[Android] Refactoring for different engines

[Joe Bowser <bo...@gmail.com>]

So, after looking at the Crosswalk code again, I've decided to take a
quick stab at making things pluggable.  I don't have a lot to show for
it, but with the help of Eclipse (which is why the generated
interfaces look so screwed up), I managed to create some interfaces so
we can start shoehorning in other browser renderers.

https://github.com/infil00p/cordova-android/tree/pluggable_webview

I'm going to probably start with Crosswalk, because it's probably the
most mature primary candidate in the Android Third-Party WebView
thing, and I'm pretty sure the GeckoView will be happening shortly
after.

I don't know how this would work w.r.t. the CLI or our workflow at
all, but at the moment, I really just want to at least start to have
some headway towards 4.x and PhoneGap day.

What do people think of this so far? I'm going to try to clean things
up a bit, since we've definitely done a lot of things that would make
first year CS profs freak the hell out (i.e. public members in public
objects w.r.t. PluginManager).

Thoughts?

Joe

Re: [Android] Refactoring for different engines

[Josh Soref <js...@blackberry.com>]

Hu, Ningxin wrote:
> I am in China. 1:00 PM PST means 4:00 AM here :o.
> Could you please schedule it a little bit later, say 4:00 or 5:00 PM
>PST? It will be highly appreciated.

In principle, as someone on the East Coast. I will not show up for a
meeting that might end past 5pm Eastern Time on a Friday.

I¹m not sure if someone from our team plans to attend, but there can
easily be others on the East Coast as well.

The BlackBerry team is in/around Toronto, and Bryan might want to join.
Some of Mozilla¹s mobile team is in Toronto tooŠ I¹m not sure who Brian
found.

Generally, meetings that might involve timezones should include a Doodle
poll.

Andrew Grieve used Doodle on April 15, 2014 for Re: Proposal for cli and
plugman code rearrangement
http://doodle.com/uvyr9454pvepz3a3



Best practices for a truly global team involve avoiding scheduling
meetings that end after 5PM Eastern European time on Fridays to
accommodate people around the world who might have some form of life or
religious obligations. This roughly translates to not doing meetings on
Fridays unless they¹re really early on the West Coast (around 7am).

In the case of Cordova, we don¹t seem to have anyone in Europe, so you can
relax the time zone constraint from Eastern Europe to Eastern (that buys
you about 7 hours), but it still means a hard cut off in general of 2pm
Pacific and some not particularly great hour in China. You¹re usually
better served aiming for a night owl in China (1am) which is 1pm Eastern,
and 10am Pacific.

Re: [Android] Refactoring for different engines

[Joe Bowser <bo...@gmail.com>]

I hate to say this but I think the best bet is to meet at 9 and 4.
On Apr 25, 2014 8:34 AM, "Ian Clelland" <ic...@chromium.org> wrote:

> Joe -- I'd definitely like to be able to chat with Mozilla folks as well --
> if you want to set up something for later in the day, I'll make myself
> available for that, too.
>
>
> On Fri, Apr 25, 2014 at 11:29 AM, Hu, Ningxin <ni...@intel.com>
> wrote:
>
> > I will be on hangouts at that time.
> >
> > Thanks,
> > -ningxin
> >
> > > -----Original Message-----
> > > From: Joe Bowser [mailto:bowserj@gmail.com]
> > > Sent: Friday, April 25, 2014 11:00 PM
> > > To: dev@cordova.apache.org
> > > Subject: Re: [Android] Refactoring for different engines
> > >
> > > I might be able to make it but Mozilla can't from what I heard. I don't
> > know if
> > > Brian can either.
> > > On Apr 25, 2014 6:58 AM, "Ian Clelland" <ic...@chromium.org>
> wrote:
> > >
> > > > Sounds like 09:00AM PDT
> > > > 12:00PM EDT
> > > > 00:00 China Standard Time
> > > > 16:00 UTC
> > > >
> > > > 2014-04-25T16:00:00Z
> > > >
> > > > :)
> > > >
> > > > (Based on Ningxin saying that he wasn't waiting around for the
> > > > morning)
> > > >
> > > >
> > > > On Friday, April 25, 2014, Michal Mocny <mm...@chromium.org> wrote:
> > > >
> > > > > So is it 9am PST or 4pm PST?
> > > > >
> > > > >
> > > > > On Thu, Apr 24, 2014 at 10:37 PM, Ian Clelland
> > > > > <iclelland@chromium.org
> > > > <javascript:;>
> > > > > >wrote:
> > > > >
> > > > > > I approve of that time slot. I'll be there.
> > > > > >
> > > > > > Ian
> > > > > >
> > > > > >
> > > > > > On Thu, Apr 24, 2014 at 10:32 PM, Hu, Ningxin
> > > > > > <ni...@intel.com>
> > > > > > wrote:
> > > > > >
> > > > > > > Please let me know if we agree with this time (9am Pacific,
> 12am
> > > > > Eastern
> > > > > > > and 0am China)? I will stay till mid-night, but maybe not to
> > > > > > > next
> > > > > morning
> > > > > > > :p.
> > > > > > >
> > > > > > > Thanks,
> > > > > > > -ningxin
> > > > > > >
> > > > > > > > -----Original Message-----
> > > > > > > > From: iclelland@google.com [mailto:iclelland@google.com] On
> > > > > > > > Behalf
> > > > > Of
> > > > > > > Ian
> > > > > > > > Clelland
> > > > > > > > Sent: Thursday, April 24, 2014 8:58 PM
> > > > > > > > To: dev@cordova.apache.org
> > > > > > > > Subject: Re: [Android] Refactoring for different engines
> > > > > > > >
> > > > > > > > On Thu, Apr 24, 2014 at 1:10 AM, Hu, Ningxin
> > > > > > > > <ningxin.hu@intel.com
> > > > >
> > > > > > > wrote:
> > > > > > > >
> > > > > > > > > Understood.
> > > > > > > > >
> > > > > > > > > How about 9am Pacific, 12am Eastern and 0am China? Really
> > > > > appreciate.
> > > > > > > > >
> > > > > > > >
> > > > > > > > That time would probably work better for me than 7 hours
> later.
> > > > > > > >
> > > > > > > > Ian
> > > > > > > >
> > > > > > > >
> > > > > > > > >
> > > > > > > > > Thanks,
> > > > > > > > > -ningxin
> > > > > > > > >
> > > > > > > > > > -----Original Message-----
> > > > > > > > > > From: mmocny@google.com [mailto:mmocny@google.com] On
> > > > > > > > > > Behalf
> > > > Of
> > > > > > > > > > Michal Mocny
> > > > > > > > > > Sent: Thursday, April 24, 2014 11:45 AM
> > > > > > > > > > To: dev
> > > > > > > > > > Subject: Re: [Android] Refactoring for different engines
> > > > > > > > > >
> > > > > > > > > > (Yeah 7pm Friday is more naughty than 4am for those of us
> > > > > > > > > > with
> > > > > > > > > > families.)
> > > > > > > > > >
> > > > > > > > > > I think the original intent was just supposed to be a
> meet
> > > > > > > > > > &
> > > > > greet
> > > > > > > right?
> > > > > > > > > >  Lets just do it asap and consider formal scheduling with
> > > > > > > > > > ample planning
> > > > > > > > > only if
> > > > > > > > > > there are technical topics to discuss.
> > > > > > > > > >
> > > > > > > > > > It would be nice, though, if Ian could make it, given his
> > > > recent
> > > > > > > > > > work on
> > > > > > > > > this.
> > > > > > > > > >
> > > > > > > > > > -Michal
> > > > > > > > > >
> > > > > > > > > >
> > > > > > > > > > On Wed, Apr 23, 2014 at 10:34 PM, Victor Sosa
> > > > > > > > > ><sosah.victor@gmail.com
> > > > > > > > > >wrote:
> > > > > > > > > >
> > > > > > > > > > > 4PM PST? That's 6 CST or 7 EST, me thinks. Seems to
> work
> > > > > > > > > > > for
> > > > > many
> > > > > > > > > > > of us On Apr 23, 2014 8:49 PM, "Brian LeRoux"
> > > > > > > > > > > <b...@brian.io>
> > > > > > wrote:
> > > > > > > > > > >
> > > > > > > > > > > > 4pm works for me…
> > > > > > > > > > > >
> > > > > > > > > > > >
> > > > > > > > > > > > On Wed, Apr 23, 2014 at 6:19 PM, Hu, Ningxin
> > > > > > > > > > > > <ni...@intel.com>
> > > > > > > > > > > wrote:
> > > > > > > > > > > >
> > > > > > > > > > > > > I am in China. 1:00 PM PST means 4:00 AM here :o.
> > > > > > > > > > > > > Could you please schedule it a little bit later,
> say
> > > > > > > > > > > > > 4:00
> > > > > or
> > > > > > > > > > > > > 5:00 PM
> > > > > > > > > > > PST?
> > > > > > > > > > > > > It will be highly appreciated.
> > > > > > > > > > > > >
> > > > > > > > > > > > > Thanks,
> > > > > > > > > > > > > -ningxin
> > > > > > > > > > > > >
> > > > > > > > > > > > > From:
> > > >
> >
>

Re: [Android] Refactoring for different engines

[Ian Clelland <ic...@chromium.org>]

Joe -- I'd definitely like to be able to chat with Mozilla folks as well --
if you want to set up something for later in the day, I'll make myself
available for that, too.


On Fri, Apr 25, 2014 at 11:29 AM, Hu, Ningxin <ni...@intel.com> wrote:

> I will be on hangouts at that time.
>
> Thanks,
> -ningxin
>
> > -----Original Message-----
> > From: Joe Bowser [mailto:bowserj@gmail.com]
> > Sent: Friday, April 25, 2014 11:00 PM
> > To: dev@cordova.apache.org
> > Subject: Re: [Android] Refactoring for different engines
> >
> > I might be able to make it but Mozilla can't from what I heard. I don't
> know if
> > Brian can either.
> > On Apr 25, 2014 6:58 AM, "Ian Clelland" <ic...@chromium.org> wrote:
> >
> > > Sounds like 09:00AM PDT
> > > 12:00PM EDT
> > > 00:00 China Standard Time
> > > 16:00 UTC
> > >
> > > 2014-04-25T16:00:00Z
> > >
> > > :)
> > >
> > > (Based on Ningxin saying that he wasn't waiting around for the
> > > morning)
> > >
> > >
> > > On Friday, April 25, 2014, Michal Mocny <mm...@chromium.org> wrote:
> > >
> > > > So is it 9am PST or 4pm PST?
> > > >
> > > >
> > > > On Thu, Apr 24, 2014 at 10:37 PM, Ian Clelland
> > > > <iclelland@chromium.org
> > > <javascript:;>
> > > > >wrote:
> > > >
> > > > > I approve of that time slot. I'll be there.
> > > > >
> > > > > Ian
> > > > >
> > > > >
> > > > > On Thu, Apr 24, 2014 at 10:32 PM, Hu, Ningxin
> > > > > <ni...@intel.com>
> > > > > wrote:
> > > > >
> > > > > > Please let me know if we agree with this time (9am Pacific, 12am
> > > > Eastern
> > > > > > and 0am China)? I will stay till mid-night, but maybe not to
> > > > > > next
> > > > morning
> > > > > > :p.
> > > > > >
> > > > > > Thanks,
> > > > > > -ningxin
> > > > > >
> > > > > > > -----Original Message-----
> > > > > > > From: iclelland@google.com [mailto:iclelland@google.com] On
> > > > > > > Behalf
> > > > Of
> > > > > > Ian
> > > > > > > Clelland
> > > > > > > Sent: Thursday, April 24, 2014 8:58 PM
> > > > > > > To: dev@cordova.apache.org
> > > > > > > Subject: Re: [Android] Refactoring for different engines
> > > > > > >
> > > > > > > On Thu, Apr 24, 2014 at 1:10 AM, Hu, Ningxin
> > > > > > > <ningxin.hu@intel.com
> > > >
> > > > > > wrote:
> > > > > > >
> > > > > > > > Understood.
> > > > > > > >
> > > > > > > > How about 9am Pacific, 12am Eastern and 0am China? Really
> > > > appreciate.
> > > > > > > >
> > > > > > >
> > > > > > > That time would probably work better for me than 7 hours later.
> > > > > > >
> > > > > > > Ian
> > > > > > >
> > > > > > >
> > > > > > > >
> > > > > > > > Thanks,
> > > > > > > > -ningxin
> > > > > > > >
> > > > > > > > > -----Original Message-----
> > > > > > > > > From: mmocny@google.com [mailto:mmocny@google.com] On
> > > > > > > > > Behalf
> > > Of
> > > > > > > > > Michal Mocny
> > > > > > > > > Sent: Thursday, April 24, 2014 11:45 AM
> > > > > > > > > To: dev
> > > > > > > > > Subject: Re: [Android] Refactoring for different engines
> > > > > > > > >
> > > > > > > > > (Yeah 7pm Friday is more naughty than 4am for those of us
> > > > > > > > > with
> > > > > > > > > families.)
> > > > > > > > >
> > > > > > > > > I think the original intent was just supposed to be a meet
> > > > > > > > > &
> > > > greet
> > > > > > right?
> > > > > > > > >  Lets just do it asap and consider formal scheduling with
> > > > > > > > > ample planning
> > > > > > > > only if
> > > > > > > > > there are technical topics to discuss.
> > > > > > > > >
> > > > > > > > > It would be nice, though, if Ian could make it, given his
> > > recent
> > > > > > > > > work on
> > > > > > > > this.
> > > > > > > > >
> > > > > > > > > -Michal
> > > > > > > > >
> > > > > > > > >
> > > > > > > > > On Wed, Apr 23, 2014 at 10:34 PM, Victor Sosa
> > > > > > > > ><sosah.victor@gmail.com
> > > > > > > > >wrote:
> > > > > > > > >
> > > > > > > > > > 4PM PST? That's 6 CST or 7 EST, me thinks. Seems to work
> > > > > > > > > > for
> > > > many
> > > > > > > > > > of us On Apr 23, 2014 8:49 PM, "Brian LeRoux"
> > > > > > > > > > <b...@brian.io>
> > > > > wrote:
> > > > > > > > > >
> > > > > > > > > > > 4pm works for me…
> > > > > > > > > > >
> > > > > > > > > > >
> > > > > > > > > > > On Wed, Apr 23, 2014 at 6:19 PM, Hu, Ningxin
> > > > > > > > > > > <ni...@intel.com>
> > > > > > > > > > wrote:
> > > > > > > > > > >
> > > > > > > > > > > > I am in China. 1:00 PM PST means 4:00 AM here :o.
> > > > > > > > > > > > Could you please schedule it a little bit later, say
> > > > > > > > > > > > 4:00
> > > > or
> > > > > > > > > > > > 5:00 PM
> > > > > > > > > > PST?
> > > > > > > > > > > > It will be highly appreciated.
> > > > > > > > > > > >
> > > > > > > > > > > > Thanks,
> > > > > > > > > > > > -ningxin
> > > > > > > > > > > >
> > > > > > > > > > > > From:
> > >
>

RE: [Android] Refactoring for different engines

["Hu, Ningxin" <ni...@intel.com>]

I will be on hangouts at that time.

Thanks,
-ningxin

> -----Original Message-----
> From: Joe Bowser [mailto:bowserj@gmail.com]
> Sent: Friday, April 25, 2014 11:00 PM
> To: dev@cordova.apache.org
> Subject: Re: [Android] Refactoring for different engines
> 
> I might be able to make it but Mozilla can't from what I heard. I don't know if
> Brian can either.
> On Apr 25, 2014 6:58 AM, "Ian Clelland" <ic...@chromium.org> wrote:
> 
> > Sounds like 09:00AM PDT
> > 12:00PM EDT
> > 00:00 China Standard Time
> > 16:00 UTC
> >
> > 2014-04-25T16:00:00Z
> >
> > :)
> >
> > (Based on Ningxin saying that he wasn't waiting around for the
> > morning)
> >
> >
> > On Friday, April 25, 2014, Michal Mocny <mm...@chromium.org> wrote:
> >
> > > So is it 9am PST or 4pm PST?
> > >
> > >
> > > On Thu, Apr 24, 2014 at 10:37 PM, Ian Clelland
> > > <iclelland@chromium.org
> > <javascript:;>
> > > >wrote:
> > >
> > > > I approve of that time slot. I'll be there.
> > > >
> > > > Ian
> > > >
> > > >
> > > > On Thu, Apr 24, 2014 at 10:32 PM, Hu, Ningxin
> > > > <ni...@intel.com>
> > > > wrote:
> > > >
> > > > > Please let me know if we agree with this time (9am Pacific, 12am
> > > Eastern
> > > > > and 0am China)? I will stay till mid-night, but maybe not to
> > > > > next
> > > morning
> > > > > :p.
> > > > >
> > > > > Thanks,
> > > > > -ningxin
> > > > >
> > > > > > -----Original Message-----
> > > > > > From: iclelland@google.com [mailto:iclelland@google.com] On
> > > > > > Behalf
> > > Of
> > > > > Ian
> > > > > > Clelland
> > > > > > Sent: Thursday, April 24, 2014 8:58 PM
> > > > > > To: dev@cordova.apache.org
> > > > > > Subject: Re: [Android] Refactoring for different engines
> > > > > >
> > > > > > On Thu, Apr 24, 2014 at 1:10 AM, Hu, Ningxin
> > > > > > <ningxin.hu@intel.com
> > >
> > > > > wrote:
> > > > > >
> > > > > > > Understood.
> > > > > > >
> > > > > > > How about 9am Pacific, 12am Eastern and 0am China? Really
> > > appreciate.
> > > > > > >
> > > > > >
> > > > > > That time would probably work better for me than 7 hours later.
> > > > > >
> > > > > > Ian
> > > > > >
> > > > > >
> > > > > > >
> > > > > > > Thanks,
> > > > > > > -ningxin
> > > > > > >
> > > > > > > > -----Original Message-----
> > > > > > > > From: mmocny@google.com [mailto:mmocny@google.com] On
> > > > > > > > Behalf
> > Of
> > > > > > > > Michal Mocny
> > > > > > > > Sent: Thursday, April 24, 2014 11:45 AM
> > > > > > > > To: dev
> > > > > > > > Subject: Re: [Android] Refactoring for different engines
> > > > > > > >
> > > > > > > > (Yeah 7pm Friday is more naughty than 4am for those of us
> > > > > > > > with
> > > > > > > > families.)
> > > > > > > >
> > > > > > > > I think the original intent was just supposed to be a meet
> > > > > > > > &
> > > greet
> > > > > right?
> > > > > > > >  Lets just do it asap and consider formal scheduling with
> > > > > > > > ample planning
> > > > > > > only if
> > > > > > > > there are technical topics to discuss.
> > > > > > > >
> > > > > > > > It would be nice, though, if Ian could make it, given his
> > recent
> > > > > > > > work on
> > > > > > > this.
> > > > > > > >
> > > > > > > > -Michal
> > > > > > > >
> > > > > > > >
> > > > > > > > On Wed, Apr 23, 2014 at 10:34 PM, Victor Sosa
> > > > > > > ><sosah.victor@gmail.com
> > > > > > > >wrote:
> > > > > > > >
> > > > > > > > > 4PM PST? That's 6 CST or 7 EST, me thinks. Seems to work
> > > > > > > > > for
> > > many
> > > > > > > > > of us On Apr 23, 2014 8:49 PM, "Brian LeRoux"
> > > > > > > > > <b...@brian.io>
> > > > wrote:
> > > > > > > > >
> > > > > > > > > > 4pm works for me…
> > > > > > > > > >
> > > > > > > > > >
> > > > > > > > > > On Wed, Apr 23, 2014 at 6:19 PM, Hu, Ningxin
> > > > > > > > > > <ni...@intel.com>
> > > > > > > > > wrote:
> > > > > > > > > >
> > > > > > > > > > > I am in China. 1:00 PM PST means 4:00 AM here :o.
> > > > > > > > > > > Could you please schedule it a little bit later, say
> > > > > > > > > > > 4:00
> > > or
> > > > > > > > > > > 5:00 PM
> > > > > > > > > PST?
> > > > > > > > > > > It will be highly appreciated.
> > > > > > > > > > >
> > > > > > > > > > > Thanks,
> > > > > > > > > > > -ningxin
> > > > > > > > > > >
> > > > > > > > > > > From:
> >

Re: [Android] Refactoring for different engines

[Joe Bowser <bo...@gmail.com>]

I might be able to make it but Mozilla can't from what I heard. I don't
know if Brian can either.
On Apr 25, 2014 6:58 AM, "Ian Clelland" <ic...@chromium.org> wrote:

> Sounds like 09:00AM PDT
> 12:00PM EDT
> 00:00 China Standard Time
> 16:00 UTC
>
> 2014-04-25T16:00:00Z
>
> :)
>
> (Based on Ningxin saying that he wasn't waiting around for the morning)
>
>
> On Friday, April 25, 2014, Michal Mocny <mm...@chromium.org> wrote:
>
> > So is it 9am PST or 4pm PST?
> >
> >
> > On Thu, Apr 24, 2014 at 10:37 PM, Ian Clelland <iclelland@chromium.org
> <javascript:;>
> > >wrote:
> >
> > > I approve of that time slot. I'll be there.
> > >
> > > Ian
> > >
> > >
> > > On Thu, Apr 24, 2014 at 10:32 PM, Hu, Ningxin <ni...@intel.com>
> > > wrote:
> > >
> > > > Please let me know if we agree with this time (9am Pacific, 12am
> > Eastern
> > > > and 0am China)? I will stay till mid-night, but maybe not to next
> > morning
> > > > :p.
> > > >
> > > > Thanks,
> > > > -ningxin
> > > >
> > > > > -----Original Message-----
> > > > > From: iclelland@google.com [mailto:iclelland@google.com] On Behalf
> > Of
> > > > Ian
> > > > > Clelland
> > > > > Sent: Thursday, April 24, 2014 8:58 PM
> > > > > To: dev@cordova.apache.org
> > > > > Subject: Re: [Android] Refactoring for different engines
> > > > >
> > > > > On Thu, Apr 24, 2014 at 1:10 AM, Hu, Ningxin <ningxin.hu@intel.com
> >
> > > > wrote:
> > > > >
> > > > > > Understood.
> > > > > >
> > > > > > How about 9am Pacific, 12am Eastern and 0am China? Really
> > appreciate.
> > > > > >
> > > > >
> > > > > That time would probably work better for me than 7 hours later.
> > > > >
> > > > > Ian
> > > > >
> > > > >
> > > > > >
> > > > > > Thanks,
> > > > > > -ningxin
> > > > > >
> > > > > > > -----Original Message-----
> > > > > > > From: mmocny@google.com [mailto:mmocny@google.com] On Behalf
> Of
> > > > > > > Michal Mocny
> > > > > > > Sent: Thursday, April 24, 2014 11:45 AM
> > > > > > > To: dev
> > > > > > > Subject: Re: [Android] Refactoring for different engines
> > > > > > >
> > > > > > > (Yeah 7pm Friday is more naughty than 4am for those of us with
> > > > > > > families.)
> > > > > > >
> > > > > > > I think the original intent was just supposed to be a meet &
> > greet
> > > > right?
> > > > > > >  Lets just do it asap and consider formal scheduling with ample
> > > > > > > planning
> > > > > > only if
> > > > > > > there are technical topics to discuss.
> > > > > > >
> > > > > > > It would be nice, though, if Ian could make it, given his
> recent
> > > > > > > work on
> > > > > > this.
> > > > > > >
> > > > > > > -Michal
> > > > > > >
> > > > > > >
> > > > > > > On Wed, Apr 23, 2014 at 10:34 PM, Victor Sosa
> > > > > > ><sosah.victor@gmail.com
> > > > > > >wrote:
> > > > > > >
> > > > > > > > 4PM PST? That's 6 CST or 7 EST, me thinks. Seems to work for
> > many
> > > > > > > > of us On Apr 23, 2014 8:49 PM, "Brian LeRoux" <b...@brian.io>
> > > wrote:
> > > > > > > >
> > > > > > > > > 4pm works for me…
> > > > > > > > >
> > > > > > > > >
> > > > > > > > > On Wed, Apr 23, 2014 at 6:19 PM, Hu, Ningxin
> > > > > > > > > <ni...@intel.com>
> > > > > > > > wrote:
> > > > > > > > >
> > > > > > > > > > I am in China. 1:00 PM PST means 4:00 AM here :o.
> > > > > > > > > > Could you please schedule it a little bit later, say 4:00
> > or
> > > > > > > > > > 5:00 PM
> > > > > > > > PST?
> > > > > > > > > > It will be highly appreciated.
> > > > > > > > > >
> > > > > > > > > > Thanks,
> > > > > > > > > > -ningxin
> > > > > > > > > >
> > > > > > > > > > From:
>

Re: [Android] Refactoring for different engines

[Josh Soref <js...@blackberry.com>]

Ian Clelland wrote:
>Sounds like 09:00AM PDT
>12:00PM EDT
>00:00 China Standard Time
>16:00 UTC
>
>2014-04-25T16:00:00Z
>
>:)
>
>(Based on Ningxin saying that he wasn't waiting around for the morning)

Which would be now, is there a way to join this meeting?

Re: [Android] Refactoring for different engines

[Ian Clelland <ic...@chromium.org>]

Sounds like 09:00AM PDT
12:00PM EDT
00:00 China Standard Time
16:00 UTC

2014-04-25T16:00:00Z

:)

(Based on Ningxin saying that he wasn't waiting around for the morning)


On Friday, April 25, 2014, Michal Mocny <mm...@chromium.org> wrote:

> So is it 9am PST or 4pm PST?
>
>
> On Thu, Apr 24, 2014 at 10:37 PM, Ian Clelland <iclelland@chromium.org<javascript:;>
> >wrote:
>
> > I approve of that time slot. I'll be there.
> >
> > Ian
> >
> >
> > On Thu, Apr 24, 2014 at 10:32 PM, Hu, Ningxin <ni...@intel.com>
> > wrote:
> >
> > > Please let me know if we agree with this time (9am Pacific, 12am
> Eastern
> > > and 0am China)? I will stay till mid-night, but maybe not to next
> morning
> > > :p.
> > >
> > > Thanks,
> > > -ningxin
> > >
> > > > -----Original Message-----
> > > > From: iclelland@google.com [mailto:iclelland@google.com] On Behalf
> Of
> > > Ian
> > > > Clelland
> > > > Sent: Thursday, April 24, 2014 8:58 PM
> > > > To: dev@cordova.apache.org
> > > > Subject: Re: [Android] Refactoring for different engines
> > > >
> > > > On Thu, Apr 24, 2014 at 1:10 AM, Hu, Ningxin <ni...@intel.com>
> > > wrote:
> > > >
> > > > > Understood.
> > > > >
> > > > > How about 9am Pacific, 12am Eastern and 0am China? Really
> appreciate.
> > > > >
> > > >
> > > > That time would probably work better for me than 7 hours later.
> > > >
> > > > Ian
> > > >
> > > >
> > > > >
> > > > > Thanks,
> > > > > -ningxin
> > > > >
> > > > > > -----Original Message-----
> > > > > > From: mmocny@google.com [mailto:mmocny@google.com] On Behalf Of
> > > > > > Michal Mocny
> > > > > > Sent: Thursday, April 24, 2014 11:45 AM
> > > > > > To: dev
> > > > > > Subject: Re: [Android] Refactoring for different engines
> > > > > >
> > > > > > (Yeah 7pm Friday is more naughty than 4am for those of us with
> > > > > > families.)
> > > > > >
> > > > > > I think the original intent was just supposed to be a meet &
> greet
> > > right?
> > > > > >  Lets just do it asap and consider formal scheduling with ample
> > > > > > planning
> > > > > only if
> > > > > > there are technical topics to discuss.
> > > > > >
> > > > > > It would be nice, though, if Ian could make it, given his recent
> > > > > > work on
> > > > > this.
> > > > > >
> > > > > > -Michal
> > > > > >
> > > > > >
> > > > > > On Wed, Apr 23, 2014 at 10:34 PM, Victor Sosa
> > > > > ><sosah.victor@gmail.com
> > > > > >wrote:
> > > > > >
> > > > > > > 4PM PST? That's 6 CST or 7 EST, me thinks. Seems to work for
> many
> > > > > > > of us On Apr 23, 2014 8:49 PM, "Brian LeRoux" <b...@brian.io>
> > wrote:
> > > > > > >
> > > > > > > > 4pm works for me…
> > > > > > > >
> > > > > > > >
> > > > > > > > On Wed, Apr 23, 2014 at 6:19 PM, Hu, Ningxin
> > > > > > > > <ni...@intel.com>
> > > > > > > wrote:
> > > > > > > >
> > > > > > > > > I am in China. 1:00 PM PST means 4:00 AM here :o.
> > > > > > > > > Could you please schedule it a little bit later, say 4:00
> or
> > > > > > > > > 5:00 PM
> > > > > > > PST?
> > > > > > > > > It will be highly appreciated.
> > > > > > > > >
> > > > > > > > > Thanks,
> > > > > > > > > -ningxin
> > > > > > > > >
> > > > > > > > > From:

Re: [Android] Refactoring for different engines

[Michal Mocny <mm...@chromium.org>]

So is it 9am PST or 4pm PST?


On Thu, Apr 24, 2014 at 10:37 PM, Ian Clelland <ic...@chromium.org>wrote:

> I approve of that time slot. I'll be there.
>
> Ian
>
>
> On Thu, Apr 24, 2014 at 10:32 PM, Hu, Ningxin <ni...@intel.com>
> wrote:
>
> > Please let me know if we agree with this time (9am Pacific, 12am Eastern
> > and 0am China)? I will stay till mid-night, but maybe not to next morning
> > :p.
> >
> > Thanks,
> > -ningxin
> >
> > > -----Original Message-----
> > > From: iclelland@google.com [mailto:iclelland@google.com] On Behalf Of
> > Ian
> > > Clelland
> > > Sent: Thursday, April 24, 2014 8:58 PM
> > > To: dev@cordova.apache.org
> > > Subject: Re: [Android] Refactoring for different engines
> > >
> > > On Thu, Apr 24, 2014 at 1:10 AM, Hu, Ningxin <ni...@intel.com>
> > wrote:
> > >
> > > > Understood.
> > > >
> > > > How about 9am Pacific, 12am Eastern and 0am China? Really appreciate.
> > > >
> > >
> > > That time would probably work better for me than 7 hours later.
> > >
> > > Ian
> > >
> > >
> > > >
> > > > Thanks,
> > > > -ningxin
> > > >
> > > > > -----Original Message-----
> > > > > From: mmocny@google.com [mailto:mmocny@google.com] On Behalf Of
> > > > > Michal Mocny
> > > > > Sent: Thursday, April 24, 2014 11:45 AM
> > > > > To: dev
> > > > > Subject: Re: [Android] Refactoring for different engines
> > > > >
> > > > > (Yeah 7pm Friday is more naughty than 4am for those of us with
> > > > > families.)
> > > > >
> > > > > I think the original intent was just supposed to be a meet & greet
> > right?
> > > > >  Lets just do it asap and consider formal scheduling with ample
> > > > > planning
> > > > only if
> > > > > there are technical topics to discuss.
> > > > >
> > > > > It would be nice, though, if Ian could make it, given his recent
> > > > > work on
> > > > this.
> > > > >
> > > > > -Michal
> > > > >
> > > > >
> > > > > On Wed, Apr 23, 2014 at 10:34 PM, Victor Sosa
> > > > ><sosah.victor@gmail.com
> > > > >wrote:
> > > > >
> > > > > > 4PM PST? That's 6 CST or 7 EST, me thinks. Seems to work for many
> > > > > > of us On Apr 23, 2014 8:49 PM, "Brian LeRoux" <b...@brian.io>
> wrote:
> > > > > >
> > > > > > > 4pm works for me…
> > > > > > >
> > > > > > >
> > > > > > > On Wed, Apr 23, 2014 at 6:19 PM, Hu, Ningxin
> > > > > > > <ni...@intel.com>
> > > > > > wrote:
> > > > > > >
> > > > > > > > I am in China. 1:00 PM PST means 4:00 AM here :o.
> > > > > > > > Could you please schedule it a little bit later, say 4:00 or
> > > > > > > > 5:00 PM
> > > > > > PST?
> > > > > > > > It will be highly appreciated.
> > > > > > > >
> > > > > > > > Thanks,
> > > > > > > > -ningxin
> > > > > > > >
> > > > > > > > From: brian.leroux@gmail.com [mailto:brian.leroux@gmail.com]
> > > > > > > > On Behalf
> > > > > > > Of
> > > > > > > > Brian LeRoux
> > > > > > > > Sent: Thursday, April 24, 2014 6:10 AM
> > > > > > > > To: Joe Bowser
> > > > > > > > Cc: dev@cordova.apache.org; Hu, Ningxin
> > > > > > > > Subject: Re: [Android] Refactoring for different engines
> > > > > > > >
> > > > > > > > How does 1:00PST on Friday work for a hangout for everyone?
> > > > > > > >
> > > > > > > > On Wed, Apr 23, 2014 at 2:36 PM, Joe Bowser <
> bowserj@gmail.com
> > > > <mailto:
> > > > > > > > bowserj@gmail.com>> wrote:
> > > > > > > > BTW: Here's my PoC for Mozilla so far.  It's very broken!
> > > > > > > >
> > > > > > > > https://github.com/infil00p/MozillaView
> > > > > > > >
> > > > > > > >
> > > > > > > >
> > > > > > > > On Wed, Apr 23, 2014 at 10:50 AM, Brian LeRoux <b@brian.io
> > <mailto:
> > > > > > > > b@brian.io>> wrote:
> > > > > > > > > So I found a Moz hacker whom can help. what time on Fri do
> > > > > > > > > you guys
> > > > > > > want
> > > > > > > > to
> > > > > > > > > do this?
> > > > > > > > >
> > > > > > > > >
> > > > > > > > > On Wed, Apr 23, 2014 at 10:31 AM, Ian Clelland <
> > > > > > iclelland@chromium.org
> > > > > > > > <ma...@chromium.org>>
> > > > > > > > > wrote:
> > > > > > > > >>
> > > > > > > > >> I've managed to get this up and running now -- great work
> > > > > > > > >> on this,
> > > > > > > Joe!
> > > > > > > > >>
> > > > > > > > >> Mobilespec runs on my N4, with 10 failing tests: 3 in
> > > > > > > > >> contacts;
> > > > > > > > >> 7 in file-transfer. Otherwise, things seem to be working
> > > > > > > > >> pretty
> > > > well.
> > > > > > > > >>
> > > > > > > > >> I used a new build of Crosswalk, and found that the
> > > > > > > > >> embedding API
> > > > > > has
> > > > > > > > >> changed since the weekend (when Ningxin's patches
> applied).
> > > > > > > > >> I've
> > > > > > > issued
> > > > > > > > a
> > > > > > > > >> pull request at
> > > > > > > > >>
> https://github.com/infil00p/cordova-crosswalk-engine/pull/5
> > > > > > > > >> for
> > > > > > > > >> it
> > > > > > --
> > > > > > > > >>
> > > > > > > > >> I'm not sure if there's a way to keep compatibility with
> > > > > > > > >> last week's Crosswalk, or if we'd even want to. (Ningxin,
> > > > > > > > >> if you could
> > > > > > > take a
> > > > > > > > >> look at that PR and see if it makes sense, I'd appreciate
> > > > > > > > >> it)
> > > > > > > > >>
> > > > > > > > >> Joe, I also had to patch the default constructor for
> > > > > > > > XWalkCordovaWebView;
> > > > > > > > >> it wasn't creating its own client objects, so it got the
> > > > > > > > >> default
> > > > > > ones,
> > > > > > > > and
> > > > > > > > >> most of the tests were failing because some component of
> > > > > > > > >> the bridge
> > > > > > > > wan't
> > > > > > > > >> working.
> > > > > > https://github.com/infil00p/cordova-crosswalk-engine/pull/4is
> > > > > > > > >> out
> > > > > > > > >> for that.
> > > > > > > > >>
> > > > > > > > >> Count me in for the hangout -- this is exciting stuff
> > > > > > > > >>
> > > > > > > > >> Ian
> > > > > > > > >>
> > > > > > > > >>
> > > > > > > > >> On Wed, Apr 23, 2014 at 10:26 AM, Brian LeRoux <
> b@brian.io
> > > > <mailto:
> > > > > > > > b@brian.io>> wrote:
> > > > > > > > >>
> > > > > > > > >> > Yup I'll track em down
> > > > > > > > >> > On Apr 23, 2014 7:17 AM, "Andrew Grieve"
> > > > > > > > >> > <agrieve@chromium.org
> > > > > > > > <ma...@chromium.org>> wrote:
> > > > > > > > >> >
> > > > > > > > >> > > Does anyone have a contact at moz that we could
> invite?
> > > > > > > > >> > >
> > > > > > > > >> > > On Wed, Apr 23, 2014 at 10:09 AM, Andrew Grieve <
> > > > > > > > agrieve@chromium.org<ma...@chromium.org>>
> > > > > > > > >> > > wrote:
> > > > > > > > >> > > > Depends on their interest level I think. Faster we
> > > > > > > > >> > > > can get
> > > > > > this
> > > > > > > > out
> > > > > > > > >> > > > the door the better. If we need to delay for
> > > > > > > > >> > > > geckoview, then I
> > > > > > > > don't
> > > > > > > > >> > > > think we should gate on it, just release it after.
> > > > > > > > >> > > >
> > > > > > > > >> > > > On Wed, Apr 23, 2014 at 3:01 AM, Tommy Williams <
> > > > > > > > tommy@devgeeks.org<ma...@devgeeks.org>>
> > > > > > > > >> > > wrote:
> > > > > > > > >> > > >> More engines, more better...
> > > > > > > > >> > > >> On 23 Apr 2014 16:32, "Joe Bowser"
> > > > > > > > >> > > >> <bowserj@gmail.com
> > > > > > <mailto:
> > > > > > > > bowserj@gmail.com>> wrote:
> > > > > > > > >> > > >>
> > > > > > > > >> > > >>> Hey
> > > > > > > > >> > > >>>
> > > > > > > > >> > > >>> A Hangout would have to happen on Friday at the
> > > > earliest.
> > > > > > >  It'd
> > > > > > > > be
> > > > > > > > >> > > good if
> > > > > > > > >> > > >>> we could get someone from Mozilla on the hangout
> as
> > > > > > > > >> > > >>> well.  I haven't
> > > > > > > > >> > > gotten
> > > > > > > > >> > > >>> MozillaView (GeckoView with Cordova methods) fully
> > > > > > > > >> > > >>> working
> > > > > > > yet.
> > > > > > > > >> > > >>> For
> > > > > > > > >> > > some
> > > > > > > > >> > > >>> reason it's not rendering on the screen.
> > > > > > > > >> > > >>>
> > > > > > > > >> > > >>> Ideally it'd be cool to have at least two options
> > > > > > > > >> > > >>> when this feature
> > > > > > > > >> > > finally
> > > > > > > > >> > > >>> lands.
> > > > > > > > >> > > >>>
> > > > > > > > >> > > >>> What do other people think?
> > > > > > > > >> > > >>>
> > > > > > > > >> > > >>> Joe
> > > > > > > > >> > > >>> On 22 Apr 2014 20:06, "Hu, Ningxin"
> > > > > > > > >> > > >>> <ningxin.hu@intel.com
> > > > > > > > <ma...@intel.com>> wrote:
> > > > > > > > >> > > >>>
> > > > > > > > >> > > >>> > Joe,
> > > > > > > > >> > > >>> >
> > > > > > > > >> > > >>> > Thanks for your review and merge the PRs.
> > > > > > > > >> > > >>> >
> > > > > > > > >> > > >>> > To pluggable webview interest group:
> > > > > > > > >> > > >>> > Are we OK to setup a hangout this week for
> > > > > > > > >> > > >>> > initial
> > > > > > > > introduction
> > > > > > > > >> > > >>> > and
> > > > > > > > >> > > >>> > discussion of next steps?
> > > > > > > > >> > > >>> >
> > > > > > > > >> > > >>> > Thanks,
> > > > > > > > >> > > >>> > -ningxin
> > > > > > > > >> > > >>> >
> > > > > > > > >> > > >>> > > -----Original Message-----
> > > > > > > > >> > > >>> > > From: Hu, Ningxin [mailto:
> ningxin.hu@intel.com
> > > > <mailto:
> > > > > > > > ningxin.hu@intel.com>]
> > > > > > > > >> > > >>> > > Sent: Tuesday, April 22, 2014 4:04 PM
> > > > > > > > >> > > >>> > > To: dev@cordova.apache.org<mailto:
> > > > > > dev@cordova.apache.org>
> > > > > > > > >> > > >>> > > Subject: RE: [Android] Refactoring for
> > > > > > > > >> > > >>> > > different engines
> > > > > > > > >> > > >>> > >
> > > > > > > > >> > > >>> > > The PoC is great! Quite excited about the
> > direction!
> > > > > > > > >> > > >>> > >
> > > > > > > > >> > > >>> > > I've sent a PR to update the
> > > > > > > > >> > > >>> > > cordova-crosswalk-engine to latest
> > > > > > > > >> > > >>> crosswalk
> > > > > > > > >> > > >>> > > embedding API. It works with
> xwalk_core_library
> > > > > > > > >> > > >>> > > at
> > > > > > > > 6.35.124.0.
> > > > > > > > >> > > >>> > >
> > > > > > > > >> > > >>> > > I've also changed the CordovaWebView interface
> > > > > > > > >> > > >>> > > slightly (adding
> > > > > > > > >> > > >>> > getView() API)
> > > > > > > > >> > > >>> > > to allow XWalkCordovaWebView to composite a
> > > > > > > > >> > > >>> > > XWalkView
> > > > > > > > instead
> > > > > > > > >> > > >>> > > of
> > > > > > > > >> > > >>> > extending
> > > > > > > > >> > > >>> > > it. It resolves some API naming issues for
> > > > > > > > >> > > >>> > > XWalkView
> > > > > > case.
> > > > > > > > >> > > >>> > >
> > > > > > > > >> > > >>> > > Please review them at:
> > > > > > > > >> > > >>> > >
> > > > > > > https://github.com/infil00p/cordova-crosswalk-engine/pull/3
> > > > > > > > >> > > >>> > >
> https://github.com/infil00p/cordova-android/pul
> > > > > > > > >> > > >>> > > l/2
> > > > > > > > >> > > >>> > >
> > > > > > > > >> > > >>> > > Thanks,
> > > > > > > > >> > > >>> > > -ningxin
> > > > > > > > >> > > >>> > >
> > > > > > > > >> > > >>> > > > -----Original Message-----
> > > > > > > > >> > > >>> > > > From: Joe Bowser [mailto:bowserj@gmail.com
> > > > <mailto:
> > > > > > > > bowserj@gmail.com>]
> > > > > > > > >> > > >>> > > > Sent: Friday, April 11, 2014 12:45 AM
> > > > > > > > >> > > >>> > > > To: dev
> > > > > > > > >> > > >>> > > > Subject: Re: [Android] Refactoring for
> > > > > > > > >> > > >>> > > > different
> > > > > > engines
> > > > > > > > >> > > >>> > > >
> > > > > > > > >> > > >>> > > > Yeah, I'd be cool with setting up a hangout.
> > > > > > > > >> > > >>> > > > Everyone should
> > > > > > > > >> > > take a
> > > > > > > > >> > > >>> > > > look at the PoC, I've basically distilled it
> > > > > > > > >> > > >>> > > > down to
> > > > > > > four
> > > > > > > > or
> > > > > > > > >> > five
> > > > > > > > >> > > >>> > > > classes so far, but with some work, we may
> be
> > > > > > > > >> > > >>> > > > able to
> > > > > > > get
> > > > > > > > it
> > > > > > > > >> > > down to
> > > > > > > > >> > > >>> > > > three.  Due to legacy, we're pretty stuck
> > > > > > > > >> > > >>> > > > with the
> > > > > > > Android
> > > > > > > > >> > > WebView
> > > > > > > > >> > > >>> API
> > > > > > > > >> > > >>> > calls,
> > > > > > > > >> > > >>> > > but these can probably be modified.
> > > > > > > > >> > > >>> > > >
> > > > > > > > >> > > >>> > > > It'd be good to get Mozilla people on the
> > > > > > > > >> > > >>> > > > call as
> > > > > > well,
> > > > > > > > >> > > >>> > > > since
> > > > > > > > >> > > they
> > > > > > > > >> > > >>> > > > have their WebView as well.
> > > > > > > > >> > > >>> > > >
> > > > > > > > >> > > >>> > > > On Thu, Apr 10, 2014 at 9:38 AM, Hu, Ningxin
> > > > > > > > >> > > >>> > > > <
> > > > > > > > >> > > ningxin.hu@intel.com<ma...@intel.com>>
> > > > > > > > >> > > >>> > wrote:
> > > > > > > > >> > > >>> > > > > Hangout would be a good idea.
> > > > > > > > >> > > >>> > > > >
> > > > > > > > >> > > >>> > > > > FYI, I will be off next week. How about
> the
> > > > > > > > >> > > >>> > > > > week
> > > > > > after
> > > > > > > > >> > > >>> > > > > next?
> > > > > > > > >> > > If it
> > > > > > > > >> > > >>> > > > > works, please
> > > > > > > > >> > > >>> > > > feel free to schedule one and count me in.
> > > > > > > > >> > > >>> > > > >
> > > > > > > > >> > > >>> > > > > Thanks,
> > > > > > > > >> > > >>> > > > > -ningxin
> > > > > > > > >> > > >>> > > > >
> > > > > > > > >> > > >>> > > > >> -----Original Message-----
> > > > > > > > >> > > >>> > > > >> From:
> > > > > > > > >> > > >>> > > > >> mmocny@google.com<mailto:
> mmocny@google.com
> > > > > > > > >> > > >>> > > > >> >
> > > > > > > > [mailto:mmocny@google.com<ma...@google.com>] On
> > > > > > > > >> > Behalf
> > > > > > > > >> > > Of
> > > > > > > > >> > > >>> > > > >> Michal Mocny
> > > > > > > > >> > > >>> > > > >> Sent: Tuesday, April 08, 2014 11:39 PM
> > > > > > > > >> > > >>> > > > >> To: dev
> > > > > > > > >> > > >>> > > > >> Subject: Re: [Android] Refactoring for
> > > > > > > > >> > > >>> > > > >> different
> > > > > > > > engines
> > > > > > > > >> > > >>> > > > >>
> > > > > > > > >> > > >>> > > > >> Would it be alright to set up a Hangout
> > > > > > > > >> > > >>> > > > >> some time
> > > > > > to
> > > > > > > > >> > introduce
> > > > > > > > >> > > >>> > everyone?
> > > > > > > > >> > > >>> > > > >>
> > > > > > > > >> > > >>> > > > >> Joe has been leading the effort here, but
> > > > > > > > >> > > >>> > > > >> there are
> > > > > > > > other
> > > > > > > > >> > > cordova
> > > > > > > > >> > > >>> > > > >> contributors for whom this is top
> priority.
> > > > > > > > >> > > >>> > > > >> It
> > > > > > would
> > > > > > > > be
> > > > > > > > >> > nice
> > > > > > > > >> > > if
> > > > > > > > >> > > >>> we
> > > > > > > > >> > > >>> > > > >> could all meet to say hello and make sure
> > > > > > > > >> > > >>> > > > >> we are
> > > > > > all
> > > > > > > > >> > > >>> > > > >> going
> > > > > > > > >> > in
> > > > > > > > >> > > the
> > > > > > > > >> > > >>> > > > >> right
> > > > > > > > >> > > >>> > > > direction.
> > > > > > > > >> > > >>> > > > >>
> > > > > > > > >> > > >>> > > > >> Quite exciting!
> > > > > > > > >> > > >>> > > > >>
> > > > > > > > >> > > >>> > > > >> -Michal
> > > > > > > > >> > > >>> > > > >>
> > > > > > > > >> > > >>> > > > >>
> > > > > > > > >> > > >>> > > > >> On Tue, Apr 8, 2014 at 10:56 AM, Hu,
> > > > > > > > >> > > >>> > > > >> Ningxin <
> > > > > > > > >> > > >>> ningxin.hu@intel.com<mailto:ningxin.hu@intel.com
> >>
> > > > > > > > >> > > >>> > > wrote:
> > > > > > > > >> > > >>> > > > >>
> > > > > > > > >> > > >>> > > > >> > Joe, thanks for this. I am very
> excited.
> > > > > > > > >> > > >>> > > > >> >
> > > > > > > > >> > > >>> > > > >> > FYI. Crosswalk team is working on
> > > > > > > > >> > > >>> > > > >> > refactoring the WebView
> > > > > > > > >> > > API to
> > > > > > > > >> > > >>> > > > >> > support embedding usage better [1].
> > > > > > > > >> > > >>> > > > >> > (Previously
> > > > > > the
> > > > > > > > >> > > >>> > > > >> > layer
> > > > > > > > >> > > API
> > > > > > > > >> > > >>> was
> > > > > > > > >> > > >>> > > > >> > not exposed as public usage).
> > > > > > > > >> > > >>> > > > >> >
> > > > > > > > >> > > >>> > > > >> > I would like to review the PoC and work
> > > > > > > > >> > > >>> > > > >> > with you
> > > > > > to
> > > > > > > > get
> > > > > > > > >> > > >>> Crosswalk
> > > > > > > > >> > > >>> > > > >> > fits into the pluggable WebView
> > architecture.
> > > > > > > > >> > > >>> > > > >> >
> > > > > > > > >> > > >>> > > > >> > Thanks,
> > > > > > > > >> > > >>> > > > >> > -ningxin
> > > > > > > > >> > > >>> > > > >> >
> > > > > > > > >> > > >>> > > > >> > > -----Original Message-----
> > > > > > > > >> > > >>> > > > >> > > From: Joe Bowser
> > > > > > > > >> > > >>> > > > >> > > [mailto:bowserj@gmail.com
> > > > > > > <mailto:
> > > > > > > > bowserj@gmail.com>]
> > > > > > > > >> > > >>> > > > >> > > Sent: Wednesday, March 19, 2014 7:08
> > > > > > > > >> > > >>> > > > >> > > AM
> > > > > > > > >> > > >>> > > > >> > > To: dev
> > > > > > > > >> > > >>> > > > >> > > Subject: Re: [Android] Refactoring
> for
> > > > > > different
> > > > > > > > >> > > >>> > > > >> > > engines
> > > > > > > > >> > > >>> > > > >> > >
> > > > > > > > >> > > >>> > > > >> > > Hey
> > > > > > > > >> > > >>> > > > >> > >
> > > > > > > > >> > > >>> > > > >> > > After debugging, I did some minor
> > > > > > > > >> > > >>> > > > >> > > updates to
> > > > > > the
> > > > > > > > >> > > >>> > > > >> > > plugin
> > > > > > > > >> > > >>> README.
> > > > > > > > >> > > >>> > > > >> > > It
> > > > > > > > >> > > >>> > > > >> > should be
> > > > > > > > >> > > >>> > > > >> > > easier to get this up and running,
> > > > > > > > >> > > >>> > > > >> > > although
> > > > > > > there's
> > > > > > > > >> > still
> > > > > > > > >> > > the
> > > > > > > > >> > > >>> > > > >> > > issue of
> > > > > > > > >> > > >>> > > > >> > after-install
> > > > > > > > >> > > >>> > > > >> > > hooks and the relative path weirdness
> > > > > > > > >> > > >>> > > > >> > > with the Crosswalk
> > > > > > > > >> > > >>> > Library itself.
> > > > > > > > >> > > >>> > > > >> > >
> > > > > > > > >> > > >>> > > > >> > > It still doesn't support the CLI at
> > > > > > > > >> > > >>> > > > >> > > all, but it should
> > > > > > > > >> > be
> > > > > > > > >> > > >>> there
> > > > > > > > >> > > >>> > > > >> > > with the
> > > > > > > > >> > > >>> > > > >> > old flow.
> > > > > > > > >> > > >>> > > > >> > >
> > > > > > > > >> > > >>> > > > >> > > On Mon, Mar 17, 2014 at 1:14 PM,
> > > > > > > > >> > > >>> > > > >> > > Michal Mocny
> > > > > > > > >> > > >>> > > > >> > > <mmocny@chromium.org<mailto:
> > > > > > mmocny@chromium.org
> > > > > > > >>
> > > > > > > > >> > > >>> > > > >> > > wrote:
> > > > > > > > >> > > >>> > > > >> > > > (Sorry Joe, Googlers are down in
> > > > > > > > >> > > >>> > > > >> > > > California
> > > > > > and
> > > > > > > > way
> > > > > > > > >> > > busy.
> > > > > > > > >> > > >>> > > > >> > > > Will be back in a week.  Super
> > > > > > > > >> > > >>> > > > >> > > > excited about
> > > > > > > > this,
> > > > > > > > >> > > though.)
> > > > > > > > >> > > >>> > > > >> > > >
> > > > > > > > >> > > >>> > > > >> > > > -Michal
> > > > > > > > >> > > >>> > > > >> > > >
> > > > > > > > >> > > >>> > > > >> > > >
> > > > > > > > >> > > >>> > > > >> > > > On Mon, Mar 17, 2014 at 2:53 PM,
> Joe
> > > > > > > > >> > > >>> > > > >> > > > Bowser
> > > > > > > > >> > > >>> > > > >> > > > <bowserj@gmail.com<mailto:
> > bowserj@gmail.
> > > > > > > > >> > > >>> > > > >> > > > com
> > > > > > >>
> > > > > > > > >> > > >>> > > > >> wrote:
> > > > > > > > >> > > >>> > > > >> > > >
> > > > > > > > >> > > >>> > > > >> > > >> Reviving this thread!
> > > > > > > > >> > > >>> > > > >> > > >>
> > > > > > > > >> > > >>> > > > >> > > >> Can other people look at this, and
> > > > > > > > >> > > >>> > > > >> > > >> see
> > > > > > if/when
> > > > > > > > we
> > > > > > > > >> > > should
> > > > > > > > >> > > >>> > land this?
> > > > > > > > >> > > >>> > > > >> > > >> I know that I have to re-write the
> > > > > > > > >> > > >>> > > > >> > > >> tests
> > > > > > > still,
> > > > > > > > >> > > >>> > > > >> > > >> but I
> > > > > > > > >> > > would
> > > > > > > > >> > > >>> > > > >> > > >> like some feedback before merging
> > it in.
> > > > > > >  Also,
> > > > > > > > >> > > >>> > > > >> > > >> it'd
> > > > > > > > >> > be
> > > > > > > > >> > > >>> > > > >> > > >> super awesome if other people
> could
> > > > > > > > >> > > >>> > > > >> > > >> try and
> > > > > > > > make a
> > > > > > > > >> > > WebView
> > > > > > > > >> > > >>> > > > >> > > >> based on the interfaces and
> > > > > > > > >> > > >>> > > > >> > > >> recommend which methods
> > > > > > > > >> > > should
> > > > > > > > >> > > >>> > > > >> > > >> die.  I want to get this released
> > > > > > > > >> > > >>> > > > >> > > >> in the
> > > > > > next
> > > > > > > > >> > > >>> > > > >> > > >> month
> > > > > > > > >> > or
> > > > > > > > >> > > so,
> > > > > > > > >> > > >>> > > > >> > > >> so any time and feedback would be
> > > > > > > > >> > > >>> > > > >> > > >> greatly
> > > > > > > > >> > appreciated.
> > > > > > > > >> > > >>> > > > >> > > >>
> > > > > > > > >> > > >>> > > > >> > > >> Thanks
> > > > > > > > >> > > >>> > > > >> > > >>
> > > > > > > > >> > > >>> > > > >> > > >> On Thu, Mar 13, 2014 at 3:50 PM,
> > > > > > > > >> > > >>> > > > >> > > >> Joe Bowser
> > > > > > > > >> > > >>> > > > >> > > >> <bowserj@gmail.com<mailto:
> bowserj@g
> > > > > > > > >> > > >>> > > > >> > > >> mail .com
> > > > > > >>
> > > > > > > > >> > > >>> > > > >> > wrote:
> > > > > > > > >> > > >>> > > > >> > > >> > Hey, I created the following
> > > > > > > > >> > > >>> > > > >> > > >> > today to
> > > > > > track
> > > > > > > > >> > > >>> > > > >> > > >> > various WebView
> > > > > > > > >> > > >>> > > > >> > progresses:
> > > > > > > > >> > > >>> > > > >> > > >> >
> > > > > > > https://issues.apache.org/jira/browse/CB-6246
> > > > > > > > >> > > >>> > > > >> > > >> >
> > > > > > > > >> > > >>> > > > >> > > >> > I also have this repo created.
> > > > > > > > >> > > >>> > > > >> > > >> > The
> > > > > > > licensing
> > > > > > > > is
> > > > > > > > >> > > ugly as
> > > > > > > > >> > > >>> > > > >> > > >> > all crap, but it's a
> > Proof-Of-Concept:
> > > > > > > > >> > > >>> > > > >> > > >> >
> > > > > > > > >> > https://github.com/infil00p/cordova-crosswalk-engine
> > > > > > > > >> > > >>> > > > >> > > >> >
> > > > > > > > >> > > >>> > > > >> > > >> > If I can get some help getting
> > > > plugman to
> > > > > > > just
> > > > > > > > >> > > >>> > > > >> > > >> > load Crosswalk, it'll
> > > > > > > > >> > > >>> > > > >> > > >> look hawt.
> > > > > > > > >> > > >>> > > > >> > > >> >
> > > > > > > > >> > > >>> > > > >> > > >> > BTW: We should probably get this
> > > > ready to
> > > > > > go
> > > > > > > > >> > > >>> > > > >> > > >> > into
> > > > > > > > >> > > Android
> > > > > > > > >> > > >>> > > > >> > > >> > in the next two months and
> > deprecate
> > > > the
> > > > > > > > >> > setProperty
> > > > > > > > >> > > >>> > > > >> > > >> > methods, since all properties
> > should
> > > > be
> > > > > > > > >> > > >>> > > > >> > > >> > preferences
> > > > > > > > >> > > in
> > > > > > > > >> > > >>> > config.xml
> > > > > > > > >> > > >>> > > now.
> > > > > > > > >> > > >>> > > > >> > > >> >
> > > > > > > > >> > > >>> > > > >> > > >> > On Mon, Mar 10, 2014 at 2:42 PM,
> > Joe
> > > > > > Bowser
> > > > > > > > >> > > >>> > > > >> > > >> > <bowserj@gmail.com<mailto:
> > > > > > bowserj@gmail.com
> > > > > > > >>
> > > > > > > > >> > > >>> > > > >> > > wrote:
> > > > > > > > >> > > >>> > > > >> > > >> >> Perhaps. There would be
> > additional
> > > > > > benefits
> > > > > > > > to
> > > > > > > > >> > this
> > > > > > > > >> > > >>> > > > >> > > >> >> approach, namely fixes being
> > added to
> > > > > > that
> > > > > > > > >> > platform
> > > > > > > > >> > > more
> > > > > > > > >> > > >>> > > > >> > > >> >> quickly.  I'll probably take a
> > look
> > > > at
> > > > > > that
> > > > > > > > >> > > >>> > > > >> > > >> >> once I
> > > > > > > > >> > > have
> > > > > > > > >> > > >>> > > > >> > > >> >> Crosswalk
> > > > > > > > >> > > >>> > > > finalized.
> > > > > > > > >> > > >>> > > > >> > > >> >>
> > > > > > > > >> > > >>> > > > >> > > >> >> On Mon, Mar 10, 2014 at 9:49
> AM,
> > > > Brian
> > > > > > > LeRoux
> > > > > > > > >> > > >>> > > > >> > > >> >> <b@brian.io<mailto:b@brian.io
> >>
> > > > > > > > >> > > >>> > > > wrote:
> > > > > > > > >> > > >>> > > > >> > > >> >>> this is great stuff
> > > > > > > > >> > > >>> > > > >> > > >> >>>
> > > > > > > > >> > > >>> > > > >> > > >> >>> do we think it may be possible
> > to
> > > > bring
> > > > > > in
> > > > > > > > >> > > >>> > > > >> > > >> >>> amazon
> > > > > > > > >> > > >>> fireos
> > > > > > > > >> > > >>> > > > >> > > >> >>> stuff
> > > > > > > > >> > > >>> > > > >> > > >> eventually
> > > > > > > > >> > > >>> > > > >> > > >> >>> too?
> > > > > > > > >> > > >>> > > > >> > > >> >>>
> > > > > > > > >> > > >>> > > > >> > > >> >>>
> > > > > > > > >> > > >>> > > > >> > > >> >>> On Fri, Mar 7, 2014 at 3:22
> PM,
> > Joe
> > > > > > Bowser
> > > > > > > > >> > > >>> > > > >> > > >> >>> <bowserj@gmail.com<mailto:
> > > > > > > bowserj@gmail.com
> > > > > > > > >>
> > > > > > > > >> > > >>> > > > >> > wrote:
> > > > > > > > >> > > >>> > > > >> > > >> >>>
> > > > > > > > >> > > >>> > > > >> > > >> >>>> BTW: I committed it in my
> repo,
> > > > not the
> > > > > > > > main
> > > > > > > > >> > > Apache
> > > > > > > > >> > > >>> one.
> > > > > > > > >> > > >>> > > > >> > > >> >>>>
> > > > > > > > >> > > >>> > > > >> > > >> >>>> On Fri, Mar 7, 2014 at 3:21
> > PM, Joe
> > > > > > > Bowser
> > > > > > > > >> > > >>> > > > >> > > >> >>>> <bowserj@gmail.com<mailto:
> > > > > > > > bowserj@gmail.com>>
> > > > > > > > >> > > >>> > > > >> > > wrote:
> > > > > > > > >> > > >>> > > > >> > > >> >>>> > Hey
> > > > > > > > >> > > >>> > > > >> > > >> >>>> >
> > > > > > > > >> > > >>> > > > >> > > >> >>>> > I just committed some code
> > based
> > > > on
> > > > > > > their
> > > > > > > > >> > > WebView
> > > > > > > > >> > > >>> > > > >> > > >> >>>> > modifications that allows
> > you to
> > > > > > choose
> > > > > > > > >> > > >>> > > > >> > > >> >>>> > your
> > > > > > > > >> > > >>> renderer
> > > > > > > > >> > > >>> > > > >> > > >> >>>> > in the
> > > > > > > > >> > > >>> > > > >> > config file
> > > > > > > > >> > > >>> > > > >> > > with this:
> > > > > > > > >> > > >>> > > > >> > > >> >>>> >
> > > > > > > > >> > > >>> > > > >> > > >> >>>> >     <preference
> > name="webView"
> > > > > > > > >> > > >>> > > > >> > > >> >>>> >
> > > > > > > > >> > > >>>
> > value="org.apache.cordova.engine.crosswalk.XWalkCordo
> > > > > > > > >> > > >>> > > > >> > > >> >>>> > va
> > > > > > > > >> > > >>> > > > >> > > >> >>>> > Web
> > > > > > > > >> > > >>> > > > >> > > >> >>>> > View
> > > > > > > > >> > > >>> > > > >> > > >> >>>> > " />
> > > > > > > > >> > > >>> > > > >> > > >> >>>> >
> > > > > > > > >> > > >>> > > > >> > > >> >>>> > You currently have to copy
> > over
> > > > the
> > > > > > > *.pak
> > > > > > > > >> > > >>> > > > >> > > >> >>>> > file
> > > > > > > > >> > > and
> > > > > > > > >> > > >>> > > > >> > > >> >>>> > the jsapi from a Crosswalk
> > > > Example
> > > > > > > > project
> > > > > > > > >> > > >>> > > > >> > > >> >>>> > to
> > > > > > > > >> > > get
> > > > > > > > >> > > >>> > > > >> > > >> >>>> > this to work.  The next
> thing
> > > > that
> > > > > > I'm
> > > > > > > > >> > > >>> > > > >> > > >> >>>> > going
> > > > > > > > >> > to
> > > > > > > > >> > > do
> > > > > > > > >> > > >>> is
> > > > > > > > >> > > >>> > > > >> > > >> >>>> > figure out how to write
> this
> > as a
> > > > > > > plugin
> > > > > > > > >> > > >>> > > > >> > > >> >>>> > and
> > > > > > > > >> > > have it
> > > > > > > > >> > > >>> > > > >> > > >> >>>> > install on a default
> > > > > > > > >> > > >>> > > > project.
> > > > > > > > >> > > >>> > > > >> > > >> >>>> > Also, right now the bridge
> > > > doesn't
> > > > > > seem
> > > > > > > > to
> > > > > > > > >> > > work, and
> > > > > > > > >> > > >>> > > > >> > > >> >>>> > I don't know why exactly.
> >  That
> > > > being
> > > > > > > > said,
> > > > > > > > >> > the
> > > > > > > > >> > > >>> > > > >> > > >> fact
> > > > > > > > >> > > >>> > > > >> > > >> >>>> > that I can choose which
> > version
> > > > of
> > > > > > > > >> > > Chrome/Chromium
> > > > > > > > >> > > >>> > > > >> > > >> >>>> > I'm running with
> > > > > > > > >> > > >>> > > > >> > > >> a
> > > > > > > > >> > > >>> > > > >> > > >> >>>> > single XML preference is
> > HUGE.
> > > > > > > > >> > > >>> > > > >> > > >> >>>> >
> > > > > > > > >> > > >>> > > > >> > > >> >>>> > There's definitely a lot
> more
> > > > work
> > > > > > that
> > > > > > > > >> > > >>> > > > >> > > >> >>>> > needs
> > > > > > > > >> > > to be
> > > > > > > > >> > > >>> > > > >> > > >> >>>> > done, but as
> > > > > > > > >> > > >>> > > > >> > > >> long
> > > > > > > > >> > > >>> > > > >> > > >> >>>> > as we have something that
> we
> > can
> > > > fit
> > > > > > > into
> > > > > > > > >> > > >>> > > > >> > > >> >>>> > the
> > > > > > > > >> > > >>> > > > >> > > >> >>>> > interface, we should
> > > > > > > > >> > > >>> > > > >> > > >> be
> > > > > > > > >> > > >>> > > > >> > > >> >>>> > able to put in things like
> > > > GeckoView
> > > > > > or
> > > > > > > > >> > > >>> > > > >> > > >> >>>> > other
> > > > > > > > >> > > third
> > > > > > > > >> > > >>> > > > >> > > >> >>>> > party
> > > > > > > > >> > > >>> > > > >> > renderers.
> > > > > > > > >> > > >>> > > > >> > > >> >>>> > The nightmare of being
> stuck
> > with
> > > > > > > > bullshit
> > > > > > > > >> > > WebView
> > > > > > > > >> > > >>> > > > >> > > >> >>>> > bugs may soon be over.
> > > > > > > > >> > > >>> > > > >> > > >> >>>> >
> > > > > > > > >> > > >>> > > > >> > > >> >>>> > On Wed, Mar 5, 2014 at 8:59
> > PM,
> > > > > > Michal
> > > > > > > > >> > > >>> > > > >> > > >> >>>> > Mocny
> > > > > > > > >> > > >>> > > > >> > > >> >>>> > <mmocny@chromium.org
> <mailto:
> > > > > > > > mmocny@chromium.org>>
> > > > > > > > >> > > >>> > > > >> > > >> >>>> wrote:
> > > > > > > > >> > > >>> > > > >> > > >> >>>> >>
> > > > > > > > >> > > >>>
> > https://github.com/crosswalk-project/crosswalk-cordo
> > > > > > > > >> > > >>> > > > >> > > >> >>>> >> va
> > > > > > > > >> > > >>> > > > >> > > >> >>>> >> -an
> > > > > > > > >> > > >>> > > > >> > > >> >>>> >> droi
> > > > > > > > >> > > >>> > > > >> > > >> >>>> >> d
> > > > > > > > >> > > >>> > > > >> > > >> >>>> >>
> > > > > > > > >> > > >>> > > > >> > > >> >>>> >> First patch they landed,
> > which
> > > > > > claims
> > > > > > > to
> > > > > > > > >> > > >>> > > > >> > > >> >>>> >> have
> > > > > > > > >> > > min
> > > > > > > > >> > > >>> > > > >> > > >> >>>> >> viable xwalk
> > > > > > > > >> > > >>> > > > >> > > >> webview:
> > > > > > > > >> > > >>> > > > >> > > >> >>>> >>
> > > > > > > > >> > > >>> > > > >> > > >> >>>>
> > > > > > > > >> > > >>> > > > >> > > >>
> > > > > > > > >> > > >>>
> > > > > > https://github.com/crosswalk-project/crosswalk-cordova-andro
> > > > > > > > >> > > >>> > > > >> > > >> id
> > > > > > > > >> > > >>> > > > >> > > >> /co
> > > > > > > > >> > > >>> > > > >> > > >> mmit
> > > > > > > > >> > > >>> > > > >> > > >>
> > > > /a04dedeb0204e7542d190312c6ae70c795a26e04
> > > > > > > > >> > > >>> > > > >> > > >> >>>> >>
> > > > > > > > >> > > >>> > > > >> > > >> >>>> >>
> > > > > > > > >> > > >>> > > > >> > > >> >>>> >> On Wed, Mar 5, 2014 at
> > 11:37 PM,
> > > > > > > Michal
> > > > > > > > >> > > >>> > > > >> > > >> >>>> >> Mocny
> > > > > > > > >> > > >>> > > > >> > > >> >>>> >> <mmocny@chromium.org
> > <mailto:
> > > > > > > > mmocny@chromium.org>
> > > > > > > > >> > > >>> > > > >> > > >> >
> > > > > > > > >> > > >>> > > > >> > > >> >>>> wrote:
> > > > > > > > >> > > >>> > > > >> > > >> >>>> >>
> > > > > > > > >> > > >>> > > > >> > > >> >>>> >>> I haven't looked yet, but
> > did
> > > > you
> > > > > > > see:
> > > > > > > > >> > > >>> > > > >> > > >> >>>> >>>
> > > > > > > > >> > > >>>
> https://crosswalk-project.org/#wiki/crosswalk-cordo
> > > > > > > > >> > > >>> > > > >> > > >> >>>> >>> va
> > > > > > > > >> > > >>> > > > >> > > >> >>>> >>> -an
> > > > > > > > >> > > >>> > > > >> > > >> >>>> >>> droi
> > > > > > > > >> > > >>> > > > >> > > >> >>>> >>> d
> > > > > > > > >> > > >>> > > > >> > > >> >>>> >>>
> > > > > > > > >> > > >>> > > > >> > > >> >>>> >>> ?
> > > > > > > > >> > > >>> > > > >> > > >> >>>> >>>
> > > > > > > > >> > > >>> > > > >> > > >> >>>> >>>
> > > > > > > > >> > > >>> > > > >> > > >> >>>> >>> On Wed, Mar 5, 2014 at
> > 10:20
> > > > PM,
> > > > > > > Andrew
> > > > > > > > >> > > Grieve <
> > > > > > > > >> > > >>> > > > >> > > >> agrieve@chromium.org<mailto:
> > > > > > > > agrieve@chromium.org>
> > > > > > > > >> > > >>> > > > >> > > >> >>>> >wrote:
> > > > > > > > >> > > >>> > > > >> > > >> >>>> >>>
> > > > > > > > >> > > >>> > > > >> > > >> >>>> >>>> First - very excited
> that
> > > > you're
> > > > > > > > working
> > > > > > > > >> > > >>> > > > >> > > >> >>>> >>>> on
> > > > > > > > >> > > this!
> > > > > > > > >> > > >>> > > > >> > > >> >>>> >>>>
> > > > > > > > >> > > >>> > > > >> > > >> >>>> >>>> Had a quick look. Not
> sure
> > > > there's
> > > > > > > > much
> > > > > > > > >> > > >>> > > > >> > > >> >>>> >>>> to
> > > > > > > > >> > be
> > > > > > > > >> > > >>> > gleaned
> > > > > > > > >> > > >>> > > yet.
> > > > > > > > >> > > >>> > > > >> > > >> >>>> >>>> Once
> > > > > > > > >> > > >>> > > > >> > > >> you
> > > > > > > > >> > > >>> > > > >> > > >> >>>> start
> > > > > > > > >> > > >>> > > > >> > > >> >>>> >>>> in on hooking up
> x-walk's
> > > > webview
> > > > > > I
> > > > > > > > >> > > >>> > > > >> > > >> >>>> >>>> think
> > > > > > > > >> > it
> > > > > > > > >> > > will
> > > > > > > > >> > > >>> > > > >> > > >> >>>> >>>> become more
> > > > > > > > >> > > >>> > > > >> > > >> obvious
> > > > > > > > >> > > >>> > > > >> > > >> >>>> what
> > > > > > > > >> > > >>> > > > >> > > >> >>>> >>>> the interface should
> look
> > > > like.
> > > > > > > E.g.,
> > > > > > > > >> > > >>> > > > >> > > >> >>>> >>>> does
> > > > > > > > >> > > x-walk
> > > > > > > > >> > > >>> > > > >> > > >> >>>> >>>> even have the
> > > > > > > > >> > > >>> > > > >> > > >> >>>> concept of
> > > > > > > > >> > > >>> > > > >> > > >> >>>> >>>> ChromeClient vs
> > WebViewClient
> > > > vs
> > > > > > > > >> > > >>> > > > >> > > >> >>>> >>>> WebView?
> > > > > > > > >> > > Also
> > > > > > > > >> > > >>> > > > >> > > >> >>>> >>>> unsure whether the
> > > > > > > > >> > > >>> > > > >> > > >> >>>> class
> > > > > > > > >> > > >>> > > > >> > > >> >>>> >>>> should extend
> > android.View as
> > > > well
> > > > > > > as
> > > > > > > > >> > > implement
> > > > > > > > >> > > >>> > > > >> > > >> >>>> >>>> our
> > > > > > > > >> > > >>> > > > >> > interface.
> > > > > > > > >> > > >>> > > > >> > > >> E.g.
> > > > > > > > >> > > >>> > > > >> > > >> >>>> >>>> alternative is to have a
> > > > > > "getView()"
> > > > > > > > >> > > >>> > > > >> > > >> >>>> >>>> method
> > > > > > > > >> > > on
> > > > > > > > >> > > >>> the
> > > > > > > > >> > > >>> > > > >> > interface.
> > > > > > > > >> > > >>> > > > >> > > >> Might
> > > > > > > > >> > > >>> > > > >> > > >> >>>> help
> > > > > > > > >> > > >>> > > > >> > > >> >>>> >>>> to
> > > > > > > > >> > > >>> > > > >> > > >> >>>> >>>> cut down on file sizes,
> > and
> > > > API
> > > > > > > > surface,
> > > > > > > > >> > but
> > > > > > > > >> > > >>> > > > >> > > >> >>>> >>>> again, I'm not too
> > > > > > > > >> > > >>> > > > >> > > >> sure.
> > > > > > > > >> > > >>> > > > >> > > >> >>>> >>>>
> > > > > > > > >> > > >>> > > > >> > > >> >>>> >>>> I've been pretty
> hesitant
> > to
> > > > touch
> > > > > > > > >> > > >>> > > > >> > > >> >>>> >>>> existing
> > > > > > > > >> > > >>> > > > >> > > >> >>>> >>>> exposed members
> > > > > > > > >> > > >>> > > > >> > > >> (e.g. the
> > > > > > > > >> > > >>> > > > >> > > >> >>>> >>>> public fields you were
> > > > referring
> > > > > > to)
> > > > > > > > >> > > >>> > > > >> > > >> >>>> >>>> since
> > > > > > > > >> > > >>> > > > >> > > >> >>>> >>>> touching anything
> > > > > > > > >> > > >>> > > > >> > > >> public
> > > > > > > > >> > > >>> > > > >> > > >> >>>> could
> > > > > > > > >> > > >>> > > > >> > > >> >>>> >>>> break plugins. That
> said,
> > > > maybe
> > > > > > now
> > > > > > > > is a
> > > > > > > > >> > good
> > > > > > > > >> > > >>> time
> > > > > > > > >> > > >>> > > > >> > > >> >>>> >>>> to @deprecate
> > > > > > > > >> > > >>> > > > >> > > >> a
> > > > > > > > >> > > >>> > > > >> > > >> >>>> bunch
> > > > > > > > >> > > >>> > > > >> > > >> >>>> >>>> of
> > > > > > > > >> > > >>> > > > >> > > >> >>>> >>>> them and either replace
> > them
> > > > with
> > > > > > > > >> > > >>> > > > >> > > >> >>>> >>>> getters,
> > > > > > > > >> > or
> > > > > > > > >> > > >>> just
> > > > > > > > >> > > >>> > > > >> > > >> >>>> >>>> declare them
> > > > > > > > >> > > >>> > > > >> > > >> to be
> > > > > > > > >> > > >>> > > > >> > > >> >>>> not
> > > > > > > > >> > > >>> > > > >> > > >> >>>> >>>> exposed to plugins.
> > > > > > > > >> > > >>> > > > >> > > >> >>>> >>>>
> > > > > > > > >> > > >>> > > > >> > > >> >>>> >>>>
> > > > > > > > >> > > >>> > > > >> > > >> >>>> >>>> On Wed, Mar 5, 2014 at
> > 6:57
> > > > PM,
> > > > > > Joe
> > > > > > > > >> > > >>> > > > >> > > >> >>>> >>>> Bowser
> > > > > > > > >> > > >>> > > > >> > > >> >>>> >>>> <bowserj@gmail.com
> > <mailto:
> > > > > > > > bowserj@gmail.com>>
> > > > > > > > >> > > >>> > > > >> > > >> wrote:
> > > > > > > > >> > > >>> > > > >> > > >> >>>> >>>>
> > > > > > > > >> > > >>> > > > >> > > >> >>>> >>>> > So, after looking at
> the
> > > > > > Crosswalk
> > > > > > > > >> > > >>> > > > >> > > >> >>>> >>>> > code
> > > > > > > > >> > > again,
> > > > > > > > >> > > >>> > > > >> > > >> >>>> >>>> > I've decided to
> > > > > > > > >> > > >>> > > > >> > > >> take
> > > > > > > > >> > > >>> > > > >> > > >> >>>> a
> > > > > > > > >> > > >>> > > > >> > > >> >>>> >>>> > quick stab at making
> > things
> > > > > > > > pluggable.
> > > > > > > > >> > > >>> > > > >> > > >> >>>> >>>> > I
> > > > > > > > >> > > don't
> > > > > > > > >> > > >>> > > > >> > > >> >>>> >>>> > have a lot to
> > > > > > > > >> > > >>> > > > >> > > >> show
> > > > > > > > >> > > >>> > > > >> > > >> >>>> for
> > > > > > > > >> > > >>> > > > >> > > >> >>>> >>>> > it, but with the help
> of
> > > > Eclipse
> > > > > > > > >> > > >>> > > > >> > > >> >>>> >>>> > (which
> > > > > > > > >> > is
> > > > > > > > >> > > why
> > > > > > > > >> > > >>> > > > >> > > >> >>>> >>>> > the generated
> interfaces
> > > > look so
> > > > > > > > >> > > >>> > > > >> > > >> >>>> >>>> > screwed
> > > > > > > > >> > > up), I
> > > > > > > > >> > > >>> > > > >> > > >> >>>> >>>> > managed to create some
> > > > > > > > >> > > >>> > > > >> > > >> interfaces
> > > > > > > > >> > > >>> > > > >> > > >> >>>> so
> > > > > > > > >> > > >>> > > > >> > > >> >>>> >>>> > we can start
> > shoehorning in
> > > > > > other
> > > > > > > > >> > > >>> > > > >> > > >> >>>> >>>> > browser
> > > > > > > > >> > > >>> > renderers.
> > > > > > > > >> > > >>> > > > >> > > >> >>>> >>>> >
> > > > > > > > >> > > >>> > > > >> > > >> >>>> >>>> >
> > > > > > > > >> > > >>> > > > >> > > >>
> > > > > > > > >> > > >>>
> > > > > > https://github.com/infil00p/cordova-android/tree/pluggable_w
> > > > > > > > >> > > >>> > > > >> > > >> eb
> > > > > > > > >> > > >>> > > > >> > > >> vie
> > > > > > > > >> > > >>> > > > >> > > >> w
> > > > > > > > >> > > >>> > > > >> > > >> >>>> >>>> >
> > > > > > > > >> > > >>> > > > >> > > >> >>>> >>>> > I'm going to probably
> > start
> > > > with
> > > > > > > > >> > Crosswalk,
> > > > > > > > >> > > >>> > > > >> > > >> >>>> >>>> > because it's
> > > > > > > > >> > > >>> > > > >> > > >> probably
> > > > > > > > >> > > >>> > > > >> > > >> >>>> the
> > > > > > > > >> > > >>> > > > >> > > >> >>>> >>>> > most mature primary
> > > > candidate in
> > > > > > > the
> > > > > > > > >> > > Android
> > > > > > > > >> > > >>> > > > >> > > >> >>>> >>>> > Third-Party
> > > > > > > > >> > > >>> > > > >> > > >> WebView
> > > > > > > > >> > > >>> > > > >> > > >> >>>> >>>> > thing, and I'm pretty
> > sure
> > > > the
> > > > > > > > >> > > >>> > > > >> > > >> >>>> >>>> > GeckoView
> > > > > > > > >> > > will
> > > > > > > > >> > > >>> be
> > > > > > > > >> > > >>> > > > >> > > >> >>>> >>>> > happening
> > > > > > > > >> > > >>> > > > >> > > >> shortly
> > > > > > > > >> > > >>> > > > >> > > >> >>>> >>>> > after.
> > > > > > > > >> > > >>> > > > >> > > >> >>>> >>>> >
> > > > > > > > >> > > >>> > > > >> > > >> >>>> >>>> > I don't know how this
> > would
> > > > work
> > > > > > > > >> > > >>> > > > >> > > >> >>>> >>>> > w.r.t.
> > > > > > > > >> > > the CLI
> > > > > > > > >> > > >>> > > > >> > > >> >>>> >>>> > or our
> > > > > > > > >> > > >>> > > > >> > > >> workflow at
> > > > > > > > >> > > >>> > > > >> > > >> >>>> >>>> > all, but at the
> moment,
> > I
> > > > really
> > > > > > > > just
> > > > > > > > >> > want
> > > > > > > > >> > > to
> > > > > > > > >> > > >>> at
> > > > > > > > >> > > >>> > > > >> > > >> >>>> >>>> > least start
> > > > > > > > >> > > >>> > > > >> > > >> to have
> > > > > > > > >> > > >>> > > > >> > > >> >>>> >>>> > some headway towards
> > 4.x and
> > > > > > > > PhoneGap
> > > > > > > > >> > day.
> > > > > > > > >> > > >>> > > > >> > > >> >>>> >>>> >
> > > > > > > > >> > > >>> > > > >> > > >> >>>> >>>> > What do people think
> of
> > > > this so
> > > > > > > far?
> > > > > > > > >> > > >>> > > > >> > > >> >>>> >>>> > I'm
> > > > > > > > >> > > going
> > > > > > > > >> > > >>> > > > >> > > >> >>>> >>>> > to try to clean
> > > > > > > > >> > > >>> > > > >> > > >> >>>> things
> > > > > > > > >> > > >>> > > > >> > > >> >>>> >>>> > up a bit, since we've
> > > > definitely
> > > > > > > > done
> > > > > > > > >> > > >>> > > > >> > > >> >>>> >>>> > a
> > > > > > > > >> > > lot of
> > > > > > > > >> > > >>> > > > >> > > >> >>>> >>>> > things that
> > > > > > > > >> > > >>> > > > >> > > >> would
> > > > > > > > >> > > >>> > > > >> > > >> >>>> make
> > > > > > > > >> > > >>> > > > >> > > >> >>>> >>>> > first year CS profs
> > freak
> > > > the
> > > > > > hell
> > > > > > > > out
> > > > > > > > >> > > (i.e.
> > > > > > > > >> > > >>> > > > >> > > >> >>>> >>>> > public members in
> > > > > > > > >> > > >>> > > > >> > > >> >>>> public
> > > > > > > > >> > > >>> > > > >> > > >> >>>> >>>> > objects w.r.t.
> > > > PluginManager).
> > > > > > > > >> > > >>> > > > >> > > >> >>>> >>>> >
> > > > > > > > >> > > >>> > > > >> > > >> >>>> >>>> > Thoughts?
> > > > > > > > >> > > >>> > > > >> > > >> >>>> >>>> >
> > > > > > > > >> > > >>> > > > >> > > >> >>>> >>>> > Joe
> > > > > > > > >> > > >>> > > > >> > > >> >>>> >>>> >
> > > > > > > > >> > > >>> > > > >> > > >> >>>> >>>>
> > > > > > > > >> > > >>> > > > >> > > >> >>>> >>>
> > > > > > > > >> > > >>> > > > >> > > >> >>>> >>>
> > > > > > > > >> > > >>> > > > >> > > >> >>>>
> > > > > > > > >> > > >>> > > > >> > > >>
> > > > > > > > >> > > >>> > > > >> >
> > > > > > > > >> > > >>> >
> > > > > > > > >> > > >>>
> > > > > > > > >> > >
> > > > > > > > >> >
> > > > > > > > >
> > > > > > > > >
> > > > > > > >
> > > > > > > >
> > > > > > >
> > > > > >
> > > >
> >
>

Re: [Android] Refactoring for different engines

[Ian Clelland <ic...@chromium.org>]

I approve of that time slot. I'll be there.

Ian


On Thu, Apr 24, 2014 at 10:32 PM, Hu, Ningxin <ni...@intel.com> wrote:

> Please let me know if we agree with this time (9am Pacific, 12am Eastern
> and 0am China)? I will stay till mid-night, but maybe not to next morning
> :p.
>
> Thanks,
> -ningxin
>
> > -----Original Message-----
> > From: iclelland@google.com [mailto:iclelland@google.com] On Behalf Of
> Ian
> > Clelland
> > Sent: Thursday, April 24, 2014 8:58 PM
> > To: dev@cordova.apache.org
> > Subject: Re: [Android] Refactoring for different engines
> >
> > On Thu, Apr 24, 2014 at 1:10 AM, Hu, Ningxin <ni...@intel.com>
> wrote:
> >
> > > Understood.
> > >
> > > How about 9am Pacific, 12am Eastern and 0am China? Really appreciate.
> > >
> >
> > That time would probably work better for me than 7 hours later.
> >
> > Ian
> >
> >
> > >
> > > Thanks,
> > > -ningxin
> > >
> > > > -----Original Message-----
> > > > From: mmocny@google.com [mailto:mmocny@google.com] On Behalf Of
> > > > Michal Mocny
> > > > Sent: Thursday, April 24, 2014 11:45 AM
> > > > To: dev
> > > > Subject: Re: [Android] Refactoring for different engines
> > > >
> > > > (Yeah 7pm Friday is more naughty than 4am for those of us with
> > > > families.)
> > > >
> > > > I think the original intent was just supposed to be a meet & greet
> right?
> > > >  Lets just do it asap and consider formal scheduling with ample
> > > > planning
> > > only if
> > > > there are technical topics to discuss.
> > > >
> > > > It would be nice, though, if Ian could make it, given his recent
> > > > work on
> > > this.
> > > >
> > > > -Michal
> > > >
> > > >
> > > > On Wed, Apr 23, 2014 at 10:34 PM, Victor Sosa
> > > ><sosah.victor@gmail.com
> > > >wrote:
> > > >
> > > > > 4PM PST? That's 6 CST or 7 EST, me thinks. Seems to work for many
> > > > > of us On Apr 23, 2014 8:49 PM, "Brian LeRoux" <b...@brian.io> wrote:
> > > > >
> > > > > > 4pm works for me…
> > > > > >
> > > > > >
> > > > > > On Wed, Apr 23, 2014 at 6:19 PM, Hu, Ningxin
> > > > > > <ni...@intel.com>
> > > > > wrote:
> > > > > >
> > > > > > > I am in China. 1:00 PM PST means 4:00 AM here :o.
> > > > > > > Could you please schedule it a little bit later, say 4:00 or
> > > > > > > 5:00 PM
> > > > > PST?
> > > > > > > It will be highly appreciated.
> > > > > > >
> > > > > > > Thanks,
> > > > > > > -ningxin
> > > > > > >
> > > > > > > From: brian.leroux@gmail.com [mailto:brian.leroux@gmail.com]
> > > > > > > On Behalf
> > > > > > Of
> > > > > > > Brian LeRoux
> > > > > > > Sent: Thursday, April 24, 2014 6:10 AM
> > > > > > > To: Joe Bowser
> > > > > > > Cc: dev@cordova.apache.org; Hu, Ningxin
> > > > > > > Subject: Re: [Android] Refactoring for different engines
> > > > > > >
> > > > > > > How does 1:00PST on Friday work for a hangout for everyone?
> > > > > > >
> > > > > > > On Wed, Apr 23, 2014 at 2:36 PM, Joe Bowser <bowserj@gmail.com
> > > <mailto:
> > > > > > > bowserj@gmail.com>> wrote:
> > > > > > > BTW: Here's my PoC for Mozilla so far.  It's very broken!
> > > > > > >
> > > > > > > https://github.com/infil00p/MozillaView
> > > > > > >
> > > > > > >
> > > > > > >
> > > > > > > On Wed, Apr 23, 2014 at 10:50 AM, Brian LeRoux <b@brian.io
> <mailto:
> > > > > > > b@brian.io>> wrote:
> > > > > > > > So I found a Moz hacker whom can help. what time on Fri do
> > > > > > > > you guys
> > > > > > want
> > > > > > > to
> > > > > > > > do this?
> > > > > > > >
> > > > > > > >
> > > > > > > > On Wed, Apr 23, 2014 at 10:31 AM, Ian Clelland <
> > > > > iclelland@chromium.org
> > > > > > > <ma...@chromium.org>>
> > > > > > > > wrote:
> > > > > > > >>
> > > > > > > >> I've managed to get this up and running now -- great work
> > > > > > > >> on this,
> > > > > > Joe!
> > > > > > > >>
> > > > > > > >> Mobilespec runs on my N4, with 10 failing tests: 3 in
> > > > > > > >> contacts;
> > > > > > > >> 7 in file-transfer. Otherwise, things seem to be working
> > > > > > > >> pretty
> > > well.
> > > > > > > >>
> > > > > > > >> I used a new build of Crosswalk, and found that the
> > > > > > > >> embedding API
> > > > > has
> > > > > > > >> changed since the weekend (when Ningxin's patches applied).
> > > > > > > >> I've
> > > > > > issued
> > > > > > > a
> > > > > > > >> pull request at
> > > > > > > >> https://github.com/infil00p/cordova-crosswalk-engine/pull/5
> > > > > > > >> for
> > > > > > > >> it
> > > > > --
> > > > > > > >>
> > > > > > > >> I'm not sure if there's a way to keep compatibility with
> > > > > > > >> last week's Crosswalk, or if we'd even want to. (Ningxin,
> > > > > > > >> if you could
> > > > > > take a
> > > > > > > >> look at that PR and see if it makes sense, I'd appreciate
> > > > > > > >> it)
> > > > > > > >>
> > > > > > > >> Joe, I also had to patch the default constructor for
> > > > > > > XWalkCordovaWebView;
> > > > > > > >> it wasn't creating its own client objects, so it got the
> > > > > > > >> default
> > > > > ones,
> > > > > > > and
> > > > > > > >> most of the tests were failing because some component of
> > > > > > > >> the bridge
> > > > > > > wan't
> > > > > > > >> working.
> > > > > https://github.com/infil00p/cordova-crosswalk-engine/pull/4is
> > > > > > > >> out
> > > > > > > >> for that.
> > > > > > > >>
> > > > > > > >> Count me in for the hangout -- this is exciting stuff
> > > > > > > >>
> > > > > > > >> Ian
> > > > > > > >>
> > > > > > > >>
> > > > > > > >> On Wed, Apr 23, 2014 at 10:26 AM, Brian LeRoux <b@brian.io
> > > <mailto:
> > > > > > > b@brian.io>> wrote:
> > > > > > > >>
> > > > > > > >> > Yup I'll track em down
> > > > > > > >> > On Apr 23, 2014 7:17 AM, "Andrew Grieve"
> > > > > > > >> > <agrieve@chromium.org
> > > > > > > <ma...@chromium.org>> wrote:
> > > > > > > >> >
> > > > > > > >> > > Does anyone have a contact at moz that we could invite?
> > > > > > > >> > >
> > > > > > > >> > > On Wed, Apr 23, 2014 at 10:09 AM, Andrew Grieve <
> > > > > > > agrieve@chromium.org<ma...@chromium.org>>
> > > > > > > >> > > wrote:
> > > > > > > >> > > > Depends on their interest level I think. Faster we
> > > > > > > >> > > > can get
> > > > > this
> > > > > > > out
> > > > > > > >> > > > the door the better. If we need to delay for
> > > > > > > >> > > > geckoview, then I
> > > > > > > don't
> > > > > > > >> > > > think we should gate on it, just release it after.
> > > > > > > >> > > >
> > > > > > > >> > > > On Wed, Apr 23, 2014 at 3:01 AM, Tommy Williams <
> > > > > > > tommy@devgeeks.org<ma...@devgeeks.org>>
> > > > > > > >> > > wrote:
> > > > > > > >> > > >> More engines, more better...
> > > > > > > >> > > >> On 23 Apr 2014 16:32, "Joe Bowser"
> > > > > > > >> > > >> <bowserj@gmail.com
> > > > > <mailto:
> > > > > > > bowserj@gmail.com>> wrote:
> > > > > > > >> > > >>
> > > > > > > >> > > >>> Hey
> > > > > > > >> > > >>>
> > > > > > > >> > > >>> A Hangout would have to happen on Friday at the
> > > earliest.
> > > > > >  It'd
> > > > > > > be
> > > > > > > >> > > good if
> > > > > > > >> > > >>> we could get someone from Mozilla on the hangout as
> > > > > > > >> > > >>> well.  I haven't
> > > > > > > >> > > gotten
> > > > > > > >> > > >>> MozillaView (GeckoView with Cordova methods) fully
> > > > > > > >> > > >>> working
> > > > > > yet.
> > > > > > > >> > > >>> For
> > > > > > > >> > > some
> > > > > > > >> > > >>> reason it's not rendering on the screen.
> > > > > > > >> > > >>>
> > > > > > > >> > > >>> Ideally it'd be cool to have at least two options
> > > > > > > >> > > >>> when this feature
> > > > > > > >> > > finally
> > > > > > > >> > > >>> lands.
> > > > > > > >> > > >>>
> > > > > > > >> > > >>> What do other people think?
> > > > > > > >> > > >>>
> > > > > > > >> > > >>> Joe
> > > > > > > >> > > >>> On 22 Apr 2014 20:06, "Hu, Ningxin"
> > > > > > > >> > > >>> <ningxin.hu@intel.com
> > > > > > > <ma...@intel.com>> wrote:
> > > > > > > >> > > >>>
> > > > > > > >> > > >>> > Joe,
> > > > > > > >> > > >>> >
> > > > > > > >> > > >>> > Thanks for your review and merge the PRs.
> > > > > > > >> > > >>> >
> > > > > > > >> > > >>> > To pluggable webview interest group:
> > > > > > > >> > > >>> > Are we OK to setup a hangout this week for
> > > > > > > >> > > >>> > initial
> > > > > > > introduction
> > > > > > > >> > > >>> > and
> > > > > > > >> > > >>> > discussion of next steps?
> > > > > > > >> > > >>> >
> > > > > > > >> > > >>> > Thanks,
> > > > > > > >> > > >>> > -ningxin
> > > > > > > >> > > >>> >
> > > > > > > >> > > >>> > > -----Original Message-----
> > > > > > > >> > > >>> > > From: Hu, Ningxin [mailto:ningxin.hu@intel.com
> > > <mailto:
> > > > > > > ningxin.hu@intel.com>]
> > > > > > > >> > > >>> > > Sent: Tuesday, April 22, 2014 4:04 PM
> > > > > > > >> > > >>> > > To: dev@cordova.apache.org<mailto:
> > > > > dev@cordova.apache.org>
> > > > > > > >> > > >>> > > Subject: RE: [Android] Refactoring for
> > > > > > > >> > > >>> > > different engines
> > > > > > > >> > > >>> > >
> > > > > > > >> > > >>> > > The PoC is great! Quite excited about the
> direction!
> > > > > > > >> > > >>> > >
> > > > > > > >> > > >>> > > I've sent a PR to update the
> > > > > > > >> > > >>> > > cordova-crosswalk-engine to latest
> > > > > > > >> > > >>> crosswalk
> > > > > > > >> > > >>> > > embedding API. It works with xwalk_core_library
> > > > > > > >> > > >>> > > at
> > > > > > > 6.35.124.0.
> > > > > > > >> > > >>> > >
> > > > > > > >> > > >>> > > I've also changed the CordovaWebView interface
> > > > > > > >> > > >>> > > slightly (adding
> > > > > > > >> > > >>> > getView() API)
> > > > > > > >> > > >>> > > to allow XWalkCordovaWebView to composite a
> > > > > > > >> > > >>> > > XWalkView
> > > > > > > instead
> > > > > > > >> > > >>> > > of
> > > > > > > >> > > >>> > extending
> > > > > > > >> > > >>> > > it. It resolves some API naming issues for
> > > > > > > >> > > >>> > > XWalkView
> > > > > case.
> > > > > > > >> > > >>> > >
> > > > > > > >> > > >>> > > Please review them at:
> > > > > > > >> > > >>> > >
> > > > > > https://github.com/infil00p/cordova-crosswalk-engine/pull/3
> > > > > > > >> > > >>> > > https://github.com/infil00p/cordova-android/pul
> > > > > > > >> > > >>> > > l/2
> > > > > > > >> > > >>> > >
> > > > > > > >> > > >>> > > Thanks,
> > > > > > > >> > > >>> > > -ningxin
> > > > > > > >> > > >>> > >
> > > > > > > >> > > >>> > > > -----Original Message-----
> > > > > > > >> > > >>> > > > From: Joe Bowser [mailto:bowserj@gmail.com
> > > <mailto:
> > > > > > > bowserj@gmail.com>]
> > > > > > > >> > > >>> > > > Sent: Friday, April 11, 2014 12:45 AM
> > > > > > > >> > > >>> > > > To: dev
> > > > > > > >> > > >>> > > > Subject: Re: [Android] Refactoring for
> > > > > > > >> > > >>> > > > different
> > > > > engines
> > > > > > > >> > > >>> > > >
> > > > > > > >> > > >>> > > > Yeah, I'd be cool with setting up a hangout.
> > > > > > > >> > > >>> > > > Everyone should
> > > > > > > >> > > take a
> > > > > > > >> > > >>> > > > look at the PoC, I've basically distilled it
> > > > > > > >> > > >>> > > > down to
> > > > > > four
> > > > > > > or
> > > > > > > >> > five
> > > > > > > >> > > >>> > > > classes so far, but with some work, we may be
> > > > > > > >> > > >>> > > > able to
> > > > > > get
> > > > > > > it
> > > > > > > >> > > down to
> > > > > > > >> > > >>> > > > three.  Due to legacy, we're pretty stuck
> > > > > > > >> > > >>> > > > with the
> > > > > > Android
> > > > > > > >> > > WebView
> > > > > > > >> > > >>> API
> > > > > > > >> > > >>> > calls,
> > > > > > > >> > > >>> > > but these can probably be modified.
> > > > > > > >> > > >>> > > >
> > > > > > > >> > > >>> > > > It'd be good to get Mozilla people on the
> > > > > > > >> > > >>> > > > call as
> > > > > well,
> > > > > > > >> > > >>> > > > since
> > > > > > > >> > > they
> > > > > > > >> > > >>> > > > have their WebView as well.
> > > > > > > >> > > >>> > > >
> > > > > > > >> > > >>> > > > On Thu, Apr 10, 2014 at 9:38 AM, Hu, Ningxin
> > > > > > > >> > > >>> > > > <
> > > > > > > >> > > ningxin.hu@intel.com<ma...@intel.com>>
> > > > > > > >> > > >>> > wrote:
> > > > > > > >> > > >>> > > > > Hangout would be a good idea.
> > > > > > > >> > > >>> > > > >
> > > > > > > >> > > >>> > > > > FYI, I will be off next week. How about the
> > > > > > > >> > > >>> > > > > week
> > > > > after
> > > > > > > >> > > >>> > > > > next?
> > > > > > > >> > > If it
> > > > > > > >> > > >>> > > > > works, please
> > > > > > > >> > > >>> > > > feel free to schedule one and count me in.
> > > > > > > >> > > >>> > > > >
> > > > > > > >> > > >>> > > > > Thanks,
> > > > > > > >> > > >>> > > > > -ningxin
> > > > > > > >> > > >>> > > > >
> > > > > > > >> > > >>> > > > >> -----Original Message-----
> > > > > > > >> > > >>> > > > >> From:
> > > > > > > >> > > >>> > > > >> mmocny@google.com<mailto:mmocny@google.com
> > > > > > > >> > > >>> > > > >> >
> > > > > > > [mailto:mmocny@google.com<ma...@google.com>] On
> > > > > > > >> > Behalf
> > > > > > > >> > > Of
> > > > > > > >> > > >>> > > > >> Michal Mocny
> > > > > > > >> > > >>> > > > >> Sent: Tuesday, April 08, 2014 11:39 PM
> > > > > > > >> > > >>> > > > >> To: dev
> > > > > > > >> > > >>> > > > >> Subject: Re: [Android] Refactoring for
> > > > > > > >> > > >>> > > > >> different
> > > > > > > engines
> > > > > > > >> > > >>> > > > >>
> > > > > > > >> > > >>> > > > >> Would it be alright to set up a Hangout
> > > > > > > >> > > >>> > > > >> some time
> > > > > to
> > > > > > > >> > introduce
> > > > > > > >> > > >>> > everyone?
> > > > > > > >> > > >>> > > > >>
> > > > > > > >> > > >>> > > > >> Joe has been leading the effort here, but
> > > > > > > >> > > >>> > > > >> there are
> > > > > > > other
> > > > > > > >> > > cordova
> > > > > > > >> > > >>> > > > >> contributors for whom this is top priority.
> > > > > > > >> > > >>> > > > >> It
> > > > > would
> > > > > > > be
> > > > > > > >> > nice
> > > > > > > >> > > if
> > > > > > > >> > > >>> we
> > > > > > > >> > > >>> > > > >> could all meet to say hello and make sure
> > > > > > > >> > > >>> > > > >> we are
> > > > > all
> > > > > > > >> > > >>> > > > >> going
> > > > > > > >> > in
> > > > > > > >> > > the
> > > > > > > >> > > >>> > > > >> right
> > > > > > > >> > > >>> > > > direction.
> > > > > > > >> > > >>> > > > >>
> > > > > > > >> > > >>> > > > >> Quite exciting!
> > > > > > > >> > > >>> > > > >>
> > > > > > > >> > > >>> > > > >> -Michal
> > > > > > > >> > > >>> > > > >>
> > > > > > > >> > > >>> > > > >>
> > > > > > > >> > > >>> > > > >> On Tue, Apr 8, 2014 at 10:56 AM, Hu,
> > > > > > > >> > > >>> > > > >> Ningxin <
> > > > > > > >> > > >>> ningxin.hu@intel.com<ma...@intel.com>>
> > > > > > > >> > > >>> > > wrote:
> > > > > > > >> > > >>> > > > >>
> > > > > > > >> > > >>> > > > >> > Joe, thanks for this. I am very excited.
> > > > > > > >> > > >>> > > > >> >
> > > > > > > >> > > >>> > > > >> > FYI. Crosswalk team is working on
> > > > > > > >> > > >>> > > > >> > refactoring the WebView
> > > > > > > >> > > API to
> > > > > > > >> > > >>> > > > >> > support embedding usage better [1].
> > > > > > > >> > > >>> > > > >> > (Previously
> > > > > the
> > > > > > > >> > > >>> > > > >> > layer
> > > > > > > >> > > API
> > > > > > > >> > > >>> was
> > > > > > > >> > > >>> > > > >> > not exposed as public usage).
> > > > > > > >> > > >>> > > > >> >
> > > > > > > >> > > >>> > > > >> > I would like to review the PoC and work
> > > > > > > >> > > >>> > > > >> > with you
> > > > > to
> > > > > > > get
> > > > > > > >> > > >>> Crosswalk
> > > > > > > >> > > >>> > > > >> > fits into the pluggable WebView
> architecture.
> > > > > > > >> > > >>> > > > >> >
> > > > > > > >> > > >>> > > > >> > Thanks,
> > > > > > > >> > > >>> > > > >> > -ningxin
> > > > > > > >> > > >>> > > > >> >
> > > > > > > >> > > >>> > > > >> > > -----Original Message-----
> > > > > > > >> > > >>> > > > >> > > From: Joe Bowser
> > > > > > > >> > > >>> > > > >> > > [mailto:bowserj@gmail.com
> > > > > > <mailto:
> > > > > > > bowserj@gmail.com>]
> > > > > > > >> > > >>> > > > >> > > Sent: Wednesday, March 19, 2014 7:08
> > > > > > > >> > > >>> > > > >> > > AM
> > > > > > > >> > > >>> > > > >> > > To: dev
> > > > > > > >> > > >>> > > > >> > > Subject: Re: [Android] Refactoring for
> > > > > different
> > > > > > > >> > > >>> > > > >> > > engines
> > > > > > > >> > > >>> > > > >> > >
> > > > > > > >> > > >>> > > > >> > > Hey
> > > > > > > >> > > >>> > > > >> > >
> > > > > > > >> > > >>> > > > >> > > After debugging, I did some minor
> > > > > > > >> > > >>> > > > >> > > updates to
> > > > > the
> > > > > > > >> > > >>> > > > >> > > plugin
> > > > > > > >> > > >>> README.
> > > > > > > >> > > >>> > > > >> > > It
> > > > > > > >> > > >>> > > > >> > should be
> > > > > > > >> > > >>> > > > >> > > easier to get this up and running,
> > > > > > > >> > > >>> > > > >> > > although
> > > > > > there's
> > > > > > > >> > still
> > > > > > > >> > > the
> > > > > > > >> > > >>> > > > >> > > issue of
> > > > > > > >> > > >>> > > > >> > after-install
> > > > > > > >> > > >>> > > > >> > > hooks and the relative path weirdness
> > > > > > > >> > > >>> > > > >> > > with the Crosswalk
> > > > > > > >> > > >>> > Library itself.
> > > > > > > >> > > >>> > > > >> > >
> > > > > > > >> > > >>> > > > >> > > It still doesn't support the CLI at
> > > > > > > >> > > >>> > > > >> > > all, but it should
> > > > > > > >> > be
> > > > > > > >> > > >>> there
> > > > > > > >> > > >>> > > > >> > > with the
> > > > > > > >> > > >>> > > > >> > old flow.
> > > > > > > >> > > >>> > > > >> > >
> > > > > > > >> > > >>> > > > >> > > On Mon, Mar 17, 2014 at 1:14 PM,
> > > > > > > >> > > >>> > > > >> > > Michal Mocny
> > > > > > > >> > > >>> > > > >> > > <mmocny@chromium.org<mailto:
> > > > > mmocny@chromium.org
> > > > > > >>
> > > > > > > >> > > >>> > > > >> > > wrote:
> > > > > > > >> > > >>> > > > >> > > > (Sorry Joe, Googlers are down in
> > > > > > > >> > > >>> > > > >> > > > California
> > > > > and
> > > > > > > way
> > > > > > > >> > > busy.
> > > > > > > >> > > >>> > > > >> > > > Will be back in a week.  Super
> > > > > > > >> > > >>> > > > >> > > > excited about
> > > > > > > this,
> > > > > > > >> > > though.)
> > > > > > > >> > > >>> > > > >> > > >
> > > > > > > >> > > >>> > > > >> > > > -Michal
> > > > > > > >> > > >>> > > > >> > > >
> > > > > > > >> > > >>> > > > >> > > >
> > > > > > > >> > > >>> > > > >> > > > On Mon, Mar 17, 2014 at 2:53 PM, Joe
> > > > > > > >> > > >>> > > > >> > > > Bowser
> > > > > > > >> > > >>> > > > >> > > > <bowserj@gmail.com<mailto:
> bowserj@gmail.
> > > > > > > >> > > >>> > > > >> > > > com
> > > > > >>
> > > > > > > >> > > >>> > > > >> wrote:
> > > > > > > >> > > >>> > > > >> > > >
> > > > > > > >> > > >>> > > > >> > > >> Reviving this thread!
> > > > > > > >> > > >>> > > > >> > > >>
> > > > > > > >> > > >>> > > > >> > > >> Can other people look at this, and
> > > > > > > >> > > >>> > > > >> > > >> see
> > > > > if/when
> > > > > > > we
> > > > > > > >> > > should
> > > > > > > >> > > >>> > land this?
> > > > > > > >> > > >>> > > > >> > > >> I know that I have to re-write the
> > > > > > > >> > > >>> > > > >> > > >> tests
> > > > > > still,
> > > > > > > >> > > >>> > > > >> > > >> but I
> > > > > > > >> > > would
> > > > > > > >> > > >>> > > > >> > > >> like some feedback before merging
> it in.
> > > > > >  Also,
> > > > > > > >> > > >>> > > > >> > > >> it'd
> > > > > > > >> > be
> > > > > > > >> > > >>> > > > >> > > >> super awesome if other people could
> > > > > > > >> > > >>> > > > >> > > >> try and
> > > > > > > make a
> > > > > > > >> > > WebView
> > > > > > > >> > > >>> > > > >> > > >> based on the interfaces and
> > > > > > > >> > > >>> > > > >> > > >> recommend which methods
> > > > > > > >> > > should
> > > > > > > >> > > >>> > > > >> > > >> die.  I want to get this released
> > > > > > > >> > > >>> > > > >> > > >> in the
> > > > > next
> > > > > > > >> > > >>> > > > >> > > >> month
> > > > > > > >> > or
> > > > > > > >> > > so,
> > > > > > > >> > > >>> > > > >> > > >> so any time and feedback would be
> > > > > > > >> > > >>> > > > >> > > >> greatly
> > > > > > > >> > appreciated.
> > > > > > > >> > > >>> > > > >> > > >>
> > > > > > > >> > > >>> > > > >> > > >> Thanks
> > > > > > > >> > > >>> > > > >> > > >>
> > > > > > > >> > > >>> > > > >> > > >> On Thu, Mar 13, 2014 at 3:50 PM,
> > > > > > > >> > > >>> > > > >> > > >> Joe Bowser
> > > > > > > >> > > >>> > > > >> > > >> <bowserj@gmail.com<mailto:bowserj@g
> > > > > > > >> > > >>> > > > >> > > >> mail .com
> > > > > >>
> > > > > > > >> > > >>> > > > >> > wrote:
> > > > > > > >> > > >>> > > > >> > > >> > Hey, I created the following
> > > > > > > >> > > >>> > > > >> > > >> > today to
> > > > > track
> > > > > > > >> > > >>> > > > >> > > >> > various WebView
> > > > > > > >> > > >>> > > > >> > progresses:
> > > > > > > >> > > >>> > > > >> > > >> >
> > > > > > https://issues.apache.org/jira/browse/CB-6246
> > > > > > > >> > > >>> > > > >> > > >> >
> > > > > > > >> > > >>> > > > >> > > >> > I also have this repo created.
> > > > > > > >> > > >>> > > > >> > > >> > The
> > > > > > licensing
> > > > > > > is
> > > > > > > >> > > ugly as
> > > > > > > >> > > >>> > > > >> > > >> > all crap, but it's a
> Proof-Of-Concept:
> > > > > > > >> > > >>> > > > >> > > >> >
> > > > > > > >> > https://github.com/infil00p/cordova-crosswalk-engine
> > > > > > > >> > > >>> > > > >> > > >> >
> > > > > > > >> > > >>> > > > >> > > >> > If I can get some help getting
> > > plugman to
> > > > > > just
> > > > > > > >> > > >>> > > > >> > > >> > load Crosswalk, it'll
> > > > > > > >> > > >>> > > > >> > > >> look hawt.
> > > > > > > >> > > >>> > > > >> > > >> >
> > > > > > > >> > > >>> > > > >> > > >> > BTW: We should probably get this
> > > ready to
> > > > > go
> > > > > > > >> > > >>> > > > >> > > >> > into
> > > > > > > >> > > Android
> > > > > > > >> > > >>> > > > >> > > >> > in the next two months and
> deprecate
> > > the
> > > > > > > >> > setProperty
> > > > > > > >> > > >>> > > > >> > > >> > methods, since all properties
> should
> > > be
> > > > > > > >> > > >>> > > > >> > > >> > preferences
> > > > > > > >> > > in
> > > > > > > >> > > >>> > config.xml
> > > > > > > >> > > >>> > > now.
> > > > > > > >> > > >>> > > > >> > > >> >
> > > > > > > >> > > >>> > > > >> > > >> > On Mon, Mar 10, 2014 at 2:42 PM,
> Joe
> > > > > Bowser
> > > > > > > >> > > >>> > > > >> > > >> > <bowserj@gmail.com<mailto:
> > > > > bowserj@gmail.com
> > > > > > >>
> > > > > > > >> > > >>> > > > >> > > wrote:
> > > > > > > >> > > >>> > > > >> > > >> >> Perhaps. There would be
> additional
> > > > > benefits
> > > > > > > to
> > > > > > > >> > this
> > > > > > > >> > > >>> > > > >> > > >> >> approach, namely fixes being
> added to
> > > > > that
> > > > > > > >> > platform
> > > > > > > >> > > more
> > > > > > > >> > > >>> > > > >> > > >> >> quickly.  I'll probably take a
> look
> > > at
> > > > > that
> > > > > > > >> > > >>> > > > >> > > >> >> once I
> > > > > > > >> > > have
> > > > > > > >> > > >>> > > > >> > > >> >> Crosswalk
> > > > > > > >> > > >>> > > > finalized.
> > > > > > > >> > > >>> > > > >> > > >> >>
> > > > > > > >> > > >>> > > > >> > > >> >> On Mon, Mar 10, 2014 at 9:49 AM,
> > > Brian
> > > > > > LeRoux
> > > > > > > >> > > >>> > > > >> > > >> >> <b@...@brian.io>>
> > > > > > > >> > > >>> > > > wrote:
> > > > > > > >> > > >>> > > > >> > > >> >>> this is great stuff
> > > > > > > >> > > >>> > > > >> > > >> >>>
> > > > > > > >> > > >>> > > > >> > > >> >>> do we think it may be possible
> to
> > > bring
> > > > > in
> > > > > > > >> > > >>> > > > >> > > >> >>> amazon
> > > > > > > >> > > >>> fireos
> > > > > > > >> > > >>> > > > >> > > >> >>> stuff
> > > > > > > >> > > >>> > > > >> > > >> eventually
> > > > > > > >> > > >>> > > > >> > > >> >>> too?
> > > > > > > >> > > >>> > > > >> > > >> >>>
> > > > > > > >> > > >>> > > > >> > > >> >>>
> > > > > > > >> > > >>> > > > >> > > >> >>> On Fri, Mar 7, 2014 at 3:22 PM,
> Joe
> > > > > Bowser
> > > > > > > >> > > >>> > > > >> > > >> >>> <bowserj@gmail.com<mailto:
> > > > > > bowserj@gmail.com
> > > > > > > >>
> > > > > > > >> > > >>> > > > >> > wrote:
> > > > > > > >> > > >>> > > > >> > > >> >>>
> > > > > > > >> > > >>> > > > >> > > >> >>>> BTW: I committed it in my repo,
> > > not the
> > > > > > > main
> > > > > > > >> > > Apache
> > > > > > > >> > > >>> one.
> > > > > > > >> > > >>> > > > >> > > >> >>>>
> > > > > > > >> > > >>> > > > >> > > >> >>>> On Fri, Mar 7, 2014 at 3:21
> PM, Joe
> > > > > > Bowser
> > > > > > > >> > > >>> > > > >> > > >> >>>> <bowserj@gmail.com<mailto:
> > > > > > > bowserj@gmail.com>>
> > > > > > > >> > > >>> > > > >> > > wrote:
> > > > > > > >> > > >>> > > > >> > > >> >>>> > Hey
> > > > > > > >> > > >>> > > > >> > > >> >>>> >
> > > > > > > >> > > >>> > > > >> > > >> >>>> > I just committed some code
> based
> > > on
> > > > > > their
> > > > > > > >> > > WebView
> > > > > > > >> > > >>> > > > >> > > >> >>>> > modifications that allows
> you to
> > > > > choose
> > > > > > > >> > > >>> > > > >> > > >> >>>> > your
> > > > > > > >> > > >>> renderer
> > > > > > > >> > > >>> > > > >> > > >> >>>> > in the
> > > > > > > >> > > >>> > > > >> > config file
> > > > > > > >> > > >>> > > > >> > > with this:
> > > > > > > >> > > >>> > > > >> > > >> >>>> >
> > > > > > > >> > > >>> > > > >> > > >> >>>> >     <preference
> name="webView"
> > > > > > > >> > > >>> > > > >> > > >> >>>> >
> > > > > > > >> > > >>>
> value="org.apache.cordova.engine.crosswalk.XWalkCordo
> > > > > > > >> > > >>> > > > >> > > >> >>>> > va
> > > > > > > >> > > >>> > > > >> > > >> >>>> > Web
> > > > > > > >> > > >>> > > > >> > > >> >>>> > View
> > > > > > > >> > > >>> > > > >> > > >> >>>> > " />
> > > > > > > >> > > >>> > > > >> > > >> >>>> >
> > > > > > > >> > > >>> > > > >> > > >> >>>> > You currently have to copy
> over
> > > the
> > > > > > *.pak
> > > > > > > >> > > >>> > > > >> > > >> >>>> > file
> > > > > > > >> > > and
> > > > > > > >> > > >>> > > > >> > > >> >>>> > the jsapi from a Crosswalk
> > > Example
> > > > > > > project
> > > > > > > >> > > >>> > > > >> > > >> >>>> > to
> > > > > > > >> > > get
> > > > > > > >> > > >>> > > > >> > > >> >>>> > this to work.  The next thing
> > > that
> > > > > I'm
> > > > > > > >> > > >>> > > > >> > > >> >>>> > going
> > > > > > > >> > to
> > > > > > > >> > > do
> > > > > > > >> > > >>> is
> > > > > > > >> > > >>> > > > >> > > >> >>>> > figure out how to write this
> as a
> > > > > > plugin
> > > > > > > >> > > >>> > > > >> > > >> >>>> > and
> > > > > > > >> > > have it
> > > > > > > >> > > >>> > > > >> > > >> >>>> > install on a default
> > > > > > > >> > > >>> > > > project.
> > > > > > > >> > > >>> > > > >> > > >> >>>> > Also, right now the bridge
> > > doesn't
> > > > > seem
> > > > > > > to
> > > > > > > >> > > work, and
> > > > > > > >> > > >>> > > > >> > > >> >>>> > I don't know why exactly.
>  That
> > > being
> > > > > > > said,
> > > > > > > >> > the
> > > > > > > >> > > >>> > > > >> > > >> fact
> > > > > > > >> > > >>> > > > >> > > >> >>>> > that I can choose which
> version
> > > of
> > > > > > > >> > > Chrome/Chromium
> > > > > > > >> > > >>> > > > >> > > >> >>>> > I'm running with
> > > > > > > >> > > >>> > > > >> > > >> a
> > > > > > > >> > > >>> > > > >> > > >> >>>> > single XML preference is
> HUGE.
> > > > > > > >> > > >>> > > > >> > > >> >>>> >
> > > > > > > >> > > >>> > > > >> > > >> >>>> > There's definitely a lot more
> > > work
> > > > > that
> > > > > > > >> > > >>> > > > >> > > >> >>>> > needs
> > > > > > > >> > > to be
> > > > > > > >> > > >>> > > > >> > > >> >>>> > done, but as
> > > > > > > >> > > >>> > > > >> > > >> long
> > > > > > > >> > > >>> > > > >> > > >> >>>> > as we have something that we
> can
> > > fit
> > > > > > into
> > > > > > > >> > > >>> > > > >> > > >> >>>> > the
> > > > > > > >> > > >>> > > > >> > > >> >>>> > interface, we should
> > > > > > > >> > > >>> > > > >> > > >> be
> > > > > > > >> > > >>> > > > >> > > >> >>>> > able to put in things like
> > > GeckoView
> > > > > or
> > > > > > > >> > > >>> > > > >> > > >> >>>> > other
> > > > > > > >> > > third
> > > > > > > >> > > >>> > > > >> > > >> >>>> > party
> > > > > > > >> > > >>> > > > >> > renderers.
> > > > > > > >> > > >>> > > > >> > > >> >>>> > The nightmare of being stuck
> with
> > > > > > > bullshit
> > > > > > > >> > > WebView
> > > > > > > >> > > >>> > > > >> > > >> >>>> > bugs may soon be over.
> > > > > > > >> > > >>> > > > >> > > >> >>>> >
> > > > > > > >> > > >>> > > > >> > > >> >>>> > On Wed, Mar 5, 2014 at 8:59
> PM,
> > > > > Michal
> > > > > > > >> > > >>> > > > >> > > >> >>>> > Mocny
> > > > > > > >> > > >>> > > > >> > > >> >>>> > <mmocny@chromium.org<mailto:
> > > > > > > mmocny@chromium.org>>
> > > > > > > >> > > >>> > > > >> > > >> >>>> wrote:
> > > > > > > >> > > >>> > > > >> > > >> >>>> >>
> > > > > > > >> > > >>>
> https://github.com/crosswalk-project/crosswalk-cordo
> > > > > > > >> > > >>> > > > >> > > >> >>>> >> va
> > > > > > > >> > > >>> > > > >> > > >> >>>> >> -an
> > > > > > > >> > > >>> > > > >> > > >> >>>> >> droi
> > > > > > > >> > > >>> > > > >> > > >> >>>> >> d
> > > > > > > >> > > >>> > > > >> > > >> >>>> >>
> > > > > > > >> > > >>> > > > >> > > >> >>>> >> First patch they landed,
> which
> > > > > claims
> > > > > > to
> > > > > > > >> > > >>> > > > >> > > >> >>>> >> have
> > > > > > > >> > > min
> > > > > > > >> > > >>> > > > >> > > >> >>>> >> viable xwalk
> > > > > > > >> > > >>> > > > >> > > >> webview:
> > > > > > > >> > > >>> > > > >> > > >> >>>> >>
> > > > > > > >> > > >>> > > > >> > > >> >>>>
> > > > > > > >> > > >>> > > > >> > > >>
> > > > > > > >> > > >>>
> > > > > https://github.com/crosswalk-project/crosswalk-cordova-andro
> > > > > > > >> > > >>> > > > >> > > >> id
> > > > > > > >> > > >>> > > > >> > > >> /co
> > > > > > > >> > > >>> > > > >> > > >> mmit
> > > > > > > >> > > >>> > > > >> > > >>
> > > /a04dedeb0204e7542d190312c6ae70c795a26e04
> > > > > > > >> > > >>> > > > >> > > >> >>>> >>
> > > > > > > >> > > >>> > > > >> > > >> >>>> >>
> > > > > > > >> > > >>> > > > >> > > >> >>>> >> On Wed, Mar 5, 2014 at
> 11:37 PM,
> > > > > > Michal
> > > > > > > >> > > >>> > > > >> > > >> >>>> >> Mocny
> > > > > > > >> > > >>> > > > >> > > >> >>>> >> <mmocny@chromium.org
> <mailto:
> > > > > > > mmocny@chromium.org>
> > > > > > > >> > > >>> > > > >> > > >> >
> > > > > > > >> > > >>> > > > >> > > >> >>>> wrote:
> > > > > > > >> > > >>> > > > >> > > >> >>>> >>
> > > > > > > >> > > >>> > > > >> > > >> >>>> >>> I haven't looked yet, but
> did
> > > you
> > > > > > see:
> > > > > > > >> > > >>> > > > >> > > >> >>>> >>>
> > > > > > > >> > > >>> https://crosswalk-project.org/#wiki/crosswalk-cordo
> > > > > > > >> > > >>> > > > >> > > >> >>>> >>> va
> > > > > > > >> > > >>> > > > >> > > >> >>>> >>> -an
> > > > > > > >> > > >>> > > > >> > > >> >>>> >>> droi
> > > > > > > >> > > >>> > > > >> > > >> >>>> >>> d
> > > > > > > >> > > >>> > > > >> > > >> >>>> >>>
> > > > > > > >> > > >>> > > > >> > > >> >>>> >>> ?
> > > > > > > >> > > >>> > > > >> > > >> >>>> >>>
> > > > > > > >> > > >>> > > > >> > > >> >>>> >>>
> > > > > > > >> > > >>> > > > >> > > >> >>>> >>> On Wed, Mar 5, 2014 at
> 10:20
> > > PM,
> > > > > > Andrew
> > > > > > > >> > > Grieve <
> > > > > > > >> > > >>> > > > >> > > >> agrieve@chromium.org<mailto:
> > > > > > > agrieve@chromium.org>
> > > > > > > >> > > >>> > > > >> > > >> >>>> >wrote:
> > > > > > > >> > > >>> > > > >> > > >> >>>> >>>
> > > > > > > >> > > >>> > > > >> > > >> >>>> >>>> First - very excited that
> > > you're
> > > > > > > working
> > > > > > > >> > > >>> > > > >> > > >> >>>> >>>> on
> > > > > > > >> > > this!
> > > > > > > >> > > >>> > > > >> > > >> >>>> >>>>
> > > > > > > >> > > >>> > > > >> > > >> >>>> >>>> Had a quick look. Not sure
> > > there's
> > > > > > > much
> > > > > > > >> > > >>> > > > >> > > >> >>>> >>>> to
> > > > > > > >> > be
> > > > > > > >> > > >>> > gleaned
> > > > > > > >> > > >>> > > yet.
> > > > > > > >> > > >>> > > > >> > > >> >>>> >>>> Once
> > > > > > > >> > > >>> > > > >> > > >> you
> > > > > > > >> > > >>> > > > >> > > >> >>>> start
> > > > > > > >> > > >>> > > > >> > > >> >>>> >>>> in on hooking up x-walk's
> > > webview
> > > > > I
> > > > > > > >> > > >>> > > > >> > > >> >>>> >>>> think
> > > > > > > >> > it
> > > > > > > >> > > will
> > > > > > > >> > > >>> > > > >> > > >> >>>> >>>> become more
> > > > > > > >> > > >>> > > > >> > > >> obvious
> > > > > > > >> > > >>> > > > >> > > >> >>>> what
> > > > > > > >> > > >>> > > > >> > > >> >>>> >>>> the interface should look
> > > like.
> > > > > > E.g.,
> > > > > > > >> > > >>> > > > >> > > >> >>>> >>>> does
> > > > > > > >> > > x-walk
> > > > > > > >> > > >>> > > > >> > > >> >>>> >>>> even have the
> > > > > > > >> > > >>> > > > >> > > >> >>>> concept of
> > > > > > > >> > > >>> > > > >> > > >> >>>> >>>> ChromeClient vs
> WebViewClient
> > > vs
> > > > > > > >> > > >>> > > > >> > > >> >>>> >>>> WebView?
> > > > > > > >> > > Also
> > > > > > > >> > > >>> > > > >> > > >> >>>> >>>> unsure whether the
> > > > > > > >> > > >>> > > > >> > > >> >>>> class
> > > > > > > >> > > >>> > > > >> > > >> >>>> >>>> should extend
> android.View as
> > > well
> > > > > > as
> > > > > > > >> > > implement
> > > > > > > >> > > >>> > > > >> > > >> >>>> >>>> our
> > > > > > > >> > > >>> > > > >> > interface.
> > > > > > > >> > > >>> > > > >> > > >> E.g.
> > > > > > > >> > > >>> > > > >> > > >> >>>> >>>> alternative is to have a
> > > > > "getView()"
> > > > > > > >> > > >>> > > > >> > > >> >>>> >>>> method
> > > > > > > >> > > on
> > > > > > > >> > > >>> the
> > > > > > > >> > > >>> > > > >> > interface.
> > > > > > > >> > > >>> > > > >> > > >> Might
> > > > > > > >> > > >>> > > > >> > > >> >>>> help
> > > > > > > >> > > >>> > > > >> > > >> >>>> >>>> to
> > > > > > > >> > > >>> > > > >> > > >> >>>> >>>> cut down on file sizes,
> and
> > > API
> > > > > > > surface,
> > > > > > > >> > but
> > > > > > > >> > > >>> > > > >> > > >> >>>> >>>> again, I'm not too
> > > > > > > >> > > >>> > > > >> > > >> sure.
> > > > > > > >> > > >>> > > > >> > > >> >>>> >>>>
> > > > > > > >> > > >>> > > > >> > > >> >>>> >>>> I've been pretty hesitant
> to
> > > touch
> > > > > > > >> > > >>> > > > >> > > >> >>>> >>>> existing
> > > > > > > >> > > >>> > > > >> > > >> >>>> >>>> exposed members
> > > > > > > >> > > >>> > > > >> > > >> (e.g. the
> > > > > > > >> > > >>> > > > >> > > >> >>>> >>>> public fields you were
> > > referring
> > > > > to)
> > > > > > > >> > > >>> > > > >> > > >> >>>> >>>> since
> > > > > > > >> > > >>> > > > >> > > >> >>>> >>>> touching anything
> > > > > > > >> > > >>> > > > >> > > >> public
> > > > > > > >> > > >>> > > > >> > > >> >>>> could
> > > > > > > >> > > >>> > > > >> > > >> >>>> >>>> break plugins. That said,
> > > maybe
> > > > > now
> > > > > > > is a
> > > > > > > >> > good
> > > > > > > >> > > >>> time
> > > > > > > >> > > >>> > > > >> > > >> >>>> >>>> to @deprecate
> > > > > > > >> > > >>> > > > >> > > >> a
> > > > > > > >> > > >>> > > > >> > > >> >>>> bunch
> > > > > > > >> > > >>> > > > >> > > >> >>>> >>>> of
> > > > > > > >> > > >>> > > > >> > > >> >>>> >>>> them and either replace
> them
> > > with
> > > > > > > >> > > >>> > > > >> > > >> >>>> >>>> getters,
> > > > > > > >> > or
> > > > > > > >> > > >>> just
> > > > > > > >> > > >>> > > > >> > > >> >>>> >>>> declare them
> > > > > > > >> > > >>> > > > >> > > >> to be
> > > > > > > >> > > >>> > > > >> > > >> >>>> not
> > > > > > > >> > > >>> > > > >> > > >> >>>> >>>> exposed to plugins.
> > > > > > > >> > > >>> > > > >> > > >> >>>> >>>>
> > > > > > > >> > > >>> > > > >> > > >> >>>> >>>>
> > > > > > > >> > > >>> > > > >> > > >> >>>> >>>> On Wed, Mar 5, 2014 at
> 6:57
> > > PM,
> > > > > Joe
> > > > > > > >> > > >>> > > > >> > > >> >>>> >>>> Bowser
> > > > > > > >> > > >>> > > > >> > > >> >>>> >>>> <bowserj@gmail.com
> <mailto:
> > > > > > > bowserj@gmail.com>>
> > > > > > > >> > > >>> > > > >> > > >> wrote:
> > > > > > > >> > > >>> > > > >> > > >> >>>> >>>>
> > > > > > > >> > > >>> > > > >> > > >> >>>> >>>> > So, after looking at the
> > > > > Crosswalk
> > > > > > > >> > > >>> > > > >> > > >> >>>> >>>> > code
> > > > > > > >> > > again,
> > > > > > > >> > > >>> > > > >> > > >> >>>> >>>> > I've decided to
> > > > > > > >> > > >>> > > > >> > > >> take
> > > > > > > >> > > >>> > > > >> > > >> >>>> a
> > > > > > > >> > > >>> > > > >> > > >> >>>> >>>> > quick stab at making
> things
> > > > > > > pluggable.
> > > > > > > >> > > >>> > > > >> > > >> >>>> >>>> > I
> > > > > > > >> > > don't
> > > > > > > >> > > >>> > > > >> > > >> >>>> >>>> > have a lot to
> > > > > > > >> > > >>> > > > >> > > >> show
> > > > > > > >> > > >>> > > > >> > > >> >>>> for
> > > > > > > >> > > >>> > > > >> > > >> >>>> >>>> > it, but with the help of
> > > Eclipse
> > > > > > > >> > > >>> > > > >> > > >> >>>> >>>> > (which
> > > > > > > >> > is
> > > > > > > >> > > why
> > > > > > > >> > > >>> > > > >> > > >> >>>> >>>> > the generated interfaces
> > > look so
> > > > > > > >> > > >>> > > > >> > > >> >>>> >>>> > screwed
> > > > > > > >> > > up), I
> > > > > > > >> > > >>> > > > >> > > >> >>>> >>>> > managed to create some
> > > > > > > >> > > >>> > > > >> > > >> interfaces
> > > > > > > >> > > >>> > > > >> > > >> >>>> so
> > > > > > > >> > > >>> > > > >> > > >> >>>> >>>> > we can start
> shoehorning in
> > > > > other
> > > > > > > >> > > >>> > > > >> > > >> >>>> >>>> > browser
> > > > > > > >> > > >>> > renderers.
> > > > > > > >> > > >>> > > > >> > > >> >>>> >>>> >
> > > > > > > >> > > >>> > > > >> > > >> >>>> >>>> >
> > > > > > > >> > > >>> > > > >> > > >>
> > > > > > > >> > > >>>
> > > > > https://github.com/infil00p/cordova-android/tree/pluggable_w
> > > > > > > >> > > >>> > > > >> > > >> eb
> > > > > > > >> > > >>> > > > >> > > >> vie
> > > > > > > >> > > >>> > > > >> > > >> w
> > > > > > > >> > > >>> > > > >> > > >> >>>> >>>> >
> > > > > > > >> > > >>> > > > >> > > >> >>>> >>>> > I'm going to probably
> start
> > > with
> > > > > > > >> > Crosswalk,
> > > > > > > >> > > >>> > > > >> > > >> >>>> >>>> > because it's
> > > > > > > >> > > >>> > > > >> > > >> probably
> > > > > > > >> > > >>> > > > >> > > >> >>>> the
> > > > > > > >> > > >>> > > > >> > > >> >>>> >>>> > most mature primary
> > > candidate in
> > > > > > the
> > > > > > > >> > > Android
> > > > > > > >> > > >>> > > > >> > > >> >>>> >>>> > Third-Party
> > > > > > > >> > > >>> > > > >> > > >> WebView
> > > > > > > >> > > >>> > > > >> > > >> >>>> >>>> > thing, and I'm pretty
> sure
> > > the
> > > > > > > >> > > >>> > > > >> > > >> >>>> >>>> > GeckoView
> > > > > > > >> > > will
> > > > > > > >> > > >>> be
> > > > > > > >> > > >>> > > > >> > > >> >>>> >>>> > happening
> > > > > > > >> > > >>> > > > >> > > >> shortly
> > > > > > > >> > > >>> > > > >> > > >> >>>> >>>> > after.
> > > > > > > >> > > >>> > > > >> > > >> >>>> >>>> >
> > > > > > > >> > > >>> > > > >> > > >> >>>> >>>> > I don't know how this
> would
> > > work
> > > > > > > >> > > >>> > > > >> > > >> >>>> >>>> > w.r.t.
> > > > > > > >> > > the CLI
> > > > > > > >> > > >>> > > > >> > > >> >>>> >>>> > or our
> > > > > > > >> > > >>> > > > >> > > >> workflow at
> > > > > > > >> > > >>> > > > >> > > >> >>>> >>>> > all, but at the moment,
> I
> > > really
> > > > > > > just
> > > > > > > >> > want
> > > > > > > >> > > to
> > > > > > > >> > > >>> at
> > > > > > > >> > > >>> > > > >> > > >> >>>> >>>> > least start
> > > > > > > >> > > >>> > > > >> > > >> to have
> > > > > > > >> > > >>> > > > >> > > >> >>>> >>>> > some headway towards
> 4.x and
> > > > > > > PhoneGap
> > > > > > > >> > day.
> > > > > > > >> > > >>> > > > >> > > >> >>>> >>>> >
> > > > > > > >> > > >>> > > > >> > > >> >>>> >>>> > What do people think of
> > > this so
> > > > > > far?
> > > > > > > >> > > >>> > > > >> > > >> >>>> >>>> > I'm
> > > > > > > >> > > going
> > > > > > > >> > > >>> > > > >> > > >> >>>> >>>> > to try to clean
> > > > > > > >> > > >>> > > > >> > > >> >>>> things
> > > > > > > >> > > >>> > > > >> > > >> >>>> >>>> > up a bit, since we've
> > > definitely
> > > > > > > done
> > > > > > > >> > > >>> > > > >> > > >> >>>> >>>> > a
> > > > > > > >> > > lot of
> > > > > > > >> > > >>> > > > >> > > >> >>>> >>>> > things that
> > > > > > > >> > > >>> > > > >> > > >> would
> > > > > > > >> > > >>> > > > >> > > >> >>>> make
> > > > > > > >> > > >>> > > > >> > > >> >>>> >>>> > first year CS profs
> freak
> > > the
> > > > > hell
> > > > > > > out
> > > > > > > >> > > (i.e.
> > > > > > > >> > > >>> > > > >> > > >> >>>> >>>> > public members in
> > > > > > > >> > > >>> > > > >> > > >> >>>> public
> > > > > > > >> > > >>> > > > >> > > >> >>>> >>>> > objects w.r.t.
> > > PluginManager).
> > > > > > > >> > > >>> > > > >> > > >> >>>> >>>> >
> > > > > > > >> > > >>> > > > >> > > >> >>>> >>>> > Thoughts?
> > > > > > > >> > > >>> > > > >> > > >> >>>> >>>> >
> > > > > > > >> > > >>> > > > >> > > >> >>>> >>>> > Joe
> > > > > > > >> > > >>> > > > >> > > >> >>>> >>>> >
> > > > > > > >> > > >>> > > > >> > > >> >>>> >>>>
> > > > > > > >> > > >>> > > > >> > > >> >>>> >>>
> > > > > > > >> > > >>> > > > >> > > >> >>>> >>>
> > > > > > > >> > > >>> > > > >> > > >> >>>>
> > > > > > > >> > > >>> > > > >> > > >>
> > > > > > > >> > > >>> > > > >> >
> > > > > > > >> > > >>> >
> > > > > > > >> > > >>>
> > > > > > > >> > >
> > > > > > > >> >
> > > > > > > >
> > > > > > > >
> > > > > > >
> > > > > > >
> > > > > >
> > > > >
> > >
>

RE: [Android] Refactoring for different engines

["Hu, Ningxin" <ni...@intel.com>]

Please let me know if we agree with this time (9am Pacific, 12am Eastern and 0am China)? I will stay till mid-night, but maybe not to next morning :p.

Thanks,
-ningxin

> -----Original Message-----
> From: iclelland@google.com [mailto:iclelland@google.com] On Behalf Of Ian
> Clelland
> Sent: Thursday, April 24, 2014 8:58 PM
> To: dev@cordova.apache.org
> Subject: Re: [Android] Refactoring for different engines
> 
> On Thu, Apr 24, 2014 at 1:10 AM, Hu, Ningxin <ni...@intel.com> wrote:
> 
> > Understood.
> >
> > How about 9am Pacific, 12am Eastern and 0am China? Really appreciate.
> >
> 
> That time would probably work better for me than 7 hours later.
> 
> Ian
> 
> 
> >
> > Thanks,
> > -ningxin
> >
> > > -----Original Message-----
> > > From: mmocny@google.com [mailto:mmocny@google.com] On Behalf Of
> > > Michal Mocny
> > > Sent: Thursday, April 24, 2014 11:45 AM
> > > To: dev
> > > Subject: Re: [Android] Refactoring for different engines
> > >
> > > (Yeah 7pm Friday is more naughty than 4am for those of us with
> > > families.)
> > >
> > > I think the original intent was just supposed to be a meet & greet right?
> > >  Lets just do it asap and consider formal scheduling with ample
> > > planning
> > only if
> > > there are technical topics to discuss.
> > >
> > > It would be nice, though, if Ian could make it, given his recent
> > > work on
> > this.
> > >
> > > -Michal
> > >
> > >
> > > On Wed, Apr 23, 2014 at 10:34 PM, Victor Sosa
> > ><sosah.victor@gmail.com
> > >wrote:
> > >
> > > > 4PM PST? That's 6 CST or 7 EST, me thinks. Seems to work for many
> > > > of us On Apr 23, 2014 8:49 PM, "Brian LeRoux" <b...@brian.io> wrote:
> > > >
> > > > > 4pm works for me…
> > > > >
> > > > >
> > > > > On Wed, Apr 23, 2014 at 6:19 PM, Hu, Ningxin
> > > > > <ni...@intel.com>
> > > > wrote:
> > > > >
> > > > > > I am in China. 1:00 PM PST means 4:00 AM here :o.
> > > > > > Could you please schedule it a little bit later, say 4:00 or
> > > > > > 5:00 PM
> > > > PST?
> > > > > > It will be highly appreciated.
> > > > > >
> > > > > > Thanks,
> > > > > > -ningxin
> > > > > >
> > > > > > From: brian.leroux@gmail.com [mailto:brian.leroux@gmail.com]
> > > > > > On Behalf
> > > > > Of
> > > > > > Brian LeRoux
> > > > > > Sent: Thursday, April 24, 2014 6:10 AM
> > > > > > To: Joe Bowser
> > > > > > Cc: dev@cordova.apache.org; Hu, Ningxin
> > > > > > Subject: Re: [Android] Refactoring for different engines
> > > > > >
> > > > > > How does 1:00PST on Friday work for a hangout for everyone?
> > > > > >
> > > > > > On Wed, Apr 23, 2014 at 2:36 PM, Joe Bowser <bowserj@gmail.com
> > <mailto:
> > > > > > bowserj@gmail.com>> wrote:
> > > > > > BTW: Here's my PoC for Mozilla so far.  It's very broken!
> > > > > >
> > > > > > https://github.com/infil00p/MozillaView
> > > > > >
> > > > > >
> > > > > >
> > > > > > On Wed, Apr 23, 2014 at 10:50 AM, Brian LeRoux <b@brian.io<mailto:
> > > > > > b@brian.io>> wrote:
> > > > > > > So I found a Moz hacker whom can help. what time on Fri do
> > > > > > > you guys
> > > > > want
> > > > > > to
> > > > > > > do this?
> > > > > > >
> > > > > > >
> > > > > > > On Wed, Apr 23, 2014 at 10:31 AM, Ian Clelland <
> > > > iclelland@chromium.org
> > > > > > <ma...@chromium.org>>
> > > > > > > wrote:
> > > > > > >>
> > > > > > >> I've managed to get this up and running now -- great work
> > > > > > >> on this,
> > > > > Joe!
> > > > > > >>
> > > > > > >> Mobilespec runs on my N4, with 10 failing tests: 3 in
> > > > > > >> contacts;
> > > > > > >> 7 in file-transfer. Otherwise, things seem to be working
> > > > > > >> pretty
> > well.
> > > > > > >>
> > > > > > >> I used a new build of Crosswalk, and found that the
> > > > > > >> embedding API
> > > > has
> > > > > > >> changed since the weekend (when Ningxin's patches applied).
> > > > > > >> I've
> > > > > issued
> > > > > > a
> > > > > > >> pull request at
> > > > > > >> https://github.com/infil00p/cordova-crosswalk-engine/pull/5
> > > > > > >> for
> > > > > > >> it
> > > > --
> > > > > > >>
> > > > > > >> I'm not sure if there's a way to keep compatibility with
> > > > > > >> last week's Crosswalk, or if we'd even want to. (Ningxin,
> > > > > > >> if you could
> > > > > take a
> > > > > > >> look at that PR and see if it makes sense, I'd appreciate
> > > > > > >> it)
> > > > > > >>
> > > > > > >> Joe, I also had to patch the default constructor for
> > > > > > XWalkCordovaWebView;
> > > > > > >> it wasn't creating its own client objects, so it got the
> > > > > > >> default
> > > > ones,
> > > > > > and
> > > > > > >> most of the tests were failing because some component of
> > > > > > >> the bridge
> > > > > > wan't
> > > > > > >> working.
> > > > https://github.com/infil00p/cordova-crosswalk-engine/pull/4is
> > > > > > >> out
> > > > > > >> for that.
> > > > > > >>
> > > > > > >> Count me in for the hangout -- this is exciting stuff
> > > > > > >>
> > > > > > >> Ian
> > > > > > >>
> > > > > > >>
> > > > > > >> On Wed, Apr 23, 2014 at 10:26 AM, Brian LeRoux <b@brian.io
> > <mailto:
> > > > > > b@brian.io>> wrote:
> > > > > > >>
> > > > > > >> > Yup I'll track em down
> > > > > > >> > On Apr 23, 2014 7:17 AM, "Andrew Grieve"
> > > > > > >> > <agrieve@chromium.org
> > > > > > <ma...@chromium.org>> wrote:
> > > > > > >> >
> > > > > > >> > > Does anyone have a contact at moz that we could invite?
> > > > > > >> > >
> > > > > > >> > > On Wed, Apr 23, 2014 at 10:09 AM, Andrew Grieve <
> > > > > > agrieve@chromium.org<ma...@chromium.org>>
> > > > > > >> > > wrote:
> > > > > > >> > > > Depends on their interest level I think. Faster we
> > > > > > >> > > > can get
> > > > this
> > > > > > out
> > > > > > >> > > > the door the better. If we need to delay for
> > > > > > >> > > > geckoview, then I
> > > > > > don't
> > > > > > >> > > > think we should gate on it, just release it after.
> > > > > > >> > > >
> > > > > > >> > > > On Wed, Apr 23, 2014 at 3:01 AM, Tommy Williams <
> > > > > > tommy@devgeeks.org<ma...@devgeeks.org>>
> > > > > > >> > > wrote:
> > > > > > >> > > >> More engines, more better...
> > > > > > >> > > >> On 23 Apr 2014 16:32, "Joe Bowser"
> > > > > > >> > > >> <bowserj@gmail.com
> > > > <mailto:
> > > > > > bowserj@gmail.com>> wrote:
> > > > > > >> > > >>
> > > > > > >> > > >>> Hey
> > > > > > >> > > >>>
> > > > > > >> > > >>> A Hangout would have to happen on Friday at the
> > earliest.
> > > > >  It'd
> > > > > > be
> > > > > > >> > > good if
> > > > > > >> > > >>> we could get someone from Mozilla on the hangout as
> > > > > > >> > > >>> well.  I haven't
> > > > > > >> > > gotten
> > > > > > >> > > >>> MozillaView (GeckoView with Cordova methods) fully
> > > > > > >> > > >>> working
> > > > > yet.
> > > > > > >> > > >>> For
> > > > > > >> > > some
> > > > > > >> > > >>> reason it's not rendering on the screen.
> > > > > > >> > > >>>
> > > > > > >> > > >>> Ideally it'd be cool to have at least two options
> > > > > > >> > > >>> when this feature
> > > > > > >> > > finally
> > > > > > >> > > >>> lands.
> > > > > > >> > > >>>
> > > > > > >> > > >>> What do other people think?
> > > > > > >> > > >>>
> > > > > > >> > > >>> Joe
> > > > > > >> > > >>> On 22 Apr 2014 20:06, "Hu, Ningxin"
> > > > > > >> > > >>> <ningxin.hu@intel.com
> > > > > > <ma...@intel.com>> wrote:
> > > > > > >> > > >>>
> > > > > > >> > > >>> > Joe,
> > > > > > >> > > >>> >
> > > > > > >> > > >>> > Thanks for your review and merge the PRs.
> > > > > > >> > > >>> >
> > > > > > >> > > >>> > To pluggable webview interest group:
> > > > > > >> > > >>> > Are we OK to setup a hangout this week for
> > > > > > >> > > >>> > initial
> > > > > > introduction
> > > > > > >> > > >>> > and
> > > > > > >> > > >>> > discussion of next steps?
> > > > > > >> > > >>> >
> > > > > > >> > > >>> > Thanks,
> > > > > > >> > > >>> > -ningxin
> > > > > > >> > > >>> >
> > > > > > >> > > >>> > > -----Original Message-----
> > > > > > >> > > >>> > > From: Hu, Ningxin [mailto:ningxin.hu@intel.com
> > <mailto:
> > > > > > ningxin.hu@intel.com>]
> > > > > > >> > > >>> > > Sent: Tuesday, April 22, 2014 4:04 PM
> > > > > > >> > > >>> > > To: dev@cordova.apache.org<mailto:
> > > > dev@cordova.apache.org>
> > > > > > >> > > >>> > > Subject: RE: [Android] Refactoring for
> > > > > > >> > > >>> > > different engines
> > > > > > >> > > >>> > >
> > > > > > >> > > >>> > > The PoC is great! Quite excited about the direction!
> > > > > > >> > > >>> > >
> > > > > > >> > > >>> > > I've sent a PR to update the
> > > > > > >> > > >>> > > cordova-crosswalk-engine to latest
> > > > > > >> > > >>> crosswalk
> > > > > > >> > > >>> > > embedding API. It works with xwalk_core_library
> > > > > > >> > > >>> > > at
> > > > > > 6.35.124.0.
> > > > > > >> > > >>> > >
> > > > > > >> > > >>> > > I've also changed the CordovaWebView interface
> > > > > > >> > > >>> > > slightly (adding
> > > > > > >> > > >>> > getView() API)
> > > > > > >> > > >>> > > to allow XWalkCordovaWebView to composite a
> > > > > > >> > > >>> > > XWalkView
> > > > > > instead
> > > > > > >> > > >>> > > of
> > > > > > >> > > >>> > extending
> > > > > > >> > > >>> > > it. It resolves some API naming issues for
> > > > > > >> > > >>> > > XWalkView
> > > > case.
> > > > > > >> > > >>> > >
> > > > > > >> > > >>> > > Please review them at:
> > > > > > >> > > >>> > >
> > > > > https://github.com/infil00p/cordova-crosswalk-engine/pull/3
> > > > > > >> > > >>> > > https://github.com/infil00p/cordova-android/pul
> > > > > > >> > > >>> > > l/2
> > > > > > >> > > >>> > >
> > > > > > >> > > >>> > > Thanks,
> > > > > > >> > > >>> > > -ningxin
> > > > > > >> > > >>> > >
> > > > > > >> > > >>> > > > -----Original Message-----
> > > > > > >> > > >>> > > > From: Joe Bowser [mailto:bowserj@gmail.com
> > <mailto:
> > > > > > bowserj@gmail.com>]
> > > > > > >> > > >>> > > > Sent: Friday, April 11, 2014 12:45 AM
> > > > > > >> > > >>> > > > To: dev
> > > > > > >> > > >>> > > > Subject: Re: [Android] Refactoring for
> > > > > > >> > > >>> > > > different
> > > > engines
> > > > > > >> > > >>> > > >
> > > > > > >> > > >>> > > > Yeah, I'd be cool with setting up a hangout.
> > > > > > >> > > >>> > > > Everyone should
> > > > > > >> > > take a
> > > > > > >> > > >>> > > > look at the PoC, I've basically distilled it
> > > > > > >> > > >>> > > > down to
> > > > > four
> > > > > > or
> > > > > > >> > five
> > > > > > >> > > >>> > > > classes so far, but with some work, we may be
> > > > > > >> > > >>> > > > able to
> > > > > get
> > > > > > it
> > > > > > >> > > down to
> > > > > > >> > > >>> > > > three.  Due to legacy, we're pretty stuck
> > > > > > >> > > >>> > > > with the
> > > > > Android
> > > > > > >> > > WebView
> > > > > > >> > > >>> API
> > > > > > >> > > >>> > calls,
> > > > > > >> > > >>> > > but these can probably be modified.
> > > > > > >> > > >>> > > >
> > > > > > >> > > >>> > > > It'd be good to get Mozilla people on the
> > > > > > >> > > >>> > > > call as
> > > > well,
> > > > > > >> > > >>> > > > since
> > > > > > >> > > they
> > > > > > >> > > >>> > > > have their WebView as well.
> > > > > > >> > > >>> > > >
> > > > > > >> > > >>> > > > On Thu, Apr 10, 2014 at 9:38 AM, Hu, Ningxin
> > > > > > >> > > >>> > > > <
> > > > > > >> > > ningxin.hu@intel.com<ma...@intel.com>>
> > > > > > >> > > >>> > wrote:
> > > > > > >> > > >>> > > > > Hangout would be a good idea.
> > > > > > >> > > >>> > > > >
> > > > > > >> > > >>> > > > > FYI, I will be off next week. How about the
> > > > > > >> > > >>> > > > > week
> > > > after
> > > > > > >> > > >>> > > > > next?
> > > > > > >> > > If it
> > > > > > >> > > >>> > > > > works, please
> > > > > > >> > > >>> > > > feel free to schedule one and count me in.
> > > > > > >> > > >>> > > > >
> > > > > > >> > > >>> > > > > Thanks,
> > > > > > >> > > >>> > > > > -ningxin
> > > > > > >> > > >>> > > > >
> > > > > > >> > > >>> > > > >> -----Original Message-----
> > > > > > >> > > >>> > > > >> From:
> > > > > > >> > > >>> > > > >> mmocny@google.com<mailto:mmocny@google.com
> > > > > > >> > > >>> > > > >> >
> > > > > > [mailto:mmocny@google.com<ma...@google.com>] On
> > > > > > >> > Behalf
> > > > > > >> > > Of
> > > > > > >> > > >>> > > > >> Michal Mocny
> > > > > > >> > > >>> > > > >> Sent: Tuesday, April 08, 2014 11:39 PM
> > > > > > >> > > >>> > > > >> To: dev
> > > > > > >> > > >>> > > > >> Subject: Re: [Android] Refactoring for
> > > > > > >> > > >>> > > > >> different
> > > > > > engines
> > > > > > >> > > >>> > > > >>
> > > > > > >> > > >>> > > > >> Would it be alright to set up a Hangout
> > > > > > >> > > >>> > > > >> some time
> > > > to
> > > > > > >> > introduce
> > > > > > >> > > >>> > everyone?
> > > > > > >> > > >>> > > > >>
> > > > > > >> > > >>> > > > >> Joe has been leading the effort here, but
> > > > > > >> > > >>> > > > >> there are
> > > > > > other
> > > > > > >> > > cordova
> > > > > > >> > > >>> > > > >> contributors for whom this is top priority.
> > > > > > >> > > >>> > > > >> It
> > > > would
> > > > > > be
> > > > > > >> > nice
> > > > > > >> > > if
> > > > > > >> > > >>> we
> > > > > > >> > > >>> > > > >> could all meet to say hello and make sure
> > > > > > >> > > >>> > > > >> we are
> > > > all
> > > > > > >> > > >>> > > > >> going
> > > > > > >> > in
> > > > > > >> > > the
> > > > > > >> > > >>> > > > >> right
> > > > > > >> > > >>> > > > direction.
> > > > > > >> > > >>> > > > >>
> > > > > > >> > > >>> > > > >> Quite exciting!
> > > > > > >> > > >>> > > > >>
> > > > > > >> > > >>> > > > >> -Michal
> > > > > > >> > > >>> > > > >>
> > > > > > >> > > >>> > > > >>
> > > > > > >> > > >>> > > > >> On Tue, Apr 8, 2014 at 10:56 AM, Hu,
> > > > > > >> > > >>> > > > >> Ningxin <
> > > > > > >> > > >>> ningxin.hu@intel.com<ma...@intel.com>>
> > > > > > >> > > >>> > > wrote:
> > > > > > >> > > >>> > > > >>
> > > > > > >> > > >>> > > > >> > Joe, thanks for this. I am very excited.
> > > > > > >> > > >>> > > > >> >
> > > > > > >> > > >>> > > > >> > FYI. Crosswalk team is working on
> > > > > > >> > > >>> > > > >> > refactoring the WebView
> > > > > > >> > > API to
> > > > > > >> > > >>> > > > >> > support embedding usage better [1].
> > > > > > >> > > >>> > > > >> > (Previously
> > > > the
> > > > > > >> > > >>> > > > >> > layer
> > > > > > >> > > API
> > > > > > >> > > >>> was
> > > > > > >> > > >>> > > > >> > not exposed as public usage).
> > > > > > >> > > >>> > > > >> >
> > > > > > >> > > >>> > > > >> > I would like to review the PoC and work
> > > > > > >> > > >>> > > > >> > with you
> > > > to
> > > > > > get
> > > > > > >> > > >>> Crosswalk
> > > > > > >> > > >>> > > > >> > fits into the pluggable WebView architecture.
> > > > > > >> > > >>> > > > >> >
> > > > > > >> > > >>> > > > >> > Thanks,
> > > > > > >> > > >>> > > > >> > -ningxin
> > > > > > >> > > >>> > > > >> >
> > > > > > >> > > >>> > > > >> > > -----Original Message-----
> > > > > > >> > > >>> > > > >> > > From: Joe Bowser
> > > > > > >> > > >>> > > > >> > > [mailto:bowserj@gmail.com
> > > > > <mailto:
> > > > > > bowserj@gmail.com>]
> > > > > > >> > > >>> > > > >> > > Sent: Wednesday, March 19, 2014 7:08
> > > > > > >> > > >>> > > > >> > > AM
> > > > > > >> > > >>> > > > >> > > To: dev
> > > > > > >> > > >>> > > > >> > > Subject: Re: [Android] Refactoring for
> > > > different
> > > > > > >> > > >>> > > > >> > > engines
> > > > > > >> > > >>> > > > >> > >
> > > > > > >> > > >>> > > > >> > > Hey
> > > > > > >> > > >>> > > > >> > >
> > > > > > >> > > >>> > > > >> > > After debugging, I did some minor
> > > > > > >> > > >>> > > > >> > > updates to
> > > > the
> > > > > > >> > > >>> > > > >> > > plugin
> > > > > > >> > > >>> README.
> > > > > > >> > > >>> > > > >> > > It
> > > > > > >> > > >>> > > > >> > should be
> > > > > > >> > > >>> > > > >> > > easier to get this up and running,
> > > > > > >> > > >>> > > > >> > > although
> > > > > there's
> > > > > > >> > still
> > > > > > >> > > the
> > > > > > >> > > >>> > > > >> > > issue of
> > > > > > >> > > >>> > > > >> > after-install
> > > > > > >> > > >>> > > > >> > > hooks and the relative path weirdness
> > > > > > >> > > >>> > > > >> > > with the Crosswalk
> > > > > > >> > > >>> > Library itself.
> > > > > > >> > > >>> > > > >> > >
> > > > > > >> > > >>> > > > >> > > It still doesn't support the CLI at
> > > > > > >> > > >>> > > > >> > > all, but it should
> > > > > > >> > be
> > > > > > >> > > >>> there
> > > > > > >> > > >>> > > > >> > > with the
> > > > > > >> > > >>> > > > >> > old flow.
> > > > > > >> > > >>> > > > >> > >
> > > > > > >> > > >>> > > > >> > > On Mon, Mar 17, 2014 at 1:14 PM,
> > > > > > >> > > >>> > > > >> > > Michal Mocny
> > > > > > >> > > >>> > > > >> > > <mmocny@chromium.org<mailto:
> > > > mmocny@chromium.org
> > > > > >>
> > > > > > >> > > >>> > > > >> > > wrote:
> > > > > > >> > > >>> > > > >> > > > (Sorry Joe, Googlers are down in
> > > > > > >> > > >>> > > > >> > > > California
> > > > and
> > > > > > way
> > > > > > >> > > busy.
> > > > > > >> > > >>> > > > >> > > > Will be back in a week.  Super
> > > > > > >> > > >>> > > > >> > > > excited about
> > > > > > this,
> > > > > > >> > > though.)
> > > > > > >> > > >>> > > > >> > > >
> > > > > > >> > > >>> > > > >> > > > -Michal
> > > > > > >> > > >>> > > > >> > > >
> > > > > > >> > > >>> > > > >> > > >
> > > > > > >> > > >>> > > > >> > > > On Mon, Mar 17, 2014 at 2:53 PM, Joe
> > > > > > >> > > >>> > > > >> > > > Bowser
> > > > > > >> > > >>> > > > >> > > > <bowserj@gmail.com<mailto:bowserj@gmail.
> > > > > > >> > > >>> > > > >> > > > com
> > > > >>
> > > > > > >> > > >>> > > > >> wrote:
> > > > > > >> > > >>> > > > >> > > >
> > > > > > >> > > >>> > > > >> > > >> Reviving this thread!
> > > > > > >> > > >>> > > > >> > > >>
> > > > > > >> > > >>> > > > >> > > >> Can other people look at this, and
> > > > > > >> > > >>> > > > >> > > >> see
> > > > if/when
> > > > > > we
> > > > > > >> > > should
> > > > > > >> > > >>> > land this?
> > > > > > >> > > >>> > > > >> > > >> I know that I have to re-write the
> > > > > > >> > > >>> > > > >> > > >> tests
> > > > > still,
> > > > > > >> > > >>> > > > >> > > >> but I
> > > > > > >> > > would
> > > > > > >> > > >>> > > > >> > > >> like some feedback before merging it in.
> > > > >  Also,
> > > > > > >> > > >>> > > > >> > > >> it'd
> > > > > > >> > be
> > > > > > >> > > >>> > > > >> > > >> super awesome if other people could
> > > > > > >> > > >>> > > > >> > > >> try and
> > > > > > make a
> > > > > > >> > > WebView
> > > > > > >> > > >>> > > > >> > > >> based on the interfaces and
> > > > > > >> > > >>> > > > >> > > >> recommend which methods
> > > > > > >> > > should
> > > > > > >> > > >>> > > > >> > > >> die.  I want to get this released
> > > > > > >> > > >>> > > > >> > > >> in the
> > > > next
> > > > > > >> > > >>> > > > >> > > >> month
> > > > > > >> > or
> > > > > > >> > > so,
> > > > > > >> > > >>> > > > >> > > >> so any time and feedback would be
> > > > > > >> > > >>> > > > >> > > >> greatly
> > > > > > >> > appreciated.
> > > > > > >> > > >>> > > > >> > > >>
> > > > > > >> > > >>> > > > >> > > >> Thanks
> > > > > > >> > > >>> > > > >> > > >>
> > > > > > >> > > >>> > > > >> > > >> On Thu, Mar 13, 2014 at 3:50 PM,
> > > > > > >> > > >>> > > > >> > > >> Joe Bowser
> > > > > > >> > > >>> > > > >> > > >> <bowserj@gmail.com<mailto:bowserj@g
> > > > > > >> > > >>> > > > >> > > >> mail .com
> > > > >>
> > > > > > >> > > >>> > > > >> > wrote:
> > > > > > >> > > >>> > > > >> > > >> > Hey, I created the following
> > > > > > >> > > >>> > > > >> > > >> > today to
> > > > track
> > > > > > >> > > >>> > > > >> > > >> > various WebView
> > > > > > >> > > >>> > > > >> > progresses:
> > > > > > >> > > >>> > > > >> > > >> >
> > > > > https://issues.apache.org/jira/browse/CB-6246
> > > > > > >> > > >>> > > > >> > > >> >
> > > > > > >> > > >>> > > > >> > > >> > I also have this repo created.
> > > > > > >> > > >>> > > > >> > > >> > The
> > > > > licensing
> > > > > > is
> > > > > > >> > > ugly as
> > > > > > >> > > >>> > > > >> > > >> > all crap, but it's a Proof-Of-Concept:
> > > > > > >> > > >>> > > > >> > > >> >
> > > > > > >> > https://github.com/infil00p/cordova-crosswalk-engine
> > > > > > >> > > >>> > > > >> > > >> >
> > > > > > >> > > >>> > > > >> > > >> > If I can get some help getting
> > plugman to
> > > > > just
> > > > > > >> > > >>> > > > >> > > >> > load Crosswalk, it'll
> > > > > > >> > > >>> > > > >> > > >> look hawt.
> > > > > > >> > > >>> > > > >> > > >> >
> > > > > > >> > > >>> > > > >> > > >> > BTW: We should probably get this
> > ready to
> > > > go
> > > > > > >> > > >>> > > > >> > > >> > into
> > > > > > >> > > Android
> > > > > > >> > > >>> > > > >> > > >> > in the next two months and deprecate
> > the
> > > > > > >> > setProperty
> > > > > > >> > > >>> > > > >> > > >> > methods, since all properties should
> > be
> > > > > > >> > > >>> > > > >> > > >> > preferences
> > > > > > >> > > in
> > > > > > >> > > >>> > config.xml
> > > > > > >> > > >>> > > now.
> > > > > > >> > > >>> > > > >> > > >> >
> > > > > > >> > > >>> > > > >> > > >> > On Mon, Mar 10, 2014 at 2:42 PM, Joe
> > > > Bowser
> > > > > > >> > > >>> > > > >> > > >> > <bowserj@gmail.com<mailto:
> > > > bowserj@gmail.com
> > > > > >>
> > > > > > >> > > >>> > > > >> > > wrote:
> > > > > > >> > > >>> > > > >> > > >> >> Perhaps. There would be additional
> > > > benefits
> > > > > > to
> > > > > > >> > this
> > > > > > >> > > >>> > > > >> > > >> >> approach, namely fixes being added to
> > > > that
> > > > > > >> > platform
> > > > > > >> > > more
> > > > > > >> > > >>> > > > >> > > >> >> quickly.  I'll probably take a look
> > at
> > > > that
> > > > > > >> > > >>> > > > >> > > >> >> once I
> > > > > > >> > > have
> > > > > > >> > > >>> > > > >> > > >> >> Crosswalk
> > > > > > >> > > >>> > > > finalized.
> > > > > > >> > > >>> > > > >> > > >> >>
> > > > > > >> > > >>> > > > >> > > >> >> On Mon, Mar 10, 2014 at 9:49 AM,
> > Brian
> > > > > LeRoux
> > > > > > >> > > >>> > > > >> > > >> >> <b@...@brian.io>>
> > > > > > >> > > >>> > > > wrote:
> > > > > > >> > > >>> > > > >> > > >> >>> this is great stuff
> > > > > > >> > > >>> > > > >> > > >> >>>
> > > > > > >> > > >>> > > > >> > > >> >>> do we think it may be possible to
> > bring
> > > > in
> > > > > > >> > > >>> > > > >> > > >> >>> amazon
> > > > > > >> > > >>> fireos
> > > > > > >> > > >>> > > > >> > > >> >>> stuff
> > > > > > >> > > >>> > > > >> > > >> eventually
> > > > > > >> > > >>> > > > >> > > >> >>> too?
> > > > > > >> > > >>> > > > >> > > >> >>>
> > > > > > >> > > >>> > > > >> > > >> >>>
> > > > > > >> > > >>> > > > >> > > >> >>> On Fri, Mar 7, 2014 at 3:22 PM, Joe
> > > > Bowser
> > > > > > >> > > >>> > > > >> > > >> >>> <bowserj@gmail.com<mailto:
> > > > > bowserj@gmail.com
> > > > > > >>
> > > > > > >> > > >>> > > > >> > wrote:
> > > > > > >> > > >>> > > > >> > > >> >>>
> > > > > > >> > > >>> > > > >> > > >> >>>> BTW: I committed it in my repo,
> > not the
> > > > > > main
> > > > > > >> > > Apache
> > > > > > >> > > >>> one.
> > > > > > >> > > >>> > > > >> > > >> >>>>
> > > > > > >> > > >>> > > > >> > > >> >>>> On Fri, Mar 7, 2014 at 3:21 PM, Joe
> > > > > Bowser
> > > > > > >> > > >>> > > > >> > > >> >>>> <bowserj@gmail.com<mailto:
> > > > > > bowserj@gmail.com>>
> > > > > > >> > > >>> > > > >> > > wrote:
> > > > > > >> > > >>> > > > >> > > >> >>>> > Hey
> > > > > > >> > > >>> > > > >> > > >> >>>> >
> > > > > > >> > > >>> > > > >> > > >> >>>> > I just committed some code based
> > on
> > > > > their
> > > > > > >> > > WebView
> > > > > > >> > > >>> > > > >> > > >> >>>> > modifications that allows you to
> > > > choose
> > > > > > >> > > >>> > > > >> > > >> >>>> > your
> > > > > > >> > > >>> renderer
> > > > > > >> > > >>> > > > >> > > >> >>>> > in the
> > > > > > >> > > >>> > > > >> > config file
> > > > > > >> > > >>> > > > >> > > with this:
> > > > > > >> > > >>> > > > >> > > >> >>>> >
> > > > > > >> > > >>> > > > >> > > >> >>>> >     <preference name="webView"
> > > > > > >> > > >>> > > > >> > > >> >>>> >
> > > > > > >> > > >>> value="org.apache.cordova.engine.crosswalk.XWalkCordo
> > > > > > >> > > >>> > > > >> > > >> >>>> > va
> > > > > > >> > > >>> > > > >> > > >> >>>> > Web
> > > > > > >> > > >>> > > > >> > > >> >>>> > View
> > > > > > >> > > >>> > > > >> > > >> >>>> > " />
> > > > > > >> > > >>> > > > >> > > >> >>>> >
> > > > > > >> > > >>> > > > >> > > >> >>>> > You currently have to copy over
> > the
> > > > > *.pak
> > > > > > >> > > >>> > > > >> > > >> >>>> > file
> > > > > > >> > > and
> > > > > > >> > > >>> > > > >> > > >> >>>> > the jsapi from a Crosswalk
> > Example
> > > > > > project
> > > > > > >> > > >>> > > > >> > > >> >>>> > to
> > > > > > >> > > get
> > > > > > >> > > >>> > > > >> > > >> >>>> > this to work.  The next thing
> > that
> > > > I'm
> > > > > > >> > > >>> > > > >> > > >> >>>> > going
> > > > > > >> > to
> > > > > > >> > > do
> > > > > > >> > > >>> is
> > > > > > >> > > >>> > > > >> > > >> >>>> > figure out how to write this as a
> > > > > plugin
> > > > > > >> > > >>> > > > >> > > >> >>>> > and
> > > > > > >> > > have it
> > > > > > >> > > >>> > > > >> > > >> >>>> > install on a default
> > > > > > >> > > >>> > > > project.
> > > > > > >> > > >>> > > > >> > > >> >>>> > Also, right now the bridge
> > doesn't
> > > > seem
> > > > > > to
> > > > > > >> > > work, and
> > > > > > >> > > >>> > > > >> > > >> >>>> > I don't know why exactly.  That
> > being
> > > > > > said,
> > > > > > >> > the
> > > > > > >> > > >>> > > > >> > > >> fact
> > > > > > >> > > >>> > > > >> > > >> >>>> > that I can choose which version
> > of
> > > > > > >> > > Chrome/Chromium
> > > > > > >> > > >>> > > > >> > > >> >>>> > I'm running with
> > > > > > >> > > >>> > > > >> > > >> a
> > > > > > >> > > >>> > > > >> > > >> >>>> > single XML preference is HUGE.
> > > > > > >> > > >>> > > > >> > > >> >>>> >
> > > > > > >> > > >>> > > > >> > > >> >>>> > There's definitely a lot more
> > work
> > > > that
> > > > > > >> > > >>> > > > >> > > >> >>>> > needs
> > > > > > >> > > to be
> > > > > > >> > > >>> > > > >> > > >> >>>> > done, but as
> > > > > > >> > > >>> > > > >> > > >> long
> > > > > > >> > > >>> > > > >> > > >> >>>> > as we have something that we can
> > fit
> > > > > into
> > > > > > >> > > >>> > > > >> > > >> >>>> > the
> > > > > > >> > > >>> > > > >> > > >> >>>> > interface, we should
> > > > > > >> > > >>> > > > >> > > >> be
> > > > > > >> > > >>> > > > >> > > >> >>>> > able to put in things like
> > GeckoView
> > > > or
> > > > > > >> > > >>> > > > >> > > >> >>>> > other
> > > > > > >> > > third
> > > > > > >> > > >>> > > > >> > > >> >>>> > party
> > > > > > >> > > >>> > > > >> > renderers.
> > > > > > >> > > >>> > > > >> > > >> >>>> > The nightmare of being stuck with
> > > > > > bullshit
> > > > > > >> > > WebView
> > > > > > >> > > >>> > > > >> > > >> >>>> > bugs may soon be over.
> > > > > > >> > > >>> > > > >> > > >> >>>> >
> > > > > > >> > > >>> > > > >> > > >> >>>> > On Wed, Mar 5, 2014 at 8:59 PM,
> > > > Michal
> > > > > > >> > > >>> > > > >> > > >> >>>> > Mocny
> > > > > > >> > > >>> > > > >> > > >> >>>> > <mmocny@chromium.org<mailto:
> > > > > > mmocny@chromium.org>>
> > > > > > >> > > >>> > > > >> > > >> >>>> wrote:
> > > > > > >> > > >>> > > > >> > > >> >>>> >>
> > > > > > >> > > >>> https://github.com/crosswalk-project/crosswalk-cordo
> > > > > > >> > > >>> > > > >> > > >> >>>> >> va
> > > > > > >> > > >>> > > > >> > > >> >>>> >> -an
> > > > > > >> > > >>> > > > >> > > >> >>>> >> droi
> > > > > > >> > > >>> > > > >> > > >> >>>> >> d
> > > > > > >> > > >>> > > > >> > > >> >>>> >>
> > > > > > >> > > >>> > > > >> > > >> >>>> >> First patch they landed, which
> > > > claims
> > > > > to
> > > > > > >> > > >>> > > > >> > > >> >>>> >> have
> > > > > > >> > > min
> > > > > > >> > > >>> > > > >> > > >> >>>> >> viable xwalk
> > > > > > >> > > >>> > > > >> > > >> webview:
> > > > > > >> > > >>> > > > >> > > >> >>>> >>
> > > > > > >> > > >>> > > > >> > > >> >>>>
> > > > > > >> > > >>> > > > >> > > >>
> > > > > > >> > > >>>
> > > > https://github.com/crosswalk-project/crosswalk-cordova-andro
> > > > > > >> > > >>> > > > >> > > >> id
> > > > > > >> > > >>> > > > >> > > >> /co
> > > > > > >> > > >>> > > > >> > > >> mmit
> > > > > > >> > > >>> > > > >> > > >>
> > /a04dedeb0204e7542d190312c6ae70c795a26e04
> > > > > > >> > > >>> > > > >> > > >> >>>> >>
> > > > > > >> > > >>> > > > >> > > >> >>>> >>
> > > > > > >> > > >>> > > > >> > > >> >>>> >> On Wed, Mar 5, 2014 at 11:37 PM,
> > > > > Michal
> > > > > > >> > > >>> > > > >> > > >> >>>> >> Mocny
> > > > > > >> > > >>> > > > >> > > >> >>>> >> <mmocny@chromium.org<mailto:
> > > > > > mmocny@chromium.org>
> > > > > > >> > > >>> > > > >> > > >> >
> > > > > > >> > > >>> > > > >> > > >> >>>> wrote:
> > > > > > >> > > >>> > > > >> > > >> >>>> >>
> > > > > > >> > > >>> > > > >> > > >> >>>> >>> I haven't looked yet, but did
> > you
> > > > > see:
> > > > > > >> > > >>> > > > >> > > >> >>>> >>>
> > > > > > >> > > >>> https://crosswalk-project.org/#wiki/crosswalk-cordo
> > > > > > >> > > >>> > > > >> > > >> >>>> >>> va
> > > > > > >> > > >>> > > > >> > > >> >>>> >>> -an
> > > > > > >> > > >>> > > > >> > > >> >>>> >>> droi
> > > > > > >> > > >>> > > > >> > > >> >>>> >>> d
> > > > > > >> > > >>> > > > >> > > >> >>>> >>>
> > > > > > >> > > >>> > > > >> > > >> >>>> >>> ?
> > > > > > >> > > >>> > > > >> > > >> >>>> >>>
> > > > > > >> > > >>> > > > >> > > >> >>>> >>>
> > > > > > >> > > >>> > > > >> > > >> >>>> >>> On Wed, Mar 5, 2014 at 10:20
> > PM,
> > > > > Andrew
> > > > > > >> > > Grieve <
> > > > > > >> > > >>> > > > >> > > >> agrieve@chromium.org<mailto:
> > > > > > agrieve@chromium.org>
> > > > > > >> > > >>> > > > >> > > >> >>>> >wrote:
> > > > > > >> > > >>> > > > >> > > >> >>>> >>>
> > > > > > >> > > >>> > > > >> > > >> >>>> >>>> First - very excited that
> > you're
> > > > > > working
> > > > > > >> > > >>> > > > >> > > >> >>>> >>>> on
> > > > > > >> > > this!
> > > > > > >> > > >>> > > > >> > > >> >>>> >>>>
> > > > > > >> > > >>> > > > >> > > >> >>>> >>>> Had a quick look. Not sure
> > there's
> > > > > > much
> > > > > > >> > > >>> > > > >> > > >> >>>> >>>> to
> > > > > > >> > be
> > > > > > >> > > >>> > gleaned
> > > > > > >> > > >>> > > yet.
> > > > > > >> > > >>> > > > >> > > >> >>>> >>>> Once
> > > > > > >> > > >>> > > > >> > > >> you
> > > > > > >> > > >>> > > > >> > > >> >>>> start
> > > > > > >> > > >>> > > > >> > > >> >>>> >>>> in on hooking up x-walk's
> > webview
> > > > I
> > > > > > >> > > >>> > > > >> > > >> >>>> >>>> think
> > > > > > >> > it
> > > > > > >> > > will
> > > > > > >> > > >>> > > > >> > > >> >>>> >>>> become more
> > > > > > >> > > >>> > > > >> > > >> obvious
> > > > > > >> > > >>> > > > >> > > >> >>>> what
> > > > > > >> > > >>> > > > >> > > >> >>>> >>>> the interface should look
> > like.
> > > > > E.g.,
> > > > > > >> > > >>> > > > >> > > >> >>>> >>>> does
> > > > > > >> > > x-walk
> > > > > > >> > > >>> > > > >> > > >> >>>> >>>> even have the
> > > > > > >> > > >>> > > > >> > > >> >>>> concept of
> > > > > > >> > > >>> > > > >> > > >> >>>> >>>> ChromeClient vs WebViewClient
> > vs
> > > > > > >> > > >>> > > > >> > > >> >>>> >>>> WebView?
> > > > > > >> > > Also
> > > > > > >> > > >>> > > > >> > > >> >>>> >>>> unsure whether the
> > > > > > >> > > >>> > > > >> > > >> >>>> class
> > > > > > >> > > >>> > > > >> > > >> >>>> >>>> should extend android.View as
> > well
> > > > > as
> > > > > > >> > > implement
> > > > > > >> > > >>> > > > >> > > >> >>>> >>>> our
> > > > > > >> > > >>> > > > >> > interface.
> > > > > > >> > > >>> > > > >> > > >> E.g.
> > > > > > >> > > >>> > > > >> > > >> >>>> >>>> alternative is to have a
> > > > "getView()"
> > > > > > >> > > >>> > > > >> > > >> >>>> >>>> method
> > > > > > >> > > on
> > > > > > >> > > >>> the
> > > > > > >> > > >>> > > > >> > interface.
> > > > > > >> > > >>> > > > >> > > >> Might
> > > > > > >> > > >>> > > > >> > > >> >>>> help
> > > > > > >> > > >>> > > > >> > > >> >>>> >>>> to
> > > > > > >> > > >>> > > > >> > > >> >>>> >>>> cut down on file sizes, and
> > API
> > > > > > surface,
> > > > > > >> > but
> > > > > > >> > > >>> > > > >> > > >> >>>> >>>> again, I'm not too
> > > > > > >> > > >>> > > > >> > > >> sure.
> > > > > > >> > > >>> > > > >> > > >> >>>> >>>>
> > > > > > >> > > >>> > > > >> > > >> >>>> >>>> I've been pretty hesitant to
> > touch
> > > > > > >> > > >>> > > > >> > > >> >>>> >>>> existing
> > > > > > >> > > >>> > > > >> > > >> >>>> >>>> exposed members
> > > > > > >> > > >>> > > > >> > > >> (e.g. the
> > > > > > >> > > >>> > > > >> > > >> >>>> >>>> public fields you were
> > referring
> > > > to)
> > > > > > >> > > >>> > > > >> > > >> >>>> >>>> since
> > > > > > >> > > >>> > > > >> > > >> >>>> >>>> touching anything
> > > > > > >> > > >>> > > > >> > > >> public
> > > > > > >> > > >>> > > > >> > > >> >>>> could
> > > > > > >> > > >>> > > > >> > > >> >>>> >>>> break plugins. That said,
> > maybe
> > > > now
> > > > > > is a
> > > > > > >> > good
> > > > > > >> > > >>> time
> > > > > > >> > > >>> > > > >> > > >> >>>> >>>> to @deprecate
> > > > > > >> > > >>> > > > >> > > >> a
> > > > > > >> > > >>> > > > >> > > >> >>>> bunch
> > > > > > >> > > >>> > > > >> > > >> >>>> >>>> of
> > > > > > >> > > >>> > > > >> > > >> >>>> >>>> them and either replace them
> > with
> > > > > > >> > > >>> > > > >> > > >> >>>> >>>> getters,
> > > > > > >> > or
> > > > > > >> > > >>> just
> > > > > > >> > > >>> > > > >> > > >> >>>> >>>> declare them
> > > > > > >> > > >>> > > > >> > > >> to be
> > > > > > >> > > >>> > > > >> > > >> >>>> not
> > > > > > >> > > >>> > > > >> > > >> >>>> >>>> exposed to plugins.
> > > > > > >> > > >>> > > > >> > > >> >>>> >>>>
> > > > > > >> > > >>> > > > >> > > >> >>>> >>>>
> > > > > > >> > > >>> > > > >> > > >> >>>> >>>> On Wed, Mar 5, 2014 at 6:57
> > PM,
> > > > Joe
> > > > > > >> > > >>> > > > >> > > >> >>>> >>>> Bowser
> > > > > > >> > > >>> > > > >> > > >> >>>> >>>> <bowserj@gmail.com<mailto:
> > > > > > bowserj@gmail.com>>
> > > > > > >> > > >>> > > > >> > > >> wrote:
> > > > > > >> > > >>> > > > >> > > >> >>>> >>>>
> > > > > > >> > > >>> > > > >> > > >> >>>> >>>> > So, after looking at the
> > > > Crosswalk
> > > > > > >> > > >>> > > > >> > > >> >>>> >>>> > code
> > > > > > >> > > again,
> > > > > > >> > > >>> > > > >> > > >> >>>> >>>> > I've decided to
> > > > > > >> > > >>> > > > >> > > >> take
> > > > > > >> > > >>> > > > >> > > >> >>>> a
> > > > > > >> > > >>> > > > >> > > >> >>>> >>>> > quick stab at making things
> > > > > > pluggable.
> > > > > > >> > > >>> > > > >> > > >> >>>> >>>> > I
> > > > > > >> > > don't
> > > > > > >> > > >>> > > > >> > > >> >>>> >>>> > have a lot to
> > > > > > >> > > >>> > > > >> > > >> show
> > > > > > >> > > >>> > > > >> > > >> >>>> for
> > > > > > >> > > >>> > > > >> > > >> >>>> >>>> > it, but with the help of
> > Eclipse
> > > > > > >> > > >>> > > > >> > > >> >>>> >>>> > (which
> > > > > > >> > is
> > > > > > >> > > why
> > > > > > >> > > >>> > > > >> > > >> >>>> >>>> > the generated interfaces
> > look so
> > > > > > >> > > >>> > > > >> > > >> >>>> >>>> > screwed
> > > > > > >> > > up), I
> > > > > > >> > > >>> > > > >> > > >> >>>> >>>> > managed to create some
> > > > > > >> > > >>> > > > >> > > >> interfaces
> > > > > > >> > > >>> > > > >> > > >> >>>> so
> > > > > > >> > > >>> > > > >> > > >> >>>> >>>> > we can start shoehorning in
> > > > other
> > > > > > >> > > >>> > > > >> > > >> >>>> >>>> > browser
> > > > > > >> > > >>> > renderers.
> > > > > > >> > > >>> > > > >> > > >> >>>> >>>> >
> > > > > > >> > > >>> > > > >> > > >> >>>> >>>> >
> > > > > > >> > > >>> > > > >> > > >>
> > > > > > >> > > >>>
> > > > https://github.com/infil00p/cordova-android/tree/pluggable_w
> > > > > > >> > > >>> > > > >> > > >> eb
> > > > > > >> > > >>> > > > >> > > >> vie
> > > > > > >> > > >>> > > > >> > > >> w
> > > > > > >> > > >>> > > > >> > > >> >>>> >>>> >
> > > > > > >> > > >>> > > > >> > > >> >>>> >>>> > I'm going to probably start
> > with
> > > > > > >> > Crosswalk,
> > > > > > >> > > >>> > > > >> > > >> >>>> >>>> > because it's
> > > > > > >> > > >>> > > > >> > > >> probably
> > > > > > >> > > >>> > > > >> > > >> >>>> the
> > > > > > >> > > >>> > > > >> > > >> >>>> >>>> > most mature primary
> > candidate in
> > > > > the
> > > > > > >> > > Android
> > > > > > >> > > >>> > > > >> > > >> >>>> >>>> > Third-Party
> > > > > > >> > > >>> > > > >> > > >> WebView
> > > > > > >> > > >>> > > > >> > > >> >>>> >>>> > thing, and I'm pretty sure
> > the
> > > > > > >> > > >>> > > > >> > > >> >>>> >>>> > GeckoView
> > > > > > >> > > will
> > > > > > >> > > >>> be
> > > > > > >> > > >>> > > > >> > > >> >>>> >>>> > happening
> > > > > > >> > > >>> > > > >> > > >> shortly
> > > > > > >> > > >>> > > > >> > > >> >>>> >>>> > after.
> > > > > > >> > > >>> > > > >> > > >> >>>> >>>> >
> > > > > > >> > > >>> > > > >> > > >> >>>> >>>> > I don't know how this would
> > work
> > > > > > >> > > >>> > > > >> > > >> >>>> >>>> > w.r.t.
> > > > > > >> > > the CLI
> > > > > > >> > > >>> > > > >> > > >> >>>> >>>> > or our
> > > > > > >> > > >>> > > > >> > > >> workflow at
> > > > > > >> > > >>> > > > >> > > >> >>>> >>>> > all, but at the moment, I
> > really
> > > > > > just
> > > > > > >> > want
> > > > > > >> > > to
> > > > > > >> > > >>> at
> > > > > > >> > > >>> > > > >> > > >> >>>> >>>> > least start
> > > > > > >> > > >>> > > > >> > > >> to have
> > > > > > >> > > >>> > > > >> > > >> >>>> >>>> > some headway towards 4.x and
> > > > > > PhoneGap
> > > > > > >> > day.
> > > > > > >> > > >>> > > > >> > > >> >>>> >>>> >
> > > > > > >> > > >>> > > > >> > > >> >>>> >>>> > What do people think of
> > this so
> > > > > far?
> > > > > > >> > > >>> > > > >> > > >> >>>> >>>> > I'm
> > > > > > >> > > going
> > > > > > >> > > >>> > > > >> > > >> >>>> >>>> > to try to clean
> > > > > > >> > > >>> > > > >> > > >> >>>> things
> > > > > > >> > > >>> > > > >> > > >> >>>> >>>> > up a bit, since we've
> > definitely
> > > > > > done
> > > > > > >> > > >>> > > > >> > > >> >>>> >>>> > a
> > > > > > >> > > lot of
> > > > > > >> > > >>> > > > >> > > >> >>>> >>>> > things that
> > > > > > >> > > >>> > > > >> > > >> would
> > > > > > >> > > >>> > > > >> > > >> >>>> make
> > > > > > >> > > >>> > > > >> > > >> >>>> >>>> > first year CS profs freak
> > the
> > > > hell
> > > > > > out
> > > > > > >> > > (i.e.
> > > > > > >> > > >>> > > > >> > > >> >>>> >>>> > public members in
> > > > > > >> > > >>> > > > >> > > >> >>>> public
> > > > > > >> > > >>> > > > >> > > >> >>>> >>>> > objects w.r.t.
> > PluginManager).
> > > > > > >> > > >>> > > > >> > > >> >>>> >>>> >
> > > > > > >> > > >>> > > > >> > > >> >>>> >>>> > Thoughts?
> > > > > > >> > > >>> > > > >> > > >> >>>> >>>> >
> > > > > > >> > > >>> > > > >> > > >> >>>> >>>> > Joe
> > > > > > >> > > >>> > > > >> > > >> >>>> >>>> >
> > > > > > >> > > >>> > > > >> > > >> >>>> >>>>
> > > > > > >> > > >>> > > > >> > > >> >>>> >>>
> > > > > > >> > > >>> > > > >> > > >> >>>> >>>
> > > > > > >> > > >>> > > > >> > > >> >>>>
> > > > > > >> > > >>> > > > >> > > >>
> > > > > > >> > > >>> > > > >> >
> > > > > > >> > > >>> >
> > > > > > >> > > >>>
> > > > > > >> > >
> > > > > > >> >
> > > > > > >
> > > > > > >
> > > > > >
> > > > > >
> > > > >
> > > >
> >

Re: [Android] Refactoring for different engines

[Ian Clelland <ic...@chromium.org>]

On Thu, Apr 24, 2014 at 1:10 AM, Hu, Ningxin <ni...@intel.com> wrote:

> Understood.
>
> How about 9am Pacific, 12am Eastern and 0am China? Really appreciate.
>

That time would probably work better for me than 7 hours later.

Ian


>
> Thanks,
> -ningxin
>
> > -----Original Message-----
> > From: mmocny@google.com [mailto:mmocny@google.com] On Behalf Of Michal
> > Mocny
> > Sent: Thursday, April 24, 2014 11:45 AM
> > To: dev
> > Subject: Re: [Android] Refactoring for different engines
> >
> > (Yeah 7pm Friday is more naughty than 4am for those of us with families.)
> >
> > I think the original intent was just supposed to be a meet & greet right?
> >  Lets just do it asap and consider formal scheduling with ample planning
> only if
> > there are technical topics to discuss.
> >
> > It would be nice, though, if Ian could make it, given his recent work on
> this.
> >
> > -Michal
> >
> >
> > On Wed, Apr 23, 2014 at 10:34 PM, Victor Sosa <sosah.victor@gmail.com
> >wrote:
> >
> > > 4PM PST? That's 6 CST or 7 EST, me thinks. Seems to work for many of
> > > us On Apr 23, 2014 8:49 PM, "Brian LeRoux" <b...@brian.io> wrote:
> > >
> > > > 4pm works for me…
> > > >
> > > >
> > > > On Wed, Apr 23, 2014 at 6:19 PM, Hu, Ningxin <ni...@intel.com>
> > > wrote:
> > > >
> > > > > I am in China. 1:00 PM PST means 4:00 AM here :o.
> > > > > Could you please schedule it a little bit later, say 4:00 or 5:00
> > > > > PM
> > > PST?
> > > > > It will be highly appreciated.
> > > > >
> > > > > Thanks,
> > > > > -ningxin
> > > > >
> > > > > From: brian.leroux@gmail.com [mailto:brian.leroux@gmail.com] On
> > > > > Behalf
> > > > Of
> > > > > Brian LeRoux
> > > > > Sent: Thursday, April 24, 2014 6:10 AM
> > > > > To: Joe Bowser
> > > > > Cc: dev@cordova.apache.org; Hu, Ningxin
> > > > > Subject: Re: [Android] Refactoring for different engines
> > > > >
> > > > > How does 1:00PST on Friday work for a hangout for everyone?
> > > > >
> > > > > On Wed, Apr 23, 2014 at 2:36 PM, Joe Bowser <bowserj@gmail.com
> <mailto:
> > > > > bowserj@gmail.com>> wrote:
> > > > > BTW: Here's my PoC for Mozilla so far.  It's very broken!
> > > > >
> > > > > https://github.com/infil00p/MozillaView
> > > > >
> > > > >
> > > > >
> > > > > On Wed, Apr 23, 2014 at 10:50 AM, Brian LeRoux <b@brian.io<mailto:
> > > > > b@brian.io>> wrote:
> > > > > > So I found a Moz hacker whom can help. what time on Fri do you
> > > > > > guys
> > > > want
> > > > > to
> > > > > > do this?
> > > > > >
> > > > > >
> > > > > > On Wed, Apr 23, 2014 at 10:31 AM, Ian Clelland <
> > > iclelland@chromium.org
> > > > > <ma...@chromium.org>>
> > > > > > wrote:
> > > > > >>
> > > > > >> I've managed to get this up and running now -- great work on
> > > > > >> this,
> > > > Joe!
> > > > > >>
> > > > > >> Mobilespec runs on my N4, with 10 failing tests: 3 in contacts;
> > > > > >> 7 in file-transfer. Otherwise, things seem to be working pretty
> well.
> > > > > >>
> > > > > >> I used a new build of Crosswalk, and found that the embedding
> > > > > >> API
> > > has
> > > > > >> changed since the weekend (when Ningxin's patches applied).
> > > > > >> I've
> > > > issued
> > > > > a
> > > > > >> pull request at
> > > > > >> https://github.com/infil00p/cordova-crosswalk-engine/pull/5for
> > > > > >> it
> > > --
> > > > > >>
> > > > > >> I'm not sure if there's a way to keep compatibility with last
> > > > > >> week's Crosswalk, or if we'd even want to. (Ningxin, if you
> > > > > >> could
> > > > take a
> > > > > >> look at that PR and see if it makes sense, I'd appreciate it)
> > > > > >>
> > > > > >> Joe, I also had to patch the default constructor for
> > > > > XWalkCordovaWebView;
> > > > > >> it wasn't creating its own client objects, so it got the
> > > > > >> default
> > > ones,
> > > > > and
> > > > > >> most of the tests were failing because some component of the
> > > > > >> bridge
> > > > > wan't
> > > > > >> working.
> > > https://github.com/infil00p/cordova-crosswalk-engine/pull/4is
> > > > > >> out
> > > > > >> for that.
> > > > > >>
> > > > > >> Count me in for the hangout -- this is exciting stuff
> > > > > >>
> > > > > >> Ian
> > > > > >>
> > > > > >>
> > > > > >> On Wed, Apr 23, 2014 at 10:26 AM, Brian LeRoux <b@brian.io
> <mailto:
> > > > > b@brian.io>> wrote:
> > > > > >>
> > > > > >> > Yup I'll track em down
> > > > > >> > On Apr 23, 2014 7:17 AM, "Andrew Grieve"
> > > > > >> > <agrieve@chromium.org
> > > > > <ma...@chromium.org>> wrote:
> > > > > >> >
> > > > > >> > > Does anyone have a contact at moz that we could invite?
> > > > > >> > >
> > > > > >> > > On Wed, Apr 23, 2014 at 10:09 AM, Andrew Grieve <
> > > > > agrieve@chromium.org<ma...@chromium.org>>
> > > > > >> > > wrote:
> > > > > >> > > > Depends on their interest level I think. Faster we can
> > > > > >> > > > get
> > > this
> > > > > out
> > > > > >> > > > the door the better. If we need to delay for geckoview,
> > > > > >> > > > then I
> > > > > don't
> > > > > >> > > > think we should gate on it, just release it after.
> > > > > >> > > >
> > > > > >> > > > On Wed, Apr 23, 2014 at 3:01 AM, Tommy Williams <
> > > > > tommy@devgeeks.org<ma...@devgeeks.org>>
> > > > > >> > > wrote:
> > > > > >> > > >> More engines, more better...
> > > > > >> > > >> On 23 Apr 2014 16:32, "Joe Bowser" <bowserj@gmail.com
> > > <mailto:
> > > > > bowserj@gmail.com>> wrote:
> > > > > >> > > >>
> > > > > >> > > >>> Hey
> > > > > >> > > >>>
> > > > > >> > > >>> A Hangout would have to happen on Friday at the
> earliest.
> > > >  It'd
> > > > > be
> > > > > >> > > good if
> > > > > >> > > >>> we could get someone from Mozilla on the hangout as
> > > > > >> > > >>> well.  I haven't
> > > > > >> > > gotten
> > > > > >> > > >>> MozillaView (GeckoView with Cordova methods) fully
> > > > > >> > > >>> working
> > > > yet.
> > > > > >> > > >>> For
> > > > > >> > > some
> > > > > >> > > >>> reason it's not rendering on the screen.
> > > > > >> > > >>>
> > > > > >> > > >>> Ideally it'd be cool to have at least two options when
> > > > > >> > > >>> this feature
> > > > > >> > > finally
> > > > > >> > > >>> lands.
> > > > > >> > > >>>
> > > > > >> > > >>> What do other people think?
> > > > > >> > > >>>
> > > > > >> > > >>> Joe
> > > > > >> > > >>> On 22 Apr 2014 20:06, "Hu, Ningxin"
> > > > > >> > > >>> <ningxin.hu@intel.com
> > > > > <ma...@intel.com>> wrote:
> > > > > >> > > >>>
> > > > > >> > > >>> > Joe,
> > > > > >> > > >>> >
> > > > > >> > > >>> > Thanks for your review and merge the PRs.
> > > > > >> > > >>> >
> > > > > >> > > >>> > To pluggable webview interest group:
> > > > > >> > > >>> > Are we OK to setup a hangout this week for initial
> > > > > introduction
> > > > > >> > > >>> > and
> > > > > >> > > >>> > discussion of next steps?
> > > > > >> > > >>> >
> > > > > >> > > >>> > Thanks,
> > > > > >> > > >>> > -ningxin
> > > > > >> > > >>> >
> > > > > >> > > >>> > > -----Original Message-----
> > > > > >> > > >>> > > From: Hu, Ningxin [mailto:ningxin.hu@intel.com
> <mailto:
> > > > > ningxin.hu@intel.com>]
> > > > > >> > > >>> > > Sent: Tuesday, April 22, 2014 4:04 PM
> > > > > >> > > >>> > > To: dev@cordova.apache.org<mailto:
> > > dev@cordova.apache.org>
> > > > > >> > > >>> > > Subject: RE: [Android] Refactoring for different
> > > > > >> > > >>> > > engines
> > > > > >> > > >>> > >
> > > > > >> > > >>> > > The PoC is great! Quite excited about the direction!
> > > > > >> > > >>> > >
> > > > > >> > > >>> > > I've sent a PR to update the
> > > > > >> > > >>> > > cordova-crosswalk-engine to latest
> > > > > >> > > >>> crosswalk
> > > > > >> > > >>> > > embedding API. It works with xwalk_core_library at
> > > > > 6.35.124.0.
> > > > > >> > > >>> > >
> > > > > >> > > >>> > > I've also changed the CordovaWebView interface
> > > > > >> > > >>> > > slightly (adding
> > > > > >> > > >>> > getView() API)
> > > > > >> > > >>> > > to allow XWalkCordovaWebView to composite a
> > > > > >> > > >>> > > XWalkView
> > > > > instead
> > > > > >> > > >>> > > of
> > > > > >> > > >>> > extending
> > > > > >> > > >>> > > it. It resolves some API naming issues for
> > > > > >> > > >>> > > XWalkView
> > > case.
> > > > > >> > > >>> > >
> > > > > >> > > >>> > > Please review them at:
> > > > > >> > > >>> > >
> > > > https://github.com/infil00p/cordova-crosswalk-engine/pull/3
> > > > > >> > > >>> > > https://github.com/infil00p/cordova-android/pull/2
> > > > > >> > > >>> > >
> > > > > >> > > >>> > > Thanks,
> > > > > >> > > >>> > > -ningxin
> > > > > >> > > >>> > >
> > > > > >> > > >>> > > > -----Original Message-----
> > > > > >> > > >>> > > > From: Joe Bowser [mailto:bowserj@gmail.com
> <mailto:
> > > > > bowserj@gmail.com>]
> > > > > >> > > >>> > > > Sent: Friday, April 11, 2014 12:45 AM
> > > > > >> > > >>> > > > To: dev
> > > > > >> > > >>> > > > Subject: Re: [Android] Refactoring for different
> > > engines
> > > > > >> > > >>> > > >
> > > > > >> > > >>> > > > Yeah, I'd be cool with setting up a hangout.
> > > > > >> > > >>> > > > Everyone should
> > > > > >> > > take a
> > > > > >> > > >>> > > > look at the PoC, I've basically distilled it down
> > > > > >> > > >>> > > > to
> > > > four
> > > > > or
> > > > > >> > five
> > > > > >> > > >>> > > > classes so far, but with some work, we may be
> > > > > >> > > >>> > > > able to
> > > > get
> > > > > it
> > > > > >> > > down to
> > > > > >> > > >>> > > > three.  Due to legacy, we're pretty stuck with
> > > > > >> > > >>> > > > the
> > > > Android
> > > > > >> > > WebView
> > > > > >> > > >>> API
> > > > > >> > > >>> > calls,
> > > > > >> > > >>> > > but these can probably be modified.
> > > > > >> > > >>> > > >
> > > > > >> > > >>> > > > It'd be good to get Mozilla people on the call as
> > > well,
> > > > > >> > > >>> > > > since
> > > > > >> > > they
> > > > > >> > > >>> > > > have their WebView as well.
> > > > > >> > > >>> > > >
> > > > > >> > > >>> > > > On Thu, Apr 10, 2014 at 9:38 AM, Hu, Ningxin <
> > > > > >> > > ningxin.hu@intel.com<ma...@intel.com>>
> > > > > >> > > >>> > wrote:
> > > > > >> > > >>> > > > > Hangout would be a good idea.
> > > > > >> > > >>> > > > >
> > > > > >> > > >>> > > > > FYI, I will be off next week. How about the
> > > > > >> > > >>> > > > > week
> > > after
> > > > > >> > > >>> > > > > next?
> > > > > >> > > If it
> > > > > >> > > >>> > > > > works, please
> > > > > >> > > >>> > > > feel free to schedule one and count me in.
> > > > > >> > > >>> > > > >
> > > > > >> > > >>> > > > > Thanks,
> > > > > >> > > >>> > > > > -ningxin
> > > > > >> > > >>> > > > >
> > > > > >> > > >>> > > > >> -----Original Message-----
> > > > > >> > > >>> > > > >> From:
> > > > > >> > > >>> > > > >> mmocny@google.com<ma...@google.com>
> > > > > [mailto:mmocny@google.com<ma...@google.com>] On
> > > > > >> > Behalf
> > > > > >> > > Of
> > > > > >> > > >>> > > > >> Michal Mocny
> > > > > >> > > >>> > > > >> Sent: Tuesday, April 08, 2014 11:39 PM
> > > > > >> > > >>> > > > >> To: dev
> > > > > >> > > >>> > > > >> Subject: Re: [Android] Refactoring for
> > > > > >> > > >>> > > > >> different
> > > > > engines
> > > > > >> > > >>> > > > >>
> > > > > >> > > >>> > > > >> Would it be alright to set up a Hangout some
> > > > > >> > > >>> > > > >> time
> > > to
> > > > > >> > introduce
> > > > > >> > > >>> > everyone?
> > > > > >> > > >>> > > > >>
> > > > > >> > > >>> > > > >> Joe has been leading the effort here, but
> > > > > >> > > >>> > > > >> there are
> > > > > other
> > > > > >> > > cordova
> > > > > >> > > >>> > > > >> contributors for whom this is top priority.
> > > > > >> > > >>> > > > >> It
> > > would
> > > > > be
> > > > > >> > nice
> > > > > >> > > if
> > > > > >> > > >>> we
> > > > > >> > > >>> > > > >> could all meet to say hello and make sure we
> > > > > >> > > >>> > > > >> are
> > > all
> > > > > >> > > >>> > > > >> going
> > > > > >> > in
> > > > > >> > > the
> > > > > >> > > >>> > > > >> right
> > > > > >> > > >>> > > > direction.
> > > > > >> > > >>> > > > >>
> > > > > >> > > >>> > > > >> Quite exciting!
> > > > > >> > > >>> > > > >>
> > > > > >> > > >>> > > > >> -Michal
> > > > > >> > > >>> > > > >>
> > > > > >> > > >>> > > > >>
> > > > > >> > > >>> > > > >> On Tue, Apr 8, 2014 at 10:56 AM, Hu, Ningxin <
> > > > > >> > > >>> ningxin.hu@intel.com<ma...@intel.com>>
> > > > > >> > > >>> > > wrote:
> > > > > >> > > >>> > > > >>
> > > > > >> > > >>> > > > >> > Joe, thanks for this. I am very excited.
> > > > > >> > > >>> > > > >> >
> > > > > >> > > >>> > > > >> > FYI. Crosswalk team is working on
> > > > > >> > > >>> > > > >> > refactoring the WebView
> > > > > >> > > API to
> > > > > >> > > >>> > > > >> > support embedding usage better [1].
> > > > > >> > > >>> > > > >> > (Previously
> > > the
> > > > > >> > > >>> > > > >> > layer
> > > > > >> > > API
> > > > > >> > > >>> was
> > > > > >> > > >>> > > > >> > not exposed as public usage).
> > > > > >> > > >>> > > > >> >
> > > > > >> > > >>> > > > >> > I would like to review the PoC and work with
> > > > > >> > > >>> > > > >> > you
> > > to
> > > > > get
> > > > > >> > > >>> Crosswalk
> > > > > >> > > >>> > > > >> > fits into the pluggable WebView architecture.
> > > > > >> > > >>> > > > >> >
> > > > > >> > > >>> > > > >> > Thanks,
> > > > > >> > > >>> > > > >> > -ningxin
> > > > > >> > > >>> > > > >> >
> > > > > >> > > >>> > > > >> > > -----Original Message-----
> > > > > >> > > >>> > > > >> > > From: Joe Bowser [mailto:bowserj@gmail.com
> > > > <mailto:
> > > > > bowserj@gmail.com>]
> > > > > >> > > >>> > > > >> > > Sent: Wednesday, March 19, 2014 7:08 AM
> > > > > >> > > >>> > > > >> > > To: dev
> > > > > >> > > >>> > > > >> > > Subject: Re: [Android] Refactoring for
> > > different
> > > > > >> > > >>> > > > >> > > engines
> > > > > >> > > >>> > > > >> > >
> > > > > >> > > >>> > > > >> > > Hey
> > > > > >> > > >>> > > > >> > >
> > > > > >> > > >>> > > > >> > > After debugging, I did some minor updates
> > > > > >> > > >>> > > > >> > > to
> > > the
> > > > > >> > > >>> > > > >> > > plugin
> > > > > >> > > >>> README.
> > > > > >> > > >>> > > > >> > > It
> > > > > >> > > >>> > > > >> > should be
> > > > > >> > > >>> > > > >> > > easier to get this up and running,
> > > > > >> > > >>> > > > >> > > although
> > > > there's
> > > > > >> > still
> > > > > >> > > the
> > > > > >> > > >>> > > > >> > > issue of
> > > > > >> > > >>> > > > >> > after-install
> > > > > >> > > >>> > > > >> > > hooks and the relative path weirdness with
> > > > > >> > > >>> > > > >> > > the Crosswalk
> > > > > >> > > >>> > Library itself.
> > > > > >> > > >>> > > > >> > >
> > > > > >> > > >>> > > > >> > > It still doesn't support the CLI at all,
> > > > > >> > > >>> > > > >> > > but it should
> > > > > >> > be
> > > > > >> > > >>> there
> > > > > >> > > >>> > > > >> > > with the
> > > > > >> > > >>> > > > >> > old flow.
> > > > > >> > > >>> > > > >> > >
> > > > > >> > > >>> > > > >> > > On Mon, Mar 17, 2014 at 1:14 PM, Michal
> > > > > >> > > >>> > > > >> > > Mocny
> > > > > >> > > >>> > > > >> > > <mmocny@chromium.org<mailto:
> > > mmocny@chromium.org
> > > > >>
> > > > > >> > > >>> > > > >> > > wrote:
> > > > > >> > > >>> > > > >> > > > (Sorry Joe, Googlers are down in
> > > > > >> > > >>> > > > >> > > > California
> > > and
> > > > > way
> > > > > >> > > busy.
> > > > > >> > > >>> > > > >> > > > Will be back in a week.  Super excited
> > > > > >> > > >>> > > > >> > > > about
> > > > > this,
> > > > > >> > > though.)
> > > > > >> > > >>> > > > >> > > >
> > > > > >> > > >>> > > > >> > > > -Michal
> > > > > >> > > >>> > > > >> > > >
> > > > > >> > > >>> > > > >> > > >
> > > > > >> > > >>> > > > >> > > > On Mon, Mar 17, 2014 at 2:53 PM, Joe
> > > > > >> > > >>> > > > >> > > > Bowser
> > > > > >> > > >>> > > > >> > > > <bowserj@gmail.com<mailto:bowserj@gmail.
> > > > > >> > > >>> > > > >> > > > com
> > > >>
> > > > > >> > > >>> > > > >> wrote:
> > > > > >> > > >>> > > > >> > > >
> > > > > >> > > >>> > > > >> > > >> Reviving this thread!
> > > > > >> > > >>> > > > >> > > >>
> > > > > >> > > >>> > > > >> > > >> Can other people look at this, and see
> > > if/when
> > > > > we
> > > > > >> > > should
> > > > > >> > > >>> > land this?
> > > > > >> > > >>> > > > >> > > >> I know that I have to re-write the
> > > > > >> > > >>> > > > >> > > >> tests
> > > > still,
> > > > > >> > > >>> > > > >> > > >> but I
> > > > > >> > > would
> > > > > >> > > >>> > > > >> > > >> like some feedback before merging it in.
> > > >  Also,
> > > > > >> > > >>> > > > >> > > >> it'd
> > > > > >> > be
> > > > > >> > > >>> > > > >> > > >> super awesome if other people could try
> > > > > >> > > >>> > > > >> > > >> and
> > > > > make a
> > > > > >> > > WebView
> > > > > >> > > >>> > > > >> > > >> based on the interfaces and recommend
> > > > > >> > > >>> > > > >> > > >> which methods
> > > > > >> > > should
> > > > > >> > > >>> > > > >> > > >> die.  I want to get this released in
> > > > > >> > > >>> > > > >> > > >> the
> > > next
> > > > > >> > > >>> > > > >> > > >> month
> > > > > >> > or
> > > > > >> > > so,
> > > > > >> > > >>> > > > >> > > >> so any time and feedback would be
> > > > > >> > > >>> > > > >> > > >> greatly
> > > > > >> > appreciated.
> > > > > >> > > >>> > > > >> > > >>
> > > > > >> > > >>> > > > >> > > >> Thanks
> > > > > >> > > >>> > > > >> > > >>
> > > > > >> > > >>> > > > >> > > >> On Thu, Mar 13, 2014 at 3:50 PM, Joe
> > > > > >> > > >>> > > > >> > > >> Bowser
> > > > > >> > > >>> > > > >> > > >> <bowserj@gmail.com<mailto:bowserj@gmail
> > > > > >> > > >>> > > > >> > > >> .com
> > > >>
> > > > > >> > > >>> > > > >> > wrote:
> > > > > >> > > >>> > > > >> > > >> > Hey, I created the following today to
> > > track
> > > > > >> > > >>> > > > >> > > >> > various WebView
> > > > > >> > > >>> > > > >> > progresses:
> > > > > >> > > >>> > > > >> > > >> >
> > > > https://issues.apache.org/jira/browse/CB-6246
> > > > > >> > > >>> > > > >> > > >> >
> > > > > >> > > >>> > > > >> > > >> > I also have this repo created.  The
> > > > licensing
> > > > > is
> > > > > >> > > ugly as
> > > > > >> > > >>> > > > >> > > >> > all crap, but it's a Proof-Of-Concept:
> > > > > >> > > >>> > > > >> > > >> >
> > > > > >> > https://github.com/infil00p/cordova-crosswalk-engine
> > > > > >> > > >>> > > > >> > > >> >
> > > > > >> > > >>> > > > >> > > >> > If I can get some help getting
> plugman to
> > > > just
> > > > > >> > > >>> > > > >> > > >> > load
> > > > > >> > > >>> > > > >> > > >> > Crosswalk, it'll
> > > > > >> > > >>> > > > >> > > >> look hawt.
> > > > > >> > > >>> > > > >> > > >> >
> > > > > >> > > >>> > > > >> > > >> > BTW: We should probably get this
> ready to
> > > go
> > > > > >> > > >>> > > > >> > > >> > into
> > > > > >> > > Android
> > > > > >> > > >>> > > > >> > > >> > in the next two months and deprecate
> the
> > > > > >> > setProperty
> > > > > >> > > >>> > > > >> > > >> > methods, since all properties should
> be
> > > > > >> > > >>> > > > >> > > >> > preferences
> > > > > >> > > in
> > > > > >> > > >>> > config.xml
> > > > > >> > > >>> > > now.
> > > > > >> > > >>> > > > >> > > >> >
> > > > > >> > > >>> > > > >> > > >> > On Mon, Mar 10, 2014 at 2:42 PM, Joe
> > > Bowser
> > > > > >> > > >>> > > > >> > > >> > <bowserj@gmail.com<mailto:
> > > bowserj@gmail.com
> > > > >>
> > > > > >> > > >>> > > > >> > > wrote:
> > > > > >> > > >>> > > > >> > > >> >> Perhaps. There would be additional
> > > benefits
> > > > > to
> > > > > >> > this
> > > > > >> > > >>> > > > >> > > >> >> approach, namely fixes being added to
> > > that
> > > > > >> > platform
> > > > > >> > > more
> > > > > >> > > >>> > > > >> > > >> >> quickly.  I'll probably take a look
> at
> > > that
> > > > > >> > > >>> > > > >> > > >> >> once I
> > > > > >> > > have
> > > > > >> > > >>> > > > >> > > >> >> Crosswalk
> > > > > >> > > >>> > > > finalized.
> > > > > >> > > >>> > > > >> > > >> >>
> > > > > >> > > >>> > > > >> > > >> >> On Mon, Mar 10, 2014 at 9:49 AM,
> Brian
> > > > LeRoux
> > > > > >> > > >>> > > > >> > > >> >> <b@...@brian.io>>
> > > > > >> > > >>> > > > wrote:
> > > > > >> > > >>> > > > >> > > >> >>> this is great stuff
> > > > > >> > > >>> > > > >> > > >> >>>
> > > > > >> > > >>> > > > >> > > >> >>> do we think it may be possible to
> bring
> > > in
> > > > > >> > > >>> > > > >> > > >> >>> amazon
> > > > > >> > > >>> fireos
> > > > > >> > > >>> > > > >> > > >> >>> stuff
> > > > > >> > > >>> > > > >> > > >> eventually
> > > > > >> > > >>> > > > >> > > >> >>> too?
> > > > > >> > > >>> > > > >> > > >> >>>
> > > > > >> > > >>> > > > >> > > >> >>>
> > > > > >> > > >>> > > > >> > > >> >>> On Fri, Mar 7, 2014 at 3:22 PM, Joe
> > > Bowser
> > > > > >> > > >>> > > > >> > > >> >>> <bowserj@gmail.com<mailto:
> > > > bowserj@gmail.com
> > > > > >>
> > > > > >> > > >>> > > > >> > wrote:
> > > > > >> > > >>> > > > >> > > >> >>>
> > > > > >> > > >>> > > > >> > > >> >>>> BTW: I committed it in my repo,
> not the
> > > > > main
> > > > > >> > > Apache
> > > > > >> > > >>> one.
> > > > > >> > > >>> > > > >> > > >> >>>>
> > > > > >> > > >>> > > > >> > > >> >>>> On Fri, Mar 7, 2014 at 3:21 PM, Joe
> > > > Bowser
> > > > > >> > > >>> > > > >> > > >> >>>> <bowserj@gmail.com<mailto:
> > > > > bowserj@gmail.com>>
> > > > > >> > > >>> > > > >> > > wrote:
> > > > > >> > > >>> > > > >> > > >> >>>> > Hey
> > > > > >> > > >>> > > > >> > > >> >>>> >
> > > > > >> > > >>> > > > >> > > >> >>>> > I just committed some code based
> on
> > > > their
> > > > > >> > > WebView
> > > > > >> > > >>> > > > >> > > >> >>>> > modifications that allows you to
> > > choose
> > > > > >> > > >>> > > > >> > > >> >>>> > your
> > > > > >> > > >>> renderer
> > > > > >> > > >>> > > > >> > > >> >>>> > in the
> > > > > >> > > >>> > > > >> > config file
> > > > > >> > > >>> > > > >> > > with this:
> > > > > >> > > >>> > > > >> > > >> >>>> >
> > > > > >> > > >>> > > > >> > > >> >>>> >     <preference name="webView"
> > > > > >> > > >>> > > > >> > > >> >>>> >
> > > > > >> > > >>> value="org.apache.cordova.engine.crosswalk.XWalkCordo
> > > > > >> > > >>> > > > >> > > >> >>>> > va
> > > > > >> > > >>> > > > >> > > >> >>>> > Web
> > > > > >> > > >>> > > > >> > > >> >>>> > View
> > > > > >> > > >>> > > > >> > > >> >>>> > " />
> > > > > >> > > >>> > > > >> > > >> >>>> >
> > > > > >> > > >>> > > > >> > > >> >>>> > You currently have to copy over
> the
> > > > *.pak
> > > > > >> > > >>> > > > >> > > >> >>>> > file
> > > > > >> > > and
> > > > > >> > > >>> > > > >> > > >> >>>> > the jsapi from a Crosswalk
> Example
> > > > > project
> > > > > >> > > >>> > > > >> > > >> >>>> > to
> > > > > >> > > get
> > > > > >> > > >>> > > > >> > > >> >>>> > this to work.  The next thing
> that
> > > I'm
> > > > > >> > > >>> > > > >> > > >> >>>> > going
> > > > > >> > to
> > > > > >> > > do
> > > > > >> > > >>> is
> > > > > >> > > >>> > > > >> > > >> >>>> > figure out how to write this as a
> > > > plugin
> > > > > >> > > >>> > > > >> > > >> >>>> > and
> > > > > >> > > have it
> > > > > >> > > >>> > > > >> > > >> >>>> > install on a default
> > > > > >> > > >>> > > > project.
> > > > > >> > > >>> > > > >> > > >> >>>> > Also, right now the bridge
> doesn't
> > > seem
> > > > > to
> > > > > >> > > work, and
> > > > > >> > > >>> > > > >> > > >> >>>> > I don't know why exactly.  That
> being
> > > > > said,
> > > > > >> > the
> > > > > >> > > >>> > > > >> > > >> fact
> > > > > >> > > >>> > > > >> > > >> >>>> > that I can choose which version
> of
> > > > > >> > > Chrome/Chromium
> > > > > >> > > >>> > > > >> > > >> >>>> > I'm running with
> > > > > >> > > >>> > > > >> > > >> a
> > > > > >> > > >>> > > > >> > > >> >>>> > single XML preference is HUGE.
> > > > > >> > > >>> > > > >> > > >> >>>> >
> > > > > >> > > >>> > > > >> > > >> >>>> > There's definitely a lot more
> work
> > > that
> > > > > >> > > >>> > > > >> > > >> >>>> > needs
> > > > > >> > > to be
> > > > > >> > > >>> > > > >> > > >> >>>> > done, but as
> > > > > >> > > >>> > > > >> > > >> long
> > > > > >> > > >>> > > > >> > > >> >>>> > as we have something that we can
> fit
> > > > into
> > > > > >> > > >>> > > > >> > > >> >>>> > the
> > > > > >> > > >>> > > > >> > > >> >>>> > interface, we should
> > > > > >> > > >>> > > > >> > > >> be
> > > > > >> > > >>> > > > >> > > >> >>>> > able to put in things like
> GeckoView
> > > or
> > > > > >> > > >>> > > > >> > > >> >>>> > other
> > > > > >> > > third
> > > > > >> > > >>> > > > >> > > >> >>>> > party
> > > > > >> > > >>> > > > >> > renderers.
> > > > > >> > > >>> > > > >> > > >> >>>> > The nightmare of being stuck with
> > > > > bullshit
> > > > > >> > > WebView
> > > > > >> > > >>> > > > >> > > >> >>>> > bugs may soon be over.
> > > > > >> > > >>> > > > >> > > >> >>>> >
> > > > > >> > > >>> > > > >> > > >> >>>> > On Wed, Mar 5, 2014 at 8:59 PM,
> > > Michal
> > > > > >> > > >>> > > > >> > > >> >>>> > Mocny
> > > > > >> > > >>> > > > >> > > >> >>>> > <mmocny@chromium.org<mailto:
> > > > > mmocny@chromium.org>>
> > > > > >> > > >>> > > > >> > > >> >>>> wrote:
> > > > > >> > > >>> > > > >> > > >> >>>> >>
> > > > > >> > > >>> https://github.com/crosswalk-project/crosswalk-cordo
> > > > > >> > > >>> > > > >> > > >> >>>> >> va
> > > > > >> > > >>> > > > >> > > >> >>>> >> -an
> > > > > >> > > >>> > > > >> > > >> >>>> >> droi
> > > > > >> > > >>> > > > >> > > >> >>>> >> d
> > > > > >> > > >>> > > > >> > > >> >>>> >>
> > > > > >> > > >>> > > > >> > > >> >>>> >> First patch they landed, which
> > > claims
> > > > to
> > > > > >> > > >>> > > > >> > > >> >>>> >> have
> > > > > >> > > min
> > > > > >> > > >>> > > > >> > > >> >>>> >> viable xwalk
> > > > > >> > > >>> > > > >> > > >> webview:
> > > > > >> > > >>> > > > >> > > >> >>>> >>
> > > > > >> > > >>> > > > >> > > >> >>>>
> > > > > >> > > >>> > > > >> > > >>
> > > > > >> > > >>>
> > > https://github.com/crosswalk-project/crosswalk-cordova-andro
> > > > > >> > > >>> > > > >> > > >> id
> > > > > >> > > >>> > > > >> > > >> /co
> > > > > >> > > >>> > > > >> > > >> mmit
> > > > > >> > > >>> > > > >> > > >>
> /a04dedeb0204e7542d190312c6ae70c795a26e04
> > > > > >> > > >>> > > > >> > > >> >>>> >>
> > > > > >> > > >>> > > > >> > > >> >>>> >>
> > > > > >> > > >>> > > > >> > > >> >>>> >> On Wed, Mar 5, 2014 at 11:37 PM,
> > > > Michal
> > > > > >> > > >>> > > > >> > > >> >>>> >> Mocny
> > > > > >> > > >>> > > > >> > > >> >>>> >> <mmocny@chromium.org<mailto:
> > > > > mmocny@chromium.org>
> > > > > >> > > >>> > > > >> > > >> >
> > > > > >> > > >>> > > > >> > > >> >>>> wrote:
> > > > > >> > > >>> > > > >> > > >> >>>> >>
> > > > > >> > > >>> > > > >> > > >> >>>> >>> I haven't looked yet, but did
> you
> > > > see:
> > > > > >> > > >>> > > > >> > > >> >>>> >>>
> > > > > >> > > >>> https://crosswalk-project.org/#wiki/crosswalk-cordo
> > > > > >> > > >>> > > > >> > > >> >>>> >>> va
> > > > > >> > > >>> > > > >> > > >> >>>> >>> -an
> > > > > >> > > >>> > > > >> > > >> >>>> >>> droi
> > > > > >> > > >>> > > > >> > > >> >>>> >>> d
> > > > > >> > > >>> > > > >> > > >> >>>> >>>
> > > > > >> > > >>> > > > >> > > >> >>>> >>> ?
> > > > > >> > > >>> > > > >> > > >> >>>> >>>
> > > > > >> > > >>> > > > >> > > >> >>>> >>>
> > > > > >> > > >>> > > > >> > > >> >>>> >>> On Wed, Mar 5, 2014 at 10:20
> PM,
> > > > Andrew
> > > > > >> > > Grieve <
> > > > > >> > > >>> > > > >> > > >> agrieve@chromium.org<mailto:
> > > > > agrieve@chromium.org>
> > > > > >> > > >>> > > > >> > > >> >>>> >wrote:
> > > > > >> > > >>> > > > >> > > >> >>>> >>>
> > > > > >> > > >>> > > > >> > > >> >>>> >>>> First - very excited that
> you're
> > > > > working
> > > > > >> > > >>> > > > >> > > >> >>>> >>>> on
> > > > > >> > > this!
> > > > > >> > > >>> > > > >> > > >> >>>> >>>>
> > > > > >> > > >>> > > > >> > > >> >>>> >>>> Had a quick look. Not sure
> there's
> > > > > much
> > > > > >> > > >>> > > > >> > > >> >>>> >>>> to
> > > > > >> > be
> > > > > >> > > >>> > gleaned
> > > > > >> > > >>> > > yet.
> > > > > >> > > >>> > > > >> > > >> >>>> >>>> Once
> > > > > >> > > >>> > > > >> > > >> you
> > > > > >> > > >>> > > > >> > > >> >>>> start
> > > > > >> > > >>> > > > >> > > >> >>>> >>>> in on hooking up x-walk's
> webview
> > > I
> > > > > >> > > >>> > > > >> > > >> >>>> >>>> think
> > > > > >> > it
> > > > > >> > > will
> > > > > >> > > >>> > > > >> > > >> >>>> >>>> become more
> > > > > >> > > >>> > > > >> > > >> obvious
> > > > > >> > > >>> > > > >> > > >> >>>> what
> > > > > >> > > >>> > > > >> > > >> >>>> >>>> the interface should look
> like.
> > > > E.g.,
> > > > > >> > > >>> > > > >> > > >> >>>> >>>> does
> > > > > >> > > x-walk
> > > > > >> > > >>> > > > >> > > >> >>>> >>>> even have the
> > > > > >> > > >>> > > > >> > > >> >>>> concept of
> > > > > >> > > >>> > > > >> > > >> >>>> >>>> ChromeClient vs WebViewClient
> vs
> > > > > >> > > >>> > > > >> > > >> >>>> >>>> WebView?
> > > > > >> > > Also
> > > > > >> > > >>> > > > >> > > >> >>>> >>>> unsure whether the
> > > > > >> > > >>> > > > >> > > >> >>>> class
> > > > > >> > > >>> > > > >> > > >> >>>> >>>> should extend android.View as
> well
> > > > as
> > > > > >> > > implement
> > > > > >> > > >>> > > > >> > > >> >>>> >>>> our
> > > > > >> > > >>> > > > >> > interface.
> > > > > >> > > >>> > > > >> > > >> E.g.
> > > > > >> > > >>> > > > >> > > >> >>>> >>>> alternative is to have a
> > > "getView()"
> > > > > >> > > >>> > > > >> > > >> >>>> >>>> method
> > > > > >> > > on
> > > > > >> > > >>> the
> > > > > >> > > >>> > > > >> > interface.
> > > > > >> > > >>> > > > >> > > >> Might
> > > > > >> > > >>> > > > >> > > >> >>>> help
> > > > > >> > > >>> > > > >> > > >> >>>> >>>> to
> > > > > >> > > >>> > > > >> > > >> >>>> >>>> cut down on file sizes, and
> API
> > > > > surface,
> > > > > >> > but
> > > > > >> > > >>> > > > >> > > >> >>>> >>>> again, I'm not too
> > > > > >> > > >>> > > > >> > > >> sure.
> > > > > >> > > >>> > > > >> > > >> >>>> >>>>
> > > > > >> > > >>> > > > >> > > >> >>>> >>>> I've been pretty hesitant to
> touch
> > > > > >> > > >>> > > > >> > > >> >>>> >>>> existing
> > > > > >> > > >>> > > > >> > > >> >>>> >>>> exposed members
> > > > > >> > > >>> > > > >> > > >> (e.g. the
> > > > > >> > > >>> > > > >> > > >> >>>> >>>> public fields you were
> referring
> > > to)
> > > > > >> > > >>> > > > >> > > >> >>>> >>>> since
> > > > > >> > > >>> > > > >> > > >> >>>> >>>> touching anything
> > > > > >> > > >>> > > > >> > > >> public
> > > > > >> > > >>> > > > >> > > >> >>>> could
> > > > > >> > > >>> > > > >> > > >> >>>> >>>> break plugins. That said,
> maybe
> > > now
> > > > > is a
> > > > > >> > good
> > > > > >> > > >>> time
> > > > > >> > > >>> > > > >> > > >> >>>> >>>> to @deprecate
> > > > > >> > > >>> > > > >> > > >> a
> > > > > >> > > >>> > > > >> > > >> >>>> bunch
> > > > > >> > > >>> > > > >> > > >> >>>> >>>> of
> > > > > >> > > >>> > > > >> > > >> >>>> >>>> them and either replace them
> with
> > > > > >> > > >>> > > > >> > > >> >>>> >>>> getters,
> > > > > >> > or
> > > > > >> > > >>> just
> > > > > >> > > >>> > > > >> > > >> >>>> >>>> declare them
> > > > > >> > > >>> > > > >> > > >> to be
> > > > > >> > > >>> > > > >> > > >> >>>> not
> > > > > >> > > >>> > > > >> > > >> >>>> >>>> exposed to plugins.
> > > > > >> > > >>> > > > >> > > >> >>>> >>>>
> > > > > >> > > >>> > > > >> > > >> >>>> >>>>
> > > > > >> > > >>> > > > >> > > >> >>>> >>>> On Wed, Mar 5, 2014 at 6:57
> PM,
> > > Joe
> > > > > >> > > >>> > > > >> > > >> >>>> >>>> Bowser
> > > > > >> > > >>> > > > >> > > >> >>>> >>>> <bowserj@gmail.com<mailto:
> > > > > bowserj@gmail.com>>
> > > > > >> > > >>> > > > >> > > >> wrote:
> > > > > >> > > >>> > > > >> > > >> >>>> >>>>
> > > > > >> > > >>> > > > >> > > >> >>>> >>>> > So, after looking at the
> > > Crosswalk
> > > > > >> > > >>> > > > >> > > >> >>>> >>>> > code
> > > > > >> > > again,
> > > > > >> > > >>> > > > >> > > >> >>>> >>>> > I've decided to
> > > > > >> > > >>> > > > >> > > >> take
> > > > > >> > > >>> > > > >> > > >> >>>> a
> > > > > >> > > >>> > > > >> > > >> >>>> >>>> > quick stab at making things
> > > > > pluggable.
> > > > > >> > > >>> > > > >> > > >> >>>> >>>> > I
> > > > > >> > > don't
> > > > > >> > > >>> > > > >> > > >> >>>> >>>> > have a lot to
> > > > > >> > > >>> > > > >> > > >> show
> > > > > >> > > >>> > > > >> > > >> >>>> for
> > > > > >> > > >>> > > > >> > > >> >>>> >>>> > it, but with the help of
> Eclipse
> > > > > >> > > >>> > > > >> > > >> >>>> >>>> > (which
> > > > > >> > is
> > > > > >> > > why
> > > > > >> > > >>> > > > >> > > >> >>>> >>>> > the generated interfaces
> look so
> > > > > >> > > >>> > > > >> > > >> >>>> >>>> > screwed
> > > > > >> > > up), I
> > > > > >> > > >>> > > > >> > > >> >>>> >>>> > managed to create some
> > > > > >> > > >>> > > > >> > > >> interfaces
> > > > > >> > > >>> > > > >> > > >> >>>> so
> > > > > >> > > >>> > > > >> > > >> >>>> >>>> > we can start shoehorning in
> > > other
> > > > > >> > > >>> > > > >> > > >> >>>> >>>> > browser
> > > > > >> > > >>> > renderers.
> > > > > >> > > >>> > > > >> > > >> >>>> >>>> >
> > > > > >> > > >>> > > > >> > > >> >>>> >>>> >
> > > > > >> > > >>> > > > >> > > >>
> > > > > >> > > >>>
> > > https://github.com/infil00p/cordova-android/tree/pluggable_w
> > > > > >> > > >>> > > > >> > > >> eb
> > > > > >> > > >>> > > > >> > > >> vie
> > > > > >> > > >>> > > > >> > > >> w
> > > > > >> > > >>> > > > >> > > >> >>>> >>>> >
> > > > > >> > > >>> > > > >> > > >> >>>> >>>> > I'm going to probably start
> with
> > > > > >> > Crosswalk,
> > > > > >> > > >>> > > > >> > > >> >>>> >>>> > because it's
> > > > > >> > > >>> > > > >> > > >> probably
> > > > > >> > > >>> > > > >> > > >> >>>> the
> > > > > >> > > >>> > > > >> > > >> >>>> >>>> > most mature primary
> candidate in
> > > > the
> > > > > >> > > Android
> > > > > >> > > >>> > > > >> > > >> >>>> >>>> > Third-Party
> > > > > >> > > >>> > > > >> > > >> WebView
> > > > > >> > > >>> > > > >> > > >> >>>> >>>> > thing, and I'm pretty sure
> the
> > > > > >> > > >>> > > > >> > > >> >>>> >>>> > GeckoView
> > > > > >> > > will
> > > > > >> > > >>> be
> > > > > >> > > >>> > > > >> > > >> >>>> >>>> > happening
> > > > > >> > > >>> > > > >> > > >> shortly
> > > > > >> > > >>> > > > >> > > >> >>>> >>>> > after.
> > > > > >> > > >>> > > > >> > > >> >>>> >>>> >
> > > > > >> > > >>> > > > >> > > >> >>>> >>>> > I don't know how this would
> work
> > > > > >> > > >>> > > > >> > > >> >>>> >>>> > w.r.t.
> > > > > >> > > the CLI
> > > > > >> > > >>> > > > >> > > >> >>>> >>>> > or our
> > > > > >> > > >>> > > > >> > > >> workflow at
> > > > > >> > > >>> > > > >> > > >> >>>> >>>> > all, but at the moment, I
> really
> > > > > just
> > > > > >> > want
> > > > > >> > > to
> > > > > >> > > >>> at
> > > > > >> > > >>> > > > >> > > >> >>>> >>>> > least start
> > > > > >> > > >>> > > > >> > > >> to have
> > > > > >> > > >>> > > > >> > > >> >>>> >>>> > some headway towards 4.x and
> > > > > PhoneGap
> > > > > >> > day.
> > > > > >> > > >>> > > > >> > > >> >>>> >>>> >
> > > > > >> > > >>> > > > >> > > >> >>>> >>>> > What do people think of
> this so
> > > > far?
> > > > > >> > > >>> > > > >> > > >> >>>> >>>> > I'm
> > > > > >> > > going
> > > > > >> > > >>> > > > >> > > >> >>>> >>>> > to try to clean
> > > > > >> > > >>> > > > >> > > >> >>>> things
> > > > > >> > > >>> > > > >> > > >> >>>> >>>> > up a bit, since we've
> definitely
> > > > > done
> > > > > >> > > >>> > > > >> > > >> >>>> >>>> > a
> > > > > >> > > lot of
> > > > > >> > > >>> > > > >> > > >> >>>> >>>> > things that
> > > > > >> > > >>> > > > >> > > >> would
> > > > > >> > > >>> > > > >> > > >> >>>> make
> > > > > >> > > >>> > > > >> > > >> >>>> >>>> > first year CS profs freak
> the
> > > hell
> > > > > out
> > > > > >> > > (i.e.
> > > > > >> > > >>> > > > >> > > >> >>>> >>>> > public members in
> > > > > >> > > >>> > > > >> > > >> >>>> public
> > > > > >> > > >>> > > > >> > > >> >>>> >>>> > objects w.r.t.
> PluginManager).
> > > > > >> > > >>> > > > >> > > >> >>>> >>>> >
> > > > > >> > > >>> > > > >> > > >> >>>> >>>> > Thoughts?
> > > > > >> > > >>> > > > >> > > >> >>>> >>>> >
> > > > > >> > > >>> > > > >> > > >> >>>> >>>> > Joe
> > > > > >> > > >>> > > > >> > > >> >>>> >>>> >
> > > > > >> > > >>> > > > >> > > >> >>>> >>>>
> > > > > >> > > >>> > > > >> > > >> >>>> >>>
> > > > > >> > > >>> > > > >> > > >> >>>> >>>
> > > > > >> > > >>> > > > >> > > >> >>>>
> > > > > >> > > >>> > > > >> > > >>
> > > > > >> > > >>> > > > >> >
> > > > > >> > > >>> >
> > > > > >> > > >>>
> > > > > >> > >
> > > > > >> >
> > > > > >
> > > > > >
> > > > >
> > > > >
> > > >
> > >
>

RE: [Android] Refactoring for different engines

["Hu, Ningxin" <ni...@intel.com>]

Understood.

How about 9am Pacific, 12am Eastern and 0am China? Really appreciate.

Thanks,
-ningxin

> -----Original Message-----
> From: mmocny@google.com [mailto:mmocny@google.com] On Behalf Of Michal
> Mocny
> Sent: Thursday, April 24, 2014 11:45 AM
> To: dev
> Subject: Re: [Android] Refactoring for different engines
> 
> (Yeah 7pm Friday is more naughty than 4am for those of us with families.)
> 
> I think the original intent was just supposed to be a meet & greet right?
>  Lets just do it asap and consider formal scheduling with ample planning only if
> there are technical topics to discuss.
> 
> It would be nice, though, if Ian could make it, given his recent work on this.
> 
> -Michal
> 
> 
> On Wed, Apr 23, 2014 at 10:34 PM, Victor Sosa <so...@gmail.com>wrote:
> 
> > 4PM PST? That's 6 CST or 7 EST, me thinks. Seems to work for many of
> > us On Apr 23, 2014 8:49 PM, "Brian LeRoux" <b...@brian.io> wrote:
> >
> > > 4pm works for me…
> > >
> > >
> > > On Wed, Apr 23, 2014 at 6:19 PM, Hu, Ningxin <ni...@intel.com>
> > wrote:
> > >
> > > > I am in China. 1:00 PM PST means 4:00 AM here :o.
> > > > Could you please schedule it a little bit later, say 4:00 or 5:00
> > > > PM
> > PST?
> > > > It will be highly appreciated.
> > > >
> > > > Thanks,
> > > > -ningxin
> > > >
> > > > From: brian.leroux@gmail.com [mailto:brian.leroux@gmail.com] On
> > > > Behalf
> > > Of
> > > > Brian LeRoux
> > > > Sent: Thursday, April 24, 2014 6:10 AM
> > > > To: Joe Bowser
> > > > Cc: dev@cordova.apache.org; Hu, Ningxin
> > > > Subject: Re: [Android] Refactoring for different engines
> > > >
> > > > How does 1:00PST on Friday work for a hangout for everyone?
> > > >
> > > > On Wed, Apr 23, 2014 at 2:36 PM, Joe Bowser <bowserj@gmail.com<mailto:
> > > > bowserj@gmail.com>> wrote:
> > > > BTW: Here's my PoC for Mozilla so far.  It's very broken!
> > > >
> > > > https://github.com/infil00p/MozillaView
> > > >
> > > >
> > > >
> > > > On Wed, Apr 23, 2014 at 10:50 AM, Brian LeRoux <b@brian.io<mailto:
> > > > b@brian.io>> wrote:
> > > > > So I found a Moz hacker whom can help. what time on Fri do you
> > > > > guys
> > > want
> > > > to
> > > > > do this?
> > > > >
> > > > >
> > > > > On Wed, Apr 23, 2014 at 10:31 AM, Ian Clelland <
> > iclelland@chromium.org
> > > > <ma...@chromium.org>>
> > > > > wrote:
> > > > >>
> > > > >> I've managed to get this up and running now -- great work on
> > > > >> this,
> > > Joe!
> > > > >>
> > > > >> Mobilespec runs on my N4, with 10 failing tests: 3 in contacts;
> > > > >> 7 in file-transfer. Otherwise, things seem to be working pretty well.
> > > > >>
> > > > >> I used a new build of Crosswalk, and found that the embedding
> > > > >> API
> > has
> > > > >> changed since the weekend (when Ningxin's patches applied).
> > > > >> I've
> > > issued
> > > > a
> > > > >> pull request at
> > > > >> https://github.com/infil00p/cordova-crosswalk-engine/pull/5for
> > > > >> it
> > --
> > > > >>
> > > > >> I'm not sure if there's a way to keep compatibility with last
> > > > >> week's Crosswalk, or if we'd even want to. (Ningxin, if you
> > > > >> could
> > > take a
> > > > >> look at that PR and see if it makes sense, I'd appreciate it)
> > > > >>
> > > > >> Joe, I also had to patch the default constructor for
> > > > XWalkCordovaWebView;
> > > > >> it wasn't creating its own client objects, so it got the
> > > > >> default
> > ones,
> > > > and
> > > > >> most of the tests were failing because some component of the
> > > > >> bridge
> > > > wan't
> > > > >> working.
> > https://github.com/infil00p/cordova-crosswalk-engine/pull/4is
> > > > >> out
> > > > >> for that.
> > > > >>
> > > > >> Count me in for the hangout -- this is exciting stuff
> > > > >>
> > > > >> Ian
> > > > >>
> > > > >>
> > > > >> On Wed, Apr 23, 2014 at 10:26 AM, Brian LeRoux <b@brian.io<mailto:
> > > > b@brian.io>> wrote:
> > > > >>
> > > > >> > Yup I'll track em down
> > > > >> > On Apr 23, 2014 7:17 AM, "Andrew Grieve"
> > > > >> > <agrieve@chromium.org
> > > > <ma...@chromium.org>> wrote:
> > > > >> >
> > > > >> > > Does anyone have a contact at moz that we could invite?
> > > > >> > >
> > > > >> > > On Wed, Apr 23, 2014 at 10:09 AM, Andrew Grieve <
> > > > agrieve@chromium.org<ma...@chromium.org>>
> > > > >> > > wrote:
> > > > >> > > > Depends on their interest level I think. Faster we can
> > > > >> > > > get
> > this
> > > > out
> > > > >> > > > the door the better. If we need to delay for geckoview,
> > > > >> > > > then I
> > > > don't
> > > > >> > > > think we should gate on it, just release it after.
> > > > >> > > >
> > > > >> > > > On Wed, Apr 23, 2014 at 3:01 AM, Tommy Williams <
> > > > tommy@devgeeks.org<ma...@devgeeks.org>>
> > > > >> > > wrote:
> > > > >> > > >> More engines, more better...
> > > > >> > > >> On 23 Apr 2014 16:32, "Joe Bowser" <bowserj@gmail.com
> > <mailto:
> > > > bowserj@gmail.com>> wrote:
> > > > >> > > >>
> > > > >> > > >>> Hey
> > > > >> > > >>>
> > > > >> > > >>> A Hangout would have to happen on Friday at the earliest.
> > >  It'd
> > > > be
> > > > >> > > good if
> > > > >> > > >>> we could get someone from Mozilla on the hangout as
> > > > >> > > >>> well.  I haven't
> > > > >> > > gotten
> > > > >> > > >>> MozillaView (GeckoView with Cordova methods) fully
> > > > >> > > >>> working
> > > yet.
> > > > >> > > >>> For
> > > > >> > > some
> > > > >> > > >>> reason it's not rendering on the screen.
> > > > >> > > >>>
> > > > >> > > >>> Ideally it'd be cool to have at least two options when
> > > > >> > > >>> this feature
> > > > >> > > finally
> > > > >> > > >>> lands.
> > > > >> > > >>>
> > > > >> > > >>> What do other people think?
> > > > >> > > >>>
> > > > >> > > >>> Joe
> > > > >> > > >>> On 22 Apr 2014 20:06, "Hu, Ningxin"
> > > > >> > > >>> <ningxin.hu@intel.com
> > > > <ma...@intel.com>> wrote:
> > > > >> > > >>>
> > > > >> > > >>> > Joe,
> > > > >> > > >>> >
> > > > >> > > >>> > Thanks for your review and merge the PRs.
> > > > >> > > >>> >
> > > > >> > > >>> > To pluggable webview interest group:
> > > > >> > > >>> > Are we OK to setup a hangout this week for initial
> > > > introduction
> > > > >> > > >>> > and
> > > > >> > > >>> > discussion of next steps?
> > > > >> > > >>> >
> > > > >> > > >>> > Thanks,
> > > > >> > > >>> > -ningxin
> > > > >> > > >>> >
> > > > >> > > >>> > > -----Original Message-----
> > > > >> > > >>> > > From: Hu, Ningxin [mailto:ningxin.hu@intel.com<mailto:
> > > > ningxin.hu@intel.com>]
> > > > >> > > >>> > > Sent: Tuesday, April 22, 2014 4:04 PM
> > > > >> > > >>> > > To: dev@cordova.apache.org<mailto:
> > dev@cordova.apache.org>
> > > > >> > > >>> > > Subject: RE: [Android] Refactoring for different
> > > > >> > > >>> > > engines
> > > > >> > > >>> > >
> > > > >> > > >>> > > The PoC is great! Quite excited about the direction!
> > > > >> > > >>> > >
> > > > >> > > >>> > > I've sent a PR to update the
> > > > >> > > >>> > > cordova-crosswalk-engine to latest
> > > > >> > > >>> crosswalk
> > > > >> > > >>> > > embedding API. It works with xwalk_core_library at
> > > > 6.35.124.0.
> > > > >> > > >>> > >
> > > > >> > > >>> > > I've also changed the CordovaWebView interface
> > > > >> > > >>> > > slightly (adding
> > > > >> > > >>> > getView() API)
> > > > >> > > >>> > > to allow XWalkCordovaWebView to composite a
> > > > >> > > >>> > > XWalkView
> > > > instead
> > > > >> > > >>> > > of
> > > > >> > > >>> > extending
> > > > >> > > >>> > > it. It resolves some API naming issues for
> > > > >> > > >>> > > XWalkView
> > case.
> > > > >> > > >>> > >
> > > > >> > > >>> > > Please review them at:
> > > > >> > > >>> > >
> > > https://github.com/infil00p/cordova-crosswalk-engine/pull/3
> > > > >> > > >>> > > https://github.com/infil00p/cordova-android/pull/2
> > > > >> > > >>> > >
> > > > >> > > >>> > > Thanks,
> > > > >> > > >>> > > -ningxin
> > > > >> > > >>> > >
> > > > >> > > >>> > > > -----Original Message-----
> > > > >> > > >>> > > > From: Joe Bowser [mailto:bowserj@gmail.com<mailto:
> > > > bowserj@gmail.com>]
> > > > >> > > >>> > > > Sent: Friday, April 11, 2014 12:45 AM
> > > > >> > > >>> > > > To: dev
> > > > >> > > >>> > > > Subject: Re: [Android] Refactoring for different
> > engines
> > > > >> > > >>> > > >
> > > > >> > > >>> > > > Yeah, I'd be cool with setting up a hangout.
> > > > >> > > >>> > > > Everyone should
> > > > >> > > take a
> > > > >> > > >>> > > > look at the PoC, I've basically distilled it down
> > > > >> > > >>> > > > to
> > > four
> > > > or
> > > > >> > five
> > > > >> > > >>> > > > classes so far, but with some work, we may be
> > > > >> > > >>> > > > able to
> > > get
> > > > it
> > > > >> > > down to
> > > > >> > > >>> > > > three.  Due to legacy, we're pretty stuck with
> > > > >> > > >>> > > > the
> > > Android
> > > > >> > > WebView
> > > > >> > > >>> API
> > > > >> > > >>> > calls,
> > > > >> > > >>> > > but these can probably be modified.
> > > > >> > > >>> > > >
> > > > >> > > >>> > > > It'd be good to get Mozilla people on the call as
> > well,
> > > > >> > > >>> > > > since
> > > > >> > > they
> > > > >> > > >>> > > > have their WebView as well.
> > > > >> > > >>> > > >
> > > > >> > > >>> > > > On Thu, Apr 10, 2014 at 9:38 AM, Hu, Ningxin <
> > > > >> > > ningxin.hu@intel.com<ma...@intel.com>>
> > > > >> > > >>> > wrote:
> > > > >> > > >>> > > > > Hangout would be a good idea.
> > > > >> > > >>> > > > >
> > > > >> > > >>> > > > > FYI, I will be off next week. How about the
> > > > >> > > >>> > > > > week
> > after
> > > > >> > > >>> > > > > next?
> > > > >> > > If it
> > > > >> > > >>> > > > > works, please
> > > > >> > > >>> > > > feel free to schedule one and count me in.
> > > > >> > > >>> > > > >
> > > > >> > > >>> > > > > Thanks,
> > > > >> > > >>> > > > > -ningxin
> > > > >> > > >>> > > > >
> > > > >> > > >>> > > > >> -----Original Message-----
> > > > >> > > >>> > > > >> From:
> > > > >> > > >>> > > > >> mmocny@google.com<ma...@google.com>
> > > > [mailto:mmocny@google.com<ma...@google.com>] On
> > > > >> > Behalf
> > > > >> > > Of
> > > > >> > > >>> > > > >> Michal Mocny
> > > > >> > > >>> > > > >> Sent: Tuesday, April 08, 2014 11:39 PM
> > > > >> > > >>> > > > >> To: dev
> > > > >> > > >>> > > > >> Subject: Re: [Android] Refactoring for
> > > > >> > > >>> > > > >> different
> > > > engines
> > > > >> > > >>> > > > >>
> > > > >> > > >>> > > > >> Would it be alright to set up a Hangout some
> > > > >> > > >>> > > > >> time
> > to
> > > > >> > introduce
> > > > >> > > >>> > everyone?
> > > > >> > > >>> > > > >>
> > > > >> > > >>> > > > >> Joe has been leading the effort here, but
> > > > >> > > >>> > > > >> there are
> > > > other
> > > > >> > > cordova
> > > > >> > > >>> > > > >> contributors for whom this is top priority.
> > > > >> > > >>> > > > >> It
> > would
> > > > be
> > > > >> > nice
> > > > >> > > if
> > > > >> > > >>> we
> > > > >> > > >>> > > > >> could all meet to say hello and make sure we
> > > > >> > > >>> > > > >> are
> > all
> > > > >> > > >>> > > > >> going
> > > > >> > in
> > > > >> > > the
> > > > >> > > >>> > > > >> right
> > > > >> > > >>> > > > direction.
> > > > >> > > >>> > > > >>
> > > > >> > > >>> > > > >> Quite exciting!
> > > > >> > > >>> > > > >>
> > > > >> > > >>> > > > >> -Michal
> > > > >> > > >>> > > > >>
> > > > >> > > >>> > > > >>
> > > > >> > > >>> > > > >> On Tue, Apr 8, 2014 at 10:56 AM, Hu, Ningxin <
> > > > >> > > >>> ningxin.hu@intel.com<ma...@intel.com>>
> > > > >> > > >>> > > wrote:
> > > > >> > > >>> > > > >>
> > > > >> > > >>> > > > >> > Joe, thanks for this. I am very excited.
> > > > >> > > >>> > > > >> >
> > > > >> > > >>> > > > >> > FYI. Crosswalk team is working on
> > > > >> > > >>> > > > >> > refactoring the WebView
> > > > >> > > API to
> > > > >> > > >>> > > > >> > support embedding usage better [1].
> > > > >> > > >>> > > > >> > (Previously
> > the
> > > > >> > > >>> > > > >> > layer
> > > > >> > > API
> > > > >> > > >>> was
> > > > >> > > >>> > > > >> > not exposed as public usage).
> > > > >> > > >>> > > > >> >
> > > > >> > > >>> > > > >> > I would like to review the PoC and work with
> > > > >> > > >>> > > > >> > you
> > to
> > > > get
> > > > >> > > >>> Crosswalk
> > > > >> > > >>> > > > >> > fits into the pluggable WebView architecture.
> > > > >> > > >>> > > > >> >
> > > > >> > > >>> > > > >> > Thanks,
> > > > >> > > >>> > > > >> > -ningxin
> > > > >> > > >>> > > > >> >
> > > > >> > > >>> > > > >> > > -----Original Message-----
> > > > >> > > >>> > > > >> > > From: Joe Bowser [mailto:bowserj@gmail.com
> > > <mailto:
> > > > bowserj@gmail.com>]
> > > > >> > > >>> > > > >> > > Sent: Wednesday, March 19, 2014 7:08 AM
> > > > >> > > >>> > > > >> > > To: dev
> > > > >> > > >>> > > > >> > > Subject: Re: [Android] Refactoring for
> > different
> > > > >> > > >>> > > > >> > > engines
> > > > >> > > >>> > > > >> > >
> > > > >> > > >>> > > > >> > > Hey
> > > > >> > > >>> > > > >> > >
> > > > >> > > >>> > > > >> > > After debugging, I did some minor updates
> > > > >> > > >>> > > > >> > > to
> > the
> > > > >> > > >>> > > > >> > > plugin
> > > > >> > > >>> README.
> > > > >> > > >>> > > > >> > > It
> > > > >> > > >>> > > > >> > should be
> > > > >> > > >>> > > > >> > > easier to get this up and running,
> > > > >> > > >>> > > > >> > > although
> > > there's
> > > > >> > still
> > > > >> > > the
> > > > >> > > >>> > > > >> > > issue of
> > > > >> > > >>> > > > >> > after-install
> > > > >> > > >>> > > > >> > > hooks and the relative path weirdness with
> > > > >> > > >>> > > > >> > > the Crosswalk
> > > > >> > > >>> > Library itself.
> > > > >> > > >>> > > > >> > >
> > > > >> > > >>> > > > >> > > It still doesn't support the CLI at all,
> > > > >> > > >>> > > > >> > > but it should
> > > > >> > be
> > > > >> > > >>> there
> > > > >> > > >>> > > > >> > > with the
> > > > >> > > >>> > > > >> > old flow.
> > > > >> > > >>> > > > >> > >
> > > > >> > > >>> > > > >> > > On Mon, Mar 17, 2014 at 1:14 PM, Michal
> > > > >> > > >>> > > > >> > > Mocny
> > > > >> > > >>> > > > >> > > <mmocny@chromium.org<mailto:
> > mmocny@chromium.org
> > > >>
> > > > >> > > >>> > > > >> > > wrote:
> > > > >> > > >>> > > > >> > > > (Sorry Joe, Googlers are down in
> > > > >> > > >>> > > > >> > > > California
> > and
> > > > way
> > > > >> > > busy.
> > > > >> > > >>> > > > >> > > > Will be back in a week.  Super excited
> > > > >> > > >>> > > > >> > > > about
> > > > this,
> > > > >> > > though.)
> > > > >> > > >>> > > > >> > > >
> > > > >> > > >>> > > > >> > > > -Michal
> > > > >> > > >>> > > > >> > > >
> > > > >> > > >>> > > > >> > > >
> > > > >> > > >>> > > > >> > > > On Mon, Mar 17, 2014 at 2:53 PM, Joe
> > > > >> > > >>> > > > >> > > > Bowser
> > > > >> > > >>> > > > >> > > > <bowserj@gmail.com<mailto:bowserj@gmail.
> > > > >> > > >>> > > > >> > > > com
> > >>
> > > > >> > > >>> > > > >> wrote:
> > > > >> > > >>> > > > >> > > >
> > > > >> > > >>> > > > >> > > >> Reviving this thread!
> > > > >> > > >>> > > > >> > > >>
> > > > >> > > >>> > > > >> > > >> Can other people look at this, and see
> > if/when
> > > > we
> > > > >> > > should
> > > > >> > > >>> > land this?
> > > > >> > > >>> > > > >> > > >> I know that I have to re-write the
> > > > >> > > >>> > > > >> > > >> tests
> > > still,
> > > > >> > > >>> > > > >> > > >> but I
> > > > >> > > would
> > > > >> > > >>> > > > >> > > >> like some feedback before merging it in.
> > >  Also,
> > > > >> > > >>> > > > >> > > >> it'd
> > > > >> > be
> > > > >> > > >>> > > > >> > > >> super awesome if other people could try
> > > > >> > > >>> > > > >> > > >> and
> > > > make a
> > > > >> > > WebView
> > > > >> > > >>> > > > >> > > >> based on the interfaces and recommend
> > > > >> > > >>> > > > >> > > >> which methods
> > > > >> > > should
> > > > >> > > >>> > > > >> > > >> die.  I want to get this released in
> > > > >> > > >>> > > > >> > > >> the
> > next
> > > > >> > > >>> > > > >> > > >> month
> > > > >> > or
> > > > >> > > so,
> > > > >> > > >>> > > > >> > > >> so any time and feedback would be
> > > > >> > > >>> > > > >> > > >> greatly
> > > > >> > appreciated.
> > > > >> > > >>> > > > >> > > >>
> > > > >> > > >>> > > > >> > > >> Thanks
> > > > >> > > >>> > > > >> > > >>
> > > > >> > > >>> > > > >> > > >> On Thu, Mar 13, 2014 at 3:50 PM, Joe
> > > > >> > > >>> > > > >> > > >> Bowser
> > > > >> > > >>> > > > >> > > >> <bowserj@gmail.com<mailto:bowserj@gmail
> > > > >> > > >>> > > > >> > > >> .com
> > >>
> > > > >> > > >>> > > > >> > wrote:
> > > > >> > > >>> > > > >> > > >> > Hey, I created the following today to
> > track
> > > > >> > > >>> > > > >> > > >> > various WebView
> > > > >> > > >>> > > > >> > progresses:
> > > > >> > > >>> > > > >> > > >> >
> > > https://issues.apache.org/jira/browse/CB-6246
> > > > >> > > >>> > > > >> > > >> >
> > > > >> > > >>> > > > >> > > >> > I also have this repo created.  The
> > > licensing
> > > > is
> > > > >> > > ugly as
> > > > >> > > >>> > > > >> > > >> > all crap, but it's a Proof-Of-Concept:
> > > > >> > > >>> > > > >> > > >> >
> > > > >> > https://github.com/infil00p/cordova-crosswalk-engine
> > > > >> > > >>> > > > >> > > >> >
> > > > >> > > >>> > > > >> > > >> > If I can get some help getting plugman to
> > > just
> > > > >> > > >>> > > > >> > > >> > load
> > > > >> > > >>> > > > >> > > >> > Crosswalk, it'll
> > > > >> > > >>> > > > >> > > >> look hawt.
> > > > >> > > >>> > > > >> > > >> >
> > > > >> > > >>> > > > >> > > >> > BTW: We should probably get this ready to
> > go
> > > > >> > > >>> > > > >> > > >> > into
> > > > >> > > Android
> > > > >> > > >>> > > > >> > > >> > in the next two months and deprecate the
> > > > >> > setProperty
> > > > >> > > >>> > > > >> > > >> > methods, since all properties should be
> > > > >> > > >>> > > > >> > > >> > preferences
> > > > >> > > in
> > > > >> > > >>> > config.xml
> > > > >> > > >>> > > now.
> > > > >> > > >>> > > > >> > > >> >
> > > > >> > > >>> > > > >> > > >> > On Mon, Mar 10, 2014 at 2:42 PM, Joe
> > Bowser
> > > > >> > > >>> > > > >> > > >> > <bowserj@gmail.com<mailto:
> > bowserj@gmail.com
> > > >>
> > > > >> > > >>> > > > >> > > wrote:
> > > > >> > > >>> > > > >> > > >> >> Perhaps. There would be additional
> > benefits
> > > > to
> > > > >> > this
> > > > >> > > >>> > > > >> > > >> >> approach, namely fixes being added to
> > that
> > > > >> > platform
> > > > >> > > more
> > > > >> > > >>> > > > >> > > >> >> quickly.  I'll probably take a look at
> > that
> > > > >> > > >>> > > > >> > > >> >> once I
> > > > >> > > have
> > > > >> > > >>> > > > >> > > >> >> Crosswalk
> > > > >> > > >>> > > > finalized.
> > > > >> > > >>> > > > >> > > >> >>
> > > > >> > > >>> > > > >> > > >> >> On Mon, Mar 10, 2014 at 9:49 AM, Brian
> > > LeRoux
> > > > >> > > >>> > > > >> > > >> >> <b@...@brian.io>>
> > > > >> > > >>> > > > wrote:
> > > > >> > > >>> > > > >> > > >> >>> this is great stuff
> > > > >> > > >>> > > > >> > > >> >>>
> > > > >> > > >>> > > > >> > > >> >>> do we think it may be possible to bring
> > in
> > > > >> > > >>> > > > >> > > >> >>> amazon
> > > > >> > > >>> fireos
> > > > >> > > >>> > > > >> > > >> >>> stuff
> > > > >> > > >>> > > > >> > > >> eventually
> > > > >> > > >>> > > > >> > > >> >>> too?
> > > > >> > > >>> > > > >> > > >> >>>
> > > > >> > > >>> > > > >> > > >> >>>
> > > > >> > > >>> > > > >> > > >> >>> On Fri, Mar 7, 2014 at 3:22 PM, Joe
> > Bowser
> > > > >> > > >>> > > > >> > > >> >>> <bowserj@gmail.com<mailto:
> > > bowserj@gmail.com
> > > > >>
> > > > >> > > >>> > > > >> > wrote:
> > > > >> > > >>> > > > >> > > >> >>>
> > > > >> > > >>> > > > >> > > >> >>>> BTW: I committed it in my repo, not the
> > > > main
> > > > >> > > Apache
> > > > >> > > >>> one.
> > > > >> > > >>> > > > >> > > >> >>>>
> > > > >> > > >>> > > > >> > > >> >>>> On Fri, Mar 7, 2014 at 3:21 PM, Joe
> > > Bowser
> > > > >> > > >>> > > > >> > > >> >>>> <bowserj@gmail.com<mailto:
> > > > bowserj@gmail.com>>
> > > > >> > > >>> > > > >> > > wrote:
> > > > >> > > >>> > > > >> > > >> >>>> > Hey
> > > > >> > > >>> > > > >> > > >> >>>> >
> > > > >> > > >>> > > > >> > > >> >>>> > I just committed some code based on
> > > their
> > > > >> > > WebView
> > > > >> > > >>> > > > >> > > >> >>>> > modifications that allows you to
> > choose
> > > > >> > > >>> > > > >> > > >> >>>> > your
> > > > >> > > >>> renderer
> > > > >> > > >>> > > > >> > > >> >>>> > in the
> > > > >> > > >>> > > > >> > config file
> > > > >> > > >>> > > > >> > > with this:
> > > > >> > > >>> > > > >> > > >> >>>> >
> > > > >> > > >>> > > > >> > > >> >>>> >     <preference name="webView"
> > > > >> > > >>> > > > >> > > >> >>>> >
> > > > >> > > >>> value="org.apache.cordova.engine.crosswalk.XWalkCordo
> > > > >> > > >>> > > > >> > > >> >>>> > va
> > > > >> > > >>> > > > >> > > >> >>>> > Web
> > > > >> > > >>> > > > >> > > >> >>>> > View
> > > > >> > > >>> > > > >> > > >> >>>> > " />
> > > > >> > > >>> > > > >> > > >> >>>> >
> > > > >> > > >>> > > > >> > > >> >>>> > You currently have to copy over the
> > > *.pak
> > > > >> > > >>> > > > >> > > >> >>>> > file
> > > > >> > > and
> > > > >> > > >>> > > > >> > > >> >>>> > the jsapi from a Crosswalk Example
> > > > project
> > > > >> > > >>> > > > >> > > >> >>>> > to
> > > > >> > > get
> > > > >> > > >>> > > > >> > > >> >>>> > this to work.  The next thing that
> > I'm
> > > > >> > > >>> > > > >> > > >> >>>> > going
> > > > >> > to
> > > > >> > > do
> > > > >> > > >>> is
> > > > >> > > >>> > > > >> > > >> >>>> > figure out how to write this as a
> > > plugin
> > > > >> > > >>> > > > >> > > >> >>>> > and
> > > > >> > > have it
> > > > >> > > >>> > > > >> > > >> >>>> > install on a default
> > > > >> > > >>> > > > project.
> > > > >> > > >>> > > > >> > > >> >>>> > Also, right now the bridge doesn't
> > seem
> > > > to
> > > > >> > > work, and
> > > > >> > > >>> > > > >> > > >> >>>> > I don't know why exactly.  That being
> > > > said,
> > > > >> > the
> > > > >> > > >>> > > > >> > > >> fact
> > > > >> > > >>> > > > >> > > >> >>>> > that I can choose which version of
> > > > >> > > Chrome/Chromium
> > > > >> > > >>> > > > >> > > >> >>>> > I'm running with
> > > > >> > > >>> > > > >> > > >> a
> > > > >> > > >>> > > > >> > > >> >>>> > single XML preference is HUGE.
> > > > >> > > >>> > > > >> > > >> >>>> >
> > > > >> > > >>> > > > >> > > >> >>>> > There's definitely a lot more work
> > that
> > > > >> > > >>> > > > >> > > >> >>>> > needs
> > > > >> > > to be
> > > > >> > > >>> > > > >> > > >> >>>> > done, but as
> > > > >> > > >>> > > > >> > > >> long
> > > > >> > > >>> > > > >> > > >> >>>> > as we have something that we can fit
> > > into
> > > > >> > > >>> > > > >> > > >> >>>> > the
> > > > >> > > >>> > > > >> > > >> >>>> > interface, we should
> > > > >> > > >>> > > > >> > > >> be
> > > > >> > > >>> > > > >> > > >> >>>> > able to put in things like GeckoView
> > or
> > > > >> > > >>> > > > >> > > >> >>>> > other
> > > > >> > > third
> > > > >> > > >>> > > > >> > > >> >>>> > party
> > > > >> > > >>> > > > >> > renderers.
> > > > >> > > >>> > > > >> > > >> >>>> > The nightmare of being stuck with
> > > > bullshit
> > > > >> > > WebView
> > > > >> > > >>> > > > >> > > >> >>>> > bugs may soon be over.
> > > > >> > > >>> > > > >> > > >> >>>> >
> > > > >> > > >>> > > > >> > > >> >>>> > On Wed, Mar 5, 2014 at 8:59 PM,
> > Michal
> > > > >> > > >>> > > > >> > > >> >>>> > Mocny
> > > > >> > > >>> > > > >> > > >> >>>> > <mmocny@chromium.org<mailto:
> > > > mmocny@chromium.org>>
> > > > >> > > >>> > > > >> > > >> >>>> wrote:
> > > > >> > > >>> > > > >> > > >> >>>> >>
> > > > >> > > >>> https://github.com/crosswalk-project/crosswalk-cordo
> > > > >> > > >>> > > > >> > > >> >>>> >> va
> > > > >> > > >>> > > > >> > > >> >>>> >> -an
> > > > >> > > >>> > > > >> > > >> >>>> >> droi
> > > > >> > > >>> > > > >> > > >> >>>> >> d
> > > > >> > > >>> > > > >> > > >> >>>> >>
> > > > >> > > >>> > > > >> > > >> >>>> >> First patch they landed, which
> > claims
> > > to
> > > > >> > > >>> > > > >> > > >> >>>> >> have
> > > > >> > > min
> > > > >> > > >>> > > > >> > > >> >>>> >> viable xwalk
> > > > >> > > >>> > > > >> > > >> webview:
> > > > >> > > >>> > > > >> > > >> >>>> >>
> > > > >> > > >>> > > > >> > > >> >>>>
> > > > >> > > >>> > > > >> > > >>
> > > > >> > > >>>
> > https://github.com/crosswalk-project/crosswalk-cordova-andro
> > > > >> > > >>> > > > >> > > >> id
> > > > >> > > >>> > > > >> > > >> /co
> > > > >> > > >>> > > > >> > > >> mmit
> > > > >> > > >>> > > > >> > > >> /a04dedeb0204e7542d190312c6ae70c795a26e04
> > > > >> > > >>> > > > >> > > >> >>>> >>
> > > > >> > > >>> > > > >> > > >> >>>> >>
> > > > >> > > >>> > > > >> > > >> >>>> >> On Wed, Mar 5, 2014 at 11:37 PM,
> > > Michal
> > > > >> > > >>> > > > >> > > >> >>>> >> Mocny
> > > > >> > > >>> > > > >> > > >> >>>> >> <mmocny@chromium.org<mailto:
> > > > mmocny@chromium.org>
> > > > >> > > >>> > > > >> > > >> >
> > > > >> > > >>> > > > >> > > >> >>>> wrote:
> > > > >> > > >>> > > > >> > > >> >>>> >>
> > > > >> > > >>> > > > >> > > >> >>>> >>> I haven't looked yet, but did you
> > > see:
> > > > >> > > >>> > > > >> > > >> >>>> >>>
> > > > >> > > >>> https://crosswalk-project.org/#wiki/crosswalk-cordo
> > > > >> > > >>> > > > >> > > >> >>>> >>> va
> > > > >> > > >>> > > > >> > > >> >>>> >>> -an
> > > > >> > > >>> > > > >> > > >> >>>> >>> droi
> > > > >> > > >>> > > > >> > > >> >>>> >>> d
> > > > >> > > >>> > > > >> > > >> >>>> >>>
> > > > >> > > >>> > > > >> > > >> >>>> >>> ?
> > > > >> > > >>> > > > >> > > >> >>>> >>>
> > > > >> > > >>> > > > >> > > >> >>>> >>>
> > > > >> > > >>> > > > >> > > >> >>>> >>> On Wed, Mar 5, 2014 at 10:20 PM,
> > > Andrew
> > > > >> > > Grieve <
> > > > >> > > >>> > > > >> > > >> agrieve@chromium.org<mailto:
> > > > agrieve@chromium.org>
> > > > >> > > >>> > > > >> > > >> >>>> >wrote:
> > > > >> > > >>> > > > >> > > >> >>>> >>>
> > > > >> > > >>> > > > >> > > >> >>>> >>>> First - very excited that you're
> > > > working
> > > > >> > > >>> > > > >> > > >> >>>> >>>> on
> > > > >> > > this!
> > > > >> > > >>> > > > >> > > >> >>>> >>>>
> > > > >> > > >>> > > > >> > > >> >>>> >>>> Had a quick look. Not sure there's
> > > > much
> > > > >> > > >>> > > > >> > > >> >>>> >>>> to
> > > > >> > be
> > > > >> > > >>> > gleaned
> > > > >> > > >>> > > yet.
> > > > >> > > >>> > > > >> > > >> >>>> >>>> Once
> > > > >> > > >>> > > > >> > > >> you
> > > > >> > > >>> > > > >> > > >> >>>> start
> > > > >> > > >>> > > > >> > > >> >>>> >>>> in on hooking up x-walk's webview
> > I
> > > > >> > > >>> > > > >> > > >> >>>> >>>> think
> > > > >> > it
> > > > >> > > will
> > > > >> > > >>> > > > >> > > >> >>>> >>>> become more
> > > > >> > > >>> > > > >> > > >> obvious
> > > > >> > > >>> > > > >> > > >> >>>> what
> > > > >> > > >>> > > > >> > > >> >>>> >>>> the interface should look like.
> > > E.g.,
> > > > >> > > >>> > > > >> > > >> >>>> >>>> does
> > > > >> > > x-walk
> > > > >> > > >>> > > > >> > > >> >>>> >>>> even have the
> > > > >> > > >>> > > > >> > > >> >>>> concept of
> > > > >> > > >>> > > > >> > > >> >>>> >>>> ChromeClient vs WebViewClient vs
> > > > >> > > >>> > > > >> > > >> >>>> >>>> WebView?
> > > > >> > > Also
> > > > >> > > >>> > > > >> > > >> >>>> >>>> unsure whether the
> > > > >> > > >>> > > > >> > > >> >>>> class
> > > > >> > > >>> > > > >> > > >> >>>> >>>> should extend android.View as well
> > > as
> > > > >> > > implement
> > > > >> > > >>> > > > >> > > >> >>>> >>>> our
> > > > >> > > >>> > > > >> > interface.
> > > > >> > > >>> > > > >> > > >> E.g.
> > > > >> > > >>> > > > >> > > >> >>>> >>>> alternative is to have a
> > "getView()"
> > > > >> > > >>> > > > >> > > >> >>>> >>>> method
> > > > >> > > on
> > > > >> > > >>> the
> > > > >> > > >>> > > > >> > interface.
> > > > >> > > >>> > > > >> > > >> Might
> > > > >> > > >>> > > > >> > > >> >>>> help
> > > > >> > > >>> > > > >> > > >> >>>> >>>> to
> > > > >> > > >>> > > > >> > > >> >>>> >>>> cut down on file sizes, and API
> > > > surface,
> > > > >> > but
> > > > >> > > >>> > > > >> > > >> >>>> >>>> again, I'm not too
> > > > >> > > >>> > > > >> > > >> sure.
> > > > >> > > >>> > > > >> > > >> >>>> >>>>
> > > > >> > > >>> > > > >> > > >> >>>> >>>> I've been pretty hesitant to touch
> > > > >> > > >>> > > > >> > > >> >>>> >>>> existing
> > > > >> > > >>> > > > >> > > >> >>>> >>>> exposed members
> > > > >> > > >>> > > > >> > > >> (e.g. the
> > > > >> > > >>> > > > >> > > >> >>>> >>>> public fields you were referring
> > to)
> > > > >> > > >>> > > > >> > > >> >>>> >>>> since
> > > > >> > > >>> > > > >> > > >> >>>> >>>> touching anything
> > > > >> > > >>> > > > >> > > >> public
> > > > >> > > >>> > > > >> > > >> >>>> could
> > > > >> > > >>> > > > >> > > >> >>>> >>>> break plugins. That said, maybe
> > now
> > > > is a
> > > > >> > good
> > > > >> > > >>> time
> > > > >> > > >>> > > > >> > > >> >>>> >>>> to @deprecate
> > > > >> > > >>> > > > >> > > >> a
> > > > >> > > >>> > > > >> > > >> >>>> bunch
> > > > >> > > >>> > > > >> > > >> >>>> >>>> of
> > > > >> > > >>> > > > >> > > >> >>>> >>>> them and either replace them with
> > > > >> > > >>> > > > >> > > >> >>>> >>>> getters,
> > > > >> > or
> > > > >> > > >>> just
> > > > >> > > >>> > > > >> > > >> >>>> >>>> declare them
> > > > >> > > >>> > > > >> > > >> to be
> > > > >> > > >>> > > > >> > > >> >>>> not
> > > > >> > > >>> > > > >> > > >> >>>> >>>> exposed to plugins.
> > > > >> > > >>> > > > >> > > >> >>>> >>>>
> > > > >> > > >>> > > > >> > > >> >>>> >>>>
> > > > >> > > >>> > > > >> > > >> >>>> >>>> On Wed, Mar 5, 2014 at 6:57 PM,
> > Joe
> > > > >> > > >>> > > > >> > > >> >>>> >>>> Bowser
> > > > >> > > >>> > > > >> > > >> >>>> >>>> <bowserj@gmail.com<mailto:
> > > > bowserj@gmail.com>>
> > > > >> > > >>> > > > >> > > >> wrote:
> > > > >> > > >>> > > > >> > > >> >>>> >>>>
> > > > >> > > >>> > > > >> > > >> >>>> >>>> > So, after looking at the
> > Crosswalk
> > > > >> > > >>> > > > >> > > >> >>>> >>>> > code
> > > > >> > > again,
> > > > >> > > >>> > > > >> > > >> >>>> >>>> > I've decided to
> > > > >> > > >>> > > > >> > > >> take
> > > > >> > > >>> > > > >> > > >> >>>> a
> > > > >> > > >>> > > > >> > > >> >>>> >>>> > quick stab at making things
> > > > pluggable.
> > > > >> > > >>> > > > >> > > >> >>>> >>>> > I
> > > > >> > > don't
> > > > >> > > >>> > > > >> > > >> >>>> >>>> > have a lot to
> > > > >> > > >>> > > > >> > > >> show
> > > > >> > > >>> > > > >> > > >> >>>> for
> > > > >> > > >>> > > > >> > > >> >>>> >>>> > it, but with the help of Eclipse
> > > > >> > > >>> > > > >> > > >> >>>> >>>> > (which
> > > > >> > is
> > > > >> > > why
> > > > >> > > >>> > > > >> > > >> >>>> >>>> > the generated interfaces look so
> > > > >> > > >>> > > > >> > > >> >>>> >>>> > screwed
> > > > >> > > up), I
> > > > >> > > >>> > > > >> > > >> >>>> >>>> > managed to create some
> > > > >> > > >>> > > > >> > > >> interfaces
> > > > >> > > >>> > > > >> > > >> >>>> so
> > > > >> > > >>> > > > >> > > >> >>>> >>>> > we can start shoehorning in
> > other
> > > > >> > > >>> > > > >> > > >> >>>> >>>> > browser
> > > > >> > > >>> > renderers.
> > > > >> > > >>> > > > >> > > >> >>>> >>>> >
> > > > >> > > >>> > > > >> > > >> >>>> >>>> >
> > > > >> > > >>> > > > >> > > >>
> > > > >> > > >>>
> > https://github.com/infil00p/cordova-android/tree/pluggable_w
> > > > >> > > >>> > > > >> > > >> eb
> > > > >> > > >>> > > > >> > > >> vie
> > > > >> > > >>> > > > >> > > >> w
> > > > >> > > >>> > > > >> > > >> >>>> >>>> >
> > > > >> > > >>> > > > >> > > >> >>>> >>>> > I'm going to probably start with
> > > > >> > Crosswalk,
> > > > >> > > >>> > > > >> > > >> >>>> >>>> > because it's
> > > > >> > > >>> > > > >> > > >> probably
> > > > >> > > >>> > > > >> > > >> >>>> the
> > > > >> > > >>> > > > >> > > >> >>>> >>>> > most mature primary candidate in
> > > the
> > > > >> > > Android
> > > > >> > > >>> > > > >> > > >> >>>> >>>> > Third-Party
> > > > >> > > >>> > > > >> > > >> WebView
> > > > >> > > >>> > > > >> > > >> >>>> >>>> > thing, and I'm pretty sure the
> > > > >> > > >>> > > > >> > > >> >>>> >>>> > GeckoView
> > > > >> > > will
> > > > >> > > >>> be
> > > > >> > > >>> > > > >> > > >> >>>> >>>> > happening
> > > > >> > > >>> > > > >> > > >> shortly
> > > > >> > > >>> > > > >> > > >> >>>> >>>> > after.
> > > > >> > > >>> > > > >> > > >> >>>> >>>> >
> > > > >> > > >>> > > > >> > > >> >>>> >>>> > I don't know how this would work
> > > > >> > > >>> > > > >> > > >> >>>> >>>> > w.r.t.
> > > > >> > > the CLI
> > > > >> > > >>> > > > >> > > >> >>>> >>>> > or our
> > > > >> > > >>> > > > >> > > >> workflow at
> > > > >> > > >>> > > > >> > > >> >>>> >>>> > all, but at the moment, I really
> > > > just
> > > > >> > want
> > > > >> > > to
> > > > >> > > >>> at
> > > > >> > > >>> > > > >> > > >> >>>> >>>> > least start
> > > > >> > > >>> > > > >> > > >> to have
> > > > >> > > >>> > > > >> > > >> >>>> >>>> > some headway towards 4.x and
> > > > PhoneGap
> > > > >> > day.
> > > > >> > > >>> > > > >> > > >> >>>> >>>> >
> > > > >> > > >>> > > > >> > > >> >>>> >>>> > What do people think of this so
> > > far?
> > > > >> > > >>> > > > >> > > >> >>>> >>>> > I'm
> > > > >> > > going
> > > > >> > > >>> > > > >> > > >> >>>> >>>> > to try to clean
> > > > >> > > >>> > > > >> > > >> >>>> things
> > > > >> > > >>> > > > >> > > >> >>>> >>>> > up a bit, since we've definitely
> > > > done
> > > > >> > > >>> > > > >> > > >> >>>> >>>> > a
> > > > >> > > lot of
> > > > >> > > >>> > > > >> > > >> >>>> >>>> > things that
> > > > >> > > >>> > > > >> > > >> would
> > > > >> > > >>> > > > >> > > >> >>>> make
> > > > >> > > >>> > > > >> > > >> >>>> >>>> > first year CS profs freak the
> > hell
> > > > out
> > > > >> > > (i.e.
> > > > >> > > >>> > > > >> > > >> >>>> >>>> > public members in
> > > > >> > > >>> > > > >> > > >> >>>> public
> > > > >> > > >>> > > > >> > > >> >>>> >>>> > objects w.r.t. PluginManager).
> > > > >> > > >>> > > > >> > > >> >>>> >>>> >
> > > > >> > > >>> > > > >> > > >> >>>> >>>> > Thoughts?
> > > > >> > > >>> > > > >> > > >> >>>> >>>> >
> > > > >> > > >>> > > > >> > > >> >>>> >>>> > Joe
> > > > >> > > >>> > > > >> > > >> >>>> >>>> >
> > > > >> > > >>> > > > >> > > >> >>>> >>>>
> > > > >> > > >>> > > > >> > > >> >>>> >>>
> > > > >> > > >>> > > > >> > > >> >>>> >>>
> > > > >> > > >>> > > > >> > > >> >>>>
> > > > >> > > >>> > > > >> > > >>
> > > > >> > > >>> > > > >> >
> > > > >> > > >>> >
> > > > >> > > >>>
> > > > >> > >
> > > > >> >
> > > > >
> > > > >
> > > >
> > > >
> > >
> >

Re: [Android] Refactoring for different engines

[Joe Bowser <bo...@gmail.com>]

I'm fine with 4 pm.  The coworking space closes at 5 pm, so Brian and
I would have to find another location elsewhere.

On Wed, Apr 23, 2014 at 8:45 PM, Michal Mocny <mm...@chromium.org> wrote:
> (Yeah 7pm Friday is more naughty than 4am for those of us with families.)
>
> I think the original intent was just supposed to be a meet & greet right?
>  Lets just do it asap and consider formal scheduling with ample planning
> only if there are technical topics to discuss.
>
> It would be nice, though, if Ian could make it, given his recent work on
> this.
>
> -Michal
>
>
> On Wed, Apr 23, 2014 at 10:34 PM, Victor Sosa <so...@gmail.com>wrote:
>
>> 4PM PST? That's 6 CST or 7 EST, me thinks. Seems to work for many of us
>> On Apr 23, 2014 8:49 PM, "Brian LeRoux" <b...@brian.io> wrote:
>>
>> > 4pm works for me…
>> >
>> >
>> > On Wed, Apr 23, 2014 at 6:19 PM, Hu, Ningxin <ni...@intel.com>
>> wrote:
>> >
>> > > I am in China. 1:00 PM PST means 4:00 AM here :o.
>> > > Could you please schedule it a little bit later, say 4:00 or 5:00 PM
>> PST?
>> > > It will be highly appreciated.
>> > >
>> > > Thanks,
>> > > -ningxin
>> > >
>> > > From: brian.leroux@gmail.com [mailto:brian.leroux@gmail.com] On Behalf
>> > Of
>> > > Brian LeRoux
>> > > Sent: Thursday, April 24, 2014 6:10 AM
>> > > To: Joe Bowser
>> > > Cc: dev@cordova.apache.org; Hu, Ningxin
>> > > Subject: Re: [Android] Refactoring for different engines
>> > >
>> > > How does 1:00PST on Friday work for a hangout for everyone?
>> > >
>> > > On Wed, Apr 23, 2014 at 2:36 PM, Joe Bowser <bowserj@gmail.com<mailto:
>> > > bowserj@gmail.com>> wrote:
>> > > BTW: Here's my PoC for Mozilla so far.  It's very broken!
>> > >
>> > > https://github.com/infil00p/MozillaView
>> > >
>> > >
>> > >
>> > > On Wed, Apr 23, 2014 at 10:50 AM, Brian LeRoux <b@brian.io<mailto:
>> > > b@brian.io>> wrote:
>> > > > So I found a Moz hacker whom can help. what time on Fri do you guys
>> > want
>> > > to
>> > > > do this?
>> > > >
>> > > >
>> > > > On Wed, Apr 23, 2014 at 10:31 AM, Ian Clelland <
>> iclelland@chromium.org
>> > > <ma...@chromium.org>>
>> > > > wrote:
>> > > >>
>> > > >> I've managed to get this up and running now -- great work on this,
>> > Joe!
>> > > >>
>> > > >> Mobilespec runs on my N4, with 10 failing tests: 3 in contacts; 7 in
>> > > >> file-transfer. Otherwise, things seem to be working pretty well.
>> > > >>
>> > > >> I used a new build of Crosswalk, and found that the embedding API
>> has
>> > > >> changed since the weekend (when Ningxin's patches applied). I've
>> > issued
>> > > a
>> > > >> pull request at
>> > > >> https://github.com/infil00p/cordova-crosswalk-engine/pull/5for it
>> --
>> > > >>
>> > > >> I'm not sure if there's a way to keep compatibility with last
>> > > >> week's Crosswalk, or if we'd even want to. (Ningxin, if you could
>> > take a
>> > > >> look at that PR and see if it makes sense, I'd appreciate it)
>> > > >>
>> > > >> Joe, I also had to patch the default constructor for
>> > > XWalkCordovaWebView;
>> > > >> it wasn't creating its own client objects, so it got the default
>> ones,
>> > > and
>> > > >> most of the tests were failing because some component of the bridge
>> > > wan't
>> > > >> working.
>> https://github.com/infil00p/cordova-crosswalk-engine/pull/4is
>> > > >> out
>> > > >> for that.
>> > > >>
>> > > >> Count me in for the hangout -- this is exciting stuff
>> > > >>
>> > > >> Ian
>> > > >>
>> > > >>
>> > > >> On Wed, Apr 23, 2014 at 10:26 AM, Brian LeRoux <b@brian.io<mailto:
>> > > b@brian.io>> wrote:
>> > > >>
>> > > >> > Yup I'll track em down
>> > > >> > On Apr 23, 2014 7:17 AM, "Andrew Grieve" <agrieve@chromium.org
>> > > <ma...@chromium.org>> wrote:
>> > > >> >
>> > > >> > > Does anyone have a contact at moz that we could invite?
>> > > >> > >
>> > > >> > > On Wed, Apr 23, 2014 at 10:09 AM, Andrew Grieve <
>> > > agrieve@chromium.org<ma...@chromium.org>>
>> > > >> > > wrote:
>> > > >> > > > Depends on their interest level I think. Faster we can get
>> this
>> > > out
>> > > >> > > > the door the better. If we need to delay for geckoview, then I
>> > > don't
>> > > >> > > > think we should gate on it, just release it after.
>> > > >> > > >
>> > > >> > > > On Wed, Apr 23, 2014 at 3:01 AM, Tommy Williams <
>> > > tommy@devgeeks.org<ma...@devgeeks.org>>
>> > > >> > > wrote:
>> > > >> > > >> More engines, more better...
>> > > >> > > >> On 23 Apr 2014 16:32, "Joe Bowser" <bowserj@gmail.com
>> <mailto:
>> > > bowserj@gmail.com>> wrote:
>> > > >> > > >>
>> > > >> > > >>> Hey
>> > > >> > > >>>
>> > > >> > > >>> A Hangout would have to happen on Friday at the earliest.
>> >  It'd
>> > > be
>> > > >> > > good if
>> > > >> > > >>> we could get someone from Mozilla on the hangout as well.  I
>> > > >> > > >>> haven't
>> > > >> > > gotten
>> > > >> > > >>> MozillaView (GeckoView with Cordova methods) fully working
>> > yet.
>> > > >> > > >>> For
>> > > >> > > some
>> > > >> > > >>> reason it's not rendering on the screen.
>> > > >> > > >>>
>> > > >> > > >>> Ideally it'd be cool to have at least two options when this
>> > > >> > > >>> feature
>> > > >> > > finally
>> > > >> > > >>> lands.
>> > > >> > > >>>
>> > > >> > > >>> What do other people think?
>> > > >> > > >>>
>> > > >> > > >>> Joe
>> > > >> > > >>> On 22 Apr 2014 20:06, "Hu, Ningxin" <ningxin.hu@intel.com
>> > > <ma...@intel.com>> wrote:
>> > > >> > > >>>
>> > > >> > > >>> > Joe,
>> > > >> > > >>> >
>> > > >> > > >>> > Thanks for your review and merge the PRs.
>> > > >> > > >>> >
>> > > >> > > >>> > To pluggable webview interest group:
>> > > >> > > >>> > Are we OK to setup a hangout this week for initial
>> > > introduction
>> > > >> > > >>> > and
>> > > >> > > >>> > discussion of next steps?
>> > > >> > > >>> >
>> > > >> > > >>> > Thanks,
>> > > >> > > >>> > -ningxin
>> > > >> > > >>> >
>> > > >> > > >>> > > -----Original Message-----
>> > > >> > > >>> > > From: Hu, Ningxin [mailto:ningxin.hu@intel.com<mailto:
>> > > ningxin.hu@intel.com>]
>> > > >> > > >>> > > Sent: Tuesday, April 22, 2014 4:04 PM
>> > > >> > > >>> > > To: dev@cordova.apache.org<mailto:
>> dev@cordova.apache.org>
>> > > >> > > >>> > > Subject: RE: [Android] Refactoring for different engines
>> > > >> > > >>> > >
>> > > >> > > >>> > > The PoC is great! Quite excited about the direction!
>> > > >> > > >>> > >
>> > > >> > > >>> > > I've sent a PR to update the cordova-crosswalk-engine to
>> > > >> > > >>> > > latest
>> > > >> > > >>> crosswalk
>> > > >> > > >>> > > embedding API. It works with xwalk_core_library at
>> > > 6.35.124.0.
>> > > >> > > >>> > >
>> > > >> > > >>> > > I've also changed the CordovaWebView interface slightly
>> > > >> > > >>> > > (adding
>> > > >> > > >>> > getView() API)
>> > > >> > > >>> > > to allow XWalkCordovaWebView to composite a XWalkView
>> > > instead
>> > > >> > > >>> > > of
>> > > >> > > >>> > extending
>> > > >> > > >>> > > it. It resolves some API naming issues for XWalkView
>> case.
>> > > >> > > >>> > >
>> > > >> > > >>> > > Please review them at:
>> > > >> > > >>> > >
>> > https://github.com/infil00p/cordova-crosswalk-engine/pull/3
>> > > >> > > >>> > > https://github.com/infil00p/cordova-android/pull/2
>> > > >> > > >>> > >
>> > > >> > > >>> > > Thanks,
>> > > >> > > >>> > > -ningxin
>> > > >> > > >>> > >
>> > > >> > > >>> > > > -----Original Message-----
>> > > >> > > >>> > > > From: Joe Bowser [mailto:bowserj@gmail.com<mailto:
>> > > bowserj@gmail.com>]
>> > > >> > > >>> > > > Sent: Friday, April 11, 2014 12:45 AM
>> > > >> > > >>> > > > To: dev
>> > > >> > > >>> > > > Subject: Re: [Android] Refactoring for different
>> engines
>> > > >> > > >>> > > >
>> > > >> > > >>> > > > Yeah, I'd be cool with setting up a hangout.  Everyone
>> > > >> > > >>> > > > should
>> > > >> > > take a
>> > > >> > > >>> > > > look at the PoC, I've basically distilled it down to
>> > four
>> > > or
>> > > >> > five
>> > > >> > > >>> > > > classes so far, but with some work, we may be able to
>> > get
>> > > it
>> > > >> > > down to
>> > > >> > > >>> > > > three.  Due to legacy, we're pretty stuck with the
>> > Android
>> > > >> > > WebView
>> > > >> > > >>> API
>> > > >> > > >>> > calls,
>> > > >> > > >>> > > but these can probably be modified.
>> > > >> > > >>> > > >
>> > > >> > > >>> > > > It'd be good to get Mozilla people on the call as
>> well,
>> > > >> > > >>> > > > since
>> > > >> > > they
>> > > >> > > >>> > > > have their WebView as well.
>> > > >> > > >>> > > >
>> > > >> > > >>> > > > On Thu, Apr 10, 2014 at 9:38 AM, Hu, Ningxin <
>> > > >> > > ningxin.hu@intel.com<ma...@intel.com>>
>> > > >> > > >>> > wrote:
>> > > >> > > >>> > > > > Hangout would be a good idea.
>> > > >> > > >>> > > > >
>> > > >> > > >>> > > > > FYI, I will be off next week. How about the week
>> after
>> > > >> > > >>> > > > > next?
>> > > >> > > If it
>> > > >> > > >>> > > > > works, please
>> > > >> > > >>> > > > feel free to schedule one and count me in.
>> > > >> > > >>> > > > >
>> > > >> > > >>> > > > > Thanks,
>> > > >> > > >>> > > > > -ningxin
>> > > >> > > >>> > > > >
>> > > >> > > >>> > > > >> -----Original Message-----
>> > > >> > > >>> > > > >> From: mmocny@google.com<ma...@google.com>
>> > > [mailto:mmocny@google.com<ma...@google.com>] On
>> > > >> > Behalf
>> > > >> > > Of
>> > > >> > > >>> > > > >> Michal Mocny
>> > > >> > > >>> > > > >> Sent: Tuesday, April 08, 2014 11:39 PM
>> > > >> > > >>> > > > >> To: dev
>> > > >> > > >>> > > > >> Subject: Re: [Android] Refactoring for different
>> > > engines
>> > > >> > > >>> > > > >>
>> > > >> > > >>> > > > >> Would it be alright to set up a Hangout some time
>> to
>> > > >> > introduce
>> > > >> > > >>> > everyone?
>> > > >> > > >>> > > > >>
>> > > >> > > >>> > > > >> Joe has been leading the effort here, but there are
>> > > other
>> > > >> > > cordova
>> > > >> > > >>> > > > >> contributors for whom this is top priority.  It
>> would
>> > > be
>> > > >> > nice
>> > > >> > > if
>> > > >> > > >>> we
>> > > >> > > >>> > > > >> could all meet to say hello and make sure we are
>> all
>> > > >> > > >>> > > > >> going
>> > > >> > in
>> > > >> > > the
>> > > >> > > >>> > > > >> right
>> > > >> > > >>> > > > direction.
>> > > >> > > >>> > > > >>
>> > > >> > > >>> > > > >> Quite exciting!
>> > > >> > > >>> > > > >>
>> > > >> > > >>> > > > >> -Michal
>> > > >> > > >>> > > > >>
>> > > >> > > >>> > > > >>
>> > > >> > > >>> > > > >> On Tue, Apr 8, 2014 at 10:56 AM, Hu, Ningxin <
>> > > >> > > >>> ningxin.hu@intel.com<ma...@intel.com>>
>> > > >> > > >>> > > wrote:
>> > > >> > > >>> > > > >>
>> > > >> > > >>> > > > >> > Joe, thanks for this. I am very excited.
>> > > >> > > >>> > > > >> >
>> > > >> > > >>> > > > >> > FYI. Crosswalk team is working on refactoring the
>> > > >> > > >>> > > > >> > WebView
>> > > >> > > API to
>> > > >> > > >>> > > > >> > support embedding usage better [1]. (Previously
>> the
>> > > >> > > >>> > > > >> > layer
>> > > >> > > API
>> > > >> > > >>> was
>> > > >> > > >>> > > > >> > not exposed as public usage).
>> > > >> > > >>> > > > >> >
>> > > >> > > >>> > > > >> > I would like to review the PoC and work with you
>> to
>> > > get
>> > > >> > > >>> Crosswalk
>> > > >> > > >>> > > > >> > fits into the pluggable WebView architecture.
>> > > >> > > >>> > > > >> >
>> > > >> > > >>> > > > >> > Thanks,
>> > > >> > > >>> > > > >> > -ningxin
>> > > >> > > >>> > > > >> >
>> > > >> > > >>> > > > >> > > -----Original Message-----
>> > > >> > > >>> > > > >> > > From: Joe Bowser [mailto:bowserj@gmail.com
>> > <mailto:
>> > > bowserj@gmail.com>]
>> > > >> > > >>> > > > >> > > Sent: Wednesday, March 19, 2014 7:08 AM
>> > > >> > > >>> > > > >> > > To: dev
>> > > >> > > >>> > > > >> > > Subject: Re: [Android] Refactoring for
>> different
>> > > >> > > >>> > > > >> > > engines
>> > > >> > > >>> > > > >> > >
>> > > >> > > >>> > > > >> > > Hey
>> > > >> > > >>> > > > >> > >
>> > > >> > > >>> > > > >> > > After debugging, I did some minor updates to
>> the
>> > > >> > > >>> > > > >> > > plugin
>> > > >> > > >>> README.
>> > > >> > > >>> > > > >> > > It
>> > > >> > > >>> > > > >> > should be
>> > > >> > > >>> > > > >> > > easier to get this up and running, although
>> > there's
>> > > >> > still
>> > > >> > > the
>> > > >> > > >>> > > > >> > > issue of
>> > > >> > > >>> > > > >> > after-install
>> > > >> > > >>> > > > >> > > hooks and the relative path weirdness with the
>> > > >> > > >>> > > > >> > > Crosswalk
>> > > >> > > >>> > Library itself.
>> > > >> > > >>> > > > >> > >
>> > > >> > > >>> > > > >> > > It still doesn't support the CLI at all, but it
>> > > >> > > >>> > > > >> > > should
>> > > >> > be
>> > > >> > > >>> there
>> > > >> > > >>> > > > >> > > with the
>> > > >> > > >>> > > > >> > old flow.
>> > > >> > > >>> > > > >> > >
>> > > >> > > >>> > > > >> > > On Mon, Mar 17, 2014 at 1:14 PM, Michal Mocny
>> > > >> > > >>> > > > >> > > <mmocny@chromium.org<mailto:
>> mmocny@chromium.org
>> > >>
>> > > >> > > >>> > > > >> > > wrote:
>> > > >> > > >>> > > > >> > > > (Sorry Joe, Googlers are down in California
>> and
>> > > way
>> > > >> > > busy.
>> > > >> > > >>> > > > >> > > > Will be back in a week.  Super excited about
>> > > this,
>> > > >> > > though.)
>> > > >> > > >>> > > > >> > > >
>> > > >> > > >>> > > > >> > > > -Michal
>> > > >> > > >>> > > > >> > > >
>> > > >> > > >>> > > > >> > > >
>> > > >> > > >>> > > > >> > > > On Mon, Mar 17, 2014 at 2:53 PM, Joe Bowser
>> > > >> > > >>> > > > >> > > > <bowserj@gmail.com<mailto:bowserj@gmail.com
>> >>
>> > > >> > > >>> > > > >> wrote:
>> > > >> > > >>> > > > >> > > >
>> > > >> > > >>> > > > >> > > >> Reviving this thread!
>> > > >> > > >>> > > > >> > > >>
>> > > >> > > >>> > > > >> > > >> Can other people look at this, and see
>> if/when
>> > > we
>> > > >> > > should
>> > > >> > > >>> > land this?
>> > > >> > > >>> > > > >> > > >> I know that I have to re-write the tests
>> > still,
>> > > >> > > >>> > > > >> > > >> but I
>> > > >> > > would
>> > > >> > > >>> > > > >> > > >> like some feedback before merging it in.
>> >  Also,
>> > > >> > > >>> > > > >> > > >> it'd
>> > > >> > be
>> > > >> > > >>> > > > >> > > >> super awesome if other people could try and
>> > > make a
>> > > >> > > WebView
>> > > >> > > >>> > > > >> > > >> based on the interfaces and recommend which
>> > > >> > > >>> > > > >> > > >> methods
>> > > >> > > should
>> > > >> > > >>> > > > >> > > >> die.  I want to get this released in the
>> next
>> > > >> > > >>> > > > >> > > >> month
>> > > >> > or
>> > > >> > > so,
>> > > >> > > >>> > > > >> > > >> so any time and feedback would be greatly
>> > > >> > appreciated.
>> > > >> > > >>> > > > >> > > >>
>> > > >> > > >>> > > > >> > > >> Thanks
>> > > >> > > >>> > > > >> > > >>
>> > > >> > > >>> > > > >> > > >> On Thu, Mar 13, 2014 at 3:50 PM, Joe Bowser
>> > > >> > > >>> > > > >> > > >> <bowserj@gmail.com<mailto:bowserj@gmail.com
>> >>
>> > > >> > > >>> > > > >> > wrote:
>> > > >> > > >>> > > > >> > > >> > Hey, I created the following today to
>> track
>> > > >> > > >>> > > > >> > > >> > various
>> > > >> > > >>> > > > >> > > >> > WebView
>> > > >> > > >>> > > > >> > progresses:
>> > > >> > > >>> > > > >> > > >> >
>> > https://issues.apache.org/jira/browse/CB-6246
>> > > >> > > >>> > > > >> > > >> >
>> > > >> > > >>> > > > >> > > >> > I also have this repo created.  The
>> > licensing
>> > > is
>> > > >> > > ugly as
>> > > >> > > >>> > > > >> > > >> > all crap, but it's a Proof-Of-Concept:
>> > > >> > > >>> > > > >> > > >> >
>> > > >> > https://github.com/infil00p/cordova-crosswalk-engine
>> > > >> > > >>> > > > >> > > >> >
>> > > >> > > >>> > > > >> > > >> > If I can get some help getting plugman to
>> > just
>> > > >> > > >>> > > > >> > > >> > load
>> > > >> > > >>> > > > >> > > >> > Crosswalk, it'll
>> > > >> > > >>> > > > >> > > >> look hawt.
>> > > >> > > >>> > > > >> > > >> >
>> > > >> > > >>> > > > >> > > >> > BTW: We should probably get this ready to
>> go
>> > > >> > > >>> > > > >> > > >> > into
>> > > >> > > Android
>> > > >> > > >>> > > > >> > > >> > in the next two months and deprecate the
>> > > >> > setProperty
>> > > >> > > >>> > > > >> > > >> > methods, since all properties should be
>> > > >> > > >>> > > > >> > > >> > preferences
>> > > >> > > in
>> > > >> > > >>> > config.xml
>> > > >> > > >>> > > now.
>> > > >> > > >>> > > > >> > > >> >
>> > > >> > > >>> > > > >> > > >> > On Mon, Mar 10, 2014 at 2:42 PM, Joe
>> Bowser
>> > > >> > > >>> > > > >> > > >> > <bowserj@gmail.com<mailto:
>> bowserj@gmail.com
>> > >>
>> > > >> > > >>> > > > >> > > wrote:
>> > > >> > > >>> > > > >> > > >> >> Perhaps. There would be additional
>> benefits
>> > > to
>> > > >> > this
>> > > >> > > >>> > > > >> > > >> >> approach, namely fixes being added to
>> that
>> > > >> > platform
>> > > >> > > more
>> > > >> > > >>> > > > >> > > >> >> quickly.  I'll probably take a look at
>> that
>> > > >> > > >>> > > > >> > > >> >> once I
>> > > >> > > have
>> > > >> > > >>> > > > >> > > >> >> Crosswalk
>> > > >> > > >>> > > > finalized.
>> > > >> > > >>> > > > >> > > >> >>
>> > > >> > > >>> > > > >> > > >> >> On Mon, Mar 10, 2014 at 9:49 AM, Brian
>> > LeRoux
>> > > >> > > >>> > > > >> > > >> >> <b@...@brian.io>>
>> > > >> > > >>> > > > wrote:
>> > > >> > > >>> > > > >> > > >> >>> this is great stuff
>> > > >> > > >>> > > > >> > > >> >>>
>> > > >> > > >>> > > > >> > > >> >>> do we think it may be possible to bring
>> in
>> > > >> > > >>> > > > >> > > >> >>> amazon
>> > > >> > > >>> fireos
>> > > >> > > >>> > > > >> > > >> >>> stuff
>> > > >> > > >>> > > > >> > > >> eventually
>> > > >> > > >>> > > > >> > > >> >>> too?
>> > > >> > > >>> > > > >> > > >> >>>
>> > > >> > > >>> > > > >> > > >> >>>
>> > > >> > > >>> > > > >> > > >> >>> On Fri, Mar 7, 2014 at 3:22 PM, Joe
>> Bowser
>> > > >> > > >>> > > > >> > > >> >>> <bowserj@gmail.com<mailto:
>> > bowserj@gmail.com
>> > > >>
>> > > >> > > >>> > > > >> > wrote:
>> > > >> > > >>> > > > >> > > >> >>>
>> > > >> > > >>> > > > >> > > >> >>>> BTW: I committed it in my repo, not the
>> > > main
>> > > >> > > Apache
>> > > >> > > >>> one.
>> > > >> > > >>> > > > >> > > >> >>>>
>> > > >> > > >>> > > > >> > > >> >>>> On Fri, Mar 7, 2014 at 3:21 PM, Joe
>> > Bowser
>> > > >> > > >>> > > > >> > > >> >>>> <bowserj@gmail.com<mailto:
>> > > bowserj@gmail.com>>
>> > > >> > > >>> > > > >> > > wrote:
>> > > >> > > >>> > > > >> > > >> >>>> > Hey
>> > > >> > > >>> > > > >> > > >> >>>> >
>> > > >> > > >>> > > > >> > > >> >>>> > I just committed some code based on
>> > their
>> > > >> > > WebView
>> > > >> > > >>> > > > >> > > >> >>>> > modifications that allows you to
>> choose
>> > > >> > > >>> > > > >> > > >> >>>> > your
>> > > >> > > >>> renderer
>> > > >> > > >>> > > > >> > > >> >>>> > in the
>> > > >> > > >>> > > > >> > config file
>> > > >> > > >>> > > > >> > > with this:
>> > > >> > > >>> > > > >> > > >> >>>> >
>> > > >> > > >>> > > > >> > > >> >>>> >     <preference name="webView"
>> > > >> > > >>> > > > >> > > >> >>>> >
>> > > >> > > >>> value="org.apache.cordova.engine.crosswalk.XWalkCordo
>> > > >> > > >>> > > > >> > > >> >>>> > va
>> > > >> > > >>> > > > >> > > >> >>>> > Web
>> > > >> > > >>> > > > >> > > >> >>>> > View
>> > > >> > > >>> > > > >> > > >> >>>> > " />
>> > > >> > > >>> > > > >> > > >> >>>> >
>> > > >> > > >>> > > > >> > > >> >>>> > You currently have to copy over the
>> > *.pak
>> > > >> > > >>> > > > >> > > >> >>>> > file
>> > > >> > > and
>> > > >> > > >>> > > > >> > > >> >>>> > the jsapi from a Crosswalk Example
>> > > project
>> > > >> > > >>> > > > >> > > >> >>>> > to
>> > > >> > > get
>> > > >> > > >>> > > > >> > > >> >>>> > this to work.  The next thing that
>> I'm
>> > > >> > > >>> > > > >> > > >> >>>> > going
>> > > >> > to
>> > > >> > > do
>> > > >> > > >>> is
>> > > >> > > >>> > > > >> > > >> >>>> > figure out how to write this as a
>> > plugin
>> > > >> > > >>> > > > >> > > >> >>>> > and
>> > > >> > > have it
>> > > >> > > >>> > > > >> > > >> >>>> > install on a default
>> > > >> > > >>> > > > project.
>> > > >> > > >>> > > > >> > > >> >>>> > Also, right now the bridge doesn't
>> seem
>> > > to
>> > > >> > > work, and
>> > > >> > > >>> > > > >> > > >> >>>> > I don't know why exactly.  That being
>> > > said,
>> > > >> > the
>> > > >> > > >>> > > > >> > > >> fact
>> > > >> > > >>> > > > >> > > >> >>>> > that I can choose which version of
>> > > >> > > Chrome/Chromium
>> > > >> > > >>> > > > >> > > >> >>>> > I'm running with
>> > > >> > > >>> > > > >> > > >> a
>> > > >> > > >>> > > > >> > > >> >>>> > single XML preference is HUGE.
>> > > >> > > >>> > > > >> > > >> >>>> >
>> > > >> > > >>> > > > >> > > >> >>>> > There's definitely a lot more work
>> that
>> > > >> > > >>> > > > >> > > >> >>>> > needs
>> > > >> > > to be
>> > > >> > > >>> > > > >> > > >> >>>> > done, but as
>> > > >> > > >>> > > > >> > > >> long
>> > > >> > > >>> > > > >> > > >> >>>> > as we have something that we can fit
>> > into
>> > > >> > > >>> > > > >> > > >> >>>> > the
>> > > >> > > >>> > > > >> > > >> >>>> > interface, we should
>> > > >> > > >>> > > > >> > > >> be
>> > > >> > > >>> > > > >> > > >> >>>> > able to put in things like GeckoView
>> or
>> > > >> > > >>> > > > >> > > >> >>>> > other
>> > > >> > > third
>> > > >> > > >>> > > > >> > > >> >>>> > party
>> > > >> > > >>> > > > >> > renderers.
>> > > >> > > >>> > > > >> > > >> >>>> > The nightmare of being stuck with
>> > > bullshit
>> > > >> > > WebView
>> > > >> > > >>> > > > >> > > >> >>>> > bugs may soon be over.
>> > > >> > > >>> > > > >> > > >> >>>> >
>> > > >> > > >>> > > > >> > > >> >>>> > On Wed, Mar 5, 2014 at 8:59 PM,
>> Michal
>> > > >> > > >>> > > > >> > > >> >>>> > Mocny
>> > > >> > > >>> > > > >> > > >> >>>> > <mmocny@chromium.org<mailto:
>> > > mmocny@chromium.org>>
>> > > >> > > >>> > > > >> > > >> >>>> wrote:
>> > > >> > > >>> > > > >> > > >> >>>> >>
>> > > >> > > >>> https://github.com/crosswalk-project/crosswalk-cordo
>> > > >> > > >>> > > > >> > > >> >>>> >> va
>> > > >> > > >>> > > > >> > > >> >>>> >> -an
>> > > >> > > >>> > > > >> > > >> >>>> >> droi
>> > > >> > > >>> > > > >> > > >> >>>> >> d
>> > > >> > > >>> > > > >> > > >> >>>> >>
>> > > >> > > >>> > > > >> > > >> >>>> >> First patch they landed, which
>> claims
>> > to
>> > > >> > > >>> > > > >> > > >> >>>> >> have
>> > > >> > > min
>> > > >> > > >>> > > > >> > > >> >>>> >> viable xwalk
>> > > >> > > >>> > > > >> > > >> webview:
>> > > >> > > >>> > > > >> > > >> >>>> >>
>> > > >> > > >>> > > > >> > > >> >>>>
>> > > >> > > >>> > > > >> > > >>
>> > > >> > > >>>
>> https://github.com/crosswalk-project/crosswalk-cordova-andro
>> > > >> > > >>> > > > >> > > >> id
>> > > >> > > >>> > > > >> > > >> /co
>> > > >> > > >>> > > > >> > > >> mmit
>> > > >> > > >>> > > > >> > > >> /a04dedeb0204e7542d190312c6ae70c795a26e04
>> > > >> > > >>> > > > >> > > >> >>>> >>
>> > > >> > > >>> > > > >> > > >> >>>> >>
>> > > >> > > >>> > > > >> > > >> >>>> >> On Wed, Mar 5, 2014 at 11:37 PM,
>> > Michal
>> > > >> > > >>> > > > >> > > >> >>>> >> Mocny
>> > > >> > > >>> > > > >> > > >> >>>> >> <mmocny@chromium.org<mailto:
>> > > mmocny@chromium.org>
>> > > >> > > >>> > > > >> > > >> >
>> > > >> > > >>> > > > >> > > >> >>>> wrote:
>> > > >> > > >>> > > > >> > > >> >>>> >>
>> > > >> > > >>> > > > >> > > >> >>>> >>> I haven't looked yet, but did you
>> > see:
>> > > >> > > >>> > > > >> > > >> >>>> >>>
>> > > >> > > >>> https://crosswalk-project.org/#wiki/crosswalk-cordo
>> > > >> > > >>> > > > >> > > >> >>>> >>> va
>> > > >> > > >>> > > > >> > > >> >>>> >>> -an
>> > > >> > > >>> > > > >> > > >> >>>> >>> droi
>> > > >> > > >>> > > > >> > > >> >>>> >>> d
>> > > >> > > >>> > > > >> > > >> >>>> >>>
>> > > >> > > >>> > > > >> > > >> >>>> >>> ?
>> > > >> > > >>> > > > >> > > >> >>>> >>>
>> > > >> > > >>> > > > >> > > >> >>>> >>>
>> > > >> > > >>> > > > >> > > >> >>>> >>> On Wed, Mar 5, 2014 at 10:20 PM,
>> > Andrew
>> > > >> > > Grieve <
>> > > >> > > >>> > > > >> > > >> agrieve@chromium.org<mailto:
>> > > agrieve@chromium.org>
>> > > >> > > >>> > > > >> > > >> >>>> >wrote:
>> > > >> > > >>> > > > >> > > >> >>>> >>>
>> > > >> > > >>> > > > >> > > >> >>>> >>>> First - very excited that you're
>> > > working
>> > > >> > > >>> > > > >> > > >> >>>> >>>> on
>> > > >> > > this!
>> > > >> > > >>> > > > >> > > >> >>>> >>>>
>> > > >> > > >>> > > > >> > > >> >>>> >>>> Had a quick look. Not sure there's
>> > > much
>> > > >> > > >>> > > > >> > > >> >>>> >>>> to
>> > > >> > be
>> > > >> > > >>> > gleaned
>> > > >> > > >>> > > yet.
>> > > >> > > >>> > > > >> > > >> >>>> >>>> Once
>> > > >> > > >>> > > > >> > > >> you
>> > > >> > > >>> > > > >> > > >> >>>> start
>> > > >> > > >>> > > > >> > > >> >>>> >>>> in on hooking up x-walk's webview
>> I
>> > > >> > > >>> > > > >> > > >> >>>> >>>> think
>> > > >> > it
>> > > >> > > will
>> > > >> > > >>> > > > >> > > >> >>>> >>>> become more
>> > > >> > > >>> > > > >> > > >> obvious
>> > > >> > > >>> > > > >> > > >> >>>> what
>> > > >> > > >>> > > > >> > > >> >>>> >>>> the interface should look like.
>> > E.g.,
>> > > >> > > >>> > > > >> > > >> >>>> >>>> does
>> > > >> > > x-walk
>> > > >> > > >>> > > > >> > > >> >>>> >>>> even have the
>> > > >> > > >>> > > > >> > > >> >>>> concept of
>> > > >> > > >>> > > > >> > > >> >>>> >>>> ChromeClient vs WebViewClient vs
>> > > >> > > >>> > > > >> > > >> >>>> >>>> WebView?
>> > > >> > > Also
>> > > >> > > >>> > > > >> > > >> >>>> >>>> unsure whether the
>> > > >> > > >>> > > > >> > > >> >>>> class
>> > > >> > > >>> > > > >> > > >> >>>> >>>> should extend android.View as well
>> > as
>> > > >> > > implement
>> > > >> > > >>> > > > >> > > >> >>>> >>>> our
>> > > >> > > >>> > > > >> > interface.
>> > > >> > > >>> > > > >> > > >> E.g.
>> > > >> > > >>> > > > >> > > >> >>>> >>>> alternative is to have a
>> "getView()"
>> > > >> > > >>> > > > >> > > >> >>>> >>>> method
>> > > >> > > on
>> > > >> > > >>> the
>> > > >> > > >>> > > > >> > interface.
>> > > >> > > >>> > > > >> > > >> Might
>> > > >> > > >>> > > > >> > > >> >>>> help
>> > > >> > > >>> > > > >> > > >> >>>> >>>> to
>> > > >> > > >>> > > > >> > > >> >>>> >>>> cut down on file sizes, and API
>> > > surface,
>> > > >> > but
>> > > >> > > >>> > > > >> > > >> >>>> >>>> again, I'm not too
>> > > >> > > >>> > > > >> > > >> sure.
>> > > >> > > >>> > > > >> > > >> >>>> >>>>
>> > > >> > > >>> > > > >> > > >> >>>> >>>> I've been pretty hesitant to touch
>> > > >> > > >>> > > > >> > > >> >>>> >>>> existing
>> > > >> > > >>> > > > >> > > >> >>>> >>>> exposed members
>> > > >> > > >>> > > > >> > > >> (e.g. the
>> > > >> > > >>> > > > >> > > >> >>>> >>>> public fields you were referring
>> to)
>> > > >> > > >>> > > > >> > > >> >>>> >>>> since
>> > > >> > > >>> > > > >> > > >> >>>> >>>> touching anything
>> > > >> > > >>> > > > >> > > >> public
>> > > >> > > >>> > > > >> > > >> >>>> could
>> > > >> > > >>> > > > >> > > >> >>>> >>>> break plugins. That said, maybe
>> now
>> > > is a
>> > > >> > good
>> > > >> > > >>> time
>> > > >> > > >>> > > > >> > > >> >>>> >>>> to @deprecate
>> > > >> > > >>> > > > >> > > >> a
>> > > >> > > >>> > > > >> > > >> >>>> bunch
>> > > >> > > >>> > > > >> > > >> >>>> >>>> of
>> > > >> > > >>> > > > >> > > >> >>>> >>>> them and either replace them with
>> > > >> > > >>> > > > >> > > >> >>>> >>>> getters,
>> > > >> > or
>> > > >> > > >>> just
>> > > >> > > >>> > > > >> > > >> >>>> >>>> declare them
>> > > >> > > >>> > > > >> > > >> to be
>> > > >> > > >>> > > > >> > > >> >>>> not
>> > > >> > > >>> > > > >> > > >> >>>> >>>> exposed to plugins.
>> > > >> > > >>> > > > >> > > >> >>>> >>>>
>> > > >> > > >>> > > > >> > > >> >>>> >>>>
>> > > >> > > >>> > > > >> > > >> >>>> >>>> On Wed, Mar 5, 2014 at 6:57 PM,
>> Joe
>> > > >> > > >>> > > > >> > > >> >>>> >>>> Bowser
>> > > >> > > >>> > > > >> > > >> >>>> >>>> <bowserj@gmail.com<mailto:
>> > > bowserj@gmail.com>>
>> > > >> > > >>> > > > >> > > >> wrote:
>> > > >> > > >>> > > > >> > > >> >>>> >>>>
>> > > >> > > >>> > > > >> > > >> >>>> >>>> > So, after looking at the
>> Crosswalk
>> > > >> > > >>> > > > >> > > >> >>>> >>>> > code
>> > > >> > > again,
>> > > >> > > >>> > > > >> > > >> >>>> >>>> > I've decided to
>> > > >> > > >>> > > > >> > > >> take
>> > > >> > > >>> > > > >> > > >> >>>> a
>> > > >> > > >>> > > > >> > > >> >>>> >>>> > quick stab at making things
>> > > pluggable.
>> > > >> > > >>> > > > >> > > >> >>>> >>>> > I
>> > > >> > > don't
>> > > >> > > >>> > > > >> > > >> >>>> >>>> > have a lot to
>> > > >> > > >>> > > > >> > > >> show
>> > > >> > > >>> > > > >> > > >> >>>> for
>> > > >> > > >>> > > > >> > > >> >>>> >>>> > it, but with the help of Eclipse
>> > > >> > > >>> > > > >> > > >> >>>> >>>> > (which
>> > > >> > is
>> > > >> > > why
>> > > >> > > >>> > > > >> > > >> >>>> >>>> > the generated interfaces look so
>> > > >> > > >>> > > > >> > > >> >>>> >>>> > screwed
>> > > >> > > up), I
>> > > >> > > >>> > > > >> > > >> >>>> >>>> > managed to create some
>> > > >> > > >>> > > > >> > > >> interfaces
>> > > >> > > >>> > > > >> > > >> >>>> so
>> > > >> > > >>> > > > >> > > >> >>>> >>>> > we can start shoehorning in
>> other
>> > > >> > > >>> > > > >> > > >> >>>> >>>> > browser
>> > > >> > > >>> > renderers.
>> > > >> > > >>> > > > >> > > >> >>>> >>>> >
>> > > >> > > >>> > > > >> > > >> >>>> >>>> >
>> > > >> > > >>> > > > >> > > >>
>> > > >> > > >>>
>> https://github.com/infil00p/cordova-android/tree/pluggable_w
>> > > >> > > >>> > > > >> > > >> eb
>> > > >> > > >>> > > > >> > > >> vie
>> > > >> > > >>> > > > >> > > >> w
>> > > >> > > >>> > > > >> > > >> >>>> >>>> >
>> > > >> > > >>> > > > >> > > >> >>>> >>>> > I'm going to probably start with
>> > > >> > Crosswalk,
>> > > >> > > >>> > > > >> > > >> >>>> >>>> > because it's
>> > > >> > > >>> > > > >> > > >> probably
>> > > >> > > >>> > > > >> > > >> >>>> the
>> > > >> > > >>> > > > >> > > >> >>>> >>>> > most mature primary candidate in
>> > the
>> > > >> > > Android
>> > > >> > > >>> > > > >> > > >> >>>> >>>> > Third-Party
>> > > >> > > >>> > > > >> > > >> WebView
>> > > >> > > >>> > > > >> > > >> >>>> >>>> > thing, and I'm pretty sure the
>> > > >> > > >>> > > > >> > > >> >>>> >>>> > GeckoView
>> > > >> > > will
>> > > >> > > >>> be
>> > > >> > > >>> > > > >> > > >> >>>> >>>> > happening
>> > > >> > > >>> > > > >> > > >> shortly
>> > > >> > > >>> > > > >> > > >> >>>> >>>> > after.
>> > > >> > > >>> > > > >> > > >> >>>> >>>> >
>> > > >> > > >>> > > > >> > > >> >>>> >>>> > I don't know how this would work
>> > > >> > > >>> > > > >> > > >> >>>> >>>> > w.r.t.
>> > > >> > > the CLI
>> > > >> > > >>> > > > >> > > >> >>>> >>>> > or our
>> > > >> > > >>> > > > >> > > >> workflow at
>> > > >> > > >>> > > > >> > > >> >>>> >>>> > all, but at the moment, I really
>> > > just
>> > > >> > want
>> > > >> > > to
>> > > >> > > >>> at
>> > > >> > > >>> > > > >> > > >> >>>> >>>> > least start
>> > > >> > > >>> > > > >> > > >> to have
>> > > >> > > >>> > > > >> > > >> >>>> >>>> > some headway towards 4.x and
>> > > PhoneGap
>> > > >> > day.
>> > > >> > > >>> > > > >> > > >> >>>> >>>> >
>> > > >> > > >>> > > > >> > > >> >>>> >>>> > What do people think of this so
>> > far?
>> > > >> > > >>> > > > >> > > >> >>>> >>>> > I'm
>> > > >> > > going
>> > > >> > > >>> > > > >> > > >> >>>> >>>> > to try to clean
>> > > >> > > >>> > > > >> > > >> >>>> things
>> > > >> > > >>> > > > >> > > >> >>>> >>>> > up a bit, since we've definitely
>> > > done
>> > > >> > > >>> > > > >> > > >> >>>> >>>> > a
>> > > >> > > lot of
>> > > >> > > >>> > > > >> > > >> >>>> >>>> > things that
>> > > >> > > >>> > > > >> > > >> would
>> > > >> > > >>> > > > >> > > >> >>>> make
>> > > >> > > >>> > > > >> > > >> >>>> >>>> > first year CS profs freak the
>> hell
>> > > out
>> > > >> > > (i.e.
>> > > >> > > >>> > > > >> > > >> >>>> >>>> > public members in
>> > > >> > > >>> > > > >> > > >> >>>> public
>> > > >> > > >>> > > > >> > > >> >>>> >>>> > objects w.r.t. PluginManager).
>> > > >> > > >>> > > > >> > > >> >>>> >>>> >
>> > > >> > > >>> > > > >> > > >> >>>> >>>> > Thoughts?
>> > > >> > > >>> > > > >> > > >> >>>> >>>> >
>> > > >> > > >>> > > > >> > > >> >>>> >>>> > Joe
>> > > >> > > >>> > > > >> > > >> >>>> >>>> >
>> > > >> > > >>> > > > >> > > >> >>>> >>>>
>> > > >> > > >>> > > > >> > > >> >>>> >>>
>> > > >> > > >>> > > > >> > > >> >>>> >>>
>> > > >> > > >>> > > > >> > > >> >>>>
>> > > >> > > >>> > > > >> > > >>
>> > > >> > > >>> > > > >> >
>> > > >> > > >>> >
>> > > >> > > >>>
>> > > >> > >
>> > > >> >
>> > > >
>> > > >
>> > >
>> > >
>> >
>>

Re: [Android] Refactoring for different engines

[Michal Mocny <mm...@chromium.org>]

(Yeah 7pm Friday is more naughty than 4am for those of us with families.)

I think the original intent was just supposed to be a meet & greet right?
 Lets just do it asap and consider formal scheduling with ample planning
only if there are technical topics to discuss.

It would be nice, though, if Ian could make it, given his recent work on
this.

-Michal


On Wed, Apr 23, 2014 at 10:34 PM, Victor Sosa <so...@gmail.com>wrote:

> 4PM PST? That's 6 CST or 7 EST, me thinks. Seems to work for many of us
> On Apr 23, 2014 8:49 PM, "Brian LeRoux" <b...@brian.io> wrote:
>
> > 4pm works for me…
> >
> >
> > On Wed, Apr 23, 2014 at 6:19 PM, Hu, Ningxin <ni...@intel.com>
> wrote:
> >
> > > I am in China. 1:00 PM PST means 4:00 AM here :o.
> > > Could you please schedule it a little bit later, say 4:00 or 5:00 PM
> PST?
> > > It will be highly appreciated.
> > >
> > > Thanks,
> > > -ningxin
> > >
> > > From: brian.leroux@gmail.com [mailto:brian.leroux@gmail.com] On Behalf
> > Of
> > > Brian LeRoux
> > > Sent: Thursday, April 24, 2014 6:10 AM
> > > To: Joe Bowser
> > > Cc: dev@cordova.apache.org; Hu, Ningxin
> > > Subject: Re: [Android] Refactoring for different engines
> > >
> > > How does 1:00PST on Friday work for a hangout for everyone?
> > >
> > > On Wed, Apr 23, 2014 at 2:36 PM, Joe Bowser <bowserj@gmail.com<mailto:
> > > bowserj@gmail.com>> wrote:
> > > BTW: Here's my PoC for Mozilla so far.  It's very broken!
> > >
> > > https://github.com/infil00p/MozillaView
> > >
> > >
> > >
> > > On Wed, Apr 23, 2014 at 10:50 AM, Brian LeRoux <b@brian.io<mailto:
> > > b@brian.io>> wrote:
> > > > So I found a Moz hacker whom can help. what time on Fri do you guys
> > want
> > > to
> > > > do this?
> > > >
> > > >
> > > > On Wed, Apr 23, 2014 at 10:31 AM, Ian Clelland <
> iclelland@chromium.org
> > > <ma...@chromium.org>>
> > > > wrote:
> > > >>
> > > >> I've managed to get this up and running now -- great work on this,
> > Joe!
> > > >>
> > > >> Mobilespec runs on my N4, with 10 failing tests: 3 in contacts; 7 in
> > > >> file-transfer. Otherwise, things seem to be working pretty well.
> > > >>
> > > >> I used a new build of Crosswalk, and found that the embedding API
> has
> > > >> changed since the weekend (when Ningxin's patches applied). I've
> > issued
> > > a
> > > >> pull request at
> > > >> https://github.com/infil00p/cordova-crosswalk-engine/pull/5for it
> --
> > > >>
> > > >> I'm not sure if there's a way to keep compatibility with last
> > > >> week's Crosswalk, or if we'd even want to. (Ningxin, if you could
> > take a
> > > >> look at that PR and see if it makes sense, I'd appreciate it)
> > > >>
> > > >> Joe, I also had to patch the default constructor for
> > > XWalkCordovaWebView;
> > > >> it wasn't creating its own client objects, so it got the default
> ones,
> > > and
> > > >> most of the tests were failing because some component of the bridge
> > > wan't
> > > >> working.
> https://github.com/infil00p/cordova-crosswalk-engine/pull/4is
> > > >> out
> > > >> for that.
> > > >>
> > > >> Count me in for the hangout -- this is exciting stuff
> > > >>
> > > >> Ian
> > > >>
> > > >>
> > > >> On Wed, Apr 23, 2014 at 10:26 AM, Brian LeRoux <b@brian.io<mailto:
> > > b@brian.io>> wrote:
> > > >>
> > > >> > Yup I'll track em down
> > > >> > On Apr 23, 2014 7:17 AM, "Andrew Grieve" <agrieve@chromium.org
> > > <ma...@chromium.org>> wrote:
> > > >> >
> > > >> > > Does anyone have a contact at moz that we could invite?
> > > >> > >
> > > >> > > On Wed, Apr 23, 2014 at 10:09 AM, Andrew Grieve <
> > > agrieve@chromium.org<ma...@chromium.org>>
> > > >> > > wrote:
> > > >> > > > Depends on their interest level I think. Faster we can get
> this
> > > out
> > > >> > > > the door the better. If we need to delay for geckoview, then I
> > > don't
> > > >> > > > think we should gate on it, just release it after.
> > > >> > > >
> > > >> > > > On Wed, Apr 23, 2014 at 3:01 AM, Tommy Williams <
> > > tommy@devgeeks.org<ma...@devgeeks.org>>
> > > >> > > wrote:
> > > >> > > >> More engines, more better...
> > > >> > > >> On 23 Apr 2014 16:32, "Joe Bowser" <bowserj@gmail.com
> <mailto:
> > > bowserj@gmail.com>> wrote:
> > > >> > > >>
> > > >> > > >>> Hey
> > > >> > > >>>
> > > >> > > >>> A Hangout would have to happen on Friday at the earliest.
> >  It'd
> > > be
> > > >> > > good if
> > > >> > > >>> we could get someone from Mozilla on the hangout as well.  I
> > > >> > > >>> haven't
> > > >> > > gotten
> > > >> > > >>> MozillaView (GeckoView with Cordova methods) fully working
> > yet.
> > > >> > > >>> For
> > > >> > > some
> > > >> > > >>> reason it's not rendering on the screen.
> > > >> > > >>>
> > > >> > > >>> Ideally it'd be cool to have at least two options when this
> > > >> > > >>> feature
> > > >> > > finally
> > > >> > > >>> lands.
> > > >> > > >>>
> > > >> > > >>> What do other people think?
> > > >> > > >>>
> > > >> > > >>> Joe
> > > >> > > >>> On 22 Apr 2014 20:06, "Hu, Ningxin" <ningxin.hu@intel.com
> > > <ma...@intel.com>> wrote:
> > > >> > > >>>
> > > >> > > >>> > Joe,
> > > >> > > >>> >
> > > >> > > >>> > Thanks for your review and merge the PRs.
> > > >> > > >>> >
> > > >> > > >>> > To pluggable webview interest group:
> > > >> > > >>> > Are we OK to setup a hangout this week for initial
> > > introduction
> > > >> > > >>> > and
> > > >> > > >>> > discussion of next steps?
> > > >> > > >>> >
> > > >> > > >>> > Thanks,
> > > >> > > >>> > -ningxin
> > > >> > > >>> >
> > > >> > > >>> > > -----Original Message-----
> > > >> > > >>> > > From: Hu, Ningxin [mailto:ningxin.hu@intel.com<mailto:
> > > ningxin.hu@intel.com>]
> > > >> > > >>> > > Sent: Tuesday, April 22, 2014 4:04 PM
> > > >> > > >>> > > To: dev@cordova.apache.org<mailto:
> dev@cordova.apache.org>
> > > >> > > >>> > > Subject: RE: [Android] Refactoring for different engines
> > > >> > > >>> > >
> > > >> > > >>> > > The PoC is great! Quite excited about the direction!
> > > >> > > >>> > >
> > > >> > > >>> > > I've sent a PR to update the cordova-crosswalk-engine to
> > > >> > > >>> > > latest
> > > >> > > >>> crosswalk
> > > >> > > >>> > > embedding API. It works with xwalk_core_library at
> > > 6.35.124.0.
> > > >> > > >>> > >
> > > >> > > >>> > > I've also changed the CordovaWebView interface slightly
> > > >> > > >>> > > (adding
> > > >> > > >>> > getView() API)
> > > >> > > >>> > > to allow XWalkCordovaWebView to composite a XWalkView
> > > instead
> > > >> > > >>> > > of
> > > >> > > >>> > extending
> > > >> > > >>> > > it. It resolves some API naming issues for XWalkView
> case.
> > > >> > > >>> > >
> > > >> > > >>> > > Please review them at:
> > > >> > > >>> > >
> > https://github.com/infil00p/cordova-crosswalk-engine/pull/3
> > > >> > > >>> > > https://github.com/infil00p/cordova-android/pull/2
> > > >> > > >>> > >
> > > >> > > >>> > > Thanks,
> > > >> > > >>> > > -ningxin
> > > >> > > >>> > >
> > > >> > > >>> > > > -----Original Message-----
> > > >> > > >>> > > > From: Joe Bowser [mailto:bowserj@gmail.com<mailto:
> > > bowserj@gmail.com>]
> > > >> > > >>> > > > Sent: Friday, April 11, 2014 12:45 AM
> > > >> > > >>> > > > To: dev
> > > >> > > >>> > > > Subject: Re: [Android] Refactoring for different
> engines
> > > >> > > >>> > > >
> > > >> > > >>> > > > Yeah, I'd be cool with setting up a hangout.  Everyone
> > > >> > > >>> > > > should
> > > >> > > take a
> > > >> > > >>> > > > look at the PoC, I've basically distilled it down to
> > four
> > > or
> > > >> > five
> > > >> > > >>> > > > classes so far, but with some work, we may be able to
> > get
> > > it
> > > >> > > down to
> > > >> > > >>> > > > three.  Due to legacy, we're pretty stuck with the
> > Android
> > > >> > > WebView
> > > >> > > >>> API
> > > >> > > >>> > calls,
> > > >> > > >>> > > but these can probably be modified.
> > > >> > > >>> > > >
> > > >> > > >>> > > > It'd be good to get Mozilla people on the call as
> well,
> > > >> > > >>> > > > since
> > > >> > > they
> > > >> > > >>> > > > have their WebView as well.
> > > >> > > >>> > > >
> > > >> > > >>> > > > On Thu, Apr 10, 2014 at 9:38 AM, Hu, Ningxin <
> > > >> > > ningxin.hu@intel.com<ma...@intel.com>>
> > > >> > > >>> > wrote:
> > > >> > > >>> > > > > Hangout would be a good idea.
> > > >> > > >>> > > > >
> > > >> > > >>> > > > > FYI, I will be off next week. How about the week
> after
> > > >> > > >>> > > > > next?
> > > >> > > If it
> > > >> > > >>> > > > > works, please
> > > >> > > >>> > > > feel free to schedule one and count me in.
> > > >> > > >>> > > > >
> > > >> > > >>> > > > > Thanks,
> > > >> > > >>> > > > > -ningxin
> > > >> > > >>> > > > >
> > > >> > > >>> > > > >> -----Original Message-----
> > > >> > > >>> > > > >> From: mmocny@google.com<ma...@google.com>
> > > [mailto:mmocny@google.com<ma...@google.com>] On
> > > >> > Behalf
> > > >> > > Of
> > > >> > > >>> > > > >> Michal Mocny
> > > >> > > >>> > > > >> Sent: Tuesday, April 08, 2014 11:39 PM
> > > >> > > >>> > > > >> To: dev
> > > >> > > >>> > > > >> Subject: Re: [Android] Refactoring for different
> > > engines
> > > >> > > >>> > > > >>
> > > >> > > >>> > > > >> Would it be alright to set up a Hangout some time
> to
> > > >> > introduce
> > > >> > > >>> > everyone?
> > > >> > > >>> > > > >>
> > > >> > > >>> > > > >> Joe has been leading the effort here, but there are
> > > other
> > > >> > > cordova
> > > >> > > >>> > > > >> contributors for whom this is top priority.  It
> would
> > > be
> > > >> > nice
> > > >> > > if
> > > >> > > >>> we
> > > >> > > >>> > > > >> could all meet to say hello and make sure we are
> all
> > > >> > > >>> > > > >> going
> > > >> > in
> > > >> > > the
> > > >> > > >>> > > > >> right
> > > >> > > >>> > > > direction.
> > > >> > > >>> > > > >>
> > > >> > > >>> > > > >> Quite exciting!
> > > >> > > >>> > > > >>
> > > >> > > >>> > > > >> -Michal
> > > >> > > >>> > > > >>
> > > >> > > >>> > > > >>
> > > >> > > >>> > > > >> On Tue, Apr 8, 2014 at 10:56 AM, Hu, Ningxin <
> > > >> > > >>> ningxin.hu@intel.com<ma...@intel.com>>
> > > >> > > >>> > > wrote:
> > > >> > > >>> > > > >>
> > > >> > > >>> > > > >> > Joe, thanks for this. I am very excited.
> > > >> > > >>> > > > >> >
> > > >> > > >>> > > > >> > FYI. Crosswalk team is working on refactoring the
> > > >> > > >>> > > > >> > WebView
> > > >> > > API to
> > > >> > > >>> > > > >> > support embedding usage better [1]. (Previously
> the
> > > >> > > >>> > > > >> > layer
> > > >> > > API
> > > >> > > >>> was
> > > >> > > >>> > > > >> > not exposed as public usage).
> > > >> > > >>> > > > >> >
> > > >> > > >>> > > > >> > I would like to review the PoC and work with you
> to
> > > get
> > > >> > > >>> Crosswalk
> > > >> > > >>> > > > >> > fits into the pluggable WebView architecture.
> > > >> > > >>> > > > >> >
> > > >> > > >>> > > > >> > Thanks,
> > > >> > > >>> > > > >> > -ningxin
> > > >> > > >>> > > > >> >
> > > >> > > >>> > > > >> > > -----Original Message-----
> > > >> > > >>> > > > >> > > From: Joe Bowser [mailto:bowserj@gmail.com
> > <mailto:
> > > bowserj@gmail.com>]
> > > >> > > >>> > > > >> > > Sent: Wednesday, March 19, 2014 7:08 AM
> > > >> > > >>> > > > >> > > To: dev
> > > >> > > >>> > > > >> > > Subject: Re: [Android] Refactoring for
> different
> > > >> > > >>> > > > >> > > engines
> > > >> > > >>> > > > >> > >
> > > >> > > >>> > > > >> > > Hey
> > > >> > > >>> > > > >> > >
> > > >> > > >>> > > > >> > > After debugging, I did some minor updates to
> the
> > > >> > > >>> > > > >> > > plugin
> > > >> > > >>> README.
> > > >> > > >>> > > > >> > > It
> > > >> > > >>> > > > >> > should be
> > > >> > > >>> > > > >> > > easier to get this up and running, although
> > there's
> > > >> > still
> > > >> > > the
> > > >> > > >>> > > > >> > > issue of
> > > >> > > >>> > > > >> > after-install
> > > >> > > >>> > > > >> > > hooks and the relative path weirdness with the
> > > >> > > >>> > > > >> > > Crosswalk
> > > >> > > >>> > Library itself.
> > > >> > > >>> > > > >> > >
> > > >> > > >>> > > > >> > > It still doesn't support the CLI at all, but it
> > > >> > > >>> > > > >> > > should
> > > >> > be
> > > >> > > >>> there
> > > >> > > >>> > > > >> > > with the
> > > >> > > >>> > > > >> > old flow.
> > > >> > > >>> > > > >> > >
> > > >> > > >>> > > > >> > > On Mon, Mar 17, 2014 at 1:14 PM, Michal Mocny
> > > >> > > >>> > > > >> > > <mmocny@chromium.org<mailto:
> mmocny@chromium.org
> > >>
> > > >> > > >>> > > > >> > > wrote:
> > > >> > > >>> > > > >> > > > (Sorry Joe, Googlers are down in California
> and
> > > way
> > > >> > > busy.
> > > >> > > >>> > > > >> > > > Will be back in a week.  Super excited about
> > > this,
> > > >> > > though.)
> > > >> > > >>> > > > >> > > >
> > > >> > > >>> > > > >> > > > -Michal
> > > >> > > >>> > > > >> > > >
> > > >> > > >>> > > > >> > > >
> > > >> > > >>> > > > >> > > > On Mon, Mar 17, 2014 at 2:53 PM, Joe Bowser
> > > >> > > >>> > > > >> > > > <bowserj@gmail.com<mailto:bowserj@gmail.com
> >>
> > > >> > > >>> > > > >> wrote:
> > > >> > > >>> > > > >> > > >
> > > >> > > >>> > > > >> > > >> Reviving this thread!
> > > >> > > >>> > > > >> > > >>
> > > >> > > >>> > > > >> > > >> Can other people look at this, and see
> if/when
> > > we
> > > >> > > should
> > > >> > > >>> > land this?
> > > >> > > >>> > > > >> > > >> I know that I have to re-write the tests
> > still,
> > > >> > > >>> > > > >> > > >> but I
> > > >> > > would
> > > >> > > >>> > > > >> > > >> like some feedback before merging it in.
> >  Also,
> > > >> > > >>> > > > >> > > >> it'd
> > > >> > be
> > > >> > > >>> > > > >> > > >> super awesome if other people could try and
> > > make a
> > > >> > > WebView
> > > >> > > >>> > > > >> > > >> based on the interfaces and recommend which
> > > >> > > >>> > > > >> > > >> methods
> > > >> > > should
> > > >> > > >>> > > > >> > > >> die.  I want to get this released in the
> next
> > > >> > > >>> > > > >> > > >> month
> > > >> > or
> > > >> > > so,
> > > >> > > >>> > > > >> > > >> so any time and feedback would be greatly
> > > >> > appreciated.
> > > >> > > >>> > > > >> > > >>
> > > >> > > >>> > > > >> > > >> Thanks
> > > >> > > >>> > > > >> > > >>
> > > >> > > >>> > > > >> > > >> On Thu, Mar 13, 2014 at 3:50 PM, Joe Bowser
> > > >> > > >>> > > > >> > > >> <bowserj@gmail.com<mailto:bowserj@gmail.com
> >>
> > > >> > > >>> > > > >> > wrote:
> > > >> > > >>> > > > >> > > >> > Hey, I created the following today to
> track
> > > >> > > >>> > > > >> > > >> > various
> > > >> > > >>> > > > >> > > >> > WebView
> > > >> > > >>> > > > >> > progresses:
> > > >> > > >>> > > > >> > > >> >
> > https://issues.apache.org/jira/browse/CB-6246
> > > >> > > >>> > > > >> > > >> >
> > > >> > > >>> > > > >> > > >> > I also have this repo created.  The
> > licensing
> > > is
> > > >> > > ugly as
> > > >> > > >>> > > > >> > > >> > all crap, but it's a Proof-Of-Concept:
> > > >> > > >>> > > > >> > > >> >
> > > >> > https://github.com/infil00p/cordova-crosswalk-engine
> > > >> > > >>> > > > >> > > >> >
> > > >> > > >>> > > > >> > > >> > If I can get some help getting plugman to
> > just
> > > >> > > >>> > > > >> > > >> > load
> > > >> > > >>> > > > >> > > >> > Crosswalk, it'll
> > > >> > > >>> > > > >> > > >> look hawt.
> > > >> > > >>> > > > >> > > >> >
> > > >> > > >>> > > > >> > > >> > BTW: We should probably get this ready to
> go
> > > >> > > >>> > > > >> > > >> > into
> > > >> > > Android
> > > >> > > >>> > > > >> > > >> > in the next two months and deprecate the
> > > >> > setProperty
> > > >> > > >>> > > > >> > > >> > methods, since all properties should be
> > > >> > > >>> > > > >> > > >> > preferences
> > > >> > > in
> > > >> > > >>> > config.xml
> > > >> > > >>> > > now.
> > > >> > > >>> > > > >> > > >> >
> > > >> > > >>> > > > >> > > >> > On Mon, Mar 10, 2014 at 2:42 PM, Joe
> Bowser
> > > >> > > >>> > > > >> > > >> > <bowserj@gmail.com<mailto:
> bowserj@gmail.com
> > >>
> > > >> > > >>> > > > >> > > wrote:
> > > >> > > >>> > > > >> > > >> >> Perhaps. There would be additional
> benefits
> > > to
> > > >> > this
> > > >> > > >>> > > > >> > > >> >> approach, namely fixes being added to
> that
> > > >> > platform
> > > >> > > more
> > > >> > > >>> > > > >> > > >> >> quickly.  I'll probably take a look at
> that
> > > >> > > >>> > > > >> > > >> >> once I
> > > >> > > have
> > > >> > > >>> > > > >> > > >> >> Crosswalk
> > > >> > > >>> > > > finalized.
> > > >> > > >>> > > > >> > > >> >>
> > > >> > > >>> > > > >> > > >> >> On Mon, Mar 10, 2014 at 9:49 AM, Brian
> > LeRoux
> > > >> > > >>> > > > >> > > >> >> <b@...@brian.io>>
> > > >> > > >>> > > > wrote:
> > > >> > > >>> > > > >> > > >> >>> this is great stuff
> > > >> > > >>> > > > >> > > >> >>>
> > > >> > > >>> > > > >> > > >> >>> do we think it may be possible to bring
> in
> > > >> > > >>> > > > >> > > >> >>> amazon
> > > >> > > >>> fireos
> > > >> > > >>> > > > >> > > >> >>> stuff
> > > >> > > >>> > > > >> > > >> eventually
> > > >> > > >>> > > > >> > > >> >>> too?
> > > >> > > >>> > > > >> > > >> >>>
> > > >> > > >>> > > > >> > > >> >>>
> > > >> > > >>> > > > >> > > >> >>> On Fri, Mar 7, 2014 at 3:22 PM, Joe
> Bowser
> > > >> > > >>> > > > >> > > >> >>> <bowserj@gmail.com<mailto:
> > bowserj@gmail.com
> > > >>
> > > >> > > >>> > > > >> > wrote:
> > > >> > > >>> > > > >> > > >> >>>
> > > >> > > >>> > > > >> > > >> >>>> BTW: I committed it in my repo, not the
> > > main
> > > >> > > Apache
> > > >> > > >>> one.
> > > >> > > >>> > > > >> > > >> >>>>
> > > >> > > >>> > > > >> > > >> >>>> On Fri, Mar 7, 2014 at 3:21 PM, Joe
> > Bowser
> > > >> > > >>> > > > >> > > >> >>>> <bowserj@gmail.com<mailto:
> > > bowserj@gmail.com>>
> > > >> > > >>> > > > >> > > wrote:
> > > >> > > >>> > > > >> > > >> >>>> > Hey
> > > >> > > >>> > > > >> > > >> >>>> >
> > > >> > > >>> > > > >> > > >> >>>> > I just committed some code based on
> > their
> > > >> > > WebView
> > > >> > > >>> > > > >> > > >> >>>> > modifications that allows you to
> choose
> > > >> > > >>> > > > >> > > >> >>>> > your
> > > >> > > >>> renderer
> > > >> > > >>> > > > >> > > >> >>>> > in the
> > > >> > > >>> > > > >> > config file
> > > >> > > >>> > > > >> > > with this:
> > > >> > > >>> > > > >> > > >> >>>> >
> > > >> > > >>> > > > >> > > >> >>>> >     <preference name="webView"
> > > >> > > >>> > > > >> > > >> >>>> >
> > > >> > > >>> value="org.apache.cordova.engine.crosswalk.XWalkCordo
> > > >> > > >>> > > > >> > > >> >>>> > va
> > > >> > > >>> > > > >> > > >> >>>> > Web
> > > >> > > >>> > > > >> > > >> >>>> > View
> > > >> > > >>> > > > >> > > >> >>>> > " />
> > > >> > > >>> > > > >> > > >> >>>> >
> > > >> > > >>> > > > >> > > >> >>>> > You currently have to copy over the
> > *.pak
> > > >> > > >>> > > > >> > > >> >>>> > file
> > > >> > > and
> > > >> > > >>> > > > >> > > >> >>>> > the jsapi from a Crosswalk Example
> > > project
> > > >> > > >>> > > > >> > > >> >>>> > to
> > > >> > > get
> > > >> > > >>> > > > >> > > >> >>>> > this to work.  The next thing that
> I'm
> > > >> > > >>> > > > >> > > >> >>>> > going
> > > >> > to
> > > >> > > do
> > > >> > > >>> is
> > > >> > > >>> > > > >> > > >> >>>> > figure out how to write this as a
> > plugin
> > > >> > > >>> > > > >> > > >> >>>> > and
> > > >> > > have it
> > > >> > > >>> > > > >> > > >> >>>> > install on a default
> > > >> > > >>> > > > project.
> > > >> > > >>> > > > >> > > >> >>>> > Also, right now the bridge doesn't
> seem
> > > to
> > > >> > > work, and
> > > >> > > >>> > > > >> > > >> >>>> > I don't know why exactly.  That being
> > > said,
> > > >> > the
> > > >> > > >>> > > > >> > > >> fact
> > > >> > > >>> > > > >> > > >> >>>> > that I can choose which version of
> > > >> > > Chrome/Chromium
> > > >> > > >>> > > > >> > > >> >>>> > I'm running with
> > > >> > > >>> > > > >> > > >> a
> > > >> > > >>> > > > >> > > >> >>>> > single XML preference is HUGE.
> > > >> > > >>> > > > >> > > >> >>>> >
> > > >> > > >>> > > > >> > > >> >>>> > There's definitely a lot more work
> that
> > > >> > > >>> > > > >> > > >> >>>> > needs
> > > >> > > to be
> > > >> > > >>> > > > >> > > >> >>>> > done, but as
> > > >> > > >>> > > > >> > > >> long
> > > >> > > >>> > > > >> > > >> >>>> > as we have something that we can fit
> > into
> > > >> > > >>> > > > >> > > >> >>>> > the
> > > >> > > >>> > > > >> > > >> >>>> > interface, we should
> > > >> > > >>> > > > >> > > >> be
> > > >> > > >>> > > > >> > > >> >>>> > able to put in things like GeckoView
> or
> > > >> > > >>> > > > >> > > >> >>>> > other
> > > >> > > third
> > > >> > > >>> > > > >> > > >> >>>> > party
> > > >> > > >>> > > > >> > renderers.
> > > >> > > >>> > > > >> > > >> >>>> > The nightmare of being stuck with
> > > bullshit
> > > >> > > WebView
> > > >> > > >>> > > > >> > > >> >>>> > bugs may soon be over.
> > > >> > > >>> > > > >> > > >> >>>> >
> > > >> > > >>> > > > >> > > >> >>>> > On Wed, Mar 5, 2014 at 8:59 PM,
> Michal
> > > >> > > >>> > > > >> > > >> >>>> > Mocny
> > > >> > > >>> > > > >> > > >> >>>> > <mmocny@chromium.org<mailto:
> > > mmocny@chromium.org>>
> > > >> > > >>> > > > >> > > >> >>>> wrote:
> > > >> > > >>> > > > >> > > >> >>>> >>
> > > >> > > >>> https://github.com/crosswalk-project/crosswalk-cordo
> > > >> > > >>> > > > >> > > >> >>>> >> va
> > > >> > > >>> > > > >> > > >> >>>> >> -an
> > > >> > > >>> > > > >> > > >> >>>> >> droi
> > > >> > > >>> > > > >> > > >> >>>> >> d
> > > >> > > >>> > > > >> > > >> >>>> >>
> > > >> > > >>> > > > >> > > >> >>>> >> First patch they landed, which
> claims
> > to
> > > >> > > >>> > > > >> > > >> >>>> >> have
> > > >> > > min
> > > >> > > >>> > > > >> > > >> >>>> >> viable xwalk
> > > >> > > >>> > > > >> > > >> webview:
> > > >> > > >>> > > > >> > > >> >>>> >>
> > > >> > > >>> > > > >> > > >> >>>>
> > > >> > > >>> > > > >> > > >>
> > > >> > > >>>
> https://github.com/crosswalk-project/crosswalk-cordova-andro
> > > >> > > >>> > > > >> > > >> id
> > > >> > > >>> > > > >> > > >> /co
> > > >> > > >>> > > > >> > > >> mmit
> > > >> > > >>> > > > >> > > >> /a04dedeb0204e7542d190312c6ae70c795a26e04
> > > >> > > >>> > > > >> > > >> >>>> >>
> > > >> > > >>> > > > >> > > >> >>>> >>
> > > >> > > >>> > > > >> > > >> >>>> >> On Wed, Mar 5, 2014 at 11:37 PM,
> > Michal
> > > >> > > >>> > > > >> > > >> >>>> >> Mocny
> > > >> > > >>> > > > >> > > >> >>>> >> <mmocny@chromium.org<mailto:
> > > mmocny@chromium.org>
> > > >> > > >>> > > > >> > > >> >
> > > >> > > >>> > > > >> > > >> >>>> wrote:
> > > >> > > >>> > > > >> > > >> >>>> >>
> > > >> > > >>> > > > >> > > >> >>>> >>> I haven't looked yet, but did you
> > see:
> > > >> > > >>> > > > >> > > >> >>>> >>>
> > > >> > > >>> https://crosswalk-project.org/#wiki/crosswalk-cordo
> > > >> > > >>> > > > >> > > >> >>>> >>> va
> > > >> > > >>> > > > >> > > >> >>>> >>> -an
> > > >> > > >>> > > > >> > > >> >>>> >>> droi
> > > >> > > >>> > > > >> > > >> >>>> >>> d
> > > >> > > >>> > > > >> > > >> >>>> >>>
> > > >> > > >>> > > > >> > > >> >>>> >>> ?
> > > >> > > >>> > > > >> > > >> >>>> >>>
> > > >> > > >>> > > > >> > > >> >>>> >>>
> > > >> > > >>> > > > >> > > >> >>>> >>> On Wed, Mar 5, 2014 at 10:20 PM,
> > Andrew
> > > >> > > Grieve <
> > > >> > > >>> > > > >> > > >> agrieve@chromium.org<mailto:
> > > agrieve@chromium.org>
> > > >> > > >>> > > > >> > > >> >>>> >wrote:
> > > >> > > >>> > > > >> > > >> >>>> >>>
> > > >> > > >>> > > > >> > > >> >>>> >>>> First - very excited that you're
> > > working
> > > >> > > >>> > > > >> > > >> >>>> >>>> on
> > > >> > > this!
> > > >> > > >>> > > > >> > > >> >>>> >>>>
> > > >> > > >>> > > > >> > > >> >>>> >>>> Had a quick look. Not sure there's
> > > much
> > > >> > > >>> > > > >> > > >> >>>> >>>> to
> > > >> > be
> > > >> > > >>> > gleaned
> > > >> > > >>> > > yet.
> > > >> > > >>> > > > >> > > >> >>>> >>>> Once
> > > >> > > >>> > > > >> > > >> you
> > > >> > > >>> > > > >> > > >> >>>> start
> > > >> > > >>> > > > >> > > >> >>>> >>>> in on hooking up x-walk's webview
> I
> > > >> > > >>> > > > >> > > >> >>>> >>>> think
> > > >> > it
> > > >> > > will
> > > >> > > >>> > > > >> > > >> >>>> >>>> become more
> > > >> > > >>> > > > >> > > >> obvious
> > > >> > > >>> > > > >> > > >> >>>> what
> > > >> > > >>> > > > >> > > >> >>>> >>>> the interface should look like.
> > E.g.,
> > > >> > > >>> > > > >> > > >> >>>> >>>> does
> > > >> > > x-walk
> > > >> > > >>> > > > >> > > >> >>>> >>>> even have the
> > > >> > > >>> > > > >> > > >> >>>> concept of
> > > >> > > >>> > > > >> > > >> >>>> >>>> ChromeClient vs WebViewClient vs
> > > >> > > >>> > > > >> > > >> >>>> >>>> WebView?
> > > >> > > Also
> > > >> > > >>> > > > >> > > >> >>>> >>>> unsure whether the
> > > >> > > >>> > > > >> > > >> >>>> class
> > > >> > > >>> > > > >> > > >> >>>> >>>> should extend android.View as well
> > as
> > > >> > > implement
> > > >> > > >>> > > > >> > > >> >>>> >>>> our
> > > >> > > >>> > > > >> > interface.
> > > >> > > >>> > > > >> > > >> E.g.
> > > >> > > >>> > > > >> > > >> >>>> >>>> alternative is to have a
> "getView()"
> > > >> > > >>> > > > >> > > >> >>>> >>>> method
> > > >> > > on
> > > >> > > >>> the
> > > >> > > >>> > > > >> > interface.
> > > >> > > >>> > > > >> > > >> Might
> > > >> > > >>> > > > >> > > >> >>>> help
> > > >> > > >>> > > > >> > > >> >>>> >>>> to
> > > >> > > >>> > > > >> > > >> >>>> >>>> cut down on file sizes, and API
> > > surface,
> > > >> > but
> > > >> > > >>> > > > >> > > >> >>>> >>>> again, I'm not too
> > > >> > > >>> > > > >> > > >> sure.
> > > >> > > >>> > > > >> > > >> >>>> >>>>
> > > >> > > >>> > > > >> > > >> >>>> >>>> I've been pretty hesitant to touch
> > > >> > > >>> > > > >> > > >> >>>> >>>> existing
> > > >> > > >>> > > > >> > > >> >>>> >>>> exposed members
> > > >> > > >>> > > > >> > > >> (e.g. the
> > > >> > > >>> > > > >> > > >> >>>> >>>> public fields you were referring
> to)
> > > >> > > >>> > > > >> > > >> >>>> >>>> since
> > > >> > > >>> > > > >> > > >> >>>> >>>> touching anything
> > > >> > > >>> > > > >> > > >> public
> > > >> > > >>> > > > >> > > >> >>>> could
> > > >> > > >>> > > > >> > > >> >>>> >>>> break plugins. That said, maybe
> now
> > > is a
> > > >> > good
> > > >> > > >>> time
> > > >> > > >>> > > > >> > > >> >>>> >>>> to @deprecate
> > > >> > > >>> > > > >> > > >> a
> > > >> > > >>> > > > >> > > >> >>>> bunch
> > > >> > > >>> > > > >> > > >> >>>> >>>> of
> > > >> > > >>> > > > >> > > >> >>>> >>>> them and either replace them with
> > > >> > > >>> > > > >> > > >> >>>> >>>> getters,
> > > >> > or
> > > >> > > >>> just
> > > >> > > >>> > > > >> > > >> >>>> >>>> declare them
> > > >> > > >>> > > > >> > > >> to be
> > > >> > > >>> > > > >> > > >> >>>> not
> > > >> > > >>> > > > >> > > >> >>>> >>>> exposed to plugins.
> > > >> > > >>> > > > >> > > >> >>>> >>>>
> > > >> > > >>> > > > >> > > >> >>>> >>>>
> > > >> > > >>> > > > >> > > >> >>>> >>>> On Wed, Mar 5, 2014 at 6:57 PM,
> Joe
> > > >> > > >>> > > > >> > > >> >>>> >>>> Bowser
> > > >> > > >>> > > > >> > > >> >>>> >>>> <bowserj@gmail.com<mailto:
> > > bowserj@gmail.com>>
> > > >> > > >>> > > > >> > > >> wrote:
> > > >> > > >>> > > > >> > > >> >>>> >>>>
> > > >> > > >>> > > > >> > > >> >>>> >>>> > So, after looking at the
> Crosswalk
> > > >> > > >>> > > > >> > > >> >>>> >>>> > code
> > > >> > > again,
> > > >> > > >>> > > > >> > > >> >>>> >>>> > I've decided to
> > > >> > > >>> > > > >> > > >> take
> > > >> > > >>> > > > >> > > >> >>>> a
> > > >> > > >>> > > > >> > > >> >>>> >>>> > quick stab at making things
> > > pluggable.
> > > >> > > >>> > > > >> > > >> >>>> >>>> > I
> > > >> > > don't
> > > >> > > >>> > > > >> > > >> >>>> >>>> > have a lot to
> > > >> > > >>> > > > >> > > >> show
> > > >> > > >>> > > > >> > > >> >>>> for
> > > >> > > >>> > > > >> > > >> >>>> >>>> > it, but with the help of Eclipse
> > > >> > > >>> > > > >> > > >> >>>> >>>> > (which
> > > >> > is
> > > >> > > why
> > > >> > > >>> > > > >> > > >> >>>> >>>> > the generated interfaces look so
> > > >> > > >>> > > > >> > > >> >>>> >>>> > screwed
> > > >> > > up), I
> > > >> > > >>> > > > >> > > >> >>>> >>>> > managed to create some
> > > >> > > >>> > > > >> > > >> interfaces
> > > >> > > >>> > > > >> > > >> >>>> so
> > > >> > > >>> > > > >> > > >> >>>> >>>> > we can start shoehorning in
> other
> > > >> > > >>> > > > >> > > >> >>>> >>>> > browser
> > > >> > > >>> > renderers.
> > > >> > > >>> > > > >> > > >> >>>> >>>> >
> > > >> > > >>> > > > >> > > >> >>>> >>>> >
> > > >> > > >>> > > > >> > > >>
> > > >> > > >>>
> https://github.com/infil00p/cordova-android/tree/pluggable_w
> > > >> > > >>> > > > >> > > >> eb
> > > >> > > >>> > > > >> > > >> vie
> > > >> > > >>> > > > >> > > >> w
> > > >> > > >>> > > > >> > > >> >>>> >>>> >
> > > >> > > >>> > > > >> > > >> >>>> >>>> > I'm going to probably start with
> > > >> > Crosswalk,
> > > >> > > >>> > > > >> > > >> >>>> >>>> > because it's
> > > >> > > >>> > > > >> > > >> probably
> > > >> > > >>> > > > >> > > >> >>>> the
> > > >> > > >>> > > > >> > > >> >>>> >>>> > most mature primary candidate in
> > the
> > > >> > > Android
> > > >> > > >>> > > > >> > > >> >>>> >>>> > Third-Party
> > > >> > > >>> > > > >> > > >> WebView
> > > >> > > >>> > > > >> > > >> >>>> >>>> > thing, and I'm pretty sure the
> > > >> > > >>> > > > >> > > >> >>>> >>>> > GeckoView
> > > >> > > will
> > > >> > > >>> be
> > > >> > > >>> > > > >> > > >> >>>> >>>> > happening
> > > >> > > >>> > > > >> > > >> shortly
> > > >> > > >>> > > > >> > > >> >>>> >>>> > after.
> > > >> > > >>> > > > >> > > >> >>>> >>>> >
> > > >> > > >>> > > > >> > > >> >>>> >>>> > I don't know how this would work
> > > >> > > >>> > > > >> > > >> >>>> >>>> > w.r.t.
> > > >> > > the CLI
> > > >> > > >>> > > > >> > > >> >>>> >>>> > or our
> > > >> > > >>> > > > >> > > >> workflow at
> > > >> > > >>> > > > >> > > >> >>>> >>>> > all, but at the moment, I really
> > > just
> > > >> > want
> > > >> > > to
> > > >> > > >>> at
> > > >> > > >>> > > > >> > > >> >>>> >>>> > least start
> > > >> > > >>> > > > >> > > >> to have
> > > >> > > >>> > > > >> > > >> >>>> >>>> > some headway towards 4.x and
> > > PhoneGap
> > > >> > day.
> > > >> > > >>> > > > >> > > >> >>>> >>>> >
> > > >> > > >>> > > > >> > > >> >>>> >>>> > What do people think of this so
> > far?
> > > >> > > >>> > > > >> > > >> >>>> >>>> > I'm
> > > >> > > going
> > > >> > > >>> > > > >> > > >> >>>> >>>> > to try to clean
> > > >> > > >>> > > > >> > > >> >>>> things
> > > >> > > >>> > > > >> > > >> >>>> >>>> > up a bit, since we've definitely
> > > done
> > > >> > > >>> > > > >> > > >> >>>> >>>> > a
> > > >> > > lot of
> > > >> > > >>> > > > >> > > >> >>>> >>>> > things that
> > > >> > > >>> > > > >> > > >> would
> > > >> > > >>> > > > >> > > >> >>>> make
> > > >> > > >>> > > > >> > > >> >>>> >>>> > first year CS profs freak the
> hell
> > > out
> > > >> > > (i.e.
> > > >> > > >>> > > > >> > > >> >>>> >>>> > public members in
> > > >> > > >>> > > > >> > > >> >>>> public
> > > >> > > >>> > > > >> > > >> >>>> >>>> > objects w.r.t. PluginManager).
> > > >> > > >>> > > > >> > > >> >>>> >>>> >
> > > >> > > >>> > > > >> > > >> >>>> >>>> > Thoughts?
> > > >> > > >>> > > > >> > > >> >>>> >>>> >
> > > >> > > >>> > > > >> > > >> >>>> >>>> > Joe
> > > >> > > >>> > > > >> > > >> >>>> >>>> >
> > > >> > > >>> > > > >> > > >> >>>> >>>>
> > > >> > > >>> > > > >> > > >> >>>> >>>
> > > >> > > >>> > > > >> > > >> >>>> >>>
> > > >> > > >>> > > > >> > > >> >>>>
> > > >> > > >>> > > > >> > > >>
> > > >> > > >>> > > > >> >
> > > >> > > >>> >
> > > >> > > >>>
> > > >> > >
> > > >> >
> > > >
> > > >
> > >
> > >
> >
>

Re: [Android] Refactoring for different engines

[Victor Sosa <so...@gmail.com>]

4PM PST? That's 6 CST or 7 EST, me thinks. Seems to work for many of us
On Apr 23, 2014 8:49 PM, "Brian LeRoux" <b...@brian.io> wrote:

> 4pm works for me…
>
>
> On Wed, Apr 23, 2014 at 6:19 PM, Hu, Ningxin <ni...@intel.com> wrote:
>
> > I am in China. 1:00 PM PST means 4:00 AM here :o.
> > Could you please schedule it a little bit later, say 4:00 or 5:00 PM PST?
> > It will be highly appreciated.
> >
> > Thanks,
> > -ningxin
> >
> > From: brian.leroux@gmail.com [mailto:brian.leroux@gmail.com] On Behalf
> Of
> > Brian LeRoux
> > Sent: Thursday, April 24, 2014 6:10 AM
> > To: Joe Bowser
> > Cc: dev@cordova.apache.org; Hu, Ningxin
> > Subject: Re: [Android] Refactoring for different engines
> >
> > How does 1:00PST on Friday work for a hangout for everyone?
> >
> > On Wed, Apr 23, 2014 at 2:36 PM, Joe Bowser <bowserj@gmail.com<mailto:
> > bowserj@gmail.com>> wrote:
> > BTW: Here's my PoC for Mozilla so far.  It's very broken!
> >
> > https://github.com/infil00p/MozillaView
> >
> >
> >
> > On Wed, Apr 23, 2014 at 10:50 AM, Brian LeRoux <b@brian.io<mailto:
> > b@brian.io>> wrote:
> > > So I found a Moz hacker whom can help. what time on Fri do you guys
> want
> > to
> > > do this?
> > >
> > >
> > > On Wed, Apr 23, 2014 at 10:31 AM, Ian Clelland <iclelland@chromium.org
> > <ma...@chromium.org>>
> > > wrote:
> > >>
> > >> I've managed to get this up and running now -- great work on this,
> Joe!
> > >>
> > >> Mobilespec runs on my N4, with 10 failing tests: 3 in contacts; 7 in
> > >> file-transfer. Otherwise, things seem to be working pretty well.
> > >>
> > >> I used a new build of Crosswalk, and found that the embedding API has
> > >> changed since the weekend (when Ningxin's patches applied). I've
> issued
> > a
> > >> pull request at
> > >> https://github.com/infil00p/cordova-crosswalk-engine/pull/5for it --
> > >>
> > >> I'm not sure if there's a way to keep compatibility with last
> > >> week's Crosswalk, or if we'd even want to. (Ningxin, if you could
> take a
> > >> look at that PR and see if it makes sense, I'd appreciate it)
> > >>
> > >> Joe, I also had to patch the default constructor for
> > XWalkCordovaWebView;
> > >> it wasn't creating its own client objects, so it got the default ones,
> > and
> > >> most of the tests were failing because some component of the bridge
> > wan't
> > >> working. https://github.com/infil00p/cordova-crosswalk-engine/pull/4is
> > >> out
> > >> for that.
> > >>
> > >> Count me in for the hangout -- this is exciting stuff
> > >>
> > >> Ian
> > >>
> > >>
> > >> On Wed, Apr 23, 2014 at 10:26 AM, Brian LeRoux <b@brian.io<mailto:
> > b@brian.io>> wrote:
> > >>
> > >> > Yup I'll track em down
> > >> > On Apr 23, 2014 7:17 AM, "Andrew Grieve" <agrieve@chromium.org
> > <ma...@chromium.org>> wrote:
> > >> >
> > >> > > Does anyone have a contact at moz that we could invite?
> > >> > >
> > >> > > On Wed, Apr 23, 2014 at 10:09 AM, Andrew Grieve <
> > agrieve@chromium.org<ma...@chromium.org>>
> > >> > > wrote:
> > >> > > > Depends on their interest level I think. Faster we can get this
> > out
> > >> > > > the door the better. If we need to delay for geckoview, then I
> > don't
> > >> > > > think we should gate on it, just release it after.
> > >> > > >
> > >> > > > On Wed, Apr 23, 2014 at 3:01 AM, Tommy Williams <
> > tommy@devgeeks.org<ma...@devgeeks.org>>
> > >> > > wrote:
> > >> > > >> More engines, more better...
> > >> > > >> On 23 Apr 2014 16:32, "Joe Bowser" <bowserj@gmail.com<mailto:
> > bowserj@gmail.com>> wrote:
> > >> > > >>
> > >> > > >>> Hey
> > >> > > >>>
> > >> > > >>> A Hangout would have to happen on Friday at the earliest.
>  It'd
> > be
> > >> > > good if
> > >> > > >>> we could get someone from Mozilla on the hangout as well.  I
> > >> > > >>> haven't
> > >> > > gotten
> > >> > > >>> MozillaView (GeckoView with Cordova methods) fully working
> yet.
> > >> > > >>> For
> > >> > > some
> > >> > > >>> reason it's not rendering on the screen.
> > >> > > >>>
> > >> > > >>> Ideally it'd be cool to have at least two options when this
> > >> > > >>> feature
> > >> > > finally
> > >> > > >>> lands.
> > >> > > >>>
> > >> > > >>> What do other people think?
> > >> > > >>>
> > >> > > >>> Joe
> > >> > > >>> On 22 Apr 2014 20:06, "Hu, Ningxin" <ningxin.hu@intel.com
> > <ma...@intel.com>> wrote:
> > >> > > >>>
> > >> > > >>> > Joe,
> > >> > > >>> >
> > >> > > >>> > Thanks for your review and merge the PRs.
> > >> > > >>> >
> > >> > > >>> > To pluggable webview interest group:
> > >> > > >>> > Are we OK to setup a hangout this week for initial
> > introduction
> > >> > > >>> > and
> > >> > > >>> > discussion of next steps?
> > >> > > >>> >
> > >> > > >>> > Thanks,
> > >> > > >>> > -ningxin
> > >> > > >>> >
> > >> > > >>> > > -----Original Message-----
> > >> > > >>> > > From: Hu, Ningxin [mailto:ningxin.hu@intel.com<mailto:
> > ningxin.hu@intel.com>]
> > >> > > >>> > > Sent: Tuesday, April 22, 2014 4:04 PM
> > >> > > >>> > > To: dev@cordova.apache.org<ma...@cordova.apache.org>
> > >> > > >>> > > Subject: RE: [Android] Refactoring for different engines
> > >> > > >>> > >
> > >> > > >>> > > The PoC is great! Quite excited about the direction!
> > >> > > >>> > >
> > >> > > >>> > > I've sent a PR to update the cordova-crosswalk-engine to
> > >> > > >>> > > latest
> > >> > > >>> crosswalk
> > >> > > >>> > > embedding API. It works with xwalk_core_library at
> > 6.35.124.0.
> > >> > > >>> > >
> > >> > > >>> > > I've also changed the CordovaWebView interface slightly
> > >> > > >>> > > (adding
> > >> > > >>> > getView() API)
> > >> > > >>> > > to allow XWalkCordovaWebView to composite a XWalkView
> > instead
> > >> > > >>> > > of
> > >> > > >>> > extending
> > >> > > >>> > > it. It resolves some API naming issues for XWalkView case.
> > >> > > >>> > >
> > >> > > >>> > > Please review them at:
> > >> > > >>> > >
> https://github.com/infil00p/cordova-crosswalk-engine/pull/3
> > >> > > >>> > > https://github.com/infil00p/cordova-android/pull/2
> > >> > > >>> > >
> > >> > > >>> > > Thanks,
> > >> > > >>> > > -ningxin
> > >> > > >>> > >
> > >> > > >>> > > > -----Original Message-----
> > >> > > >>> > > > From: Joe Bowser [mailto:bowserj@gmail.com<mailto:
> > bowserj@gmail.com>]
> > >> > > >>> > > > Sent: Friday, April 11, 2014 12:45 AM
> > >> > > >>> > > > To: dev
> > >> > > >>> > > > Subject: Re: [Android] Refactoring for different engines
> > >> > > >>> > > >
> > >> > > >>> > > > Yeah, I'd be cool with setting up a hangout.  Everyone
> > >> > > >>> > > > should
> > >> > > take a
> > >> > > >>> > > > look at the PoC, I've basically distilled it down to
> four
> > or
> > >> > five
> > >> > > >>> > > > classes so far, but with some work, we may be able to
> get
> > it
> > >> > > down to
> > >> > > >>> > > > three.  Due to legacy, we're pretty stuck with the
> Android
> > >> > > WebView
> > >> > > >>> API
> > >> > > >>> > calls,
> > >> > > >>> > > but these can probably be modified.
> > >> > > >>> > > >
> > >> > > >>> > > > It'd be good to get Mozilla people on the call as well,
> > >> > > >>> > > > since
> > >> > > they
> > >> > > >>> > > > have their WebView as well.
> > >> > > >>> > > >
> > >> > > >>> > > > On Thu, Apr 10, 2014 at 9:38 AM, Hu, Ningxin <
> > >> > > ningxin.hu@intel.com<ma...@intel.com>>
> > >> > > >>> > wrote:
> > >> > > >>> > > > > Hangout would be a good idea.
> > >> > > >>> > > > >
> > >> > > >>> > > > > FYI, I will be off next week. How about the week after
> > >> > > >>> > > > > next?
> > >> > > If it
> > >> > > >>> > > > > works, please
> > >> > > >>> > > > feel free to schedule one and count me in.
> > >> > > >>> > > > >
> > >> > > >>> > > > > Thanks,
> > >> > > >>> > > > > -ningxin
> > >> > > >>> > > > >
> > >> > > >>> > > > >> -----Original Message-----
> > >> > > >>> > > > >> From: mmocny@google.com<ma...@google.com>
> > [mailto:mmocny@google.com<ma...@google.com>] On
> > >> > Behalf
> > >> > > Of
> > >> > > >>> > > > >> Michal Mocny
> > >> > > >>> > > > >> Sent: Tuesday, April 08, 2014 11:39 PM
> > >> > > >>> > > > >> To: dev
> > >> > > >>> > > > >> Subject: Re: [Android] Refactoring for different
> > engines
> > >> > > >>> > > > >>
> > >> > > >>> > > > >> Would it be alright to set up a Hangout some time to
> > >> > introduce
> > >> > > >>> > everyone?
> > >> > > >>> > > > >>
> > >> > > >>> > > > >> Joe has been leading the effort here, but there are
> > other
> > >> > > cordova
> > >> > > >>> > > > >> contributors for whom this is top priority.  It would
> > be
> > >> > nice
> > >> > > if
> > >> > > >>> we
> > >> > > >>> > > > >> could all meet to say hello and make sure we are all
> > >> > > >>> > > > >> going
> > >> > in
> > >> > > the
> > >> > > >>> > > > >> right
> > >> > > >>> > > > direction.
> > >> > > >>> > > > >>
> > >> > > >>> > > > >> Quite exciting!
> > >> > > >>> > > > >>
> > >> > > >>> > > > >> -Michal
> > >> > > >>> > > > >>
> > >> > > >>> > > > >>
> > >> > > >>> > > > >> On Tue, Apr 8, 2014 at 10:56 AM, Hu, Ningxin <
> > >> > > >>> ningxin.hu@intel.com<ma...@intel.com>>
> > >> > > >>> > > wrote:
> > >> > > >>> > > > >>
> > >> > > >>> > > > >> > Joe, thanks for this. I am very excited.
> > >> > > >>> > > > >> >
> > >> > > >>> > > > >> > FYI. Crosswalk team is working on refactoring the
> > >> > > >>> > > > >> > WebView
> > >> > > API to
> > >> > > >>> > > > >> > support embedding usage better [1]. (Previously the
> > >> > > >>> > > > >> > layer
> > >> > > API
> > >> > > >>> was
> > >> > > >>> > > > >> > not exposed as public usage).
> > >> > > >>> > > > >> >
> > >> > > >>> > > > >> > I would like to review the PoC and work with you to
> > get
> > >> > > >>> Crosswalk
> > >> > > >>> > > > >> > fits into the pluggable WebView architecture.
> > >> > > >>> > > > >> >
> > >> > > >>> > > > >> > Thanks,
> > >> > > >>> > > > >> > -ningxin
> > >> > > >>> > > > >> >
> > >> > > >>> > > > >> > > -----Original Message-----
> > >> > > >>> > > > >> > > From: Joe Bowser [mailto:bowserj@gmail.com
> <mailto:
> > bowserj@gmail.com>]
> > >> > > >>> > > > >> > > Sent: Wednesday, March 19, 2014 7:08 AM
> > >> > > >>> > > > >> > > To: dev
> > >> > > >>> > > > >> > > Subject: Re: [Android] Refactoring for different
> > >> > > >>> > > > >> > > engines
> > >> > > >>> > > > >> > >
> > >> > > >>> > > > >> > > Hey
> > >> > > >>> > > > >> > >
> > >> > > >>> > > > >> > > After debugging, I did some minor updates to the
> > >> > > >>> > > > >> > > plugin
> > >> > > >>> README.
> > >> > > >>> > > > >> > > It
> > >> > > >>> > > > >> > should be
> > >> > > >>> > > > >> > > easier to get this up and running, although
> there's
> > >> > still
> > >> > > the
> > >> > > >>> > > > >> > > issue of
> > >> > > >>> > > > >> > after-install
> > >> > > >>> > > > >> > > hooks and the relative path weirdness with the
> > >> > > >>> > > > >> > > Crosswalk
> > >> > > >>> > Library itself.
> > >> > > >>> > > > >> > >
> > >> > > >>> > > > >> > > It still doesn't support the CLI at all, but it
> > >> > > >>> > > > >> > > should
> > >> > be
> > >> > > >>> there
> > >> > > >>> > > > >> > > with the
> > >> > > >>> > > > >> > old flow.
> > >> > > >>> > > > >> > >
> > >> > > >>> > > > >> > > On Mon, Mar 17, 2014 at 1:14 PM, Michal Mocny
> > >> > > >>> > > > >> > > <mmocny@chromium.org<mailto:mmocny@chromium.org
> >>
> > >> > > >>> > > > >> > > wrote:
> > >> > > >>> > > > >> > > > (Sorry Joe, Googlers are down in California and
> > way
> > >> > > busy.
> > >> > > >>> > > > >> > > > Will be back in a week.  Super excited about
> > this,
> > >> > > though.)
> > >> > > >>> > > > >> > > >
> > >> > > >>> > > > >> > > > -Michal
> > >> > > >>> > > > >> > > >
> > >> > > >>> > > > >> > > >
> > >> > > >>> > > > >> > > > On Mon, Mar 17, 2014 at 2:53 PM, Joe Bowser
> > >> > > >>> > > > >> > > > <bo...@gmail.com>>
> > >> > > >>> > > > >> wrote:
> > >> > > >>> > > > >> > > >
> > >> > > >>> > > > >> > > >> Reviving this thread!
> > >> > > >>> > > > >> > > >>
> > >> > > >>> > > > >> > > >> Can other people look at this, and see if/when
> > we
> > >> > > should
> > >> > > >>> > land this?
> > >> > > >>> > > > >> > > >> I know that I have to re-write the tests
> still,
> > >> > > >>> > > > >> > > >> but I
> > >> > > would
> > >> > > >>> > > > >> > > >> like some feedback before merging it in.
>  Also,
> > >> > > >>> > > > >> > > >> it'd
> > >> > be
> > >> > > >>> > > > >> > > >> super awesome if other people could try and
> > make a
> > >> > > WebView
> > >> > > >>> > > > >> > > >> based on the interfaces and recommend which
> > >> > > >>> > > > >> > > >> methods
> > >> > > should
> > >> > > >>> > > > >> > > >> die.  I want to get this released in the next
> > >> > > >>> > > > >> > > >> month
> > >> > or
> > >> > > so,
> > >> > > >>> > > > >> > > >> so any time and feedback would be greatly
> > >> > appreciated.
> > >> > > >>> > > > >> > > >>
> > >> > > >>> > > > >> > > >> Thanks
> > >> > > >>> > > > >> > > >>
> > >> > > >>> > > > >> > > >> On Thu, Mar 13, 2014 at 3:50 PM, Joe Bowser
> > >> > > >>> > > > >> > > >> <bo...@gmail.com>>
> > >> > > >>> > > > >> > wrote:
> > >> > > >>> > > > >> > > >> > Hey, I created the following today to track
> > >> > > >>> > > > >> > > >> > various
> > >> > > >>> > > > >> > > >> > WebView
> > >> > > >>> > > > >> > progresses:
> > >> > > >>> > > > >> > > >> >
> https://issues.apache.org/jira/browse/CB-6246
> > >> > > >>> > > > >> > > >> >
> > >> > > >>> > > > >> > > >> > I also have this repo created.  The
> licensing
> > is
> > >> > > ugly as
> > >> > > >>> > > > >> > > >> > all crap, but it's a Proof-Of-Concept:
> > >> > > >>> > > > >> > > >> >
> > >> > https://github.com/infil00p/cordova-crosswalk-engine
> > >> > > >>> > > > >> > > >> >
> > >> > > >>> > > > >> > > >> > If I can get some help getting plugman to
> just
> > >> > > >>> > > > >> > > >> > load
> > >> > > >>> > > > >> > > >> > Crosswalk, it'll
> > >> > > >>> > > > >> > > >> look hawt.
> > >> > > >>> > > > >> > > >> >
> > >> > > >>> > > > >> > > >> > BTW: We should probably get this ready to go
> > >> > > >>> > > > >> > > >> > into
> > >> > > Android
> > >> > > >>> > > > >> > > >> > in the next two months and deprecate the
> > >> > setProperty
> > >> > > >>> > > > >> > > >> > methods, since all properties should be
> > >> > > >>> > > > >> > > >> > preferences
> > >> > > in
> > >> > > >>> > config.xml
> > >> > > >>> > > now.
> > >> > > >>> > > > >> > > >> >
> > >> > > >>> > > > >> > > >> > On Mon, Mar 10, 2014 at 2:42 PM, Joe Bowser
> > >> > > >>> > > > >> > > >> > <bowserj@gmail.com<mailto:bowserj@gmail.com
> >>
> > >> > > >>> > > > >> > > wrote:
> > >> > > >>> > > > >> > > >> >> Perhaps. There would be additional benefits
> > to
> > >> > this
> > >> > > >>> > > > >> > > >> >> approach, namely fixes being added to that
> > >> > platform
> > >> > > more
> > >> > > >>> > > > >> > > >> >> quickly.  I'll probably take a look at that
> > >> > > >>> > > > >> > > >> >> once I
> > >> > > have
> > >> > > >>> > > > >> > > >> >> Crosswalk
> > >> > > >>> > > > finalized.
> > >> > > >>> > > > >> > > >> >>
> > >> > > >>> > > > >> > > >> >> On Mon, Mar 10, 2014 at 9:49 AM, Brian
> LeRoux
> > >> > > >>> > > > >> > > >> >> <b@...@brian.io>>
> > >> > > >>> > > > wrote:
> > >> > > >>> > > > >> > > >> >>> this is great stuff
> > >> > > >>> > > > >> > > >> >>>
> > >> > > >>> > > > >> > > >> >>> do we think it may be possible to bring in
> > >> > > >>> > > > >> > > >> >>> amazon
> > >> > > >>> fireos
> > >> > > >>> > > > >> > > >> >>> stuff
> > >> > > >>> > > > >> > > >> eventually
> > >> > > >>> > > > >> > > >> >>> too?
> > >> > > >>> > > > >> > > >> >>>
> > >> > > >>> > > > >> > > >> >>>
> > >> > > >>> > > > >> > > >> >>> On Fri, Mar 7, 2014 at 3:22 PM, Joe Bowser
> > >> > > >>> > > > >> > > >> >>> <bowserj@gmail.com<mailto:
> bowserj@gmail.com
> > >>
> > >> > > >>> > > > >> > wrote:
> > >> > > >>> > > > >> > > >> >>>
> > >> > > >>> > > > >> > > >> >>>> BTW: I committed it in my repo, not the
> > main
> > >> > > Apache
> > >> > > >>> one.
> > >> > > >>> > > > >> > > >> >>>>
> > >> > > >>> > > > >> > > >> >>>> On Fri, Mar 7, 2014 at 3:21 PM, Joe
> Bowser
> > >> > > >>> > > > >> > > >> >>>> <bowserj@gmail.com<mailto:
> > bowserj@gmail.com>>
> > >> > > >>> > > > >> > > wrote:
> > >> > > >>> > > > >> > > >> >>>> > Hey
> > >> > > >>> > > > >> > > >> >>>> >
> > >> > > >>> > > > >> > > >> >>>> > I just committed some code based on
> their
> > >> > > WebView
> > >> > > >>> > > > >> > > >> >>>> > modifications that allows you to choose
> > >> > > >>> > > > >> > > >> >>>> > your
> > >> > > >>> renderer
> > >> > > >>> > > > >> > > >> >>>> > in the
> > >> > > >>> > > > >> > config file
> > >> > > >>> > > > >> > > with this:
> > >> > > >>> > > > >> > > >> >>>> >
> > >> > > >>> > > > >> > > >> >>>> >     <preference name="webView"
> > >> > > >>> > > > >> > > >> >>>> >
> > >> > > >>> value="org.apache.cordova.engine.crosswalk.XWalkCordo
> > >> > > >>> > > > >> > > >> >>>> > va
> > >> > > >>> > > > >> > > >> >>>> > Web
> > >> > > >>> > > > >> > > >> >>>> > View
> > >> > > >>> > > > >> > > >> >>>> > " />
> > >> > > >>> > > > >> > > >> >>>> >
> > >> > > >>> > > > >> > > >> >>>> > You currently have to copy over the
> *.pak
> > >> > > >>> > > > >> > > >> >>>> > file
> > >> > > and
> > >> > > >>> > > > >> > > >> >>>> > the jsapi from a Crosswalk Example
> > project
> > >> > > >>> > > > >> > > >> >>>> > to
> > >> > > get
> > >> > > >>> > > > >> > > >> >>>> > this to work.  The next thing that I'm
> > >> > > >>> > > > >> > > >> >>>> > going
> > >> > to
> > >> > > do
> > >> > > >>> is
> > >> > > >>> > > > >> > > >> >>>> > figure out how to write this as a
> plugin
> > >> > > >>> > > > >> > > >> >>>> > and
> > >> > > have it
> > >> > > >>> > > > >> > > >> >>>> > install on a default
> > >> > > >>> > > > project.
> > >> > > >>> > > > >> > > >> >>>> > Also, right now the bridge doesn't seem
> > to
> > >> > > work, and
> > >> > > >>> > > > >> > > >> >>>> > I don't know why exactly.  That being
> > said,
> > >> > the
> > >> > > >>> > > > >> > > >> fact
> > >> > > >>> > > > >> > > >> >>>> > that I can choose which version of
> > >> > > Chrome/Chromium
> > >> > > >>> > > > >> > > >> >>>> > I'm running with
> > >> > > >>> > > > >> > > >> a
> > >> > > >>> > > > >> > > >> >>>> > single XML preference is HUGE.
> > >> > > >>> > > > >> > > >> >>>> >
> > >> > > >>> > > > >> > > >> >>>> > There's definitely a lot more work that
> > >> > > >>> > > > >> > > >> >>>> > needs
> > >> > > to be
> > >> > > >>> > > > >> > > >> >>>> > done, but as
> > >> > > >>> > > > >> > > >> long
> > >> > > >>> > > > >> > > >> >>>> > as we have something that we can fit
> into
> > >> > > >>> > > > >> > > >> >>>> > the
> > >> > > >>> > > > >> > > >> >>>> > interface, we should
> > >> > > >>> > > > >> > > >> be
> > >> > > >>> > > > >> > > >> >>>> > able to put in things like GeckoView or
> > >> > > >>> > > > >> > > >> >>>> > other
> > >> > > third
> > >> > > >>> > > > >> > > >> >>>> > party
> > >> > > >>> > > > >> > renderers.
> > >> > > >>> > > > >> > > >> >>>> > The nightmare of being stuck with
> > bullshit
> > >> > > WebView
> > >> > > >>> > > > >> > > >> >>>> > bugs may soon be over.
> > >> > > >>> > > > >> > > >> >>>> >
> > >> > > >>> > > > >> > > >> >>>> > On Wed, Mar 5, 2014 at 8:59 PM, Michal
> > >> > > >>> > > > >> > > >> >>>> > Mocny
> > >> > > >>> > > > >> > > >> >>>> > <mmocny@chromium.org<mailto:
> > mmocny@chromium.org>>
> > >> > > >>> > > > >> > > >> >>>> wrote:
> > >> > > >>> > > > >> > > >> >>>> >>
> > >> > > >>> https://github.com/crosswalk-project/crosswalk-cordo
> > >> > > >>> > > > >> > > >> >>>> >> va
> > >> > > >>> > > > >> > > >> >>>> >> -an
> > >> > > >>> > > > >> > > >> >>>> >> droi
> > >> > > >>> > > > >> > > >> >>>> >> d
> > >> > > >>> > > > >> > > >> >>>> >>
> > >> > > >>> > > > >> > > >> >>>> >> First patch they landed, which claims
> to
> > >> > > >>> > > > >> > > >> >>>> >> have
> > >> > > min
> > >> > > >>> > > > >> > > >> >>>> >> viable xwalk
> > >> > > >>> > > > >> > > >> webview:
> > >> > > >>> > > > >> > > >> >>>> >>
> > >> > > >>> > > > >> > > >> >>>>
> > >> > > >>> > > > >> > > >>
> > >> > > >>> https://github.com/crosswalk-project/crosswalk-cordova-andro
> > >> > > >>> > > > >> > > >> id
> > >> > > >>> > > > >> > > >> /co
> > >> > > >>> > > > >> > > >> mmit
> > >> > > >>> > > > >> > > >> /a04dedeb0204e7542d190312c6ae70c795a26e04
> > >> > > >>> > > > >> > > >> >>>> >>
> > >> > > >>> > > > >> > > >> >>>> >>
> > >> > > >>> > > > >> > > >> >>>> >> On Wed, Mar 5, 2014 at 11:37 PM,
> Michal
> > >> > > >>> > > > >> > > >> >>>> >> Mocny
> > >> > > >>> > > > >> > > >> >>>> >> <mmocny@chromium.org<mailto:
> > mmocny@chromium.org>
> > >> > > >>> > > > >> > > >> >
> > >> > > >>> > > > >> > > >> >>>> wrote:
> > >> > > >>> > > > >> > > >> >>>> >>
> > >> > > >>> > > > >> > > >> >>>> >>> I haven't looked yet, but did you
> see:
> > >> > > >>> > > > >> > > >> >>>> >>>
> > >> > > >>> https://crosswalk-project.org/#wiki/crosswalk-cordo
> > >> > > >>> > > > >> > > >> >>>> >>> va
> > >> > > >>> > > > >> > > >> >>>> >>> -an
> > >> > > >>> > > > >> > > >> >>>> >>> droi
> > >> > > >>> > > > >> > > >> >>>> >>> d
> > >> > > >>> > > > >> > > >> >>>> >>>
> > >> > > >>> > > > >> > > >> >>>> >>> ?
> > >> > > >>> > > > >> > > >> >>>> >>>
> > >> > > >>> > > > >> > > >> >>>> >>>
> > >> > > >>> > > > >> > > >> >>>> >>> On Wed, Mar 5, 2014 at 10:20 PM,
> Andrew
> > >> > > Grieve <
> > >> > > >>> > > > >> > > >> agrieve@chromium.org<mailto:
> > agrieve@chromium.org>
> > >> > > >>> > > > >> > > >> >>>> >wrote:
> > >> > > >>> > > > >> > > >> >>>> >>>
> > >> > > >>> > > > >> > > >> >>>> >>>> First - very excited that you're
> > working
> > >> > > >>> > > > >> > > >> >>>> >>>> on
> > >> > > this!
> > >> > > >>> > > > >> > > >> >>>> >>>>
> > >> > > >>> > > > >> > > >> >>>> >>>> Had a quick look. Not sure there's
> > much
> > >> > > >>> > > > >> > > >> >>>> >>>> to
> > >> > be
> > >> > > >>> > gleaned
> > >> > > >>> > > yet.
> > >> > > >>> > > > >> > > >> >>>> >>>> Once
> > >> > > >>> > > > >> > > >> you
> > >> > > >>> > > > >> > > >> >>>> start
> > >> > > >>> > > > >> > > >> >>>> >>>> in on hooking up x-walk's webview I
> > >> > > >>> > > > >> > > >> >>>> >>>> think
> > >> > it
> > >> > > will
> > >> > > >>> > > > >> > > >> >>>> >>>> become more
> > >> > > >>> > > > >> > > >> obvious
> > >> > > >>> > > > >> > > >> >>>> what
> > >> > > >>> > > > >> > > >> >>>> >>>> the interface should look like.
> E.g.,
> > >> > > >>> > > > >> > > >> >>>> >>>> does
> > >> > > x-walk
> > >> > > >>> > > > >> > > >> >>>> >>>> even have the
> > >> > > >>> > > > >> > > >> >>>> concept of
> > >> > > >>> > > > >> > > >> >>>> >>>> ChromeClient vs WebViewClient vs
> > >> > > >>> > > > >> > > >> >>>> >>>> WebView?
> > >> > > Also
> > >> > > >>> > > > >> > > >> >>>> >>>> unsure whether the
> > >> > > >>> > > > >> > > >> >>>> class
> > >> > > >>> > > > >> > > >> >>>> >>>> should extend android.View as well
> as
> > >> > > implement
> > >> > > >>> > > > >> > > >> >>>> >>>> our
> > >> > > >>> > > > >> > interface.
> > >> > > >>> > > > >> > > >> E.g.
> > >> > > >>> > > > >> > > >> >>>> >>>> alternative is to have a "getView()"
> > >> > > >>> > > > >> > > >> >>>> >>>> method
> > >> > > on
> > >> > > >>> the
> > >> > > >>> > > > >> > interface.
> > >> > > >>> > > > >> > > >> Might
> > >> > > >>> > > > >> > > >> >>>> help
> > >> > > >>> > > > >> > > >> >>>> >>>> to
> > >> > > >>> > > > >> > > >> >>>> >>>> cut down on file sizes, and API
> > surface,
> > >> > but
> > >> > > >>> > > > >> > > >> >>>> >>>> again, I'm not too
> > >> > > >>> > > > >> > > >> sure.
> > >> > > >>> > > > >> > > >> >>>> >>>>
> > >> > > >>> > > > >> > > >> >>>> >>>> I've been pretty hesitant to touch
> > >> > > >>> > > > >> > > >> >>>> >>>> existing
> > >> > > >>> > > > >> > > >> >>>> >>>> exposed members
> > >> > > >>> > > > >> > > >> (e.g. the
> > >> > > >>> > > > >> > > >> >>>> >>>> public fields you were referring to)
> > >> > > >>> > > > >> > > >> >>>> >>>> since
> > >> > > >>> > > > >> > > >> >>>> >>>> touching anything
> > >> > > >>> > > > >> > > >> public
> > >> > > >>> > > > >> > > >> >>>> could
> > >> > > >>> > > > >> > > >> >>>> >>>> break plugins. That said, maybe now
> > is a
> > >> > good
> > >> > > >>> time
> > >> > > >>> > > > >> > > >> >>>> >>>> to @deprecate
> > >> > > >>> > > > >> > > >> a
> > >> > > >>> > > > >> > > >> >>>> bunch
> > >> > > >>> > > > >> > > >> >>>> >>>> of
> > >> > > >>> > > > >> > > >> >>>> >>>> them and either replace them with
> > >> > > >>> > > > >> > > >> >>>> >>>> getters,
> > >> > or
> > >> > > >>> just
> > >> > > >>> > > > >> > > >> >>>> >>>> declare them
> > >> > > >>> > > > >> > > >> to be
> > >> > > >>> > > > >> > > >> >>>> not
> > >> > > >>> > > > >> > > >> >>>> >>>> exposed to plugins.
> > >> > > >>> > > > >> > > >> >>>> >>>>
> > >> > > >>> > > > >> > > >> >>>> >>>>
> > >> > > >>> > > > >> > > >> >>>> >>>> On Wed, Mar 5, 2014 at 6:57 PM, Joe
> > >> > > >>> > > > >> > > >> >>>> >>>> Bowser
> > >> > > >>> > > > >> > > >> >>>> >>>> <bowserj@gmail.com<mailto:
> > bowserj@gmail.com>>
> > >> > > >>> > > > >> > > >> wrote:
> > >> > > >>> > > > >> > > >> >>>> >>>>
> > >> > > >>> > > > >> > > >> >>>> >>>> > So, after looking at the Crosswalk
> > >> > > >>> > > > >> > > >> >>>> >>>> > code
> > >> > > again,
> > >> > > >>> > > > >> > > >> >>>> >>>> > I've decided to
> > >> > > >>> > > > >> > > >> take
> > >> > > >>> > > > >> > > >> >>>> a
> > >> > > >>> > > > >> > > >> >>>> >>>> > quick stab at making things
> > pluggable.
> > >> > > >>> > > > >> > > >> >>>> >>>> > I
> > >> > > don't
> > >> > > >>> > > > >> > > >> >>>> >>>> > have a lot to
> > >> > > >>> > > > >> > > >> show
> > >> > > >>> > > > >> > > >> >>>> for
> > >> > > >>> > > > >> > > >> >>>> >>>> > it, but with the help of Eclipse
> > >> > > >>> > > > >> > > >> >>>> >>>> > (which
> > >> > is
> > >> > > why
> > >> > > >>> > > > >> > > >> >>>> >>>> > the generated interfaces look so
> > >> > > >>> > > > >> > > >> >>>> >>>> > screwed
> > >> > > up), I
> > >> > > >>> > > > >> > > >> >>>> >>>> > managed to create some
> > >> > > >>> > > > >> > > >> interfaces
> > >> > > >>> > > > >> > > >> >>>> so
> > >> > > >>> > > > >> > > >> >>>> >>>> > we can start shoehorning in other
> > >> > > >>> > > > >> > > >> >>>> >>>> > browser
> > >> > > >>> > renderers.
> > >> > > >>> > > > >> > > >> >>>> >>>> >
> > >> > > >>> > > > >> > > >> >>>> >>>> >
> > >> > > >>> > > > >> > > >>
> > >> > > >>> https://github.com/infil00p/cordova-android/tree/pluggable_w
> > >> > > >>> > > > >> > > >> eb
> > >> > > >>> > > > >> > > >> vie
> > >> > > >>> > > > >> > > >> w
> > >> > > >>> > > > >> > > >> >>>> >>>> >
> > >> > > >>> > > > >> > > >> >>>> >>>> > I'm going to probably start with
> > >> > Crosswalk,
> > >> > > >>> > > > >> > > >> >>>> >>>> > because it's
> > >> > > >>> > > > >> > > >> probably
> > >> > > >>> > > > >> > > >> >>>> the
> > >> > > >>> > > > >> > > >> >>>> >>>> > most mature primary candidate in
> the
> > >> > > Android
> > >> > > >>> > > > >> > > >> >>>> >>>> > Third-Party
> > >> > > >>> > > > >> > > >> WebView
> > >> > > >>> > > > >> > > >> >>>> >>>> > thing, and I'm pretty sure the
> > >> > > >>> > > > >> > > >> >>>> >>>> > GeckoView
> > >> > > will
> > >> > > >>> be
> > >> > > >>> > > > >> > > >> >>>> >>>> > happening
> > >> > > >>> > > > >> > > >> shortly
> > >> > > >>> > > > >> > > >> >>>> >>>> > after.
> > >> > > >>> > > > >> > > >> >>>> >>>> >
> > >> > > >>> > > > >> > > >> >>>> >>>> > I don't know how this would work
> > >> > > >>> > > > >> > > >> >>>> >>>> > w.r.t.
> > >> > > the CLI
> > >> > > >>> > > > >> > > >> >>>> >>>> > or our
> > >> > > >>> > > > >> > > >> workflow at
> > >> > > >>> > > > >> > > >> >>>> >>>> > all, but at the moment, I really
> > just
> > >> > want
> > >> > > to
> > >> > > >>> at
> > >> > > >>> > > > >> > > >> >>>> >>>> > least start
> > >> > > >>> > > > >> > > >> to have
> > >> > > >>> > > > >> > > >> >>>> >>>> > some headway towards 4.x and
> > PhoneGap
> > >> > day.
> > >> > > >>> > > > >> > > >> >>>> >>>> >
> > >> > > >>> > > > >> > > >> >>>> >>>> > What do people think of this so
> far?
> > >> > > >>> > > > >> > > >> >>>> >>>> > I'm
> > >> > > going
> > >> > > >>> > > > >> > > >> >>>> >>>> > to try to clean
> > >> > > >>> > > > >> > > >> >>>> things
> > >> > > >>> > > > >> > > >> >>>> >>>> > up a bit, since we've definitely
> > done
> > >> > > >>> > > > >> > > >> >>>> >>>> > a
> > >> > > lot of
> > >> > > >>> > > > >> > > >> >>>> >>>> > things that
> > >> > > >>> > > > >> > > >> would
> > >> > > >>> > > > >> > > >> >>>> make
> > >> > > >>> > > > >> > > >> >>>> >>>> > first year CS profs freak the hell
> > out
> > >> > > (i.e.
> > >> > > >>> > > > >> > > >> >>>> >>>> > public members in
> > >> > > >>> > > > >> > > >> >>>> public
> > >> > > >>> > > > >> > > >> >>>> >>>> > objects w.r.t. PluginManager).
> > >> > > >>> > > > >> > > >> >>>> >>>> >
> > >> > > >>> > > > >> > > >> >>>> >>>> > Thoughts?
> > >> > > >>> > > > >> > > >> >>>> >>>> >
> > >> > > >>> > > > >> > > >> >>>> >>>> > Joe
> > >> > > >>> > > > >> > > >> >>>> >>>> >
> > >> > > >>> > > > >> > > >> >>>> >>>>
> > >> > > >>> > > > >> > > >> >>>> >>>
> > >> > > >>> > > > >> > > >> >>>> >>>
> > >> > > >>> > > > >> > > >> >>>>
> > >> > > >>> > > > >> > > >>
> > >> > > >>> > > > >> >
> > >> > > >>> >
> > >> > > >>>
> > >> > >
> > >> >
> > >
> > >
> >
> >
>

Re: [Android] Refactoring for different engines

[Brian LeRoux <b...@brian.io>]

4pm works for me…


On Wed, Apr 23, 2014 at 6:19 PM, Hu, Ningxin <ni...@intel.com> wrote:

> I am in China. 1:00 PM PST means 4:00 AM here :o.
> Could you please schedule it a little bit later, say 4:00 or 5:00 PM PST?
> It will be highly appreciated.
>
> Thanks,
> -ningxin
>
> From: brian.leroux@gmail.com [mailto:brian.leroux@gmail.com] On Behalf Of
> Brian LeRoux
> Sent: Thursday, April 24, 2014 6:10 AM
> To: Joe Bowser
> Cc: dev@cordova.apache.org; Hu, Ningxin
> Subject: Re: [Android] Refactoring for different engines
>
> How does 1:00PST on Friday work for a hangout for everyone?
>
> On Wed, Apr 23, 2014 at 2:36 PM, Joe Bowser <bowserj@gmail.com<mailto:
> bowserj@gmail.com>> wrote:
> BTW: Here's my PoC for Mozilla so far.  It's very broken!
>
> https://github.com/infil00p/MozillaView
>
>
>
> On Wed, Apr 23, 2014 at 10:50 AM, Brian LeRoux <b@brian.io<mailto:
> b@brian.io>> wrote:
> > So I found a Moz hacker whom can help. what time on Fri do you guys want
> to
> > do this?
> >
> >
> > On Wed, Apr 23, 2014 at 10:31 AM, Ian Clelland <iclelland@chromium.org
> <ma...@chromium.org>>
> > wrote:
> >>
> >> I've managed to get this up and running now -- great work on this, Joe!
> >>
> >> Mobilespec runs on my N4, with 10 failing tests: 3 in contacts; 7 in
> >> file-transfer. Otherwise, things seem to be working pretty well.
> >>
> >> I used a new build of Crosswalk, and found that the embedding API has
> >> changed since the weekend (when Ningxin's patches applied). I've issued
> a
> >> pull request at
> >> https://github.com/infil00p/cordova-crosswalk-engine/pull/5for it --
> >>
> >> I'm not sure if there's a way to keep compatibility with last
> >> week's Crosswalk, or if we'd even want to. (Ningxin, if you could take a
> >> look at that PR and see if it makes sense, I'd appreciate it)
> >>
> >> Joe, I also had to patch the default constructor for
> XWalkCordovaWebView;
> >> it wasn't creating its own client objects, so it got the default ones,
> and
> >> most of the tests were failing because some component of the bridge
> wan't
> >> working. https://github.com/infil00p/cordova-crosswalk-engine/pull/4 is
> >> out
> >> for that.
> >>
> >> Count me in for the hangout -- this is exciting stuff
> >>
> >> Ian
> >>
> >>
> >> On Wed, Apr 23, 2014 at 10:26 AM, Brian LeRoux <b@brian.io<mailto:
> b@brian.io>> wrote:
> >>
> >> > Yup I'll track em down
> >> > On Apr 23, 2014 7:17 AM, "Andrew Grieve" <agrieve@chromium.org
> <ma...@chromium.org>> wrote:
> >> >
> >> > > Does anyone have a contact at moz that we could invite?
> >> > >
> >> > > On Wed, Apr 23, 2014 at 10:09 AM, Andrew Grieve <
> agrieve@chromium.org<ma...@chromium.org>>
> >> > > wrote:
> >> > > > Depends on their interest level I think. Faster we can get this
> out
> >> > > > the door the better. If we need to delay for geckoview, then I
> don't
> >> > > > think we should gate on it, just release it after.
> >> > > >
> >> > > > On Wed, Apr 23, 2014 at 3:01 AM, Tommy Williams <
> tommy@devgeeks.org<ma...@devgeeks.org>>
> >> > > wrote:
> >> > > >> More engines, more better...
> >> > > >> On 23 Apr 2014 16:32, "Joe Bowser" <bowserj@gmail.com<mailto:
> bowserj@gmail.com>> wrote:
> >> > > >>
> >> > > >>> Hey
> >> > > >>>
> >> > > >>> A Hangout would have to happen on Friday at the earliest.  It'd
> be
> >> > > good if
> >> > > >>> we could get someone from Mozilla on the hangout as well.  I
> >> > > >>> haven't
> >> > > gotten
> >> > > >>> MozillaView (GeckoView with Cordova methods) fully working yet.
> >> > > >>> For
> >> > > some
> >> > > >>> reason it's not rendering on the screen.
> >> > > >>>
> >> > > >>> Ideally it'd be cool to have at least two options when this
> >> > > >>> feature
> >> > > finally
> >> > > >>> lands.
> >> > > >>>
> >> > > >>> What do other people think?
> >> > > >>>
> >> > > >>> Joe
> >> > > >>> On 22 Apr 2014 20:06, "Hu, Ningxin" <ningxin.hu@intel.com
> <ma...@intel.com>> wrote:
> >> > > >>>
> >> > > >>> > Joe,
> >> > > >>> >
> >> > > >>> > Thanks for your review and merge the PRs.
> >> > > >>> >
> >> > > >>> > To pluggable webview interest group:
> >> > > >>> > Are we OK to setup a hangout this week for initial
> introduction
> >> > > >>> > and
> >> > > >>> > discussion of next steps?
> >> > > >>> >
> >> > > >>> > Thanks,
> >> > > >>> > -ningxin
> >> > > >>> >
> >> > > >>> > > -----Original Message-----
> >> > > >>> > > From: Hu, Ningxin [mailto:ningxin.hu@intel.com<mailto:
> ningxin.hu@intel.com>]
> >> > > >>> > > Sent: Tuesday, April 22, 2014 4:04 PM
> >> > > >>> > > To: dev@cordova.apache.org<ma...@cordova.apache.org>
> >> > > >>> > > Subject: RE: [Android] Refactoring for different engines
> >> > > >>> > >
> >> > > >>> > > The PoC is great! Quite excited about the direction!
> >> > > >>> > >
> >> > > >>> > > I've sent a PR to update the cordova-crosswalk-engine to
> >> > > >>> > > latest
> >> > > >>> crosswalk
> >> > > >>> > > embedding API. It works with xwalk_core_library at
> 6.35.124.0.
> >> > > >>> > >
> >> > > >>> > > I've also changed the CordovaWebView interface slightly
> >> > > >>> > > (adding
> >> > > >>> > getView() API)
> >> > > >>> > > to allow XWalkCordovaWebView to composite a XWalkView
> instead
> >> > > >>> > > of
> >> > > >>> > extending
> >> > > >>> > > it. It resolves some API naming issues for XWalkView case.
> >> > > >>> > >
> >> > > >>> > > Please review them at:
> >> > > >>> > > https://github.com/infil00p/cordova-crosswalk-engine/pull/3
> >> > > >>> > > https://github.com/infil00p/cordova-android/pull/2
> >> > > >>> > >
> >> > > >>> > > Thanks,
> >> > > >>> > > -ningxin
> >> > > >>> > >
> >> > > >>> > > > -----Original Message-----
> >> > > >>> > > > From: Joe Bowser [mailto:bowserj@gmail.com<mailto:
> bowserj@gmail.com>]
> >> > > >>> > > > Sent: Friday, April 11, 2014 12:45 AM
> >> > > >>> > > > To: dev
> >> > > >>> > > > Subject: Re: [Android] Refactoring for different engines
> >> > > >>> > > >
> >> > > >>> > > > Yeah, I'd be cool with setting up a hangout.  Everyone
> >> > > >>> > > > should
> >> > > take a
> >> > > >>> > > > look at the PoC, I've basically distilled it down to four
> or
> >> > five
> >> > > >>> > > > classes so far, but with some work, we may be able to get
> it
> >> > > down to
> >> > > >>> > > > three.  Due to legacy, we're pretty stuck with the Android
> >> > > WebView
> >> > > >>> API
> >> > > >>> > calls,
> >> > > >>> > > but these can probably be modified.
> >> > > >>> > > >
> >> > > >>> > > > It'd be good to get Mozilla people on the call as well,
> >> > > >>> > > > since
> >> > > they
> >> > > >>> > > > have their WebView as well.
> >> > > >>> > > >
> >> > > >>> > > > On Thu, Apr 10, 2014 at 9:38 AM, Hu, Ningxin <
> >> > > ningxin.hu@intel.com<ma...@intel.com>>
> >> > > >>> > wrote:
> >> > > >>> > > > > Hangout would be a good idea.
> >> > > >>> > > > >
> >> > > >>> > > > > FYI, I will be off next week. How about the week after
> >> > > >>> > > > > next?
> >> > > If it
> >> > > >>> > > > > works, please
> >> > > >>> > > > feel free to schedule one and count me in.
> >> > > >>> > > > >
> >> > > >>> > > > > Thanks,
> >> > > >>> > > > > -ningxin
> >> > > >>> > > > >
> >> > > >>> > > > >> -----Original Message-----
> >> > > >>> > > > >> From: mmocny@google.com<ma...@google.com>
> [mailto:mmocny@google.com<ma...@google.com>] On
> >> > Behalf
> >> > > Of
> >> > > >>> > > > >> Michal Mocny
> >> > > >>> > > > >> Sent: Tuesday, April 08, 2014 11:39 PM
> >> > > >>> > > > >> To: dev
> >> > > >>> > > > >> Subject: Re: [Android] Refactoring for different
> engines
> >> > > >>> > > > >>
> >> > > >>> > > > >> Would it be alright to set up a Hangout some time to
> >> > introduce
> >> > > >>> > everyone?
> >> > > >>> > > > >>
> >> > > >>> > > > >> Joe has been leading the effort here, but there are
> other
> >> > > cordova
> >> > > >>> > > > >> contributors for whom this is top priority.  It would
> be
> >> > nice
> >> > > if
> >> > > >>> we
> >> > > >>> > > > >> could all meet to say hello and make sure we are all
> >> > > >>> > > > >> going
> >> > in
> >> > > the
> >> > > >>> > > > >> right
> >> > > >>> > > > direction.
> >> > > >>> > > > >>
> >> > > >>> > > > >> Quite exciting!
> >> > > >>> > > > >>
> >> > > >>> > > > >> -Michal
> >> > > >>> > > > >>
> >> > > >>> > > > >>
> >> > > >>> > > > >> On Tue, Apr 8, 2014 at 10:56 AM, Hu, Ningxin <
> >> > > >>> ningxin.hu@intel.com<ma...@intel.com>>
> >> > > >>> > > wrote:
> >> > > >>> > > > >>
> >> > > >>> > > > >> > Joe, thanks for this. I am very excited.
> >> > > >>> > > > >> >
> >> > > >>> > > > >> > FYI. Crosswalk team is working on refactoring the
> >> > > >>> > > > >> > WebView
> >> > > API to
> >> > > >>> > > > >> > support embedding usage better [1]. (Previously the
> >> > > >>> > > > >> > layer
> >> > > API
> >> > > >>> was
> >> > > >>> > > > >> > not exposed as public usage).
> >> > > >>> > > > >> >
> >> > > >>> > > > >> > I would like to review the PoC and work with you to
> get
> >> > > >>> Crosswalk
> >> > > >>> > > > >> > fits into the pluggable WebView architecture.
> >> > > >>> > > > >> >
> >> > > >>> > > > >> > Thanks,
> >> > > >>> > > > >> > -ningxin
> >> > > >>> > > > >> >
> >> > > >>> > > > >> > > -----Original Message-----
> >> > > >>> > > > >> > > From: Joe Bowser [mailto:bowserj@gmail.com<mailto:
> bowserj@gmail.com>]
> >> > > >>> > > > >> > > Sent: Wednesday, March 19, 2014 7:08 AM
> >> > > >>> > > > >> > > To: dev
> >> > > >>> > > > >> > > Subject: Re: [Android] Refactoring for different
> >> > > >>> > > > >> > > engines
> >> > > >>> > > > >> > >
> >> > > >>> > > > >> > > Hey
> >> > > >>> > > > >> > >
> >> > > >>> > > > >> > > After debugging, I did some minor updates to the
> >> > > >>> > > > >> > > plugin
> >> > > >>> README.
> >> > > >>> > > > >> > > It
> >> > > >>> > > > >> > should be
> >> > > >>> > > > >> > > easier to get this up and running, although there's
> >> > still
> >> > > the
> >> > > >>> > > > >> > > issue of
> >> > > >>> > > > >> > after-install
> >> > > >>> > > > >> > > hooks and the relative path weirdness with the
> >> > > >>> > > > >> > > Crosswalk
> >> > > >>> > Library itself.
> >> > > >>> > > > >> > >
> >> > > >>> > > > >> > > It still doesn't support the CLI at all, but it
> >> > > >>> > > > >> > > should
> >> > be
> >> > > >>> there
> >> > > >>> > > > >> > > with the
> >> > > >>> > > > >> > old flow.
> >> > > >>> > > > >> > >
> >> > > >>> > > > >> > > On Mon, Mar 17, 2014 at 1:14 PM, Michal Mocny
> >> > > >>> > > > >> > > <mm...@chromium.org>>
> >> > > >>> > > > >> > > wrote:
> >> > > >>> > > > >> > > > (Sorry Joe, Googlers are down in California and
> way
> >> > > busy.
> >> > > >>> > > > >> > > > Will be back in a week.  Super excited about
> this,
> >> > > though.)
> >> > > >>> > > > >> > > >
> >> > > >>> > > > >> > > > -Michal
> >> > > >>> > > > >> > > >
> >> > > >>> > > > >> > > >
> >> > > >>> > > > >> > > > On Mon, Mar 17, 2014 at 2:53 PM, Joe Bowser
> >> > > >>> > > > >> > > > <bo...@gmail.com>>
> >> > > >>> > > > >> wrote:
> >> > > >>> > > > >> > > >
> >> > > >>> > > > >> > > >> Reviving this thread!
> >> > > >>> > > > >> > > >>
> >> > > >>> > > > >> > > >> Can other people look at this, and see if/when
> we
> >> > > should
> >> > > >>> > land this?
> >> > > >>> > > > >> > > >> I know that I have to re-write the tests still,
> >> > > >>> > > > >> > > >> but I
> >> > > would
> >> > > >>> > > > >> > > >> like some feedback before merging it in.  Also,
> >> > > >>> > > > >> > > >> it'd
> >> > be
> >> > > >>> > > > >> > > >> super awesome if other people could try and
> make a
> >> > > WebView
> >> > > >>> > > > >> > > >> based on the interfaces and recommend which
> >> > > >>> > > > >> > > >> methods
> >> > > should
> >> > > >>> > > > >> > > >> die.  I want to get this released in the next
> >> > > >>> > > > >> > > >> month
> >> > or
> >> > > so,
> >> > > >>> > > > >> > > >> so any time and feedback would be greatly
> >> > appreciated.
> >> > > >>> > > > >> > > >>
> >> > > >>> > > > >> > > >> Thanks
> >> > > >>> > > > >> > > >>
> >> > > >>> > > > >> > > >> On Thu, Mar 13, 2014 at 3:50 PM, Joe Bowser
> >> > > >>> > > > >> > > >> <bo...@gmail.com>>
> >> > > >>> > > > >> > wrote:
> >> > > >>> > > > >> > > >> > Hey, I created the following today to track
> >> > > >>> > > > >> > > >> > various
> >> > > >>> > > > >> > > >> > WebView
> >> > > >>> > > > >> > progresses:
> >> > > >>> > > > >> > > >> > https://issues.apache.org/jira/browse/CB-6246
> >> > > >>> > > > >> > > >> >
> >> > > >>> > > > >> > > >> > I also have this repo created.  The licensing
> is
> >> > > ugly as
> >> > > >>> > > > >> > > >> > all crap, but it's a Proof-Of-Concept:
> >> > > >>> > > > >> > > >> >
> >> > https://github.com/infil00p/cordova-crosswalk-engine
> >> > > >>> > > > >> > > >> >
> >> > > >>> > > > >> > > >> > If I can get some help getting plugman to just
> >> > > >>> > > > >> > > >> > load
> >> > > >>> > > > >> > > >> > Crosswalk, it'll
> >> > > >>> > > > >> > > >> look hawt.
> >> > > >>> > > > >> > > >> >
> >> > > >>> > > > >> > > >> > BTW: We should probably get this ready to go
> >> > > >>> > > > >> > > >> > into
> >> > > Android
> >> > > >>> > > > >> > > >> > in the next two months and deprecate the
> >> > setProperty
> >> > > >>> > > > >> > > >> > methods, since all properties should be
> >> > > >>> > > > >> > > >> > preferences
> >> > > in
> >> > > >>> > config.xml
> >> > > >>> > > now.
> >> > > >>> > > > >> > > >> >
> >> > > >>> > > > >> > > >> > On Mon, Mar 10, 2014 at 2:42 PM, Joe Bowser
> >> > > >>> > > > >> > > >> > <bo...@gmail.com>>
> >> > > >>> > > > >> > > wrote:
> >> > > >>> > > > >> > > >> >> Perhaps. There would be additional benefits
> to
> >> > this
> >> > > >>> > > > >> > > >> >> approach, namely fixes being added to that
> >> > platform
> >> > > more
> >> > > >>> > > > >> > > >> >> quickly.  I'll probably take a look at that
> >> > > >>> > > > >> > > >> >> once I
> >> > > have
> >> > > >>> > > > >> > > >> >> Crosswalk
> >> > > >>> > > > finalized.
> >> > > >>> > > > >> > > >> >>
> >> > > >>> > > > >> > > >> >> On Mon, Mar 10, 2014 at 9:49 AM, Brian LeRoux
> >> > > >>> > > > >> > > >> >> <b@...@brian.io>>
> >> > > >>> > > > wrote:
> >> > > >>> > > > >> > > >> >>> this is great stuff
> >> > > >>> > > > >> > > >> >>>
> >> > > >>> > > > >> > > >> >>> do we think it may be possible to bring in
> >> > > >>> > > > >> > > >> >>> amazon
> >> > > >>> fireos
> >> > > >>> > > > >> > > >> >>> stuff
> >> > > >>> > > > >> > > >> eventually
> >> > > >>> > > > >> > > >> >>> too?
> >> > > >>> > > > >> > > >> >>>
> >> > > >>> > > > >> > > >> >>>
> >> > > >>> > > > >> > > >> >>> On Fri, Mar 7, 2014 at 3:22 PM, Joe Bowser
> >> > > >>> > > > >> > > >> >>> <bowserj@gmail.com<mailto:bowserj@gmail.com
> >>
> >> > > >>> > > > >> > wrote:
> >> > > >>> > > > >> > > >> >>>
> >> > > >>> > > > >> > > >> >>>> BTW: I committed it in my repo, not the
> main
> >> > > Apache
> >> > > >>> one.
> >> > > >>> > > > >> > > >> >>>>
> >> > > >>> > > > >> > > >> >>>> On Fri, Mar 7, 2014 at 3:21 PM, Joe Bowser
> >> > > >>> > > > >> > > >> >>>> <bowserj@gmail.com<mailto:
> bowserj@gmail.com>>
> >> > > >>> > > > >> > > wrote:
> >> > > >>> > > > >> > > >> >>>> > Hey
> >> > > >>> > > > >> > > >> >>>> >
> >> > > >>> > > > >> > > >> >>>> > I just committed some code based on their
> >> > > WebView
> >> > > >>> > > > >> > > >> >>>> > modifications that allows you to choose
> >> > > >>> > > > >> > > >> >>>> > your
> >> > > >>> renderer
> >> > > >>> > > > >> > > >> >>>> > in the
> >> > > >>> > > > >> > config file
> >> > > >>> > > > >> > > with this:
> >> > > >>> > > > >> > > >> >>>> >
> >> > > >>> > > > >> > > >> >>>> >     <preference name="webView"
> >> > > >>> > > > >> > > >> >>>> >
> >> > > >>> value="org.apache.cordova.engine.crosswalk.XWalkCordo
> >> > > >>> > > > >> > > >> >>>> > va
> >> > > >>> > > > >> > > >> >>>> > Web
> >> > > >>> > > > >> > > >> >>>> > View
> >> > > >>> > > > >> > > >> >>>> > " />
> >> > > >>> > > > >> > > >> >>>> >
> >> > > >>> > > > >> > > >> >>>> > You currently have to copy over the *.pak
> >> > > >>> > > > >> > > >> >>>> > file
> >> > > and
> >> > > >>> > > > >> > > >> >>>> > the jsapi from a Crosswalk Example
> project
> >> > > >>> > > > >> > > >> >>>> > to
> >> > > get
> >> > > >>> > > > >> > > >> >>>> > this to work.  The next thing that I'm
> >> > > >>> > > > >> > > >> >>>> > going
> >> > to
> >> > > do
> >> > > >>> is
> >> > > >>> > > > >> > > >> >>>> > figure out how to write this as a plugin
> >> > > >>> > > > >> > > >> >>>> > and
> >> > > have it
> >> > > >>> > > > >> > > >> >>>> > install on a default
> >> > > >>> > > > project.
> >> > > >>> > > > >> > > >> >>>> > Also, right now the bridge doesn't seem
> to
> >> > > work, and
> >> > > >>> > > > >> > > >> >>>> > I don't know why exactly.  That being
> said,
> >> > the
> >> > > >>> > > > >> > > >> fact
> >> > > >>> > > > >> > > >> >>>> > that I can choose which version of
> >> > > Chrome/Chromium
> >> > > >>> > > > >> > > >> >>>> > I'm running with
> >> > > >>> > > > >> > > >> a
> >> > > >>> > > > >> > > >> >>>> > single XML preference is HUGE.
> >> > > >>> > > > >> > > >> >>>> >
> >> > > >>> > > > >> > > >> >>>> > There's definitely a lot more work that
> >> > > >>> > > > >> > > >> >>>> > needs
> >> > > to be
> >> > > >>> > > > >> > > >> >>>> > done, but as
> >> > > >>> > > > >> > > >> long
> >> > > >>> > > > >> > > >> >>>> > as we have something that we can fit into
> >> > > >>> > > > >> > > >> >>>> > the
> >> > > >>> > > > >> > > >> >>>> > interface, we should
> >> > > >>> > > > >> > > >> be
> >> > > >>> > > > >> > > >> >>>> > able to put in things like GeckoView or
> >> > > >>> > > > >> > > >> >>>> > other
> >> > > third
> >> > > >>> > > > >> > > >> >>>> > party
> >> > > >>> > > > >> > renderers.
> >> > > >>> > > > >> > > >> >>>> > The nightmare of being stuck with
> bullshit
> >> > > WebView
> >> > > >>> > > > >> > > >> >>>> > bugs may soon be over.
> >> > > >>> > > > >> > > >> >>>> >
> >> > > >>> > > > >> > > >> >>>> > On Wed, Mar 5, 2014 at 8:59 PM, Michal
> >> > > >>> > > > >> > > >> >>>> > Mocny
> >> > > >>> > > > >> > > >> >>>> > <mmocny@chromium.org<mailto:
> mmocny@chromium.org>>
> >> > > >>> > > > >> > > >> >>>> wrote:
> >> > > >>> > > > >> > > >> >>>> >>
> >> > > >>> https://github.com/crosswalk-project/crosswalk-cordo
> >> > > >>> > > > >> > > >> >>>> >> va
> >> > > >>> > > > >> > > >> >>>> >> -an
> >> > > >>> > > > >> > > >> >>>> >> droi
> >> > > >>> > > > >> > > >> >>>> >> d
> >> > > >>> > > > >> > > >> >>>> >>
> >> > > >>> > > > >> > > >> >>>> >> First patch they landed, which claims to
> >> > > >>> > > > >> > > >> >>>> >> have
> >> > > min
> >> > > >>> > > > >> > > >> >>>> >> viable xwalk
> >> > > >>> > > > >> > > >> webview:
> >> > > >>> > > > >> > > >> >>>> >>
> >> > > >>> > > > >> > > >> >>>>
> >> > > >>> > > > >> > > >>
> >> > > >>> https://github.com/crosswalk-project/crosswalk-cordova-andro
> >> > > >>> > > > >> > > >> id
> >> > > >>> > > > >> > > >> /co
> >> > > >>> > > > >> > > >> mmit
> >> > > >>> > > > >> > > >> /a04dedeb0204e7542d190312c6ae70c795a26e04
> >> > > >>> > > > >> > > >> >>>> >>
> >> > > >>> > > > >> > > >> >>>> >>
> >> > > >>> > > > >> > > >> >>>> >> On Wed, Mar 5, 2014 at 11:37 PM, Michal
> >> > > >>> > > > >> > > >> >>>> >> Mocny
> >> > > >>> > > > >> > > >> >>>> >> <mmocny@chromium.org<mailto:
> mmocny@chromium.org>
> >> > > >>> > > > >> > > >> >
> >> > > >>> > > > >> > > >> >>>> wrote:
> >> > > >>> > > > >> > > >> >>>> >>
> >> > > >>> > > > >> > > >> >>>> >>> I haven't looked yet, but did you see:
> >> > > >>> > > > >> > > >> >>>> >>>
> >> > > >>> https://crosswalk-project.org/#wiki/crosswalk-cordo
> >> > > >>> > > > >> > > >> >>>> >>> va
> >> > > >>> > > > >> > > >> >>>> >>> -an
> >> > > >>> > > > >> > > >> >>>> >>> droi
> >> > > >>> > > > >> > > >> >>>> >>> d
> >> > > >>> > > > >> > > >> >>>> >>>
> >> > > >>> > > > >> > > >> >>>> >>> ?
> >> > > >>> > > > >> > > >> >>>> >>>
> >> > > >>> > > > >> > > >> >>>> >>>
> >> > > >>> > > > >> > > >> >>>> >>> On Wed, Mar 5, 2014 at 10:20 PM, Andrew
> >> > > Grieve <
> >> > > >>> > > > >> > > >> agrieve@chromium.org<mailto:
> agrieve@chromium.org>
> >> > > >>> > > > >> > > >> >>>> >wrote:
> >> > > >>> > > > >> > > >> >>>> >>>
> >> > > >>> > > > >> > > >> >>>> >>>> First - very excited that you're
> working
> >> > > >>> > > > >> > > >> >>>> >>>> on
> >> > > this!
> >> > > >>> > > > >> > > >> >>>> >>>>
> >> > > >>> > > > >> > > >> >>>> >>>> Had a quick look. Not sure there's
> much
> >> > > >>> > > > >> > > >> >>>> >>>> to
> >> > be
> >> > > >>> > gleaned
> >> > > >>> > > yet.
> >> > > >>> > > > >> > > >> >>>> >>>> Once
> >> > > >>> > > > >> > > >> you
> >> > > >>> > > > >> > > >> >>>> start
> >> > > >>> > > > >> > > >> >>>> >>>> in on hooking up x-walk's webview I
> >> > > >>> > > > >> > > >> >>>> >>>> think
> >> > it
> >> > > will
> >> > > >>> > > > >> > > >> >>>> >>>> become more
> >> > > >>> > > > >> > > >> obvious
> >> > > >>> > > > >> > > >> >>>> what
> >> > > >>> > > > >> > > >> >>>> >>>> the interface should look like. E.g.,
> >> > > >>> > > > >> > > >> >>>> >>>> does
> >> > > x-walk
> >> > > >>> > > > >> > > >> >>>> >>>> even have the
> >> > > >>> > > > >> > > >> >>>> concept of
> >> > > >>> > > > >> > > >> >>>> >>>> ChromeClient vs WebViewClient vs
> >> > > >>> > > > >> > > >> >>>> >>>> WebView?
> >> > > Also
> >> > > >>> > > > >> > > >> >>>> >>>> unsure whether the
> >> > > >>> > > > >> > > >> >>>> class
> >> > > >>> > > > >> > > >> >>>> >>>> should extend android.View as well as
> >> > > implement
> >> > > >>> > > > >> > > >> >>>> >>>> our
> >> > > >>> > > > >> > interface.
> >> > > >>> > > > >> > > >> E.g.
> >> > > >>> > > > >> > > >> >>>> >>>> alternative is to have a "getView()"
> >> > > >>> > > > >> > > >> >>>> >>>> method
> >> > > on
> >> > > >>> the
> >> > > >>> > > > >> > interface.
> >> > > >>> > > > >> > > >> Might
> >> > > >>> > > > >> > > >> >>>> help
> >> > > >>> > > > >> > > >> >>>> >>>> to
> >> > > >>> > > > >> > > >> >>>> >>>> cut down on file sizes, and API
> surface,
> >> > but
> >> > > >>> > > > >> > > >> >>>> >>>> again, I'm not too
> >> > > >>> > > > >> > > >> sure.
> >> > > >>> > > > >> > > >> >>>> >>>>
> >> > > >>> > > > >> > > >> >>>> >>>> I've been pretty hesitant to touch
> >> > > >>> > > > >> > > >> >>>> >>>> existing
> >> > > >>> > > > >> > > >> >>>> >>>> exposed members
> >> > > >>> > > > >> > > >> (e.g. the
> >> > > >>> > > > >> > > >> >>>> >>>> public fields you were referring to)
> >> > > >>> > > > >> > > >> >>>> >>>> since
> >> > > >>> > > > >> > > >> >>>> >>>> touching anything
> >> > > >>> > > > >> > > >> public
> >> > > >>> > > > >> > > >> >>>> could
> >> > > >>> > > > >> > > >> >>>> >>>> break plugins. That said, maybe now
> is a
> >> > good
> >> > > >>> time
> >> > > >>> > > > >> > > >> >>>> >>>> to @deprecate
> >> > > >>> > > > >> > > >> a
> >> > > >>> > > > >> > > >> >>>> bunch
> >> > > >>> > > > >> > > >> >>>> >>>> of
> >> > > >>> > > > >> > > >> >>>> >>>> them and either replace them with
> >> > > >>> > > > >> > > >> >>>> >>>> getters,
> >> > or
> >> > > >>> just
> >> > > >>> > > > >> > > >> >>>> >>>> declare them
> >> > > >>> > > > >> > > >> to be
> >> > > >>> > > > >> > > >> >>>> not
> >> > > >>> > > > >> > > >> >>>> >>>> exposed to plugins.
> >> > > >>> > > > >> > > >> >>>> >>>>
> >> > > >>> > > > >> > > >> >>>> >>>>
> >> > > >>> > > > >> > > >> >>>> >>>> On Wed, Mar 5, 2014 at 6:57 PM, Joe
> >> > > >>> > > > >> > > >> >>>> >>>> Bowser
> >> > > >>> > > > >> > > >> >>>> >>>> <bowserj@gmail.com<mailto:
> bowserj@gmail.com>>
> >> > > >>> > > > >> > > >> wrote:
> >> > > >>> > > > >> > > >> >>>> >>>>
> >> > > >>> > > > >> > > >> >>>> >>>> > So, after looking at the Crosswalk
> >> > > >>> > > > >> > > >> >>>> >>>> > code
> >> > > again,
> >> > > >>> > > > >> > > >> >>>> >>>> > I've decided to
> >> > > >>> > > > >> > > >> take
> >> > > >>> > > > >> > > >> >>>> a
> >> > > >>> > > > >> > > >> >>>> >>>> > quick stab at making things
> pluggable.
> >> > > >>> > > > >> > > >> >>>> >>>> > I
> >> > > don't
> >> > > >>> > > > >> > > >> >>>> >>>> > have a lot to
> >> > > >>> > > > >> > > >> show
> >> > > >>> > > > >> > > >> >>>> for
> >> > > >>> > > > >> > > >> >>>> >>>> > it, but with the help of Eclipse
> >> > > >>> > > > >> > > >> >>>> >>>> > (which
> >> > is
> >> > > why
> >> > > >>> > > > >> > > >> >>>> >>>> > the generated interfaces look so
> >> > > >>> > > > >> > > >> >>>> >>>> > screwed
> >> > > up), I
> >> > > >>> > > > >> > > >> >>>> >>>> > managed to create some
> >> > > >>> > > > >> > > >> interfaces
> >> > > >>> > > > >> > > >> >>>> so
> >> > > >>> > > > >> > > >> >>>> >>>> > we can start shoehorning in other
> >> > > >>> > > > >> > > >> >>>> >>>> > browser
> >> > > >>> > renderers.
> >> > > >>> > > > >> > > >> >>>> >>>> >
> >> > > >>> > > > >> > > >> >>>> >>>> >
> >> > > >>> > > > >> > > >>
> >> > > >>> https://github.com/infil00p/cordova-android/tree/pluggable_w
> >> > > >>> > > > >> > > >> eb
> >> > > >>> > > > >> > > >> vie
> >> > > >>> > > > >> > > >> w
> >> > > >>> > > > >> > > >> >>>> >>>> >
> >> > > >>> > > > >> > > >> >>>> >>>> > I'm going to probably start with
> >> > Crosswalk,
> >> > > >>> > > > >> > > >> >>>> >>>> > because it's
> >> > > >>> > > > >> > > >> probably
> >> > > >>> > > > >> > > >> >>>> the
> >> > > >>> > > > >> > > >> >>>> >>>> > most mature primary candidate in the
> >> > > Android
> >> > > >>> > > > >> > > >> >>>> >>>> > Third-Party
> >> > > >>> > > > >> > > >> WebView
> >> > > >>> > > > >> > > >> >>>> >>>> > thing, and I'm pretty sure the
> >> > > >>> > > > >> > > >> >>>> >>>> > GeckoView
> >> > > will
> >> > > >>> be
> >> > > >>> > > > >> > > >> >>>> >>>> > happening
> >> > > >>> > > > >> > > >> shortly
> >> > > >>> > > > >> > > >> >>>> >>>> > after.
> >> > > >>> > > > >> > > >> >>>> >>>> >
> >> > > >>> > > > >> > > >> >>>> >>>> > I don't know how this would work
> >> > > >>> > > > >> > > >> >>>> >>>> > w.r.t.
> >> > > the CLI
> >> > > >>> > > > >> > > >> >>>> >>>> > or our
> >> > > >>> > > > >> > > >> workflow at
> >> > > >>> > > > >> > > >> >>>> >>>> > all, but at the moment, I really
> just
> >> > want
> >> > > to
> >> > > >>> at
> >> > > >>> > > > >> > > >> >>>> >>>> > least start
> >> > > >>> > > > >> > > >> to have
> >> > > >>> > > > >> > > >> >>>> >>>> > some headway towards 4.x and
> PhoneGap
> >> > day.
> >> > > >>> > > > >> > > >> >>>> >>>> >
> >> > > >>> > > > >> > > >> >>>> >>>> > What do people think of this so far?
> >> > > >>> > > > >> > > >> >>>> >>>> > I'm
> >> > > going
> >> > > >>> > > > >> > > >> >>>> >>>> > to try to clean
> >> > > >>> > > > >> > > >> >>>> things
> >> > > >>> > > > >> > > >> >>>> >>>> > up a bit, since we've definitely
> done
> >> > > >>> > > > >> > > >> >>>> >>>> > a
> >> > > lot of
> >> > > >>> > > > >> > > >> >>>> >>>> > things that
> >> > > >>> > > > >> > > >> would
> >> > > >>> > > > >> > > >> >>>> make
> >> > > >>> > > > >> > > >> >>>> >>>> > first year CS profs freak the hell
> out
> >> > > (i.e.
> >> > > >>> > > > >> > > >> >>>> >>>> > public members in
> >> > > >>> > > > >> > > >> >>>> public
> >> > > >>> > > > >> > > >> >>>> >>>> > objects w.r.t. PluginManager).
> >> > > >>> > > > >> > > >> >>>> >>>> >
> >> > > >>> > > > >> > > >> >>>> >>>> > Thoughts?
> >> > > >>> > > > >> > > >> >>>> >>>> >
> >> > > >>> > > > >> > > >> >>>> >>>> > Joe
> >> > > >>> > > > >> > > >> >>>> >>>> >
> >> > > >>> > > > >> > > >> >>>> >>>>
> >> > > >>> > > > >> > > >> >>>> >>>
> >> > > >>> > > > >> > > >> >>>> >>>
> >> > > >>> > > > >> > > >> >>>>
> >> > > >>> > > > >> > > >>
> >> > > >>> > > > >> >
> >> > > >>> >
> >> > > >>>
> >> > >
> >> >
> >
> >
>
>

RE: [Android] Refactoring for different engines

["Hu, Ningxin" <ni...@intel.com>]

I am in China. 1:00 PM PST means 4:00 AM here :o.
Could you please schedule it a little bit later, say 4:00 or 5:00 PM PST? It will be highly appreciated.

Thanks,
-ningxin

From: brian.leroux@gmail.com [mailto:brian.leroux@gmail.com] On Behalf Of Brian LeRoux
Sent: Thursday, April 24, 2014 6:10 AM
To: Joe Bowser
Cc: dev@cordova.apache.org; Hu, Ningxin
Subject: Re: [Android] Refactoring for different engines

How does 1:00PST on Friday work for a hangout for everyone?

On Wed, Apr 23, 2014 at 2:36 PM, Joe Bowser <bo...@gmail.com>> wrote:
BTW: Here's my PoC for Mozilla so far.  It's very broken!

https://github.com/infil00p/MozillaView



On Wed, Apr 23, 2014 at 10:50 AM, Brian LeRoux <b@...@brian.io>> wrote:
> So I found a Moz hacker whom can help. what time on Fri do you guys want to
> do this?
>
>
> On Wed, Apr 23, 2014 at 10:31 AM, Ian Clelland <ic...@chromium.org>>
> wrote:
>>
>> I've managed to get this up and running now -- great work on this, Joe!
>>
>> Mobilespec runs on my N4, with 10 failing tests: 3 in contacts; 7 in
>> file-transfer. Otherwise, things seem to be working pretty well.
>>
>> I used a new build of Crosswalk, and found that the embedding API has
>> changed since the weekend (when Ningxin's patches applied). I've issued a
>> pull request at
>> https://github.com/infil00p/cordova-crosswalk-engine/pull/5for it --
>>
>> I'm not sure if there's a way to keep compatibility with last
>> week's Crosswalk, or if we'd even want to. (Ningxin, if you could take a
>> look at that PR and see if it makes sense, I'd appreciate it)
>>
>> Joe, I also had to patch the default constructor for XWalkCordovaWebView;
>> it wasn't creating its own client objects, so it got the default ones, and
>> most of the tests were failing because some component of the bridge wan't
>> working. https://github.com/infil00p/cordova-crosswalk-engine/pull/4 is
>> out
>> for that.
>>
>> Count me in for the hangout -- this is exciting stuff
>>
>> Ian
>>
>>
>> On Wed, Apr 23, 2014 at 10:26 AM, Brian LeRoux <b@...@brian.io>> wrote:
>>
>> > Yup I'll track em down
>> > On Apr 23, 2014 7:17 AM, "Andrew Grieve" <ag...@chromium.org>> wrote:
>> >
>> > > Does anyone have a contact at moz that we could invite?
>> > >
>> > > On Wed, Apr 23, 2014 at 10:09 AM, Andrew Grieve <ag...@chromium.org>>
>> > > wrote:
>> > > > Depends on their interest level I think. Faster we can get this out
>> > > > the door the better. If we need to delay for geckoview, then I don't
>> > > > think we should gate on it, just release it after.
>> > > >
>> > > > On Wed, Apr 23, 2014 at 3:01 AM, Tommy Williams <to...@devgeeks.org>>
>> > > wrote:
>> > > >> More engines, more better...
>> > > >> On 23 Apr 2014 16:32, "Joe Bowser" <bo...@gmail.com>> wrote:
>> > > >>
>> > > >>> Hey
>> > > >>>
>> > > >>> A Hangout would have to happen on Friday at the earliest.  It'd be
>> > > good if
>> > > >>> we could get someone from Mozilla on the hangout as well.  I
>> > > >>> haven't
>> > > gotten
>> > > >>> MozillaView (GeckoView with Cordova methods) fully working yet.
>> > > >>> For
>> > > some
>> > > >>> reason it's not rendering on the screen.
>> > > >>>
>> > > >>> Ideally it'd be cool to have at least two options when this
>> > > >>> feature
>> > > finally
>> > > >>> lands.
>> > > >>>
>> > > >>> What do other people think?
>> > > >>>
>> > > >>> Joe
>> > > >>> On 22 Apr 2014 20:06, "Hu, Ningxin" <ni...@intel.com>> wrote:
>> > > >>>
>> > > >>> > Joe,
>> > > >>> >
>> > > >>> > Thanks for your review and merge the PRs.
>> > > >>> >
>> > > >>> > To pluggable webview interest group:
>> > > >>> > Are we OK to setup a hangout this week for initial introduction
>> > > >>> > and
>> > > >>> > discussion of next steps?
>> > > >>> >
>> > > >>> > Thanks,
>> > > >>> > -ningxin
>> > > >>> >
>> > > >>> > > -----Original Message-----
>> > > >>> > > From: Hu, Ningxin [mailto:ningxin.hu@intel.com<ma...@intel.com>]
>> > > >>> > > Sent: Tuesday, April 22, 2014 4:04 PM
>> > > >>> > > To: dev@cordova.apache.org<ma...@cordova.apache.org>
>> > > >>> > > Subject: RE: [Android] Refactoring for different engines
>> > > >>> > >
>> > > >>> > > The PoC is great! Quite excited about the direction!
>> > > >>> > >
>> > > >>> > > I've sent a PR to update the cordova-crosswalk-engine to
>> > > >>> > > latest
>> > > >>> crosswalk
>> > > >>> > > embedding API. It works with xwalk_core_library at 6.35.124.0.
>> > > >>> > >
>> > > >>> > > I've also changed the CordovaWebView interface slightly
>> > > >>> > > (adding
>> > > >>> > getView() API)
>> > > >>> > > to allow XWalkCordovaWebView to composite a XWalkView instead
>> > > >>> > > of
>> > > >>> > extending
>> > > >>> > > it. It resolves some API naming issues for XWalkView case.
>> > > >>> > >
>> > > >>> > > Please review them at:
>> > > >>> > > https://github.com/infil00p/cordova-crosswalk-engine/pull/3
>> > > >>> > > https://github.com/infil00p/cordova-android/pull/2
>> > > >>> > >
>> > > >>> > > Thanks,
>> > > >>> > > -ningxin
>> > > >>> > >
>> > > >>> > > > -----Original Message-----
>> > > >>> > > > From: Joe Bowser [mailto:bowserj@gmail.com<ma...@gmail.com>]
>> > > >>> > > > Sent: Friday, April 11, 2014 12:45 AM
>> > > >>> > > > To: dev
>> > > >>> > > > Subject: Re: [Android] Refactoring for different engines
>> > > >>> > > >
>> > > >>> > > > Yeah, I'd be cool with setting up a hangout.  Everyone
>> > > >>> > > > should
>> > > take a
>> > > >>> > > > look at the PoC, I've basically distilled it down to four or
>> > five
>> > > >>> > > > classes so far, but with some work, we may be able to get it
>> > > down to
>> > > >>> > > > three.  Due to legacy, we're pretty stuck with the Android
>> > > WebView
>> > > >>> API
>> > > >>> > calls,
>> > > >>> > > but these can probably be modified.
>> > > >>> > > >
>> > > >>> > > > It'd be good to get Mozilla people on the call as well,
>> > > >>> > > > since
>> > > they
>> > > >>> > > > have their WebView as well.
>> > > >>> > > >
>> > > >>> > > > On Thu, Apr 10, 2014 at 9:38 AM, Hu, Ningxin <
>> > > ningxin.hu@intel.com<ma...@intel.com>>
>> > > >>> > wrote:
>> > > >>> > > > > Hangout would be a good idea.
>> > > >>> > > > >
>> > > >>> > > > > FYI, I will be off next week. How about the week after
>> > > >>> > > > > next?
>> > > If it
>> > > >>> > > > > works, please
>> > > >>> > > > feel free to schedule one and count me in.
>> > > >>> > > > >
>> > > >>> > > > > Thanks,
>> > > >>> > > > > -ningxin
>> > > >>> > > > >
>> > > >>> > > > >> -----Original Message-----
>> > > >>> > > > >> From: mmocny@google.com<ma...@google.com> [mailto:mmocny@google.com<ma...@google.com>] On
>> > Behalf
>> > > Of
>> > > >>> > > > >> Michal Mocny
>> > > >>> > > > >> Sent: Tuesday, April 08, 2014 11:39 PM
>> > > >>> > > > >> To: dev
>> > > >>> > > > >> Subject: Re: [Android] Refactoring for different engines
>> > > >>> > > > >>
>> > > >>> > > > >> Would it be alright to set up a Hangout some time to
>> > introduce
>> > > >>> > everyone?
>> > > >>> > > > >>
>> > > >>> > > > >> Joe has been leading the effort here, but there are other
>> > > cordova
>> > > >>> > > > >> contributors for whom this is top priority.  It would be
>> > nice
>> > > if
>> > > >>> we
>> > > >>> > > > >> could all meet to say hello and make sure we are all
>> > > >>> > > > >> going
>> > in
>> > > the
>> > > >>> > > > >> right
>> > > >>> > > > direction.
>> > > >>> > > > >>
>> > > >>> > > > >> Quite exciting!
>> > > >>> > > > >>
>> > > >>> > > > >> -Michal
>> > > >>> > > > >>
>> > > >>> > > > >>
>> > > >>> > > > >> On Tue, Apr 8, 2014 at 10:56 AM, Hu, Ningxin <
>> > > >>> ningxin.hu@intel.com<ma...@intel.com>>
>> > > >>> > > wrote:
>> > > >>> > > > >>
>> > > >>> > > > >> > Joe, thanks for this. I am very excited.
>> > > >>> > > > >> >
>> > > >>> > > > >> > FYI. Crosswalk team is working on refactoring the
>> > > >>> > > > >> > WebView
>> > > API to
>> > > >>> > > > >> > support embedding usage better [1]. (Previously the
>> > > >>> > > > >> > layer
>> > > API
>> > > >>> was
>> > > >>> > > > >> > not exposed as public usage).
>> > > >>> > > > >> >
>> > > >>> > > > >> > I would like to review the PoC and work with you to get
>> > > >>> Crosswalk
>> > > >>> > > > >> > fits into the pluggable WebView architecture.
>> > > >>> > > > >> >
>> > > >>> > > > >> > Thanks,
>> > > >>> > > > >> > -ningxin
>> > > >>> > > > >> >
>> > > >>> > > > >> > > -----Original Message-----
>> > > >>> > > > >> > > From: Joe Bowser [mailto:bowserj@gmail.com<ma...@gmail.com>]
>> > > >>> > > > >> > > Sent: Wednesday, March 19, 2014 7:08 AM
>> > > >>> > > > >> > > To: dev
>> > > >>> > > > >> > > Subject: Re: [Android] Refactoring for different
>> > > >>> > > > >> > > engines
>> > > >>> > > > >> > >
>> > > >>> > > > >> > > Hey
>> > > >>> > > > >> > >
>> > > >>> > > > >> > > After debugging, I did some minor updates to the
>> > > >>> > > > >> > > plugin
>> > > >>> README.
>> > > >>> > > > >> > > It
>> > > >>> > > > >> > should be
>> > > >>> > > > >> > > easier to get this up and running, although there's
>> > still
>> > > the
>> > > >>> > > > >> > > issue of
>> > > >>> > > > >> > after-install
>> > > >>> > > > >> > > hooks and the relative path weirdness with the
>> > > >>> > > > >> > > Crosswalk
>> > > >>> > Library itself.
>> > > >>> > > > >> > >
>> > > >>> > > > >> > > It still doesn't support the CLI at all, but it
>> > > >>> > > > >> > > should
>> > be
>> > > >>> there
>> > > >>> > > > >> > > with the
>> > > >>> > > > >> > old flow.
>> > > >>> > > > >> > >
>> > > >>> > > > >> > > On Mon, Mar 17, 2014 at 1:14 PM, Michal Mocny
>> > > >>> > > > >> > > <mm...@chromium.org>>
>> > > >>> > > > >> > > wrote:
>> > > >>> > > > >> > > > (Sorry Joe, Googlers are down in California and way
>> > > busy.
>> > > >>> > > > >> > > > Will be back in a week.  Super excited about this,
>> > > though.)
>> > > >>> > > > >> > > >
>> > > >>> > > > >> > > > -Michal
>> > > >>> > > > >> > > >
>> > > >>> > > > >> > > >
>> > > >>> > > > >> > > > On Mon, Mar 17, 2014 at 2:53 PM, Joe Bowser
>> > > >>> > > > >> > > > <bo...@gmail.com>>
>> > > >>> > > > >> wrote:
>> > > >>> > > > >> > > >
>> > > >>> > > > >> > > >> Reviving this thread!
>> > > >>> > > > >> > > >>
>> > > >>> > > > >> > > >> Can other people look at this, and see if/when we
>> > > should
>> > > >>> > land this?
>> > > >>> > > > >> > > >> I know that I have to re-write the tests still,
>> > > >>> > > > >> > > >> but I
>> > > would
>> > > >>> > > > >> > > >> like some feedback before merging it in.  Also,
>> > > >>> > > > >> > > >> it'd
>> > be
>> > > >>> > > > >> > > >> super awesome if other people could try and make a
>> > > WebView
>> > > >>> > > > >> > > >> based on the interfaces and recommend which
>> > > >>> > > > >> > > >> methods
>> > > should
>> > > >>> > > > >> > > >> die.  I want to get this released in the next
>> > > >>> > > > >> > > >> month
>> > or
>> > > so,
>> > > >>> > > > >> > > >> so any time and feedback would be greatly
>> > appreciated.
>> > > >>> > > > >> > > >>
>> > > >>> > > > >> > > >> Thanks
>> > > >>> > > > >> > > >>
>> > > >>> > > > >> > > >> On Thu, Mar 13, 2014 at 3:50 PM, Joe Bowser
>> > > >>> > > > >> > > >> <bo...@gmail.com>>
>> > > >>> > > > >> > wrote:
>> > > >>> > > > >> > > >> > Hey, I created the following today to track
>> > > >>> > > > >> > > >> > various
>> > > >>> > > > >> > > >> > WebView
>> > > >>> > > > >> > progresses:
>> > > >>> > > > >> > > >> > https://issues.apache.org/jira/browse/CB-6246
>> > > >>> > > > >> > > >> >
>> > > >>> > > > >> > > >> > I also have this repo created.  The licensing is
>> > > ugly as
>> > > >>> > > > >> > > >> > all crap, but it's a Proof-Of-Concept:
>> > > >>> > > > >> > > >> >
>> > https://github.com/infil00p/cordova-crosswalk-engine
>> > > >>> > > > >> > > >> >
>> > > >>> > > > >> > > >> > If I can get some help getting plugman to just
>> > > >>> > > > >> > > >> > load
>> > > >>> > > > >> > > >> > Crosswalk, it'll
>> > > >>> > > > >> > > >> look hawt.
>> > > >>> > > > >> > > >> >
>> > > >>> > > > >> > > >> > BTW: We should probably get this ready to go
>> > > >>> > > > >> > > >> > into
>> > > Android
>> > > >>> > > > >> > > >> > in the next two months and deprecate the
>> > setProperty
>> > > >>> > > > >> > > >> > methods, since all properties should be
>> > > >>> > > > >> > > >> > preferences
>> > > in
>> > > >>> > config.xml
>> > > >>> > > now.
>> > > >>> > > > >> > > >> >
>> > > >>> > > > >> > > >> > On Mon, Mar 10, 2014 at 2:42 PM, Joe Bowser
>> > > >>> > > > >> > > >> > <bo...@gmail.com>>
>> > > >>> > > > >> > > wrote:
>> > > >>> > > > >> > > >> >> Perhaps. There would be additional benefits to
>> > this
>> > > >>> > > > >> > > >> >> approach, namely fixes being added to that
>> > platform
>> > > more
>> > > >>> > > > >> > > >> >> quickly.  I'll probably take a look at that
>> > > >>> > > > >> > > >> >> once I
>> > > have
>> > > >>> > > > >> > > >> >> Crosswalk
>> > > >>> > > > finalized.
>> > > >>> > > > >> > > >> >>
>> > > >>> > > > >> > > >> >> On Mon, Mar 10, 2014 at 9:49 AM, Brian LeRoux
>> > > >>> > > > >> > > >> >> <b@...@brian.io>>
>> > > >>> > > > wrote:
>> > > >>> > > > >> > > >> >>> this is great stuff
>> > > >>> > > > >> > > >> >>>
>> > > >>> > > > >> > > >> >>> do we think it may be possible to bring in
>> > > >>> > > > >> > > >> >>> amazon
>> > > >>> fireos
>> > > >>> > > > >> > > >> >>> stuff
>> > > >>> > > > >> > > >> eventually
>> > > >>> > > > >> > > >> >>> too?
>> > > >>> > > > >> > > >> >>>
>> > > >>> > > > >> > > >> >>>
>> > > >>> > > > >> > > >> >>> On Fri, Mar 7, 2014 at 3:22 PM, Joe Bowser
>> > > >>> > > > >> > > >> >>> <bo...@gmail.com>>
>> > > >>> > > > >> > wrote:
>> > > >>> > > > >> > > >> >>>
>> > > >>> > > > >> > > >> >>>> BTW: I committed it in my repo, not the main
>> > > Apache
>> > > >>> one.
>> > > >>> > > > >> > > >> >>>>
>> > > >>> > > > >> > > >> >>>> On Fri, Mar 7, 2014 at 3:21 PM, Joe Bowser
>> > > >>> > > > >> > > >> >>>> <bo...@gmail.com>>
>> > > >>> > > > >> > > wrote:
>> > > >>> > > > >> > > >> >>>> > Hey
>> > > >>> > > > >> > > >> >>>> >
>> > > >>> > > > >> > > >> >>>> > I just committed some code based on their
>> > > WebView
>> > > >>> > > > >> > > >> >>>> > modifications that allows you to choose
>> > > >>> > > > >> > > >> >>>> > your
>> > > >>> renderer
>> > > >>> > > > >> > > >> >>>> > in the
>> > > >>> > > > >> > config file
>> > > >>> > > > >> > > with this:
>> > > >>> > > > >> > > >> >>>> >
>> > > >>> > > > >> > > >> >>>> >     <preference name="webView"
>> > > >>> > > > >> > > >> >>>> >
>> > > >>> value="org.apache.cordova.engine.crosswalk.XWalkCordo
>> > > >>> > > > >> > > >> >>>> > va
>> > > >>> > > > >> > > >> >>>> > Web
>> > > >>> > > > >> > > >> >>>> > View
>> > > >>> > > > >> > > >> >>>> > " />
>> > > >>> > > > >> > > >> >>>> >
>> > > >>> > > > >> > > >> >>>> > You currently have to copy over the *.pak
>> > > >>> > > > >> > > >> >>>> > file
>> > > and
>> > > >>> > > > >> > > >> >>>> > the jsapi from a Crosswalk Example project
>> > > >>> > > > >> > > >> >>>> > to
>> > > get
>> > > >>> > > > >> > > >> >>>> > this to work.  The next thing that I'm
>> > > >>> > > > >> > > >> >>>> > going
>> > to
>> > > do
>> > > >>> is
>> > > >>> > > > >> > > >> >>>> > figure out how to write this as a plugin
>> > > >>> > > > >> > > >> >>>> > and
>> > > have it
>> > > >>> > > > >> > > >> >>>> > install on a default
>> > > >>> > > > project.
>> > > >>> > > > >> > > >> >>>> > Also, right now the bridge doesn't seem to
>> > > work, and
>> > > >>> > > > >> > > >> >>>> > I don't know why exactly.  That being said,
>> > the
>> > > >>> > > > >> > > >> fact
>> > > >>> > > > >> > > >> >>>> > that I can choose which version of
>> > > Chrome/Chromium
>> > > >>> > > > >> > > >> >>>> > I'm running with
>> > > >>> > > > >> > > >> a
>> > > >>> > > > >> > > >> >>>> > single XML preference is HUGE.
>> > > >>> > > > >> > > >> >>>> >
>> > > >>> > > > >> > > >> >>>> > There's definitely a lot more work that
>> > > >>> > > > >> > > >> >>>> > needs
>> > > to be
>> > > >>> > > > >> > > >> >>>> > done, but as
>> > > >>> > > > >> > > >> long
>> > > >>> > > > >> > > >> >>>> > as we have something that we can fit into
>> > > >>> > > > >> > > >> >>>> > the
>> > > >>> > > > >> > > >> >>>> > interface, we should
>> > > >>> > > > >> > > >> be
>> > > >>> > > > >> > > >> >>>> > able to put in things like GeckoView or
>> > > >>> > > > >> > > >> >>>> > other
>> > > third
>> > > >>> > > > >> > > >> >>>> > party
>> > > >>> > > > >> > renderers.
>> > > >>> > > > >> > > >> >>>> > The nightmare of being stuck with bullshit
>> > > WebView
>> > > >>> > > > >> > > >> >>>> > bugs may soon be over.
>> > > >>> > > > >> > > >> >>>> >
>> > > >>> > > > >> > > >> >>>> > On Wed, Mar 5, 2014 at 8:59 PM, Michal
>> > > >>> > > > >> > > >> >>>> > Mocny
>> > > >>> > > > >> > > >> >>>> > <mm...@chromium.org>>
>> > > >>> > > > >> > > >> >>>> wrote:
>> > > >>> > > > >> > > >> >>>> >>
>> > > >>> https://github.com/crosswalk-project/crosswalk-cordo
>> > > >>> > > > >> > > >> >>>> >> va
>> > > >>> > > > >> > > >> >>>> >> -an
>> > > >>> > > > >> > > >> >>>> >> droi
>> > > >>> > > > >> > > >> >>>> >> d
>> > > >>> > > > >> > > >> >>>> >>
>> > > >>> > > > >> > > >> >>>> >> First patch they landed, which claims to
>> > > >>> > > > >> > > >> >>>> >> have
>> > > min
>> > > >>> > > > >> > > >> >>>> >> viable xwalk
>> > > >>> > > > >> > > >> webview:
>> > > >>> > > > >> > > >> >>>> >>
>> > > >>> > > > >> > > >> >>>>
>> > > >>> > > > >> > > >>
>> > > >>> https://github.com/crosswalk-project/crosswalk-cordova-andro
>> > > >>> > > > >> > > >> id
>> > > >>> > > > >> > > >> /co
>> > > >>> > > > >> > > >> mmit
>> > > >>> > > > >> > > >> /a04dedeb0204e7542d190312c6ae70c795a26e04
>> > > >>> > > > >> > > >> >>>> >>
>> > > >>> > > > >> > > >> >>>> >>
>> > > >>> > > > >> > > >> >>>> >> On Wed, Mar 5, 2014 at 11:37 PM, Michal
>> > > >>> > > > >> > > >> >>>> >> Mocny
>> > > >>> > > > >> > > >> >>>> >> <mm...@chromium.org>
>> > > >>> > > > >> > > >> >
>> > > >>> > > > >> > > >> >>>> wrote:
>> > > >>> > > > >> > > >> >>>> >>
>> > > >>> > > > >> > > >> >>>> >>> I haven't looked yet, but did you see:
>> > > >>> > > > >> > > >> >>>> >>>
>> > > >>> https://crosswalk-project.org/#wiki/crosswalk-cordo
>> > > >>> > > > >> > > >> >>>> >>> va
>> > > >>> > > > >> > > >> >>>> >>> -an
>> > > >>> > > > >> > > >> >>>> >>> droi
>> > > >>> > > > >> > > >> >>>> >>> d
>> > > >>> > > > >> > > >> >>>> >>>
>> > > >>> > > > >> > > >> >>>> >>> ?
>> > > >>> > > > >> > > >> >>>> >>>
>> > > >>> > > > >> > > >> >>>> >>>
>> > > >>> > > > >> > > >> >>>> >>> On Wed, Mar 5, 2014 at 10:20 PM, Andrew
>> > > Grieve <
>> > > >>> > > > >> > > >> agrieve@chromium.org<ma...@chromium.org>
>> > > >>> > > > >> > > >> >>>> >wrote:
>> > > >>> > > > >> > > >> >>>> >>>
>> > > >>> > > > >> > > >> >>>> >>>> First - very excited that you're working
>> > > >>> > > > >> > > >> >>>> >>>> on
>> > > this!
>> > > >>> > > > >> > > >> >>>> >>>>
>> > > >>> > > > >> > > >> >>>> >>>> Had a quick look. Not sure there's much
>> > > >>> > > > >> > > >> >>>> >>>> to
>> > be
>> > > >>> > gleaned
>> > > >>> > > yet.
>> > > >>> > > > >> > > >> >>>> >>>> Once
>> > > >>> > > > >> > > >> you
>> > > >>> > > > >> > > >> >>>> start
>> > > >>> > > > >> > > >> >>>> >>>> in on hooking up x-walk's webview I
>> > > >>> > > > >> > > >> >>>> >>>> think
>> > it
>> > > will
>> > > >>> > > > >> > > >> >>>> >>>> become more
>> > > >>> > > > >> > > >> obvious
>> > > >>> > > > >> > > >> >>>> what
>> > > >>> > > > >> > > >> >>>> >>>> the interface should look like. E.g.,
>> > > >>> > > > >> > > >> >>>> >>>> does
>> > > x-walk
>> > > >>> > > > >> > > >> >>>> >>>> even have the
>> > > >>> > > > >> > > >> >>>> concept of
>> > > >>> > > > >> > > >> >>>> >>>> ChromeClient vs WebViewClient vs
>> > > >>> > > > >> > > >> >>>> >>>> WebView?
>> > > Also
>> > > >>> > > > >> > > >> >>>> >>>> unsure whether the
>> > > >>> > > > >> > > >> >>>> class
>> > > >>> > > > >> > > >> >>>> >>>> should extend android.View as well as
>> > > implement
>> > > >>> > > > >> > > >> >>>> >>>> our
>> > > >>> > > > >> > interface.
>> > > >>> > > > >> > > >> E.g.
>> > > >>> > > > >> > > >> >>>> >>>> alternative is to have a "getView()"
>> > > >>> > > > >> > > >> >>>> >>>> method
>> > > on
>> > > >>> the
>> > > >>> > > > >> > interface.
>> > > >>> > > > >> > > >> Might
>> > > >>> > > > >> > > >> >>>> help
>> > > >>> > > > >> > > >> >>>> >>>> to
>> > > >>> > > > >> > > >> >>>> >>>> cut down on file sizes, and API surface,
>> > but
>> > > >>> > > > >> > > >> >>>> >>>> again, I'm not too
>> > > >>> > > > >> > > >> sure.
>> > > >>> > > > >> > > >> >>>> >>>>
>> > > >>> > > > >> > > >> >>>> >>>> I've been pretty hesitant to touch
>> > > >>> > > > >> > > >> >>>> >>>> existing
>> > > >>> > > > >> > > >> >>>> >>>> exposed members
>> > > >>> > > > >> > > >> (e.g. the
>> > > >>> > > > >> > > >> >>>> >>>> public fields you were referring to)
>> > > >>> > > > >> > > >> >>>> >>>> since
>> > > >>> > > > >> > > >> >>>> >>>> touching anything
>> > > >>> > > > >> > > >> public
>> > > >>> > > > >> > > >> >>>> could
>> > > >>> > > > >> > > >> >>>> >>>> break plugins. That said, maybe now is a
>> > good
>> > > >>> time
>> > > >>> > > > >> > > >> >>>> >>>> to @deprecate
>> > > >>> > > > >> > > >> a
>> > > >>> > > > >> > > >> >>>> bunch
>> > > >>> > > > >> > > >> >>>> >>>> of
>> > > >>> > > > >> > > >> >>>> >>>> them and either replace them with
>> > > >>> > > > >> > > >> >>>> >>>> getters,
>> > or
>> > > >>> just
>> > > >>> > > > >> > > >> >>>> >>>> declare them
>> > > >>> > > > >> > > >> to be
>> > > >>> > > > >> > > >> >>>> not
>> > > >>> > > > >> > > >> >>>> >>>> exposed to plugins.
>> > > >>> > > > >> > > >> >>>> >>>>
>> > > >>> > > > >> > > >> >>>> >>>>
>> > > >>> > > > >> > > >> >>>> >>>> On Wed, Mar 5, 2014 at 6:57 PM, Joe
>> > > >>> > > > >> > > >> >>>> >>>> Bowser
>> > > >>> > > > >> > > >> >>>> >>>> <bo...@gmail.com>>
>> > > >>> > > > >> > > >> wrote:
>> > > >>> > > > >> > > >> >>>> >>>>
>> > > >>> > > > >> > > >> >>>> >>>> > So, after looking at the Crosswalk
>> > > >>> > > > >> > > >> >>>> >>>> > code
>> > > again,
>> > > >>> > > > >> > > >> >>>> >>>> > I've decided to
>> > > >>> > > > >> > > >> take
>> > > >>> > > > >> > > >> >>>> a
>> > > >>> > > > >> > > >> >>>> >>>> > quick stab at making things pluggable.
>> > > >>> > > > >> > > >> >>>> >>>> > I
>> > > don't
>> > > >>> > > > >> > > >> >>>> >>>> > have a lot to
>> > > >>> > > > >> > > >> show
>> > > >>> > > > >> > > >> >>>> for
>> > > >>> > > > >> > > >> >>>> >>>> > it, but with the help of Eclipse
>> > > >>> > > > >> > > >> >>>> >>>> > (which
>> > is
>> > > why
>> > > >>> > > > >> > > >> >>>> >>>> > the generated interfaces look so
>> > > >>> > > > >> > > >> >>>> >>>> > screwed
>> > > up), I
>> > > >>> > > > >> > > >> >>>> >>>> > managed to create some
>> > > >>> > > > >> > > >> interfaces
>> > > >>> > > > >> > > >> >>>> so
>> > > >>> > > > >> > > >> >>>> >>>> > we can start shoehorning in other
>> > > >>> > > > >> > > >> >>>> >>>> > browser
>> > > >>> > renderers.
>> > > >>> > > > >> > > >> >>>> >>>> >
>> > > >>> > > > >> > > >> >>>> >>>> >
>> > > >>> > > > >> > > >>
>> > > >>> https://github.com/infil00p/cordova-android/tree/pluggable_w
>> > > >>> > > > >> > > >> eb
>> > > >>> > > > >> > > >> vie
>> > > >>> > > > >> > > >> w
>> > > >>> > > > >> > > >> >>>> >>>> >
>> > > >>> > > > >> > > >> >>>> >>>> > I'm going to probably start with
>> > Crosswalk,
>> > > >>> > > > >> > > >> >>>> >>>> > because it's
>> > > >>> > > > >> > > >> probably
>> > > >>> > > > >> > > >> >>>> the
>> > > >>> > > > >> > > >> >>>> >>>> > most mature primary candidate in the
>> > > Android
>> > > >>> > > > >> > > >> >>>> >>>> > Third-Party
>> > > >>> > > > >> > > >> WebView
>> > > >>> > > > >> > > >> >>>> >>>> > thing, and I'm pretty sure the
>> > > >>> > > > >> > > >> >>>> >>>> > GeckoView
>> > > will
>> > > >>> be
>> > > >>> > > > >> > > >> >>>> >>>> > happening
>> > > >>> > > > >> > > >> shortly
>> > > >>> > > > >> > > >> >>>> >>>> > after.
>> > > >>> > > > >> > > >> >>>> >>>> >
>> > > >>> > > > >> > > >> >>>> >>>> > I don't know how this would work
>> > > >>> > > > >> > > >> >>>> >>>> > w.r.t.
>> > > the CLI
>> > > >>> > > > >> > > >> >>>> >>>> > or our
>> > > >>> > > > >> > > >> workflow at
>> > > >>> > > > >> > > >> >>>> >>>> > all, but at the moment, I really just
>> > want
>> > > to
>> > > >>> at
>> > > >>> > > > >> > > >> >>>> >>>> > least start
>> > > >>> > > > >> > > >> to have
>> > > >>> > > > >> > > >> >>>> >>>> > some headway towards 4.x and PhoneGap
>> > day.
>> > > >>> > > > >> > > >> >>>> >>>> >
>> > > >>> > > > >> > > >> >>>> >>>> > What do people think of this so far?
>> > > >>> > > > >> > > >> >>>> >>>> > I'm
>> > > going
>> > > >>> > > > >> > > >> >>>> >>>> > to try to clean
>> > > >>> > > > >> > > >> >>>> things
>> > > >>> > > > >> > > >> >>>> >>>> > up a bit, since we've definitely done
>> > > >>> > > > >> > > >> >>>> >>>> > a
>> > > lot of
>> > > >>> > > > >> > > >> >>>> >>>> > things that
>> > > >>> > > > >> > > >> would
>> > > >>> > > > >> > > >> >>>> make
>> > > >>> > > > >> > > >> >>>> >>>> > first year CS profs freak the hell out
>> > > (i.e.
>> > > >>> > > > >> > > >> >>>> >>>> > public members in
>> > > >>> > > > >> > > >> >>>> public
>> > > >>> > > > >> > > >> >>>> >>>> > objects w.r.t. PluginManager).
>> > > >>> > > > >> > > >> >>>> >>>> >
>> > > >>> > > > >> > > >> >>>> >>>> > Thoughts?
>> > > >>> > > > >> > > >> >>>> >>>> >
>> > > >>> > > > >> > > >> >>>> >>>> > Joe
>> > > >>> > > > >> > > >> >>>> >>>> >
>> > > >>> > > > >> > > >> >>>> >>>>
>> > > >>> > > > >> > > >> >>>> >>>
>> > > >>> > > > >> > > >> >>>> >>>
>> > > >>> > > > >> > > >> >>>>
>> > > >>> > > > >> > > >>
>> > > >>> > > > >> >
>> > > >>> >
>> > > >>>
>> > >
>> >
>
>

Re: [Android] Refactoring for different engines

[Ian Clelland <ic...@chromium.org>]

That works for me

On Wednesday, April 23, 2014, Joe Bowser <bo...@gmail.com> wrote:

> Sounds good
> On Apr 23, 2014 3:10 PM, "Brian LeRoux" <b...@brian.io> wrote:
>
> > How does 1:00PST on Friday work for a hangout for everyone?
> >
> >
> > On Wed, Apr 23, 2014 at 2:36 PM, Joe Bowser <bo...@gmail.com> wrote:
> >
> >> BTW: Here's my PoC for Mozilla so far.  It's very broken!
> >>
> >> https://github.com/infil00p/MozillaView
> >>
> >>
> >>
> >> On Wed, Apr 23, 2014 at 10:50 AM, Brian LeRoux <b...@brian.io> wrote:
> >> > So I found a Moz hacker whom can help. what time on Fri do you guys
> >> want to
> >> > do this?
> >> >
> >> >
> >> > On Wed, Apr 23, 2014 at 10:31 AM, Ian Clelland <
> iclelland@chromium.org>
> >> > wrote:
> >> >>
> >> >> I've managed to get this up and running now -- great work on this,
> Joe!
> >> >>
> >> >> Mobilespec runs on my N4, with 10 failing tests: 3 in contacts; 7 in
> >> >> file-transfer. Otherwise, things seem to be working pretty well.
> >> >>
> >> >> I used a new build of Crosswalk, and found that the embedding API has
> >> >> changed since the weekend (when Ningxin's patches applied). I've
> >> issued a
> >> >> pull request at
> >> >> https://github.com/infil00p/cordova-crosswalk-engine/pull/5for it --
> >> >>
> >> >> I'm not sure if there's a way to keep compatibility with last
> >> >> week's Crosswalk, or if we'd even want to. (Ningxin, if you could
> take
> >> a
> >> >> look at that PR and see if it makes sense, I'd appreciate it)
> >> >>
> >> >> Joe, I also had to patch the default constructor for
> >> XWalkCordovaWebView;
> >> >> it wasn't creating its own client objects, so it got the default
> ones,
> >> and
> >> >> most of the tests were failing because some component of the bridge
> >> wan't
> >> >> working.
> https://github.com/infil00p/cordova-crosswalk-engine/pull/4is
> >> >> out
> >> >> for that.
> >> >>
> >> >> Count me in for the hangout -- this is exciting stuff
> >> >>
> >> >> Ian
> >> >>
> >> >>
> >> >> On Wed, Apr 23, 2014 at 10:26 AM, Brian LeRoux <b...@brian.io> wrote:
> >> >>
> >> >> > Yup I'll track em down
> >> >> > On Apr 23, 2014 7:17 AM, "Andrew Grieve" <ag...@chromium.org>
> >> wrote:
> >> >> >
> >> >> > > Does anyone have a contact at moz that we could invite?
> >> >> > >
> >> >> > > On Wed, Apr 23, 2014 at 10:09 AM, Andrew Grieve <
> >> agrieve@chromium.org>
> >> >> > > wrote:
> >> >> > > > Depends on their interest level I think. Faster we can get this
> >> out
> >> >> > > > the door the better. If we need to delay for geckoview, then I
> >> don't
> >> >> > > > think we should gate on it, just release it after.
> >> >> > > >
> >> >> > > > On Wed, Apr 23, 2014 at 3:01 AM, Tommy Williams <
> >> tommy@devgeeks.org>
> >> >> > > wrote:
> >> >> > > >> More engines, more better...
> >> >> > > >> On 23 Apr 2014 16:32, "Joe Bowser" <bo...@gmail.com> wrote:
> >> >> > > >>
> >> >> > > >>> Hey
> >> >> > > >>>
> >> >> > > >>> A Hangout would have t

Re: [Android] Refactoring for different engines

[Joe Bowser <bo...@gmail.com>]

Sounds good
On Apr 23, 2014 3:10 PM, "Brian LeRoux" <b...@brian.io> wrote:

> How does 1:00PST on Friday work for a hangout for everyone?
>
>
> On Wed, Apr 23, 2014 at 2:36 PM, Joe Bowser <bo...@gmail.com> wrote:
>
>> BTW: Here's my PoC for Mozilla so far.  It's very broken!
>>
>> https://github.com/infil00p/MozillaView
>>
>>
>>
>> On Wed, Apr 23, 2014 at 10:50 AM, Brian LeRoux <b...@brian.io> wrote:
>> > So I found a Moz hacker whom can help. what time on Fri do you guys
>> want to
>> > do this?
>> >
>> >
>> > On Wed, Apr 23, 2014 at 10:31 AM, Ian Clelland <ic...@chromium.org>
>> > wrote:
>> >>
>> >> I've managed to get this up and running now -- great work on this, Joe!
>> >>
>> >> Mobilespec runs on my N4, with 10 failing tests: 3 in contacts; 7 in
>> >> file-transfer. Otherwise, things seem to be working pretty well.
>> >>
>> >> I used a new build of Crosswalk, and found that the embedding API has
>> >> changed since the weekend (when Ningxin's patches applied). I've
>> issued a
>> >> pull request at
>> >> https://github.com/infil00p/cordova-crosswalk-engine/pull/5for it --
>> >>
>> >> I'm not sure if there's a way to keep compatibility with last
>> >> week's Crosswalk, or if we'd even want to. (Ningxin, if you could take
>> a
>> >> look at that PR and see if it makes sense, I'd appreciate it)
>> >>
>> >> Joe, I also had to patch the default constructor for
>> XWalkCordovaWebView;
>> >> it wasn't creating its own client objects, so it got the default ones,
>> and
>> >> most of the tests were failing because some component of the bridge
>> wan't
>> >> working. https://github.com/infil00p/cordova-crosswalk-engine/pull/4is
>> >> out
>> >> for that.
>> >>
>> >> Count me in for the hangout -- this is exciting stuff
>> >>
>> >> Ian
>> >>
>> >>
>> >> On Wed, Apr 23, 2014 at 10:26 AM, Brian LeRoux <b...@brian.io> wrote:
>> >>
>> >> > Yup I'll track em down
>> >> > On Apr 23, 2014 7:17 AM, "Andrew Grieve" <ag...@chromium.org>
>> wrote:
>> >> >
>> >> > > Does anyone have a contact at moz that we could invite?
>> >> > >
>> >> > > On Wed, Apr 23, 2014 at 10:09 AM, Andrew Grieve <
>> agrieve@chromium.org>
>> >> > > wrote:
>> >> > > > Depends on their interest level I think. Faster we can get this
>> out
>> >> > > > the door the better. If we need to delay for geckoview, then I
>> don't
>> >> > > > think we should gate on it, just release it after.
>> >> > > >
>> >> > > > On Wed, Apr 23, 2014 at 3:01 AM, Tommy Williams <
>> tommy@devgeeks.org>
>> >> > > wrote:
>> >> > > >> More engines, more better...
>> >> > > >> On 23 Apr 2014 16:32, "Joe Bowser" <bo...@gmail.com> wrote:
>> >> > > >>
>> >> > > >>> Hey
>> >> > > >>>
>> >> > > >>> A Hangout would have to happen on Friday at the earliest.
>>  It'd be
>> >> > > good if
>> >> > > >>> we could get someone from Mozilla on the hangout as well.  I
>> >> > > >>> haven't
>> >> > > gotten
>> >> > > >>> MozillaView (GeckoView with Cordova methods) fully working yet.
>> >> > > >>> For
>> >> > > some
>> >> > > >>> reason it's not rendering on the screen.
>> >> > > >>>
>> >> > > >>> Ideally it'd be cool to have at least two options when this
>> >> > > >>> feature
>> >> > > finally
>> >> > > >>> lands.
>> >> > > >>>
>> >> > > >>> What do other people think?
>> >> > > >>>
>> >> > > >>> Joe
>> >> > > >>> On 22 Apr 2014 20:06, "Hu, Ningxin" <ni...@intel.com>
>> wrote:
>> >> > > >>>
>> >> > > >>> > Joe,
>> >> > > >>> >
>> >> > > >>> > Thanks for your review and merge the PRs.
>> >> > > >>> >
>> >> > > >>> > To pluggable webview interest group:
>> >> > > >>> > Are we OK to setup a hangout this week for initial
>> introduction
>> >> > > >>> > and
>> >> > > >>> > discussion of next steps?
>> >> > > >>> >
>> >> > > >>> > Thanks,
>> >> > > >>> > -ningxin
>> >> > > >>> >
>> >> > > >>> > > -----Original Message-----
>> >> > > >>> > > From: Hu, Ningxin [mailto:ningxin.hu@intel.com]
>> >> > > >>> > > Sent: Tuesday, April 22, 2014 4:04 PM
>> >> > > >>> > > To: dev@cordova.apache.org
>> >> > > >>> > > Subject: RE: [Android] Refactoring for different engines
>> >> > > >>> > >
>> >> > > >>> > > The PoC is great! Quite excited about the direction!
>> >> > > >>> > >
>> >> > > >>> > > I've sent a PR to update the cordova-crosswalk-engine to
>> >> > > >>> > > latest
>> >> > > >>> crosswalk
>> >> > > >>> > > embedding API. It works with xwalk_core_library at
>> 6.35.124.0.
>> >> > > >>> > >
>> >> > > >>> > > I've also changed the CordovaWebView interface slightly
>> >> > > >>> > > (adding
>> >> > > >>> > getView() API)
>> >> > > >>> > > to allow XWalkCordovaWebView to composite a XWalkView
>> instead
>> >> > > >>> > > of
>> >> > > >>> > extending
>> >> > > >>> > > it. It resolves some API naming issues for XWalkView case.
>> >> > > >>> > >
>> >> > > >>> > > Please review them at:
>> >> > > >>> > >
>> https://github.com/infil00p/cordova-crosswalk-engine/pull/3
>> >> > > >>> > > https://github.com/infil00p/cordova-android/pull/2
>> >> > > >>> > >
>> >> > > >>> > > Thanks,
>> >> > > >>> > > -ningxin
>> >> > > >>> > >
>> >> > > >>> > > > -----Original Message-----
>> >> > > >>> > > > From: Joe Bowser [mailto:bowserj@gmail.com]
>> >> > > >>> > > > Sent: Friday, April 11, 2014 12:45 AM
>> >> > > >>> > > > To: dev
>> >> > > >>> > > > Subject: Re: [Android] Refactoring for different engines
>> >> > > >>> > > >
>> >> > > >>> > > > Yeah, I'd be cool with setting up a hangout.  Everyone
>> >> > > >>> > > > should
>> >> > > take a
>> >> > > >>> > > > look at the PoC, I've basically distilled it down to
>> four or
>> >> > five
>> >> > > >>> > > > classes so far, but with some work, we may be able to
>> get it
>> >> > > down to
>> >> > > >>> > > > three.  Due to legacy, we're pretty stuck with the
>> Android
>> >> > > WebView
>> >> > > >>> API
>> >> > > >>> > calls,
>> >> > > >>> > > but these can probably be modified.
>> >> > > >>> > > >
>> >> > > >>> > > > It'd be good to get Mozilla people on the call as well,
>> >> > > >>> > > > since
>> >> > > they
>> >> > > >>> > > > have their WebView as well.
>> >> > > >>> > > >
>> >> > > >>> > > > On Thu, Apr 10, 2014 at 9:38 AM, Hu, Ningxin <
>> >> > > ningxin.hu@intel.com>
>> >> > > >>> > wrote:
>> >> > > >>> > > > > Hangout would be a good idea.
>> >> > > >>> > > > >
>> >> > > >>> > > > > FYI, I will be off next week. How about the week after
>> >> > > >>> > > > > next?
>> >> > > If it
>> >> > > >>> > > > > works, please
>> >> > > >>> > > > feel free to schedule one and count me in.
>> >> > > >>> > > > >
>> >> > > >>> > > > > Thanks,
>> >> > > >>> > > > > -ningxin
>> >> > > >>> > > > >
>> >> > > >>> > > > >> -----Original Message-----
>> >> > > >>> > > > >> From: mmocny@google.com [mailto:mmocny@google.com] On
>> >> > Behalf
>> >> > > Of
>> >> > > >>> > > > >> Michal Mocny
>> >> > > >>> > > > >> Sent: Tuesday, April 08, 2014 11:39 PM
>> >> > > >>> > > > >> To: dev
>> >> > > >>> > > > >> Subject: Re: [Android] Refactoring for different
>> engines
>> >> > > >>> > > > >>
>> >> > > >>> > > > >> Would it be alright to set up a Hangout some time to
>> >> > introduce
>> >> > > >>> > everyone?
>> >> > > >>> > > > >>
>> >> > > >>> > > > >> Joe has been leading the effort here, but there are
>> other
>> >> > > cordova
>> >> > > >>> > > > >> contributors for whom this is top priority.  It would
>> be
>> >> > nice
>> >> > > if
>> >> > > >>> we
>> >> > > >>> > > > >> could all meet to say hello and make sure we are all
>> >> > > >>> > > > >> going
>> >> > in
>> >> > > the
>> >> > > >>> > > > >> right
>> >> > > >>> > > > direction.
>> >> > > >>> > > > >>
>> >> > > >>> > > > >> Quite exciting!
>> >> > > >>> > > > >>
>> >> > > >>> > > > >> -Michal
>> >> > > >>> > > > >>
>> >> > > >>> > > > >>
>> >> > > >>> > > > >> On Tue, Apr 8, 2014 at 10:56 AM, Hu, Ningxin <
>> >> > > >>> ningxin.hu@intel.com>
>> >> > > >>> > > wrote:
>> >> > > >>> > > > >>
>> >> > > >>> > > > >> > Joe, thanks for this. I am very excited.
>> >> > > >>> > > > >> >
>> >> > > >>> > > > >> > FYI. Crosswalk team is working on refactoring the
>> >> > > >>> > > > >> > WebView
>> >> > > API to
>> >> > > >>> > > > >> > support embedding usage better [1]. (Previously the
>> >> > > >>> > > > >> > layer
>> >> > > API
>> >> > > >>> was
>> >> > > >>> > > > >> > not exposed as public usage).
>> >> > > >>> > > > >> >
>> >> > > >>> > > > >> > I would like to review the PoC and work with you to
>> get
>> >> > > >>> Crosswalk
>> >> > > >>> > > > >> > fits into the pluggable WebView architecture.
>> >> > > >>> > > > >> >
>> >> > > >>> > > > >> > Thanks,
>> >> > > >>> > > > >> > -ningxin
>> >> > > >>> > > > >> >
>> >> > > >>> > > > >> > > -----Original Message-----
>> >> > > >>> > > > >> > > From: Joe Bowser [mailto:bowserj@gmail.com]
>> >> > > >>> > > > >> > > Sent: Wednesday, March 19, 2014 7:08 AM
>> >> > > >>> > > > >> > > To: dev
>> >> > > >>> > > > >> > > Subject: Re: [Android] Refactoring for different
>> >> > > >>> > > > >> > > engines
>> >> > > >>> > > > >> > >
>> >> > > >>> > > > >> > > Hey
>> >> > > >>> > > > >> > >
>> >> > > >>> > > > >> > > After debugging, I did some minor updates to the
>> >> > > >>> > > > >> > > plugin
>> >> > > >>> README.
>> >> > > >>> > > > >> > > It
>> >> > > >>> > > > >> > should be
>> >> > > >>> > > > >> > > easier to get this up and running, although
>> there's
>> >> > still
>> >> > > the
>> >> > > >>> > > > >> > > issue of
>> >> > > >>> > > > >> > after-install
>> >> > > >>> > > > >> > > hooks and the relative path weirdness with the
>> >> > > >>> > > > >> > > Crosswalk
>> >> > > >>> > Library itself.
>> >> > > >>> > > > >> > >
>> >> > > >>> > > > >> > > It still doesn't support the CLI at all, but it
>> >> > > >>> > > > >> > > should
>> >> > be
>> >> > > >>> there
>> >> > > >>> > > > >> > > with the
>> >> > > >>> > > > >> > old flow.
>> >> > > >>> > > > >> > >
>> >> > > >>> > > > >> > > On Mon, Mar 17, 2014 at 1:14 PM, Michal Mocny
>> >> > > >>> > > > >> > > <mm...@chromium.org>
>> >> > > >>> > > > >> > > wrote:
>> >> > > >>> > > > >> > > > (Sorry Joe, Googlers are down in California and
>> way
>> >> > > busy.
>> >> > > >>> > > > >> > > > Will be back in a week.  Super excited about
>> this,
>> >> > > though.)
>> >> > > >>> > > > >> > > >
>> >> > > >>> > > > >> > > > -Michal
>> >> > > >>> > > > >> > > >
>> >> > > >>> > > > >> > > >
>> >> > > >>> > > > >> > > > On Mon, Mar 17, 2014 at 2:53 PM, Joe Bowser
>> >> > > >>> > > > >> > > > <bo...@gmail.com>
>> >> > > >>> > > > >> wrote:
>> >> > > >>> > > > >> > > >
>> >> > > >>> > > > >> > > >> Reviving this thread!
>> >> > > >>> > > > >> > > >>
>> >> > > >>> > > > >> > > >> Can other people look at this, and see if/when
>> we
>> >> > > should
>> >> > > >>> > land this?
>> >> > > >>> > > > >> > > >> I know that I have to re-write the tests still,
>> >> > > >>> > > > >> > > >> but I
>> >> > > would
>> >> > > >>> > > > >> > > >> like some feedback before merging it in.  Also,
>> >> > > >>> > > > >> > > >> it'd
>> >> > be
>> >> > > >>> > > > >> > > >> super awesome if other people could try and
>> make a
>> >> > > WebView
>> >> > > >>> > > > >> > > >> based on the interfaces and recommend which
>> >> > > >>> > > > >> > > >> methods
>> >> > > should
>> >> > > >>> > > > >> > > >> die.  I want to get this released in the next
>> >> > > >>> > > > >> > > >> month
>> >> > or
>> >> > > so,
>> >> > > >>> > > > >> > > >> so any time and feedback would be greatly
>> >> > appreciated.
>> >> > > >>> > > > >> > > >>
>> >> > > >>> > > > >> > > >> Thanks
>> >> > > >>> > > > >> > > >>
>> >> > > >>> > > > >> > > >> On Thu, Mar 13, 2014 at 3:50 PM, Joe Bowser
>> >> > > >>> > > > >> > > >> <bo...@gmail.com>
>> >> > > >>> > > > >> > wrote:
>> >> > > >>> > > > >> > > >> > Hey, I created the following today to track
>> >> > > >>> > > > >> > > >> > various
>> >> > > >>> > > > >> > > >> > WebView
>> >> > > >>> > > > >> > progresses:
>> >> > > >>> > > > >> > > >> >
>> https://issues.apache.org/jira/browse/CB-6246
>> >> > > >>> > > > >> > > >> >
>> >> > > >>> > > > >> > > >> > I also have this repo created.  The
>> licensing is
>> >> > > ugly as
>> >> > > >>> > > > >> > > >> > all crap, but it's a Proof-Of-Concept:
>> >> > > >>> > > > >> > > >> >
>> >> > https://github.com/infil00p/cordova-crosswalk-engine
>> >> > > >>> > > > >> > > >> >
>> >> > > >>> > > > >> > > >> > If I can get some help getting plugman to
>> just
>> >> > > >>> > > > >> > > >> > load
>> >> > > >>> > > > >> > > >> > Crosswalk, it'll
>> >> > > >>> > > > >> > > >> look hawt.
>> >> > > >>> > > > >> > > >> >
>> >> > > >>> > > > >> > > >> > BTW: We should probably get this ready to go
>> >> > > >>> > > > >> > > >> > into
>> >> > > Android
>> >> > > >>> > > > >> > > >> > in the next two months and deprecate the
>> >> > setProperty
>> >> > > >>> > > > >> > > >> > methods, since all properties should be
>> >> > > >>> > > > >> > > >> > preferences
>> >> > > in
>> >> > > >>> > config.xml
>> >> > > >>> > > now.
>> >> > > >>> > > > >> > > >> >
>> >> > > >>> > > > >> > > >> > On Mon, Mar 10, 2014 at 2:42 PM, Joe Bowser
>> >> > > >>> > > > >> > > >> > <bo...@gmail.com>
>> >> > > >>> > > > >> > > wrote:
>> >> > > >>> > > > >> > > >> >> Perhaps. There would be additional benefits
>> to
>> >> > this
>> >> > > >>> > > > >> > > >> >> approach, namely fixes being added to that
>> >> > platform
>> >> > > more
>> >> > > >>> > > > >> > > >> >> quickly.  I'll probably take a look at that
>> >> > > >>> > > > >> > > >> >> once I
>> >> > > have
>> >> > > >>> > > > >> > > >> >> Crosswalk
>> >> > > >>> > > > finalized.
>> >> > > >>> > > > >> > > >> >>
>> >> > > >>> > > > >> > > >> >> On Mon, Mar 10, 2014 at 9:49 AM, Brian
>> LeRoux
>> >> > > >>> > > > >> > > >> >> <b...@brian.io>
>> >> > > >>> > > > wrote:
>> >> > > >>> > > > >> > > >> >>> this is great stuff
>> >> > > >>> > > > >> > > >> >>>
>> >> > > >>> > > > >> > > >> >>> do we think it may be possible to bring in
>> >> > > >>> > > > >> > > >> >>> amazon
>> >> > > >>> fireos
>> >> > > >>> > > > >> > > >> >>> stuff
>> >> > > >>> > > > >> > > >> eventually
>> >> > > >>> > > > >> > > >> >>> too?
>> >> > > >>> > > > >> > > >> >>>
>> >> > > >>> > > > >> > > >> >>>
>> >> > > >>> > > > >> > > >> >>> On Fri, Mar 7, 2014 at 3:22 PM, Joe Bowser
>> >> > > >>> > > > >> > > >> >>> <bo...@gmail.com>
>> >> > > >>> > > > >> > wrote:
>> >> > > >>> > > > >> > > >> >>>
>> >> > > >>> > > > >> > > >> >>>> BTW: I committed it in my repo, not the
>> main
>> >> > > Apache
>> >> > > >>> one.
>> >> > > >>> > > > >> > > >> >>>>
>> >> > > >>> > > > >> > > >> >>>> On Fri, Mar 7, 2014 at 3:21 PM, Joe Bowser
>> >> > > >>> > > > >> > > >> >>>> <bo...@gmail.com>
>> >> > > >>> > > > >> > > wrote:
>> >> > > >>> > > > >> > > >> >>>> > Hey
>> >> > > >>> > > > >> > > >> >>>> >
>> >> > > >>> > > > >> > > >> >>>> > I just committed some code based on
>> their
>> >> > > WebView
>> >> > > >>> > > > >> > > >> >>>> > modifications that allows you to choose
>> >> > > >>> > > > >> > > >> >>>> > your
>> >> > > >>> renderer
>> >> > > >>> > > > >> > > >> >>>> > in the
>> >> > > >>> > > > >> > config file
>> >> > > >>> > > > >> > > with this:
>> >> > > >>> > > > >> > > >> >>>> >
>> >> > > >>> > > > >> > > >> >>>> >     <preference name="webView"
>> >> > > >>> > > > >> > > >> >>>> >
>> >> > > >>> value="org.apache.cordova.engine.crosswalk.XWalkCordo
>> >> > > >>> > > > >> > > >> >>>> > va
>> >> > > >>> > > > >> > > >> >>>> > Web
>> >> > > >>> > > > >> > > >> >>>> > View
>> >> > > >>> > > > >> > > >> >>>> > " />
>> >> > > >>> > > > >> > > >> >>>> >
>> >> > > >>> > > > >> > > >> >>>> > You currently have to copy over the
>> *.pak
>> >> > > >>> > > > >> > > >> >>>> > file
>> >> > > and
>> >> > > >>> > > > >> > > >> >>>> > the jsapi from a Crosswalk Example
>> project
>> >> > > >>> > > > >> > > >> >>>> > to
>> >> > > get
>> >> > > >>> > > > >> > > >> >>>> > this to work.  The next thing that I'm
>> >> > > >>> > > > >> > > >> >>>> > going
>> >> > to
>> >> > > do
>> >> > > >>> is
>> >> > > >>> > > > >> > > >> >>>> > figure out how to write this as a plugin
>> >> > > >>> > > > >> > > >> >>>> > and
>> >> > > have it
>> >> > > >>> > > > >> > > >> >>>> > install on a default
>> >> > > >>> > > > project.
>> >> > > >>> > > > >> > > >> >>>> > Also, right now the bridge doesn't seem
>> to
>> >> > > work, and
>> >> > > >>> > > > >> > > >> >>>> > I don't know why exactly.  That being
>> said,
>> >> > the
>> >> > > >>> > > > >> > > >> fact
>> >> > > >>> > > > >> > > >> >>>> > that I can choose which version of
>> >> > > Chrome/Chromium
>> >> > > >>> > > > >> > > >> >>>> > I'm running with
>> >> > > >>> > > > >> > > >> a
>> >> > > >>> > > > >> > > >> >>>> > single XML preference is HUGE.
>> >> > > >>> > > > >> > > >> >>>> >
>> >> > > >>> > > > >> > > >> >>>> > There's definitely a lot more work that
>> >> > > >>> > > > >> > > >> >>>> > needs
>> >> > > to be
>> >> > > >>> > > > >> > > >> >>>> > done, but as
>> >> > > >>> > > > >> > > >> long
>> >> > > >>> > > > >> > > >> >>>> > as we have something that we can fit
>> into
>> >> > > >>> > > > >> > > >> >>>> > the
>> >> > > >>> > > > >> > > >> >>>> > interface, we should
>> >> > > >>> > > > >> > > >> be
>> >> > > >>> > > > >> > > >> >>>> > able to put in things like GeckoView or
>> >> > > >>> > > > >> > > >> >>>> > other
>> >> > > third
>> >> > > >>> > > > >> > > >> >>>> > party
>> >> > > >>> > > > >> > renderers.
>> >> > > >>> > > > >> > > >> >>>> > The nightmare of being stuck with
>> bullshit
>> >> > > WebView
>> >> > > >>> > > > >> > > >> >>>> > bugs may soon be over.
>> >> > > >>> > > > >> > > >> >>>> >
>> >> > > >>> > > > >> > > >> >>>> > On Wed, Mar 5, 2014 at 8:59 PM, Michal
>> >> > > >>> > > > >> > > >> >>>> > Mocny
>> >> > > >>> > > > >> > > >> >>>> > <mm...@chromium.org>
>> >> > > >>> > > > >> > > >> >>>> wrote:
>> >> > > >>> > > > >> > > >> >>>> >>
>> >> > > >>> https://github.com/crosswalk-project/crosswalk-cordo
>> >> > > >>> > > > >> > > >> >>>> >> va
>> >> > > >>> > > > >> > > >> >>>> >> -an
>> >> > > >>> > > > >> > > >> >>>> >> droi
>> >> > > >>> > > > >> > > >> >>>> >> d
>> >> > > >>> > > > >> > > >> >>>> >>
>> >> > > >>> > > > >> > > >> >>>> >> First patch they landed, which claims
>> to
>> >> > > >>> > > > >> > > >> >>>> >> have
>> >> > > min
>> >> > > >>> > > > >> > > >> >>>> >> viable xwalk
>> >> > > >>> > > > >> > > >> webview:
>> >> > > >>> > > > >> > > >> >>>> >>
>> >> > > >>> > > > >> > > >> >>>>
>> >> > > >>> > > > >> > > >>
>> >> > > >>> https://github.com/crosswalk-project/crosswalk-cordova-andro
>> >> > > >>> > > > >> > > >> id
>> >> > > >>> > > > >> > > >> /co
>> >> > > >>> > > > >> > > >> mmit
>> >> > > >>> > > > >> > > >> /a04dedeb0204e7542d190312c6ae70c795a26e04
>> >> > > >>> > > > >> > > >> >>>> >>
>> >> > > >>> > > > >> > > >> >>>> >>
>> >> > > >>> > > > >> > > >> >>>> >> On Wed, Mar 5, 2014 at 11:37 PM, Michal
>> >> > > >>> > > > >> > > >> >>>> >> Mocny
>> >> > > >>> > > > >> > > >> >>>> >> <mmocny@chromium.org
>> >> > > >>> > > > >> > > >> >
>> >> > > >>> > > > >> > > >> >>>> wrote:
>> >> > > >>> > > > >> > > >> >>>> >>
>> >> > > >>> > > > >> > > >> >>>> >>> I haven't looked yet, but did you see:
>> >> > > >>> > > > >> > > >> >>>> >>>
>> >> > > >>> https://crosswalk-project.org/#wiki/crosswalk-cordo
>> >> > > >>> > > > >> > > >> >>>> >>> va
>> >> > > >>> > > > >> > > >> >>>> >>> -an
>> >> > > >>> > > > >> > > >> >>>> >>> droi
>> >> > > >>> > > > >> > > >> >>>> >>> d
>> >> > > >>> > > > >> > > >> >>>> >>>
>> >> > > >>> > > > >> > > >> >>>> >>> ?
>> >> > > >>> > > > >> > > >> >>>> >>>
>> >> > > >>> > > > >> > > >> >>>> >>>
>> >> > > >>> > > > >> > > >> >>>> >>> On Wed, Mar 5, 2014 at 10:20 PM,
>> Andrew
>> >> > > Grieve <
>> >> > > >>> > > > >> > > >> agrieve@chromium.org
>> >> > > >>> > > > >> > > >> >>>> >wrote:
>> >> > > >>> > > > >> > > >> >>>> >>>
>> >> > > >>> > > > >> > > >> >>>> >>>> First - very excited that you're
>> working
>> >> > > >>> > > > >> > > >> >>>> >>>> on
>> >> > > this!
>> >> > > >>> > > > >> > > >> >>>> >>>>
>> >> > > >>> > > > >> > > >> >>>> >>>> Had a quick look. Not sure there's
>> much
>> >> > > >>> > > > >> > > >> >>>> >>>> to
>> >> > be
>> >> > > >>> > gleaned
>> >> > > >>> > > yet.
>> >> > > >>> > > > >> > > >> >>>> >>>> Once
>> >> > > >>> > > > >> > > >> you
>> >> > > >>> > > > >> > > >> >>>> start
>> >> > > >>> > > > >> > > >> >>>> >>>> in on hooking up x-walk's webview I
>> >> > > >>> > > > >> > > >> >>>> >>>> think
>> >> > it
>> >> > > will
>> >> > > >>> > > > >> > > >> >>>> >>>> become more
>> >> > > >>> > > > >> > > >> obvious
>> >> > > >>> > > > >> > > >> >>>> what
>> >> > > >>> > > > >> > > >> >>>> >>>> the interface should look like. E.g.,
>> >> > > >>> > > > >> > > >> >>>> >>>> does
>> >> > > x-walk
>> >> > > >>> > > > >> > > >> >>>> >>>> even have the
>> >> > > >>> > > > >> > > >> >>>> concept of
>> >> > > >>> > > > >> > > >> >>>> >>>> ChromeClient vs WebViewClient vs
>> >> > > >>> > > > >> > > >> >>>> >>>> WebView?
>> >> > > Also
>> >> > > >>> > > > >> > > >> >>>> >>>> unsure whether the
>> >> > > >>> > > > >> > > >> >>>> class
>> >> > > >>> > > > >> > > >> >>>> >>>> should extend android.View as well as
>> >> > > implement
>> >> > > >>> > > > >> > > >> >>>> >>>> our
>> >> > > >>> > > > >> > interface.
>> >> > > >>> > > > >> > > >> E.g.
>> >> > > >>> > > > >> > > >> >>>> >>>> alternative is to have a "getView()"
>> >> > > >>> > > > >> > > >> >>>> >>>> method
>> >> > > on
>> >> > > >>> the
>> >> > > >>> > > > >> > interface.
>> >> > > >>> > > > >> > > >> Might
>> >> > > >>> > > > >> > > >> >>>> help
>> >> > > >>> > > > >> > > >> >>>> >>>> to
>> >> > > >>> > > > >> > > >> >>>> >>>> cut down on file sizes, and API
>> surface,
>> >> > but
>> >> > > >>> > > > >> > > >> >>>> >>>> again, I'm not too
>> >> > > >>> > > > >> > > >> sure.
>> >> > > >>> > > > >> > > >> >>>> >>>>
>> >> > > >>> > > > >> > > >> >>>> >>>> I've been pretty hesitant to touch
>> >> > > >>> > > > >> > > >> >>>> >>>> existing
>> >> > > >>> > > > >> > > >> >>>> >>>> exposed members
>> >> > > >>> > > > >> > > >> (e.g. the
>> >> > > >>> > > > >> > > >> >>>> >>>> public fields you were referring to)
>> >> > > >>> > > > >> > > >> >>>> >>>> since
>> >> > > >>> > > > >> > > >> >>>> >>>> touching anything
>> >> > > >>> > > > >> > > >> public
>> >> > > >>> > > > >> > > >> >>>> could
>> >> > > >>> > > > >> > > >> >>>> >>>> break plugins. That said, maybe now
>> is a
>> >> > good
>> >> > > >>> time
>> >> > > >>> > > > >> > > >> >>>> >>>> to @deprecate
>> >> > > >>> > > > >> > > >> a
>> >> > > >>> > > > >> > > >> >>>> bunch
>> >> > > >>> > > > >> > > >> >>>> >>>> of
>> >> > > >>> > > > >> > > >> >>>> >>>> them and either replace them with
>> >> > > >>> > > > >> > > >> >>>> >>>> getters,
>> >> > or
>> >> > > >>> just
>> >> > > >>> > > > >> > > >> >>>> >>>> declare them
>> >> > > >>> > > > >> > > >> to be
>> >> > > >>> > > > >> > > >> >>>> not
>> >> > > >>> > > > >> > > >> >>>> >>>> exposed to plugins.
>> >> > > >>> > > > >> > > >> >>>> >>>>
>> >> > > >>> > > > >> > > >> >>>> >>>>
>> >> > > >>> > > > >> > > >> >>>> >>>> On Wed, Mar 5, 2014 at 6:57 PM, Joe
>> >> > > >>> > > > >> > > >> >>>> >>>> Bowser
>> >> > > >>> > > > >> > > >> >>>> >>>> <bo...@gmail.com>
>> >> > > >>> > > > >> > > >> wrote:
>> >> > > >>> > > > >> > > >> >>>> >>>>
>> >> > > >>> > > > >> > > >> >>>> >>>> > So, after looking at the Crosswalk
>> >> > > >>> > > > >> > > >> >>>> >>>> > code
>> >> > > again,
>> >> > > >>> > > > >> > > >> >>>> >>>> > I've decided to
>> >> > > >>> > > > >> > > >> take
>> >> > > >>> > > > >> > > >> >>>> a
>> >> > > >>> > > > >> > > >> >>>> >>>> > quick stab at making things
>> pluggable.
>> >> > > >>> > > > >> > > >> >>>> >>>> > I
>> >> > > don't
>> >> > > >>> > > > >> > > >> >>>> >>>> > have a lot to
>> >> > > >>> > > > >> > > >> show
>> >> > > >>> > > > >> > > >> >>>> for
>> >> > > >>> > > > >> > > >> >>>> >>>> > it, but with the help of Eclipse
>> >> > > >>> > > > >> > > >> >>>> >>>> > (which
>> >> > is
>> >> > > why
>> >> > > >>> > > > >> > > >> >>>> >>>> > the generated interfaces look so
>> >> > > >>> > > > >> > > >> >>>> >>>> > screwed
>> >> > > up), I
>> >> > > >>> > > > >> > > >> >>>> >>>> > managed to create some
>> >> > > >>> > > > >> > > >> interfaces
>> >> > > >>> > > > >> > > >> >>>> so
>> >> > > >>> > > > >> > > >> >>>> >>>> > we can start shoehorning in other
>> >> > > >>> > > > >> > > >> >>>> >>>> > browser
>> >> > > >>> > renderers.
>> >> > > >>> > > > >> > > >> >>>> >>>> >
>> >> > > >>> > > > >> > > >> >>>> >>>> >
>> >> > > >>> > > > >> > > >>
>> >> > > >>> https://github.com/infil00p/cordova-android/tree/pluggable_w
>> >> > > >>> > > > >> > > >> eb
>> >> > > >>> > > > >> > > >> vie
>> >> > > >>> > > > >> > > >> w
>> >> > > >>> > > > >> > > >> >>>> >>>> >
>> >> > > >>> > > > >> > > >> >>>> >>>> > I'm going to probably start with
>> >> > Crosswalk,
>> >> > > >>> > > > >> > > >> >>>> >>>> > because it's
>> >> > > >>> > > > >> > > >> probably
>> >> > > >>> > > > >> > > >> >>>> the
>> >> > > >>> > > > >> > > >> >>>> >>>> > most mature primary candidate in
>> the
>> >> > > Android
>> >> > > >>> > > > >> > > >> >>>> >>>> > Third-Party
>> >> > > >>> > > > >> > > >> WebView
>> >> > > >>> > > > >> > > >> >>>> >>>> > thing, and I'm pretty sure the
>> >> > > >>> > > > >> > > >> >>>> >>>> > GeckoView
>> >> > > will
>> >> > > >>> be
>> >> > > >>> > > > >> > > >> >>>> >>>> > happening
>> >> > > >>> > > > >> > > >> shortly
>> >> > > >>> > > > >> > > >> >>>> >>>> > after.
>> >> > > >>> > > > >> > > >> >>>> >>>> >
>> >> > > >>> > > > >> > > >> >>>> >>>> > I don't know how this would work
>> >> > > >>> > > > >> > > >> >>>> >>>> > w.r.t.
>> >> > > the CLI
>> >> > > >>> > > > >> > > >> >>>> >>>> > or our
>> >> > > >>> > > > >> > > >> workflow at
>> >> > > >>> > > > >> > > >> >>>> >>>> > all, but at the moment, I really
>> just
>> >> > want
>> >> > > to
>> >> > > >>> at
>> >> > > >>> > > > >> > > >> >>>> >>>> > least start
>> >> > > >>> > > > >> > > >> to have
>> >> > > >>> > > > >> > > >> >>>> >>>> > some headway towards 4.x and
>> PhoneGap
>> >> > day.
>> >> > > >>> > > > >> > > >> >>>> >>>> >
>> >> > > >>> > > > >> > > >> >>>> >>>> > What do people think of this so
>> far?
>> >> > > >>> > > > >> > > >> >>>> >>>> > I'm
>> >> > > going
>> >> > > >>> > > > >> > > >> >>>> >>>> > to try to clean
>> >> > > >>> > > > >> > > >> >>>> things
>> >> > > >>> > > > >> > > >> >>>> >>>> > up a bit, since we've definitely
>> done
>> >> > > >>> > > > >> > > >> >>>> >>>> > a
>> >> > > lot of
>> >> > > >>> > > > >> > > >> >>>> >>>> > things that
>> >> > > >>> > > > >> > > >> would
>> >> > > >>> > > > >> > > >> >>>> make
>> >> > > >>> > > > >> > > >> >>>> >>>> > first year CS profs freak the hell
>> out
>> >> > > (i.e.
>> >> > > >>> > > > >> > > >> >>>> >>>> > public members in
>> >> > > >>> > > > >> > > >> >>>> public
>> >> > > >>> > > > >> > > >> >>>> >>>> > objects w.r.t. PluginManager).
>> >> > > >>> > > > >> > > >> >>>> >>>> >
>> >> > > >>> > > > >> > > >> >>>> >>>> > Thoughts?
>> >> > > >>> > > > >> > > >> >>>> >>>> >
>> >> > > >>> > > > >> > > >> >>>> >>>> > Joe
>> >> > > >>> > > > >> > > >> >>>> >>>> >
>> >> > > >>> > > > >> > > >> >>>> >>>>
>> >> > > >>> > > > >> > > >> >>>> >>>
>> >> > > >>> > > > >> > > >> >>>> >>>
>> >> > > >>> > > > >> > > >> >>>>
>> >> > > >>> > > > >> > > >>
>> >> > > >>> > > > >> >
>> >> > > >>> >
>> >> > > >>>
>> >> > >
>> >> >
>> >
>> >
>>
>
>

Re: [Android] Refactoring for different engines

[Brian LeRoux <b...@brian.io>]

How does 1:00PST on Friday work for a hangout for everyone?


On Wed, Apr 23, 2014 at 2:36 PM, Joe Bowser <bo...@gmail.com> wrote:

> BTW: Here's my PoC for Mozilla so far.  It's very broken!
>
> https://github.com/infil00p/MozillaView
>
>
>
> On Wed, Apr 23, 2014 at 10:50 AM, Brian LeRoux <b...@brian.io> wrote:
> > So I found a Moz hacker whom can help. what time on Fri do you guys want
> to
> > do this?
> >
> >
> > On Wed, Apr 23, 2014 at 10:31 AM, Ian Clelland <ic...@chromium.org>
> > wrote:
> >>
> >> I've managed to get this up and running now -- great work on this, Joe!
> >>
> >> Mobilespec runs on my N4, with 10 failing tests: 3 in contacts; 7 in
> >> file-transfer. Otherwise, things seem to be working pretty well.
> >>
> >> I used a new build of Crosswalk, and found that the embedding API has
> >> changed since the weekend (when Ningxin's patches applied). I've issued
> a
> >> pull request at
> >> https://github.com/infil00p/cordova-crosswalk-engine/pull/5for it --
> >>
> >> I'm not sure if there's a way to keep compatibility with last
> >> week's Crosswalk, or if we'd even want to. (Ningxin, if you could take a
> >> look at that PR and see if it makes sense, I'd appreciate it)
> >>
> >> Joe, I also had to patch the default constructor for
> XWalkCordovaWebView;
> >> it wasn't creating its own client objects, so it got the default ones,
> and
> >> most of the tests were failing because some component of the bridge
> wan't
> >> working. https://github.com/infil00p/cordova-crosswalk-engine/pull/4 is
> >> out
> >> for that.
> >>
> >> Count me in for the hangout -- this is exciting stuff
> >>
> >> Ian
> >>
> >>
> >> On Wed, Apr 23, 2014 at 10:26 AM, Brian LeRoux <b...@brian.io> wrote:
> >>
> >> > Yup I'll track em down
> >> > On Apr 23, 2014 7:17 AM, "Andrew Grieve" <ag...@chromium.org>
> wrote:
> >> >
> >> > > Does anyone have a contact at moz that we could invite?
> >> > >
> >> > > On Wed, Apr 23, 2014 at 10:09 AM, Andrew Grieve <
> agrieve@chromium.org>
> >> > > wrote:
> >> > > > Depends on their interest level I think. Faster we can get this
> out
> >> > > > the door the better. If we need to delay for geckoview, then I
> don't
> >> > > > think we should gate on it, just release it after.
> >> > > >
> >> > > > On Wed, Apr 23, 2014 at 3:01 AM, Tommy Williams <
> tommy@devgeeks.org>
> >> > > wrote:
> >> > > >> More engines, more better...
> >> > > >> On 23 Apr 2014 16:32, "Joe Bowser" <bo...@gmail.com> wrote:
> >> > > >>
> >> > > >>> Hey
> >> > > >>>
> >> > > >>> A Hangout would have to happen on Friday at the earliest.  It'd
> be
> >> > > good if
> >> > > >>> we could get someone from Mozilla on the hangout as well.  I
> >> > > >>> haven't
> >> > > gotten
> >> > > >>> MozillaView (GeckoView with Cordova methods) fully working yet.
> >> > > >>> For
> >> > > some
> >> > > >>> reason it's not rendering on the screen.
> >> > > >>>
> >> > > >>> Ideally it'd be cool to have at least two options when this
> >> > > >>> feature
> >> > > finally
> >> > > >>> lands.
> >> > > >>>
> >> > > >>> What do other people think?
> >> > > >>>
> >> > > >>> Joe
> >> > > >>> On 22 Apr 2014 20:06, "Hu, Ningxin" <ni...@intel.com>
> wrote:
> >> > > >>>
> >> > > >>> > Joe,
> >> > > >>> >
> >> > > >>> > Thanks for your review and merge the PRs.
> >> > > >>> >
> >> > > >>> > To pluggable webview interest group:
> >> > > >>> > Are we OK to setup a hangout this week for initial
> introduction
> >> > > >>> > and
> >> > > >>> > discussion of next steps?
> >> > > >>> >
> >> > > >>> > Thanks,
> >> > > >>> > -ningxin
> >> > > >>> >
> >> > > >>> > > -----Original Message-----
> >> > > >>> > > From: Hu, Ningxin [mailto:ningxin.hu@intel.com]
> >> > > >>> > > Sent: Tuesday, April 22, 2014 4:04 PM
> >> > > >>> > > To: dev@cordova.apache.org
> >> > > >>> > > Subject: RE: [Android] Refactoring for different engines
> >> > > >>> > >
> >> > > >>> > > The PoC is great! Quite excited about the direction!
> >> > > >>> > >
> >> > > >>> > > I've sent a PR to update the cordova-crosswalk-engine to
> >> > > >>> > > latest
> >> > > >>> crosswalk
> >> > > >>> > > embedding API. It works with xwalk_core_library at
> 6.35.124.0.
> >> > > >>> > >
> >> > > >>> > > I've also changed the CordovaWebView interface slightly
> >> > > >>> > > (adding
> >> > > >>> > getView() API)
> >> > > >>> > > to allow XWalkCordovaWebView to composite a XWalkView
> instead
> >> > > >>> > > of
> >> > > >>> > extending
> >> > > >>> > > it. It resolves some API naming issues for XWalkView case.
> >> > > >>> > >
> >> > > >>> > > Please review them at:
> >> > > >>> > > https://github.com/infil00p/cordova-crosswalk-engine/pull/3
> >> > > >>> > > https://github.com/infil00p/cordova-android/pull/2
> >> > > >>> > >
> >> > > >>> > > Thanks,
> >> > > >>> > > -ningxin
> >> > > >>> > >
> >> > > >>> > > > -----Original Message-----
> >> > > >>> > > > From: Joe Bowser [mailto:bowserj@gmail.com]
> >> > > >>> > > > Sent: Friday, April 11, 2014 12:45 AM
> >> > > >>> > > > To: dev
> >> > > >>> > > > Subject: Re: [Android] Refactoring for different engines
> >> > > >>> > > >
> >> > > >>> > > > Yeah, I'd be cool with setting up a hangout.  Everyone
> >> > > >>> > > > should
> >> > > take a
> >> > > >>> > > > look at the PoC, I've basically distilled it down to four
> or
> >> > five
> >> > > >>> > > > classes so far, but with some work, we may be able to get
> it
> >> > > down to
> >> > > >>> > > > three.  Due to legacy, we're pretty stuck with the Android
> >> > > WebView
> >> > > >>> API
> >> > > >>> > calls,
> >> > > >>> > > but these can probably be modified.
> >> > > >>> > > >
> >> > > >>> > > > It'd be good to get Mozilla people on the call as well,
> >> > > >>> > > > since
> >> > > they
> >> > > >>> > > > have their WebView as well.
> >> > > >>> > > >
> >> > > >>> > > > On Thu, Apr 10, 2014 at 9:38 AM, Hu, Ningxin <
> >> > > ningxin.hu@intel.com>
> >> > > >>> > wrote:
> >> > > >>> > > > > Hangout would be a good idea.
> >> > > >>> > > > >
> >> > > >>> > > > > FYI, I will be off next week. How about the week after
> >> > > >>> > > > > next?
> >> > > If it
> >> > > >>> > > > > works, please
> >> > > >>> > > > feel free to schedule one and count me in.
> >> > > >>> > > > >
> >> > > >>> > > > > Thanks,
> >> > > >>> > > > > -ningxin
> >> > > >>> > > > >
> >> > > >>> > > > >> -----Original Message-----
> >> > > >>> > > > >> From: mmocny@google.com [mailto:mmocny@google.com] On
> >> > Behalf
> >> > > Of
> >> > > >>> > > > >> Michal Mocny
> >> > > >>> > > > >> Sent: Tuesday, April 08, 2014 11:39 PM
> >> > > >>> > > > >> To: dev
> >> > > >>> > > > >> Subject: Re: [Android] Refactoring for different
> engines
> >> > > >>> > > > >>
> >> > > >>> > > > >> Would it be alright to set up a Hangout some time to
> >> > introduce
> >> > > >>> > everyone?
> >> > > >>> > > > >>
> >> > > >>> > > > >> Joe has been leading the effort here, but there are
> other
> >> > > cordova
> >> > > >>> > > > >> contributors for whom this is top priority.  It would
> be
> >> > nice
> >> > > if
> >> > > >>> we
> >> > > >>> > > > >> could all meet to say hello and make sure we are all
> >> > > >>> > > > >> going
> >> > in
> >> > > the
> >> > > >>> > > > >> right
> >> > > >>> > > > direction.
> >> > > >>> > > > >>
> >> > > >>> > > > >> Quite exciting!
> >> > > >>> > > > >>
> >> > > >>> > > > >> -Michal
> >> > > >>> > > > >>
> >> > > >>> > > > >>
> >> > > >>> > > > >> On Tue, Apr 8, 2014 at 10:56 AM, Hu, Ningxin <
> >> > > >>> ningxin.hu@intel.com>
> >> > > >>> > > wrote:
> >> > > >>> > > > >>
> >> > > >>> > > > >> > Joe, thanks for this. I am very excited.
> >> > > >>> > > > >> >
> >> > > >>> > > > >> > FYI. Crosswalk team is working on refactoring the
> >> > > >>> > > > >> > WebView
> >> > > API to
> >> > > >>> > > > >> > support embedding usage better [1]. (Previously the
> >> > > >>> > > > >> > layer
> >> > > API
> >> > > >>> was
> >> > > >>> > > > >> > not exposed as public usage).
> >> > > >>> > > > >> >
> >> > > >>> > > > >> > I would like to review the PoC and work with you to
> get
> >> > > >>> Crosswalk
> >> > > >>> > > > >> > fits into the pluggable WebView architecture.
> >> > > >>> > > > >> >
> >> > > >>> > > > >> > Thanks,
> >> > > >>> > > > >> > -ningxin
> >> > > >>> > > > >> >
> >> > > >>> > > > >> > > -----Original Message-----
> >> > > >>> > > > >> > > From: Joe Bowser [mailto:bowserj@gmail.com]
> >> > > >>> > > > >> > > Sent: Wednesday, March 19, 2014 7:08 AM
> >> > > >>> > > > >> > > To: dev
> >> > > >>> > > > >> > > Subject: Re: [Android] Refactoring for different
> >> > > >>> > > > >> > > engines
> >> > > >>> > > > >> > >
> >> > > >>> > > > >> > > Hey
> >> > > >>> > > > >> > >
> >> > > >>> > > > >> > > After debugging, I did some minor updates to the
> >> > > >>> > > > >> > > plugin
> >> > > >>> README.
> >> > > >>> > > > >> > > It
> >> > > >>> > > > >> > should be
> >> > > >>> > > > >> > > easier to get this up and running, although there's
> >> > still
> >> > > the
> >> > > >>> > > > >> > > issue of
> >> > > >>> > > > >> > after-install
> >> > > >>> > > > >> > > hooks and the relative path weirdness with the
> >> > > >>> > > > >> > > Crosswalk
> >> > > >>> > Library itself.
> >> > > >>> > > > >> > >
> >> > > >>> > > > >> > > It still doesn't support the CLI at all, but it
> >> > > >>> > > > >> > > should
> >> > be
> >> > > >>> there
> >> > > >>> > > > >> > > with the
> >> > > >>> > > > >> > old flow.
> >> > > >>> > > > >> > >
> >> > > >>> > > > >> > > On Mon, Mar 17, 2014 at 1:14 PM, Michal Mocny
> >> > > >>> > > > >> > > <mm...@chromium.org>
> >> > > >>> > > > >> > > wrote:
> >> > > >>> > > > >> > > > (Sorry Joe, Googlers are down in California and
> way
> >> > > busy.
> >> > > >>> > > > >> > > > Will be back in a week.  Super excited about
> this,
> >> > > though.)
> >> > > >>> > > > >> > > >
> >> > > >>> > > > >> > > > -Michal
> >> > > >>> > > > >> > > >
> >> > > >>> > > > >> > > >
> >> > > >>> > > > >> > > > On Mon, Mar 17, 2014 at 2:53 PM, Joe Bowser
> >> > > >>> > > > >> > > > <bo...@gmail.com>
> >> > > >>> > > > >> wrote:
> >> > > >>> > > > >> > > >
> >> > > >>> > > > >> > > >> Reviving this thread!
> >> > > >>> > > > >> > > >>
> >> > > >>> > > > >> > > >> Can other people look at this, and see if/when
> we
> >> > > should
> >> > > >>> > land this?
> >> > > >>> > > > >> > > >> I know that I have to re-write the tests still,
> >> > > >>> > > > >> > > >> but I
> >> > > would
> >> > > >>> > > > >> > > >> like some feedback before merging it in.  Also,
> >> > > >>> > > > >> > > >> it'd
> >> > be
> >> > > >>> > > > >> > > >> super awesome if other people could try and
> make a
> >> > > WebView
> >> > > >>> > > > >> > > >> based on the interfaces and recommend which
> >> > > >>> > > > >> > > >> methods
> >> > > should
> >> > > >>> > > > >> > > >> die.  I want to get this released in the next
> >> > > >>> > > > >> > > >> month
> >> > or
> >> > > so,
> >> > > >>> > > > >> > > >> so any time and feedback would be greatly
> >> > appreciated.
> >> > > >>> > > > >> > > >>
> >> > > >>> > > > >> > > >> Thanks
> >> > > >>> > > > >> > > >>
> >> > > >>> > > > >> > > >> On Thu, Mar 13, 2014 at 3:50 PM, Joe Bowser
> >> > > >>> > > > >> > > >> <bo...@gmail.com>
> >> > > >>> > > > >> > wrote:
> >> > > >>> > > > >> > > >> > Hey, I created the following today to track
> >> > > >>> > > > >> > > >> > various
> >> > > >>> > > > >> > > >> > WebView
> >> > > >>> > > > >> > progresses:
> >> > > >>> > > > >> > > >> > https://issues.apache.org/jira/browse/CB-6246
> >> > > >>> > > > >> > > >> >
> >> > > >>> > > > >> > > >> > I also have this repo created.  The licensing
> is
> >> > > ugly as
> >> > > >>> > > > >> > > >> > all crap, but it's a Proof-Of-Concept:
> >> > > >>> > > > >> > > >> >
> >> > https://github.com/infil00p/cordova-crosswalk-engine
> >> > > >>> > > > >> > > >> >
> >> > > >>> > > > >> > > >> > If I can get some help getting plugman to just
> >> > > >>> > > > >> > > >> > load
> >> > > >>> > > > >> > > >> > Crosswalk, it'll
> >> > > >>> > > > >> > > >> look hawt.
> >> > > >>> > > > >> > > >> >
> >> > > >>> > > > >> > > >> > BTW: We should probably get this ready to go
> >> > > >>> > > > >> > > >> > into
> >> > > Android
> >> > > >>> > > > >> > > >> > in the next two months and deprecate the
> >> > setProperty
> >> > > >>> > > > >> > > >> > methods, since all properties should be
> >> > > >>> > > > >> > > >> > preferences
> >> > > in
> >> > > >>> > config.xml
> >> > > >>> > > now.
> >> > > >>> > > > >> > > >> >
> >> > > >>> > > > >> > > >> > On Mon, Mar 10, 2014 at 2:42 PM, Joe Bowser
> >> > > >>> > > > >> > > >> > <bo...@gmail.com>
> >> > > >>> > > > >> > > wrote:
> >> > > >>> > > > >> > > >> >> Perhaps. There would be additional benefits
> to
> >> > this
> >> > > >>> > > > >> > > >> >> approach, namely fixes being added to that
> >> > platform
> >> > > more
> >> > > >>> > > > >> > > >> >> quickly.  I'll probably take a look at that
> >> > > >>> > > > >> > > >> >> once I
> >> > > have
> >> > > >>> > > > >> > > >> >> Crosswalk
> >> > > >>> > > > finalized.
> >> > > >>> > > > >> > > >> >>
> >> > > >>> > > > >> > > >> >> On Mon, Mar 10, 2014 at 9:49 AM, Brian LeRoux
> >> > > >>> > > > >> > > >> >> <b...@brian.io>
> >> > > >>> > > > wrote:
> >> > > >>> > > > >> > > >> >>> this is great stuff
> >> > > >>> > > > >> > > >> >>>
> >> > > >>> > > > >> > > >> >>> do we think it may be possible to bring in
> >> > > >>> > > > >> > > >> >>> amazon
> >> > > >>> fireos
> >> > > >>> > > > >> > > >> >>> stuff
> >> > > >>> > > > >> > > >> eventually
> >> > > >>> > > > >> > > >> >>> too?
> >> > > >>> > > > >> > > >> >>>
> >> > > >>> > > > >> > > >> >>>
> >> > > >>> > > > >> > > >> >>> On Fri, Mar 7, 2014 at 3:22 PM, Joe Bowser
> >> > > >>> > > > >> > > >> >>> <bo...@gmail.com>
> >> > > >>> > > > >> > wrote:
> >> > > >>> > > > >> > > >> >>>
> >> > > >>> > > > >> > > >> >>>> BTW: I committed it in my repo, not the
> main
> >> > > Apache
> >> > > >>> one.
> >> > > >>> > > > >> > > >> >>>>
> >> > > >>> > > > >> > > >> >>>> On Fri, Mar 7, 2014 at 3:21 PM, Joe Bowser
> >> > > >>> > > > >> > > >> >>>> <bo...@gmail.com>
> >> > > >>> > > > >> > > wrote:
> >> > > >>> > > > >> > > >> >>>> > Hey
> >> > > >>> > > > >> > > >> >>>> >
> >> > > >>> > > > >> > > >> >>>> > I just committed some code based on their
> >> > > WebView
> >> > > >>> > > > >> > > >> >>>> > modifications that allows you to choose
> >> > > >>> > > > >> > > >> >>>> > your
> >> > > >>> renderer
> >> > > >>> > > > >> > > >> >>>> > in the
> >> > > >>> > > > >> > config file
> >> > > >>> > > > >> > > with this:
> >> > > >>> > > > >> > > >> >>>> >
> >> > > >>> > > > >> > > >> >>>> >     <preference name="webView"
> >> > > >>> > > > >> > > >> >>>> >
> >> > > >>> value="org.apache.cordova.engine.crosswalk.XWalkCordo
> >> > > >>> > > > >> > > >> >>>> > va
> >> > > >>> > > > >> > > >> >>>> > Web
> >> > > >>> > > > >> > > >> >>>> > View
> >> > > >>> > > > >> > > >> >>>> > " />
> >> > > >>> > > > >> > > >> >>>> >
> >> > > >>> > > > >> > > >> >>>> > You currently have to copy over the *.pak
> >> > > >>> > > > >> > > >> >>>> > file
> >> > > and
> >> > > >>> > > > >> > > >> >>>> > the jsapi from a Crosswalk Example
> project
> >> > > >>> > > > >> > > >> >>>> > to
> >> > > get
> >> > > >>> > > > >> > > >> >>>> > this to work.  The next thing that I'm
> >> > > >>> > > > >> > > >> >>>> > going
> >> > to
> >> > > do
> >> > > >>> is
> >> > > >>> > > > >> > > >> >>>> > figure out how to write this as a plugin
> >> > > >>> > > > >> > > >> >>>> > and
> >> > > have it
> >> > > >>> > > > >> > > >> >>>> > install on a default
> >> > > >>> > > > project.
> >> > > >>> > > > >> > > >> >>>> > Also, right now the bridge doesn't seem
> to
> >> > > work, and
> >> > > >>> > > > >> > > >> >>>> > I don't know why exactly.  That being
> said,
> >> > the
> >> > > >>> > > > >> > > >> fact
> >> > > >>> > > > >> > > >> >>>> > that I can choose which version of
> >> > > Chrome/Chromium
> >> > > >>> > > > >> > > >> >>>> > I'm running with
> >> > > >>> > > > >> > > >> a
> >> > > >>> > > > >> > > >> >>>> > single XML preference is HUGE.
> >> > > >>> > > > >> > > >> >>>> >
> >> > > >>> > > > >> > > >> >>>> > There's definitely a lot more work that
> >> > > >>> > > > >> > > >> >>>> > needs
> >> > > to be
> >> > > >>> > > > >> > > >> >>>> > done, but as
> >> > > >>> > > > >> > > >> long
> >> > > >>> > > > >> > > >> >>>> > as we have something that we can fit into
> >> > > >>> > > > >> > > >> >>>> > the
> >> > > >>> > > > >> > > >> >>>> > interface, we should
> >> > > >>> > > > >> > > >> be
> >> > > >>> > > > >> > > >> >>>> > able to put in things like GeckoView or
> >> > > >>> > > > >> > > >> >>>> > other
> >> > > third
> >> > > >>> > > > >> > > >> >>>> > party
> >> > > >>> > > > >> > renderers.
> >> > > >>> > > > >> > > >> >>>> > The nightmare of being stuck with
> bullshit
> >> > > WebView
> >> > > >>> > > > >> > > >> >>>> > bugs may soon be over.
> >> > > >>> > > > >> > > >> >>>> >
> >> > > >>> > > > >> > > >> >>>> > On Wed, Mar 5, 2014 at 8:59 PM, Michal
> >> > > >>> > > > >> > > >> >>>> > Mocny
> >> > > >>> > > > >> > > >> >>>> > <mm...@chromium.org>
> >> > > >>> > > > >> > > >> >>>> wrote:
> >> > > >>> > > > >> > > >> >>>> >>
> >> > > >>> https://github.com/crosswalk-project/crosswalk-cordo
> >> > > >>> > > > >> > > >> >>>> >> va
> >> > > >>> > > > >> > > >> >>>> >> -an
> >> > > >>> > > > >> > > >> >>>> >> droi
> >> > > >>> > > > >> > > >> >>>> >> d
> >> > > >>> > > > >> > > >> >>>> >>
> >> > > >>> > > > >> > > >> >>>> >> First patch they landed, which claims to
> >> > > >>> > > > >> > > >> >>>> >> have
> >> > > min
> >> > > >>> > > > >> > > >> >>>> >> viable xwalk
> >> > > >>> > > > >> > > >> webview:
> >> > > >>> > > > >> > > >> >>>> >>
> >> > > >>> > > > >> > > >> >>>>
> >> > > >>> > > > >> > > >>
> >> > > >>> https://github.com/crosswalk-project/crosswalk-cordova-andro
> >> > > >>> > > > >> > > >> id
> >> > > >>> > > > >> > > >> /co
> >> > > >>> > > > >> > > >> mmit
> >> > > >>> > > > >> > > >> /a04dedeb0204e7542d190312c6ae70c795a26e04
> >> > > >>> > > > >> > > >> >>>> >>
> >> > > >>> > > > >> > > >> >>>> >>
> >> > > >>> > > > >> > > >> >>>> >> On Wed, Mar 5, 2014 at 11:37 PM, Michal
> >> > > >>> > > > >> > > >> >>>> >> Mocny
> >> > > >>> > > > >> > > >> >>>> >> <mmocny@chromium.org
> >> > > >>> > > > >> > > >> >
> >> > > >>> > > > >> > > >> >>>> wrote:
> >> > > >>> > > > >> > > >> >>>> >>
> >> > > >>> > > > >> > > >> >>>> >>> I haven't looked yet, but did you see:
> >> > > >>> > > > >> > > >> >>>> >>>
> >> > > >>> https://crosswalk-project.org/#wiki/crosswalk-cordo
> >> > > >>> > > > >> > > >> >>>> >>> va
> >> > > >>> > > > >> > > >> >>>> >>> -an
> >> > > >>> > > > >> > > >> >>>> >>> droi
> >> > > >>> > > > >> > > >> >>>> >>> d
> >> > > >>> > > > >> > > >> >>>> >>>
> >> > > >>> > > > >> > > >> >>>> >>> ?
> >> > > >>> > > > >> > > >> >>>> >>>
> >> > > >>> > > > >> > > >> >>>> >>>
> >> > > >>> > > > >> > > >> >>>> >>> On Wed, Mar 5, 2014 at 10:20 PM, Andrew
> >> > > Grieve <
> >> > > >>> > > > >> > > >> agrieve@chromium.org
> >> > > >>> > > > >> > > >> >>>> >wrote:
> >> > > >>> > > > >> > > >> >>>> >>>
> >> > > >>> > > > >> > > >> >>>> >>>> First - very excited that you're
> working
> >> > > >>> > > > >> > > >> >>>> >>>> on
> >> > > this!
> >> > > >>> > > > >> > > >> >>>> >>>>
> >> > > >>> > > > >> > > >> >>>> >>>> Had a quick look. Not sure there's
> much
> >> > > >>> > > > >> > > >> >>>> >>>> to
> >> > be
> >> > > >>> > gleaned
> >> > > >>> > > yet.
> >> > > >>> > > > >> > > >> >>>> >>>> Once
> >> > > >>> > > > >> > > >> you
> >> > > >>> > > > >> > > >> >>>> start
> >> > > >>> > > > >> > > >> >>>> >>>> in on hooking up x-walk's webview I
> >> > > >>> > > > >> > > >> >>>> >>>> think
> >> > it
> >> > > will
> >> > > >>> > > > >> > > >> >>>> >>>> become more
> >> > > >>> > > > >> > > >> obvious
> >> > > >>> > > > >> > > >> >>>> what
> >> > > >>> > > > >> > > >> >>>> >>>> the interface should look like. E.g.,
> >> > > >>> > > > >> > > >> >>>> >>>> does
> >> > > x-walk
> >> > > >>> > > > >> > > >> >>>> >>>> even have the
> >> > > >>> > > > >> > > >> >>>> concept of
> >> > > >>> > > > >> > > >> >>>> >>>> ChromeClient vs WebViewClient vs
> >> > > >>> > > > >> > > >> >>>> >>>> WebView?
> >> > > Also
> >> > > >>> > > > >> > > >> >>>> >>>> unsure whether the
> >> > > >>> > > > >> > > >> >>>> class
> >> > > >>> > > > >> > > >> >>>> >>>> should extend android.View as well as
> >> > > implement
> >> > > >>> > > > >> > > >> >>>> >>>> our
> >> > > >>> > > > >> > interface.
> >> > > >>> > > > >> > > >> E.g.
> >> > > >>> > > > >> > > >> >>>> >>>> alternative is to have a "getView()"
> >> > > >>> > > > >> > > >> >>>> >>>> method
> >> > > on
> >> > > >>> the
> >> > > >>> > > > >> > interface.
> >> > > >>> > > > >> > > >> Might
> >> > > >>> > > > >> > > >> >>>> help
> >> > > >>> > > > >> > > >> >>>> >>>> to
> >> > > >>> > > > >> > > >> >>>> >>>> cut down on file sizes, and API
> surface,
> >> > but
> >> > > >>> > > > >> > > >> >>>> >>>> again, I'm not too
> >> > > >>> > > > >> > > >> sure.
> >> > > >>> > > > >> > > >> >>>> >>>>
> >> > > >>> > > > >> > > >> >>>> >>>> I've been pretty hesitant to touch
> >> > > >>> > > > >> > > >> >>>> >>>> existing
> >> > > >>> > > > >> > > >> >>>> >>>> exposed members
> >> > > >>> > > > >> > > >> (e.g. the
> >> > > >>> > > > >> > > >> >>>> >>>> public fields you were referring to)
> >> > > >>> > > > >> > > >> >>>> >>>> since
> >> > > >>> > > > >> > > >> >>>> >>>> touching anything
> >> > > >>> > > > >> > > >> public
> >> > > >>> > > > >> > > >> >>>> could
> >> > > >>> > > > >> > > >> >>>> >>>> break plugins. That said, maybe now
> is a
> >> > good
> >> > > >>> time
> >> > > >>> > > > >> > > >> >>>> >>>> to @deprecate
> >> > > >>> > > > >> > > >> a
> >> > > >>> > > > >> > > >> >>>> bunch
> >> > > >>> > > > >> > > >> >>>> >>>> of
> >> > > >>> > > > >> > > >> >>>> >>>> them and either replace them with
> >> > > >>> > > > >> > > >> >>>> >>>> getters,
> >> > or
> >> > > >>> just
> >> > > >>> > > > >> > > >> >>>> >>>> declare them
> >> > > >>> > > > >> > > >> to be
> >> > > >>> > > > >> > > >> >>>> not
> >> > > >>> > > > >> > > >> >>>> >>>> exposed to plugins.
> >> > > >>> > > > >> > > >> >>>> >>>>
> >> > > >>> > > > >> > > >> >>>> >>>>
> >> > > >>> > > > >> > > >> >>>> >>>> On Wed, Mar 5, 2014 at 6:57 PM, Joe
> >> > > >>> > > > >> > > >> >>>> >>>> Bowser
> >> > > >>> > > > >> > > >> >>>> >>>> <bo...@gmail.com>
> >> > > >>> > > > >> > > >> wrote:
> >> > > >>> > > > >> > > >> >>>> >>>>
> >> > > >>> > > > >> > > >> >>>> >>>> > So, after looking at the Crosswalk
> >> > > >>> > > > >> > > >> >>>> >>>> > code
> >> > > again,
> >> > > >>> > > > >> > > >> >>>> >>>> > I've decided to
> >> > > >>> > > > >> > > >> take
> >> > > >>> > > > >> > > >> >>>> a
> >> > > >>> > > > >> > > >> >>>> >>>> > quick stab at making things
> pluggable.
> >> > > >>> > > > >> > > >> >>>> >>>> > I
> >> > > don't
> >> > > >>> > > > >> > > >> >>>> >>>> > have a lot to
> >> > > >>> > > > >> > > >> show
> >> > > >>> > > > >> > > >> >>>> for
> >> > > >>> > > > >> > > >> >>>> >>>> > it, but with the help of Eclipse
> >> > > >>> > > > >> > > >> >>>> >>>> > (which
> >> > is
> >> > > why
> >> > > >>> > > > >> > > >> >>>> >>>> > the generated interfaces look so
> >> > > >>> > > > >> > > >> >>>> >>>> > screwed
> >> > > up), I
> >> > > >>> > > > >> > > >> >>>> >>>> > managed to create some
> >> > > >>> > > > >> > > >> interfaces
> >> > > >>> > > > >> > > >> >>>> so
> >> > > >>> > > > >> > > >> >>>> >>>> > we can start shoehorning in other
> >> > > >>> > > > >> > > >> >>>> >>>> > browser
> >> > > >>> > renderers.
> >> > > >>> > > > >> > > >> >>>> >>>> >
> >> > > >>> > > > >> > > >> >>>> >>>> >
> >> > > >>> > > > >> > > >>
> >> > > >>> https://github.com/infil00p/cordova-android/tree/pluggable_w
> >> > > >>> > > > >> > > >> eb
> >> > > >>> > > > >> > > >> vie
> >> > > >>> > > > >> > > >> w
> >> > > >>> > > > >> > > >> >>>> >>>> >
> >> > > >>> > > > >> > > >> >>>> >>>> > I'm going to probably start with
> >> > Crosswalk,
> >> > > >>> > > > >> > > >> >>>> >>>> > because it's
> >> > > >>> > > > >> > > >> probably
> >> > > >>> > > > >> > > >> >>>> the
> >> > > >>> > > > >> > > >> >>>> >>>> > most mature primary candidate in the
> >> > > Android
> >> > > >>> > > > >> > > >> >>>> >>>> > Third-Party
> >> > > >>> > > > >> > > >> WebView
> >> > > >>> > > > >> > > >> >>>> >>>> > thing, and I'm pretty sure the
> >> > > >>> > > > >> > > >> >>>> >>>> > GeckoView
> >> > > will
> >> > > >>> be
> >> > > >>> > > > >> > > >> >>>> >>>> > happening
> >> > > >>> > > > >> > > >> shortly
> >> > > >>> > > > >> > > >> >>>> >>>> > after.
> >> > > >>> > > > >> > > >> >>>> >>>> >
> >> > > >>> > > > >> > > >> >>>> >>>> > I don't know how this would work
> >> > > >>> > > > >> > > >> >>>> >>>> > w.r.t.
> >> > > the CLI
> >> > > >>> > > > >> > > >> >>>> >>>> > or our
> >> > > >>> > > > >> > > >> workflow at
> >> > > >>> > > > >> > > >> >>>> >>>> > all, but at the moment, I really
> just
> >> > want
> >> > > to
> >> > > >>> at
> >> > > >>> > > > >> > > >> >>>> >>>> > least start
> >> > > >>> > > > >> > > >> to have
> >> > > >>> > > > >> > > >> >>>> >>>> > some headway towards 4.x and
> PhoneGap
> >> > day.
> >> > > >>> > > > >> > > >> >>>> >>>> >
> >> > > >>> > > > >> > > >> >>>> >>>> > What do people think of this so far?
> >> > > >>> > > > >> > > >> >>>> >>>> > I'm
> >> > > going
> >> > > >>> > > > >> > > >> >>>> >>>> > to try to clean
> >> > > >>> > > > >> > > >> >>>> things
> >> > > >>> > > > >> > > >> >>>> >>>> > up a bit, since we've definitely
> done
> >> > > >>> > > > >> > > >> >>>> >>>> > a
> >> > > lot of
> >> > > >>> > > > >> > > >> >>>> >>>> > things that
> >> > > >>> > > > >> > > >> would
> >> > > >>> > > > >> > > >> >>>> make
> >> > > >>> > > > >> > > >> >>>> >>>> > first year CS profs freak the hell
> out
> >> > > (i.e.
> >> > > >>> > > > >> > > >> >>>> >>>> > public members in
> >> > > >>> > > > >> > > >> >>>> public
> >> > > >>> > > > >> > > >> >>>> >>>> > objects w.r.t. PluginManager).
> >> > > >>> > > > >> > > >> >>>> >>>> >
> >> > > >>> > > > >> > > >> >>>> >>>> > Thoughts?
> >> > > >>> > > > >> > > >> >>>> >>>> >
> >> > > >>> > > > >> > > >> >>>> >>>> > Joe
> >> > > >>> > > > >> > > >> >>>> >>>> >
> >> > > >>> > > > >> > > >> >>>> >>>>
> >> > > >>> > > > >> > > >> >>>> >>>
> >> > > >>> > > > >> > > >> >>>> >>>
> >> > > >>> > > > >> > > >> >>>>
> >> > > >>> > > > >> > > >>
> >> > > >>> > > > >> >
> >> > > >>> >
> >> > > >>>
> >> > >
> >> >
> >
> >
>

Re: [Android] Refactoring for different engines

[Joe Bowser <bo...@gmail.com>]

BTW: Here's my PoC for Mozilla so far.  It's very broken!

https://github.com/infil00p/MozillaView



On Wed, Apr 23, 2014 at 10:50 AM, Brian LeRoux <b...@brian.io> wrote:
> So I found a Moz hacker whom can help. what time on Fri do you guys want to
> do this?
>
>
> On Wed, Apr 23, 2014 at 10:31 AM, Ian Clelland <ic...@chromium.org>
> wrote:
>>
>> I've managed to get this up and running now -- great work on this, Joe!
>>
>> Mobilespec runs on my N4, with 10 failing tests: 3 in contacts; 7 in
>> file-transfer. Otherwise, things seem to be working pretty well.
>>
>> I used a new build of Crosswalk, and found that the embedding API has
>> changed since the weekend (when Ningxin's patches applied). I've issued a
>> pull request at
>> https://github.com/infil00p/cordova-crosswalk-engine/pull/5for it --
>>
>> I'm not sure if there's a way to keep compatibility with last
>> week's Crosswalk, or if we'd even want to. (Ningxin, if you could take a
>> look at that PR and see if it makes sense, I'd appreciate it)
>>
>> Joe, I also had to patch the default constructor for XWalkCordovaWebView;
>> it wasn't creating its own client objects, so it got the default ones, and
>> most of the tests were failing because some component of the bridge wan't
>> working. https://github.com/infil00p/cordova-crosswalk-engine/pull/4 is
>> out
>> for that.
>>
>> Count me in for the hangout -- this is exciting stuff
>>
>> Ian
>>
>>
>> On Wed, Apr 23, 2014 at 10:26 AM, Brian LeRoux <b...@brian.io> wrote:
>>
>> > Yup I'll track em down
>> > On Apr 23, 2014 7:17 AM, "Andrew Grieve" <ag...@chromium.org> wrote:
>> >
>> > > Does anyone have a contact at moz that we could invite?
>> > >
>> > > On Wed, Apr 23, 2014 at 10:09 AM, Andrew Grieve <ag...@chromium.org>
>> > > wrote:
>> > > > Depends on their interest level I think. Faster we can get this out
>> > > > the door the better. If we need to delay for geckoview, then I don't
>> > > > think we should gate on it, just release it after.
>> > > >
>> > > > On Wed, Apr 23, 2014 at 3:01 AM, Tommy Williams <to...@devgeeks.org>
>> > > wrote:
>> > > >> More engines, more better...
>> > > >> On 23 Apr 2014 16:32, "Joe Bowser" <bo...@gmail.com> wrote:
>> > > >>
>> > > >>> Hey
>> > > >>>
>> > > >>> A Hangout would have to happen on Friday at the earliest.  It'd be
>> > > good if
>> > > >>> we could get someone from Mozilla on the hangout as well.  I
>> > > >>> haven't
>> > > gotten
>> > > >>> MozillaView (GeckoView with Cordova methods) fully working yet.
>> > > >>> For
>> > > some
>> > > >>> reason it's not rendering on the screen.
>> > > >>>
>> > > >>> Ideally it'd be cool to have at least two options when this
>> > > >>> feature
>> > > finally
>> > > >>> lands.
>> > > >>>
>> > > >>> What do other people think?
>> > > >>>
>> > > >>> Joe
>> > > >>> On 22 Apr 2014 20:06, "Hu, Ningxin" <ni...@intel.com> wrote:
>> > > >>>
>> > > >>> > Joe,
>> > > >>> >
>> > > >>> > Thanks for your review and merge the PRs.
>> > > >>> >
>> > > >>> > To pluggable webview interest group:
>> > > >>> > Are we OK to setup a hangout this week for initial introduction
>> > > >>> > and
>> > > >>> > discussion of next steps?
>> > > >>> >
>> > > >>> > Thanks,
>> > > >>> > -ningxin
>> > > >>> >
>> > > >>> > > -----Original Message-----
>> > > >>> > > From: Hu, Ningxin [mailto:ningxin.hu@intel.com]
>> > > >>> > > Sent: Tuesday, April 22, 2014 4:04 PM
>> > > >>> > > To: dev@cordova.apache.org
>> > > >>> > > Subject: RE: [Android] Refactoring for different engines
>> > > >>> > >
>> > > >>> > > The PoC is great! Quite excited about the direction!
>> > > >>> > >
>> > > >>> > > I've sent a PR to update the cordova-crosswalk-engine to
>> > > >>> > > latest
>> > > >>> crosswalk
>> > > >>> > > embedding API. It works with xwalk_core_library at 6.35.124.0.
>> > > >>> > >
>> > > >>> > > I've also changed the CordovaWebView interface slightly
>> > > >>> > > (adding
>> > > >>> > getView() API)
>> > > >>> > > to allow XWalkCordovaWebView to composite a XWalkView instead
>> > > >>> > > of
>> > > >>> > extending
>> > > >>> > > it. It resolves some API naming issues for XWalkView case.
>> > > >>> > >
>> > > >>> > > Please review them at:
>> > > >>> > > https://github.com/infil00p/cordova-crosswalk-engine/pull/3
>> > > >>> > > https://github.com/infil00p/cordova-android/pull/2
>> > > >>> > >
>> > > >>> > > Thanks,
>> > > >>> > > -ningxin
>> > > >>> > >
>> > > >>> > > > -----Original Message-----
>> > > >>> > > > From: Joe Bowser [mailto:bowserj@gmail.com]
>> > > >>> > > > Sent: Friday, April 11, 2014 12:45 AM
>> > > >>> > > > To: dev
>> > > >>> > > > Subject: Re: [Android] Refactoring for different engines
>> > > >>> > > >
>> > > >>> > > > Yeah, I'd be cool with setting up a hangout.  Everyone
>> > > >>> > > > should
>> > > take a
>> > > >>> > > > look at the PoC, I've basically distilled it down to four or
>> > five
>> > > >>> > > > classes so far, but with some work, we may be able to get it
>> > > down to
>> > > >>> > > > three.  Due to legacy, we're pretty stuck with the Android
>> > > WebView
>> > > >>> API
>> > > >>> > calls,
>> > > >>> > > but these can probably be modified.
>> > > >>> > > >
>> > > >>> > > > It'd be good to get Mozilla people on the call as well,
>> > > >>> > > > since
>> > > they
>> > > >>> > > > have their WebView as well.
>> > > >>> > > >
>> > > >>> > > > On Thu, Apr 10, 2014 at 9:38 AM, Hu, Ningxin <
>> > > ningxin.hu@intel.com>
>> > > >>> > wrote:
>> > > >>> > > > > Hangout would be a good idea.
>> > > >>> > > > >
>> > > >>> > > > > FYI, I will be off next week. How about the week after
>> > > >>> > > > > next?
>> > > If it
>> > > >>> > > > > works, please
>> > > >>> > > > feel free to schedule one and count me in.
>> > > >>> > > > >
>> > > >>> > > > > Thanks,
>> > > >>> > > > > -ningxin
>> > > >>> > > > >
>> > > >>> > > > >> -----Original Message-----
>> > > >>> > > > >> From: mmocny@google.com [mailto:mmocny@google.com] On
>> > Behalf
>> > > Of
>> > > >>> > > > >> Michal Mocny
>> > > >>> > > > >> Sent: Tuesday, April 08, 2014 11:39 PM
>> > > >>> > > > >> To: dev
>> > > >>> > > > >> Subject: Re: [Android] Refactoring for different engines
>> > > >>> > > > >>
>> > > >>> > > > >> Would it be alright to set up a Hangout some time to
>> > introduce
>> > > >>> > everyone?
>> > > >>> > > > >>
>> > > >>> > > > >> Joe has been leading the effort here, but there are other
>> > > cordova
>> > > >>> > > > >> contributors for whom this is top priority.  It would be
>> > nice
>> > > if
>> > > >>> we
>> > > >>> > > > >> could all meet to say hello and make sure we are all
>> > > >>> > > > >> going
>> > in
>> > > the
>> > > >>> > > > >> right
>> > > >>> > > > direction.
>> > > >>> > > > >>
>> > > >>> > > > >> Quite exciting!
>> > > >>> > > > >>
>> > > >>> > > > >> -Michal
>> > > >>> > > > >>
>> > > >>> > > > >>
>> > > >>> > > > >> On Tue, Apr 8, 2014 at 10:56 AM, Hu, Ningxin <
>> > > >>> ningxin.hu@intel.com>
>> > > >>> > > wrote:
>> > > >>> > > > >>
>> > > >>> > > > >> > Joe, thanks for this. I am very excited.
>> > > >>> > > > >> >
>> > > >>> > > > >> > FYI. Crosswalk team is working on refactoring the
>> > > >>> > > > >> > WebView
>> > > API to
>> > > >>> > > > >> > support embedding usage better [1]. (Previously the
>> > > >>> > > > >> > layer
>> > > API
>> > > >>> was
>> > > >>> > > > >> > not exposed as public usage).
>> > > >>> > > > >> >
>> > > >>> > > > >> > I would like to review the PoC and work with you to get
>> > > >>> Crosswalk
>> > > >>> > > > >> > fits into the pluggable WebView architecture.
>> > > >>> > > > >> >
>> > > >>> > > > >> > Thanks,
>> > > >>> > > > >> > -ningxin
>> > > >>> > > > >> >
>> > > >>> > > > >> > > -----Original Message-----
>> > > >>> > > > >> > > From: Joe Bowser [mailto:bowserj@gmail.com]
>> > > >>> > > > >> > > Sent: Wednesday, March 19, 2014 7:08 AM
>> > > >>> > > > >> > > To: dev
>> > > >>> > > > >> > > Subject: Re: [Android] Refactoring for different
>> > > >>> > > > >> > > engines
>> > > >>> > > > >> > >
>> > > >>> > > > >> > > Hey
>> > > >>> > > > >> > >
>> > > >>> > > > >> > > After debugging, I did some minor updates to the
>> > > >>> > > > >> > > plugin
>> > > >>> README.
>> > > >>> > > > >> > > It
>> > > >>> > > > >> > should be
>> > > >>> > > > >> > > easier to get this up and running, although there's
>> > still
>> > > the
>> > > >>> > > > >> > > issue of
>> > > >>> > > > >> > after-install
>> > > >>> > > > >> > > hooks and the relative path weirdness with the
>> > > >>> > > > >> > > Crosswalk
>> > > >>> > Library itself.
>> > > >>> > > > >> > >
>> > > >>> > > > >> > > It still doesn't support the CLI at all, but it
>> > > >>> > > > >> > > should
>> > be
>> > > >>> there
>> > > >>> > > > >> > > with the
>> > > >>> > > > >> > old flow.
>> > > >>> > > > >> > >
>> > > >>> > > > >> > > On Mon, Mar 17, 2014 at 1:14 PM, Michal Mocny
>> > > >>> > > > >> > > <mm...@chromium.org>
>> > > >>> > > > >> > > wrote:
>> > > >>> > > > >> > > > (Sorry Joe, Googlers are down in California and way
>> > > busy.
>> > > >>> > > > >> > > > Will be back in a week.  Super excited about this,
>> > > though.)
>> > > >>> > > > >> > > >
>> > > >>> > > > >> > > > -Michal
>> > > >>> > > > >> > > >
>> > > >>> > > > >> > > >
>> > > >>> > > > >> > > > On Mon, Mar 17, 2014 at 2:53 PM, Joe Bowser
>> > > >>> > > > >> > > > <bo...@gmail.com>
>> > > >>> > > > >> wrote:
>> > > >>> > > > >> > > >
>> > > >>> > > > >> > > >> Reviving this thread!
>> > > >>> > > > >> > > >>
>> > > >>> > > > >> > > >> Can other people look at this, and see if/when we
>> > > should
>> > > >>> > land this?
>> > > >>> > > > >> > > >> I know that I have to re-write the tests still,
>> > > >>> > > > >> > > >> but I
>> > > would
>> > > >>> > > > >> > > >> like some feedback before merging it in.  Also,
>> > > >>> > > > >> > > >> it'd
>> > be
>> > > >>> > > > >> > > >> super awesome if other people could try and make a
>> > > WebView
>> > > >>> > > > >> > > >> based on the interfaces and recommend which
>> > > >>> > > > >> > > >> methods
>> > > should
>> > > >>> > > > >> > > >> die.  I want to get this released in the next
>> > > >>> > > > >> > > >> month
>> > or
>> > > so,
>> > > >>> > > > >> > > >> so any time and feedback would be greatly
>> > appreciated.
>> > > >>> > > > >> > > >>
>> > > >>> > > > >> > > >> Thanks
>> > > >>> > > > >> > > >>
>> > > >>> > > > >> > > >> On Thu, Mar 13, 2014 at 3:50 PM, Joe Bowser
>> > > >>> > > > >> > > >> <bo...@gmail.com>
>> > > >>> > > > >> > wrote:
>> > > >>> > > > >> > > >> > Hey, I created the following today to track
>> > > >>> > > > >> > > >> > various
>> > > >>> > > > >> > > >> > WebView
>> > > >>> > > > >> > progresses:
>> > > >>> > > > >> > > >> > https://issues.apache.org/jira/browse/CB-6246
>> > > >>> > > > >> > > >> >
>> > > >>> > > > >> > > >> > I also have this repo created.  The licensing is
>> > > ugly as
>> > > >>> > > > >> > > >> > all crap, but it's a Proof-Of-Concept:
>> > > >>> > > > >> > > >> >
>> > https://github.com/infil00p/cordova-crosswalk-engine
>> > > >>> > > > >> > > >> >
>> > > >>> > > > >> > > >> > If I can get some help getting plugman to just
>> > > >>> > > > >> > > >> > load
>> > > >>> > > > >> > > >> > Crosswalk, it'll
>> > > >>> > > > >> > > >> look hawt.
>> > > >>> > > > >> > > >> >
>> > > >>> > > > >> > > >> > BTW: We should probably get this ready to go
>> > > >>> > > > >> > > >> > into
>> > > Android
>> > > >>> > > > >> > > >> > in the next two months and deprecate the
>> > setProperty
>> > > >>> > > > >> > > >> > methods, since all properties should be
>> > > >>> > > > >> > > >> > preferences
>> > > in
>> > > >>> > config.xml
>> > > >>> > > now.
>> > > >>> > > > >> > > >> >
>> > > >>> > > > >> > > >> > On Mon, Mar 10, 2014 at 2:42 PM, Joe Bowser
>> > > >>> > > > >> > > >> > <bo...@gmail.com>
>> > > >>> > > > >> > > wrote:
>> > > >>> > > > >> > > >> >> Perhaps. There would be additional benefits to
>> > this
>> > > >>> > > > >> > > >> >> approach, namely fixes being added to that
>> > platform
>> > > more
>> > > >>> > > > >> > > >> >> quickly.  I'll probably take a look at that
>> > > >>> > > > >> > > >> >> once I
>> > > have
>> > > >>> > > > >> > > >> >> Crosswalk
>> > > >>> > > > finalized.
>> > > >>> > > > >> > > >> >>
>> > > >>> > > > >> > > >> >> On Mon, Mar 10, 2014 at 9:49 AM, Brian LeRoux
>> > > >>> > > > >> > > >> >> <b...@brian.io>
>> > > >>> > > > wrote:
>> > > >>> > > > >> > > >> >>> this is great stuff
>> > > >>> > > > >> > > >> >>>
>> > > >>> > > > >> > > >> >>> do we think it may be possible to bring in
>> > > >>> > > > >> > > >> >>> amazon
>> > > >>> fireos
>> > > >>> > > > >> > > >> >>> stuff
>> > > >>> > > > >> > > >> eventually
>> > > >>> > > > >> > > >> >>> too?
>> > > >>> > > > >> > > >> >>>
>> > > >>> > > > >> > > >> >>>
>> > > >>> > > > >> > > >> >>> On Fri, Mar 7, 2014 at 3:22 PM, Joe Bowser
>> > > >>> > > > >> > > >> >>> <bo...@gmail.com>
>> > > >>> > > > >> > wrote:
>> > > >>> > > > >> > > >> >>>
>> > > >>> > > > >> > > >> >>>> BTW: I committed it in my repo, not the main
>> > > Apache
>> > > >>> one.
>> > > >>> > > > >> > > >> >>>>
>> > > >>> > > > >> > > >> >>>> On Fri, Mar 7, 2014 at 3:21 PM, Joe Bowser
>> > > >>> > > > >> > > >> >>>> <bo...@gmail.com>
>> > > >>> > > > >> > > wrote:
>> > > >>> > > > >> > > >> >>>> > Hey
>> > > >>> > > > >> > > >> >>>> >
>> > > >>> > > > >> > > >> >>>> > I just committed some code based on their
>> > > WebView
>> > > >>> > > > >> > > >> >>>> > modifications that allows you to choose
>> > > >>> > > > >> > > >> >>>> > your
>> > > >>> renderer
>> > > >>> > > > >> > > >> >>>> > in the
>> > > >>> > > > >> > config file
>> > > >>> > > > >> > > with this:
>> > > >>> > > > >> > > >> >>>> >
>> > > >>> > > > >> > > >> >>>> >     <preference name="webView"
>> > > >>> > > > >> > > >> >>>> >
>> > > >>> value="org.apache.cordova.engine.crosswalk.XWalkCordo
>> > > >>> > > > >> > > >> >>>> > va
>> > > >>> > > > >> > > >> >>>> > Web
>> > > >>> > > > >> > > >> >>>> > View
>> > > >>> > > > >> > > >> >>>> > " />
>> > > >>> > > > >> > > >> >>>> >
>> > > >>> > > > >> > > >> >>>> > You currently have to copy over the *.pak
>> > > >>> > > > >> > > >> >>>> > file
>> > > and
>> > > >>> > > > >> > > >> >>>> > the jsapi from a Crosswalk Example project
>> > > >>> > > > >> > > >> >>>> > to
>> > > get
>> > > >>> > > > >> > > >> >>>> > this to work.  The next thing that I'm
>> > > >>> > > > >> > > >> >>>> > going
>> > to
>> > > do
>> > > >>> is
>> > > >>> > > > >> > > >> >>>> > figure out how to write this as a plugin
>> > > >>> > > > >> > > >> >>>> > and
>> > > have it
>> > > >>> > > > >> > > >> >>>> > install on a default
>> > > >>> > > > project.
>> > > >>> > > > >> > > >> >>>> > Also, right now the bridge doesn't seem to
>> > > work, and
>> > > >>> > > > >> > > >> >>>> > I don't know why exactly.  That being said,
>> > the
>> > > >>> > > > >> > > >> fact
>> > > >>> > > > >> > > >> >>>> > that I can choose which version of
>> > > Chrome/Chromium
>> > > >>> > > > >> > > >> >>>> > I'm running with
>> > > >>> > > > >> > > >> a
>> > > >>> > > > >> > > >> >>>> > single XML preference is HUGE.
>> > > >>> > > > >> > > >> >>>> >
>> > > >>> > > > >> > > >> >>>> > There's definitely a lot more work that
>> > > >>> > > > >> > > >> >>>> > needs
>> > > to be
>> > > >>> > > > >> > > >> >>>> > done, but as
>> > > >>> > > > >> > > >> long
>> > > >>> > > > >> > > >> >>>> > as we have something that we can fit into
>> > > >>> > > > >> > > >> >>>> > the
>> > > >>> > > > >> > > >> >>>> > interface, we should
>> > > >>> > > > >> > > >> be
>> > > >>> > > > >> > > >> >>>> > able to put in things like GeckoView or
>> > > >>> > > > >> > > >> >>>> > other
>> > > third
>> > > >>> > > > >> > > >> >>>> > party
>> > > >>> > > > >> > renderers.
>> > > >>> > > > >> > > >> >>>> > The nightmare of being stuck with bullshit
>> > > WebView
>> > > >>> > > > >> > > >> >>>> > bugs may soon be over.
>> > > >>> > > > >> > > >> >>>> >
>> > > >>> > > > >> > > >> >>>> > On Wed, Mar 5, 2014 at 8:59 PM, Michal
>> > > >>> > > > >> > > >> >>>> > Mocny
>> > > >>> > > > >> > > >> >>>> > <mm...@chromium.org>
>> > > >>> > > > >> > > >> >>>> wrote:
>> > > >>> > > > >> > > >> >>>> >>
>> > > >>> https://github.com/crosswalk-project/crosswalk-cordo
>> > > >>> > > > >> > > >> >>>> >> va
>> > > >>> > > > >> > > >> >>>> >> -an
>> > > >>> > > > >> > > >> >>>> >> droi
>> > > >>> > > > >> > > >> >>>> >> d
>> > > >>> > > > >> > > >> >>>> >>
>> > > >>> > > > >> > > >> >>>> >> First patch they landed, which claims to
>> > > >>> > > > >> > > >> >>>> >> have
>> > > min
>> > > >>> > > > >> > > >> >>>> >> viable xwalk
>> > > >>> > > > >> > > >> webview:
>> > > >>> > > > >> > > >> >>>> >>
>> > > >>> > > > >> > > >> >>>>
>> > > >>> > > > >> > > >>
>> > > >>> https://github.com/crosswalk-project/crosswalk-cordova-andro
>> > > >>> > > > >> > > >> id
>> > > >>> > > > >> > > >> /co
>> > > >>> > > > >> > > >> mmit
>> > > >>> > > > >> > > >> /a04dedeb0204e7542d190312c6ae70c795a26e04
>> > > >>> > > > >> > > >> >>>> >>
>> > > >>> > > > >> > > >> >>>> >>
>> > > >>> > > > >> > > >> >>>> >> On Wed, Mar 5, 2014 at 11:37 PM, Michal
>> > > >>> > > > >> > > >> >>>> >> Mocny
>> > > >>> > > > >> > > >> >>>> >> <mmocny@chromium.org
>> > > >>> > > > >> > > >> >
>> > > >>> > > > >> > > >> >>>> wrote:
>> > > >>> > > > >> > > >> >>>> >>
>> > > >>> > > > >> > > >> >>>> >>> I haven't looked yet, but did you see:
>> > > >>> > > > >> > > >> >>>> >>>
>> > > >>> https://crosswalk-project.org/#wiki/crosswalk-cordo
>> > > >>> > > > >> > > >> >>>> >>> va
>> > > >>> > > > >> > > >> >>>> >>> -an
>> > > >>> > > > >> > > >> >>>> >>> droi
>> > > >>> > > > >> > > >> >>>> >>> d
>> > > >>> > > > >> > > >> >>>> >>>
>> > > >>> > > > >> > > >> >>>> >>> ?
>> > > >>> > > > >> > > >> >>>> >>>
>> > > >>> > > > >> > > >> >>>> >>>
>> > > >>> > > > >> > > >> >>>> >>> On Wed, Mar 5, 2014 at 10:20 PM, Andrew
>> > > Grieve <
>> > > >>> > > > >> > > >> agrieve@chromium.org
>> > > >>> > > > >> > > >> >>>> >wrote:
>> > > >>> > > > >> > > >> >>>> >>>
>> > > >>> > > > >> > > >> >>>> >>>> First - very excited that you're working
>> > > >>> > > > >> > > >> >>>> >>>> on
>> > > this!
>> > > >>> > > > >> > > >> >>>> >>>>
>> > > >>> > > > >> > > >> >>>> >>>> Had a quick look. Not sure there's much
>> > > >>> > > > >> > > >> >>>> >>>> to
>> > be
>> > > >>> > gleaned
>> > > >>> > > yet.
>> > > >>> > > > >> > > >> >>>> >>>> Once
>> > > >>> > > > >> > > >> you
>> > > >>> > > > >> > > >> >>>> start
>> > > >>> > > > >> > > >> >>>> >>>> in on hooking up x-walk's webview I
>> > > >>> > > > >> > > >> >>>> >>>> think
>> > it
>> > > will
>> > > >>> > > > >> > > >> >>>> >>>> become more
>> > > >>> > > > >> > > >> obvious
>> > > >>> > > > >> > > >> >>>> what
>> > > >>> > > > >> > > >> >>>> >>>> the interface should look like. E.g.,
>> > > >>> > > > >> > > >> >>>> >>>> does
>> > > x-walk
>> > > >>> > > > >> > > >> >>>> >>>> even have the
>> > > >>> > > > >> > > >> >>>> concept of
>> > > >>> > > > >> > > >> >>>> >>>> ChromeClient vs WebViewClient vs
>> > > >>> > > > >> > > >> >>>> >>>> WebView?
>> > > Also
>> > > >>> > > > >> > > >> >>>> >>>> unsure whether the
>> > > >>> > > > >> > > >> >>>> class
>> > > >>> > > > >> > > >> >>>> >>>> should extend android.View as well as
>> > > implement
>> > > >>> > > > >> > > >> >>>> >>>> our
>> > > >>> > > > >> > interface.
>> > > >>> > > > >> > > >> E.g.
>> > > >>> > > > >> > > >> >>>> >>>> alternative is to have a "getView()"
>> > > >>> > > > >> > > >> >>>> >>>> method
>> > > on
>> > > >>> the
>> > > >>> > > > >> > interface.
>> > > >>> > > > >> > > >> Might
>> > > >>> > > > >> > > >> >>>> help
>> > > >>> > > > >> > > >> >>>> >>>> to
>> > > >>> > > > >> > > >> >>>> >>>> cut down on file sizes, and API surface,
>> > but
>> > > >>> > > > >> > > >> >>>> >>>> again, I'm not too
>> > > >>> > > > >> > > >> sure.
>> > > >>> > > > >> > > >> >>>> >>>>
>> > > >>> > > > >> > > >> >>>> >>>> I've been pretty hesitant to touch
>> > > >>> > > > >> > > >> >>>> >>>> existing
>> > > >>> > > > >> > > >> >>>> >>>> exposed members
>> > > >>> > > > >> > > >> (e.g. the
>> > > >>> > > > >> > > >> >>>> >>>> public fields you were referring to)
>> > > >>> > > > >> > > >> >>>> >>>> since
>> > > >>> > > > >> > > >> >>>> >>>> touching anything
>> > > >>> > > > >> > > >> public
>> > > >>> > > > >> > > >> >>>> could
>> > > >>> > > > >> > > >> >>>> >>>> break plugins. That said, maybe now is a
>> > good
>> > > >>> time
>> > > >>> > > > >> > > >> >>>> >>>> to @deprecate
>> > > >>> > > > >> > > >> a
>> > > >>> > > > >> > > >> >>>> bunch
>> > > >>> > > > >> > > >> >>>> >>>> of
>> > > >>> > > > >> > > >> >>>> >>>> them and either replace them with
>> > > >>> > > > >> > > >> >>>> >>>> getters,
>> > or
>> > > >>> just
>> > > >>> > > > >> > > >> >>>> >>>> declare them
>> > > >>> > > > >> > > >> to be
>> > > >>> > > > >> > > >> >>>> not
>> > > >>> > > > >> > > >> >>>> >>>> exposed to plugins.
>> > > >>> > > > >> > > >> >>>> >>>>
>> > > >>> > > > >> > > >> >>>> >>>>
>> > > >>> > > > >> > > >> >>>> >>>> On Wed, Mar 5, 2014 at 6:57 PM, Joe
>> > > >>> > > > >> > > >> >>>> >>>> Bowser
>> > > >>> > > > >> > > >> >>>> >>>> <bo...@gmail.com>
>> > > >>> > > > >> > > >> wrote:
>> > > >>> > > > >> > > >> >>>> >>>>
>> > > >>> > > > >> > > >> >>>> >>>> > So, after looking at the Crosswalk
>> > > >>> > > > >> > > >> >>>> >>>> > code
>> > > again,
>> > > >>> > > > >> > > >> >>>> >>>> > I've decided to
>> > > >>> > > > >> > > >> take
>> > > >>> > > > >> > > >> >>>> a
>> > > >>> > > > >> > > >> >>>> >>>> > quick stab at making things pluggable.
>> > > >>> > > > >> > > >> >>>> >>>> > I
>> > > don't
>> > > >>> > > > >> > > >> >>>> >>>> > have a lot to
>> > > >>> > > > >> > > >> show
>> > > >>> > > > >> > > >> >>>> for
>> > > >>> > > > >> > > >> >>>> >>>> > it, but with the help of Eclipse
>> > > >>> > > > >> > > >> >>>> >>>> > (which
>> > is
>> > > why
>> > > >>> > > > >> > > >> >>>> >>>> > the generated interfaces look so
>> > > >>> > > > >> > > >> >>>> >>>> > screwed
>> > > up), I
>> > > >>> > > > >> > > >> >>>> >>>> > managed to create some
>> > > >>> > > > >> > > >> interfaces
>> > > >>> > > > >> > > >> >>>> so
>> > > >>> > > > >> > > >> >>>> >>>> > we can start shoehorning in other
>> > > >>> > > > >> > > >> >>>> >>>> > browser
>> > > >>> > renderers.
>> > > >>> > > > >> > > >> >>>> >>>> >
>> > > >>> > > > >> > > >> >>>> >>>> >
>> > > >>> > > > >> > > >>
>> > > >>> https://github.com/infil00p/cordova-android/tree/pluggable_w
>> > > >>> > > > >> > > >> eb
>> > > >>> > > > >> > > >> vie
>> > > >>> > > > >> > > >> w
>> > > >>> > > > >> > > >> >>>> >>>> >
>> > > >>> > > > >> > > >> >>>> >>>> > I'm going to probably start with
>> > Crosswalk,
>> > > >>> > > > >> > > >> >>>> >>>> > because it's
>> > > >>> > > > >> > > >> probably
>> > > >>> > > > >> > > >> >>>> the
>> > > >>> > > > >> > > >> >>>> >>>> > most mature primary candidate in the
>> > > Android
>> > > >>> > > > >> > > >> >>>> >>>> > Third-Party
>> > > >>> > > > >> > > >> WebView
>> > > >>> > > > >> > > >> >>>> >>>> > thing, and I'm pretty sure the
>> > > >>> > > > >> > > >> >>>> >>>> > GeckoView
>> > > will
>> > > >>> be
>> > > >>> > > > >> > > >> >>>> >>>> > happening
>> > > >>> > > > >> > > >> shortly
>> > > >>> > > > >> > > >> >>>> >>>> > after.
>> > > >>> > > > >> > > >> >>>> >>>> >
>> > > >>> > > > >> > > >> >>>> >>>> > I don't know how this would work
>> > > >>> > > > >> > > >> >>>> >>>> > w.r.t.
>> > > the CLI
>> > > >>> > > > >> > > >> >>>> >>>> > or our
>> > > >>> > > > >> > > >> workflow at
>> > > >>> > > > >> > > >> >>>> >>>> > all, but at the moment, I really just
>> > want
>> > > to
>> > > >>> at
>> > > >>> > > > >> > > >> >>>> >>>> > least start
>> > > >>> > > > >> > > >> to have
>> > > >>> > > > >> > > >> >>>> >>>> > some headway towards 4.x and PhoneGap
>> > day.
>> > > >>> > > > >> > > >> >>>> >>>> >
>> > > >>> > > > >> > > >> >>>> >>>> > What do people think of this so far?
>> > > >>> > > > >> > > >> >>>> >>>> > I'm
>> > > going
>> > > >>> > > > >> > > >> >>>> >>>> > to try to clean
>> > > >>> > > > >> > > >> >>>> things
>> > > >>> > > > >> > > >> >>>> >>>> > up a bit, since we've definitely done
>> > > >>> > > > >> > > >> >>>> >>>> > a
>> > > lot of
>> > > >>> > > > >> > > >> >>>> >>>> > things that
>> > > >>> > > > >> > > >> would
>> > > >>> > > > >> > > >> >>>> make
>> > > >>> > > > >> > > >> >>>> >>>> > first year CS profs freak the hell out
>> > > (i.e.
>> > > >>> > > > >> > > >> >>>> >>>> > public members in
>> > > >>> > > > >> > > >> >>>> public
>> > > >>> > > > >> > > >> >>>> >>>> > objects w.r.t. PluginManager).
>> > > >>> > > > >> > > >> >>>> >>>> >
>> > > >>> > > > >> > > >> >>>> >>>> > Thoughts?
>> > > >>> > > > >> > > >> >>>> >>>> >
>> > > >>> > > > >> > > >> >>>> >>>> > Joe
>> > > >>> > > > >> > > >> >>>> >>>> >
>> > > >>> > > > >> > > >> >>>> >>>>
>> > > >>> > > > >> > > >> >>>> >>>
>> > > >>> > > > >> > > >> >>>> >>>
>> > > >>> > > > >> > > >> >>>>
>> > > >>> > > > >> > > >>
>> > > >>> > > > >> >
>> > > >>> >
>> > > >>>
>> > >
>> >
>
>

Re: [Android] Refactoring for different engines

[Brian LeRoux <b...@brian.io>]

So I found a Moz hacker whom can help. what time on Fri do you guys want to
do this?


On Wed, Apr 23, 2014 at 10:31 AM, Ian Clelland <ic...@chromium.org>wrote:

> I've managed to get this up and running now -- great work on this, Joe!
>
> Mobilespec runs on my N4, with 10 failing tests: 3 in contacts; 7 in
> file-transfer. Otherwise, things seem to be working pretty well.
>
> I used a new build of Crosswalk, and found that the embedding API has
> changed since the weekend (when Ningxin's patches applied). I've issued a
> pull request at
> https://github.com/infil00p/cordova-crosswalk-engine/pull/5for it --
> I'm not sure if there's a way to keep compatibility with last
> week's Crosswalk, or if we'd even want to. (Ningxin, if you could take a
> look at that PR and see if it makes sense, I'd appreciate it)
>
> Joe, I also had to patch the default constructor for XWalkCordovaWebView;
> it wasn't creating its own client objects, so it got the default ones, and
> most of the tests were failing because some component of the bridge wan't
> working. https://github.com/infil00p/cordova-crosswalk-engine/pull/4 is
> out
> for that.
>
> Count me in for the hangout -- this is exciting stuff
>
> Ian
>
>
> On Wed, Apr 23, 2014 at 10:26 AM, Brian LeRoux <b...@brian.io> wrote:
>
> > Yup I'll track em down
> > On Apr 23, 2014 7:17 AM, "Andrew Grieve" <ag...@chromium.org> wrote:
> >
> > > Does anyone have a contact at moz that we could invite?
> > >
> > > On Wed, Apr 23, 2014 at 10:09 AM, Andrew Grieve <ag...@chromium.org>
> > > wrote:
> > > > Depends on their interest level I think. Faster we can get this out
> > > > the door the better. If we need to delay for geckoview, then I don't
> > > > think we should gate on it, just release it after.
> > > >
> > > > On Wed, Apr 23, 2014 at 3:01 AM, Tommy Williams <to...@devgeeks.org>
> > > wrote:
> > > >> More engines, more better...
> > > >> On 23 Apr 2014 16:32, "Joe Bowser" <bo...@gmail.com> wrote:
> > > >>
> > > >>> Hey
> > > >>>
> > > >>> A Hangout would have to happen on Friday at the earliest.  It'd be
> > > good if
> > > >>> we could get someone from Mozilla on the hangout as well.  I
> haven't
> > > gotten
> > > >>> MozillaView (GeckoView with Cordova methods) fully working yet.
>  For
> > > some
> > > >>> reason it's not rendering on the screen.
> > > >>>
> > > >>> Ideally it'd be cool to have at least two options when this feature
> > > finally
> > > >>> lands.
> > > >>>
> > > >>> What do other people think?
> > > >>>
> > > >>> Joe
> > > >>> On 22 Apr 2014 20:06, "Hu, Ningxin" <ni...@intel.com> wrote:
> > > >>>
> > > >>> > Joe,
> > > >>> >
> > > >>> > Thanks for your review and merge the PRs.
> > > >>> >
> > > >>> > To pluggable webview interest group:
> > > >>> > Are we OK to setup a hangout this week for initial introduction
> and
> > > >>> > discussion of next steps?
> > > >>> >
> > > >>> > Thanks,
> > > >>> > -ningxin
> > > >>> >
> > > >>> > > -----Original Message-----
> > > >>> > > From: Hu, Ningxin [mailto:ningxin.hu@intel.com]
> > > >>> > > Sent: Tuesday, April 22, 2014 4:04 PM
> > > >>> > > To: dev@cordova.apache.org
> > > >>> > > Subject: RE: [Android] Refactoring for different engines
> > > >>> > >
> > > >>> > > The PoC is great! Quite excited about the direction!
> > > >>> > >
> > > >>> > > I've sent a PR to update the cordova-crosswalk-engine to latest
> > > >>> crosswalk
> > > >>> > > embedding API. It works with xwalk_core_library at 6.35.124.0.
> > > >>> > >
> > > >>> > > I've also changed the CordovaWebView interface slightly (adding
> > > >>> > getView() API)
> > > >>> > > to allow XWalkCordovaWebView to composite a XWalkView instead
> of
> > > >>> > extending
> > > >>> > > it. It resolves some API naming issues for XWalkView case.
> > > >>> > >
> > > >>> > > Please review them at:
> > > >>> > > https://github.com/infil00p/cordova-crosswalk-engine/pull/3
> > > >>> > > https://github.com/infil00p/cordova-android/pull/2
> > > >>> > >
> > > >>> > > Thanks,
> > > >>> > > -ningxin
> > > >>> > >
> > > >>> > > > -----Original Message-----
> > > >>> > > > From: Joe Bowser [mailto:bowserj@gmail.com]
> > > >>> > > > Sent: Friday, April 11, 2014 12:45 AM
> > > >>> > > > To: dev
> > > >>> > > > Subject: Re: [Android] Refactoring for different engines
> > > >>> > > >
> > > >>> > > > Yeah, I'd be cool with setting up a hangout.  Everyone should
> > > take a
> > > >>> > > > look at the PoC, I've basically distilled it down to four or
> > five
> > > >>> > > > classes so far, but with some work, we may be able to get it
> > > down to
> > > >>> > > > three.  Due to legacy, we're pretty stuck with the Android
> > > WebView
> > > >>> API
> > > >>> > calls,
> > > >>> > > but these can probably be modified.
> > > >>> > > >
> > > >>> > > > It'd be good to get Mozilla people on the call as well, since
> > > they
> > > >>> > > > have their WebView as well.
> > > >>> > > >
> > > >>> > > > On Thu, Apr 10, 2014 at 9:38 AM, Hu, Ningxin <
> > > ningxin.hu@intel.com>
> > > >>> > wrote:
> > > >>> > > > > Hangout would be a good idea.
> > > >>> > > > >
> > > >>> > > > > FYI, I will be off next week. How about the week after
> next?
> > > If it
> > > >>> > > > > works, please
> > > >>> > > > feel free to schedule one and count me in.
> > > >>> > > > >
> > > >>> > > > > Thanks,
> > > >>> > > > > -ningxin
> > > >>> > > > >
> > > >>> > > > >> -----Original Message-----
> > > >>> > > > >> From: mmocny@google.com [mailto:mmocny@google.com] On
> > Behalf
> > > Of
> > > >>> > > > >> Michal Mocny
> > > >>> > > > >> Sent: Tuesday, April 08, 2014 11:39 PM
> > > >>> > > > >> To: dev
> > > >>> > > > >> Subject: Re: [Android] Refactoring for different engines
> > > >>> > > > >>
> > > >>> > > > >> Would it be alright to set up a Hangout some time to
> > introduce
> > > >>> > everyone?
> > > >>> > > > >>
> > > >>> > > > >> Joe has been leading the effort here, but there are other
> > > cordova
> > > >>> > > > >> contributors for whom this is top priority.  It would be
> > nice
> > > if
> > > >>> we
> > > >>> > > > >> could all meet to say hello and make sure we are all going
> > in
> > > the
> > > >>> > > > >> right
> > > >>> > > > direction.
> > > >>> > > > >>
> > > >>> > > > >> Quite exciting!
> > > >>> > > > >>
> > > >>> > > > >> -Michal
> > > >>> > > > >>
> > > >>> > > > >>
> > > >>> > > > >> On Tue, Apr 8, 2014 at 10:56 AM, Hu, Ningxin <
> > > >>> ningxin.hu@intel.com>
> > > >>> > > wrote:
> > > >>> > > > >>
> > > >>> > > > >> > Joe, thanks for this. I am very excited.
> > > >>> > > > >> >
> > > >>> > > > >> > FYI. Crosswalk team is working on refactoring the
> WebView
> > > API to
> > > >>> > > > >> > support embedding usage better [1]. (Previously the
> layer
> > > API
> > > >>> was
> > > >>> > > > >> > not exposed as public usage).
> > > >>> > > > >> >
> > > >>> > > > >> > I would like to review the PoC and work with you to get
> > > >>> Crosswalk
> > > >>> > > > >> > fits into the pluggable WebView architecture.
> > > >>> > > > >> >
> > > >>> > > > >> > Thanks,
> > > >>> > > > >> > -ningxin
> > > >>> > > > >> >
> > > >>> > > > >> > > -----Original Message-----
> > > >>> > > > >> > > From: Joe Bowser [mailto:bowserj@gmail.com]
> > > >>> > > > >> > > Sent: Wednesday, March 19, 2014 7:08 AM
> > > >>> > > > >> > > To: dev
> > > >>> > > > >> > > Subject: Re: [Android] Refactoring for different
> engines
> > > >>> > > > >> > >
> > > >>> > > > >> > > Hey
> > > >>> > > > >> > >
> > > >>> > > > >> > > After debugging, I did some minor updates to the
> plugin
> > > >>> README.
> > > >>> > > > >> > > It
> > > >>> > > > >> > should be
> > > >>> > > > >> > > easier to get this up and running, although there's
> > still
> > > the
> > > >>> > > > >> > > issue of
> > > >>> > > > >> > after-install
> > > >>> > > > >> > > hooks and the relative path weirdness with the
> Crosswalk
> > > >>> > Library itself.
> > > >>> > > > >> > >
> > > >>> > > > >> > > It still doesn't support the CLI at all, but it should
> > be
> > > >>> there
> > > >>> > > > >> > > with the
> > > >>> > > > >> > old flow.
> > > >>> > > > >> > >
> > > >>> > > > >> > > On Mon, Mar 17, 2014 at 1:14 PM, Michal Mocny
> > > >>> > > > >> > > <mm...@chromium.org>
> > > >>> > > > >> > > wrote:
> > > >>> > > > >> > > > (Sorry Joe, Googlers are down in California and way
> > > busy.
> > > >>> > > > >> > > > Will be back in a week.  Super excited about this,
> > > though.)
> > > >>> > > > >> > > >
> > > >>> > > > >> > > > -Michal
> > > >>> > > > >> > > >
> > > >>> > > > >> > > >
> > > >>> > > > >> > > > On Mon, Mar 17, 2014 at 2:53 PM, Joe Bowser
> > > >>> > > > >> > > > <bo...@gmail.com>
> > > >>> > > > >> wrote:
> > > >>> > > > >> > > >
> > > >>> > > > >> > > >> Reviving this thread!
> > > >>> > > > >> > > >>
> > > >>> > > > >> > > >> Can other people look at this, and see if/when we
> > > should
> > > >>> > land this?
> > > >>> > > > >> > > >> I know that I have to re-write the tests still,
> but I
> > > would
> > > >>> > > > >> > > >> like some feedback before merging it in.  Also,
> it'd
> > be
> > > >>> > > > >> > > >> super awesome if other people could try and make a
> > > WebView
> > > >>> > > > >> > > >> based on the interfaces and recommend which methods
> > > should
> > > >>> > > > >> > > >> die.  I want to get this released in the next month
> > or
> > > so,
> > > >>> > > > >> > > >> so any time and feedback would be greatly
> > appreciated.
> > > >>> > > > >> > > >>
> > > >>> > > > >> > > >> Thanks
> > > >>> > > > >> > > >>
> > > >>> > > > >> > > >> On Thu, Mar 13, 2014 at 3:50 PM, Joe Bowser
> > > >>> > > > >> > > >> <bo...@gmail.com>
> > > >>> > > > >> > wrote:
> > > >>> > > > >> > > >> > Hey, I created the following today to track
> various
> > > >>> > > > >> > > >> > WebView
> > > >>> > > > >> > progresses:
> > > >>> > > > >> > > >> > https://issues.apache.org/jira/browse/CB-6246
> > > >>> > > > >> > > >> >
> > > >>> > > > >> > > >> > I also have this repo created.  The licensing is
> > > ugly as
> > > >>> > > > >> > > >> > all crap, but it's a Proof-Of-Concept:
> > > >>> > > > >> > > >> >
> > https://github.com/infil00p/cordova-crosswalk-engine
> > > >>> > > > >> > > >> >
> > > >>> > > > >> > > >> > If I can get some help getting plugman to just
> load
> > > >>> > > > >> > > >> > Crosswalk, it'll
> > > >>> > > > >> > > >> look hawt.
> > > >>> > > > >> > > >> >
> > > >>> > > > >> > > >> > BTW: We should probably get this ready to go into
> > > Android
> > > >>> > > > >> > > >> > in the next two months and deprecate the
> > setProperty
> > > >>> > > > >> > > >> > methods, since all properties should be
> preferences
> > > in
> > > >>> > config.xml
> > > >>> > > now.
> > > >>> > > > >> > > >> >
> > > >>> > > > >> > > >> > On Mon, Mar 10, 2014 at 2:42 PM, Joe Bowser
> > > >>> > > > >> > > >> > <bo...@gmail.com>
> > > >>> > > > >> > > wrote:
> > > >>> > > > >> > > >> >> Perhaps. There would be additional benefits to
> > this
> > > >>> > > > >> > > >> >> approach, namely fixes being added to that
> > platform
> > > more
> > > >>> > > > >> > > >> >> quickly.  I'll probably take a look at that
> once I
> > > have
> > > >>> > > > >> > > >> >> Crosswalk
> > > >>> > > > finalized.
> > > >>> > > > >> > > >> >>
> > > >>> > > > >> > > >> >> On Mon, Mar 10, 2014 at 9:49 AM, Brian LeRoux
> > > >>> > > > >> > > >> >> <b...@brian.io>
> > > >>> > > > wrote:
> > > >>> > > > >> > > >> >>> this is great stuff
> > > >>> > > > >> > > >> >>>
> > > >>> > > > >> > > >> >>> do we think it may be possible to bring in
> amazon
> > > >>> fireos
> > > >>> > > > >> > > >> >>> stuff
> > > >>> > > > >> > > >> eventually
> > > >>> > > > >> > > >> >>> too?
> > > >>> > > > >> > > >> >>>
> > > >>> > > > >> > > >> >>>
> > > >>> > > > >> > > >> >>> On Fri, Mar 7, 2014 at 3:22 PM, Joe Bowser
> > > >>> > > > >> > > >> >>> <bo...@gmail.com>
> > > >>> > > > >> > wrote:
> > > >>> > > > >> > > >> >>>
> > > >>> > > > >> > > >> >>>> BTW: I committed it in my repo, not the main
> > > Apache
> > > >>> one.
> > > >>> > > > >> > > >> >>>>
> > > >>> > > > >> > > >> >>>> On Fri, Mar 7, 2014 at 3:21 PM, Joe Bowser
> > > >>> > > > >> > > >> >>>> <bo...@gmail.com>
> > > >>> > > > >> > > wrote:
> > > >>> > > > >> > > >> >>>> > Hey
> > > >>> > > > >> > > >> >>>> >
> > > >>> > > > >> > > >> >>>> > I just committed some code based on their
> > > WebView
> > > >>> > > > >> > > >> >>>> > modifications that allows you to choose your
> > > >>> renderer
> > > >>> > > > >> > > >> >>>> > in the
> > > >>> > > > >> > config file
> > > >>> > > > >> > > with this:
> > > >>> > > > >> > > >> >>>> >
> > > >>> > > > >> > > >> >>>> >     <preference name="webView"
> > > >>> > > > >> > > >> >>>> >
> > > >>> value="org.apache.cordova.engine.crosswalk.XWalkCordo
> > > >>> > > > >> > > >> >>>> > va
> > > >>> > > > >> > > >> >>>> > Web
> > > >>> > > > >> > > >> >>>> > View
> > > >>> > > > >> > > >> >>>> > " />
> > > >>> > > > >> > > >> >>>> >
> > > >>> > > > >> > > >> >>>> > You currently have to copy over the *.pak
> file
> > > and
> > > >>> > > > >> > > >> >>>> > the jsapi from a Crosswalk Example project
> to
> > > get
> > > >>> > > > >> > > >> >>>> > this to work.  The next thing that I'm going
> > to
> > > do
> > > >>> is
> > > >>> > > > >> > > >> >>>> > figure out how to write this as a plugin and
> > > have it
> > > >>> > > > >> > > >> >>>> > install on a default
> > > >>> > > > project.
> > > >>> > > > >> > > >> >>>> > Also, right now the bridge doesn't seem to
> > > work, and
> > > >>> > > > >> > > >> >>>> > I don't know why exactly.  That being said,
> > the
> > > >>> > > > >> > > >> fact
> > > >>> > > > >> > > >> >>>> > that I can choose which version of
> > > Chrome/Chromium
> > > >>> > > > >> > > >> >>>> > I'm running with
> > > >>> > > > >> > > >> a
> > > >>> > > > >> > > >> >>>> > single XML preference is HUGE.
> > > >>> > > > >> > > >> >>>> >
> > > >>> > > > >> > > >> >>>> > There's definitely a lot more work that
> needs
> > > to be
> > > >>> > > > >> > > >> >>>> > done, but as
> > > >>> > > > >> > > >> long
> > > >>> > > > >> > > >> >>>> > as we have something that we can fit into
> the
> > > >>> > > > >> > > >> >>>> > interface, we should
> > > >>> > > > >> > > >> be
> > > >>> > > > >> > > >> >>>> > able to put in things like GeckoView or
> other
> > > third
> > > >>> > > > >> > > >> >>>> > party
> > > >>> > > > >> > renderers.
> > > >>> > > > >> > > >> >>>> > The nightmare of being stuck with bullshit
> > > WebView
> > > >>> > > > >> > > >> >>>> > bugs may soon be over.
> > > >>> > > > >> > > >> >>>> >
> > > >>> > > > >> > > >> >>>> > On Wed, Mar 5, 2014 at 8:59 PM, Michal Mocny
> > > >>> > > > >> > > >> >>>> > <mm...@chromium.org>
> > > >>> > > > >> > > >> >>>> wrote:
> > > >>> > > > >> > > >> >>>> >>
> > > >>> https://github.com/crosswalk-project/crosswalk-cordo
> > > >>> > > > >> > > >> >>>> >> va
> > > >>> > > > >> > > >> >>>> >> -an
> > > >>> > > > >> > > >> >>>> >> droi
> > > >>> > > > >> > > >> >>>> >> d
> > > >>> > > > >> > > >> >>>> >>
> > > >>> > > > >> > > >> >>>> >> First patch they landed, which claims to
> have
> > > min
> > > >>> > > > >> > > >> >>>> >> viable xwalk
> > > >>> > > > >> > > >> webview:
> > > >>> > > > >> > > >> >>>> >>
> > > >>> > > > >> > > >> >>>>
> > > >>> > > > >> > > >>
> > > >>> https://github.com/crosswalk-project/crosswalk-cordova-andro
> > > >>> > > > >> > > >> id
> > > >>> > > > >> > > >> /co
> > > >>> > > > >> > > >> mmit
> > > >>> > > > >> > > >> /a04dedeb0204e7542d190312c6ae70c795a26e04
> > > >>> > > > >> > > >> >>>> >>
> > > >>> > > > >> > > >> >>>> >>
> > > >>> > > > >> > > >> >>>> >> On Wed, Mar 5, 2014 at 11:37 PM, Michal
> Mocny
> > > >>> > > > >> > > >> >>>> >> <mmocny@chromium.org
> > > >>> > > > >> > > >> >
> > > >>> > > > >> > > >> >>>> wrote:
> > > >>> > > > >> > > >> >>>> >>
> > > >>> > > > >> > > >> >>>> >>> I haven't looked yet, but did you see:
> > > >>> > > > >> > > >> >>>> >>>
> > > >>> https://crosswalk-project.org/#wiki/crosswalk-cordo
> > > >>> > > > >> > > >> >>>> >>> va
> > > >>> > > > >> > > >> >>>> >>> -an
> > > >>> > > > >> > > >> >>>> >>> droi
> > > >>> > > > >> > > >> >>>> >>> d
> > > >>> > > > >> > > >> >>>> >>>
> > > >>> > > > >> > > >> >>>> >>> ?
> > > >>> > > > >> > > >> >>>> >>>
> > > >>> > > > >> > > >> >>>> >>>
> > > >>> > > > >> > > >> >>>> >>> On Wed, Mar 5, 2014 at 10:20 PM, Andrew
> > > Grieve <
> > > >>> > > > >> > > >> agrieve@chromium.org
> > > >>> > > > >> > > >> >>>> >wrote:
> > > >>> > > > >> > > >> >>>> >>>
> > > >>> > > > >> > > >> >>>> >>>> First - very excited that you're working
> on
> > > this!
> > > >>> > > > >> > > >> >>>> >>>>
> > > >>> > > > >> > > >> >>>> >>>> Had a quick look. Not sure there's much
> to
> > be
> > > >>> > gleaned
> > > >>> > > yet.
> > > >>> > > > >> > > >> >>>> >>>> Once
> > > >>> > > > >> > > >> you
> > > >>> > > > >> > > >> >>>> start
> > > >>> > > > >> > > >> >>>> >>>> in on hooking up x-walk's webview I think
> > it
> > > will
> > > >>> > > > >> > > >> >>>> >>>> become more
> > > >>> > > > >> > > >> obvious
> > > >>> > > > >> > > >> >>>> what
> > > >>> > > > >> > > >> >>>> >>>> the interface should look like. E.g.,
> does
> > > x-walk
> > > >>> > > > >> > > >> >>>> >>>> even have the
> > > >>> > > > >> > > >> >>>> concept of
> > > >>> > > > >> > > >> >>>> >>>> ChromeClient vs WebViewClient vs WebView?
> > > Also
> > > >>> > > > >> > > >> >>>> >>>> unsure whether the
> > > >>> > > > >> > > >> >>>> class
> > > >>> > > > >> > > >> >>>> >>>> should extend android.View as well as
> > > implement
> > > >>> > > > >> > > >> >>>> >>>> our
> > > >>> > > > >> > interface.
> > > >>> > > > >> > > >> E.g.
> > > >>> > > > >> > > >> >>>> >>>> alternative is to have a "getView()"
> method
> > > on
> > > >>> the
> > > >>> > > > >> > interface.
> > > >>> > > > >> > > >> Might
> > > >>> > > > >> > > >> >>>> help
> > > >>> > > > >> > > >> >>>> >>>> to
> > > >>> > > > >> > > >> >>>> >>>> cut down on file sizes, and API surface,
> > but
> > > >>> > > > >> > > >> >>>> >>>> again, I'm not too
> > > >>> > > > >> > > >> sure.
> > > >>> > > > >> > > >> >>>> >>>>
> > > >>> > > > >> > > >> >>>> >>>> I've been pretty hesitant to touch
> existing
> > > >>> > > > >> > > >> >>>> >>>> exposed members
> > > >>> > > > >> > > >> (e.g. the
> > > >>> > > > >> > > >> >>>> >>>> public fields you were referring to)
> since
> > > >>> > > > >> > > >> >>>> >>>> touching anything
> > > >>> > > > >> > > >> public
> > > >>> > > > >> > > >> >>>> could
> > > >>> > > > >> > > >> >>>> >>>> break plugins. That said, maybe now is a
> > good
> > > >>> time
> > > >>> > > > >> > > >> >>>> >>>> to @deprecate
> > > >>> > > > >> > > >> a
> > > >>> > > > >> > > >> >>>> bunch
> > > >>> > > > >> > > >> >>>> >>>> of
> > > >>> > > > >> > > >> >>>> >>>> them and either replace them with
> getters,
> > or
> > > >>> just
> > > >>> > > > >> > > >> >>>> >>>> declare them
> > > >>> > > > >> > > >> to be
> > > >>> > > > >> > > >> >>>> not
> > > >>> > > > >> > > >> >>>> >>>> exposed to plugins.
> > > >>> > > > >> > > >> >>>> >>>>
> > > >>> > > > >> > > >> >>>> >>>>
> > > >>> > > > >> > > >> >>>> >>>> On Wed, Mar 5, 2014 at 6:57 PM, Joe
> Bowser
> > > >>> > > > >> > > >> >>>> >>>> <bo...@gmail.com>
> > > >>> > > > >> > > >> wrote:
> > > >>> > > > >> > > >> >>>> >>>>
> > > >>> > > > >> > > >> >>>> >>>> > So, after looking at the Crosswalk code
> > > again,
> > > >>> > > > >> > > >> >>>> >>>> > I've decided to
> > > >>> > > > >> > > >> take
> > > >>> > > > >> > > >> >>>> a
> > > >>> > > > >> > > >> >>>> >>>> > quick stab at making things pluggable.
>  I
> > > don't
> > > >>> > > > >> > > >> >>>> >>>> > have a lot to
> > > >>> > > > >> > > >> show
> > > >>> > > > >> > > >> >>>> for
> > > >>> > > > >> > > >> >>>> >>>> > it, but with the help of Eclipse (which
> > is
> > > why
> > > >>> > > > >> > > >> >>>> >>>> > the generated interfaces look so
> screwed
> > > up), I
> > > >>> > > > >> > > >> >>>> >>>> > managed to create some
> > > >>> > > > >> > > >> interfaces
> > > >>> > > > >> > > >> >>>> so
> > > >>> > > > >> > > >> >>>> >>>> > we can start shoehorning in other
> browser
> > > >>> > renderers.
> > > >>> > > > >> > > >> >>>> >>>> >
> > > >>> > > > >> > > >> >>>> >>>> >
> > > >>> > > > >> > > >>
> > > >>> https://github.com/infil00p/cordova-android/tree/pluggable_w
> > > >>> > > > >> > > >> eb
> > > >>> > > > >> > > >> vie
> > > >>> > > > >> > > >> w
> > > >>> > > > >> > > >> >>>> >>>> >
> > > >>> > > > >> > > >> >>>> >>>> > I'm going to probably start with
> > Crosswalk,
> > > >>> > > > >> > > >> >>>> >>>> > because it's
> > > >>> > > > >> > > >> probably
> > > >>> > > > >> > > >> >>>> the
> > > >>> > > > >> > > >> >>>> >>>> > most mature primary candidate in the
> > > Android
> > > >>> > > > >> > > >> >>>> >>>> > Third-Party
> > > >>> > > > >> > > >> WebView
> > > >>> > > > >> > > >> >>>> >>>> > thing, and I'm pretty sure the
> GeckoView
> > > will
> > > >>> be
> > > >>> > > > >> > > >> >>>> >>>> > happening
> > > >>> > > > >> > > >> shortly
> > > >>> > > > >> > > >> >>>> >>>> > after.
> > > >>> > > > >> > > >> >>>> >>>> >
> > > >>> > > > >> > > >> >>>> >>>> > I don't know how this would work w.r.t.
> > > the CLI
> > > >>> > > > >> > > >> >>>> >>>> > or our
> > > >>> > > > >> > > >> workflow at
> > > >>> > > > >> > > >> >>>> >>>> > all, but at the moment, I really just
> > want
> > > to
> > > >>> at
> > > >>> > > > >> > > >> >>>> >>>> > least start
> > > >>> > > > >> > > >> to have
> > > >>> > > > >> > > >> >>>> >>>> > some headway towards 4.x and PhoneGap
> > day.
> > > >>> > > > >> > > >> >>>> >>>> >
> > > >>> > > > >> > > >> >>>> >>>> > What do people think of this so far?
> I'm
> > > going
> > > >>> > > > >> > > >> >>>> >>>> > to try to clean
> > > >>> > > > >> > > >> >>>> things
> > > >>> > > > >> > > >> >>>> >>>> > up a bit, since we've definitely done a
> > > lot of
> > > >>> > > > >> > > >> >>>> >>>> > things that
> > > >>> > > > >> > > >> would
> > > >>> > > > >> > > >> >>>> make
> > > >>> > > > >> > > >> >>>> >>>> > first year CS profs freak the hell out
> > > (i.e.
> > > >>> > > > >> > > >> >>>> >>>> > public members in
> > > >>> > > > >> > > >> >>>> public
> > > >>> > > > >> > > >> >>>> >>>> > objects w.r.t. PluginManager).
> > > >>> > > > >> > > >> >>>> >>>> >
> > > >>> > > > >> > > >> >>>> >>>> > Thoughts?
> > > >>> > > > >> > > >> >>>> >>>> >
> > > >>> > > > >> > > >> >>>> >>>> > Joe
> > > >>> > > > >> > > >> >>>> >>>> >
> > > >>> > > > >> > > >> >>>> >>>>
> > > >>> > > > >> > > >> >>>> >>>
> > > >>> > > > >> > > >> >>>> >>>
> > > >>> > > > >> > > >> >>>>
> > > >>> > > > >> > > >>
> > > >>> > > > >> >
> > > >>> >
> > > >>>
> > >
> >
>

Re: [Android] Refactoring for different engines

[Joe Bowser <bo...@gmail.com>]

Sounds good.  It really should create its own WebViewClient and
WebChromeClients when they exist.  I'll pull them into the repo later
today.  I also have to remove the dependency to xwalk_library from
Cordova itself, since that's breaking the compile step on my work with
Gecko.  (Weird DEX Braille errors)


On Wed, Apr 23, 2014 at 10:31 AM, Ian Clelland <ic...@chromium.org> wrote:
> I've managed to get this up and running now -- great work on this, Joe!
>
> Mobilespec runs on my N4, with 10 failing tests: 3 in contacts; 7 in
> file-transfer. Otherwise, things seem to be working pretty well.
>
> I used a new build of Crosswalk, and found that the embedding API has
> changed since the weekend (when Ningxin's patches applied). I've issued a
> pull request at https://github.com/infil00p/cordova-crosswalk-engine/pull/5
> for it -- I'm not sure if there's a way to keep compatibility with last
> week's Crosswalk, or if we'd even want to. (Ningxin, if you could take a
> look at that PR and see if it makes sense, I'd appreciate it)
>
> Joe, I also had to patch the default constructor for XWalkCordovaWebView; it
> wasn't creating its own client objects, so it got the default ones, and most
> of the tests were failing because some component of the bridge wan't
> working. https://github.com/infil00p/cordova-crosswalk-engine/pull/4 is out
> for that.
>
> Count me in for the hangout -- this is exciting stuff
>
> Ian
>
>
> On Wed, Apr 23, 2014 at 10:26 AM, Brian LeRoux <b...@brian.io> wrote:
>>
>> Yup I'll track em down
>> On Apr 23, 2014 7:17 AM, "Andrew Grieve" <ag...@chromium.org> wrote:
>>
>> > Does anyone have a contact at moz that we could invite?
>> >
>> > On Wed, Apr 23, 2014 at 10:09 AM, Andrew Grieve <ag...@chromium.org>
>> > wrote:
>> > > Depends on their interest level I think. Faster we can get this out
>> > > the door the better. If we need to delay for geckoview, then I don't
>> > > think we should gate on it, just release it after.
>> > >
>> > > On Wed, Apr 23, 2014 at 3:01 AM, Tommy Williams <to...@devgeeks.org>
>> > wrote:
>> > >> More engines, more better...
>> > >> On 23 Apr 2014 16:32, "Joe Bowser" <bo...@gmail.com> wrote:
>> > >>
>> > >>> Hey
>> > >>>
>> > >>> A Hangout would have to happen on Friday at the earliest.  It'd be
>> > good if
>> > >>> we could get someone from Mozilla on the hangout as well.  I haven't
>> > gotten
>> > >>> MozillaView (GeckoView with Cordova methods) fully working yet.  For
>> > some
>> > >>> reason it's not rendering on the screen.
>> > >>>
>> > >>> Ideally it'd be cool to have at least two options when this feature
>> > finally
>> > >>> lands.
>> > >>>
>> > >>> What do other people think?
>> > >>>
>> > >>> Joe
>> > >>> On 22 Apr 2014 20:06, "Hu, Ningxin" <ni...@intel.com> wrote:
>> > >>>
>> > >>> > Joe,
>> > >>> >
>> > >>> > Thanks for your review and merge the PRs.
>> > >>> >
>> > >>> > To pluggable webview interest group:
>> > >>> > Are we OK to setup a hangout this week for initial introduction
>> > >>> > and
>> > >>> > discussion of next steps?
>> > >>> >
>> > >>> > Thanks,
>> > >>> > -ningxin
>> > >>> >
>> > >>> > > -----Original Message-----
>> > >>> > > From: Hu, Ningxin [mailto:ningxin.hu@intel.com]
>> > >>> > > Sent: Tuesday, April 22, 2014 4:04 PM
>> > >>> > > To: dev@cordova.apache.org
>> > >>> > > Subject: RE: [Android] Refactoring for different engines
>> > >>> > >
>> > >>> > > The PoC is great! Quite excited about the direction!
>> > >>> > >
>> > >>> > > I've sent a PR to update the cordova-crosswalk-engine to latest
>> > >>> crosswalk
>> > >>> > > embedding API. It works with xwalk_core_library at 6.35.124.0.
>> > >>> > >
>> > >>> > > I've also changed the CordovaWebView interface slightly (adding
>> > >>> > getView() API)
>> > >>> > > to allow XWalkCordovaWebView to composite a XWalkView instead of
>> > >>> > extending
>> > >>> > > it. It resolves some API naming issues for XWalkView case.
>> > >>> > >
>> > >>> > > Please review them at:
>> > >>> > > https://github.com/infil00p/cordova-crosswalk-engine/pull/3
>> > >>> > > https://github.com/infil00p/cordova-android/pull/2
>> > >>> > >
>> > >>> > > Thanks,
>> > >>> > > -ningxin
>> > >>> > >
>> > >>> > > > -----Original Message-----
>> > >>> > > > From: Joe Bowser [mailto:bowserj@gmail.com]
>> > >>> > > > Sent: Friday, April 11, 2014 12:45 AM
>> > >>> > > > To: dev
>> > >>> > > > Subject: Re: [Android] Refactoring for different engines
>> > >>> > > >
>> > >>> > > > Yeah, I'd be cool with setting up a hangout.  Everyone should
>> > take a
>> > >>> > > > look at the PoC, I've basically distilled it down to four or
>> > >>> > > > five
>> > >>> > > > classes so far, but with some work, we may be able to get it
>> > down to
>> > >>> > > > three.  Due to legacy, we're pretty stuck with the Android
>> > WebView
>> > >>> API
>> > >>> > calls,
>> > >>> > > but these can probably be modified.
>> > >>> > > >
>> > >>> > > > It'd be good to get Mozilla people on the call as well, since
>> > they
>> > >>> > > > have their WebView as well.
>> > >>> > > >
>> > >>> > > > On Thu, Apr 10, 2014 at 9:38 AM, Hu, Ningxin <
>> > ningxin.hu@intel.com>
>> > >>> > wrote:
>> > >>> > > > > Hangout would be a good idea.
>> > >>> > > > >
>> > >>> > > > > FYI, I will be off next week. How about the week after next?
>> > If it
>> > >>> > > > > works, please
>> > >>> > > > feel free to schedule one and count me in.
>> > >>> > > > >
>> > >>> > > > > Thanks,
>> > >>> > > > > -ningxin
>> > >>> > > > >
>> > >>> > > > >> -----Original Message-----
>> > >>> > > > >> From: mmocny@google.com [mailto:mmocny@google.com] On
>> > >>> > > > >> Behalf
>> > Of
>> > >>> > > > >> Michal Mocny
>> > >>> > > > >> Sent: Tuesday, April 08, 2014 11:39 PM
>> > >>> > > > >> To: dev
>> > >>> > > > >> Subject: Re: [Android] Refactoring for different engines
>> > >>> > > > >>
>> > >>> > > > >> Would it be alright to set up a Hangout some time to
>> > >>> > > > >> introduce
>> > >>> > everyone?
>> > >>> > > > >>
>> > >>> > > > >> Joe has been leading the effort here, but there are other
>> > cordova
>> > >>> > > > >> contributors for whom this is top priority.  It would be
>> > >>> > > > >> nice
>> > if
>> > >>> we
>> > >>> > > > >> could all meet to say hello and make sure we are all going
>> > >>> > > > >> in
>> > the
>> > >>> > > > >> right
>> > >>> > > > direction.
>> > >>> > > > >>
>> > >>> > > > >> Quite exciting!
>> > >>> > > > >>
>> > >>> > > > >> -Michal
>> > >>> > > > >>
>> > >>> > > > >>
>> > >>> > > > >> On Tue, Apr 8, 2014 at 10:56 AM, Hu, Ningxin <
>> > >>> ningxin.hu@intel.com>
>> > >>> > > wrote:
>> > >>> > > > >>
>> > >>> > > > >> > Joe, thanks for this. I am very excited.
>> > >>> > > > >> >
>> > >>> > > > >> > FYI. Crosswalk team is working on refactoring the WebView
>> > API to
>> > >>> > > > >> > support embedding usage better [1]. (Previously the layer
>> > API
>> > >>> was
>> > >>> > > > >> > not exposed as public usage).
>> > >>> > > > >> >
>> > >>> > > > >> > I would like to review the PoC and work with you to get
>> > >>> Crosswalk
>> > >>> > > > >> > fits into the pluggable WebView architecture.
>> > >>> > > > >> >
>> > >>> > > > >> > Thanks,
>> > >>> > > > >> > -ningxin
>> > >>> > > > >> >
>> > >>> > > > >> > > -----Original Message-----
>> > >>> > > > >> > > From: Joe Bowser [mailto:bowserj@gmail.com]
>> > >>> > > > >> > > Sent: Wednesday, March 19, 2014 7:08 AM
>> > >>> > > > >> > > To: dev
>> > >>> > > > >> > > Subject: Re: [Android] Refactoring for different
>> > >>> > > > >> > > engines
>> > >>> > > > >> > >
>> > >>> > > > >> > > Hey
>> > >>> > > > >> > >
>> > >>> > > > >> > > After debugging, I did some minor updates to the plugin
>> > >>> README.
>> > >>> > > > >> > > It
>> > >>> > > > >> > should be
>> > >>> > > > >> > > easier to get this up and running, although there's
>> > >>> > > > >> > > still
>> > the
>> > >>> > > > >> > > issue of
>> > >>> > > > >> > after-install
>> > >>> > > > >> > > hooks and the relative path weirdness with the
>> > >>> > > > >> > > Crosswalk
>> > >>> > Library itself.
>> > >>> > > > >> > >
>> > >>> > > > >> > > It still doesn't support the CLI at all, but it should
>> > >>> > > > >> > > be
>> > >>> there
>> > >>> > > > >> > > with the
>> > >>> > > > >> > old flow.
>> > >>> > > > >> > >
>> > >>> > > > >> > > On Mon, Mar 17, 2014 at 1:14 PM, Michal Mocny
>> > >>> > > > >> > > <mm...@chromium.org>
>> > >>> > > > >> > > wrote:
>> > >>> > > > >> > > > (Sorry Joe, Googlers are down in California and way
>> > busy.
>> > >>> > > > >> > > > Will be back in a week.  Super excited about this,
>> > though.)
>> > >>> > > > >> > > >
>> > >>> > > > >> > > > -Michal
>> > >>> > > > >> > > >
>> > >>> > > > >> > > >
>> > >>> > > > >> > > > On Mon, Mar 17, 2014 at 2:53 PM, Joe Bowser
>> > >>> > > > >> > > > <bo...@gmail.com>
>> > >>> > > > >> wrote:
>> > >>> > > > >> > > >
>> > >>> > > > >> > > >> Reviving this thread!
>> > >>> > > > >> > > >>
>> > >>> > > > >> > > >> Can other people look at this, and see if/when we
>> > should
>> > >>> > land this?
>> > >>> > > > >> > > >> I know that I have to re-write the tests still, but
>> > >>> > > > >> > > >> I
>> > would
>> > >>> > > > >> > > >> like some feedback before merging it in.  Also, it'd
>> > >>> > > > >> > > >> be
>> > >>> > > > >> > > >> super awesome if other people could try and make a
>> > WebView
>> > >>> > > > >> > > >> based on the interfaces and recommend which methods
>> > should
>> > >>> > > > >> > > >> die.  I want to get this released in the next month
>> > >>> > > > >> > > >> or
>> > so,
>> > >>> > > > >> > > >> so any time and feedback would be greatly
>> > >>> > > > >> > > >> appreciated.
>> > >>> > > > >> > > >>
>> > >>> > > > >> > > >> Thanks
>> > >>> > > > >> > > >>
>> > >>> > > > >> > > >> On Thu, Mar 13, 2014 at 3:50 PM, Joe Bowser
>> > >>> > > > >> > > >> <bo...@gmail.com>
>> > >>> > > > >> > wrote:
>> > >>> > > > >> > > >> > Hey, I created the following today to track
>> > >>> > > > >> > > >> > various
>> > >>> > > > >> > > >> > WebView
>> > >>> > > > >> > progresses:
>> > >>> > > > >> > > >> > https://issues.apache.org/jira/browse/CB-6246
>> > >>> > > > >> > > >> >
>> > >>> > > > >> > > >> > I also have this repo created.  The licensing is
>> > ugly as
>> > >>> > > > >> > > >> > all crap, but it's a Proof-Of-Concept:
>> > >>> > > > >> > > >> >
>> > >>> > > > >> > > >> > https://github.com/infil00p/cordova-crosswalk-engine
>> > >>> > > > >> > > >> >
>> > >>> > > > >> > > >> > If I can get some help getting plugman to just
>> > >>> > > > >> > > >> > load
>> > >>> > > > >> > > >> > Crosswalk, it'll
>> > >>> > > > >> > > >> look hawt.
>> > >>> > > > >> > > >> >
>> > >>> > > > >> > > >> > BTW: We should probably get this ready to go into
>> > Android
>> > >>> > > > >> > > >> > in the next two months and deprecate the
>> > >>> > > > >> > > >> > setProperty
>> > >>> > > > >> > > >> > methods, since all properties should be
>> > >>> > > > >> > > >> > preferences
>> > in
>> > >>> > config.xml
>> > >>> > > now.
>> > >>> > > > >> > > >> >
>> > >>> > > > >> > > >> > On Mon, Mar 10, 2014 at 2:42 PM, Joe Bowser
>> > >>> > > > >> > > >> > <bo...@gmail.com>
>> > >>> > > > >> > > wrote:
>> > >>> > > > >> > > >> >> Perhaps. There would be additional benefits to
>> > >>> > > > >> > > >> >> this
>> > >>> > > > >> > > >> >> approach, namely fixes being added to that
>> > >>> > > > >> > > >> >> platform
>> > more
>> > >>> > > > >> > > >> >> quickly.  I'll probably take a look at that once
>> > >>> > > > >> > > >> >> I
>> > have
>> > >>> > > > >> > > >> >> Crosswalk
>> > >>> > > > finalized.
>> > >>> > > > >> > > >> >>
>> > >>> > > > >> > > >> >> On Mon, Mar 10, 2014 at 9:49 AM, Brian LeRoux
>> > >>> > > > >> > > >> >> <b...@brian.io>
>> > >>> > > > wrote:
>> > >>> > > > >> > > >> >>> this is great stuff
>> > >>> > > > >> > > >> >>>
>> > >>> > > > >> > > >> >>> do we think it may be possible to bring in
>> > >>> > > > >> > > >> >>> amazon
>> > >>> fireos
>> > >>> > > > >> > > >> >>> stuff
>> > >>> > > > >> > > >> eventually
>> > >>> > > > >> > > >> >>> too?
>> > >>> > > > >> > > >> >>>
>> > >>> > > > >> > > >> >>>
>> > >>> > > > >> > > >> >>> On Fri, Mar 7, 2014 at 3:22 PM, Joe Bowser
>> > >>> > > > >> > > >> >>> <bo...@gmail.com>
>> > >>> > > > >> > wrote:
>> > >>> > > > >> > > >> >>>
>> > >>> > > > >> > > >> >>>> BTW: I committed it in my repo, not the main
>> > Apache
>> > >>> one.
>> > >>> > > > >> > > >> >>>>
>> > >>> > > > >> > > >> >>>> On Fri, Mar 7, 2014 at 3:21 PM, Joe Bowser
>> > >>> > > > >> > > >> >>>> <bo...@gmail.com>
>> > >>> > > > >> > > wrote:
>> > >>> > > > >> > > >> >>>> > Hey
>> > >>> > > > >> > > >> >>>> >
>> > >>> > > > >> > > >> >>>> > I just committed some code based on their
>> > WebView
>> > >>> > > > >> > > >> >>>> > modifications that allows you to choose your
>> > >>> renderer
>> > >>> > > > >> > > >> >>>> > in the
>> > >>> > > > >> > config file
>> > >>> > > > >> > > with this:
>> > >>> > > > >> > > >> >>>> >
>> > >>> > > > >> > > >> >>>> >     <preference name="webView"
>> > >>> > > > >> > > >> >>>> >
>> > >>> value="org.apache.cordova.engine.crosswalk.XWalkCordo
>> > >>> > > > >> > > >> >>>> > va
>> > >>> > > > >> > > >> >>>> > Web
>> > >>> > > > >> > > >> >>>> > View
>> > >>> > > > >> > > >> >>>> > " />
>> > >>> > > > >> > > >> >>>> >
>> > >>> > > > >> > > >> >>>> > You currently have to copy over the *.pak
>> > >>> > > > >> > > >> >>>> > file
>> > and
>> > >>> > > > >> > > >> >>>> > the jsapi from a Crosswalk Example project to
>> > get
>> > >>> > > > >> > > >> >>>> > this to work.  The next thing that I'm going
>> > >>> > > > >> > > >> >>>> > to
>> > do
>> > >>> is
>> > >>> > > > >> > > >> >>>> > figure out how to write this as a plugin and
>> > have it
>> > >>> > > > >> > > >> >>>> > install on a default
>> > >>> > > > project.
>> > >>> > > > >> > > >> >>>> > Also, right now the bridge doesn't seem to
>> > work, and
>> > >>> > > > >> > > >> >>>> > I don't know why exactly.  That being said,
>> > >>> > > > >> > > >> >>>> > the
>> > >>> > > > >> > > >> fact
>> > >>> > > > >> > > >> >>>> > that I can choose which version of
>> > Chrome/Chromium
>> > >>> > > > >> > > >> >>>> > I'm running with
>> > >>> > > > >> > > >> a
>> > >>> > > > >> > > >> >>>> > single XML preference is HUGE.
>> > >>> > > > >> > > >> >>>> >
>> > >>> > > > >> > > >> >>>> > There's definitely a lot more work that needs
>> > to be
>> > >>> > > > >> > > >> >>>> > done, but as
>> > >>> > > > >> > > >> long
>> > >>> > > > >> > > >> >>>> > as we have something that we can fit into the
>> > >>> > > > >> > > >> >>>> > interface, we should
>> > >>> > > > >> > > >> be
>> > >>> > > > >> > > >> >>>> > able to put in things like GeckoView or other
>> > third
>> > >>> > > > >> > > >> >>>> > party
>> > >>> > > > >> > renderers.
>> > >>> > > > >> > > >> >>>> > The nightmare of being stuck with bullshit
>> > WebView
>> > >>> > > > >> > > >> >>>> > bugs may soon be over.
>> > >>> > > > >> > > >> >>>> >
>> > >>> > > > >> > > >> >>>> > On Wed, Mar 5, 2014 at 8:59 PM, Michal Mocny
>> > >>> > > > >> > > >> >>>> > <mm...@chromium.org>
>> > >>> > > > >> > > >> >>>> wrote:
>> > >>> > > > >> > > >> >>>> >>
>> > >>> https://github.com/crosswalk-project/crosswalk-cordo
>> > >>> > > > >> > > >> >>>> >> va
>> > >>> > > > >> > > >> >>>> >> -an
>> > >>> > > > >> > > >> >>>> >> droi
>> > >>> > > > >> > > >> >>>> >> d
>> > >>> > > > >> > > >> >>>> >>
>> > >>> > > > >> > > >> >>>> >> First patch they landed, which claims to
>> > >>> > > > >> > > >> >>>> >> have
>> > min
>> > >>> > > > >> > > >> >>>> >> viable xwalk
>> > >>> > > > >> > > >> webview:
>> > >>> > > > >> > > >> >>>> >>
>> > >>> > > > >> > > >> >>>>
>> > >>> > > > >> > > >>
>> > >>> https://github.com/crosswalk-project/crosswalk-cordova-andro
>> > >>> > > > >> > > >> id
>> > >>> > > > >> > > >> /co
>> > >>> > > > >> > > >> mmit
>> > >>> > > > >> > > >> /a04dedeb0204e7542d190312c6ae70c795a26e04
>> > >>> > > > >> > > >> >>>> >>
>> > >>> > > > >> > > >> >>>> >>
>> > >>> > > > >> > > >> >>>> >> On Wed, Mar 5, 2014 at 11:37 PM, Michal
>> > >>> > > > >> > > >> >>>> >> Mocny
>> > >>> > > > >> > > >> >>>> >> <mmocny@chromium.org
>> > >>> > > > >> > > >> >
>> > >>> > > > >> > > >> >>>> wrote:
>> > >>> > > > >> > > >> >>>> >>
>> > >>> > > > >> > > >> >>>> >>> I haven't looked yet, but did you see:
>> > >>> > > > >> > > >> >>>> >>>
>> > >>> https://crosswalk-project.org/#wiki/crosswalk-cordo
>> > >>> > > > >> > > >> >>>> >>> va
>> > >>> > > > >> > > >> >>>> >>> -an
>> > >>> > > > >> > > >> >>>> >>> droi
>> > >>> > > > >> > > >> >>>> >>> d
>> > >>> > > > >> > > >> >>>> >>>
>> > >>> > > > >> > > >> >>>> >>> ?
>> > >>> > > > >> > > >> >>>> >>>
>> > >>> > > > >> > > >> >>>> >>>
>> > >>> > > > >> > > >> >>>> >>> On Wed, Mar 5, 2014 at 10:20 PM, Andrew
>> > Grieve <
>> > >>> > > > >> > > >> agrieve@chromium.org
>> > >>> > > > >> > > >> >>>> >wrote:
>> > >>> > > > >> > > >> >>>> >>>
>> > >>> > > > >> > > >> >>>> >>>> First - very excited that you're working
>> > >>> > > > >> > > >> >>>> >>>> on
>> > this!
>> > >>> > > > >> > > >> >>>> >>>>
>> > >>> > > > >> > > >> >>>> >>>> Had a quick look. Not sure there's much to
>> > >>> > > > >> > > >> >>>> >>>> be
>> > >>> > gleaned
>> > >>> > > yet.
>> > >>> > > > >> > > >> >>>> >>>> Once
>> > >>> > > > >> > > >> you
>> > >>> > > > >> > > >> >>>> start
>> > >>> > > > >> > > >> >>>> >>>> in on hooking up x-walk's webview I think
>> > >>> > > > >> > > >> >>>> >>>> it
>> > will
>> > >>> > > > >> > > >> >>>> >>>> become more
>> > >>> > > > >> > > >> obvious
>> > >>> > > > >> > > >> >>>> what
>> > >>> > > > >> > > >> >>>> >>>> the interface should look like. E.g., does
>> > x-walk
>> > >>> > > > >> > > >> >>>> >>>> even have the
>> > >>> > > > >> > > >> >>>> concept of
>> > >>> > > > >> > > >> >>>> >>>> ChromeClient vs WebViewClient vs WebView?
>> > Also
>> > >>> > > > >> > > >> >>>> >>>> unsure whether the
>> > >>> > > > >> > > >> >>>> class
>> > >>> > > > >> > > >> >>>> >>>> should extend android.View as well as
>> > implement
>> > >>> > > > >> > > >> >>>> >>>> our
>> > >>> > > > >> > interface.
>> > >>> > > > >> > > >> E.g.
>> > >>> > > > >> > > >> >>>> >>>> alternative is to have a "getView()"
>> > >>> > > > >> > > >> >>>> >>>> method
>> > on
>> > >>> the
>> > >>> > > > >> > interface.
>> > >>> > > > >> > > >> Might
>> > >>> > > > >> > > >> >>>> help
>> > >>> > > > >> > > >> >>>> >>>> to
>> > >>> > > > >> > > >> >>>> >>>> cut down on file sizes, and API surface,
>> > >>> > > > >> > > >> >>>> >>>> but
>> > >>> > > > >> > > >> >>>> >>>> again, I'm not too
>> > >>> > > > >> > > >> sure.
>> > >>> > > > >> > > >> >>>> >>>>
>> > >>> > > > >> > > >> >>>> >>>> I've been pretty hesitant to touch
>> > >>> > > > >> > > >> >>>> >>>> existing
>> > >>> > > > >> > > >> >>>> >>>> exposed members
>> > >>> > > > >> > > >> (e.g. the
>> > >>> > > > >> > > >> >>>> >>>> public fields you were referring to) since
>> > >>> > > > >> > > >> >>>> >>>> touching anything
>> > >>> > > > >> > > >> public
>> > >>> > > > >> > > >> >>>> could
>> > >>> > > > >> > > >> >>>> >>>> break plugins. That said, maybe now is a
>> > >>> > > > >> > > >> >>>> >>>> good
>> > >>> time
>> > >>> > > > >> > > >> >>>> >>>> to @deprecate
>> > >>> > > > >> > > >> a
>> > >>> > > > >> > > >> >>>> bunch
>> > >>> > > > >> > > >> >>>> >>>> of
>> > >>> > > > >> > > >> >>>> >>>> them and either replace them with getters,
>> > >>> > > > >> > > >> >>>> >>>> or
>> > >>> just
>> > >>> > > > >> > > >> >>>> >>>> declare them
>> > >>> > > > >> > > >> to be
>> > >>> > > > >> > > >> >>>> not
>> > >>> > > > >> > > >> >>>> >>>> exposed to plugins.
>> > >>> > > > >> > > >> >>>> >>>>
>> > >>> > > > >> > > >> >>>> >>>>
>> > >>> > > > >> > > >> >>>> >>>> On Wed, Mar 5, 2014 at 6:57 PM, Joe Bowser
>> > >>> > > > >> > > >> >>>> >>>> <bo...@gmail.com>
>> > >>> > > > >> > > >> wrote:
>> > >>> > > > >> > > >> >>>> >>>>
>> > >>> > > > >> > > >> >>>> >>>> > So, after looking at the Crosswalk code
>> > again,
>> > >>> > > > >> > > >> >>>> >>>> > I've decided to
>> > >>> > > > >> > > >> take
>> > >>> > > > >> > > >> >>>> a
>> > >>> > > > >> > > >> >>>> >>>> > quick stab at making things pluggable.
>> > >>> > > > >> > > >> >>>> >>>> > I
>> > don't
>> > >>> > > > >> > > >> >>>> >>>> > have a lot to
>> > >>> > > > >> > > >> show
>> > >>> > > > >> > > >> >>>> for
>> > >>> > > > >> > > >> >>>> >>>> > it, but with the help of Eclipse (which
>> > >>> > > > >> > > >> >>>> >>>> > is
>> > why
>> > >>> > > > >> > > >> >>>> >>>> > the generated interfaces look so screwed
>> > up), I
>> > >>> > > > >> > > >> >>>> >>>> > managed to create some
>> > >>> > > > >> > > >> interfaces
>> > >>> > > > >> > > >> >>>> so
>> > >>> > > > >> > > >> >>>> >>>> > we can start shoehorning in other
>> > >>> > > > >> > > >> >>>> >>>> > browser
>> > >>> > renderers.
>> > >>> > > > >> > > >> >>>> >>>> >
>> > >>> > > > >> > > >> >>>> >>>> >
>> > >>> > > > >> > > >>
>> > >>> https://github.com/infil00p/cordova-android/tree/pluggable_w
>> > >>> > > > >> > > >> eb
>> > >>> > > > >> > > >> vie
>> > >>> > > > >> > > >> w
>> > >>> > > > >> > > >> >>>> >>>> >
>> > >>> > > > >> > > >> >>>> >>>> > I'm going to probably start with
>> > >>> > > > >> > > >> >>>> >>>> > Crosswalk,
>> > >>> > > > >> > > >> >>>> >>>> > because it's
>> > >>> > > > >> > > >> probably
>> > >>> > > > >> > > >> >>>> the
>> > >>> > > > >> > > >> >>>> >>>> > most mature primary candidate in the
>> > Android
>> > >>> > > > >> > > >> >>>> >>>> > Third-Party
>> > >>> > > > >> > > >> WebView
>> > >>> > > > >> > > >> >>>> >>>> > thing, and I'm pretty sure the GeckoView
>> > will
>> > >>> be
>> > >>> > > > >> > > >> >>>> >>>> > happening
>> > >>> > > > >> > > >> shortly
>> > >>> > > > >> > > >> >>>> >>>> > after.
>> > >>> > > > >> > > >> >>>> >>>> >
>> > >>> > > > >> > > >> >>>> >>>> > I don't know how this would work w.r.t.
>> > the CLI
>> > >>> > > > >> > > >> >>>> >>>> > or our
>> > >>> > > > >> > > >> workflow at
>> > >>> > > > >> > > >> >>>> >>>> > all, but at the moment, I really just
>> > >>> > > > >> > > >> >>>> >>>> > want
>> > to
>> > >>> at
>> > >>> > > > >> > > >> >>>> >>>> > least start
>> > >>> > > > >> > > >> to have
>> > >>> > > > >> > > >> >>>> >>>> > some headway towards 4.x and PhoneGap
>> > >>> > > > >> > > >> >>>> >>>> > day.
>> > >>> > > > >> > > >> >>>> >>>> >
>> > >>> > > > >> > > >> >>>> >>>> > What do people think of this so far? I'm
>> > going
>> > >>> > > > >> > > >> >>>> >>>> > to try to clean
>> > >>> > > > >> > > >> >>>> things
>> > >>> > > > >> > > >> >>>> >>>> > up a bit, since we've definitely done a
>> > lot of
>> > >>> > > > >> > > >> >>>> >>>> > things that
>> > >>> > > > >> > > >> would
>> > >>> > > > >> > > >> >>>> make
>> > >>> > > > >> > > >> >>>> >>>> > first year CS profs freak the hell out
>> > (i.e.
>> > >>> > > > >> > > >> >>>> >>>> > public members in
>> > >>> > > > >> > > >> >>>> public
>> > >>> > > > >> > > >> >>>> >>>> > objects w.r.t. PluginManager).
>> > >>> > > > >> > > >> >>>> >>>> >
>> > >>> > > > >> > > >> >>>> >>>> > Thoughts?
>> > >>> > > > >> > > >> >>>> >>>> >
>> > >>> > > > >> > > >> >>>> >>>> > Joe
>> > >>> > > > >> > > >> >>>> >>>> >
>> > >>> > > > >> > > >> >>>> >>>>
>> > >>> > > > >> > > >> >>>> >>>
>> > >>> > > > >> > > >> >>>> >>>
>> > >>> > > > >> > > >> >>>>
>> > >>> > > > >> > > >>
>> > >>> > > > >> >
>> > >>> >
>> > >>>
>> >
>
>

RE: [Android] Refactoring for different engines

["Hu, Ningxin" <ni...@intel.com>]

Forgot to mention, the test runs on my Nexus 5.

-ningxin

> -----Original Message-----
> From: Hu, Ningxin [mailto:ningxin.hu@intel.com]
> Sent: Thursday, April 24, 2014 5:27 PM
> To: Ian Clelland; Joe Bowser
> Cc: dev@cordova.apache.org
> Subject: RE: [Android] Refactoring for different engines
> 
> > Mobilespec runs on my N4, with 10 failing tests: 3 in contacts; 7 in file-transfer.
> Otherwise, things seem to be working pretty well.
> 
> I checked out the latest code (@691fbce540) and build mbilespec with Crosswalk
> 6.35.127.0. However, it runs on the default Android WebView due to the
> InvocationTargetException when calling constructors of XWalkWebChromeClient
> and XWalkClient. I fixed it at:
> https://github.com/infil00p/cordova-crosswalk-engine/pull/6.
> 
> To make the plugins work on cordova-crosswalk-engine, it still needs to set
> correct webview client, chrome client and enable the setNetworkAvailable. I've
> sent another two PRs.
> https://github.com/infil00p/cordova-crosswalk-engine/pull/7
> https://github.com/infil00p/cordova-android/pull/3
> 
> After these fixes (and with three fixes in plugins to use getPluginManager()
> interface), I can run the mobilespec "Run All Tests" on Crosswalk with all passed
> except Media test. The Media.js seems not be loaded. I didn't have chance to
> debug it yet.
> 
> Ian and Joe, could you please review the PRs? I would appreciate that.
> 
> > I've issued a pull request at
> > https://github.com/infil00p/cordova-crosswalk-engine/pull/5 for it --
> > I'm not sure if there's a way to keep compatibility with last week's
> > Crosswalk, or if we'd even want to. (Ningxin, if you could take a look
> > at that PR and see if it makes sense, I'd appreciate it)
> 
> The PR LGTM! Thanks for the update.
> 
> For crosswalk embedding API compatibility, currently we track the master branch
> of Crosswalk (a.k.a Canary release channel), the embedding API in master is still
> under development. As planned, the Crosswalk-6 will be branched for beta in 4th
> May. In that branch, the embedding API will be stable and only accept bug fixing.
> So for cordova-crosswalk-engine, we can also have crosswalk-6 branch to track
> beta branch (later stable branch) and using master to track the latest crosswalk.
> 
> I am even thinking about we can setup some bots (as buildbots in crosswalk) to
> track if any patches to crosswalk break the cordova-crosswalk-engine.
> 
> Your thoughts?
> 
> Thanks,
> -ningxin
> 
> From: iclelland@google.com [mailto:iclelland@google.com] On Behalf Of Ian
> Clelland
> Sent: Thursday, April 24, 2014 1:32 AM
> To: dev@cordova.apache.org
> Cc: Joe Bowser; Hu, Ningxin
> Subject: Re: [Android] Refactoring for different engines
> 
> I've managed to get this up and running now -- great work on this, Joe!
> 
> Mobilespec runs on my N4, with 10 failing tests: 3 in contacts; 7 in file-transfer.
> Otherwise, things seem to be working pretty well.
> 
> I used a new build of Crosswalk, and found that the embedding API has changed
> since the weekend (when Ningxin's patches applied). I've issued a pull request at
> https://github.com/infil00p/cordova-crosswalk-engine/pull/5 for it -- I'm not sure
> if there's a way to keep compatibility with last week's Crosswalk, or if we'd even
> want to. (Ningxin, if you could take a look at that PR and see if it makes sense, I'd
> appreciate it)
> 
> Joe, I also had to patch the default constructor for XWalkCordovaWebView; it
> wasn't creating its own client objects, so it got the default ones, and most of the
> tests were failing because some component of the bridge wan't working.
> https://github.com/infil00p/cordova-crosswalk-engine/pull/4 is out for that.
> 
> Count me in for the hangout -- this is exciting stuff
> 
> Ian
> 
> On Wed, Apr 23, 2014 at 10:26 AM, Brian LeRoux <b@...@brian.io>>
> wrote:
> Yup I'll track em down
> On Apr 23, 2014 7:17 AM, "Andrew Grieve"
> <ag...@chromium.org>> wrote:
> 
> > Does anyone have a contact at moz that we could invite?
> >
> > On Wed, Apr 23, 2014 at 10:09 AM, Andrew Grieve
> > <ag...@chromium.org>>
> > wrote:
> > > Depends on their interest level I think. Faster we can get this out
> > > the door the better. If we need to delay for geckoview, then I don't
> > > think we should gate on it, just release it after.
> > >
> > > On Wed, Apr 23, 2014 at 3:01 AM, Tommy Williams
> > > <to...@devgeeks.org>>
> > wrote:
> > >> More engines, more better...
> > >> On 23 Apr 2014 16:32, "Joe Bowser"
> <bo...@gmail.com>> wrote:
> > >>
> > >>> Hey
> > >>>
> > >>> A Hangout would have to happen on Friday at the earliest.  It'd be
> > good if
> > >>> we could get someone from Mozilla on the hangout as well.  I
> > >>> haven't
> > gotten
> > >>> MozillaView (GeckoView with Cordova methods) fully working yet.
> > >>> For
> > some
> > >>> reason it's not rendering on the screen.
> > >>>
> > >>> Ideally it'd be cool to have at least two options when this
> > >>> feature
> > finally
> > >>> lands.
> > >>>
> > >>> What do other people think?
> > >>>
> > >>> Joe
> > >>> On 22 Apr 2014 20:06, "Hu, Ningxin"
> <ni...@intel.com>> wrote:
> > >>>
> > >>> > Joe,
> > >>> >
> > >>> > Thanks for your review and merge the PRs.
> > >>> >
> > >>> > To pluggable webview interest group:
> > >>> > Are we OK to setup a hangout this week for initial introduction
> > >>> > and discussion of next steps?
> > >>> >
> > >>> > Thanks,
> > >>> > -ningxin
> > >>> >
> > >>> > > -----Original Message-----
> > >>> > > From: Hu, Ningxin
> > >>> > > [mailto:ningxin.hu@intel.com<ma...@intel.com>]
> > >>> > > Sent: Tuesday, April 22, 2014 4:04 PM
> > >>> > > To: dev@cordova.apache.org<ma...@cordova.apache.org>
> > >>> > > Subject: RE: [Android] Refactoring for different engines
> > >>> > >
> > >>> > > The PoC is great! Quite excited about the direction!
> > >>> > >
> > >>> > > I've sent a PR to update the cordova-crosswalk-engine to
> > >>> > > latest
> > >>> crosswalk
> > >>> > > embedding API. It works with xwalk_core_library at 6.35.124.0.
> > >>> > >
> > >>> > > I've also changed the CordovaWebView interface slightly
> > >>> > > (adding
> > >>> > getView() API)
> > >>> > > to allow XWalkCordovaWebView to composite a XWalkView instead
> > >>> > > of
> > >>> > extending
> > >>> > > it. It resolves some API naming issues for XWalkView case.
> > >>> > >
> > >>> > > Please review them at:
> > >>> > > https://github.com/infil00p/cordova-crosswalk-engine/pull/3
> > >>> > > https://github.com/infil00p/cordova-android/pull/2
> > >>> > >
> > >>> > > Thanks,
> > >>> > > -ningxin
> > >>> > >
> > >>> > > > -----Original Message-----
> > >>> > > > From: Joe Bowser
> > >>> > > > [mailto:bowserj@gmail.com<ma...@gmail.com>]
> > >>> > > > Sent: Friday, April 11, 2014 12:45 AM
> > >>> > > > To: dev
> > >>> > > > Subject: Re: [Android] Refactoring for different engines
> > >>> > > >
> > >>> > > > Yeah, I'd be cool with setting up a hangout.  Everyone
> > >>> > > > should
> > take a
> > >>> > > > look at the PoC, I've basically distilled it down to four or
> > >>> > > > five classes so far, but with some work, we may be able to
> > >>> > > > get it
> > down to
> > >>> > > > three.  Due to legacy, we're pretty stuck with the Android
> > WebView
> > >>> API
> > >>> > calls,
> > >>> > > but these can probably be modified.
> > >>> > > >
> > >>> > > > It'd be good to get Mozilla people on the call as well,
> > >>> > > > since
> > they
> > >>> > > > have their WebView as well.
> > >>> > > >
> > >>> > > > On Thu, Apr 10, 2014 at 9:38 AM, Hu, Ningxin <
> > ningxin.hu@intel.com<ma...@intel.com>>
> > >>> > wrote:
> > >>> > > > > Hangout would be a good idea.
> > >>> > > > >
> > >>> > > > > FYI, I will be off next week. How about the week after next?
> > If it
> > >>> > > > > works, please
> > >>> > > > feel free to schedule one and count me in.
> > >>> > > > >
> > >>> > > > > Thanks,
> > >>> > > > > -ningxin
> > >>> > > > >
> > >>> > > > >> -----Original Message-----
> > >>> > > > >> From: mmocny@google.com<ma...@google.com>
> > >>> > > > >> [mailto:mmocny@google.com<ma...@google.com>] On
> > >>> > > > >> Behalf
> > Of
> > >>> > > > >> Michal Mocny
> > >>> > > > >> Sent: Tuesday, April 08, 2014 11:39 PM
> > >>> > > > >> To: dev
> > >>> > > > >> Subject: Re: [Android] Refactoring for different engines
> > >>> > > > >>
> > >>> > > > >> Would it be alright to set up a Hangout some time to
> > >>> > > > >> introduce
> > >>> > everyone?
> > >>> > > > >>
> > >>> > > > >> Joe has been leading the effort here, but there are other
> > cordova
> > >>> > > > >> contributors for whom this is top priority.  It would be
> > >>> > > > >> nice
> > if
> > >>> we
> > >>> > > > >> could all meet to say hello and make sure we are all
> > >>> > > > >> going in
> > the
> > >>> > > > >> right
> > >>> > > > direction.
> > >>> > > > >>
> > >>> > > > >> Quite exciting!
> > >>> > > > >>
> > >>> > > > >> -Michal
> > >>> > > > >>
> > >>> > > > >>
> > >>> > > > >> On Tue, Apr 8, 2014 at 10:56 AM, Hu, Ningxin <
> > >>> ningxin.hu@intel.com<ma...@intel.com>>
> > >>> > > wrote:
> > >>> > > > >>
> > >>> > > > >> > Joe, thanks for this. I am very excited.
> > >>> > > > >> >
> > >>> > > > >> > FYI. Crosswalk team is working on refactoring the
> > >>> > > > >> > WebView
> > API to
> > >>> > > > >> > support embedding usage better [1]. (Previously the
> > >>> > > > >> > layer
> > API
> > >>> was
> > >>> > > > >> > not exposed as public usage).
> > >>> > > > >> >
> > >>> > > > >> > I would like to review the PoC and work with you to get
> > >>> Crosswalk
> > >>> > > > >> > fits into the pluggable WebView architecture.
> > >>> > > > >> >
> > >>> > > > >> > Thanks,
> > >>> > > > >> > -ningxin
> > >>> > > > >> >
> > >>> > > > >> > > -----Original Message-----
> > >>> > > > >> > > From: Joe Bowser
> > >>> > > > >> > > [mailto:bowserj@gmail.com<ma...@gmail.com>]
> > >>> > > > >> > > Sent: Wednesday, March 19, 2014 7:08 AM
> > >>> > > > >> > > To: dev
> > >>> > > > >> > > Subject: Re: [Android] Refactoring for different
> > >>> > > > >> > > engines
> > >>> > > > >> > >
> > >>> > > > >> > > Hey
> > >>> > > > >> > >
> > >>> > > > >> > > After debugging, I did some minor updates to the
> > >>> > > > >> > > plugin
> > >>> README.
> > >>> > > > >> > > It
> > >>> > > > >> > should be
> > >>> > > > >> > > easier to get this up and running, although there's
> > >>> > > > >> > > still
> > the
> > >>> > > > >> > > issue of
> > >>> > > > >> > after-install
> > >>> > > > >> > > hooks and the relative path weirdness with the
> > >>> > > > >> > > Crosswalk
> > >>> > Library itself.
> > >>> > > > >> > >
> > >>> > > > >> > > It still doesn't support the CLI at all, but it
> > >>> > > > >> > > should be
> > >>> there
> > >>> > > > >> > > with the
> > >>> > > > >> > old flow.
> > >>> > > > >> > >
> > >>> > > > >> > > On Mon, Mar 17, 2014 at 1:14 PM, Michal Mocny
> > >>> > > > >> > > <mm...@chromium.org>>
> > >>> > > > >> > > wrote:
> > >>> > > > >> > > > (Sorry Joe, Googlers are down in California and way
> > busy.
> > >>> > > > >> > > > Will be back in a week.  Super excited about this,
> > though.)
> > >>> > > > >> > > >
> > >>> > > > >> > > > -Michal
> > >>> > > > >> > > >
> > >>> > > > >> > > >
> > >>> > > > >> > > > On Mon, Mar 17, 2014 at 2:53 PM, Joe Bowser
> > >>> > > > >> > > > <bo...@gmail.com>>
> > >>> > > > >> wrote:
> > >>> > > > >> > > >
> > >>> > > > >> > > >> Reviving this thread!
> > >>> > > > >> > > >>
> > >>> > > > >> > > >> Can other people look at this, and see if/when we
> > should
> > >>> > land this?
> > >>> > > > >> > > >> I know that I have to re-write the tests still,
> > >>> > > > >> > > >> but I
> > would
> > >>> > > > >> > > >> like some feedback before merging it in.  Also,
> > >>> > > > >> > > >> it'd be super awesome if other people could try
> > >>> > > > >> > > >> and make a
> > WebView
> > >>> > > > >> > > >> based on the interfaces and recommend which
> > >>> > > > >> > > >> methods
> > should
> > >>> > > > >> > > >> die.  I want to get this released in the next
> > >>> > > > >> > > >> month or
> > so,
> > >>> > > > >> > > >> so any time and feedback would be greatly appreciated.
> > >>> > > > >> > > >>
> > >>> > > > >> > > >> Thanks
> > >>> > > > >> > > >>
> > >>> > > > >> > > >> On Thu, Mar 13, 2014 at 3:50 PM, Joe Bowser
> > >>> > > > >> > > >> <bo...@gmail.com>>
> > >>> > > > >> > wrote:
> > >>> > > > >> > > >> > Hey, I created the following today to track
> > >>> > > > >> > > >> > various WebView
> > >>> > > > >> > progresses:
> > >>> > > > >> > > >> > https://issues.apache.org/jira/browse/CB-6246
> > >>> > > > >> > > >> >
> > >>> > > > >> > > >> > I also have this repo created.  The licensing is
> > ugly as
> > >>> > > > >> > > >> > all crap, but it's a Proof-Of-Concept:
> > >>> > > > >> > > >> > https://github.com/infil00p/cordova-crosswalk-en
> > >>> > > > >> > > >> > gine
> > >>> > > > >> > > >> >
> > >>> > > > >> > > >> > If I can get some help getting plugman to just
> > >>> > > > >> > > >> > load Crosswalk, it'll
> > >>> > > > >> > > >> look hawt.
> > >>> > > > >> > > >> >
> > >>> > > > >> > > >> > BTW: We should probably get this ready to go
> > >>> > > > >> > > >> > into
> > Android
> > >>> > > > >> > > >> > in the next two months and deprecate the
> > >>> > > > >> > > >> > setProperty methods, since all properties should
> > >>> > > > >> > > >> > be preferences
> > in
> > >>> > config.xml
> > >>> > > now.
> > >>> > > > >> > > >> >
> > >>> > > > >> > > >> > On Mon, Mar 10, 2014 at 2:42 PM, Joe Bowser
> > >>> > > > >> > > >> > <bo...@gmail.com>>
> > >>> > > > >> > > wrote:
> > >>> > > > >> > > >> >> Perhaps. There would be additional benefits to
> > >>> > > > >> > > >> >> this approach, namely fixes being added to that
> > >>> > > > >> > > >> >> platform
> > more
> > >>> > > > >> > > >> >> quickly.  I'll probably take a look at that
> > >>> > > > >> > > >> >> once I
> > have
> > >>> > > > >> > > >> >> Crosswalk
> > >>> > > > finalized.
> > >>> > > > >> > > >> >>
> > >>> > > > >> > > >> >> On Mon, Mar 10, 2014 at 9:49 AM, Brian LeRoux
> > >>> > > > >> > > >> >> <b@...@brian.io>>
> > >>> > > > wrote:
> > >>> > > > >> > > >> >>> this is great stuff
> > >>> > > > >> > > >> >>>
> > >>> > > > >> > > >> >>> do we think it may be possible to bring in
> > >>> > > > >> > > >> >>> amazon
> > >>> fireos
> > >>> > > > >> > > >> >>> stuff
> > >>> > > > >> > > >> eventually
> > >>> > > > >> > > >> >>> too?
> > >>> > > > >> > > >> >>>
> > >>> > > > >> > > >> >>>
> > >>> > > > >> > > >> >>> On Fri, Mar 7, 2014 at 3:22 PM, Joe Bowser
> > >>> > > > >> > > >> >>> <bo...@gmail.com>>
> > >>> > > > >> > wrote:
> > >>> > > > >> > > >> >>>
> > >>> > > > >> > > >> >>>> BTW: I committed it in my repo, not the main
> > Apache
> > >>> one.
> > >>> > > > >> > > >> >>>>
> > >>> > > > >> > > >> >>>> On Fri, Mar 7, 2014 at 3:21 PM, Joe Bowser
> > >>> > > > >> > > >> >>>> <bo...@gmail.com>>
> > >>> > > > >> > > wrote:
> > >>> > > > >> > > >> >>>> > Hey
> > >>> > > > >> > > >> >>>> >
> > >>> > > > >> > > >> >>>> > I just committed some code based on their
> > WebView
> > >>> > > > >> > > >> >>>> > modifications that allows you to choose
> > >>> > > > >> > > >> >>>> > your
> > >>> renderer
> > >>> > > > >> > > >> >>>> > in the
> > >>> > > > >> > config file
> > >>> > > > >> > > with this:
> > >>> > > > >> > > >> >>>> >
> > >>> > > > >> > > >> >>>> >     <preference name="webView"
> > >>> > > > >> > > >> >>>> >
> > >>> value="org.apache.cordova.engine.crosswalk.XWalkCordo
> > >>> > > > >> > > >> >>>> > va
> > >>> > > > >> > > >> >>>> > Web
> > >>> > > > >> > > >> >>>> > View
> > >>> > > > >> > > >> >>>> > " />
> > >>> > > > >> > > >> >>>> >
> > >>> > > > >> > > >> >>>> > You currently have to copy over the *.pak
> > >>> > > > >> > > >> >>>> > file
> > and
> > >>> > > > >> > > >> >>>> > the jsapi from a Crosswalk Example project
> > >>> > > > >> > > >> >>>> > to
> > get
> > >>> > > > >> > > >> >>>> > this to work.  The next thing that I'm
> > >>> > > > >> > > >> >>>> > going to
> > do
> > >>> is
> > >>> > > > >> > > >> >>>> > figure out how to write this as a plugin
> > >>> > > > >> > > >> >>>> > and
> > have it
> > >>> > > > >> > > >> >>>> > install on a default
> > >>> > > > project.
> > >>> > > > >> > > >> >>>> > Also, right now the bridge doesn't seem to
> > work, and
> > >>> > > > >> > > >> >>>> > I don't know why exactly.  That being said,
> > >>> > > > >> > > >> >>>> > the
> > >>> > > > >> > > >> fact
> > >>> > > > >> > > >> >>>> > that I can choose which version of
> > Chrome/Chromium
> > >>> > > > >> > > >> >>>> > I'm running with
> > >>> > > > >> > > >> a
> > >>> > > > >> > > >> >>>> > single XML preference is HUGE.
> > >>> > > > >> > > >> >>>> >
> > >>> > > > >> > > >> >>>> > There's definitely a lot more work that
> > >>> > > > >> > > >> >>>> > needs
> > to be
> > >>> > > > >> > > >> >>>> > done, but as
> > >>> > > > >> > > >> long
> > >>> > > > >> > > >> >>>> > as we have something that we can fit into
> > >>> > > > >> > > >> >>>> > the interface, we should
> > >>> > > > >> > > >> be
> > >>> > > > >> > > >> >>>> > able to put in things like GeckoView or
> > >>> > > > >> > > >> >>>> > other
> > third
> > >>> > > > >> > > >> >>>> > party
> > >>> > > > >> > renderers.
> > >>> > > > >> > > >> >>>> > The nightmare of being stuck with bullshit
> > WebView
> > >>> > > > >> > > >> >>>> > bugs may soon be over.
> > >>> > > > >> > > >> >>>> >
> > >>> > > > >> > > >> >>>> > On Wed, Mar 5, 2014 at 8:59 PM, Michal
> > >>> > > > >> > > >> >>>> > Mocny
> > >>> > > > >> > > >> >>>> >
> <mmocny@chromium.org<mailto:mmocny@chromium
> > >>> > > > >> > > >> >>>> > .org>>
> > >>> > > > >> > > >> >>>> wrote:
> > >>> > > > >> > > >> >>>> >>
> > >>> https://github.com/crosswalk-project/crosswalk-cordo
> > >>> > > > >> > > >> >>>> >> va
> > >>> > > > >> > > >> >>>> >> -an
> > >>> > > > >> > > >> >>>> >> droi
> > >>> > > > >> > > >> >>>> >> d
> > >>> > > > >> > > >> >>>> >>
> > >>> > > > >> > > >> >>>> >> First patch they landed, which claims to
> > >>> > > > >> > > >> >>>> >> have
> > min
> > >>> > > > >> > > >> >>>> >> viable xwalk
> > >>> > > > >> > > >> webview:
> > >>> > > > >> > > >> >>>> >>
> > >>> > > > >> > > >> >>>>
> > >>> > > > >> > > >>
> > >>> https://github.com/crosswalk-project/crosswalk-cordova-andro
> > >>> > > > >> > > >> id
> > >>> > > > >> > > >> /co
> > >>> > > > >> > > >> mmit
> > >>> > > > >> > > >> /a04dedeb0204e7542d190312c6ae70c795a26e04
> > >>> > > > >> > > >> >>>> >>
> > >>> > > > >> > > >> >>>> >>
> > >>> > > > >> > > >> >>>> >> On Wed, Mar 5, 2014 at 11:37 PM, Michal
> > >>> > > > >> > > >> >>>> >> Mocny
> > >>> > > > >> > > >> >>>> >>
> <mmocny@chromium.org<mailto:mmocny@chromiu
> > >>> > > > >> > > >> >>>> >> m.org>
> > >>> > > > >> > > >> >
> > >>> > > > >> > > >> >>>> wrote:
> > >>> > > > >> > > >> >>>> >>
> > >>> > > > >> > > >> >>>> >>> I haven't looked yet, but did you see:
> > >>> > > > >> > > >> >>>> >>>
> > >>> https://crosswalk-project.org/#wiki/crosswalk-cordo
> > >>> > > > >> > > >> >>>> >>> va
> > >>> > > > >> > > >> >>>> >>> -an
> > >>> > > > >> > > >> >>>> >>> droi
> > >>> > > > >> > > >> >>>> >>> d
> > >>> > > > >> > > >> >>>> >>>
> > >>> > > > >> > > >> >>>> >>> ?
> > >>> > > > >> > > >> >>>> >>>
> > >>> > > > >> > > >> >>>> >>>
> > >>> > > > >> > > >> >>>> >>> On Wed, Mar 5, 2014 at 10:20 PM, Andrew
> > Grieve <
> > >>> > > > >> > > >> agrieve@chromium.org<ma...@chromium.org>
> > >>> > > > >> > > >> >>>> >wrote:
> > >>> > > > >> > > >> >>>> >>>
> > >>> > > > >> > > >> >>>> >>>> First - very excited that you're working
> > >>> > > > >> > > >> >>>> >>>> on
> > this!
> > >>> > > > >> > > >> >>>> >>>>
> > >>> > > > >> > > >> >>>> >>>> Had a quick look. Not sure there's much
> > >>> > > > >> > > >> >>>> >>>> to be
> > >>> > gleaned
> > >>> > > yet.
> > >>> > > > >> > > >> >>>> >>>> Once
> > >>> > > > >> > > >> you
> > >>> > > > >> > > >> >>>> start
> > >>> > > > >> > > >> >>>> >>>> in on hooking up x-walk's webview I
> > >>> > > > >> > > >> >>>> >>>> think it
> > will
> > >>> > > > >> > > >> >>>> >>>> become more
> > >>> > > > >> > > >> obvious
> > >>> > > > >> > > >> >>>> what
> > >>> > > > >> > > >> >>>> >>>> the interface should look like. E.g.,
> > >>> > > > >> > > >> >>>> >>>> does
> > x-walk
> > >>> > > > >> > > >> >>>> >>>> even have the
> > >>> > > > >> > > >> >>>> concept of
> > >>> > > > >> > > >> >>>> >>>> ChromeClient vs WebViewClient vs WebView?
> > Also
> > >>> > > > >> > > >> >>>> >>>> unsure whether the
> > >>> > > > >> > > >> >>>> class
> > >>> > > > >> > > >> >>>> >>>> should extend android.View as well as
> > implement
> > >>> > > > >> > > >> >>>> >>>> our
> > >>> > > > >> > interface.
> > >>> > > > >> > > >> E.g.
> > >>> > > > >> > > >> >>>> >>>> alternative is to have a "getView()"
> > >>> > > > >> > > >> >>>> >>>> method
> > on
> > >>> the
> > >>> > > > >> > interface.
> > >>> > > > >> > > >> Might
> > >>> > > > >> > > >> >>>> help
> > >>> > > > >> > > >> >>>> >>>> to
> > >>> > > > >> > > >> >>>> >>>> cut down on file sizes, and API surface,
> > >>> > > > >> > > >> >>>> >>>> but again, I'm not too
> > >>> > > > >> > > >> sure.
> > >>> > > > >> > > >> >>>> >>>>
> > >>> > > > >> > > >> >>>> >>>> I've been pretty hesitant to touch
> > >>> > > > >> > > >> >>>> >>>> existing exposed members
> > >>> > > > >> > > >> (e.g. the
> > >>> > > > >> > > >> >>>> >>>> public fields you were referring to)
> > >>> > > > >> > > >> >>>> >>>> since touching anything
> > >>> > > > >> > > >> public
> > >>> > > > >> > > >> >>>> could
> > >>> > > > >> > > >> >>>> >>>> break plugins. That said, maybe now is a
> > >>> > > > >> > > >> >>>> >>>> good
> > >>> time
> > >>> > > > >> > > >> >>>> >>>> to @deprecate
> > >>> > > > >> > > >> a
> > >>> > > > >> > > >> >>>> bunch
> > >>> > > > >> > > >> >>>> >>>> of
> > >>> > > > >> > > >> >>>> >>>> them and either replace them with
> > >>> > > > >> > > >> >>>> >>>> getters, or
> > >>> just
> > >>> > > > >> > > >> >>>> >>>> declare them
> > >>> > > > >> > > >> to be
> > >>> > > > >> > > >> >>>> not
> > >>> > > > >> > > >> >>>> >>>> exposed to plugins.
> > >>> > > > >> > > >> >>>> >>>>
> > >>> > > > >> > > >> >>>> >>>>
> > >>> > > > >> > > >> >>>> >>>> On Wed, Mar 5, 2014 at 6:57 PM, Joe
> > >>> > > > >> > > >> >>>> >>>> Bowser
> > >>> > > > >> > > >> >>>> >>>> <bowserj@gmail.com<mailto:bowserj@gmail.
> > >>> > > > >> > > >> >>>> >>>> com>>
> > >>> > > > >> > > >> wrote:
> > >>> > > > >> > > >> >>>> >>>>
> > >>> > > > >> > > >> >>>> >>>> > So, after looking at the Crosswalk
> > >>> > > > >> > > >> >>>> >>>> > code
> > again,
> > >>> > > > >> > > >> >>>> >>>> > I've decided to
> > >>> > > > >> > > >> take
> > >>> > > > >> > > >> >>>> a
> > >>> > > > >> > > >> >>>> >>>> > quick stab at making things pluggable.
> > >>> > > > >> > > >> >>>> >>>> > I
> > don't
> > >>> > > > >> > > >> >>>> >>>> > have a lot to
> > >>> > > > >> > > >> show
> > >>> > > > >> > > >> >>>> for
> > >>> > > > >> > > >> >>>> >>>> > it, but with the help of Eclipse
> > >>> > > > >> > > >> >>>> >>>> > (which is
> > why
> > >>> > > > >> > > >> >>>> >>>> > the generated interfaces look so
> > >>> > > > >> > > >> >>>> >>>> > screwed
> > up), I
> > >>> > > > >> > > >> >>>> >>>> > managed to create some
> > >>> > > > >> > > >> interfaces
> > >>> > > > >> > > >> >>>> so
> > >>> > > > >> > > >> >>>> >>>> > we can start shoehorning in other
> > >>> > > > >> > > >> >>>> >>>> > browser
> > >>> > renderers.
> > >>> > > > >> > > >> >>>> >>>> >
> > >>> > > > >> > > >> >>>> >>>> >
> > >>> > > > >> > > >>
> > >>> https://github.com/infil00p/cordova-android/tree/pluggable_w
> > >>> > > > >> > > >> eb
> > >>> > > > >> > > >> vie
> > >>> > > > >> > > >> w
> > >>> > > > >> > > >> >>>> >>>> >
> > >>> > > > >> > > >> >>>> >>>> > I'm going to probably start with
> > >>> > > > >> > > >> >>>> >>>> > Crosswalk, because it's
> > >>> > > > >> > > >> probably
> > >>> > > > >> > > >> >>>> the
> > >>> > > > >> > > >> >>>> >>>> > most mature primary candidate in the
> > Android
> > >>> > > > >> > > >> >>>> >>>> > Third-Party
> > >>> > > > >> > > >> WebView
> > >>> > > > >> > > >> >>>> >>>> > thing, and I'm pretty sure the
> > >>> > > > >> > > >> >>>> >>>> > GeckoView
> > will
> > >>> be
> > >>> > > > >> > > >> >>>> >>>> > happening
> > >>> > > > >> > > >> shortly
> > >>> > > > >> > > >> >>>> >>>> > after.
> > >>> > > > >> > > >> >>>> >>>> >
> > >>> > > > >> > > >> >>>> >>>> > I don't know how this would work w.r.t.
> > the CLI
> > >>> > > > >> > > >> >>>> >>>> > or our
> > >>> > > > >> > > >> workflow at
> > >>> > > > >> > > >> >>>> >>>> > all, but at the moment, I really just
> > >>> > > > >> > > >> >>>> >>>> > want
> > to
> > >>> at
> > >>> > > > >> > > >> >>>> >>>> > least start
> > >>> > > > >> > > >> to have
> > >>> > > > >> > > >> >>>> >>>> > some headway towards 4.x and PhoneGap
> day.
> > >>> > > > >> > > >> >>>> >>>> >
> > >>> > > > >> > > >> >>>> >>>> > What do people think of this so far?
> > >>> > > > >> > > >> >>>> >>>> > I'm
> > going
> > >>> > > > >> > > >> >>>> >>>> > to try to clean
> > >>> > > > >> > > >> >>>> things
> > >>> > > > >> > > >> >>>> >>>> > up a bit, since we've definitely done
> > >>> > > > >> > > >> >>>> >>>> > a
> > lot of
> > >>> > > > >> > > >> >>>> >>>> > things that
> > >>> > > > >> > > >> would
> > >>> > > > >> > > >> >>>> make
> > >>> > > > >> > > >> >>>> >>>> > first year CS profs freak the hell out
> > (i.e.
> > >>> > > > >> > > >> >>>> >>>> > public members in
> > >>> > > > >> > > >> >>>> public
> > >>> > > > >> > > >> >>>> >>>> > objects w.r.t. PluginManager).
> > >>> > > > >> > > >> >>>> >>>> >
> > >>> > > > >> > > >> >>>> >>>> > Thoughts?
> > >>> > > > >> > > >> >>>> >>>> >
> > >>> > > > >> > > >> >>>> >>>> > Joe
> > >>> > > > >> > > >> >>>> >>>> >
> > >>> > > > >> > > >> >>>> >>>>
> > >>> > > > >> > > >> >>>> >>>
> > >>> > > > >> > > >> >>>> >>>
> > >>> > > > >> > > >> >>>>
> > >>> > > > >> > > >>
> > >>> > > > >> >
> > >>> >
> > >>>
> >

RE: [Android] Refactoring for different engines

["Hu, Ningxin" <ni...@intel.com>]

> -----Original Message-----
> From: Ian Clelland [mailto:iclelland@google.com]
> Sent: Wednesday, May 21, 2014 9:04 PM
> To: dev@cordova.apache.org
> Subject: Re: [Android] Refactoring for different engines
> 
> That's great news!
> 

Really!

> Do you want to clone it from my repo at
> https://github.com/clelland/cordova-crosswalk-engine ? I think that's the most
> up-to-date repo; it's the one that I have working in all of my tests.
> 

I am fine to work on your fork till we think it is ready for some releases (maybe 3.6.0?).
What do you think?

Thanks,
-ningxin

> Ian
> 
> 
> On Tue, May 20, 2014 at 10:51 PM, Hu, Ningxin <ni...@intel.com> wrote:
> 
> > An update: the legal/license is cleared to host
> > cordova-crosswalk-engine under https://github.com/crosswalk-project/.
> >
> > Thanks,
> > -ningxin
> >
> > > -----Original Message-----
> > > From: Hu, Ningxin [mailto:ningxin.hu@intel.com]
> > > Sent: Tuesday, May 06, 2014 8:56 AM
> > > To: dev@cordova.apache.org
> > > Subject: RE: [Android] Refactoring for different engines
> > >
> > > Ian,
> > >
> > > I initiated the proposal to crosswalk stakeholders about hosting the
> > Crosswalk
> > > Cordova Engine in Crosswalk projects. The feedback is very positive.
> > > I
> > am now
> > > going through the required legal/license clearance process. I will
> > > keep
> > you posted
> > > about the status.
> > >
> > > Thanks,
> > > -ningxin
> > >
> > > > -----Original Message-----
> > > > From: iclelland@google.com [mailto:iclelland@google.com] On Behalf
> > > > Of Ian Clelland
> > > > Sent: Wednesday, April 30, 2014 2:23 AM
> > > > To: dev@cordova.apache.org
> > > > Subject: Re: [Android] Refactoring for different engines
> > > >
> > > > On Tue, Apr 29, 2014 at 10:55 AM, Joe Bowser <bo...@gmail.com>
> > wrote:
> > > >
> > > > > So, when Apache publishes something, it has fill the following
> > criteria:
> > > > >
> > > > > - All source code must have their licence headers intact
> > > > > - All third-party source code must be mentioned in the NOTICE
> > > > > file
> > > > > - No Binary Blobs - No compiled libraries, which include JARs
> > > > > and shared object files (including the pak).
> > > > >
> > > > > Now, with Crosswalk, there's obviously the Chromium Library that
> > > > > we need, so we need a way to get that into the generated project
> > somehow.
> > > > >  The easiest way is with plugman, but the issue is that Apache
> > > > > can't legally pass around binary blobs when it does an official
> > > > > release of anything.  Intel, OTOH, isn't restricted by
> > > > > cumbersome open source foundation rules, and can do so.
> > > > >
> > > >
> > > > Intel has their own rules to follow, certainly, but we're
> > > > presuming here that Intel has already worked out the legal
> > > > requirements to distribute Crosswalk in the first place, so the
> > > > idea of Intel also distributing the "official" Crosswalk Cordova
> > > > Engine plugin just seems
> > to make a
> > > lot of sense.
> > > >
> > > > Apache distributes Cordova-Android, which defines the integration
> > > > API, and includes the default AndroidWebView classes, and other
> > > > parties should be free to distribute their own engine plugins,
> > > > implementing that API. That distribution can then be in any form
> > > > that makes sense (and complies with the licenses of the various
> > > > components)
> > > >
> > > > Joe's right that it would be awkward, if not impossible, for
> > > > Apache to distribute the Crosswalk core library. We'd have to
> > > > include the 15GB of source as well, at the very least, and that
> > > > doesn't sound like fun
> > at all.
> > > > It *is* all open-source, but there are a lot of different licenses
> > > > in there, and we'd need some lawyerly help to make sure that the
> > > > ASF could release software that included it all.
> > > >
> > > > Ian
> > > >
> > > >
> > > > > On Tue, Apr 29, 2014 at 7:43 AM, Hu, Ningxin
> > > > > <ni...@intel.com>
> > wrote:
> > > > > >> - who publishes the plugins, intel or cordova?
> > > > > >
> > > > > > For this open, could someone elaborate it a little bit more?
> > > > > > What does
> > > > > it mean? I remembered someone mentioned the license is open in
> > > > > the hangouts, any details?
> > > > > >
> > > > > > Thanks,
> > > > > > -ningxin
> > > > > >
> > > > > >> -----Original Message-----
> > > > > >> From: mmocny@google.com [mailto:mmocny@google.com] On Behalf
> > > > > >> Of Michal Mocny
> > > > > >> Sent: Saturday, April 26, 2014 12:53 AM
> > > > > >> To: dev
> > > > > >> Subject: Re: [Android] Refactoring for different engines
> > > > > >>
> > > > > >> Notes:
> > > > > >>
> > > > > >> - native junit tests needs fixing (due to deprication)
> > > > > >>
> > > > > >> - common script for creating walk mobilespec
> > > > > >>
> > > > > >> - fix failing mobile spec tests (file-transfer?, media?)
> > > > > >>
> > > > > >> - who publishes the plugins, intel or cordova?
> > > > > >>
> > > > > >> - static vs dynamic xwalk lib
> > > > > >>
> > > > > >>   - (option) one plugin, use hooks to download static library
> > > > > >>
> > > > > >>   - (option) one plugin, just bundle static lib
> > > > > >>
> > > > > >>   - (option) one plugin, download static lib on app run
> > > > > >>
> > > > > >>   - (option) two plugins, xwalk lib bundled in a separate
> > > > > >> plugin, and
> > > > > can be added
> > > > > >> as a <dep>?
> > > > > >>
> > > > > >> - intel vs arm binary apk targets for CLI.  Two android
> > > > > >> platforms, or
> > > > > just two build
> > > > > >> targets?
> > > > > >>
> > > > > >> - How long to get GeckoView: Joe not sure. days to weeks :(
> > > > > >>
> > > > > >>   - Not blocking, though
> > > > > >>
> > > > > >> - plugman works to install but CLI does not, lets figure that
> > > > > >> out
> > > > > >>
> > > > > >> - Other platforms: Windows Phone support!?  BB10?!
> > > > > >>
> > > > > >> - Can we share code between xwalk WebViewClient and gecko
> > > > > >> view WebViewClient etc?
> > > > > >>
> > > > > >>
> > > > > >> On Fri, Apr 25, 2014 at 12:09 PM, Josh Soref
> > > > > >> <js...@blackberry.com>
> > > > > wrote:
> > > > > >>
> > > > > >> > Ian Clelland wrote:
> > > > > >> >
> > > > > >> > >
> > > > > >> >
> > > > > https://staging.talkgadget.google.com/hangouts/_/7ecpi3uaclcuedn
> > > > > 7imn
> > > > > 6b
> > > > > >> > 9jdq
> > > > > >> > >c
> > > > > >> >
> > > > > >> > https://talkgadget.google.com/hangouts/_/7ecpi3uaclcuedn7im
> > > > > >> > n6b9
> > > > > >> > jd
> > > > > >> > qc
> > > > > >> >
> > > > > >> > Might work. Staging is probably internal.
> > > > > >> >
> > > > > >> >
> > > > >
> >

RE: [Android] Refactoring for different engines

["Hu, Ningxin" <ni...@intel.com>]

> Ian wrote:
> That's correct -- is there a more recent crosswalk available? I'd like to keep up
> with the development there.
> 

If you prefer to keep up the ToT, the canary release is closest one (daily ToT build). 
You can download it from https://download.01.org/crosswalk/releases/crosswalk/android/canary/. 
The latest canary is 7.35.143.0 which I verified working with the latest cordova-crosswalk-engine and pluggable_webview.

What's your plan to sync up with Crosswalk release, daily, weekly? Crosswalk has canary, beta and stable concepts similar to Chrome.

Thanks,
-ningxin

> >
> > Thanks,
> > -ningxin
> >
> > > I can add the library project to my repo (it's about 34MB, and
> > > ARM-only
> > at the
> > > moment), but we'd still be waiting on CB-6698 to land before plugman
> > will be
> > > able to link it automatically.
> > >
> > >
> > > On Wed, May 21, 2014 at 9:04 AM, Ian Clelland <ic...@google.com>
> > wrote:
> > >
> > > > That's great news!
> > > >
> > > > Do you want to clone it from my repo at
> > > > https://github.com/clelland/cordova-crosswalk-engine ? I think
> > > > that's the most up-to-date repo; it's the one that I have working
> > > > in all of
> > my tests.
> > > >
> > > > Ian
> > > >
> > > >
> > > > On Tue, May 20, 2014 at 10:51 PM, Hu, Ningxin
> > > > <ningxin.hu@intel.com
> > >wrote:
> > > >
> > > >> An update: the legal/license is cleared to host
> > > >> cordova-crosswalk-engine under https://github.com/crosswalk-project/.
> > > >>
> > > >> Thanks,
> > > >> -ningxin
> > > >>
> > > >> > -----Original Message-----
> > > >> > From: Hu, Ningxin [mailto:ningxin.hu@intel.com]
> > > >> > Sent: Tuesday, May 06, 2014 8:56 AM
> > > >> > To: dev@cordova.apache.org
> > > >> > Subject: RE: [Android] Refactoring for different engines
> > > >> >
> > > >> > Ian,
> > > >> >
> > > >> > I initiated the proposal to crosswalk stakeholders about
> > > >> > hosting the
> > > >> Crosswalk
> > > >> > Cordova Engine in Crosswalk projects. The feedback is very
> > > >> > positive. I
> > > >> am now
> > > >> > going through the required legal/license clearance process. I
> > > >> > will keep
> > > >> you posted
> > > >> > about the status.
> > > >> >
> > > >> > Thanks,
> > > >> > -ningxin
> > > >> >
> > > >> > > -----Original Message-----
> > > >> > > From: iclelland@google.com [mailto:iclelland@google.com] On
> > > >> > > Behalf Of Ian Clelland
> > > >> > > Sent: Wednesday, April 30, 2014 2:23 AM
> > > >> > > To: dev@cordova.apache.org
> > > >> > > Subject: Re: [Android] Refactoring for different engines
> > > >> > >
> > > >> > > On Tue, Apr 29, 2014 at 10:55 AM, Joe Bowser
> > > >> > > <bo...@gmail.com>
> > > >> wrote:
> > > >> > >
> > > >> > > > So, when Apache publishes something, it has fill the
> > > >> > > > following
> > > >> criteria:
> > > >> > > >
> > > >> > > > - All source code must have their licence headers intact
> >

Re: [Android] Refactoring for different engines

[Ian Clelland <ic...@google.com>]

On Thursday, May 22, 2014, Hu, Ningxin <ni...@intel.com> wrote:

> Hi Ian,
>
> > The plugin *almost* works out-of-the box with the latest cordova-android
> > pluggable_webview branch. The only thing that is missing is the library
> project.
> >
>
> I tried https://github.com/clelland/cordova-crosswalk-engine and
> https://github.com/apache/cordova-android/tree/pluggable_webview with
> latest Crosswalk-6 beta which is the first beta release with xwalk webview (
> https://download.01.org/crosswalk/releases/crosswalk/android/beta/6.35.131.6/arm/crosswalk-webview-6.35.131.6-arm.zip
> ).
> It works with two minor fixes. I've sent a PR
> https://github.com/clelland/cordova-crosswalk-engine/pull/1. Please have
> a look.


Thanks, those look right. I'll pull them in.


>
> I noticed you are also working on
> https://github.com/apache/cordova-android/tree/backwards_compat, is it
> related to pluggable_webview refactoring?


That was an attempted refactoring that we probably won't end up using. It
keeps better backwards compatibility with some existing plugins, but Joe
points out that it will likely break other workflows.

>
> I would like to sync with you the working repos:
> https://github.com/apache/cordova-android/tree/pluggable_webview
> https://github.com/clelland/cordova-crosswalk-engine
> and Crosswalk 6.x (latest one is 6.35.131.6)
>
> Are they correct?


That's correct -- is there a more recent crosswalk available? I'd like to
keep up with the development there.

>
> Thanks,
> -ningxin
>
> > I can add the library project to my repo (it's about 34MB, and ARM-only
> at the
> > moment), but we'd still be waiting on CB-6698 to land before plugman
> will be
> > able to link it automatically.
> >
> >
> > On Wed, May 21, 2014 at 9:04 AM, Ian Clelland <ic...@google.com>
> wrote:
> >
> > > That's great news!
> > >
> > > Do you want to clone it from my repo at
> > > https://github.com/clelland/cordova-crosswalk-engine ? I think that's
> > > the most up-to-date repo; it's the one that I have working in all of
> my tests.
> > >
> > > Ian
> > >
> > >
> > > On Tue, May 20, 2014 at 10:51 PM, Hu, Ningxin <ningxin.hu@intel.com
> >wrote:
> > >
> > >> An update: the legal/license is cleared to host
> > >> cordova-crosswalk-engine under https://github.com/crosswalk-project/.
> > >>
> > >> Thanks,
> > >> -ningxin
> > >>
> > >> > -----Original Message-----
> > >> > From: Hu, Ningxin [mailto:ningxin.hu@intel.com]
> > >> > Sent: Tuesday, May 06, 2014 8:56 AM
> > >> > To: dev@cordova.apache.org
> > >> > Subject: RE: [Android] Refactoring for different engines
> > >> >
> > >> > Ian,
> > >> >
> > >> > I initiated the proposal to crosswalk stakeholders about hosting
> > >> > the
> > >> Crosswalk
> > >> > Cordova Engine in Crosswalk projects. The feedback is very
> > >> > positive. I
> > >> am now
> > >> > going through the required legal/license clearance process. I will
> > >> > keep
> > >> you posted
> > >> > about the status.
> > >> >
> > >> > Thanks,
> > >> > -ningxin
> > >> >
> > >> > > -----Original Message-----
> > >> > > From: iclelland@google.com [mailto:iclelland@google.com] On
> > >> > > Behalf Of Ian Clelland
> > >> > > Sent: Wednesday, April 30, 2014 2:23 AM
> > >> > > To: dev@cordova.apache.org
> > >> > > Subject: Re: [Android] Refactoring for different engines
> > >> > >
> > >> > > On Tue, Apr 29, 2014 at 10:55 AM, Joe Bowser <bo...@gmail.com>
> > >> wrote:
> > >> > >
> > >> > > > So, when Apache publishes something, it has fill the following
> > >> criteria:
> > >> > > >
> > >> > > > - All source code must have their licence headers intact
>

RE: [Android] Refactoring for different engines

["Hu, Ningxin" <ni...@intel.com>]

Hi Ian,

> The plugin *almost* works out-of-the box with the latest cordova-android
> pluggable_webview branch. The only thing that is missing is the library project.
> 

I tried https://github.com/clelland/cordova-crosswalk-engine and https://github.com/apache/cordova-android/tree/pluggable_webview with latest Crosswalk-6 beta which is the first beta release with xwalk webview (https://download.01.org/crosswalk/releases/crosswalk/android/beta/6.35.131.6/arm/crosswalk-webview-6.35.131.6-arm.zip). 
It works with two minor fixes. I've sent a PR https://github.com/clelland/cordova-crosswalk-engine/pull/1. Please have a look.

I noticed you are also working on https://github.com/apache/cordova-android/tree/backwards_compat, is it related to pluggable_webview refactoring?

I would like to sync with you the working repos:
https://github.com/apache/cordova-android/tree/pluggable_webview
https://github.com/clelland/cordova-crosswalk-engine
and Crosswalk 6.x (latest one is 6.35.131.6)

Are they correct?

Thanks,
-ningxin

> I can add the library project to my repo (it's about 34MB, and ARM-only at the
> moment), but we'd still be waiting on CB-6698 to land before plugman will be
> able to link it automatically.
> 
> 
> On Wed, May 21, 2014 at 9:04 AM, Ian Clelland <ic...@google.com> wrote:
> 
> > That's great news!
> >
> > Do you want to clone it from my repo at
> > https://github.com/clelland/cordova-crosswalk-engine ? I think that's
> > the most up-to-date repo; it's the one that I have working in all of my tests.
> >
> > Ian
> >
> >
> > On Tue, May 20, 2014 at 10:51 PM, Hu, Ningxin <ni...@intel.com>wrote:
> >
> >> An update: the legal/license is cleared to host
> >> cordova-crosswalk-engine under https://github.com/crosswalk-project/.
> >>
> >> Thanks,
> >> -ningxin
> >>
> >> > -----Original Message-----
> >> > From: Hu, Ningxin [mailto:ningxin.hu@intel.com]
> >> > Sent: Tuesday, May 06, 2014 8:56 AM
> >> > To: dev@cordova.apache.org
> >> > Subject: RE: [Android] Refactoring for different engines
> >> >
> >> > Ian,
> >> >
> >> > I initiated the proposal to crosswalk stakeholders about hosting
> >> > the
> >> Crosswalk
> >> > Cordova Engine in Crosswalk projects. The feedback is very
> >> > positive. I
> >> am now
> >> > going through the required legal/license clearance process. I will
> >> > keep
> >> you posted
> >> > about the status.
> >> >
> >> > Thanks,
> >> > -ningxin
> >> >
> >> > > -----Original Message-----
> >> > > From: iclelland@google.com [mailto:iclelland@google.com] On
> >> > > Behalf Of Ian Clelland
> >> > > Sent: Wednesday, April 30, 2014 2:23 AM
> >> > > To: dev@cordova.apache.org
> >> > > Subject: Re: [Android] Refactoring for different engines
> >> > >
> >> > > On Tue, Apr 29, 2014 at 10:55 AM, Joe Bowser <bo...@gmail.com>
> >> wrote:
> >> > >
> >> > > > So, when Apache publishes something, it has fill the following
> >> criteria:
> >> > > >
> >> > > > - All source code must have their licence headers intact
> >> > > > - All third-party source code must be mentioned in the NOTICE
> >> > > > file
> >> > > > - No Binary Blobs - No compiled libraries, which include JARs
> >> > > > and shared object files (including the pak).
> >> > > >
> >> > > > Now, with Crosswalk, there's obviously the Chromium Library
> >> > > > that we need, so we need a way to get that into the generated
> >> > > > project
> >> somehow.
> >> > > >  The easiest way is with plugman, but the issue is that Apache
> >> > > > can't legally pass around binary blobs when it does an official
> >> > > > release of anything.  Intel, OTOH, isn't restricted by
> >> > > > cumbersome open source foundation rules, and can do so.
> >> > > >
> >> > >
> >> > > Intel has their own rules to follow, certainly, but we're
> >> > > presuming here that Intel has already worked out the legal
> >> > > requirements to distribute Crosswalk in the first place, so the
> >> > > idea of Intel also distributing the "official" Crosswalk Cordova
> >> > > Engine plugin just
> >> seems to make a
> >> > lot of sense.
> >> > >
> >> > > Apache distributes Cordova-Android, which defines the integration
> >> > > API, and includes the default AndroidWebView classes, and other
> >> > > parties should be free to distribute their own engine plugins,
> >> > > implementing that API. That distribution can then be in any form
> >> > > that makes sense (and complies with the licenses of the various
> >> > > components)
> >> > >
> >> > > Joe's right that it would be awkward, if not impossible, for
> >> > > Apache to distribute the Crosswalk core library. We'd have to
> >> > > include the 15GB of source as well, at the very least, and that
> >> > > doesn't sound like fun
> >> at all.
> >> > > It *is* all open-source, but there are a lot of different
> >> > > licenses in there, and we'd need some lawyerly help to make sure
> >> > > that the ASF could release software that included it all.
> >> > >
> >> > > Ian
> >> > >
> >> > >
> >> > > > On Tue, Apr 29, 2014 at 7:43 AM, Hu, Ningxin
> >> > > > <ni...@intel.com>
> >> wrote:
> >> > > > >> - who publishes the plugins, intel or cordova?
> >> > > > >
> >> > > > > For this open, could someone elaborate it a little bit more?
> >> > > > > What does
> >> > > > it mean? I remembered someone mentioned the license is open in
> >> > > > the hangouts, any details?
> >> > > > >
> >> > > > > Thanks,
> >> > > > > -ningxin
> >> > > > >
> >> > > > >> -----Original Message-----
> >> > > > >> From: mmocny@google.com [mailto:mmocny@google.com] On
> Behalf
> >> > > > >> Of Michal Mocny
> >> > > > >> Sent: Saturday, April 26, 2014 12:53 AM
> >> > > > >> To: dev
> >> > > > >> Subject: Re: [Android] Refactoring for different engines
> >> > > > >>
> >> > > > >> Notes:
> >> > > > >>
> >> > > > >> - native junit tests needs fixing (due to deprication)
> >> > > > >>
> >> > > > >> - common script for creating walk mobilespec
> >> > > > >>
> >> > > > >> - fix failing mobile spec tests (file-transfer?, media?)
> >> > > > >>
> >> > > > >> - who publishes the plugins, intel or cordova?
> >> > > > >>
> >> > > > >> - static vs dynamic xwalk lib
> >> > > > >>
> >> > > > >>   - (option) one plugin, use hooks to download static
> >> > > > >> library
> >> > > > >>
> >> > > > >>   - (option) one plugin, just bundle static lib
> >> > > > >>
> >> > > > >>   - (option) one plugin, download static lib on app run
> >> > > > >>
> >> > > > >>   - (option) two plugins, xwalk lib bundled in a separate
> >> > > > >> plugin, and
> >> > > > can be added
> >> > > > >> as a <dep>?
> >> > > > >>
> >> > > > >> - intel vs arm binary apk targets for CLI.  Two android
> >> > > > >> platforms, or
> >> > > > just two build
> >> > > > >> targets?
> >> > > > >>
> >> > > > >> - How long to get GeckoView: Joe not sure. days to weeks :(
> >> > > > >>
> >> > > > >>   - Not blocking, though
> >> > > > >>
> >> > > > >> - plugman works to install but CLI does not, lets figure
> >> > > > >> that out
> >> > > > >>
> >> > > > >> - Other platforms: Windows Phone support!?  BB10?!
> >> > > > >>
> >> > > > >> - Can we share code between xwalk WebViewClient and gecko
> >> > > > >> view WebViewClient etc?
> >> > > > >>
> >> > > > >>
> >> > > > >> On Fri, Apr 25, 2014 at 12:09 PM, Josh Soref
> >> > > > >> <js...@blackberry.com>
> >> > > > wrote:
> >> > > > >>
> >> > > > >> > Ian Clelland wrote:
> >> > > > >> >
> >> > > > >> > >
> >> > > > >> >
> >> > > >
> >> https://staging.talkgadget.google.com/hangouts/_/7ecpi3uaclcuedn7imn
> >> > > > 6b
> >> > > > >> > 9jdq
> >> > > > >> > >c
> >> > > > >> >
> >> > > > >> >
> >> https://talkgadget.google.com/hangouts/_/7ecpi3uaclcuedn7imn6b9
> >> > > > >> > jd
> >> > > > >> > qc
> >> > > > >> >
> >> > > > >> > Might work. Staging is probably internal.
> >> > > > >> >
> >> > > > >> >
> >> > > >
> >>
> >
> >

Re: [Android] Refactoring for different engines

[Ian Clelland <ic...@chromium.org>]

The plugin *almost* works out-of-the box with the latest cordova-android
pluggable_webview branch. The only thing that is missing is the library
project.

I can add the library project to my repo (it's about 34MB, and ARM-only at
the moment), but we'd still be waiting on CB-6698 to land before plugman
will be able to link it automatically.


On Wed, May 21, 2014 at 9:04 AM, Ian Clelland <ic...@google.com> wrote:

> That's great news!
>
> Do you want to clone it from my repo at
> https://github.com/clelland/cordova-crosswalk-engine ? I think that's the
> most up-to-date repo; it's the one that I have working in all of my tests.
>
> Ian
>
>
> On Tue, May 20, 2014 at 10:51 PM, Hu, Ningxin <ni...@intel.com>wrote:
>
>> An update: the legal/license is cleared to host cordova-crosswalk-engine
>> under https://github.com/crosswalk-project/.
>>
>> Thanks,
>> -ningxin
>>
>> > -----Original Message-----
>> > From: Hu, Ningxin [mailto:ningxin.hu@intel.com]
>> > Sent: Tuesday, May 06, 2014 8:56 AM
>> > To: dev@cordova.apache.org
>> > Subject: RE: [Android] Refactoring for different engines
>> >
>> > Ian,
>> >
>> > I initiated the proposal to crosswalk stakeholders about hosting the
>> Crosswalk
>> > Cordova Engine in Crosswalk projects. The feedback is very positive. I
>> am now
>> > going through the required legal/license clearance process. I will keep
>> you posted
>> > about the status.
>> >
>> > Thanks,
>> > -ningxin
>> >
>> > > -----Original Message-----
>> > > From: iclelland@google.com [mailto:iclelland@google.com] On Behalf Of
>> > > Ian Clelland
>> > > Sent: Wednesday, April 30, 2014 2:23 AM
>> > > To: dev@cordova.apache.org
>> > > Subject: Re: [Android] Refactoring for different engines
>> > >
>> > > On Tue, Apr 29, 2014 at 10:55 AM, Joe Bowser <bo...@gmail.com>
>> wrote:
>> > >
>> > > > So, when Apache publishes something, it has fill the following
>> criteria:
>> > > >
>> > > > - All source code must have their licence headers intact
>> > > > - All third-party source code must be mentioned in the NOTICE file
>> > > > - No Binary Blobs - No compiled libraries, which include JARs and
>> > > > shared object files (including the pak).
>> > > >
>> > > > Now, with Crosswalk, there's obviously the Chromium Library that we
>> > > > need, so we need a way to get that into the generated project
>> somehow.
>> > > >  The easiest way is with plugman, but the issue is that Apache can't
>> > > > legally pass around binary blobs when it does an official release of
>> > > > anything.  Intel, OTOH, isn't restricted by cumbersome open source
>> > > > foundation rules, and can do so.
>> > > >
>> > >
>> > > Intel has their own rules to follow, certainly, but we're presuming
>> > > here that Intel has already worked out the legal requirements to
>> > > distribute Crosswalk in the first place, so the idea of Intel also
>> > > distributing the "official" Crosswalk Cordova Engine plugin just
>> seems to make a
>> > lot of sense.
>> > >
>> > > Apache distributes Cordova-Android, which defines the integration API,
>> > > and includes the default AndroidWebView classes, and other parties
>> > > should be free to distribute their own engine plugins, implementing
>> > > that API. That distribution can then be in any form that makes sense
>> > > (and complies with the licenses of the various components)
>> > >
>> > > Joe's right that it would be awkward, if not impossible, for Apache to
>> > > distribute the Crosswalk core library. We'd have to include the 15GB
>> > > of source as well, at the very least, and that doesn't sound like fun
>> at all.
>> > > It *is* all open-source, but there are a lot of different licenses in
>> > > there, and we'd need some lawyerly help to make sure that the ASF
>> > > could release software that included it all.
>> > >
>> > > Ian
>> > >
>> > >
>> > > > On Tue, Apr 29, 2014 at 7:43 AM, Hu, Ningxin <ni...@intel.com>
>> wrote:
>> > > > >> - who publishes the plugins, intel or cordova?
>> > > > >
>> > > > > For this open, could someone elaborate it a little bit more? What
>> > > > > does
>> > > > it mean? I remembered someone mentioned the license is open in the
>> > > > hangouts, any details?
>> > > > >
>> > > > > Thanks,
>> > > > > -ningxin
>> > > > >
>> > > > >> -----Original Message-----
>> > > > >> From: mmocny@google.com [mailto:mmocny@google.com] On Behalf Of
>> > > > >> Michal Mocny
>> > > > >> Sent: Saturday, April 26, 2014 12:53 AM
>> > > > >> To: dev
>> > > > >> Subject: Re: [Android] Refactoring for different engines
>> > > > >>
>> > > > >> Notes:
>> > > > >>
>> > > > >> - native junit tests needs fixing (due to deprication)
>> > > > >>
>> > > > >> - common script for creating walk mobilespec
>> > > > >>
>> > > > >> - fix failing mobile spec tests (file-transfer?, media?)
>> > > > >>
>> > > > >> - who publishes the plugins, intel or cordova?
>> > > > >>
>> > > > >> - static vs dynamic xwalk lib
>> > > > >>
>> > > > >>   - (option) one plugin, use hooks to download static library
>> > > > >>
>> > > > >>   - (option) one plugin, just bundle static lib
>> > > > >>
>> > > > >>   - (option) one plugin, download static lib on app run
>> > > > >>
>> > > > >>   - (option) two plugins, xwalk lib bundled in a separate plugin,
>> > > > >> and
>> > > > can be added
>> > > > >> as a <dep>?
>> > > > >>
>> > > > >> - intel vs arm binary apk targets for CLI.  Two android
>> > > > >> platforms, or
>> > > > just two build
>> > > > >> targets?
>> > > > >>
>> > > > >> - How long to get GeckoView: Joe not sure. days to weeks :(
>> > > > >>
>> > > > >>   - Not blocking, though
>> > > > >>
>> > > > >> - plugman works to install but CLI does not, lets figure that out
>> > > > >>
>> > > > >> - Other platforms: Windows Phone support!?  BB10?!
>> > > > >>
>> > > > >> - Can we share code between xwalk WebViewClient and gecko view
>> > > > >> WebViewClient etc?
>> > > > >>
>> > > > >>
>> > > > >> On Fri, Apr 25, 2014 at 12:09 PM, Josh Soref
>> > > > >> <js...@blackberry.com>
>> > > > wrote:
>> > > > >>
>> > > > >> > Ian Clelland wrote:
>> > > > >> >
>> > > > >> > >
>> > > > >> >
>> > > >
>> https://staging.talkgadget.google.com/hangouts/_/7ecpi3uaclcuedn7imn
>> > > > 6b
>> > > > >> > 9jdq
>> > > > >> > >c
>> > > > >> >
>> > > > >> >
>> https://talkgadget.google.com/hangouts/_/7ecpi3uaclcuedn7imn6b9
>> > > > >> > jd
>> > > > >> > qc
>> > > > >> >
>> > > > >> > Might work. Staging is probably internal.
>> > > > >> >
>> > > > >> >
>> > > >
>>
>
>

Re: [Android] Refactoring for different engines

[Ian Clelland <ic...@google.com>]

That's great news!

Do you want to clone it from my repo at
https://github.com/clelland/cordova-crosswalk-engine ? I think that's the
most up-to-date repo; it's the one that I have working in all of my tests.

Ian


On Tue, May 20, 2014 at 10:51 PM, Hu, Ningxin <ni...@intel.com> wrote:

> An update: the legal/license is cleared to host cordova-crosswalk-engine
> under https://github.com/crosswalk-project/.
>
> Thanks,
> -ningxin
>
> > -----Original Message-----
> > From: Hu, Ningxin [mailto:ningxin.hu@intel.com]
> > Sent: Tuesday, May 06, 2014 8:56 AM
> > To: dev@cordova.apache.org
> > Subject: RE: [Android] Refactoring for different engines
> >
> > Ian,
> >
> > I initiated the proposal to crosswalk stakeholders about hosting the
> Crosswalk
> > Cordova Engine in Crosswalk projects. The feedback is very positive. I
> am now
> > going through the required legal/license clearance process. I will keep
> you posted
> > about the status.
> >
> > Thanks,
> > -ningxin
> >
> > > -----Original Message-----
> > > From: iclelland@google.com [mailto:iclelland@google.com] On Behalf Of
> > > Ian Clelland
> > > Sent: Wednesday, April 30, 2014 2:23 AM
> > > To: dev@cordova.apache.org
> > > Subject: Re: [Android] Refactoring for different engines
> > >
> > > On Tue, Apr 29, 2014 at 10:55 AM, Joe Bowser <bo...@gmail.com>
> wrote:
> > >
> > > > So, when Apache publishes something, it has fill the following
> criteria:
> > > >
> > > > - All source code must have their licence headers intact
> > > > - All third-party source code must be mentioned in the NOTICE file
> > > > - No Binary Blobs - No compiled libraries, which include JARs and
> > > > shared object files (including the pak).
> > > >
> > > > Now, with Crosswalk, there's obviously the Chromium Library that we
> > > > need, so we need a way to get that into the generated project
> somehow.
> > > >  The easiest way is with plugman, but the issue is that Apache can't
> > > > legally pass around binary blobs when it does an official release of
> > > > anything.  Intel, OTOH, isn't restricted by cumbersome open source
> > > > foundation rules, and can do so.
> > > >
> > >
> > > Intel has their own rules to follow, certainly, but we're presuming
> > > here that Intel has already worked out the legal requirements to
> > > distribute Crosswalk in the first place, so the idea of Intel also
> > > distributing the "official" Crosswalk Cordova Engine plugin just seems
> to make a
> > lot of sense.
> > >
> > > Apache distributes Cordova-Android, which defines the integration API,
> > > and includes the default AndroidWebView classes, and other parties
> > > should be free to distribute their own engine plugins, implementing
> > > that API. That distribution can then be in any form that makes sense
> > > (and complies with the licenses of the various components)
> > >
> > > Joe's right that it would be awkward, if not impossible, for Apache to
> > > distribute the Crosswalk core library. We'd have to include the 15GB
> > > of source as well, at the very least, and that doesn't sound like fun
> at all.
> > > It *is* all open-source, but there are a lot of different licenses in
> > > there, and we'd need some lawyerly help to make sure that the ASF
> > > could release software that included it all.
> > >
> > > Ian
> > >
> > >
> > > > On Tue, Apr 29, 2014 at 7:43 AM, Hu, Ningxin <ni...@intel.com>
> wrote:
> > > > >> - who publishes the plugins, intel or cordova?
> > > > >
> > > > > For this open, could someone elaborate it a little bit more? What
> > > > > does
> > > > it mean? I remembered someone mentioned the license is open in the
> > > > hangouts, any details?
> > > > >
> > > > > Thanks,
> > > > > -ningxin
> > > > >
> > > > >> -----Original Message-----
> > > > >> From: mmocny@google.com [mailto:mmocny@google.com] On Behalf Of
> > > > >> Michal Mocny
> > > > >> Sent: Saturday, April 26, 2014 12:53 AM
> > > > >> To: dev
> > > > >> Subject: Re: [Android] Refactoring for different engines
> > > > >>
> > > > >> Notes:
> > > > >>
> > > > >> - native junit tests needs fixing (due to deprication)
> > > > >>
> > > > >> - common script for creating walk mobilespec
> > > > >>
> > > > >> - fix failing mobile spec tests (file-transfer?, media?)
> > > > >>
> > > > >> - who publishes the plugins, intel or cordova?
> > > > >>
> > > > >> - static vs dynamic xwalk lib
> > > > >>
> > > > >>   - (option) one plugin, use hooks to download static library
> > > > >>
> > > > >>   - (option) one plugin, just bundle static lib
> > > > >>
> > > > >>   - (option) one plugin, download static lib on app run
> > > > >>
> > > > >>   - (option) two plugins, xwalk lib bundled in a separate plugin,
> > > > >> and
> > > > can be added
> > > > >> as a <dep>?
> > > > >>
> > > > >> - intel vs arm binary apk targets for CLI.  Two android
> > > > >> platforms, or
> > > > just two build
> > > > >> targets?
> > > > >>
> > > > >> - How long to get GeckoView: Joe not sure. days to weeks :(
> > > > >>
> > > > >>   - Not blocking, though
> > > > >>
> > > > >> - plugman works to install but CLI does not, lets figure that out
> > > > >>
> > > > >> - Other platforms: Windows Phone support!?  BB10?!
> > > > >>
> > > > >> - Can we share code between xwalk WebViewClient and gecko view
> > > > >> WebViewClient etc?
> > > > >>
> > > > >>
> > > > >> On Fri, Apr 25, 2014 at 12:09 PM, Josh Soref
> > > > >> <js...@blackberry.com>
> > > > wrote:
> > > > >>
> > > > >> > Ian Clelland wrote:
> > > > >> >
> > > > >> > >
> > > > >> >
> > > > https://staging.talkgadget.google.com/hangouts/_/7ecpi3uaclcuedn7imn
> > > > 6b
> > > > >> > 9jdq
> > > > >> > >c
> > > > >> >
> > > > >> > https://talkgadget.google.com/hangouts/_/7ecpi3uaclcuedn7imn6b9
> > > > >> > jd
> > > > >> > qc
> > > > >> >
> > > > >> > Might work. Staging is probably internal.
> > > > >> >
> > > > >> >
> > > >
>

RE: [Android] Refactoring for different engines

["Hu, Ningxin" <ni...@intel.com>]

An update: the legal/license is cleared to host cordova-crosswalk-engine under https://github.com/crosswalk-project/.

Thanks,
-ningxin

> -----Original Message-----
> From: Hu, Ningxin [mailto:ningxin.hu@intel.com]
> Sent: Tuesday, May 06, 2014 8:56 AM
> To: dev@cordova.apache.org
> Subject: RE: [Android] Refactoring for different engines
> 
> Ian,
> 
> I initiated the proposal to crosswalk stakeholders about hosting the Crosswalk
> Cordova Engine in Crosswalk projects. The feedback is very positive. I am now
> going through the required legal/license clearance process. I will keep you posted
> about the status.
> 
> Thanks,
> -ningxin
> 
> > -----Original Message-----
> > From: iclelland@google.com [mailto:iclelland@google.com] On Behalf Of
> > Ian Clelland
> > Sent: Wednesday, April 30, 2014 2:23 AM
> > To: dev@cordova.apache.org
> > Subject: Re: [Android] Refactoring for different engines
> >
> > On Tue, Apr 29, 2014 at 10:55 AM, Joe Bowser <bo...@gmail.com> wrote:
> >
> > > So, when Apache publishes something, it has fill the following criteria:
> > >
> > > - All source code must have their licence headers intact
> > > - All third-party source code must be mentioned in the NOTICE file
> > > - No Binary Blobs - No compiled libraries, which include JARs and
> > > shared object files (including the pak).
> > >
> > > Now, with Crosswalk, there's obviously the Chromium Library that we
> > > need, so we need a way to get that into the generated project somehow.
> > >  The easiest way is with plugman, but the issue is that Apache can't
> > > legally pass around binary blobs when it does an official release of
> > > anything.  Intel, OTOH, isn't restricted by cumbersome open source
> > > foundation rules, and can do so.
> > >
> >
> > Intel has their own rules to follow, certainly, but we're presuming
> > here that Intel has already worked out the legal requirements to
> > distribute Crosswalk in the first place, so the idea of Intel also
> > distributing the "official" Crosswalk Cordova Engine plugin just seems to make a
> lot of sense.
> >
> > Apache distributes Cordova-Android, which defines the integration API,
> > and includes the default AndroidWebView classes, and other parties
> > should be free to distribute their own engine plugins, implementing
> > that API. That distribution can then be in any form that makes sense
> > (and complies with the licenses of the various components)
> >
> > Joe's right that it would be awkward, if not impossible, for Apache to
> > distribute the Crosswalk core library. We'd have to include the 15GB
> > of source as well, at the very least, and that doesn't sound like fun at all.
> > It *is* all open-source, but there are a lot of different licenses in
> > there, and we'd need some lawyerly help to make sure that the ASF
> > could release software that included it all.
> >
> > Ian
> >
> >
> > > On Tue, Apr 29, 2014 at 7:43 AM, Hu, Ningxin <ni...@intel.com> wrote:
> > > >> - who publishes the plugins, intel or cordova?
> > > >
> > > > For this open, could someone elaborate it a little bit more? What
> > > > does
> > > it mean? I remembered someone mentioned the license is open in the
> > > hangouts, any details?
> > > >
> > > > Thanks,
> > > > -ningxin
> > > >
> > > >> -----Original Message-----
> > > >> From: mmocny@google.com [mailto:mmocny@google.com] On Behalf Of
> > > >> Michal Mocny
> > > >> Sent: Saturday, April 26, 2014 12:53 AM
> > > >> To: dev
> > > >> Subject: Re: [Android] Refactoring for different engines
> > > >>
> > > >> Notes:
> > > >>
> > > >> - native junit tests needs fixing (due to deprication)
> > > >>
> > > >> - common script for creating walk mobilespec
> > > >>
> > > >> - fix failing mobile spec tests (file-transfer?, media?)
> > > >>
> > > >> - who publishes the plugins, intel or cordova?
> > > >>
> > > >> - static vs dynamic xwalk lib
> > > >>
> > > >>   - (option) one plugin, use hooks to download static library
> > > >>
> > > >>   - (option) one plugin, just bundle static lib
> > > >>
> > > >>   - (option) one plugin, download static lib on app run
> > > >>
> > > >>   - (option) two plugins, xwalk lib bundled in a separate plugin,
> > > >> and
> > > can be added
> > > >> as a <dep>?
> > > >>
> > > >> - intel vs arm binary apk targets for CLI.  Two android
> > > >> platforms, or
> > > just two build
> > > >> targets?
> > > >>
> > > >> - How long to get GeckoView: Joe not sure. days to weeks :(
> > > >>
> > > >>   - Not blocking, though
> > > >>
> > > >> - plugman works to install but CLI does not, lets figure that out
> > > >>
> > > >> - Other platforms: Windows Phone support!?  BB10?!
> > > >>
> > > >> - Can we share code between xwalk WebViewClient and gecko view
> > > >> WebViewClient etc?
> > > >>
> > > >>
> > > >> On Fri, Apr 25, 2014 at 12:09 PM, Josh Soref
> > > >> <js...@blackberry.com>
> > > wrote:
> > > >>
> > > >> > Ian Clelland wrote:
> > > >> >
> > > >> > >
> > > >> >
> > > https://staging.talkgadget.google.com/hangouts/_/7ecpi3uaclcuedn7imn
> > > 6b
> > > >> > 9jdq
> > > >> > >c
> > > >> >
> > > >> > https://talkgadget.google.com/hangouts/_/7ecpi3uaclcuedn7imn6b9
> > > >> > jd
> > > >> > qc
> > > >> >
> > > >> > Might work. Staging is probably internal.
> > > >> >
> > > >> >
> > >

Re: [Android] Refactoring for different engines

[Josh Soref <js...@blackberry.com>]

> BTW: Have you signed the ICLA yet?  If not we should get that taken care
>of
> ASAP

Hu, Ningxin wrote:
> Intel has signed the CCLA as corporate contributor. So I assume I think
>I don't need to sign ICLA, correct?
>


http://www.apache.org/licenses/#clas

> Note that a Corporate CLA does not remove the need for every developer
>to sign their own CLA as an individual, to cover any of their
>contributions which are not owned by the corporation signing the CCLA.

http://mail-archives.apache.org/mod_mbox/www-legal-discuss/201106.mbox/%3cB
ANLkTi=sc6F9qDQX-zeYbKNNCeiXNpOnEw@mail.gmail.com%3e


In short, you need to have an ICLA to have an account with Apache.

Cordova uses the Apache account standard to apply to all contributions.

Technically, Cordova could accept contributions from you w/o you getting
an account as long as they were minor modifications, but there's a thread
earlier where Cordova informally agreed to continue simply requiring an
ICLA up front instead of trying to deal w/ the pain of some people not
having one and having to figure out what that meant.

Re: [Android] Refactoring for different engines

[Marcel Kinard <cm...@gmail.com>]

My understanding is that as a corporate contributor, you need both a CCLA from your corporation and an ICLA as an individual in that corporation. See the "Contributor License Agreement" section of http://www.apache.org/licenses/ .

On May 6, 2014, at 11:18 AM, "Hu, Ningxin" <ni...@intel.com> wrote:

> Intel has signed the CCLA as corporate contributor. So I assume I think I don't need to sign ICLA, correct?

Re: [Android] Refactoring for different engines

[Brian LeRoux <b...@brian.io>]

I've found it persistently odd that of all things to choose to be lax on it
would be a CLA. It should be considered a MUST even if sometimes people say
it isn't.


On Tue, May 6, 2014 at 12:50 PM, Ian Clelland <ic...@chromium.org>wrote:

> Yeah, it's a good idea to sign the ICLA -- if nothing else, it makes it
> really obvious that you know you are deliberately contributing code to an
> Apache project, and then we can feel much more comfortable accepting your
> contributions. It's something that we've required from all contributors,
> and it should be associated with you, rather than your company, since your
> contributions will still be under your name no matter who you may work for
> in the future.
>
> As far as where the code is going, all of the updates required to make
> webviews pluggable are going in the "pluggable_webview" branch of
> cordova-android. (Joe posted the repository URL). This should just include
> the extraction of the AndroidWebView classes, the abstract CordovaWebView
> classes, and the code in Cordova that reads the configuration and
> instantiates and configures the correct objects.
>
> The implementation of the Crosswalk webview currently exists in Joe's
> personal repo on GitHub, but I believe that the intention is for Intel to
> take over that code at some point, and to host all of the source code to
> that plugin.
>
>
> On Tue, May 6, 2014 at 2:00 PM, Joe Bowser <bo...@gmail.com> wrote:
>
> > Hey
> >
> > Here's where the logs are for pluggable_webview:
> >
> >
> >
> https://git-wip-us.apache.org/repos/asf?p=cordova-android.git;a=shortlog;h=refs/heads/pluggable_webview
> >
> > The repo URL itself is located here:
> > https://git-wip-us.apache.org/repos/asf/cordova-android.git
> >
> > Basically, once we're confident enough about a piece of code meeting
> > ASF standards, we start using ASF repos as the canonical repository.
> > This is due to the "Apache Way".  It does make sense in this case,
> > since this will be part of Apache Cordova.
> >
> > On Tue, May 6, 2014 at 10:57 AM, Joe Bowser <bo...@gmail.com> wrote:
> > > I'm not sure, but I think you still may have to, even if Intel has.  I
> > > did sign an ICLA when we donated the software to Adobe, but I think
> > > that's because a fair amount of it was done on non-work hours when I
> > > was at Nitobi.
> > >
> > > On Tue, May 6, 2014 at 8:18 AM, Hu, Ningxin <ni...@intel.com>
> > wrote:
> > >>> BTW: Have you signed the ICLA yet?  If not we should get that taken
> > care of
> > >>> ASAP
> > >>
> > >> Intel has signed the CCLA as corporate contributor. So I assume I
> think
> > I don't need to sign ICLA, correct?
> > >>
> > >> Thanks,
> > >> -ningxin
> > >>
> > >> On May 5, 2014 5:56 PM, "Hu, Ningxin" <ni...@intel.com> wrote:
> > >>>
> > >>> > Ian,
> > >>> >
> > >>> > I initiated the proposal to crosswalk stakeholders about hosting
> the
> > >>> > Crosswalk Cordova Engine in Crosswalk projects. The feedback is
> very
> > >>> > positive. I am now going through the required legal/license
> clearance
> > >>> > process. I will keep you posted about the status.
> > >>> >
> > >>> > Thanks,
> > >>> > -ningxin
> > >>> >
> > >>> > > -----Original Message-----
> > >>> > > From: iclelland@google.com [mailto:iclelland@google.com] On
> Behalf
> > >>> > > Of
> > >>> > Ian
> > >>> > > Clelland
> > >>> > > Sent: Wednesday, April 30, 2014 2:23 AM
> > >>> > > To: dev@cordova.apache.org
> > >>> > > Subject: Re: [Android] Refactoring for different engines
> > >>> > >
> > >>> > > On Tue, Apr 29, 2014 at 10:55 AM, Joe Bowser <bo...@gmail.com>
> > wrote:
> > >>> > >
> > >>> > > > So, when Apache publishes something, it has fill the following
> > >>> > criteria:
> > >>> > > >
> > >>> > > > - All source code must have their licence headers intact
> > >>> > > > - All third-party source code must be mentioned in the NOTICE
> > file
> > >>> > > > - No Binary Blobs - No compiled libraries, which include JARs
> and
> > >>> > > > shared object files (including the pak).
> > >>> > > >
> > >>> > > > Now, with Crosswalk, there's obviously the Chromium Library
> that
> > >>> > > > we need, so we need a way to get that into the generated
> project
> > >>> somehow.
> > >>> > > >  The easiest way is with plugman, but the issue is that Apache
> > >>> > > > can't legally pass around binary blobs when it does an official
> > >>> > > > release of anything.  Intel, OTOH, isn't restricted by
> cumbersome
> > >>> > > > open source foundation rules, and can do so.
> > >>> > > >
> > >>> > >
> > >>> > > Intel has their own rules to follow, certainly, but we're
> presuming
> > >>> > > here
> > >>> > that Intel
> > >>> > > has already worked out the legal requirements to distribute
> > >>> > > Crosswalk in
> > >>> > the first
> > >>> > > place, so the idea of Intel also distributing the "official"
> > >>> > > Crosswalk
> > >>> > Cordova Engine
> > >>> > > plugin just seems to make a lot of sense.
> > >>> > >
> > >>> > > Apache distributes Cordova-Android, which defines the integration
> > >>> > > API,
> > >>> > and
> > >>> > > includes the default AndroidWebView classes, and other parties
> > >>> > > should be
> > >>> > free
> > >>> > > to distribute their own engine plugins, implementing that API.
> That
> > >>> > distribution
> > >>> > > can then be in any form that makes sense (and complies with the
> > >>> > > licenses
> > >>> > of the
> > >>> > > various components)
> > >>> > >
> > >>> > > Joe's right that it would be awkward, if not impossible, for
> Apache
> > >>> > > to
> > >>> > distribute
> > >>> > > the Crosswalk core library. We'd have to include the 15GB of
> source
> > >>> > > as
> > >>> > well, at the
> > >>> > > very least, and that doesn't sound like fun at all.
> > >>> > > It *is* all open-source, but there are a lot of different
> licenses
> > >>> > > in
> > >>> > there, and we'd
> > >>> > > need some lawyerly help to make sure that the ASF could release
> > >>> > > software
> > >>> > that
> > >>> > > included it all.
> > >>> > >
> > >>> > > Ian
> > >>> > >
> > >>> > >
> > >>> > > > On Tue, Apr 29, 2014 at 7:43 AM, Hu, Ningxin
> > >>> > > > <ni...@intel.com>
> > >>> > wrote:
> > >>> > > > >> - who publishes the plugins, intel or cordova?
> > >>> > > > >
> > >>> > > > > For this open, could someone elaborate it a little bit more?
> > >>> > > > > What does
> > >>> > > > it mean? I remembered someone mentioned the license is open in
> > the
> > >>> > > > hangouts, any details?
> > >>> > > > >
> > >>> > > > > Thanks,
> > >>> > > > > -ningxin
> > >>> > > > >
> > >>> > > > >> -----Original Message-----
> > >>> > > > >> From: mmocny@google.com [mailto:mmocny@google.com] On
> Behalf
> > >>> Of
> > >>> > > > >> Michal Mocny
> > >>> > > > >> Sent: Saturday, April 26, 2014 12:53 AM
> > >>> > > > >> To: dev
> > >>> > > > >> Subject: Re: [Android] Refactoring for different engines
> > >>> > > > >>
> > >>> > > > >> Notes:
> > >>> > > > >>
> > >>> > > > >> - native junit tests needs fixing (due to deprication)
> > >>> > > > >>
> > >>> > > > >> - common script for creating walk mobilespec
> > >>> > > > >>
> > >>> > > > >> - fix failing mobile spec tests (file-transfer?, media?)
> > >>> > > > >>
> > >>> > > > >> - who publishes the plugins, intel or cordova?
> > >>> > > > >>
> > >>> > > > >> - static vs dynamic xwalk lib
> > >>> > > > >>
> > >>> > > > >>   - (option) one plugin, use hooks to download static
> library
> > >>> > > > >>
> > >>> > > > >>   - (option) one plugin, just bundle static lib
> > >>> > > > >>
> > >>> > > > >>   - (option) one plugin, download static lib on app run
> > >>> > > > >>
> > >>> > > > >>   - (option) two plugins, xwalk lib bundled in a separate
> > >>> > > > >> plugin, and
> > >>> > > > can be added
> > >>> > > > >> as a <dep>?
> > >>> > > > >>
> > >>> > > > >> - intel vs arm binary apk targets for CLI.  Two android
> > >>> > > > >> platforms, or
> > >>> > > > just two build
> > >>> > > > >> targets?
> > >>> > > > >>
> > >>> > > > >> - How long to get GeckoView: Joe not sure. days to weeks :(
> > >>> > > > >>
> > >>> > > > >>   - Not blocking, though
> > >>> > > > >>
> > >>> > > > >> - plugman works to install but CLI does not, lets figure
> that
> > >>> > > > >> out
> > >>> > > > >>
> > >>> > > > >> - Other platforms: Windows Phone support!?  BB10?!
> > >>> > > > >>
> > >>> > > > >> - Can we share code between xwalk WebViewClient and gecko
> view
> > >>> > > > >> WebViewClient etc?
> > >>> > > > >>
> > >>> > > > >>
> > >>> > > > >> On Fri, Apr 25, 2014 at 12:09 PM, Josh Soref
> > >>> > > > >> <js...@blackberry.com>
> > >>> > > > wrote:
> > >>> > > > >>
> > >>> > > > >> > Ian Clelland wrote:
> > >>> > > > >> >
> > >>> > > > >> > >
> > >>> > > > >> >
> > >>> > > >
> > https://staging.talkgadget.google.com/hangouts/_/7ecpi3uaclcuedn7i
> > >>> > > > mn6b
> > >>> > > > >> > 9jdq
> > >>> > > > >> > >c
> > >>> > > > >> >
> > >>> > > > >> >
> > https://talkgadget.google.com/hangouts/_/7ecpi3uaclcuedn7imn6
> > >>> > > > >> > b9jd
> > >>> > > > >> > qc
> > >>> > > > >> >
> > >>> > > > >> > Might work. Staging is probably internal.
> > >>> > > > >> >
> > >>> > > > >> >
> > >>> > > >
> > >>> >
> >
>

RE: [Android] Refactoring for different engines

["Hu, Ningxin" <ni...@intel.com>]

> Ian wrote:
> Yeah, it's a good idea to sign the ICLA -- if nothing else, it makes it really obvious
> that you know you are deliberately contributing code to an Apache project, and
> then we can feel much more comfortable accepting your contributions. It's
> something that we've required from all contributors, and it should be associated
> with you, rather than your company, since your contributions will still be under
> your name no matter who you may work for in the future.
> 

Many thanks for the details. My signed ICLA has been sent to Cordova.

> As far as where the code is going, all of the updates required to make webviews
> pluggable are going in the "pluggable_webview" branch of cordova-android. (Joe
> posted the repository URL). This should just include the extraction of the
> AndroidWebView classes, the abstract CordovaWebView classes, and the code in
> Cordova that reads the configuration and instantiates and configures the correct
> objects.
> 
> The implementation of the Crosswalk webview currently exists in Joe's personal
> repo on GitHub, but I believe that the intention is for Intel to take over that code
> at some point, and to host all of the source code to that plugin.
> 

Yes. That's my understanding. Thanks for clarification.

-ningxin

> 
> On Tue, May 6, 2014 at 2:00 PM, Joe Bowser <bo...@gmail.com> wrote:
> 
> > Hey
> >
> > Here's where the logs are for pluggable_webview:
> >
> >
> > https://git-wip-us.apache.org/repos/asf?p=cordova-android.git;a=shortl
> > og;h=refs/heads/pluggable_webview
> >
> > The repo URL itself is located here:
> > https://git-wip-us.apache.org/repos/asf/cordova-android.git
> >
> > Basically, once we're confident enough about a piece of code meeting
> > ASF standards, we start using ASF repos as the canonical repository.
> > This is due to the "Apache Way".  It does make sense in this case,
> > since this will be part of Apache Cordova.
> >
> > On Tue, May 6, 2014 at 10:57 AM, Joe Bowser <bo...@gmail.com> wrote:
> > > I'm not sure, but I think you still may have to, even if Intel has.
> > > I did sign an ICLA when we donated the software to Adobe, but I
> > > think that's because a fair amount of it was done on non-work hours
> > > when I was at Nitobi.
> > >
> > > On Tue, May 6, 2014 at 8:18 AM, Hu, Ningxin <ni...@intel.com>
> > wrote:
> > >>> BTW: Have you signed the ICLA yet?  If not we should get that
> > >>> taken
> > care of
> > >>> ASAP
> > >>
> > >> Intel has signed the CCLA as corporate contributor. So I assume I
> > >> think
> > I don't need to sign ICLA, correct?
> > >>
> > >> Thanks,
> > >> -ningxin
> > >>
> > >> On May 5, 2014 5:56 PM, "Hu, Ningxin" <ni...@intel.com> wrote:
> > >>>
> > >>> > Ian,
> > >>> >
> > >>> > I initiated the proposal to crosswalk stakeholders about hosting
> > >>> > the Crosswalk Cordova Engine in Crosswalk projects. The feedback
> > >>> > is very positive. I am now going through the required
> > >>> > legal/license clearance process. I will keep you posted about the status.
> > >>> >
> > >>> > Thanks,
> > >>> > -ningxin
> > >>> >
> > >>> > > -----Original Message-----
> > >>> > > From: iclelland@google.com [mailto:iclelland@google.com] On
> > >>> > > Behalf Of
> > >>> > Ian
> > >>> > > Clelland
> > >>> > > Sent: Wednesday, April 30, 2014 2:23 AM
> > >>> > > To: dev@cordova.apache.org
> > >>> > > Subject: Re: [Android] Refactoring for different engines
> > >>> > >
> > >>> > > On Tue, Apr 29, 2014 at 10:55 AM, Joe Bowser
> > >>> > > <bo...@gmail.com>
> > wrote:
> > >>> > >
> > >>> > > > So, when Apache publishes something, it has fill the
> > >>> > > > following
> > >>> > criteria:
> > >>> > > >
> > >>> > > > - All source code must have their licence headers intact
> > >>> > > > - All third-party source code must be mentioned in the
> > >>> > > > NOTICE
> > file
> > >>> > > > - No Binary Blobs - No compiled libraries, which include
> > >>> > > > JARs and shared object files (including the pak).
> > >>> > > >
> > >>> > > > Now, with Crosswalk, there's obviously the Chromium Library
> > >>> > > > that we need, so we need a way to get that into the
> > >>> > > > generated project
> > >>> somehow.
> > >>> > > >  The easiest way is with plugman, but the issue is that
> > >>> > > > Apache can't legally pass around binary blobs when it does
> > >>> > > > an official release of anything.  Intel, OTOH, isn't
> > >>> > > > restricted by cumbersome open source foundation rules, and can do
> so.
> > >>> > > >
> > >>> > >
> > >>> > > Intel has their own rules to follow, certainly, but we're
> > >>> > > presuming here
> > >>> > that Intel
> > >>> > > has already worked out the legal requirements to distribute
> > >>> > > Crosswalk in
> > >>> > the first
> > >>> > > place, so the idea of Intel also distributing the "official"
> > >>> > > Crosswalk
> > >>> > Cordova Engine
> > >>> > > plugin just seems to make a lot of sense.
> > >>> > >
> > >>> > > Apache distributes Cordova-Android, which defines the
> > >>> > > integration API,
> > >>> > and
> > >>> > > includes the default AndroidWebView classes, and other parties
> > >>> > > should be
> > >>> > free
> > >>> > > to distribute their own engine plugins, implementing that API.
> > >>> > > That
> > >>> > distribution
> > >>> > > can then be in any form that makes sense (and complies with
> > >>> > > the licenses
> > >>> > of the
> > >>> > > various components)
> > >>> > >
> > >>> > > Joe's right that it would be awkward, if not impossible, for
> > >>> > > Apache to
> > >>> > distribute
> > >>> > > the Crosswalk core library. We'd have to include the 15GB of
> > >>> > > source as
> > >>> > well, at the
> > >>> > > very least, and that doesn't sound like fun at all.
> > >>> > > It *is* all open-source, but there are a lot of different
> > >>> > > licenses in
> > >>> > there, and we'd
> > >>> > > need some lawyerly help to make sure that the ASF could
> > >>> > > release software
> > >>> > that
> > >>> > > included it all.
> > >>> > >
> > >>> > > Ian
> > >>> > >
> > >>> > >
> > >>> > > > On Tue, Apr 29, 2014 at 7:43 AM, Hu, Ningxin
> > >>> > > > <ni...@intel.com>
> > >>> > wrote:
> > >>> > > > >> - who publishes the plugins, intel or cordova?
> > >>> > > > >
> > >>> > > > > For this open, could someone elaborate it a little bit more?
> > >>> > > > > What does
> > >>> > > > it mean? I remembered someone mentioned the license is open
> > >>> > > > in
> > the
> > >>> > > > hangouts, any details?
> > >>> > > > >
> > >>> > > > > Thanks,
> > >>> > > > > -ningxin
> > >>> > > > >
> > >>> > > > >> -----Original Message-----
> > >>> > > > >> From: mmocny@google.com [mailto:mmocny@google.com] On
> > >>> > > > >> Behalf
> > >>> Of
> > >>> > > > >> Michal Mocny
> > >>> > > > >> Sent: Saturday, April 26, 2014 12:53 AM
> > >>> > > > >> To: dev
> > >>> > > > >> Subject: Re: [Android] Refactoring for different engines
> > >>> > > > >>
> > >>> > > > >> Notes:
> > >>> > > > >>
> > >>> > > > >> - native junit tests needs fixing (due to deprication)
> > >>> > > > >>
> > >>> > > > >> - common script for creating walk mobilespec
> > >>> > > > >>
> > >>> > > > >> - fix failing mobile spec tests (file-transfer?, media?)
> > >>> > > > >>
> > >>> > > > >> - who publishes the plugins, intel or cordova?
> > >>> > > > >>
> > >>> > > > >> - static vs dynamic xwalk lib
> > >>> > > > >>
> > >>> > > > >>   - (option) one plugin, use hooks to download static
> > >>> > > > >> library
> > >>> > > > >>
> > >>> > > > >>   - (option) one plugin, just bundle static lib
> > >>> > > > >>
> > >>> > > > >>   - (option) one plugin, download static lib on app run
> > >>> > > > >>
> > >>> > > > >>   - (option) two plugins, xwalk lib bundled in a separate
> > >>> > > > >> plugin, and
> > >>> > > > can be added
> > >>> > > > >> as a <dep>?
> > >>> > > > >>
> > >>> > > > >> - intel vs arm binary apk targets for CLI.  Two android
> > >>> > > > >> platforms, or
> > >>> > > > just two build
> > >>> > > > >> targets?
> > >>> > > > >>
> > >>> > > > >> - How long to get GeckoView: Joe not sure. days to weeks
> > >>> > > > >> :(
> > >>> > > > >>
> > >>> > > > >>   - Not blocking, though
> > >>> > > > >>
> > >>> > > > >> - plugman works to install but CLI does not, lets figure
> > >>> > > > >> that out
> > >>> > > > >>
> > >>> > > > >> - Other platforms: Windows Phone support!?  BB10?!
> > >>> > > > >>
> > >>> > > > >> - Can we share code between xwalk WebViewClient and gecko
> > >>> > > > >> view WebViewClient etc?
> > >>> > > > >>
> > >>> > > > >>
> > >>> > > > >> On Fri, Apr 25, 2014 at 12:09 PM, Josh Soref
> > >>> > > > >> <js...@blackberry.com>
> > >>> > > > wrote:
> > >>> > > > >>
> > >>> > > > >> > Ian Clelland wrote:
> > >>> > > > >> >
> > >>> > > > >> > >
> > >>> > > > >> >
> > >>> > > >
> > https://staging.talkgadget.google.com/hangouts/_/7ecpi3uaclcuedn7i
> > >>> > > > mn6b
> > >>> > > > >> > 9jdq
> > >>> > > > >> > >c
> > >>> > > > >> >
> > >>> > > > >> >
> > https://talkgadget.google.com/hangouts/_/7ecpi3uaclcuedn7imn6
> > >>> > > > >> > b9jd
> > >>> > > > >> > qc
> > >>> > > > >> >
> > >>> > > > >> > Might work. Staging is probably internal.
> > >>> > > > >> >
> > >>> > > > >> >
> > >>> > > >
> > >>> >
> >

Re: [Android] Refactoring for different engines

[Ian Clelland <ic...@chromium.org>]

Yeah, it's a good idea to sign the ICLA -- if nothing else, it makes it
really obvious that you know you are deliberately contributing code to an
Apache project, and then we can feel much more comfortable accepting your
contributions. It's something that we've required from all contributors,
and it should be associated with you, rather than your company, since your
contributions will still be under your name no matter who you may work for
in the future.

As far as where the code is going, all of the updates required to make
webviews pluggable are going in the "pluggable_webview" branch of
cordova-android. (Joe posted the repository URL). This should just include
the extraction of the AndroidWebView classes, the abstract CordovaWebView
classes, and the code in Cordova that reads the configuration and
instantiates and configures the correct objects.

The implementation of the Crosswalk webview currently exists in Joe's
personal repo on GitHub, but I believe that the intention is for Intel to
take over that code at some point, and to host all of the source code to
that plugin.


On Tue, May 6, 2014 at 2:00 PM, Joe Bowser <bo...@gmail.com> wrote:

> Hey
>
> Here's where the logs are for pluggable_webview:
>
>
> https://git-wip-us.apache.org/repos/asf?p=cordova-android.git;a=shortlog;h=refs/heads/pluggable_webview
>
> The repo URL itself is located here:
> https://git-wip-us.apache.org/repos/asf/cordova-android.git
>
> Basically, once we're confident enough about a piece of code meeting
> ASF standards, we start using ASF repos as the canonical repository.
> This is due to the "Apache Way".  It does make sense in this case,
> since this will be part of Apache Cordova.
>
> On Tue, May 6, 2014 at 10:57 AM, Joe Bowser <bo...@gmail.com> wrote:
> > I'm not sure, but I think you still may have to, even if Intel has.  I
> > did sign an ICLA when we donated the software to Adobe, but I think
> > that's because a fair amount of it was done on non-work hours when I
> > was at Nitobi.
> >
> > On Tue, May 6, 2014 at 8:18 AM, Hu, Ningxin <ni...@intel.com>
> wrote:
> >>> BTW: Have you signed the ICLA yet?  If not we should get that taken
> care of
> >>> ASAP
> >>
> >> Intel has signed the CCLA as corporate contributor. So I assume I think
> I don't need to sign ICLA, correct?
> >>
> >> Thanks,
> >> -ningxin
> >>
> >> On May 5, 2014 5:56 PM, "Hu, Ningxin" <ni...@intel.com> wrote:
> >>>
> >>> > Ian,
> >>> >
> >>> > I initiated the proposal to crosswalk stakeholders about hosting the
> >>> > Crosswalk Cordova Engine in Crosswalk projects. The feedback is very
> >>> > positive. I am now going through the required legal/license clearance
> >>> > process. I will keep you posted about the status.
> >>> >
> >>> > Thanks,
> >>> > -ningxin
> >>> >
> >>> > > -----Original Message-----
> >>> > > From: iclelland@google.com [mailto:iclelland@google.com] On Behalf
> >>> > > Of
> >>> > Ian
> >>> > > Clelland
> >>> > > Sent: Wednesday, April 30, 2014 2:23 AM
> >>> > > To: dev@cordova.apache.org
> >>> > > Subject: Re: [Android] Refactoring for different engines
> >>> > >
> >>> > > On Tue, Apr 29, 2014 at 10:55 AM, Joe Bowser <bo...@gmail.com>
> wrote:
> >>> > >
> >>> > > > So, when Apache publishes something, it has fill the following
> >>> > criteria:
> >>> > > >
> >>> > > > - All source code must have their licence headers intact
> >>> > > > - All third-party source code must be mentioned in the NOTICE
> file
> >>> > > > - No Binary Blobs - No compiled libraries, which include JARs and
> >>> > > > shared object files (including the pak).
> >>> > > >
> >>> > > > Now, with Crosswalk, there's obviously the Chromium Library that
> >>> > > > we need, so we need a way to get that into the generated project
> >>> somehow.
> >>> > > >  The easiest way is with plugman, but the issue is that Apache
> >>> > > > can't legally pass around binary blobs when it does an official
> >>> > > > release of anything.  Intel, OTOH, isn't restricted by cumbersome
> >>> > > > open source foundation rules, and can do so.
> >>> > > >
> >>> > >
> >>> > > Intel has their own rules to follow, certainly, but we're presuming
> >>> > > here
> >>> > that Intel
> >>> > > has already worked out the legal requirements to distribute
> >>> > > Crosswalk in
> >>> > the first
> >>> > > place, so the idea of Intel also distributing the "official"
> >>> > > Crosswalk
> >>> > Cordova Engine
> >>> > > plugin just seems to make a lot of sense.
> >>> > >
> >>> > > Apache distributes Cordova-Android, which defines the integration
> >>> > > API,
> >>> > and
> >>> > > includes the default AndroidWebView classes, and other parties
> >>> > > should be
> >>> > free
> >>> > > to distribute their own engine plugins, implementing that API. That
> >>> > distribution
> >>> > > can then be in any form that makes sense (and complies with the
> >>> > > licenses
> >>> > of the
> >>> > > various components)
> >>> > >
> >>> > > Joe's right that it would be awkward, if not impossible, for Apache
> >>> > > to
> >>> > distribute
> >>> > > the Crosswalk core library. We'd have to include the 15GB of source
> >>> > > as
> >>> > well, at the
> >>> > > very least, and that doesn't sound like fun at all.
> >>> > > It *is* all open-source, but there are a lot of different licenses
> >>> > > in
> >>> > there, and we'd
> >>> > > need some lawyerly help to make sure that the ASF could release
> >>> > > software
> >>> > that
> >>> > > included it all.
> >>> > >
> >>> > > Ian
> >>> > >
> >>> > >
> >>> > > > On Tue, Apr 29, 2014 at 7:43 AM, Hu, Ningxin
> >>> > > > <ni...@intel.com>
> >>> > wrote:
> >>> > > > >> - who publishes the plugins, intel or cordova?
> >>> > > > >
> >>> > > > > For this open, could someone elaborate it a little bit more?
> >>> > > > > What does
> >>> > > > it mean? I remembered someone mentioned the license is open in
> the
> >>> > > > hangouts, any details?
> >>> > > > >
> >>> > > > > Thanks,
> >>> > > > > -ningxin
> >>> > > > >
> >>> > > > >> -----Original Message-----
> >>> > > > >> From: mmocny@google.com [mailto:mmocny@google.com] On Behalf
> >>> Of
> >>> > > > >> Michal Mocny
> >>> > > > >> Sent: Saturday, April 26, 2014 12:53 AM
> >>> > > > >> To: dev
> >>> > > > >> Subject: Re: [Android] Refactoring for different engines
> >>> > > > >>
> >>> > > > >> Notes:
> >>> > > > >>
> >>> > > > >> - native junit tests needs fixing (due to deprication)
> >>> > > > >>
> >>> > > > >> - common script for creating walk mobilespec
> >>> > > > >>
> >>> > > > >> - fix failing mobile spec tests (file-transfer?, media?)
> >>> > > > >>
> >>> > > > >> - who publishes the plugins, intel or cordova?
> >>> > > > >>
> >>> > > > >> - static vs dynamic xwalk lib
> >>> > > > >>
> >>> > > > >>   - (option) one plugin, use hooks to download static library
> >>> > > > >>
> >>> > > > >>   - (option) one plugin, just bundle static lib
> >>> > > > >>
> >>> > > > >>   - (option) one plugin, download static lib on app run
> >>> > > > >>
> >>> > > > >>   - (option) two plugins, xwalk lib bundled in a separate
> >>> > > > >> plugin, and
> >>> > > > can be added
> >>> > > > >> as a <dep>?
> >>> > > > >>
> >>> > > > >> - intel vs arm binary apk targets for CLI.  Two android
> >>> > > > >> platforms, or
> >>> > > > just two build
> >>> > > > >> targets?
> >>> > > > >>
> >>> > > > >> - How long to get GeckoView: Joe not sure. days to weeks :(
> >>> > > > >>
> >>> > > > >>   - Not blocking, though
> >>> > > > >>
> >>> > > > >> - plugman works to install but CLI does not, lets figure that
> >>> > > > >> out
> >>> > > > >>
> >>> > > > >> - Other platforms: Windows Phone support!?  BB10?!
> >>> > > > >>
> >>> > > > >> - Can we share code between xwalk WebViewClient and gecko view
> >>> > > > >> WebViewClient etc?
> >>> > > > >>
> >>> > > > >>
> >>> > > > >> On Fri, Apr 25, 2014 at 12:09 PM, Josh Soref
> >>> > > > >> <js...@blackberry.com>
> >>> > > > wrote:
> >>> > > > >>
> >>> > > > >> > Ian Clelland wrote:
> >>> > > > >> >
> >>> > > > >> > >
> >>> > > > >> >
> >>> > > >
> https://staging.talkgadget.google.com/hangouts/_/7ecpi3uaclcuedn7i
> >>> > > > mn6b
> >>> > > > >> > 9jdq
> >>> > > > >> > >c
> >>> > > > >> >
> >>> > > > >> >
> https://talkgadget.google.com/hangouts/_/7ecpi3uaclcuedn7imn6
> >>> > > > >> > b9jd
> >>> > > > >> > qc
> >>> > > > >> >
> >>> > > > >> > Might work. Staging is probably internal.
> >>> > > > >> >
> >>> > > > >> >
> >>> > > >
> >>> >
>

Re: [Android] Refactoring for different engines

[Joe Bowser <bo...@gmail.com>]

Hey

Here's where the logs are for pluggable_webview:

https://git-wip-us.apache.org/repos/asf?p=cordova-android.git;a=shortlog;h=refs/heads/pluggable_webview

The repo URL itself is located here:
https://git-wip-us.apache.org/repos/asf/cordova-android.git

Basically, once we're confident enough about a piece of code meeting
ASF standards, we start using ASF repos as the canonical repository.
This is due to the "Apache Way".  It does make sense in this case,
since this will be part of Apache Cordova.

On Tue, May 6, 2014 at 10:57 AM, Joe Bowser <bo...@gmail.com> wrote:
> I'm not sure, but I think you still may have to, even if Intel has.  I
> did sign an ICLA when we donated the software to Adobe, but I think
> that's because a fair amount of it was done on non-work hours when I
> was at Nitobi.
>
> On Tue, May 6, 2014 at 8:18 AM, Hu, Ningxin <ni...@intel.com> wrote:
>>> BTW: Have you signed the ICLA yet?  If not we should get that taken care of
>>> ASAP
>>
>> Intel has signed the CCLA as corporate contributor. So I assume I think I don't need to sign ICLA, correct?
>>
>> Thanks,
>> -ningxin
>>
>> On May 5, 2014 5:56 PM, "Hu, Ningxin" <ni...@intel.com> wrote:
>>>
>>> > Ian,
>>> >
>>> > I initiated the proposal to crosswalk stakeholders about hosting the
>>> > Crosswalk Cordova Engine in Crosswalk projects. The feedback is very
>>> > positive. I am now going through the required legal/license clearance
>>> > process. I will keep you posted about the status.
>>> >
>>> > Thanks,
>>> > -ningxin
>>> >
>>> > > -----Original Message-----
>>> > > From: iclelland@google.com [mailto:iclelland@google.com] On Behalf
>>> > > Of
>>> > Ian
>>> > > Clelland
>>> > > Sent: Wednesday, April 30, 2014 2:23 AM
>>> > > To: dev@cordova.apache.org
>>> > > Subject: Re: [Android] Refactoring for different engines
>>> > >
>>> > > On Tue, Apr 29, 2014 at 10:55 AM, Joe Bowser <bo...@gmail.com> wrote:
>>> > >
>>> > > > So, when Apache publishes something, it has fill the following
>>> > criteria:
>>> > > >
>>> > > > - All source code must have their licence headers intact
>>> > > > - All third-party source code must be mentioned in the NOTICE file
>>> > > > - No Binary Blobs - No compiled libraries, which include JARs and
>>> > > > shared object files (including the pak).
>>> > > >
>>> > > > Now, with Crosswalk, there's obviously the Chromium Library that
>>> > > > we need, so we need a way to get that into the generated project
>>> somehow.
>>> > > >  The easiest way is with plugman, but the issue is that Apache
>>> > > > can't legally pass around binary blobs when it does an official
>>> > > > release of anything.  Intel, OTOH, isn't restricted by cumbersome
>>> > > > open source foundation rules, and can do so.
>>> > > >
>>> > >
>>> > > Intel has their own rules to follow, certainly, but we're presuming
>>> > > here
>>> > that Intel
>>> > > has already worked out the legal requirements to distribute
>>> > > Crosswalk in
>>> > the first
>>> > > place, so the idea of Intel also distributing the "official"
>>> > > Crosswalk
>>> > Cordova Engine
>>> > > plugin just seems to make a lot of sense.
>>> > >
>>> > > Apache distributes Cordova-Android, which defines the integration
>>> > > API,
>>> > and
>>> > > includes the default AndroidWebView classes, and other parties
>>> > > should be
>>> > free
>>> > > to distribute their own engine plugins, implementing that API. That
>>> > distribution
>>> > > can then be in any form that makes sense (and complies with the
>>> > > licenses
>>> > of the
>>> > > various components)
>>> > >
>>> > > Joe's right that it would be awkward, if not impossible, for Apache
>>> > > to
>>> > distribute
>>> > > the Crosswalk core library. We'd have to include the 15GB of source
>>> > > as
>>> > well, at the
>>> > > very least, and that doesn't sound like fun at all.
>>> > > It *is* all open-source, but there are a lot of different licenses
>>> > > in
>>> > there, and we'd
>>> > > need some lawyerly help to make sure that the ASF could release
>>> > > software
>>> > that
>>> > > included it all.
>>> > >
>>> > > Ian
>>> > >
>>> > >
>>> > > > On Tue, Apr 29, 2014 at 7:43 AM, Hu, Ningxin
>>> > > > <ni...@intel.com>
>>> > wrote:
>>> > > > >> - who publishes the plugins, intel or cordova?
>>> > > > >
>>> > > > > For this open, could someone elaborate it a little bit more?
>>> > > > > What does
>>> > > > it mean? I remembered someone mentioned the license is open in the
>>> > > > hangouts, any details?
>>> > > > >
>>> > > > > Thanks,
>>> > > > > -ningxin
>>> > > > >
>>> > > > >> -----Original Message-----
>>> > > > >> From: mmocny@google.com [mailto:mmocny@google.com] On Behalf
>>> Of
>>> > > > >> Michal Mocny
>>> > > > >> Sent: Saturday, April 26, 2014 12:53 AM
>>> > > > >> To: dev
>>> > > > >> Subject: Re: [Android] Refactoring for different engines
>>> > > > >>
>>> > > > >> Notes:
>>> > > > >>
>>> > > > >> - native junit tests needs fixing (due to deprication)
>>> > > > >>
>>> > > > >> - common script for creating walk mobilespec
>>> > > > >>
>>> > > > >> - fix failing mobile spec tests (file-transfer?, media?)
>>> > > > >>
>>> > > > >> - who publishes the plugins, intel or cordova?
>>> > > > >>
>>> > > > >> - static vs dynamic xwalk lib
>>> > > > >>
>>> > > > >>   - (option) one plugin, use hooks to download static library
>>> > > > >>
>>> > > > >>   - (option) one plugin, just bundle static lib
>>> > > > >>
>>> > > > >>   - (option) one plugin, download static lib on app run
>>> > > > >>
>>> > > > >>   - (option) two plugins, xwalk lib bundled in a separate
>>> > > > >> plugin, and
>>> > > > can be added
>>> > > > >> as a <dep>?
>>> > > > >>
>>> > > > >> - intel vs arm binary apk targets for CLI.  Two android
>>> > > > >> platforms, or
>>> > > > just two build
>>> > > > >> targets?
>>> > > > >>
>>> > > > >> - How long to get GeckoView: Joe not sure. days to weeks :(
>>> > > > >>
>>> > > > >>   - Not blocking, though
>>> > > > >>
>>> > > > >> - plugman works to install but CLI does not, lets figure that
>>> > > > >> out
>>> > > > >>
>>> > > > >> - Other platforms: Windows Phone support!?  BB10?!
>>> > > > >>
>>> > > > >> - Can we share code between xwalk WebViewClient and gecko view
>>> > > > >> WebViewClient etc?
>>> > > > >>
>>> > > > >>
>>> > > > >> On Fri, Apr 25, 2014 at 12:09 PM, Josh Soref
>>> > > > >> <js...@blackberry.com>
>>> > > > wrote:
>>> > > > >>
>>> > > > >> > Ian Clelland wrote:
>>> > > > >> >
>>> > > > >> > >
>>> > > > >> >
>>> > > > https://staging.talkgadget.google.com/hangouts/_/7ecpi3uaclcuedn7i
>>> > > > mn6b
>>> > > > >> > 9jdq
>>> > > > >> > >c
>>> > > > >> >
>>> > > > >> > https://talkgadget.google.com/hangouts/_/7ecpi3uaclcuedn7imn6
>>> > > > >> > b9jd
>>> > > > >> > qc
>>> > > > >> >
>>> > > > >> > Might work. Staging is probably internal.
>>> > > > >> >
>>> > > > >> >
>>> > > >
>>> >

Re: [Android] Refactoring for different engines

[Joe Bowser <bo...@gmail.com>]

I'm not sure, but I think you still may have to, even if Intel has.  I
did sign an ICLA when we donated the software to Adobe, but I think
that's because a fair amount of it was done on non-work hours when I
was at Nitobi.

On Tue, May 6, 2014 at 8:18 AM, Hu, Ningxin <ni...@intel.com> wrote:
>> BTW: Have you signed the ICLA yet?  If not we should get that taken care of
>> ASAP
>
> Intel has signed the CCLA as corporate contributor. So I assume I think I don't need to sign ICLA, correct?
>
> Thanks,
> -ningxin
>
> On May 5, 2014 5:56 PM, "Hu, Ningxin" <ni...@intel.com> wrote:
>>
>> > Ian,
>> >
>> > I initiated the proposal to crosswalk stakeholders about hosting the
>> > Crosswalk Cordova Engine in Crosswalk projects. The feedback is very
>> > positive. I am now going through the required legal/license clearance
>> > process. I will keep you posted about the status.
>> >
>> > Thanks,
>> > -ningxin
>> >
>> > > -----Original Message-----
>> > > From: iclelland@google.com [mailto:iclelland@google.com] On Behalf
>> > > Of
>> > Ian
>> > > Clelland
>> > > Sent: Wednesday, April 30, 2014 2:23 AM
>> > > To: dev@cordova.apache.org
>> > > Subject: Re: [Android] Refactoring for different engines
>> > >
>> > > On Tue, Apr 29, 2014 at 10:55 AM, Joe Bowser <bo...@gmail.com> wrote:
>> > >
>> > > > So, when Apache publishes something, it has fill the following
>> > criteria:
>> > > >
>> > > > - All source code must have their licence headers intact
>> > > > - All third-party source code must be mentioned in the NOTICE file
>> > > > - No Binary Blobs - No compiled libraries, which include JARs and
>> > > > shared object files (including the pak).
>> > > >
>> > > > Now, with Crosswalk, there's obviously the Chromium Library that
>> > > > we need, so we need a way to get that into the generated project
>> somehow.
>> > > >  The easiest way is with plugman, but the issue is that Apache
>> > > > can't legally pass around binary blobs when it does an official
>> > > > release of anything.  Intel, OTOH, isn't restricted by cumbersome
>> > > > open source foundation rules, and can do so.
>> > > >
>> > >
>> > > Intel has their own rules to follow, certainly, but we're presuming
>> > > here
>> > that Intel
>> > > has already worked out the legal requirements to distribute
>> > > Crosswalk in
>> > the first
>> > > place, so the idea of Intel also distributing the "official"
>> > > Crosswalk
>> > Cordova Engine
>> > > plugin just seems to make a lot of sense.
>> > >
>> > > Apache distributes Cordova-Android, which defines the integration
>> > > API,
>> > and
>> > > includes the default AndroidWebView classes, and other parties
>> > > should be
>> > free
>> > > to distribute their own engine plugins, implementing that API. That
>> > distribution
>> > > can then be in any form that makes sense (and complies with the
>> > > licenses
>> > of the
>> > > various components)
>> > >
>> > > Joe's right that it would be awkward, if not impossible, for Apache
>> > > to
>> > distribute
>> > > the Crosswalk core library. We'd have to include the 15GB of source
>> > > as
>> > well, at the
>> > > very least, and that doesn't sound like fun at all.
>> > > It *is* all open-source, but there are a lot of different licenses
>> > > in
>> > there, and we'd
>> > > need some lawyerly help to make sure that the ASF could release
>> > > software
>> > that
>> > > included it all.
>> > >
>> > > Ian
>> > >
>> > >
>> > > > On Tue, Apr 29, 2014 at 7:43 AM, Hu, Ningxin
>> > > > <ni...@intel.com>
>> > wrote:
>> > > > >> - who publishes the plugins, intel or cordova?
>> > > > >
>> > > > > For this open, could someone elaborate it a little bit more?
>> > > > > What does
>> > > > it mean? I remembered someone mentioned the license is open in the
>> > > > hangouts, any details?
>> > > > >
>> > > > > Thanks,
>> > > > > -ningxin
>> > > > >
>> > > > >> -----Original Message-----
>> > > > >> From: mmocny@google.com [mailto:mmocny@google.com] On Behalf
>> Of
>> > > > >> Michal Mocny
>> > > > >> Sent: Saturday, April 26, 2014 12:53 AM
>> > > > >> To: dev
>> > > > >> Subject: Re: [Android] Refactoring for different engines
>> > > > >>
>> > > > >> Notes:
>> > > > >>
>> > > > >> - native junit tests needs fixing (due to deprication)
>> > > > >>
>> > > > >> - common script for creating walk mobilespec
>> > > > >>
>> > > > >> - fix failing mobile spec tests (file-transfer?, media?)
>> > > > >>
>> > > > >> - who publishes the plugins, intel or cordova?
>> > > > >>
>> > > > >> - static vs dynamic xwalk lib
>> > > > >>
>> > > > >>   - (option) one plugin, use hooks to download static library
>> > > > >>
>> > > > >>   - (option) one plugin, just bundle static lib
>> > > > >>
>> > > > >>   - (option) one plugin, download static lib on app run
>> > > > >>
>> > > > >>   - (option) two plugins, xwalk lib bundled in a separate
>> > > > >> plugin, and
>> > > > can be added
>> > > > >> as a <dep>?
>> > > > >>
>> > > > >> - intel vs arm binary apk targets for CLI.  Two android
>> > > > >> platforms, or
>> > > > just two build
>> > > > >> targets?
>> > > > >>
>> > > > >> - How long to get GeckoView: Joe not sure. days to weeks :(
>> > > > >>
>> > > > >>   - Not blocking, though
>> > > > >>
>> > > > >> - plugman works to install but CLI does not, lets figure that
>> > > > >> out
>> > > > >>
>> > > > >> - Other platforms: Windows Phone support!?  BB10?!
>> > > > >>
>> > > > >> - Can we share code between xwalk WebViewClient and gecko view
>> > > > >> WebViewClient etc?
>> > > > >>
>> > > > >>
>> > > > >> On Fri, Apr 25, 2014 at 12:09 PM, Josh Soref
>> > > > >> <js...@blackberry.com>
>> > > > wrote:
>> > > > >>
>> > > > >> > Ian Clelland wrote:
>> > > > >> >
>> > > > >> > >
>> > > > >> >
>> > > > https://staging.talkgadget.google.com/hangouts/_/7ecpi3uaclcuedn7i
>> > > > mn6b
>> > > > >> > 9jdq
>> > > > >> > >c
>> > > > >> >
>> > > > >> > https://talkgadget.google.com/hangouts/_/7ecpi3uaclcuedn7imn6
>> > > > >> > b9jd
>> > > > >> > qc
>> > > > >> >
>> > > > >> > Might work. Staging is probably internal.
>> > > > >> >
>> > > > >> >
>> > > >
>> >

Re: [Android] Refactoring for different engines

[Andrew Grieve <ag...@chromium.org>]

You do in-fact still need to sign an ICLA. Can be done online.
http://www.apache.org/licenses/#clas


On Tue, May 6, 2014 at 11:18 AM, Hu, Ningxin <ni...@intel.com> wrote:

> > BTW: Have you signed the ICLA yet?  If not we should get that taken care
> of
> > ASAP
>
> Intel has signed the CCLA as corporate contributor. So I assume I think I
> don't need to sign ICLA, correct?
>
> Thanks,
> -ningxin
>
> On May 5, 2014 5:56 PM, "Hu, Ningxin" <ni...@intel.com> wrote:
> >
> > > Ian,
> > >
> > > I initiated the proposal to crosswalk stakeholders about hosting the
> > > Crosswalk Cordova Engine in Crosswalk projects. The feedback is very
> > > positive. I am now going through the required legal/license clearance
> > > process. I will keep you posted about the status.
> > >
> > > Thanks,
> > > -ningxin
> > >
> > > > -----Original Message-----
> > > > From: iclelland@google.com [mailto:iclelland@google.com] On Behalf
> > > > Of
> > > Ian
> > > > Clelland
> > > > Sent: Wednesday, April 30, 2014 2:23 AM
> > > > To: dev@cordova.apache.org
> > > > Subject: Re: [Android] Refactoring for different engines
> > > >
> > > > On Tue, Apr 29, 2014 at 10:55 AM, Joe Bowser <bo...@gmail.com>
> wrote:
> > > >
> > > > > So, when Apache publishes something, it has fill the following
> > > criteria:
> > > > >
> > > > > - All source code must have their licence headers intact
> > > > > - All third-party source code must be mentioned in the NOTICE file
> > > > > - No Binary Blobs - No compiled libraries, which include JARs and
> > > > > shared object files (including the pak).
> > > > >
> > > > > Now, with Crosswalk, there's obviously the Chromium Library that
> > > > > we need, so we need a way to get that into the generated project
> > somehow.
> > > > >  The easiest way is with plugman, but the issue is that Apache
> > > > > can't legally pass around binary blobs when it does an official
> > > > > release of anything.  Intel, OTOH, isn't restricted by cumbersome
> > > > > open source foundation rules, and can do so.
> > > > >
> > > >
> > > > Intel has their own rules to follow, certainly, but we're presuming
> > > > here
> > > that Intel
> > > > has already worked out the legal requirements to distribute
> > > > Crosswalk in
> > > the first
> > > > place, so the idea of Intel also distributing the "official"
> > > > Crosswalk
> > > Cordova Engine
> > > > plugin just seems to make a lot of sense.
> > > >
> > > > Apache distributes Cordova-Android, which defines the integration
> > > > API,
> > > and
> > > > includes the default AndroidWebView classes, and other parties
> > > > should be
> > > free
> > > > to distribute their own engine plugins, implementing that API. That
> > > distribution
> > > > can then be in any form that makes sense (and complies with the
> > > > licenses
> > > of the
> > > > various components)
> > > >
> > > > Joe's right that it would be awkward, if not impossible, for Apache
> > > > to
> > > distribute
> > > > the Crosswalk core library. We'd have to include the 15GB of source
> > > > as
> > > well, at the
> > > > very least, and that doesn't sound like fun at all.
> > > > It *is* all open-source, but there are a lot of different licenses
> > > > in
> > > there, and we'd
> > > > need some lawyerly help to make sure that the ASF could release
> > > > software
> > > that
> > > > included it all.
> > > >
> > > > Ian
> > > >
> > > >
> > > > > On Tue, Apr 29, 2014 at 7:43 AM, Hu, Ningxin
> > > > > <ni...@intel.com>
> > > wrote:
> > > > > >> - who publishes the plugins, intel or cordova?
> > > > > >
> > > > > > For this open, could someone elaborate it a little bit more?
> > > > > > What does
> > > > > it mean? I remembered someone mentioned the license is open in the
> > > > > hangouts, any details?
> > > > > >
> > > > > > Thanks,
> > > > > > -ningxin
> > > > > >
> > > > > >> -----Original Message-----
> > > > > >> From: mmocny@google.com [mailto:mmocny@google.com] On Behalf
> > Of
> > > > > >> Michal Mocny
> > > > > >> Sent: Saturday, April 26, 2014 12:53 AM
> > > > > >> To: dev
> > > > > >> Subject: Re: [Android] Refactoring for different engines
> > > > > >>
> > > > > >> Notes:
> > > > > >>
> > > > > >> - native junit tests needs fixing (due to deprication)
> > > > > >>
> > > > > >> - common script for creating walk mobilespec
> > > > > >>
> > > > > >> - fix failing mobile spec tests (file-transfer?, media?)
> > > > > >>
> > > > > >> - who publishes the plugins, intel or cordova?
> > > > > >>
> > > > > >> - static vs dynamic xwalk lib
> > > > > >>
> > > > > >>   - (option) one plugin, use hooks to download static library
> > > > > >>
> > > > > >>   - (option) one plugin, just bundle static lib
> > > > > >>
> > > > > >>   - (option) one plugin, download static lib on app run
> > > > > >>
> > > > > >>   - (option) two plugins, xwalk lib bundled in a separate
> > > > > >> plugin, and
> > > > > can be added
> > > > > >> as a <dep>?
> > > > > >>
> > > > > >> - intel vs arm binary apk targets for CLI.  Two android
> > > > > >> platforms, or
> > > > > just two build
> > > > > >> targets?
> > > > > >>
> > > > > >> - How long to get GeckoView: Joe not sure. days to weeks :(
> > > > > >>
> > > > > >>   - Not blocking, though
> > > > > >>
> > > > > >> - plugman works to install but CLI does not, lets figure that
> > > > > >> out
> > > > > >>
> > > > > >> - Other platforms: Windows Phone support!?  BB10?!
> > > > > >>
> > > > > >> - Can we share code between xwalk WebViewClient and gecko view
> > > > > >> WebViewClient etc?
> > > > > >>
> > > > > >>
> > > > > >> On Fri, Apr 25, 2014 at 12:09 PM, Josh Soref
> > > > > >> <js...@blackberry.com>
> > > > > wrote:
> > > > > >>
> > > > > >> > Ian Clelland wrote:
> > > > > >> >
> > > > > >> > >
> > > > > >> >
> > > > > https://staging.talkgadget.google.com/hangouts/_/7ecpi3uaclcuedn7i
> > > > > mn6b
> > > > > >> > 9jdq
> > > > > >> > >c
> > > > > >> >
> > > > > >> > https://talkgadget.google.com/hangouts/_/7ecpi3uaclcuedn7imn6
> > > > > >> > b9jd
> > > > > >> > qc
> > > > > >> >
> > > > > >> > Might work. Staging is probably internal.
> > > > > >> >
> > > > > >> >
> > > > >
> > >
>

RE: [Android] Refactoring for different engines

["Hu, Ningxin" <ni...@intel.com>]

> BTW: Have you signed the ICLA yet?  If not we should get that taken care of
> ASAP 

Intel has signed the CCLA as corporate contributor. So I assume I think I don't need to sign ICLA, correct?

Thanks,
-ningxin

On May 5, 2014 5:56 PM, "Hu, Ningxin" <ni...@intel.com> wrote:
> 
> > Ian,
> >
> > I initiated the proposal to crosswalk stakeholders about hosting the
> > Crosswalk Cordova Engine in Crosswalk projects. The feedback is very
> > positive. I am now going through the required legal/license clearance
> > process. I will keep you posted about the status.
> >
> > Thanks,
> > -ningxin
> >
> > > -----Original Message-----
> > > From: iclelland@google.com [mailto:iclelland@google.com] On Behalf
> > > Of
> > Ian
> > > Clelland
> > > Sent: Wednesday, April 30, 2014 2:23 AM
> > > To: dev@cordova.apache.org
> > > Subject: Re: [Android] Refactoring for different engines
> > >
> > > On Tue, Apr 29, 2014 at 10:55 AM, Joe Bowser <bo...@gmail.com> wrote:
> > >
> > > > So, when Apache publishes something, it has fill the following
> > criteria:
> > > >
> > > > - All source code must have their licence headers intact
> > > > - All third-party source code must be mentioned in the NOTICE file
> > > > - No Binary Blobs - No compiled libraries, which include JARs and
> > > > shared object files (including the pak).
> > > >
> > > > Now, with Crosswalk, there's obviously the Chromium Library that
> > > > we need, so we need a way to get that into the generated project
> somehow.
> > > >  The easiest way is with plugman, but the issue is that Apache
> > > > can't legally pass around binary blobs when it does an official
> > > > release of anything.  Intel, OTOH, isn't restricted by cumbersome
> > > > open source foundation rules, and can do so.
> > > >
> > >
> > > Intel has their own rules to follow, certainly, but we're presuming
> > > here
> > that Intel
> > > has already worked out the legal requirements to distribute
> > > Crosswalk in
> > the first
> > > place, so the idea of Intel also distributing the "official"
> > > Crosswalk
> > Cordova Engine
> > > plugin just seems to make a lot of sense.
> > >
> > > Apache distributes Cordova-Android, which defines the integration
> > > API,
> > and
> > > includes the default AndroidWebView classes, and other parties
> > > should be
> > free
> > > to distribute their own engine plugins, implementing that API. That
> > distribution
> > > can then be in any form that makes sense (and complies with the
> > > licenses
> > of the
> > > various components)
> > >
> > > Joe's right that it would be awkward, if not impossible, for Apache
> > > to
> > distribute
> > > the Crosswalk core library. We'd have to include the 15GB of source
> > > as
> > well, at the
> > > very least, and that doesn't sound like fun at all.
> > > It *is* all open-source, but there are a lot of different licenses
> > > in
> > there, and we'd
> > > need some lawyerly help to make sure that the ASF could release
> > > software
> > that
> > > included it all.
> > >
> > > Ian
> > >
> > >
> > > > On Tue, Apr 29, 2014 at 7:43 AM, Hu, Ningxin
> > > > <ni...@intel.com>
> > wrote:
> > > > >> - who publishes the plugins, intel or cordova?
> > > > >
> > > > > For this open, could someone elaborate it a little bit more?
> > > > > What does
> > > > it mean? I remembered someone mentioned the license is open in the
> > > > hangouts, any details?
> > > > >
> > > > > Thanks,
> > > > > -ningxin
> > > > >
> > > > >> -----Original Message-----
> > > > >> From: mmocny@google.com [mailto:mmocny@google.com] On Behalf
> Of
> > > > >> Michal Mocny
> > > > >> Sent: Saturday, April 26, 2014 12:53 AM
> > > > >> To: dev
> > > > >> Subject: Re: [Android] Refactoring for different engines
> > > > >>
> > > > >> Notes:
> > > > >>
> > > > >> - native junit tests needs fixing (due to deprication)
> > > > >>
> > > > >> - common script for creating walk mobilespec
> > > > >>
> > > > >> - fix failing mobile spec tests (file-transfer?, media?)
> > > > >>
> > > > >> - who publishes the plugins, intel or cordova?
> > > > >>
> > > > >> - static vs dynamic xwalk lib
> > > > >>
> > > > >>   - (option) one plugin, use hooks to download static library
> > > > >>
> > > > >>   - (option) one plugin, just bundle static lib
> > > > >>
> > > > >>   - (option) one plugin, download static lib on app run
> > > > >>
> > > > >>   - (option) two plugins, xwalk lib bundled in a separate
> > > > >> plugin, and
> > > > can be added
> > > > >> as a <dep>?
> > > > >>
> > > > >> - intel vs arm binary apk targets for CLI.  Two android
> > > > >> platforms, or
> > > > just two build
> > > > >> targets?
> > > > >>
> > > > >> - How long to get GeckoView: Joe not sure. days to weeks :(
> > > > >>
> > > > >>   - Not blocking, though
> > > > >>
> > > > >> - plugman works to install but CLI does not, lets figure that
> > > > >> out
> > > > >>
> > > > >> - Other platforms: Windows Phone support!?  BB10?!
> > > > >>
> > > > >> - Can we share code between xwalk WebViewClient and gecko view
> > > > >> WebViewClient etc?
> > > > >>
> > > > >>
> > > > >> On Fri, Apr 25, 2014 at 12:09 PM, Josh Soref
> > > > >> <js...@blackberry.com>
> > > > wrote:
> > > > >>
> > > > >> > Ian Clelland wrote:
> > > > >> >
> > > > >> > >
> > > > >> >
> > > > https://staging.talkgadget.google.com/hangouts/_/7ecpi3uaclcuedn7i
> > > > mn6b
> > > > >> > 9jdq
> > > > >> > >c
> > > > >> >
> > > > >> > https://talkgadget.google.com/hangouts/_/7ecpi3uaclcuedn7imn6
> > > > >> > b9jd
> > > > >> > qc
> > > > >> >
> > > > >> > Might work. Staging is probably internal.
> > > > >> >
> > > > >> >
> > > >
> >

RE: [Android] Refactoring for different engines

[Joe Bowser <bo...@gmail.com>]

Actually, the Apache repo is now the canonical branch to go on. I'll post
the URI when I get back to a keyboard.

BTW: Have you signed the ICLA yet?  If not we should get that taken care of
ASAP
On May 5, 2014 5:56 PM, "Hu, Ningxin" <ni...@intel.com> wrote:

> Ian,
>
> I initiated the proposal to crosswalk stakeholders about hosting the
> Crosswalk Cordova Engine in Crosswalk projects. The feedback is very
> positive. I am now going through the required legal/license clearance
> process. I will keep you posted about the status.
>
> Thanks,
> -ningxin
>
> > -----Original Message-----
> > From: iclelland@google.com [mailto:iclelland@google.com] On Behalf Of
> Ian
> > Clelland
> > Sent: Wednesday, April 30, 2014 2:23 AM
> > To: dev@cordova.apache.org
> > Subject: Re: [Android] Refactoring for different engines
> >
> > On Tue, Apr 29, 2014 at 10:55 AM, Joe Bowser <bo...@gmail.com> wrote:
> >
> > > So, when Apache publishes something, it has fill the following
> criteria:
> > >
> > > - All source code must have their licence headers intact
> > > - All third-party source code must be mentioned in the NOTICE file
> > > - No Binary Blobs - No compiled libraries, which include JARs and
> > > shared object files (including the pak).
> > >
> > > Now, with Crosswalk, there's obviously the Chromium Library that we
> > > need, so we need a way to get that into the generated project somehow.
> > >  The easiest way is with plugman, but the issue is that Apache can't
> > > legally pass around binary blobs when it does an official release of
> > > anything.  Intel, OTOH, isn't restricted by cumbersome open source
> > > foundation rules, and can do so.
> > >
> >
> > Intel has their own rules to follow, certainly, but we're presuming here
> that Intel
> > has already worked out the legal requirements to distribute Crosswalk in
> the first
> > place, so the idea of Intel also distributing the "official" Crosswalk
> Cordova Engine
> > plugin just seems to make a lot of sense.
> >
> > Apache distributes Cordova-Android, which defines the integration API,
> and
> > includes the default AndroidWebView classes, and other parties should be
> free
> > to distribute their own engine plugins, implementing that API. That
> distribution
> > can then be in any form that makes sense (and complies with the licenses
> of the
> > various components)
> >
> > Joe's right that it would be awkward, if not impossible, for Apache to
> distribute
> > the Crosswalk core library. We'd have to include the 15GB of source as
> well, at the
> > very least, and that doesn't sound like fun at all.
> > It *is* all open-source, but there are a lot of different licenses in
> there, and we'd
> > need some lawyerly help to make sure that the ASF could release software
> that
> > included it all.
> >
> > Ian
> >
> >
> > > On Tue, Apr 29, 2014 at 7:43 AM, Hu, Ningxin <ni...@intel.com>
> wrote:
> > > >> - who publishes the plugins, intel or cordova?
> > > >
> > > > For this open, could someone elaborate it a little bit more? What
> > > > does
> > > it mean? I remembered someone mentioned the license is open in the
> > > hangouts, any details?
> > > >
> > > > Thanks,
> > > > -ningxin
> > > >
> > > >> -----Original Message-----
> > > >> From: mmocny@google.com [mailto:mmocny@google.com] On Behalf Of
> > > >> Michal Mocny
> > > >> Sent: Saturday, April 26, 2014 12:53 AM
> > > >> To: dev
> > > >> Subject: Re: [Android] Refactoring for different engines
> > > >>
> > > >> Notes:
> > > >>
> > > >> - native junit tests needs fixing (due to deprication)
> > > >>
> > > >> - common script for creating walk mobilespec
> > > >>
> > > >> - fix failing mobile spec tests (file-transfer?, media?)
> > > >>
> > > >> - who publishes the plugins, intel or cordova?
> > > >>
> > > >> - static vs dynamic xwalk lib
> > > >>
> > > >>   - (option) one plugin, use hooks to download static library
> > > >>
> > > >>   - (option) one plugin, just bundle static lib
> > > >>
> > > >>   - (option) one plugin, download static lib on app run
> > > >>
> > > >>   - (option) two plugins, xwalk lib bundled in a separate plugin,
> > > >> and
> > > can be added
> > > >> as a <dep>?
> > > >>
> > > >> - intel vs arm binary apk targets for CLI.  Two android platforms,
> > > >> or
> > > just two build
> > > >> targets?
> > > >>
> > > >> - How long to get GeckoView: Joe not sure. days to weeks :(
> > > >>
> > > >>   - Not blocking, though
> > > >>
> > > >> - plugman works to install but CLI does not, lets figure that out
> > > >>
> > > >> - Other platforms: Windows Phone support!?  BB10?!
> > > >>
> > > >> - Can we share code between xwalk WebViewClient and gecko view
> > > >> WebViewClient etc?
> > > >>
> > > >>
> > > >> On Fri, Apr 25, 2014 at 12:09 PM, Josh Soref
> > > >> <js...@blackberry.com>
> > > wrote:
> > > >>
> > > >> > Ian Clelland wrote:
> > > >> >
> > > >> > >
> > > >> >
> > > https://staging.talkgadget.google.com/hangouts/_/7ecpi3uaclcuedn7imn6b
> > > >> > 9jdq
> > > >> > >c
> > > >> >
> > > >> > https://talkgadget.google.com/hangouts/_/7ecpi3uaclcuedn7imn6b9jd
> > > >> > qc
> > > >> >
> > > >> > Might work. Staging is probably internal.
> > > >> >
> > > >> >
> > >
>

RE: [Android] Refactoring for different engines

["Hu, Ningxin" <ni...@intel.com>]

Ian,

I initiated the proposal to crosswalk stakeholders about hosting the Crosswalk Cordova Engine in Crosswalk projects. The feedback is very positive. I am now going through the required legal/license clearance process. I will keep you posted about the status.

Thanks,
-ningxin

> -----Original Message-----
> From: iclelland@google.com [mailto:iclelland@google.com] On Behalf Of Ian
> Clelland
> Sent: Wednesday, April 30, 2014 2:23 AM
> To: dev@cordova.apache.org
> Subject: Re: [Android] Refactoring for different engines
> 
> On Tue, Apr 29, 2014 at 10:55 AM, Joe Bowser <bo...@gmail.com> wrote:
> 
> > So, when Apache publishes something, it has fill the following criteria:
> >
> > - All source code must have their licence headers intact
> > - All third-party source code must be mentioned in the NOTICE file
> > - No Binary Blobs - No compiled libraries, which include JARs and
> > shared object files (including the pak).
> >
> > Now, with Crosswalk, there's obviously the Chromium Library that we
> > need, so we need a way to get that into the generated project somehow.
> >  The easiest way is with plugman, but the issue is that Apache can't
> > legally pass around binary blobs when it does an official release of
> > anything.  Intel, OTOH, isn't restricted by cumbersome open source
> > foundation rules, and can do so.
> >
> 
> Intel has their own rules to follow, certainly, but we're presuming here that Intel
> has already worked out the legal requirements to distribute Crosswalk in the first
> place, so the idea of Intel also distributing the "official" Crosswalk Cordova Engine
> plugin just seems to make a lot of sense.
> 
> Apache distributes Cordova-Android, which defines the integration API, and
> includes the default AndroidWebView classes, and other parties should be free
> to distribute their own engine plugins, implementing that API. That distribution
> can then be in any form that makes sense (and complies with the licenses of the
> various components)
> 
> Joe's right that it would be awkward, if not impossible, for Apache to distribute
> the Crosswalk core library. We'd have to include the 15GB of source as well, at the
> very least, and that doesn't sound like fun at all.
> It *is* all open-source, but there are a lot of different licenses in there, and we'd
> need some lawyerly help to make sure that the ASF could release software that
> included it all.
> 
> Ian
> 
> 
> > On Tue, Apr 29, 2014 at 7:43 AM, Hu, Ningxin <ni...@intel.com> wrote:
> > >> - who publishes the plugins, intel or cordova?
> > >
> > > For this open, could someone elaborate it a little bit more? What
> > > does
> > it mean? I remembered someone mentioned the license is open in the
> > hangouts, any details?
> > >
> > > Thanks,
> > > -ningxin
> > >
> > >> -----Original Message-----
> > >> From: mmocny@google.com [mailto:mmocny@google.com] On Behalf Of
> > >> Michal Mocny
> > >> Sent: Saturday, April 26, 2014 12:53 AM
> > >> To: dev
> > >> Subject: Re: [Android] Refactoring for different engines
> > >>
> > >> Notes:
> > >>
> > >> - native junit tests needs fixing (due to deprication)
> > >>
> > >> - common script for creating walk mobilespec
> > >>
> > >> - fix failing mobile spec tests (file-transfer?, media?)
> > >>
> > >> - who publishes the plugins, intel or cordova?
> > >>
> > >> - static vs dynamic xwalk lib
> > >>
> > >>   - (option) one plugin, use hooks to download static library
> > >>
> > >>   - (option) one plugin, just bundle static lib
> > >>
> > >>   - (option) one plugin, download static lib on app run
> > >>
> > >>   - (option) two plugins, xwalk lib bundled in a separate plugin,
> > >> and
> > can be added
> > >> as a <dep>?
> > >>
> > >> - intel vs arm binary apk targets for CLI.  Two android platforms,
> > >> or
> > just two build
> > >> targets?
> > >>
> > >> - How long to get GeckoView: Joe not sure. days to weeks :(
> > >>
> > >>   - Not blocking, though
> > >>
> > >> - plugman works to install but CLI does not, lets figure that out
> > >>
> > >> - Other platforms: Windows Phone support!?  BB10?!
> > >>
> > >> - Can we share code between xwalk WebViewClient and gecko view
> > >> WebViewClient etc?
> > >>
> > >>
> > >> On Fri, Apr 25, 2014 at 12:09 PM, Josh Soref
> > >> <js...@blackberry.com>
> > wrote:
> > >>
> > >> > Ian Clelland wrote:
> > >> >
> > >> > >
> > >> >
> > https://staging.talkgadget.google.com/hangouts/_/7ecpi3uaclcuedn7imn6b
> > >> > 9jdq
> > >> > >c
> > >> >
> > >> > https://talkgadget.google.com/hangouts/_/7ecpi3uaclcuedn7imn6b9jd
> > >> > qc
> > >> >
> > >> > Might work. Staging is probably internal.
> > >> >
> > >> >
> >

RE: [Android] Refactoring for different engines

["Hu, Ningxin" <ni...@intel.com>]

Brian, Joe and Ian,

Thanks for your detailed explanations. It makes lots of senses. Let's make it happen.

Thanks,
-ningxin

> -----Original Message-----
> From: brian.leroux@gmail.com [mailto:brian.leroux@gmail.com] On Behalf Of
> Brian LeRoux
> Sent: Wednesday, April 30, 2014 4:47 AM
> To: dev@cordova.apache.org
> Subject: Re: [Android] Refactoring for different engines
> 
> Think those builds should be hosted by those downstreams anyhow. Cordova is
> sort of the low level, on the metal, default webview and building these things is
> a very deliberate choice by the end developer using the platform.
> Moz should host Gecko builds. Chromium should host custom ChromeViews
> (someday, I dream) and, Crosswalk should host their thing. Etc. Maybe someday
> we can get an IE binary from Microsoft. Dare to dream.
> 
> 
> On Tue, Apr 29, 2014 at 11:22 AM, Ian Clelland <ic...@chromium.org>wrote:
> 
> > On Tue, Apr 29, 2014 at 10:55 AM, Joe Bowser <bo...@gmail.com> wrote:
> >
> > > So, when Apache publishes something, it has fill the following criteria:
> > >
> > > - All source code must have their licence headers intact
> > > - All third-party source code must be mentioned in the NOTICE file
> > > - No Binary Blobs - No compiled libraries, which include JARs and
> > > shared object files (including the pak).
> > >
> > > Now, with Crosswalk, there's obviously the Chromium Library that we
> > > need, so we need a way to get that into the generated project somehow.
> > >  The easiest way is with plugman, but the issue is that Apache can't
> > > legally pass around binary blobs when it does an official release of
> > > anything.  Intel, OTOH, isn't restricted by cumbersome open source
> > > foundation rules, and can do so.
> > >
> >
> > Intel has their own rules to follow, certainly, but we're presuming
> > here that Intel has already worked out the legal requirements to
> > distribute Crosswalk in the first place, so the idea of Intel also
> > distributing the "official" Crosswalk Cordova Engine plugin just seems
> > to make a lot of sense.
> >
> > Apache distributes Cordova-Android, which defines the integration API,
> > and includes the default AndroidWebView classes, and other parties
> > should be free to distribute their own engine plugins, implementing
> > that API. That distribution can then be in any form that makes sense
> > (and complies with the licenses of the various components)
> >
> > Joe's right that it would be awkward, if not impossible, for Apache to
> > distribute the Crosswalk core library. We'd have to include the 15GB
> > of source as well, at the very least, and that doesn't sound like fun at all.
> > It *is* all open-source, but there are a lot of different licenses in
> > there, and we'd need some lawyerly help to make sure that the ASF
> > could release software that included it all.
> >
> > Ian
> >
> >
> > > On Tue, Apr 29, 2014 at 7:43 AM, Hu, Ningxin <ni...@intel.com>
> > wrote:
> > > >> - who publishes the plugins, intel or cordova?
> > > >
> > > > For this open, could someone elaborate it a little bit more? What
> > > > does
> > > it mean? I remembered someone mentioned the license is open in the
> > > hangouts, any details?
> > > >
> > > > Thanks,
> > > > -ningxin
> > > >
> > > >> -----Original Message-----
> > > >> From: mmocny@google.com [mailto:mmocny@google.com] On Behalf Of
> > Michal
> > > >> Mocny
> > > >> Sent: Saturday, April 26, 2014 12:53 AM
> > > >> To: dev
> > > >> Subject: Re: [Android] Refactoring for different engines
> > > >>
> > > >> Notes:
> > > >>
> > > >> - native junit tests needs fixing (due to deprication)
> > > >>
> > > >> - common script for creating walk mobilespec
> > > >>
> > > >> - fix failing mobile spec tests (file-transfer?, media?)
> > > >>
> > > >> - who publishes the plugins, intel or cordova?
> > > >>
> > > >> - static vs dynamic xwalk lib
> > > >>
> > > >>   - (option) one plugin, use hooks to download static library
> > > >>
> > > >>   - (option) one plugin, just bundle static lib
> > > >>
> > > >>   - (option) one plugin, download static lib on app run
> > > >>
> > > >>   - (option) two plugins, xwalk lib bundled in a separate plugin,
> > > >> and
> > > can be added
> > > >> as a <dep>?
> > > >>
> > > >> - intel vs arm binary apk targets for CLI.  Two android
> > > >> platforms, or
> > > just two build
> > > >> targets?
> > > >>
> > > >> - How long to get GeckoView: Joe not sure. days to weeks :(
> > > >>
> > > >>   - Not blocking, though
> > > >>
> > > >> - plugman works to install but CLI does not, lets figure that out
> > > >>
> > > >> - Other platforms: Windows Phone support!?  BB10?!
> > > >>
> > > >> - Can we share code between xwalk WebViewClient and gecko view
> > > >> WebViewClient etc?
> > > >>
> > > >>
> > > >> On Fri, Apr 25, 2014 at 12:09 PM, Josh Soref
> > > >> <js...@blackberry.com>
> > > wrote:
> > > >>
> > > >> > Ian Clelland wrote:
> > > >> >
> > > >> > >
> > > >> >
> > > https://staging.talkgadget.google.com/hangouts/_/7ecpi3uaclcuedn7imn
> > > 6b
> > > >> > 9jdq
> > > >> > >c
> > > >> >
> > > >> > https://talkgadget.google.com/hangouts/_/7ecpi3uaclcuedn7imn6b9
> > > >> > jdqc
> > > >> >
> > > >> > Might work. Staging is probably internal.
> > > >> >
> > > >> >
> > >
> >

Re: [Android] Refactoring for different engines

[Brian LeRoux <b...@brian.io>]

Think those builds should be hosted by those downstreams anyhow. Cordova is
sort of the low level, on the metal, default webview and building these
things is a very deliberate choice by the end developer using the platform.
Moz should host Gecko builds. Chromium should host custom ChromeViews
(someday, I dream) and, Crosswalk should host their thing. Etc. Maybe
someday we can get an IE binary from Microsoft. Dare to dream.


On Tue, Apr 29, 2014 at 11:22 AM, Ian Clelland <ic...@chromium.org>wrote:

> On Tue, Apr 29, 2014 at 10:55 AM, Joe Bowser <bo...@gmail.com> wrote:
>
> > So, when Apache publishes something, it has fill the following criteria:
> >
> > - All source code must have their licence headers intact
> > - All third-party source code must be mentioned in the NOTICE file
> > - No Binary Blobs - No compiled libraries, which include JARs and
> > shared object files (including the pak).
> >
> > Now, with Crosswalk, there's obviously the Chromium Library that we
> > need, so we need a way to get that into the generated project somehow.
> >  The easiest way is with plugman, but the issue is that Apache can't
> > legally pass around binary blobs when it does an official release of
> > anything.  Intel, OTOH, isn't restricted by cumbersome open source
> > foundation rules, and can do so.
> >
>
> Intel has their own rules to follow, certainly, but we're presuming here
> that Intel has already worked out the legal requirements to distribute
> Crosswalk in the first place, so the idea of Intel also distributing the
> "official" Crosswalk Cordova Engine plugin just seems to make a lot of
> sense.
>
> Apache distributes Cordova-Android, which defines the integration API, and
> includes the default AndroidWebView classes, and other parties should be
> free to distribute their own engine plugins, implementing that API. That
> distribution can then be in any form that makes sense (and complies with
> the licenses of the various components)
>
> Joe's right that it would be awkward, if not impossible, for Apache to
> distribute the Crosswalk core library. We'd have to include the 15GB of
> source as well, at the very least, and that doesn't sound like fun at all.
> It *is* all open-source, but there are a lot of different licenses in
> there, and we'd need some lawyerly help to make sure that the ASF could
> release software that included it all.
>
> Ian
>
>
> > On Tue, Apr 29, 2014 at 7:43 AM, Hu, Ningxin <ni...@intel.com>
> wrote:
> > >> - who publishes the plugins, intel or cordova?
> > >
> > > For this open, could someone elaborate it a little bit more? What does
> > it mean? I remembered someone mentioned the license is open in the
> > hangouts, any details?
> > >
> > > Thanks,
> > > -ningxin
> > >
> > >> -----Original Message-----
> > >> From: mmocny@google.com [mailto:mmocny@google.com] On Behalf Of
> Michal
> > >> Mocny
> > >> Sent: Saturday, April 26, 2014 12:53 AM
> > >> To: dev
> > >> Subject: Re: [Android] Refactoring for different engines
> > >>
> > >> Notes:
> > >>
> > >> - native junit tests needs fixing (due to deprication)
> > >>
> > >> - common script for creating walk mobilespec
> > >>
> > >> - fix failing mobile spec tests (file-transfer?, media?)
> > >>
> > >> - who publishes the plugins, intel or cordova?
> > >>
> > >> - static vs dynamic xwalk lib
> > >>
> > >>   - (option) one plugin, use hooks to download static library
> > >>
> > >>   - (option) one plugin, just bundle static lib
> > >>
> > >>   - (option) one plugin, download static lib on app run
> > >>
> > >>   - (option) two plugins, xwalk lib bundled in a separate plugin, and
> > can be added
> > >> as a <dep>?
> > >>
> > >> - intel vs arm binary apk targets for CLI.  Two android platforms, or
> > just two build
> > >> targets?
> > >>
> > >> - How long to get GeckoView: Joe not sure. days to weeks :(
> > >>
> > >>   - Not blocking, though
> > >>
> > >> - plugman works to install but CLI does not, lets figure that out
> > >>
> > >> - Other platforms: Windows Phone support!?  BB10?!
> > >>
> > >> - Can we share code between xwalk WebViewClient and gecko view
> > >> WebViewClient etc?
> > >>
> > >>
> > >> On Fri, Apr 25, 2014 at 12:09 PM, Josh Soref <js...@blackberry.com>
> > wrote:
> > >>
> > >> > Ian Clelland wrote:
> > >> >
> > >> > >
> > >> >
> > https://staging.talkgadget.google.com/hangouts/_/7ecpi3uaclcuedn7imn6b
> > >> > 9jdq
> > >> > >c
> > >> >
> > >> > https://talkgadget.google.com/hangouts/_/7ecpi3uaclcuedn7imn6b9jdqc
> > >> >
> > >> > Might work. Staging is probably internal.
> > >> >
> > >> >
> >
>

Re: [Android] Refactoring for different engines

[Ian Clelland <ic...@chromium.org>]

On Tue, Apr 29, 2014 at 10:55 AM, Joe Bowser <bo...@gmail.com> wrote:

> So, when Apache publishes something, it has fill the following criteria:
>
> - All source code must have their licence headers intact
> - All third-party source code must be mentioned in the NOTICE file
> - No Binary Blobs - No compiled libraries, which include JARs and
> shared object files (including the pak).
>
> Now, with Crosswalk, there's obviously the Chromium Library that we
> need, so we need a way to get that into the generated project somehow.
>  The easiest way is with plugman, but the issue is that Apache can't
> legally pass around binary blobs when it does an official release of
> anything.  Intel, OTOH, isn't restricted by cumbersome open source
> foundation rules, and can do so.
>

Intel has their own rules to follow, certainly, but we're presuming here
that Intel has already worked out the legal requirements to distribute
Crosswalk in the first place, so the idea of Intel also distributing the
"official" Crosswalk Cordova Engine plugin just seems to make a lot of
sense.

Apache distributes Cordova-Android, which defines the integration API, and
includes the default AndroidWebView classes, and other parties should be
free to distribute their own engine plugins, implementing that API. That
distribution can then be in any form that makes sense (and complies with
the licenses of the various components)

Joe's right that it would be awkward, if not impossible, for Apache to
distribute the Crosswalk core library. We'd have to include the 15GB of
source as well, at the very least, and that doesn't sound like fun at all.
It *is* all open-source, but there are a lot of different licenses in
there, and we'd need some lawyerly help to make sure that the ASF could
release software that included it all.

Ian


> On Tue, Apr 29, 2014 at 7:43 AM, Hu, Ningxin <ni...@intel.com> wrote:
> >> - who publishes the plugins, intel or cordova?
> >
> > For this open, could someone elaborate it a little bit more? What does
> it mean? I remembered someone mentioned the license is open in the
> hangouts, any details?
> >
> > Thanks,
> > -ningxin
> >
> >> -----Original Message-----
> >> From: mmocny@google.com [mailto:mmocny@google.com] On Behalf Of Michal
> >> Mocny
> >> Sent: Saturday, April 26, 2014 12:53 AM
> >> To: dev
> >> Subject: Re: [Android] Refactoring for different engines
> >>
> >> Notes:
> >>
> >> - native junit tests needs fixing (due to deprication)
> >>
> >> - common script for creating walk mobilespec
> >>
> >> - fix failing mobile spec tests (file-transfer?, media?)
> >>
> >> - who publishes the plugins, intel or cordova?
> >>
> >> - static vs dynamic xwalk lib
> >>
> >>   - (option) one plugin, use hooks to download static library
> >>
> >>   - (option) one plugin, just bundle static lib
> >>
> >>   - (option) one plugin, download static lib on app run
> >>
> >>   - (option) two plugins, xwalk lib bundled in a separate plugin, and
> can be added
> >> as a <dep>?
> >>
> >> - intel vs arm binary apk targets for CLI.  Two android platforms, or
> just two build
> >> targets?
> >>
> >> - How long to get GeckoView: Joe not sure. days to weeks :(
> >>
> >>   - Not blocking, though
> >>
> >> - plugman works to install but CLI does not, lets figure that out
> >>
> >> - Other platforms: Windows Phone support!?  BB10?!
> >>
> >> - Can we share code between xwalk WebViewClient and gecko view
> >> WebViewClient etc?
> >>
> >>
> >> On Fri, Apr 25, 2014 at 12:09 PM, Josh Soref <js...@blackberry.com>
> wrote:
> >>
> >> > Ian Clelland wrote:
> >> >
> >> > >
> >> >
> https://staging.talkgadget.google.com/hangouts/_/7ecpi3uaclcuedn7imn6b
> >> > 9jdq
> >> > >c
> >> >
> >> > https://talkgadget.google.com/hangouts/_/7ecpi3uaclcuedn7imn6b9jdqc
> >> >
> >> > Might work. Staging is probably internal.
> >> >
> >> >
>

Re: [Android] Refactoring for different engines

[Joe Bowser <bo...@gmail.com>]

So, when Apache publishes something, it has fill the following criteria:

- All source code must have their licence headers intact
- All third-party source code must be mentioned in the NOTICE file
- No Binary Blobs - No compiled libraries, which include JARs and
shared object files (including the pak).

Now, with Crosswalk, there's obviously the Chromium Library that we
need, so we need a way to get that into the generated project somehow.
 The easiest way is with plugman, but the issue is that Apache can't
legally pass around binary blobs when it does an official release of
anything.  Intel, OTOH, isn't restricted by cumbersome open source
foundation rules, and can do so.

On Tue, Apr 29, 2014 at 7:43 AM, Hu, Ningxin <ni...@intel.com> wrote:
>> - who publishes the plugins, intel or cordova?
>
> For this open, could someone elaborate it a little bit more? What does it mean? I remembered someone mentioned the license is open in the hangouts, any details?
>
> Thanks,
> -ningxin
>
>> -----Original Message-----
>> From: mmocny@google.com [mailto:mmocny@google.com] On Behalf Of Michal
>> Mocny
>> Sent: Saturday, April 26, 2014 12:53 AM
>> To: dev
>> Subject: Re: [Android] Refactoring for different engines
>>
>> Notes:
>>
>> - native junit tests needs fixing (due to deprication)
>>
>> - common script for creating walk mobilespec
>>
>> - fix failing mobile spec tests (file-transfer?, media?)
>>
>> - who publishes the plugins, intel or cordova?
>>
>> - static vs dynamic xwalk lib
>>
>>   - (option) one plugin, use hooks to download static library
>>
>>   - (option) one plugin, just bundle static lib
>>
>>   - (option) one plugin, download static lib on app run
>>
>>   - (option) two plugins, xwalk lib bundled in a separate plugin, and can be added
>> as a <dep>?
>>
>> - intel vs arm binary apk targets for CLI.  Two android platforms, or just two build
>> targets?
>>
>> - How long to get GeckoView: Joe not sure. days to weeks :(
>>
>>   - Not blocking, though
>>
>> - plugman works to install but CLI does not, lets figure that out
>>
>> - Other platforms: Windows Phone support!?  BB10?!
>>
>> - Can we share code between xwalk WebViewClient and gecko view
>> WebViewClient etc?
>>
>>
>> On Fri, Apr 25, 2014 at 12:09 PM, Josh Soref <js...@blackberry.com> wrote:
>>
>> > Ian Clelland wrote:
>> >
>> > >
>> > https://staging.talkgadget.google.com/hangouts/_/7ecpi3uaclcuedn7imn6b
>> > 9jdq
>> > >c
>> >
>> > https://talkgadget.google.com/hangouts/_/7ecpi3uaclcuedn7imn6b9jdqc
>> >
>> > Might work. Staging is probably internal.
>> >
>> >

RE: [Android] Refactoring for different engines

["Hu, Ningxin" <ni...@intel.com>]

> - who publishes the plugins, intel or cordova?

For this open, could someone elaborate it a little bit more? What does it mean? I remembered someone mentioned the license is open in the hangouts, any details?

Thanks,
-ningxin

> -----Original Message-----
> From: mmocny@google.com [mailto:mmocny@google.com] On Behalf Of Michal
> Mocny
> Sent: Saturday, April 26, 2014 12:53 AM
> To: dev
> Subject: Re: [Android] Refactoring for different engines
> 
> Notes:
> 
> - native junit tests needs fixing (due to deprication)
> 
> - common script for creating walk mobilespec
> 
> - fix failing mobile spec tests (file-transfer?, media?)
> 
> - who publishes the plugins, intel or cordova?
> 
> - static vs dynamic xwalk lib
> 
>   - (option) one plugin, use hooks to download static library
> 
>   - (option) one plugin, just bundle static lib
> 
>   - (option) one plugin, download static lib on app run
> 
>   - (option) two plugins, xwalk lib bundled in a separate plugin, and can be added
> as a <dep>?
> 
> - intel vs arm binary apk targets for CLI.  Two android platforms, or just two build
> targets?
> 
> - How long to get GeckoView: Joe not sure. days to weeks :(
> 
>   - Not blocking, though
> 
> - plugman works to install but CLI does not, lets figure that out
> 
> - Other platforms: Windows Phone support!?  BB10?!
> 
> - Can we share code between xwalk WebViewClient and gecko view
> WebViewClient etc?
> 
> 
> On Fri, Apr 25, 2014 at 12:09 PM, Josh Soref <js...@blackberry.com> wrote:
> 
> > Ian Clelland wrote:
> >
> > >
> > https://staging.talkgadget.google.com/hangouts/_/7ecpi3uaclcuedn7imn6b
> > 9jdq
> > >c
> >
> > https://talkgadget.google.com/hangouts/_/7ecpi3uaclcuedn7imn6b9jdqc
> >
> > Might work. Staging is probably internal.
> >
> >

RE: [Android] Refactoring for different engines

["Hu, Ningxin" <ni...@intel.com>]

Some follow-ups:

> - fix failing mobile spec tests (file-transfer?, media?)
Media automation tests pass after install media plugin after file plugin.

>   - (option) one plugin, use hooks to download static library
An update: after Crosswalk 6.35.129.0, the Crosswalk WebView could be downloaded directly, for examples
https://download.01.org/crosswalk/releases/crosswalk/android/canary/6.35.129.0/arm/crosswalk-webview-6.35.129.0-arm.zip
https://download.01.org/crosswalk/releases/crosswalk/android/canary/6.35.129.0/x86/crosswalk-webview-6.35.129.0-x86.zip

> - plugman works to install but CLI does not, lets figure that out
Reproduce the CLI issues by:
1. cordova-android/bin/create hello
2. plugman install --plugin cordova-crosswalk-engine --project hello
3. cd hello; cordova/build

My steps to fix:
1. Add "android.library.reference.1=crosswalk-webview-6.35.129.0-arm/xwalk_core_library” into CordovaLib’s project.properties
2. export ANDROID_HOME-<ANDROID_SDK_ROOT>
3. remote custome_rules.xml in generated project, otherwise, R.class of xwalk_core_library will not be generated which leads to switch back to Android WebView.

Thanks,
-ningxin

> -----Original Message-----
> From: mmocny@google.com [mailto:mmocny@google.com] On Behalf Of Michal
> Mocny
> Sent: Saturday, April 26, 2014 12:53 AM
> To: dev
> Subject: Re: [Android] Refactoring for different engines
> 
> Notes:
> 
> - native junit tests needs fixing (due to deprication)
> 
> - common script for creating walk mobilespec
> 
> - fix failing mobile spec tests (file-transfer?, media?)
> 
> - who publishes the plugins, intel or cordova?
> 
> - static vs dynamic xwalk lib
> 
>   - (option) one plugin, use hooks to download static library
> 
>   - (option) one plugin, just bundle static lib
> 
>   - (option) one plugin, download static lib on app run
> 
>   - (option) two plugins, xwalk lib bundled in a separate plugin, and can be added
> as a <dep>?
> 
> - intel vs arm binary apk targets for CLI.  Two android platforms, or just two build
> targets?
> 
> - How long to get GeckoView: Joe not sure. days to weeks :(
> 
>   - Not blocking, though
> 
> - plugman works to install but CLI does not, lets figure that out
> 
> - Other platforms: Windows Phone support!?  BB10?!
> 
> - Can we share code between xwalk WebViewClient and gecko view
> WebViewClient etc?
> 
> 
> On Fri, Apr 25, 2014 at 12:09 PM, Josh Soref <js...@blackberry.com> wrote:
> 
> > Ian Clelland wrote:
> >
> > >
> > https://staging.talkgadget.google.com/hangouts/_/7ecpi3uaclcuedn7imn6b
> > 9jdq
> > >c
> >
> > https://talkgadget.google.com/hangouts/_/7ecpi3uaclcuedn7imn6b9jdqc
> >
> > Might work. Staging is probably internal.
> >
> >

RE: [Android] Refactoring for different engines

["Hu, Ningxin" <ni...@intel.com>]

> Michal wrote:
> One more TODO: We should make sure to support Crosswalk within an app using
> multiple CordovaWebView's, and make sure they share resources best they can.
> 

This is the design goal of Crosswalk WebView. Crosswalk WebView is using single process architecture, multiple Crosswalk WebViews run in one process.

Do we have or plan to have test case of multiple webview instances in one app? Current InAppBrowser plugin is using Android WebView, as I know.

Thanks,
-ningxin

> -Michal
> 
> 
> On Fri, Apr 25, 2014 at 6:18 PM, Joe Bowser <bo...@gmail.com> wrote:
> 
> > Hey
> >
> > Since we don't have confirmation on the Mozilla guys, let's not do the
> > 4:00 PM meeting. This kinda sucks, but yeah, we should touch base
> > sometime next week when we've moved forward a bit.
> >
> > Sorry for making people wait all day for this thing.  I hope that you
> > can salvage your evening!
> >
> > Joe
> >
> > On Fri, Apr 25, 2014 at 9:52 AM, Michal Mocny <mm...@chromium.org>
> wrote:
> > > Notes:
> > >
> > > - native junit tests needs fixing (due to deprication)
> > >
> > > - common script for creating walk mobilespec
> > >
> > > - fix failing mobile spec tests (file-transfer?, media?)
> > >
> > > - who publishes the plugins, intel or cordova?
> > >
> > > - static vs dynamic xwalk lib
> > >
> > >   - (option) one plugin, use hooks to download static library
> > >
> > >   - (option) one plugin, just bundle static lib
> > >
> > >   - (option) one plugin, download static lib on app run
> > >
> > >   - (option) two plugins, xwalk lib bundled in a separate plugin,
> > > and can be added as a <dep>?
> > >
> > > - intel vs arm binary apk targets for CLI.  Two android platforms,
> > > or
> > just
> > > two build targets?
> > >
> > > - How long to get GeckoView: Joe not sure. days to weeks :(
> > >
> > >   - Not blocking, though
> > >
> > > - plugman works to install but CLI does not, lets figure that out
> > >
> > > - Other platforms: Windows Phone support!?  BB10?!
> > >
> > > - Can we share code between xwalk WebViewClient and gecko view
> > > WebViewClient etc?
> > >
> > >
> > > On Fri, Apr 25, 2014 at 12:09 PM, Josh Soref <js...@blackberry.com>
> > wrote:
> > >
> > >> Ian Clelland wrote:
> > >>
> > >> >
> > >>
> > https://staging.talkgadget.google.com/hangouts/_/7ecpi3uaclcuedn7imn6b
> > 9jdq
> > >> >c
> > >>
> > >> https://talkgadget.google.com/hangouts/_/7ecpi3uaclcuedn7imn6b9jdqc
> > >>
> > >> Might work. Staging is probably internal.
> > >>
> > >>
> >

Re: [Android] Refactoring for different engines

[Michal Mocny <mm...@chromium.org>]

One more TODO: We should make sure to support Crosswalk within an app using
multiple CordovaWebView's, and make sure they share resources best they can.

-Michal


On Fri, Apr 25, 2014 at 6:18 PM, Joe Bowser <bo...@gmail.com> wrote:

> Hey
>
> Since we don't have confirmation on the Mozilla guys, let's not do the
> 4:00 PM meeting. This kinda sucks, but yeah, we should touch base
> sometime next week when we've moved forward a bit.
>
> Sorry for making people wait all day for this thing.  I hope that you
> can salvage your evening!
>
> Joe
>
> On Fri, Apr 25, 2014 at 9:52 AM, Michal Mocny <mm...@chromium.org> wrote:
> > Notes:
> >
> > - native junit tests needs fixing (due to deprication)
> >
> > - common script for creating walk mobilespec
> >
> > - fix failing mobile spec tests (file-transfer?, media?)
> >
> > - who publishes the plugins, intel or cordova?
> >
> > - static vs dynamic xwalk lib
> >
> >   - (option) one plugin, use hooks to download static library
> >
> >   - (option) one plugin, just bundle static lib
> >
> >   - (option) one plugin, download static lib on app run
> >
> >   - (option) two plugins, xwalk lib bundled in a separate plugin, and can
> > be added as a <dep>?
> >
> > - intel vs arm binary apk targets for CLI.  Two android platforms, or
> just
> > two build targets?
> >
> > - How long to get GeckoView: Joe not sure. days to weeks :(
> >
> >   - Not blocking, though
> >
> > - plugman works to install but CLI does not, lets figure that out
> >
> > - Other platforms: Windows Phone support!?  BB10?!
> >
> > - Can we share code between xwalk WebViewClient and gecko view
> > WebViewClient etc?
> >
> >
> > On Fri, Apr 25, 2014 at 12:09 PM, Josh Soref <js...@blackberry.com>
> wrote:
> >
> >> Ian Clelland wrote:
> >>
> >> >
> >>
> https://staging.talkgadget.google.com/hangouts/_/7ecpi3uaclcuedn7imn6b9jdq
> >> >c
> >>
> >> https://talkgadget.google.com/hangouts/_/7ecpi3uaclcuedn7imn6b9jdqc
> >>
> >> Might work. Staging is probably internal.
> >>
> >>
>

Re: [Android] Refactoring for different engines

[Joe Bowser <bo...@gmail.com>]

Hey

Since we don't have confirmation on the Mozilla guys, let's not do the
4:00 PM meeting. This kinda sucks, but yeah, we should touch base
sometime next week when we've moved forward a bit.

Sorry for making people wait all day for this thing.  I hope that you
can salvage your evening!

Joe

On Fri, Apr 25, 2014 at 9:52 AM, Michal Mocny <mm...@chromium.org> wrote:
> Notes:
>
> - native junit tests needs fixing (due to deprication)
>
> - common script for creating walk mobilespec
>
> - fix failing mobile spec tests (file-transfer?, media?)
>
> - who publishes the plugins, intel or cordova?
>
> - static vs dynamic xwalk lib
>
>   - (option) one plugin, use hooks to download static library
>
>   - (option) one plugin, just bundle static lib
>
>   - (option) one plugin, download static lib on app run
>
>   - (option) two plugins, xwalk lib bundled in a separate plugin, and can
> be added as a <dep>?
>
> - intel vs arm binary apk targets for CLI.  Two android platforms, or just
> two build targets?
>
> - How long to get GeckoView: Joe not sure. days to weeks :(
>
>   - Not blocking, though
>
> - plugman works to install but CLI does not, lets figure that out
>
> - Other platforms: Windows Phone support!?  BB10?!
>
> - Can we share code between xwalk WebViewClient and gecko view
> WebViewClient etc?
>
>
> On Fri, Apr 25, 2014 at 12:09 PM, Josh Soref <js...@blackberry.com> wrote:
>
>> Ian Clelland wrote:
>>
>> >
>> https://staging.talkgadget.google.com/hangouts/_/7ecpi3uaclcuedn7imn6b9jdq
>> >c
>>
>> https://talkgadget.google.com/hangouts/_/7ecpi3uaclcuedn7imn6b9jdqc
>>
>> Might work. Staging is probably internal.
>>
>>

Re: [Android] Refactoring for different engines

[Michal Mocny <mm...@chromium.org>]

Notes:

- native junit tests needs fixing (due to deprication)

- common script for creating walk mobilespec

- fix failing mobile spec tests (file-transfer?, media?)

- who publishes the plugins, intel or cordova?

- static vs dynamic xwalk lib

  - (option) one plugin, use hooks to download static library

  - (option) one plugin, just bundle static lib

  - (option) one plugin, download static lib on app run

  - (option) two plugins, xwalk lib bundled in a separate plugin, and can
be added as a <dep>?

- intel vs arm binary apk targets for CLI.  Two android platforms, or just
two build targets?

- How long to get GeckoView: Joe not sure. days to weeks :(

  - Not blocking, though

- plugman works to install but CLI does not, lets figure that out

- Other platforms: Windows Phone support!?  BB10?!

- Can we share code between xwalk WebViewClient and gecko view
WebViewClient etc?


On Fri, Apr 25, 2014 at 12:09 PM, Josh Soref <js...@blackberry.com> wrote:

> Ian Clelland wrote:
>
> >
> https://staging.talkgadget.google.com/hangouts/_/7ecpi3uaclcuedn7imn6b9jdq
> >c
>
> https://talkgadget.google.com/hangouts/_/7ecpi3uaclcuedn7imn6b9jdqc
>
> Might work. Staging is probably internal.
>
>

Re: [Android] Refactoring for different engines

[Josh Soref <js...@blackberry.com>]

Ian Clelland wrote:

>https://staging.talkgadget.google.com/hangouts/_/7ecpi3uaclcuedn7imn6b9jdq
>c

https://talkgadget.google.com/hangouts/_/7ecpi3uaclcuedn7imn6b9jdqc

Might work. Staging is probably internal.

Re: [Android] Refactoring for different engines

[Ian Clelland <ic...@chromium.org>]

This one should be much better:
https://plus.google.com/hangouts/_/72cpi1jlelgth9mhjgbg119hds


On Fri, Apr 25, 2014 at 12:02 PM, Michal Mocny <mm...@chromium.org> wrote:

> Sorry, thats the wrong url, correct one coming in a sec.
>
>
> On Fri, Apr 25, 2014 at 12:00 PM, Ian Clelland <ic...@chromium.org>wrote:
>
>>
>> https://staging.talkgadget.google.com/hangouts/_/7ecpi3uaclcuedn7imn6b9jdqc
>>
>>
>> On Fri, Apr 25, 2014 at 11:58 AM, Joe Bowser <bo...@gmail.com> wrote:
>>
>> > Hangout link for this morning?
>> >
>> > On Fri, Apr 25, 2014 at 8:57 AM, Hu, Ningxin <ni...@intel.com>
>> wrote:
>> > >> Are people also going to use older (1-4) versions of Crosswalk? Or is
>> > the
>> > >> plan to encourage people to only use either stable or beta versions?
>> > >
>> > >
>> > >
>> > > Crosswalk follows release cycles similar to Chromium. Current canary
>> is
>> > > Crosswalk-6, beta is 5 and stable is 4. The developers work on canary
>> for
>> > > new features. The public embedding API is a new feature for
>> Crosswalk-6.
>> > If
>> > > we want to release cordova-corsswalk-engine, the Crosswalk-6 would be
>> the
>> > > initial version.
>> > >
>> > >
>> > >
>> > >> That would be good to have -- I'd like to have some kind of warning
>> that
>> > >> new changes in the upstream project break the plugin :)
>> > >
>> > >
>> > >
>> > > +1. So the bot need to build and run mobilespec test suite. Do you
>> know
>> > > whether the bot can drive mobilespec via adb?
>> > >
>> > >
>> > >
>> > > Thanks,
>> > >
>> > > -ningxin
>> > >
>> > >
>> > >
>> > > From: iclelland@google.com [mailto:iclelland@google.com] On Behalf Of
>> > Ian
>> > > Clelland
>> > >
>> > >
>> > > Sent: Thursday, April 24, 2014 11:58 PM
>> > > To: Hu, Ningxin
>> > > Cc: Joe Bowser; dev@cordova.apache.org
>> > > Subject: Re: [Android] Refactoring for different engines
>> > >
>> > >
>> > >
>> > >
>> > >
>> > >
>> > >
>> > > On Thu, Apr 24, 2014 at 5:27 AM, Hu, Ningxin <ni...@intel.com>
>> > wrote:
>> > >
>> > >> Mobilespec runs on my N4, with 10 failing tests: 3 in contacts; 7 in
>> > >> file-transfer. Otherwise, things seem to be working pretty well.
>> > >
>> > >
>> > >
>> > > I checked out the latest code (@691fbce540) and build mbilespec with
>> > > Crosswalk 6.35.127.0. However, it runs on the default Android WebView
>> > due to
>> > > the InvocationTargetException when calling constructors of
>> > > XWalkWebChromeClient and XWalkClient. I fixed it at:
>> > > https://github.com/infil00p/cordova-crosswalk-engine/pull/6.
>> > >
>> > >
>> > >
>> > > This looks good, I've pulled that in locally.
>> > >
>> > >
>> > >
>> > >
>> > >
>> > > To make the plugins work on cordova-crosswalk-engine, it still needs
>> to
>> > set
>> > > correct webview client, chrome client and enable the
>> setNetworkAvailable.
>> > > I've sent another two PRs.
>> > >
>> > > https://github.com/infil00p/cordova-crosswalk-engine/pull/7
>> > >
>> > > https://github.com/infil00p/cordova-android/pull/3
>> > >
>> > >
>> > >
>> > > I think that we could do this differently. I would rather see the
>> > > functionality of CordovaActivity.makeWebViewClient and
>> > > CordovaActivity.makeChromeClient moved into the AndroidWebView class,
>> and
>> > > declared as methods in the CordovaWebView interface. Then we would
>> > override
>> > > them in XWalkCordovaWebView to do the right thing.
>> > >
>> > >
>> > >
>> > > The extra string manipulation magic, and reflection, that this patch
>> > > introduces, seems wrong to me. Considering that we already have
>> methods
>> > in
>> > > XWalkCordovaWebView to construct those objects, then we should let the
>> > > XWalkCordovaWebView construct them.
>> > >
>> > >
>> > >
>> > > (I do like your method of iterating over the constructors, though --
>> I'm
>> > > going to try to use that code in makeWebView as well)
>> > >
>> > >
>> > >
>> > >
>> > >
>> > > After these fixes (and with three fixes in plugins to use
>> > getPluginManager()
>> > > interface), I can run the mobilespec "Run All Tests" on Crosswalk with
>> > all
>> > > passed except Media test. The Media.js seems not be loaded. I didn't
>> have
>> > > chance to debug it yet.
>> > >
>> > >
>> > >
>> > > Ian and Joe, could you please review the PRs? I would appreciate that.
>> > >
>> > >
>> > >
>> > >> I've issued a pull request at
>> > >> https://github.com/infil00p/cordova-crosswalk-engine/pull/5 for it
>> --
>> > I'm
>> > >> not sure if there's a way to keep compatibility with last week's
>> > Crosswalk,
>> > >> or if we'd even want to. (Ningxin, if you could take a look at that
>> PR
>> > and
>> > >> see if it makes sense, I'd appreciate it)
>> > >
>> > >
>> > >
>> > > The PR LGTM! Thanks for the update.
>> > >
>> > >
>> > >
>> > > For crosswalk embedding API compatibility, currently we track the
>> master
>> > > branch of Crosswalk (a.k.a Canary release channel), the embedding API
>> in
>> > > master is still under development. As planned, the Crosswalk-6 will be
>> > > branched for beta in 4th May. In that branch, the embedding API will
>> be
>> > > stable and only accept bug fixing. So for cordova-crosswalk-engine, we
>> > can
>> > > also have crosswalk-6 branch to track beta branch (later stable
>> branch)
>> > and
>> > > using master to track the latest crosswalk.
>> > >
>> > >
>> > >
>> > > Are people also going to use older (1-4) versions of Crosswalk? Or is
>> the
>> > > plan to encourage people to only use either stable or beta versions?
>> > >
>> > >
>> > >
>> > > I am even thinking about we can setup some bots (as buildbots in
>> > crosswalk)
>> > > to track if any patches to crosswalk break the
>> cordova-crosswalk-engine.
>> > >
>> > >
>> > >
>> > > Your thoughts?
>> > >
>> > >
>> > >
>> > > That would be good to have -- I'd like to have some kind of warning
>> that
>> > new
>> > > changes in the upstream project break the plugin :)
>> > >
>> > >
>> > >
>> > >
>> > >
>> > > Thanks,
>> > >
>> > > -ningxin
>> > >
>> > >
>> > >
>> > > From: iclelland@google.com [mailto:iclelland@google.com] On Behalf Of
>> > Ian
>> > > Clelland
>> > > Sent: Thursday, April 24, 2014 1:32 AM
>> > > To: dev@cordova.apache.org
>> > > Cc: Joe Bowser; Hu, Ningxin
>> > >
>> > >
>> > > Subject: Re: [Android] Refactoring for different engines
>> > >
>> > >
>> > >
>> > > I've managed to get this up and running now -- great work on this,
>> Joe!
>> > >
>> > >
>> > >
>> > > Mobilespec runs on my N4, with 10 failing tests: 3 in contacts; 7 in
>> > > file-transfer. Otherwise, things seem to be working pretty well.
>> > >
>> > >
>> > >
>> > > I used a new build of Crosswalk, and found that the embedding API has
>> > > changed since the weekend (when Ningxin's patches applied). I've
>> issued a
>> > > pull request at
>> > https://github.com/infil00p/cordova-crosswalk-engine/pull/5
>> > > for it -- I'm not sure if there's a way to keep compatibility with
>> last
>> > > week's Crosswalk, or if we'd even want to. (Ningxin, if you could
>> take a
>> > > look at that PR and see if it makes sense, I'd appreciate it)
>> > >
>> > >
>> > >
>> > > Joe, I also had to patch the default constructor for
>> > XWalkCordovaWebView; it
>> > > wasn't creating its own client objects, so it got the default ones,
>> and
>> > most
>> > > of the tests were failing because some component of the bridge wan't
>> > > working. https://github.com/infil00p/cordova-crosswalk-engine/pull/4is
>> > out
>> > > for that.
>> > >
>> > >
>> > >
>> > > Count me in for the hangout -- this is exciting stuff
>> > >
>> > >
>> > >
>> > > Ian
>> > >
>> > >
>> > >
>> > > On Wed, Apr 23, 2014 at 10:26 AM, Brian LeRoux <b...@brian.io> wrote:
>> > >
>> > > Yup I'll track em down
>> > >
>> > > On Apr 23, 2014 7:17 AM, "Andrew Grieve" <ag...@chromium.org>
>> wrote:
>> > >
>> > >> Does anyone have a contact at moz that we could invite?
>> > >>
>> > >> On Wed, Apr 23, 2014 at 10:09 AM, Andrew Grieve <
>> agrieve@chromium.org>
>> > >> wrote:
>> > >> > Depends on their interest level I think. Faster we can get this out
>> > >> > the door the better. If we need to delay for geckoview, then I
>> don't
>> > >> > think we should gate on it, just release it after.
>> > >> >
>> > >> > On Wed, Apr 23, 2014 at 3:01 AM, Tommy Williams <
>> tommy@devgeeks.org>
>> > >> wrote:
>> > >> >> More engines, more better...
>> > >> >> On 23 Apr 2014 16:32, "Joe Bowser" <bo...@gmail.com> wrote:
>> > >> >>
>> > >> >>> Hey
>> > >> >>>
>> > >> >>> A Hangout would have to happen on Friday at the earliest.  It'd
>> be
>> > >> good if
>> > >> >>> we could get someone from Mozilla on the hangout as well.  I
>> haven't
>> > >> gotten
>> > >> >>> MozillaView (GeckoView with Cordova methods) fully working yet.
>>  For
>> > >> some
>> > >> >>> reason it's not rendering on the screen.
>> > >> >>>
>> > >> >>> Ideally it'd be cool to have at least two options when this
>> feature
>> > >> finally
>> > >> >>> lands.
>> > >> >>>
>> > >> >>> What do other people think?
>> > >> >>>
>> > >> >>> Joe
>> > >> >>> On 22 Apr 2014 20:06, "Hu, Ningxin" <ni...@intel.com>
>> wrote:
>> > >> >>>
>> > >> >>> > Joe,
>> > >> >>> >
>> > >> >>> > Thanks for your review and merge the PRs.
>> > >> >>> >
>> > >> >>> > To pluggable webview interest group:
>> > >> >>> > Are we OK to setup a hangout this week for initial introduction
>> > and
>> > >> >>> > discussion of next steps?
>> > >> >>> >
>> > >> >>> > Thanks,
>> > >> >>> > -ningxin
>> > >> >>> >
>> > >> >>> > > -----Original Message-----
>> > >> >>> > > From: Hu, Ningxin [mailto:ningxin.hu@intel.com]
>> > >> >>> > > Sent: Tuesday, April 22, 2014 4:04 PM
>> > >> >>> > > To: dev@cordova.apache.org
>> > >> >>> > > Subject: RE: [Android] Refactoring for different engines
>> > >> >>> > >
>> > >> >>> > > The PoC is great! Quite excited about the direction!
>> > >> >>> > >
>> > >> >>> > > I've sent a PR to update the cordova-crosswalk-engine to
>> latest
>> > >> >>> crosswalk
>> > >> >>> > > embedding API. It works with xwalk_core_library at
>> 6.35.124.0.
>> > >> >>> > >
>> > >> >>> > > I've also changed the CordovaWebView interface slightly
>> (adding
>> > >> >>> > getView() API)
>> > >> >>> > > to allow XWalkCordovaWebView to composite a XWalkView
>> instead of
>> > >> >>> > extending
>> > >> >>> > > it. It resolves some API naming issues for XWalkView case.
>> > >> >>> > >
>> > >> >>> > > Please review them at:
>> > >> >>> > > https://github.com/infil00p/cordova-crosswalk-engine/pull/3
>> > >> >>> > > https://github.com/infil00p/cordova-android/pull/2
>> > >> >>> > >
>> > >> >>> > > Thanks,
>> > >> >>> > > -ningxin
>> > >> >>> > >
>> > >> >>> > > > -----Original Message-----
>> > >> >>> > > > From: Joe Bowser [mailto:bowserj@gmail.com]
>> > >> >>> > > > Sent: Friday, April 11, 2014 12:45 AM
>> > >> >>> > > > To: dev
>> > >> >>> > > > Subject: Re: [Android] Refactoring for different engines
>> > >> >>> > > >
>> > >> >>> > > > Yeah, I'd be cool with setting up a hangout.  Everyone
>> should
>> > >> take a
>> > >> >>> > > > look at the PoC, I've basically distilled it down to four
>> or
>> > >> >>> > > > five
>> > >> >>> > > > classes so far, but with some work, we may be able to get
>> it
>> > >> down to
>> > >> >>> > > > three.  Due to legacy, we're pretty stuck with the Android
>> > >> WebView
>> > >> >>> API
>> > >> >>> > calls,
>> > >> >>> > > but these can probably be modified.
>> > >> >>> > > >
>> > >> >>> > > > It'd be good to get Mozilla people on the call as well,
>> since
>> > >> they
>> > >> >>> > > > have their WebView as well.
>> > >> >>> > > >
>> > >> >>> > > > On Thu, Apr 10, 2014 at 9:38 AM, Hu, Ningxin <
>> > >> ningxin.hu@intel.com>
>> > >> >>> > wrote:
>> > >> >>> > > > > Hangout would be a good idea.
>> > >> >>> > > > >
>> > >> >>> > > > > FYI, I will be off next week. How about the week after
>> next?
>> > >> If it
>> > >> >>> > > > > works, please
>> > >> >>> > > > feel free to schedule one and count me in.
>> > >> >>> > > > >
>> > >> >>> > > > > Thanks,
>> > >> >>> > > > > -ningxin
>> > >> >>> > > > >
>> > >> >>> > > > >> -----Original Message-----
>> > >> >>> > > > >> From: mmocny@google.com [mailto:mmocny@google.com] On
>> > Behalf
>> > >> Of
>> > >> >>> > > > >> Michal Mocny
>> > >> >>> > > > >> Sent: Tuesday, April 08, 2014 11:39 PM
>> > >> >>> > > > >> To: dev
>> > >> >>> > > > >> Subject: Re: [Android] Refactoring for different engines
>> > >> >>> > > > >>
>> > >> >>> > > > >> Would it be alright to set up a Hangout some time to
>> > >> >>> > > > >> introduce
>> > >> >>> > everyone?
>> > >> >>> > > > >>
>> > >> >>> > > > >> Joe has been leading the effort here, but there are
>> other
>> > >> cordova
>> > >> >>> > > > >> contributors for whom this is top priority.  It would be
>> > nice
>> > >> if
>> > >> >>> we
>> > >> >>> > > > >> could all meet to say hello and make sure we are all
>> going
>> > in
>> > >> the
>> > >> >>> > > > >> right
>> > >> >>> > > > direction.
>> > >> >>> > > > >>
>> > >> >>> > > > >> Quite exciting!
>> > >> >>> > > > >>
>> > >> >>> > > > >> -Michal
>> > >> >>> > > > >>
>> > >> >>> > > > >>
>> > >> >>> > > > >> On Tue, Apr 8, 2014 at 10:56 AM, Hu, Ningxin <
>> > >> >>> ningxin.hu@intel.com>
>> > >> >>> > > wrote:
>> > >> >>> > > > >>
>> > >> >>> > > > >> > Joe, thanks for this. I am very excited.
>> > >> >>> > > > >> >
>> > >> >>> > > > >> > FYI. Crosswalk team is working on refactoring the
>> WebView
>> > >> API to
>> > >> >>> > > > >> > support embedding usage better [1]. (Previously the
>> layer
>> > >> API
>> > >> >>> was
>> > >> >>> > > > >> > not exposed as public usage).
>> > >> >>> > > > >> >
>> > >> >>> > > > >> > I would like to review the PoC and work with you to
>> get
>> > >> >>> Crosswalk
>> > >> >>> > > > >> > fits into the pluggable WebView architecture.
>> > >> >>> > > > >> >
>> > >> >>> > > > >> > Thanks,
>> > >> >>> > > > >> > -ningxin
>> > >> >>> > > > >> >
>> > >> >>> > > > >> > > -----Original Message-----
>> > >> >>> > > > >> > > From: Joe Bowser [mailto:bowserj@gmail.com]
>> > >> >>> > > > >> > > Sent: Wednesday, March 19, 2014 7:08 AM
>> > >> >>> > > > >> > > To: dev
>> > >> >>> > > > >> > > Subject: Re: [Android] Refactoring for different
>> > engines
>> > >> >>> > > > >> > >
>> > >> >>> > > > >> > > Hey
>> > >> >>> > > > >> > >
>> > >> >>> > > > >> > > After debugging, I did some minor updates to the
>> plugin
>> > >> >>> README.
>> > >> >>> > > > >> > > It
>> > >> >>> > > > >> > should be
>> > >> >>> > > > >> > > easier to get this up and running, although there's
>> > still
>> > >> the
>> > >> >>> > > > >> > > issue of
>> > >> >>> > > > >> > after-install
>> > >> >>> > > > >> > > hooks and the relative path weirdness with the
>> > Crosswalk
>> > >> >>> > Library itself.
>> > >> >>> > > > >> > >
>> > >> >>> > > > >> > > It still doesn't support the CLI at all, but it
>> should
>> > be
>> > >> >>> there
>> > >> >>> > > > >> > > with the
>> > >> >>> > > > >> > old flow.
>> > >> >>> > > > >> > >
>> > >> >>> > > > >> > > On Mon, Mar 17, 2014 at 1:14 PM, Michal Mocny
>> > >> >>> > > > >> > > <mm...@chromium.org>
>> > >> >>> > > > >> > > wrote:
>> > >> >>> > > > >> > > > (Sorry Joe, Googlers are down in California and
>> way
>> > >> busy.
>> > >> >>> > > > >> > > > Will be back in a week.  Super excited about this,
>> > >> though.)
>> > >> >>> > > > >> > > >
>> > >> >>> > > > >> > > > -Michal
>> > >> >>> > > > >> > > >
>> > >> >>> > > > >> > > >
>> > >> >>> > > > >> > > > On Mon, Mar 17, 2014 at 2:53 PM, Joe Bowser
>> > >> >>> > > > >> > > > <bo...@gmail.com>
>> > >> >>> > > > >> wrote:
>> > >> >>> > > > >> > > >
>> > >> >>> > > > >> > > >> Reviving this thread!
>> > >> >>> > > > >> > > >>
>> > >> >>> > > > >> > > >> Can other people look at this, and see if/when we
>> > >> should
>> > >> >>> > land this?
>> > >> >>> > > > >> > > >> I know that I have to re-write the tests still,
>> but
>> > I
>> > >> would
>> > >> >>> > > > >> > > >> like some feedback before merging it in.  Also,
>> it'd
>> > >> >>> > > > >> > > >> be
>> > >> >>> > > > >> > > >> super awesome if other people could try and make
>> a
>> > >> WebView
>> > >> >>> > > > >> > > >> based on the interfaces and recommend which
>> methods
>> > >> should
>> > >> >>> > > > >> > > >> die.  I want to get this released in the next
>> month
>> > or
>> > >> so,
>> > >> >>> > > > >> > > >> so any time and feedback would be greatly
>> > appreciated.
>> > >> >>> > > > >> > > >>
>> > >> >>> > > > >> > > >> Thanks
>> > >> >>> > > > >> > > >>
>> > >> >>> > > > >> > > >> On Thu, Mar 13, 2014 at 3:50 PM, Joe Bowser
>> > >> >>> > > > >> > > >> <bo...@gmail.com>
>> > >> >>> > > > >> > wrote:
>> > >> >>> > > > >> > > >> > Hey, I created the following today to track
>> > various
>> > >> >>> > > > >> > > >> > WebView
>> > >> >>> > > > >> > progresses:
>> > >> >>> > > > >> > > >> > https://issues.apache.org/jira/browse/CB-6246
>> > >> >>> > > > >> > > >> >
>> > >> >>> > > > >> > > >> > I also have this repo created.  The licensing
>> is
>> > >> ugly as
>> > >> >>> > > > >> > > >> > all crap, but it's a Proof-Of-Concept:
>> > >> >>> > > > >> > > >> >
>> > https://github.com/infil00p/cordova-crosswalk-engine
>> > >> >>> > > > >> > > >> >
>> > >> >>> > > > >> > > >> > If I can get some help getting plugman to just
>> > load
>> > >> >>> > > > >> > > >> > Crosswalk, it'll
>> > >> >>> > > > >> > > >> look hawt.
>> > >> >>> > > > >> > > >> >
>> > >> >>> > > > >> > > >> > BTW: We should probably get this ready to go
>> into
>> > >> Android
>> > >> >>> > > > >> > > >> > in the next two months and deprecate the
>> > setProperty
>> > >> >>> > > > >> > > >> > methods, since all properties should be
>> > preferences
>> > >> in
>> > >> >>> > config.xml
>> > >> >>> > > now.
>> > >> >>> > > > >> > > >> >
>> > >> >>> > > > >> > > >> > On Mon, Mar 10, 2014 at 2:42 PM, Joe Bowser
>> > >> >>> > > > >> > > >> > <bo...@gmail.com>
>> > >> >>> > > > >> > > wrote:
>> > >> >>> > > > >> > > >> >> Perhaps. There would be additional benefits to
>> > this
>> > >> >>> > > > >> > > >> >> approach, namely fixes being added to that
>> > platform
>> > >> more
>> > >> >>> > > > >> > > >> >> quickly.  I'll probably take a look at that
>> once
>> > I
>> > >> have
>> > >> >>> > > > >> > > >> >> Crosswalk
>> > >> >>> > > > finalized.
>> > >> >>> > > > >> > > >> >>
>> > >> >>> > > > >> > > >> >> On Mon, Mar 10, 2014 at 9:49 AM, Brian LeRoux
>> > >> >>> > > > >> > > >> >> <b...@brian.io>
>> > >> >>> > > > wrote:
>> > >> >>> > > > >> > > >> >>> this is great stuff
>> > >> >>> > > > >> > > >> >>>
>> > >> >>> > > > >> > > >> >>> do we think it may be possible to bring in
>> > amazon
>> > >> >>> fireos
>> > >> >>> > > > >> > > >> >>> stuff
>> > >> >>> > > > >> > > >> eventually
>> > >> >>> > > > >> > > >> >>> too?
>> > >> >>> > > > >> > > >> >>>
>> > >> >>> > > > >> > > >> >>>
>> > >> >>> > > > >> > > >> >>> On Fri, Mar 7, 2014 at 3:22 PM, Joe Bowser
>> > >> >>> > > > >> > > >> >>> <bo...@gmail.com>
>> > >> >>> > > > >> > wrote:
>> > >> >>> > > > >> > > >> >>>
>> > >> >>> > > > >> > > >> >>>> BTW: I committed it in my repo, not the main
>> > >> Apache
>> > >> >>> one.
>> > >> >>> > > > >> > > >> >>>>
>> > >> >>> > > > >> > > >> >>>> On Fri, Mar 7, 2014 at 3:21 PM, Joe Bowser
>> > >> >>> > > > >> > > >> >>>> <bo...@gmail.com>
>> > >> >>> > > > >> > > wrote:
>> > >> >>> > > > >> > > >> >>>> > Hey
>> > >> >>> > > > >> > > >> >>>> >
>> > >> >>> > > > >> > > >> >>>> > I just committed some code based on their
>> > >> WebView
>> > >> >>> > > > >> > > >> >>>> > modifications that allows you to choose
>> your
>> > >> >>> renderer
>> > >> >>> > > > >> > > >> >>>> > in the
>> > >> >>> > > > >> > config file
>> > >> >>> > > > >> > > with this:
>> > >> >>> > > > >> > > >> >>>> >
>> > >> >>> > > > >> > > >> >>>> >     <preference name="webView"
>> > >> >>> > > > >> > > >> >>>> >
>> > >> >>> value="org.apache.cordova.engine.crosswalk.XWalkCordo
>> > >> >>> > > > >> > > >> >>>> > va
>> > >> >>> > > > >> > > >> >>>> > Web
>> > >> >>> > > > >> > > >> >>>> > View
>> > >> >>> > > > >> > > >> >>>> > " />
>> > >> >>> > > > >> > > >> >>>> >
>> > >> >>> > > > >> > > >> >>>> > You currently have to copy over the *.pak
>> > file
>> > >> and
>> > >> >>> > > > >> > > >> >>>> > the jsapi from a Crosswalk Example
>> project to
>> > >> get
>> > >> >>> > > > >> > > >> >>>> > this to work.  The next thing that I'm
>> going
>> > to
>> > >> do
>> > >> >>> is
>> > >> >>> > > > >> > > >> >>>> > figure out how to write this as a plugin
>> and
>> > >> have it
>> > >> >>> > > > >> > > >> >>>> > install on a default
>> > >> >>> > > > project.
>> > >> >>> > > > >> > > >> >>>> > Also, right now the bridge doesn't seem to
>> > >> work, and
>> > >> >>> > > > >> > > >> >>>> > I don't know why exactly.  That being
>> said,
>> > the
>> > >> >>> > > > >> > > >> fact
>> > >> >>> > > > >> > > >> >>>> > that I can choose which version of
>> > >> Chrome/Chromium
>> > >> >>> > > > >> > > >> >>>> > I'm running with
>> > >> >>> > > > >> > > >> a
>> > >> >>> > > > >> > > >> >>>> > single XML preference is HUGE.
>> > >> >>> > > > >> > > >> >>>> >
>> > >> >>> > > > >> > > >> >>>> > There's definitely a lot more work that
>> needs
>> > >> to be
>> > >> >>> > > > >> > > >> >>>> > done, but as
>> > >> >>> > > > >> > > >> long
>> > >> >>> > > > >> > > >> >>>> > as we have something that we can fit into
>> the
>> > >> >>> > > > >> > > >> >>>> > interface, we should
>> > >> >>> > > > >> > > >> be
>> > >> >>> > > > >> > > >> >>>> > able to put in things like GeckoView or
>> other
>> > >> third
>> > >> >>> > > > >> > > >> >>>> > party
>> > >> >>> > > > >> > renderers.
>> > >> >>> > > > >> > > >> >>>> > The nightmare of being stuck with bullshit
>> > >> WebView
>> > >> >>> > > > >> > > >> >>>> > bugs may soon be over.
>> > >> >>> > > > >> > > >> >>>> >
>> > >> >>> > > > >> > > >> >>>> > On Wed, Mar 5, 2014 at 8:59 PM, Michal
>> Mocny
>> > >> >>> > > > >> > > >> >>>> > <mm...@chromium.org>
>> > >> >>> > > > >> > > >> >>>> wrote:
>> > >> >>> > > > >> > > >> >>>> >>
>> > >> >>> https://github.com/crosswalk-project/crosswalk-cordo
>> > >> >>> > > > >> > > >> >>>> >> va
>> > >> >>> > > > >> > > >> >>>> >> -an
>> > >> >>> > > > >> > > >> >>>> >> droi
>> > >> >>> > > > >> > > >> >>>> >> d
>> > >> >>> > > > >> > > >> >>>> >>
>> > >> >>> > > > >> > > >> >>>> >> First patch they landed, which claims to
>> > have
>> > >> min
>> > >> >>> > > > >> > > >> >>>> >> viable xwalk
>> > >> >>> > > > >> > > >> webview:
>> > >> >>> > > > >> > > >> >>>> >>
>> > >> >>> > > > >> > > >> >>>>
>> > >> >>> > > > >> > > >>
>> > >> >>> https://github.com/crosswalk-project/crosswalk-cordova-andro
>> > >> >>> > > > >> > > >> id
>> > >> >>> > > > >> > > >> /co
>> > >> >>> > > > >> > > >> mmit
>> > >> >>> > > > >> > > >> /a04dedeb0204e7542d190312c6ae70c795a26e04
>> > >> >>> > > > >> > > >> >>>> >>
>> > >> >>> > > > >> > > >> >>>> >>
>> > >> >>> > > > >> > > >> >>>> >> On Wed, Mar 5, 2014 at 11:37 PM, Michal
>> > Mocny
>> > >> >>> > > > >> > > >> >>>> >> <mmocny@chromium.org
>> > >> >>> > > > >> > > >> >
>> > >> >>> > > > >> > > >> >>>> wrote:
>> > >> >>> > > > >> > > >> >>>> >>
>> > >> >>> > > > >> > > >> >>>> >>> I haven't looked yet, but did you see:
>> > >> >>> > > > >> > > >> >>>> >>>
>> > >> >>> https://crosswalk-project.org/#wiki/crosswalk-cordo
>> > >> >>> > > > >> > > >> >>>> >>> va
>> > >> >>> > > > >> > > >> >>>> >>> -an
>> > >> >>> > > > >> > > >> >>>> >>> droi
>> > >> >>> > > > >> > > >> >>>> >>> d
>> > >> >>> > > > >> > > >> >>>> >>>
>> > >> >>> > > > >> > > >> >>>> >>> ?
>> > >> >>> > > > >> > > >> >>>> >>>
>> > >> >>> > > > >> > > >> >>>> >>>
>> > >> >>> > > > >> > > >> >>>> >>> On Wed, Mar 5, 2014 at 10:20 PM, Andrew
>> > >> Grieve <
>> > >> >>> > > > >> > > >> agrieve@chromium.org
>> > >> >>> > > > >> > > >> >>>> >wrote:
>> > >> >>> > > > >> > > >> >>>> >>>
>> > >> >>> > > > >> > > >> >>>> >>>> First - very excited that you're
>> working
>> > on
>> > >> this!
>> > >> >>> > > > >> > > >> >>>> >>>>
>> > >> >>> > > > >> > > >> >>>> >>>> Had a quick look. Not sure there's
>> much to
>> > >> >>> > > > >> > > >> >>>> >>>> be
>> > >> >>> > gleaned
>> > >> >>> > > yet.
>> > >> >>> > > > >> > > >> >>>> >>>> Once
>> > >> >>> > > > >> > > >> you
>> > >> >>> > > > >> > > >> >>>> start
>> > >> >>> > > > >> > > >> >>>> >>>> in on hooking up x-walk's webview I
>> think
>> > it
>> > >> will
>> > >> >>> > > > >> > > >> >>>> >>>> become more
>> > >> >>> > > > >> > > >> obvious
>> > >> >>> > > > >> > > >> >>>> what
>> > >> >>> > > > >> > > >> >>>> >>>> the interface should look like. E.g.,
>> does
>> > >> x-walk
>> > >> >>> > > > >> > > >> >>>> >>>> even have the
>> > >> >>> > > > >> > > >> >>>> concept of
>> > >> >>> > > > >> > > >> >>>> >>>> ChromeClient vs WebViewClient vs
>> WebView?
>> > >> Also
>> > >> >>> > > > >> > > >> >>>> >>>> unsure whether the
>> > >> >>> > > > >> > > >> >>>> class
>> > >> >>> > > > >> > > >> >>>> >>>> should extend android.View as well as
>> > >> implement
>> > >> >>> > > > >> > > >> >>>> >>>> our
>> > >> >>> > > > >> > interface.
>> > >> >>> > > > >> > > >> E.g.
>> > >> >>> > > > >> > > >> >>>> >>>> alternative is to have a "getView()"
>> > method
>> > >> on
>> > >> >>> the
>> > >> >>> > > > >> > interface.
>> > >> >>> > > > >> > > >> Might
>> > >> >>> > > > >> > > >> >>>> help
>> > >> >>> > > > >> > > >> >>>> >>>> to
>> > >> >>> > > > >> > > >> >>>> >>>> cut down on file sizes, and API
>> surface,
>> > but
>> > >> >>> > > > >> > > >> >>>> >>>> again, I'm not too
>> > >> >>> > > > >> > > >> sure.
>> > >> >>> > > > >> > > >> >>>> >>>>
>> > >> >>> > > > >> > > >> >>>> >>>> I've been pretty hesitant to touch
>> > existing
>> > >> >>> > > > >> > > >> >>>> >>>> exposed members
>> > >> >>> > > > >> > > >> (e.g. the
>> > >> >>> > > > >> > > >> >>>> >>>> public fields you were referring to)
>> since
>> > >> >>> > > > >> > > >> >>>> >>>> touching anything
>> > >> >>> > > > >> > > >> public
>> > >> >>> > > > >> > > >> >>>> could
>> > >> >>> > > > >> > > >> >>>> >>>> break plugins. That said, maybe now is
>> a
>> > >> >>> > > > >> > > >> >>>> >>>> good
>> > >> >>> time
>> > >> >>> > > > >> > > >> >>>> >>>> to @deprecate
>> > >> >>> > > > >> > > >> a
>> > >> >>> > > > >> > > >> >>>> bunch
>> > >> >>> > > > >> > > >> >>>> >>>> of
>> > >> >>> > > > >> > > >> >>>> >>>> them and either replace them with
>> getters,
>> > >> >>> > > > >> > > >> >>>> >>>> or
>> > >> >>> just
>> > >> >>> > > > >> > > >> >>>> >>>> declare them
>> > >> >>> > > > >> > > >> to be
>> > >> >>> > > > >> > > >> >>>> not
>> > >> >>> > > > >> > > >> >>>> >>>> exposed to plugins.
>> > >> >>> > > > >> > > >> >>>> >>>>
>> > >> >>> > > > >> > > >> >>>> >>>>
>> > >> >>> > > > >> > > >> >>>> >>>> On Wed, Mar 5, 2014 at 6:57 PM, Joe
>> Bowser
>> > >> >>> > > > >> > > >> >>>> >>>> <bo...@gmail.com>
>> > >> >>> > > > >> > > >> wrote:
>> > >> >>> > > > >> > > >> >>>> >>>>
>> > >> >>> > > > >> > > >> >>>> >>>> > So, after looking at the Crosswalk
>> code
>> > >> again,
>> > >> >>> > > > >> > > >> >>>> >>>> > I've decided to
>> > >> >>> > > > >> > > >> take
>> > >> >>> > > > >> > > >> >>>> a
>> > >> >>> > > > >> > > >> >>>> >>>> > quick stab at making things
>> pluggable.
>> >  I
>> > >> don't
>> > >> >>> > > > >> > > >> >>>> >>>> > have a lot to
>> > >> >>> > > > >> > > >> show
>> > >> >>> > > > >> > > >> >>>> for
>> > >> >>> > > > >> > > >> >>>> >>>> > it, but with the help of Eclipse
>> (which
>> > is
>> > >> why
>> > >> >>> > > > >> > > >> >>>> >>>> > the generated interfaces look so
>> screwed
>> > >> up), I
>> > >> >>> > > > >> > > >> >>>> >>>> > managed to create some
>> > >> >>> > > > >> > > >> interfaces
>> > >> >>> > > > >> > > >> >>>> so
>> > >> >>> > > > >> > > >> >>>> >>>> > we can start shoehorning in other
>> > browser
>> > >> >>> > renderers.
>> > >> >>> > > > >> > > >> >>>> >>>> >
>> > >> >>> > > > >> > > >> >>>> >>>> >
>> > >> >>> > > > >> > > >>
>> > >> >>> https://github.com/infil00p/cordova-android/tree/pluggable_w
>> > >> >>> > > > >> > > >> eb
>> > >> >>> > > > >> > > >> vie
>> > >> >>> > > > >> > > >> w
>> > >> >>> > > > >> > > >> >>>> >>>> >
>> > >> >>> > > > >> > > >> >>>> >>>> > I'm going to probably start with
>> > >> >>> > > > >> > > >> >>>> >>>> > Crosswalk,
>> > >> >>> > > > >> > > >> >>>> >>>> > because it's
>> > >> >>> > > > >> > > >> probably
>> > >> >>> > > > >> > > >> >>>> the
>> > >> >>> > > > >> > > >> >>>> >>>> > most mature primary candidate in the
>> > >> Android
>> > >> >>> > > > >> > > >> >>>> >>>> > Third-Party
>> > >> >>> > > > >> > > >> WebView
>> > >> >>> > > > >> > > >> >>>> >>>> > thing, and I'm pretty sure the
>> GeckoView
>> > >> will
>> > >> >>> be
>> > >> >>> > > > >> > > >> >>>> >>>> > happening
>> > >> >>> > > > >> > > >> shortly
>> > >> >>> > > > >> > > >> >>>> >>>> > after.
>> > >> >>> > > > >> > > >> >>>> >>>> >
>> > >> >>> > > > >> > > >> >>>> >>>> > I don't know how this would work
>> w.r.t.
>> > >> the CLI
>> > >> >>> > > > >> > > >> >>>> >>>> > or our
>> > >> >>> > > > >> > > >> workflow at
>> > >> >>> > > > >> > > >> >>>> >>>> > all, but at the moment, I really just
>> > want
>> > >> to
>> > >> >>> at
>> > >> >>> > > > >> > > >> >>>> >>>> > least start
>> > >> >>> > > > >> > > >> to have
>> > >> >>> > > > >> > > >> >>>> >>>> > some headway towards 4.x and PhoneGap
>> > day.
>> > >> >>> > > > >> > > >> >>>> >>>> >
>> > >> >>> > > > >> > > >> >>>> >>>> > What do people think of this so far?
>> I'm
>> > >> going
>> > >> >>> > > > >> > > >> >>>> >>>> > to try to clean
>> > >> >>> > > > >> > > >> >>>> things
>> > >> >>> > > > >> > > >> >>>> >>>> > up a bit, since we've definitely
>> done a
>> > >> lot of
>> > >> >>> > > > >> > > >> >>>> >>>> > things that
>> > >> >>> > > > >> > > >> would
>> > >> >>> > > > >> > > >> >>>> make
>> > >> >>> > > > >> > > >> >>>> >>>> > first year CS profs freak the hell
>> out
>> > >> (i.e.
>> > >> >>> > > > >> > > >> >>>> >>>> > public members in
>> > >> >>> > > > >> > > >> >>>> public
>> > >> >>> > > > >> > > >> >>>> >>>> > objects w.r.t. PluginManager).
>> > >> >>> > > > >> > > >> >>>> >>>> >
>> > >> >>> > > > >> > > >> >>>> >>>> > Thoughts?
>> > >> >>> > > > >> > > >> >>>> >>>> >
>> > >> >>> > > > >> > > >> >>>> >>>> > Joe
>> > >> >>> > > > >> > > >> >>>> >>>> >
>> > >> >>> > > > >> > > >> >>>> >>>>
>> > >> >>> > > > >> > > >> >>>> >>>
>> > >> >>> > > > >> > > >> >>>> >>>
>> > >> >>> > > > >> > > >> >>>>
>> > >> >>> > > > >> > > >>
>> > >> >>> > > > >> >
>> > >> >>> >
>> > >> >>>
>> > >>
>> > >
>> > >
>> > >
>> > >
>> >
>>
>
>

Re: [Android] Refactoring for different engines

[Michal Mocny <mm...@chromium.org>]

Sorry, thats the wrong url, correct one coming in a sec.


On Fri, Apr 25, 2014 at 12:00 PM, Ian Clelland <ic...@chromium.org>wrote:

> https://staging.talkgadget.google.com/hangouts/_/7ecpi3uaclcuedn7imn6b9jdqc
>
>
> On Fri, Apr 25, 2014 at 11:58 AM, Joe Bowser <bo...@gmail.com> wrote:
>
> > Hangout link for this morning?
> >
> > On Fri, Apr 25, 2014 at 8:57 AM, Hu, Ningxin <ni...@intel.com>
> wrote:
> > >> Are people also going to use older (1-4) versions of Crosswalk? Or is
> > the
> > >> plan to encourage people to only use either stable or beta versions?
> > >
> > >
> > >
> > > Crosswalk follows release cycles similar to Chromium. Current canary is
> > > Crosswalk-6, beta is 5 and stable is 4. The developers work on canary
> for
> > > new features. The public embedding API is a new feature for
> Crosswalk-6.
> > If
> > > we want to release cordova-corsswalk-engine, the Crosswalk-6 would be
> the
> > > initial version.
> > >
> > >
> > >
> > >> That would be good to have -- I'd like to have some kind of warning
> that
> > >> new changes in the upstream project break the plugin :)
> > >
> > >
> > >
> > > +1. So the bot need to build and run mobilespec test suite. Do you know
> > > whether the bot can drive mobilespec via adb?
> > >
> > >
> > >
> > > Thanks,
> > >
> > > -ningxin
> > >
> > >
> > >
> > > From: iclelland@google.com [mailto:iclelland@google.com] On Behalf Of
> > Ian
> > > Clelland
> > >
> > >
> > > Sent: Thursday, April 24, 2014 11:58 PM
> > > To: Hu, Ningxin
> > > Cc: Joe Bowser; dev@cordova.apache.org
> > > Subject: Re: [Android] Refactoring for different engines
> > >
> > >
> > >
> > >
> > >
> > >
> > >
> > > On Thu, Apr 24, 2014 at 5:27 AM, Hu, Ningxin <ni...@intel.com>
> > wrote:
> > >
> > >> Mobilespec runs on my N4, with 10 failing tests: 3 in contacts; 7 in
> > >> file-transfer. Otherwise, things seem to be working pretty well.
> > >
> > >
> > >
> > > I checked out the latest code (@691fbce540) and build mbilespec with
> > > Crosswalk 6.35.127.0. However, it runs on the default Android WebView
> > due to
> > > the InvocationTargetException when calling constructors of
> > > XWalkWebChromeClient and XWalkClient. I fixed it at:
> > > https://github.com/infil00p/cordova-crosswalk-engine/pull/6.
> > >
> > >
> > >
> > > This looks good, I've pulled that in locally.
> > >
> > >
> > >
> > >
> > >
> > > To make the plugins work on cordova-crosswalk-engine, it still needs to
> > set
> > > correct webview client, chrome client and enable the
> setNetworkAvailable.
> > > I've sent another two PRs.
> > >
> > > https://github.com/infil00p/cordova-crosswalk-engine/pull/7
> > >
> > > https://github.com/infil00p/cordova-android/pull/3
> > >
> > >
> > >
> > > I think that we could do this differently. I would rather see the
> > > functionality of CordovaActivity.makeWebViewClient and
> > > CordovaActivity.makeChromeClient moved into the AndroidWebView class,
> and
> > > declared as methods in the CordovaWebView interface. Then we would
> > override
> > > them in XWalkCordovaWebView to do the right thing.
> > >
> > >
> > >
> > > The extra string manipulation magic, and reflection, that this patch
> > > introduces, seems wrong to me. Considering that we already have methods
> > in
> > > XWalkCordovaWebView to construct those objects, then we should let the
> > > XWalkCordovaWebView construct them.
> > >
> > >
> > >
> > > (I do like your method of iterating over the constructors, though --
> I'm
> > > going to try to use that code in makeWebView as well)
> > >
> > >
> > >
> > >
> > >
> > > After these fixes (and with three fixes in plugins to use
> > getPluginManager()
> > > interface), I can run the mobilespec "Run All Tests" on Crosswalk with
> > all
> > > passed except Media test. The Media.js seems not be loaded. I didn't
> have
> > > chance to debug it yet.
> > >
> > >
> > >
> > > Ian and Joe, could you please review the PRs? I would appreciate that.
> > >
> > >
> > >
> > >> I've issued a pull request at
> > >> https://github.com/infil00p/cordova-crosswalk-engine/pull/5 for it --
> > I'm
> > >> not sure if there's a way to keep compatibility with last week's
> > Crosswalk,
> > >> or if we'd even want to. (Ningxin, if you could take a look at that PR
> > and
> > >> see if it makes sense, I'd appreciate it)
> > >
> > >
> > >
> > > The PR LGTM! Thanks for the update.
> > >
> > >
> > >
> > > For crosswalk embedding API compatibility, currently we track the
> master
> > > branch of Crosswalk (a.k.a Canary release channel), the embedding API
> in
> > > master is still under development. As planned, the Crosswalk-6 will be
> > > branched for beta in 4th May. In that branch, the embedding API will be
> > > stable and only accept bug fixing. So for cordova-crosswalk-engine, we
> > can
> > > also have crosswalk-6 branch to track beta branch (later stable branch)
> > and
> > > using master to track the latest crosswalk.
> > >
> > >
> > >
> > > Are people also going to use older (1-4) versions of Crosswalk? Or is
> the
> > > plan to encourage people to only use either stable or beta versions?
> > >
> > >
> > >
> > > I am even thinking about we can setup some bots (as buildbots in
> > crosswalk)
> > > to track if any patches to crosswalk break the
> cordova-crosswalk-engine.
> > >
> > >
> > >
> > > Your thoughts?
> > >
> > >
> > >
> > > That would be good to have -- I'd like to have some kind of warning
> that
> > new
> > > changes in the upstream project break the plugin :)
> > >
> > >
> > >
> > >
> > >
> > > Thanks,
> > >
> > > -ningxin
> > >
> > >
> > >
> > > From: iclelland@google.com [mailto:iclelland@google.com] On Behalf Of
> > Ian
> > > Clelland
> > > Sent: Thursday, April 24, 2014 1:32 AM
> > > To: dev@cordova.apache.org
> > > Cc: Joe Bowser; Hu, Ningxin
> > >
> > >
> > > Subject: Re: [Android] Refactoring for different engines
> > >
> > >
> > >
> > > I've managed to get this up and running now -- great work on this, Joe!
> > >
> > >
> > >
> > > Mobilespec runs on my N4, with 10 failing tests: 3 in contacts; 7 in
> > > file-transfer. Otherwise, things seem to be working pretty well.
> > >
> > >
> > >
> > > I used a new build of Crosswalk, and found that the embedding API has
> > > changed since the weekend (when Ningxin's patches applied). I've
> issued a
> > > pull request at
> > https://github.com/infil00p/cordova-crosswalk-engine/pull/5
> > > for it -- I'm not sure if there's a way to keep compatibility with last
> > > week's Crosswalk, or if we'd even want to. (Ningxin, if you could take
> a
> > > look at that PR and see if it makes sense, I'd appreciate it)
> > >
> > >
> > >
> > > Joe, I also had to patch the default constructor for
> > XWalkCordovaWebView; it
> > > wasn't creating its own client objects, so it got the default ones, and
> > most
> > > of the tests were failing because some component of the bridge wan't
> > > working. https://github.com/infil00p/cordova-crosswalk-engine/pull/4is
> > out
> > > for that.
> > >
> > >
> > >
> > > Count me in for the hangout -- this is exciting stuff
> > >
> > >
> > >
> > > Ian
> > >
> > >
> > >
> > > On Wed, Apr 23, 2014 at 10:26 AM, Brian LeRoux <b...@brian.io> wrote:
> > >
> > > Yup I'll track em down
> > >
> > > On Apr 23, 2014 7:17 AM, "Andrew Grieve" <ag...@chromium.org> wrote:
> > >
> > >> Does anyone have a contact at moz that we could invite?
> > >>
> > >> On Wed, Apr 23, 2014 at 10:09 AM, Andrew Grieve <agrieve@chromium.org
> >
> > >> wrote:
> > >> > Depends on their interest level I think. Faster we can get this out
> > >> > the door the better. If we need to delay for geckoview, then I don't
> > >> > think we should gate on it, just release it after.
> > >> >
> > >> > On Wed, Apr 23, 2014 at 3:01 AM, Tommy Williams <tommy@devgeeks.org
> >
> > >> wrote:
> > >> >> More engines, more better...
> > >> >> On 23 Apr 2014 16:32, "Joe Bowser" <bo...@gmail.com> wrote:
> > >> >>
> > >> >>> Hey
> > >> >>>
> > >> >>> A Hangout would have to happen on Friday at the earliest.  It'd be
> > >> good if
> > >> >>> we could get someone from Mozilla on the hangout as well.  I
> haven't
> > >> gotten
> > >> >>> MozillaView (GeckoView with Cordova methods) fully working yet.
>  For
> > >> some
> > >> >>> reason it's not rendering on the screen.
> > >> >>>
> > >> >>> Ideally it'd be cool to have at least two options when this
> feature
> > >> finally
> > >> >>> lands.
> > >> >>>
> > >> >>> What do other people think?
> > >> >>>
> > >> >>> Joe
> > >> >>> On 22 Apr 2014 20:06, "Hu, Ningxin" <ni...@intel.com> wrote:
> > >> >>>
> > >> >>> > Joe,
> > >> >>> >
> > >> >>> > Thanks for your review and merge the PRs.
> > >> >>> >
> > >> >>> > To pluggable webview interest group:
> > >> >>> > Are we OK to setup a hangout this week for initial introduction
> > and
> > >> >>> > discussion of next steps?
> > >> >>> >
> > >> >>> > Thanks,
> > >> >>> > -ningxin
> > >> >>> >
> > >> >>> > > -----Original Message-----
> > >> >>> > > From: Hu, Ningxin [mailto:ningxin.hu@intel.com]
> > >> >>> > > Sent: Tuesday, April 22, 2014 4:04 PM
> > >> >>> > > To: dev@cordova.apache.org
> > >> >>> > > Subject: RE: [Android] Refactoring for different engines
> > >> >>> > >
> > >> >>> > > The PoC is great! Quite excited about the direction!
> > >> >>> > >
> > >> >>> > > I've sent a PR to update the cordova-crosswalk-engine to
> latest
> > >> >>> crosswalk
> > >> >>> > > embedding API. It works with xwalk_core_library at 6.35.124.0.
> > >> >>> > >
> > >> >>> > > I've also changed the CordovaWebView interface slightly
> (adding
> > >> >>> > getView() API)
> > >> >>> > > to allow XWalkCordovaWebView to composite a XWalkView instead
> of
> > >> >>> > extending
> > >> >>> > > it. It resolves some API naming issues for XWalkView case.
> > >> >>> > >
> > >> >>> > > Please review them at:
> > >> >>> > > https://github.com/infil00p/cordova-crosswalk-engine/pull/3
> > >> >>> > > https://github.com/infil00p/cordova-android/pull/2
> > >> >>> > >
> > >> >>> > > Thanks,
> > >> >>> > > -ningxin
> > >> >>> > >
> > >> >>> > > > -----Original Message-----
> > >> >>> > > > From: Joe Bowser [mailto:bowserj@gmail.com]
> > >> >>> > > > Sent: Friday, April 11, 2014 12:45 AM
> > >> >>> > > > To: dev
> > >> >>> > > > Subject: Re: [Android] Refactoring for different engines
> > >> >>> > > >
> > >> >>> > > > Yeah, I'd be cool with setting up a hangout.  Everyone
> should
> > >> take a
> > >> >>> > > > look at the PoC, I've basically distilled it down to four or
> > >> >>> > > > five
> > >> >>> > > > classes so far, but with some work, we may be able to get it
> > >> down to
> > >> >>> > > > three.  Due to legacy, we're pretty stuck with the Android
> > >> WebView
> > >> >>> API
> > >> >>> > calls,
> > >> >>> > > but these can probably be modified.
> > >> >>> > > >
> > >> >>> > > > It'd be good to get Mozilla people on the call as well,
> since
> > >> they
> > >> >>> > > > have their WebView as well.
> > >> >>> > > >
> > >> >>> > > > On Thu, Apr 10, 2014 at 9:38 AM, Hu, Ningxin <
> > >> ningxin.hu@intel.com>
> > >> >>> > wrote:
> > >> >>> > > > > Hangout would be a good idea.
> > >> >>> > > > >
> > >> >>> > > > > FYI, I will be off next week. How about the week after
> next?
> > >> If it
> > >> >>> > > > > works, please
> > >> >>> > > > feel free to schedule one and count me in.
> > >> >>> > > > >
> > >> >>> > > > > Thanks,
> > >> >>> > > > > -ningxin
> > >> >>> > > > >
> > >> >>> > > > >> -----Original Message-----
> > >> >>> > > > >> From: mmocny@google.com [mailto:mmocny@google.com] On
> > Behalf
> > >> Of
> > >> >>> > > > >> Michal Mocny
> > >> >>> > > > >> Sent: Tuesday, April 08, 2014 11:39 PM
> > >> >>> > > > >> To: dev
> > >> >>> > > > >> Subject: Re: [Android] Refactoring for different engines
> > >> >>> > > > >>
> > >> >>> > > > >> Would it be alright to set up a Hangout some time to
> > >> >>> > > > >> introduce
> > >> >>> > everyone?
> > >> >>> > > > >>
> > >> >>> > > > >> Joe has been leading the effort here, but there are other
> > >> cordova
> > >> >>> > > > >> contributors for whom this is top priority.  It would be
> > nice
> > >> if
> > >> >>> we
> > >> >>> > > > >> could all meet to say hello and make sure we are all
> going
> > in
> > >> the
> > >> >>> > > > >> right
> > >> >>> > > > direction.
> > >> >>> > > > >>
> > >> >>> > > > >> Quite exciting!
> > >> >>> > > > >>
> > >> >>> > > > >> -Michal
> > >> >>> > > > >>
> > >> >>> > > > >>
> > >> >>> > > > >> On Tue, Apr 8, 2014 at 10:56 AM, Hu, Ningxin <
> > >> >>> ningxin.hu@intel.com>
> > >> >>> > > wrote:
> > >> >>> > > > >>
> > >> >>> > > > >> > Joe, thanks for this. I am very excited.
> > >> >>> > > > >> >
> > >> >>> > > > >> > FYI. Crosswalk team is working on refactoring the
> WebView
> > >> API to
> > >> >>> > > > >> > support embedding usage better [1]. (Previously the
> layer
> > >> API
> > >> >>> was
> > >> >>> > > > >> > not exposed as public usage).
> > >> >>> > > > >> >
> > >> >>> > > > >> > I would like to review the PoC and work with you to get
> > >> >>> Crosswalk
> > >> >>> > > > >> > fits into the pluggable WebView architecture.
> > >> >>> > > > >> >
> > >> >>> > > > >> > Thanks,
> > >> >>> > > > >> > -ningxin
> > >> >>> > > > >> >
> > >> >>> > > > >> > > -----Original Message-----
> > >> >>> > > > >> > > From: Joe Bowser [mailto:bowserj@gmail.com]
> > >> >>> > > > >> > > Sent: Wednesday, March 19, 2014 7:08 AM
> > >> >>> > > > >> > > To: dev
> > >> >>> > > > >> > > Subject: Re: [Android] Refactoring for different
> > engines
> > >> >>> > > > >> > >
> > >> >>> > > > >> > > Hey
> > >> >>> > > > >> > >
> > >> >>> > > > >> > > After debugging, I did some minor updates to the
> plugin
> > >> >>> README.
> > >> >>> > > > >> > > It
> > >> >>> > > > >> > should be
> > >> >>> > > > >> > > easier to get this up and running, although there's
> > still
> > >> the
> > >> >>> > > > >> > > issue of
> > >> >>> > > > >> > after-install
> > >> >>> > > > >> > > hooks and the relative path weirdness with the
> > Crosswalk
> > >> >>> > Library itself.
> > >> >>> > > > >> > >
> > >> >>> > > > >> > > It still doesn't support the CLI at all, but it
> should
> > be
> > >> >>> there
> > >> >>> > > > >> > > with the
> > >> >>> > > > >> > old flow.
> > >> >>> > > > >> > >
> > >> >>> > > > >> > > On Mon, Mar 17, 2014 at 1:14 PM, Michal Mocny
> > >> >>> > > > >> > > <mm...@chromium.org>
> > >> >>> > > > >> > > wrote:
> > >> >>> > > > >> > > > (Sorry Joe, Googlers are down in California and way
> > >> busy.
> > >> >>> > > > >> > > > Will be back in a week.  Super excited about this,
> > >> though.)
> > >> >>> > > > >> > > >
> > >> >>> > > > >> > > > -Michal
> > >> >>> > > > >> > > >
> > >> >>> > > > >> > > >
> > >> >>> > > > >> > > > On Mon, Mar 17, 2014 at 2:53 PM, Joe Bowser
> > >> >>> > > > >> > > > <bo...@gmail.com>
> > >> >>> > > > >> wrote:
> > >> >>> > > > >> > > >
> > >> >>> > > > >> > > >> Reviving this thread!
> > >> >>> > > > >> > > >>
> > >> >>> > > > >> > > >> Can other people look at this, and see if/when we
> > >> should
> > >> >>> > land this?
> > >> >>> > > > >> > > >> I know that I have to re-write the tests still,
> but
> > I
> > >> would
> > >> >>> > > > >> > > >> like some feedback before merging it in.  Also,
> it'd
> > >> >>> > > > >> > > >> be
> > >> >>> > > > >> > > >> super awesome if other people could try and make a
> > >> WebView
> > >> >>> > > > >> > > >> based on the interfaces and recommend which
> methods
> > >> should
> > >> >>> > > > >> > > >> die.  I want to get this released in the next
> month
> > or
> > >> so,
> > >> >>> > > > >> > > >> so any time and feedback would be greatly
> > appreciated.
> > >> >>> > > > >> > > >>
> > >> >>> > > > >> > > >> Thanks
> > >> >>> > > > >> > > >>
> > >> >>> > > > >> > > >> On Thu, Mar 13, 2014 at 3:50 PM, Joe Bowser
> > >> >>> > > > >> > > >> <bo...@gmail.com>
> > >> >>> > > > >> > wrote:
> > >> >>> > > > >> > > >> > Hey, I created the following today to track
> > various
> > >> >>> > > > >> > > >> > WebView
> > >> >>> > > > >> > progresses:
> > >> >>> > > > >> > > >> > https://issues.apache.org/jira/browse/CB-6246
> > >> >>> > > > >> > > >> >
> > >> >>> > > > >> > > >> > I also have this repo created.  The licensing is
> > >> ugly as
> > >> >>> > > > >> > > >> > all crap, but it's a Proof-Of-Concept:
> > >> >>> > > > >> > > >> >
> > https://github.com/infil00p/cordova-crosswalk-engine
> > >> >>> > > > >> > > >> >
> > >> >>> > > > >> > > >> > If I can get some help getting plugman to just
> > load
> > >> >>> > > > >> > > >> > Crosswalk, it'll
> > >> >>> > > > >> > > >> look hawt.
> > >> >>> > > > >> > > >> >
> > >> >>> > > > >> > > >> > BTW: We should probably get this ready to go
> into
> > >> Android
> > >> >>> > > > >> > > >> > in the next two months and deprecate the
> > setProperty
> > >> >>> > > > >> > > >> > methods, since all properties should be
> > preferences
> > >> in
> > >> >>> > config.xml
> > >> >>> > > now.
> > >> >>> > > > >> > > >> >
> > >> >>> > > > >> > > >> > On Mon, Mar 10, 2014 at 2:42 PM, Joe Bowser
> > >> >>> > > > >> > > >> > <bo...@gmail.com>
> > >> >>> > > > >> > > wrote:
> > >> >>> > > > >> > > >> >> Perhaps. There would be additional benefits to
> > this
> > >> >>> > > > >> > > >> >> approach, namely fixes being added to that
> > platform
> > >> more
> > >> >>> > > > >> > > >> >> quickly.  I'll probably take a look at that
> once
> > I
> > >> have
> > >> >>> > > > >> > > >> >> Crosswalk
> > >> >>> > > > finalized.
> > >> >>> > > > >> > > >> >>
> > >> >>> > > > >> > > >> >> On Mon, Mar 10, 2014 at 9:49 AM, Brian LeRoux
> > >> >>> > > > >> > > >> >> <b...@brian.io>
> > >> >>> > > > wrote:
> > >> >>> > > > >> > > >> >>> this is great stuff
> > >> >>> > > > >> > > >> >>>
> > >> >>> > > > >> > > >> >>> do we think it may be possible to bring in
> > amazon
> > >> >>> fireos
> > >> >>> > > > >> > > >> >>> stuff
> > >> >>> > > > >> > > >> eventually
> > >> >>> > > > >> > > >> >>> too?
> > >> >>> > > > >> > > >> >>>
> > >> >>> > > > >> > > >> >>>
> > >> >>> > > > >> > > >> >>> On Fri, Mar 7, 2014 at 3:22 PM, Joe Bowser
> > >> >>> > > > >> > > >> >>> <bo...@gmail.com>
> > >> >>> > > > >> > wrote:
> > >> >>> > > > >> > > >> >>>
> > >> >>> > > > >> > > >> >>>> BTW: I committed it in my repo, not the main
> > >> Apache
> > >> >>> one.
> > >> >>> > > > >> > > >> >>>>
> > >> >>> > > > >> > > >> >>>> On Fri, Mar 7, 2014 at 3:21 PM, Joe Bowser
> > >> >>> > > > >> > > >> >>>> <bo...@gmail.com>
> > >> >>> > > > >> > > wrote:
> > >> >>> > > > >> > > >> >>>> > Hey
> > >> >>> > > > >> > > >> >>>> >
> > >> >>> > > > >> > > >> >>>> > I just committed some code based on their
> > >> WebView
> > >> >>> > > > >> > > >> >>>> > modifications that allows you to choose
> your
> > >> >>> renderer
> > >> >>> > > > >> > > >> >>>> > in the
> > >> >>> > > > >> > config file
> > >> >>> > > > >> > > with this:
> > >> >>> > > > >> > > >> >>>> >
> > >> >>> > > > >> > > >> >>>> >     <preference name="webView"
> > >> >>> > > > >> > > >> >>>> >
> > >> >>> value="org.apache.cordova.engine.crosswalk.XWalkCordo
> > >> >>> > > > >> > > >> >>>> > va
> > >> >>> > > > >> > > >> >>>> > Web
> > >> >>> > > > >> > > >> >>>> > View
> > >> >>> > > > >> > > >> >>>> > " />
> > >> >>> > > > >> > > >> >>>> >
> > >> >>> > > > >> > > >> >>>> > You currently have to copy over the *.pak
> > file
> > >> and
> > >> >>> > > > >> > > >> >>>> > the jsapi from a Crosswalk Example project
> to
> > >> get
> > >> >>> > > > >> > > >> >>>> > this to work.  The next thing that I'm
> going
> > to
> > >> do
> > >> >>> is
> > >> >>> > > > >> > > >> >>>> > figure out how to write this as a plugin
> and
> > >> have it
> > >> >>> > > > >> > > >> >>>> > install on a default
> > >> >>> > > > project.
> > >> >>> > > > >> > > >> >>>> > Also, right now the bridge doesn't seem to
> > >> work, and
> > >> >>> > > > >> > > >> >>>> > I don't know why exactly.  That being said,
> > the
> > >> >>> > > > >> > > >> fact
> > >> >>> > > > >> > > >> >>>> > that I can choose which version of
> > >> Chrome/Chromium
> > >> >>> > > > >> > > >> >>>> > I'm running with
> > >> >>> > > > >> > > >> a
> > >> >>> > > > >> > > >> >>>> > single XML preference is HUGE.
> > >> >>> > > > >> > > >> >>>> >
> > >> >>> > > > >> > > >> >>>> > There's definitely a lot more work that
> needs
> > >> to be
> > >> >>> > > > >> > > >> >>>> > done, but as
> > >> >>> > > > >> > > >> long
> > >> >>> > > > >> > > >> >>>> > as we have something that we can fit into
> the
> > >> >>> > > > >> > > >> >>>> > interface, we should
> > >> >>> > > > >> > > >> be
> > >> >>> > > > >> > > >> >>>> > able to put in things like GeckoView or
> other
> > >> third
> > >> >>> > > > >> > > >> >>>> > party
> > >> >>> > > > >> > renderers.
> > >> >>> > > > >> > > >> >>>> > The nightmare of being stuck with bullshit
> > >> WebView
> > >> >>> > > > >> > > >> >>>> > bugs may soon be over.
> > >> >>> > > > >> > > >> >>>> >
> > >> >>> > > > >> > > >> >>>> > On Wed, Mar 5, 2014 at 8:59 PM, Michal
> Mocny
> > >> >>> > > > >> > > >> >>>> > <mm...@chromium.org>
> > >> >>> > > > >> > > >> >>>> wrote:
> > >> >>> > > > >> > > >> >>>> >>
> > >> >>> https://github.com/crosswalk-project/crosswalk-cordo
> > >> >>> > > > >> > > >> >>>> >> va
> > >> >>> > > > >> > > >> >>>> >> -an
> > >> >>> > > > >> > > >> >>>> >> droi
> > >> >>> > > > >> > > >> >>>> >> d
> > >> >>> > > > >> > > >> >>>> >>
> > >> >>> > > > >> > > >> >>>> >> First patch they landed, which claims to
> > have
> > >> min
> > >> >>> > > > >> > > >> >>>> >> viable xwalk
> > >> >>> > > > >> > > >> webview:
> > >> >>> > > > >> > > >> >>>> >>
> > >> >>> > > > >> > > >> >>>>
> > >> >>> > > > >> > > >>
> > >> >>> https://github.com/crosswalk-project/crosswalk-cordova-andro
> > >> >>> > > > >> > > >> id
> > >> >>> > > > >> > > >> /co
> > >> >>> > > > >> > > >> mmit
> > >> >>> > > > >> > > >> /a04dedeb0204e7542d190312c6ae70c795a26e04
> > >> >>> > > > >> > > >> >>>> >>
> > >> >>> > > > >> > > >> >>>> >>
> > >> >>> > > > >> > > >> >>>> >> On Wed, Mar 5, 2014 at 11:37 PM, Michal
> > Mocny
> > >> >>> > > > >> > > >> >>>> >> <mmocny@chromium.org
> > >> >>> > > > >> > > >> >
> > >> >>> > > > >> > > >> >>>> wrote:
> > >> >>> > > > >> > > >> >>>> >>
> > >> >>> > > > >> > > >> >>>> >>> I haven't looked yet, but did you see:
> > >> >>> > > > >> > > >> >>>> >>>
> > >> >>> https://crosswalk-project.org/#wiki/crosswalk-cordo
> > >> >>> > > > >> > > >> >>>> >>> va
> > >> >>> > > > >> > > >> >>>> >>> -an
> > >> >>> > > > >> > > >> >>>> >>> droi
> > >> >>> > > > >> > > >> >>>> >>> d
> > >> >>> > > > >> > > >> >>>> >>>
> > >> >>> > > > >> > > >> >>>> >>> ?
> > >> >>> > > > >> > > >> >>>> >>>
> > >> >>> > > > >> > > >> >>>> >>>
> > >> >>> > > > >> > > >> >>>> >>> On Wed, Mar 5, 2014 at 10:20 PM, Andrew
> > >> Grieve <
> > >> >>> > > > >> > > >> agrieve@chromium.org
> > >> >>> > > > >> > > >> >>>> >wrote:
> > >> >>> > > > >> > > >> >>>> >>>
> > >> >>> > > > >> > > >> >>>> >>>> First - very excited that you're working
> > on
> > >> this!
> > >> >>> > > > >> > > >> >>>> >>>>
> > >> >>> > > > >> > > >> >>>> >>>> Had a quick look. Not sure there's much
> to
> > >> >>> > > > >> > > >> >>>> >>>> be
> > >> >>> > gleaned
> > >> >>> > > yet.
> > >> >>> > > > >> > > >> >>>> >>>> Once
> > >> >>> > > > >> > > >> you
> > >> >>> > > > >> > > >> >>>> start
> > >> >>> > > > >> > > >> >>>> >>>> in on hooking up x-walk's webview I
> think
> > it
> > >> will
> > >> >>> > > > >> > > >> >>>> >>>> become more
> > >> >>> > > > >> > > >> obvious
> > >> >>> > > > >> > > >> >>>> what
> > >> >>> > > > >> > > >> >>>> >>>> the interface should look like. E.g.,
> does
> > >> x-walk
> > >> >>> > > > >> > > >> >>>> >>>> even have the
> > >> >>> > > > >> > > >> >>>> concept of
> > >> >>> > > > >> > > >> >>>> >>>> ChromeClient vs WebViewClient vs
> WebView?
> > >> Also
> > >> >>> > > > >> > > >> >>>> >>>> unsure whether the
> > >> >>> > > > >> > > >> >>>> class
> > >> >>> > > > >> > > >> >>>> >>>> should extend android.View as well as
> > >> implement
> > >> >>> > > > >> > > >> >>>> >>>> our
> > >> >>> > > > >> > interface.
> > >> >>> > > > >> > > >> E.g.
> > >> >>> > > > >> > > >> >>>> >>>> alternative is to have a "getView()"
> > method
> > >> on
> > >> >>> the
> > >> >>> > > > >> > interface.
> > >> >>> > > > >> > > >> Might
> > >> >>> > > > >> > > >> >>>> help
> > >> >>> > > > >> > > >> >>>> >>>> to
> > >> >>> > > > >> > > >> >>>> >>>> cut down on file sizes, and API surface,
> > but
> > >> >>> > > > >> > > >> >>>> >>>> again, I'm not too
> > >> >>> > > > >> > > >> sure.
> > >> >>> > > > >> > > >> >>>> >>>>
> > >> >>> > > > >> > > >> >>>> >>>> I've been pretty hesitant to touch
> > existing
> > >> >>> > > > >> > > >> >>>> >>>> exposed members
> > >> >>> > > > >> > > >> (e.g. the
> > >> >>> > > > >> > > >> >>>> >>>> public fields you were referring to)
> since
> > >> >>> > > > >> > > >> >>>> >>>> touching anything
> > >> >>> > > > >> > > >> public
> > >> >>> > > > >> > > >> >>>> could
> > >> >>> > > > >> > > >> >>>> >>>> break plugins. That said, maybe now is a
> > >> >>> > > > >> > > >> >>>> >>>> good
> > >> >>> time
> > >> >>> > > > >> > > >> >>>> >>>> to @deprecate
> > >> >>> > > > >> > > >> a
> > >> >>> > > > >> > > >> >>>> bunch
> > >> >>> > > > >> > > >> >>>> >>>> of
> > >> >>> > > > >> > > >> >>>> >>>> them and either replace them with
> getters,
> > >> >>> > > > >> > > >> >>>> >>>> or
> > >> >>> just
> > >> >>> > > > >> > > >> >>>> >>>> declare them
> > >> >>> > > > >> > > >> to be
> > >> >>> > > > >> > > >> >>>> not
> > >> >>> > > > >> > > >> >>>> >>>> exposed to plugins.
> > >> >>> > > > >> > > >> >>>> >>>>
> > >> >>> > > > >> > > >> >>>> >>>>
> > >> >>> > > > >> > > >> >>>> >>>> On Wed, Mar 5, 2014 at 6:57 PM, Joe
> Bowser
> > >> >>> > > > >> > > >> >>>> >>>> <bo...@gmail.com>
> > >> >>> > > > >> > > >> wrote:
> > >> >>> > > > >> > > >> >>>> >>>>
> > >> >>> > > > >> > > >> >>>> >>>> > So, after looking at the Crosswalk
> code
> > >> again,
> > >> >>> > > > >> > > >> >>>> >>>> > I've decided to
> > >> >>> > > > >> > > >> take
> > >> >>> > > > >> > > >> >>>> a
> > >> >>> > > > >> > > >> >>>> >>>> > quick stab at making things pluggable.
> >  I
> > >> don't
> > >> >>> > > > >> > > >> >>>> >>>> > have a lot to
> > >> >>> > > > >> > > >> show
> > >> >>> > > > >> > > >> >>>> for
> > >> >>> > > > >> > > >> >>>> >>>> > it, but with the help of Eclipse
> (which
> > is
> > >> why
> > >> >>> > > > >> > > >> >>>> >>>> > the generated interfaces look so
> screwed
> > >> up), I
> > >> >>> > > > >> > > >> >>>> >>>> > managed to create some
> > >> >>> > > > >> > > >> interfaces
> > >> >>> > > > >> > > >> >>>> so
> > >> >>> > > > >> > > >> >>>> >>>> > we can start shoehorning in other
> > browser
> > >> >>> > renderers.
> > >> >>> > > > >> > > >> >>>> >>>> >
> > >> >>> > > > >> > > >> >>>> >>>> >
> > >> >>> > > > >> > > >>
> > >> >>> https://github.com/infil00p/cordova-android/tree/pluggable_w
> > >> >>> > > > >> > > >> eb
> > >> >>> > > > >> > > >> vie
> > >> >>> > > > >> > > >> w
> > >> >>> > > > >> > > >> >>>> >>>> >
> > >> >>> > > > >> > > >> >>>> >>>> > I'm going to probably start with
> > >> >>> > > > >> > > >> >>>> >>>> > Crosswalk,
> > >> >>> > > > >> > > >> >>>> >>>> > because it's
> > >> >>> > > > >> > > >> probably
> > >> >>> > > > >> > > >> >>>> the
> > >> >>> > > > >> > > >> >>>> >>>> > most mature primary candidate in the
> > >> Android
> > >> >>> > > > >> > > >> >>>> >>>> > Third-Party
> > >> >>> > > > >> > > >> WebView
> > >> >>> > > > >> > > >> >>>> >>>> > thing, and I'm pretty sure the
> GeckoView
> > >> will
> > >> >>> be
> > >> >>> > > > >> > > >> >>>> >>>> > happening
> > >> >>> > > > >> > > >> shortly
> > >> >>> > > > >> > > >> >>>> >>>> > after.
> > >> >>> > > > >> > > >> >>>> >>>> >
> > >> >>> > > > >> > > >> >>>> >>>> > I don't know how this would work
> w.r.t.
> > >> the CLI
> > >> >>> > > > >> > > >> >>>> >>>> > or our
> > >> >>> > > > >> > > >> workflow at
> > >> >>> > > > >> > > >> >>>> >>>> > all, but at the moment, I really just
> > want
> > >> to
> > >> >>> at
> > >> >>> > > > >> > > >> >>>> >>>> > least start
> > >> >>> > > > >> > > >> to have
> > >> >>> > > > >> > > >> >>>> >>>> > some headway towards 4.x and PhoneGap
> > day.
> > >> >>> > > > >> > > >> >>>> >>>> >
> > >> >>> > > > >> > > >> >>>> >>>> > What do people think of this so far?
> I'm
> > >> going
> > >> >>> > > > >> > > >> >>>> >>>> > to try to clean
> > >> >>> > > > >> > > >> >>>> things
> > >> >>> > > > >> > > >> >>>> >>>> > up a bit, since we've definitely done
> a
> > >> lot of
> > >> >>> > > > >> > > >> >>>> >>>> > things that
> > >> >>> > > > >> > > >> would
> > >> >>> > > > >> > > >> >>>> make
> > >> >>> > > > >> > > >> >>>> >>>> > first year CS profs freak the hell out
> > >> (i.e.
> > >> >>> > > > >> > > >> >>>> >>>> > public members in
> > >> >>> > > > >> > > >> >>>> public
> > >> >>> > > > >> > > >> >>>> >>>> > objects w.r.t. PluginManager).
> > >> >>> > > > >> > > >> >>>> >>>> >
> > >> >>> > > > >> > > >> >>>> >>>> > Thoughts?
> > >> >>> > > > >> > > >> >>>> >>>> >
> > >> >>> > > > >> > > >> >>>> >>>> > Joe
> > >> >>> > > > >> > > >> >>>> >>>> >
> > >> >>> > > > >> > > >> >>>> >>>>
> > >> >>> > > > >> > > >> >>>> >>>
> > >> >>> > > > >> > > >> >>>> >>>
> > >> >>> > > > >> > > >> >>>>
> > >> >>> > > > >> > > >>
> > >> >>> > > > >> >
> > >> >>> >
> > >> >>>
> > >>
> > >
> > >
> > >
> > >
> >
>

Re: [Android] Refactoring for different engines

[Ian Clelland <ic...@chromium.org>]

https://staging.talkgadget.google.com/hangouts/_/7ecpi3uaclcuedn7imn6b9jdqc


On Fri, Apr 25, 2014 at 11:58 AM, Joe Bowser <bo...@gmail.com> wrote:

> Hangout link for this morning?
>
> On Fri, Apr 25, 2014 at 8:57 AM, Hu, Ningxin <ni...@intel.com> wrote:
> >> Are people also going to use older (1-4) versions of Crosswalk? Or is
> the
> >> plan to encourage people to only use either stable or beta versions?
> >
> >
> >
> > Crosswalk follows release cycles similar to Chromium. Current canary is
> > Crosswalk-6, beta is 5 and stable is 4. The developers work on canary for
> > new features. The public embedding API is a new feature for Crosswalk-6.
> If
> > we want to release cordova-corsswalk-engine, the Crosswalk-6 would be the
> > initial version.
> >
> >
> >
> >> That would be good to have -- I'd like to have some kind of warning that
> >> new changes in the upstream project break the plugin :)
> >
> >
> >
> > +1. So the bot need to build and run mobilespec test suite. Do you know
> > whether the bot can drive mobilespec via adb?
> >
> >
> >
> > Thanks,
> >
> > -ningxin
> >
> >
> >
> > From: iclelland@google.com [mailto:iclelland@google.com] On Behalf Of
> Ian
> > Clelland
> >
> >
> > Sent: Thursday, April 24, 2014 11:58 PM
> > To: Hu, Ningxin
> > Cc: Joe Bowser; dev@cordova.apache.org
> > Subject: Re: [Android] Refactoring for different engines
> >
> >
> >
> >
> >
> >
> >
> > On Thu, Apr 24, 2014 at 5:27 AM, Hu, Ningxin <ni...@intel.com>
> wrote:
> >
> >> Mobilespec runs on my N4, with 10 failing tests: 3 in contacts; 7 in
> >> file-transfer. Otherwise, things seem to be working pretty well.
> >
> >
> >
> > I checked out the latest code (@691fbce540) and build mbilespec with
> > Crosswalk 6.35.127.0. However, it runs on the default Android WebView
> due to
> > the InvocationTargetException when calling constructors of
> > XWalkWebChromeClient and XWalkClient. I fixed it at:
> > https://github.com/infil00p/cordova-crosswalk-engine/pull/6.
> >
> >
> >
> > This looks good, I've pulled that in locally.
> >
> >
> >
> >
> >
> > To make the plugins work on cordova-crosswalk-engine, it still needs to
> set
> > correct webview client, chrome client and enable the setNetworkAvailable.
> > I've sent another two PRs.
> >
> > https://github.com/infil00p/cordova-crosswalk-engine/pull/7
> >
> > https://github.com/infil00p/cordova-android/pull/3
> >
> >
> >
> > I think that we could do this differently. I would rather see the
> > functionality of CordovaActivity.makeWebViewClient and
> > CordovaActivity.makeChromeClient moved into the AndroidWebView class, and
> > declared as methods in the CordovaWebView interface. Then we would
> override
> > them in XWalkCordovaWebView to do the right thing.
> >
> >
> >
> > The extra string manipulation magic, and reflection, that this patch
> > introduces, seems wrong to me. Considering that we already have methods
> in
> > XWalkCordovaWebView to construct those objects, then we should let the
> > XWalkCordovaWebView construct them.
> >
> >
> >
> > (I do like your method of iterating over the constructors, though -- I'm
> > going to try to use that code in makeWebView as well)
> >
> >
> >
> >
> >
> > After these fixes (and with three fixes in plugins to use
> getPluginManager()
> > interface), I can run the mobilespec "Run All Tests" on Crosswalk with
> all
> > passed except Media test. The Media.js seems not be loaded. I didn't have
> > chance to debug it yet.
> >
> >
> >
> > Ian and Joe, could you please review the PRs? I would appreciate that.
> >
> >
> >
> >> I've issued a pull request at
> >> https://github.com/infil00p/cordova-crosswalk-engine/pull/5 for it --
> I'm
> >> not sure if there's a way to keep compatibility with last week's
> Crosswalk,
> >> or if we'd even want to. (Ningxin, if you could take a look at that PR
> and
> >> see if it makes sense, I'd appreciate it)
> >
> >
> >
> > The PR LGTM! Thanks for the update.
> >
> >
> >
> > For crosswalk embedding API compatibility, currently we track the master
> > branch of Crosswalk (a.k.a Canary release channel), the embedding API in
> > master is still under development. As planned, the Crosswalk-6 will be
> > branched for beta in 4th May. In that branch, the embedding API will be
> > stable and only accept bug fixing. So for cordova-crosswalk-engine, we
> can
> > also have crosswalk-6 branch to track beta branch (later stable branch)
> and
> > using master to track the latest crosswalk.
> >
> >
> >
> > Are people also going to use older (1-4) versions of Crosswalk? Or is the
> > plan to encourage people to only use either stable or beta versions?
> >
> >
> >
> > I am even thinking about we can setup some bots (as buildbots in
> crosswalk)
> > to track if any patches to crosswalk break the cordova-crosswalk-engine.
> >
> >
> >
> > Your thoughts?
> >
> >
> >
> > That would be good to have -- I'd like to have some kind of warning that
> new
> > changes in the upstream project break the plugin :)
> >
> >
> >
> >
> >
> > Thanks,
> >
> > -ningxin
> >
> >
> >
> > From: iclelland@google.com [mailto:iclelland@google.com] On Behalf Of
> Ian
> > Clelland
> > Sent: Thursday, April 24, 2014 1:32 AM
> > To: dev@cordova.apache.org
> > Cc: Joe Bowser; Hu, Ningxin
> >
> >
> > Subject: Re: [Android] Refactoring for different engines
> >
> >
> >
> > I've managed to get this up and running now -- great work on this, Joe!
> >
> >
> >
> > Mobilespec runs on my N4, with 10 failing tests: 3 in contacts; 7 in
> > file-transfer. Otherwise, things seem to be working pretty well.
> >
> >
> >
> > I used a new build of Crosswalk, and found that the embedding API has
> > changed since the weekend (when Ningxin's patches applied). I've issued a
> > pull request at
> https://github.com/infil00p/cordova-crosswalk-engine/pull/5
> > for it -- I'm not sure if there's a way to keep compatibility with last
> > week's Crosswalk, or if we'd even want to. (Ningxin, if you could take a
> > look at that PR and see if it makes sense, I'd appreciate it)
> >
> >
> >
> > Joe, I also had to patch the default constructor for
> XWalkCordovaWebView; it
> > wasn't creating its own client objects, so it got the default ones, and
> most
> > of the tests were failing because some component of the bridge wan't
> > working. https://github.com/infil00p/cordova-crosswalk-engine/pull/4 is
> out
> > for that.
> >
> >
> >
> > Count me in for the hangout -- this is exciting stuff
> >
> >
> >
> > Ian
> >
> >
> >
> > On Wed, Apr 23, 2014 at 10:26 AM, Brian LeRoux <b...@brian.io> wrote:
> >
> > Yup I'll track em down
> >
> > On Apr 23, 2014 7:17 AM, "Andrew Grieve" <ag...@chromium.org> wrote:
> >
> >> Does anyone have a contact at moz that we could invite?
> >>
> >> On Wed, Apr 23, 2014 at 10:09 AM, Andrew Grieve <ag...@chromium.org>
> >> wrote:
> >> > Depends on their interest level I think. Faster we can get this out
> >> > the door the better. If we need to delay for geckoview, then I don't
> >> > think we should gate on it, just release it after.
> >> >
> >> > On Wed, Apr 23, 2014 at 3:01 AM, Tommy Williams <to...@devgeeks.org>
> >> wrote:
> >> >> More engines, more better...
> >> >> On 23 Apr 2014 16:32, "Joe Bowser" <bo...@gmail.com> wrote:
> >> >>
> >> >>> Hey
> >> >>>
> >> >>> A Hangout would have to happen on Friday at the earliest.  It'd be
> >> good if
> >> >>> we could get someone from Mozilla on the hangout as well.  I haven't
> >> gotten
> >> >>> MozillaView (GeckoView with Cordova methods) fully working yet.  For
> >> some
> >> >>> reason it's not rendering on the screen.
> >> >>>
> >> >>> Ideally it'd be cool to have at least two options when this feature
> >> finally
> >> >>> lands.
> >> >>>
> >> >>> What do other people think?
> >> >>>
> >> >>> Joe
> >> >>> On 22 Apr 2014 20:06, "Hu, Ningxin" <ni...@intel.com> wrote:
> >> >>>
> >> >>> > Joe,
> >> >>> >
> >> >>> > Thanks for your review and merge the PRs.
> >> >>> >
> >> >>> > To pluggable webview interest group:
> >> >>> > Are we OK to setup a hangout this week for initial introduction
> and
> >> >>> > discussion of next steps?
> >> >>> >
> >> >>> > Thanks,
> >> >>> > -ningxin
> >> >>> >
> >> >>> > > -----Original Message-----
> >> >>> > > From: Hu, Ningxin [mailto:ningxin.hu@intel.com]
> >> >>> > > Sent: Tuesday, April 22, 2014 4:04 PM
> >> >>> > > To: dev@cordova.apache.org
> >> >>> > > Subject: RE: [Android] Refactoring for different engines
> >> >>> > >
> >> >>> > > The PoC is great! Quite excited about the direction!
> >> >>> > >
> >> >>> > > I've sent a PR to update the cordova-crosswalk-engine to latest
> >> >>> crosswalk
> >> >>> > > embedding API. It works with xwalk_core_library at 6.35.124.0.
> >> >>> > >
> >> >>> > > I've also changed the CordovaWebView interface slightly (adding
> >> >>> > getView() API)
> >> >>> > > to allow XWalkCordovaWebView to composite a XWalkView instead of
> >> >>> > extending
> >> >>> > > it. It resolves some API naming issues for XWalkView case.
> >> >>> > >
> >> >>> > > Please review them at:
> >> >>> > > https://github.com/infil00p/cordova-crosswalk-engine/pull/3
> >> >>> > > https://github.com/infil00p/cordova-android/pull/2
> >> >>> > >
> >> >>> > > Thanks,
> >> >>> > > -ningxin
> >> >>> > >
> >> >>> > > > -----Original Message-----
> >> >>> > > > From: Joe Bowser [mailto:bowserj@gmail.com]
> >> >>> > > > Sent: Friday, April 11, 2014 12:45 AM
> >> >>> > > > To: dev
> >> >>> > > > Subject: Re: [Android] Refactoring for different engines
> >> >>> > > >
> >> >>> > > > Yeah, I'd be cool with setting up a hangout.  Everyone should
> >> take a
> >> >>> > > > look at the PoC, I've basically distilled it down to four or
> >> >>> > > > five
> >> >>> > > > classes so far, but with some work, we may be able to get it
> >> down to
> >> >>> > > > three.  Due to legacy, we're pretty stuck with the Android
> >> WebView
> >> >>> API
> >> >>> > calls,
> >> >>> > > but these can probably be modified.
> >> >>> > > >
> >> >>> > > > It'd be good to get Mozilla people on the call as well, since
> >> they
> >> >>> > > > have their WebView as well.
> >> >>> > > >
> >> >>> > > > On Thu, Apr 10, 2014 at 9:38 AM, Hu, Ningxin <
> >> ningxin.hu@intel.com>
> >> >>> > wrote:
> >> >>> > > > > Hangout would be a good idea.
> >> >>> > > > >
> >> >>> > > > > FYI, I will be off next week. How about the week after next?
> >> If it
> >> >>> > > > > works, please
> >> >>> > > > feel free to schedule one and count me in.
> >> >>> > > > >
> >> >>> > > > > Thanks,
> >> >>> > > > > -ningxin
> >> >>> > > > >
> >> >>> > > > >> -----Original Message-----
> >> >>> > > > >> From: mmocny@google.com [mailto:mmocny@google.com] On
> Behalf
> >> Of
> >> >>> > > > >> Michal Mocny
> >> >>> > > > >> Sent: Tuesday, April 08, 2014 11:39 PM
> >> >>> > > > >> To: dev
> >> >>> > > > >> Subject: Re: [Android] Refactoring for different engines
> >> >>> > > > >>
> >> >>> > > > >> Would it be alright to set up a Hangout some time to
> >> >>> > > > >> introduce
> >> >>> > everyone?
> >> >>> > > > >>
> >> >>> > > > >> Joe has been leading the effort here, but there are other
> >> cordova
> >> >>> > > > >> contributors for whom this is top priority.  It would be
> nice
> >> if
> >> >>> we
> >> >>> > > > >> could all meet to say hello and make sure we are all going
> in
> >> the
> >> >>> > > > >> right
> >> >>> > > > direction.
> >> >>> > > > >>
> >> >>> > > > >> Quite exciting!
> >> >>> > > > >>
> >> >>> > > > >> -Michal
> >> >>> > > > >>
> >> >>> > > > >>
> >> >>> > > > >> On Tue, Apr 8, 2014 at 10:56 AM, Hu, Ningxin <
> >> >>> ningxin.hu@intel.com>
> >> >>> > > wrote:
> >> >>> > > > >>
> >> >>> > > > >> > Joe, thanks for this. I am very excited.
> >> >>> > > > >> >
> >> >>> > > > >> > FYI. Crosswalk team is working on refactoring the WebView
> >> API to
> >> >>> > > > >> > support embedding usage better [1]. (Previously the layer
> >> API
> >> >>> was
> >> >>> > > > >> > not exposed as public usage).
> >> >>> > > > >> >
> >> >>> > > > >> > I would like to review the PoC and work with you to get
> >> >>> Crosswalk
> >> >>> > > > >> > fits into the pluggable WebView architecture.
> >> >>> > > > >> >
> >> >>> > > > >> > Thanks,
> >> >>> > > > >> > -ningxin
> >> >>> > > > >> >
> >> >>> > > > >> > > -----Original Message-----
> >> >>> > > > >> > > From: Joe Bowser [mailto:bowserj@gmail.com]
> >> >>> > > > >> > > Sent: Wednesday, March 19, 2014 7:08 AM
> >> >>> > > > >> > > To: dev
> >> >>> > > > >> > > Subject: Re: [Android] Refactoring for different
> engines
> >> >>> > > > >> > >
> >> >>> > > > >> > > Hey
> >> >>> > > > >> > >
> >> >>> > > > >> > > After debugging, I did some minor updates to the plugin
> >> >>> README.
> >> >>> > > > >> > > It
> >> >>> > > > >> > should be
> >> >>> > > > >> > > easier to get this up and running, although there's
> still
> >> the
> >> >>> > > > >> > > issue of
> >> >>> > > > >> > after-install
> >> >>> > > > >> > > hooks and the relative path weirdness with the
> Crosswalk
> >> >>> > Library itself.
> >> >>> > > > >> > >
> >> >>> > > > >> > > It still doesn't support the CLI at all, but it should
> be
> >> >>> there
> >> >>> > > > >> > > with the
> >> >>> > > > >> > old flow.
> >> >>> > > > >> > >
> >> >>> > > > >> > > On Mon, Mar 17, 2014 at 1:14 PM, Michal Mocny
> >> >>> > > > >> > > <mm...@chromium.org>
> >> >>> > > > >> > > wrote:
> >> >>> > > > >> > > > (Sorry Joe, Googlers are down in California and way
> >> busy.
> >> >>> > > > >> > > > Will be back in a week.  Super excited about this,
> >> though.)
> >> >>> > > > >> > > >
> >> >>> > > > >> > > > -Michal
> >> >>> > > > >> > > >
> >> >>> > > > >> > > >
> >> >>> > > > >> > > > On Mon, Mar 17, 2014 at 2:53 PM, Joe Bowser
> >> >>> > > > >> > > > <bo...@gmail.com>
> >> >>> > > > >> wrote:
> >> >>> > > > >> > > >
> >> >>> > > > >> > > >> Reviving this thread!
> >> >>> > > > >> > > >>
> >> >>> > > > >> > > >> Can other people look at this, and see if/when we
> >> should
> >> >>> > land this?
> >> >>> > > > >> > > >> I know that I have to re-write the tests still, but
> I
> >> would
> >> >>> > > > >> > > >> like some feedback before merging it in.  Also, it'd
> >> >>> > > > >> > > >> be
> >> >>> > > > >> > > >> super awesome if other people could try and make a
> >> WebView
> >> >>> > > > >> > > >> based on the interfaces and recommend which methods
> >> should
> >> >>> > > > >> > > >> die.  I want to get this released in the next month
> or
> >> so,
> >> >>> > > > >> > > >> so any time and feedback would be greatly
> appreciated.
> >> >>> > > > >> > > >>
> >> >>> > > > >> > > >> Thanks
> >> >>> > > > >> > > >>
> >> >>> > > > >> > > >> On Thu, Mar 13, 2014 at 3:50 PM, Joe Bowser
> >> >>> > > > >> > > >> <bo...@gmail.com>
> >> >>> > > > >> > wrote:
> >> >>> > > > >> > > >> > Hey, I created the following today to track
> various
> >> >>> > > > >> > > >> > WebView
> >> >>> > > > >> > progresses:
> >> >>> > > > >> > > >> > https://issues.apache.org/jira/browse/CB-6246
> >> >>> > > > >> > > >> >
> >> >>> > > > >> > > >> > I also have this repo created.  The licensing is
> >> ugly as
> >> >>> > > > >> > > >> > all crap, but it's a Proof-Of-Concept:
> >> >>> > > > >> > > >> >
> https://github.com/infil00p/cordova-crosswalk-engine
> >> >>> > > > >> > > >> >
> >> >>> > > > >> > > >> > If I can get some help getting plugman to just
> load
> >> >>> > > > >> > > >> > Crosswalk, it'll
> >> >>> > > > >> > > >> look hawt.
> >> >>> > > > >> > > >> >
> >> >>> > > > >> > > >> > BTW: We should probably get this ready to go into
> >> Android
> >> >>> > > > >> > > >> > in the next two months and deprecate the
> setProperty
> >> >>> > > > >> > > >> > methods, since all properties should be
> preferences
> >> in
> >> >>> > config.xml
> >> >>> > > now.
> >> >>> > > > >> > > >> >
> >> >>> > > > >> > > >> > On Mon, Mar 10, 2014 at 2:42 PM, Joe Bowser
> >> >>> > > > >> > > >> > <bo...@gmail.com>
> >> >>> > > > >> > > wrote:
> >> >>> > > > >> > > >> >> Perhaps. There would be additional benefits to
> this
> >> >>> > > > >> > > >> >> approach, namely fixes being added to that
> platform
> >> more
> >> >>> > > > >> > > >> >> quickly.  I'll probably take a look at that once
> I
> >> have
> >> >>> > > > >> > > >> >> Crosswalk
> >> >>> > > > finalized.
> >> >>> > > > >> > > >> >>
> >> >>> > > > >> > > >> >> On Mon, Mar 10, 2014 at 9:49 AM, Brian LeRoux
> >> >>> > > > >> > > >> >> <b...@brian.io>
> >> >>> > > > wrote:
> >> >>> > > > >> > > >> >>> this is great stuff
> >> >>> > > > >> > > >> >>>
> >> >>> > > > >> > > >> >>> do we think it may be possible to bring in
> amazon
> >> >>> fireos
> >> >>> > > > >> > > >> >>> stuff
> >> >>> > > > >> > > >> eventually
> >> >>> > > > >> > > >> >>> too?
> >> >>> > > > >> > > >> >>>
> >> >>> > > > >> > > >> >>>
> >> >>> > > > >> > > >> >>> On Fri, Mar 7, 2014 at 3:22 PM, Joe Bowser
> >> >>> > > > >> > > >> >>> <bo...@gmail.com>
> >> >>> > > > >> > wrote:
> >> >>> > > > >> > > >> >>>
> >> >>> > > > >> > > >> >>>> BTW: I committed it in my repo, not the main
> >> Apache
> >> >>> one.
> >> >>> > > > >> > > >> >>>>
> >> >>> > > > >> > > >> >>>> On Fri, Mar 7, 2014 at 3:21 PM, Joe Bowser
> >> >>> > > > >> > > >> >>>> <bo...@gmail.com>
> >> >>> > > > >> > > wrote:
> >> >>> > > > >> > > >> >>>> > Hey
> >> >>> > > > >> > > >> >>>> >
> >> >>> > > > >> > > >> >>>> > I just committed some code based on their
> >> WebView
> >> >>> > > > >> > > >> >>>> > modifications that allows you to choose your
> >> >>> renderer
> >> >>> > > > >> > > >> >>>> > in the
> >> >>> > > > >> > config file
> >> >>> > > > >> > > with this:
> >> >>> > > > >> > > >> >>>> >
> >> >>> > > > >> > > >> >>>> >     <preference name="webView"
> >> >>> > > > >> > > >> >>>> >
> >> >>> value="org.apache.cordova.engine.crosswalk.XWalkCordo
> >> >>> > > > >> > > >> >>>> > va
> >> >>> > > > >> > > >> >>>> > Web
> >> >>> > > > >> > > >> >>>> > View
> >> >>> > > > >> > > >> >>>> > " />
> >> >>> > > > >> > > >> >>>> >
> >> >>> > > > >> > > >> >>>> > You currently have to copy over the *.pak
> file
> >> and
> >> >>> > > > >> > > >> >>>> > the jsapi from a Crosswalk Example project to
> >> get
> >> >>> > > > >> > > >> >>>> > this to work.  The next thing that I'm going
> to
> >> do
> >> >>> is
> >> >>> > > > >> > > >> >>>> > figure out how to write this as a plugin and
> >> have it
> >> >>> > > > >> > > >> >>>> > install on a default
> >> >>> > > > project.
> >> >>> > > > >> > > >> >>>> > Also, right now the bridge doesn't seem to
> >> work, and
> >> >>> > > > >> > > >> >>>> > I don't know why exactly.  That being said,
> the
> >> >>> > > > >> > > >> fact
> >> >>> > > > >> > > >> >>>> > that I can choose which version of
> >> Chrome/Chromium
> >> >>> > > > >> > > >> >>>> > I'm running with
> >> >>> > > > >> > > >> a
> >> >>> > > > >> > > >> >>>> > single XML preference is HUGE.
> >> >>> > > > >> > > >> >>>> >
> >> >>> > > > >> > > >> >>>> > There's definitely a lot more work that needs
> >> to be
> >> >>> > > > >> > > >> >>>> > done, but as
> >> >>> > > > >> > > >> long
> >> >>> > > > >> > > >> >>>> > as we have something that we can fit into the
> >> >>> > > > >> > > >> >>>> > interface, we should
> >> >>> > > > >> > > >> be
> >> >>> > > > >> > > >> >>>> > able to put in things like GeckoView or other
> >> third
> >> >>> > > > >> > > >> >>>> > party
> >> >>> > > > >> > renderers.
> >> >>> > > > >> > > >> >>>> > The nightmare of being stuck with bullshit
> >> WebView
> >> >>> > > > >> > > >> >>>> > bugs may soon be over.
> >> >>> > > > >> > > >> >>>> >
> >> >>> > > > >> > > >> >>>> > On Wed, Mar 5, 2014 at 8:59 PM, Michal Mocny
> >> >>> > > > >> > > >> >>>> > <mm...@chromium.org>
> >> >>> > > > >> > > >> >>>> wrote:
> >> >>> > > > >> > > >> >>>> >>
> >> >>> https://github.com/crosswalk-project/crosswalk-cordo
> >> >>> > > > >> > > >> >>>> >> va
> >> >>> > > > >> > > >> >>>> >> -an
> >> >>> > > > >> > > >> >>>> >> droi
> >> >>> > > > >> > > >> >>>> >> d
> >> >>> > > > >> > > >> >>>> >>
> >> >>> > > > >> > > >> >>>> >> First patch they landed, which claims to
> have
> >> min
> >> >>> > > > >> > > >> >>>> >> viable xwalk
> >> >>> > > > >> > > >> webview:
> >> >>> > > > >> > > >> >>>> >>
> >> >>> > > > >> > > >> >>>>
> >> >>> > > > >> > > >>
> >> >>> https://github.com/crosswalk-project/crosswalk-cordova-andro
> >> >>> > > > >> > > >> id
> >> >>> > > > >> > > >> /co
> >> >>> > > > >> > > >> mmit
> >> >>> > > > >> > > >> /a04dedeb0204e7542d190312c6ae70c795a26e04
> >> >>> > > > >> > > >> >>>> >>
> >> >>> > > > >> > > >> >>>> >>
> >> >>> > > > >> > > >> >>>> >> On Wed, Mar 5, 2014 at 11:37 PM, Michal
> Mocny
> >> >>> > > > >> > > >> >>>> >> <mmocny@chromium.org
> >> >>> > > > >> > > >> >
> >> >>> > > > >> > > >> >>>> wrote:
> >> >>> > > > >> > > >> >>>> >>
> >> >>> > > > >> > > >> >>>> >>> I haven't looked yet, but did you see:
> >> >>> > > > >> > > >> >>>> >>>
> >> >>> https://crosswalk-project.org/#wiki/crosswalk-cordo
> >> >>> > > > >> > > >> >>>> >>> va
> >> >>> > > > >> > > >> >>>> >>> -an
> >> >>> > > > >> > > >> >>>> >>> droi
> >> >>> > > > >> > > >> >>>> >>> d
> >> >>> > > > >> > > >> >>>> >>>
> >> >>> > > > >> > > >> >>>> >>> ?
> >> >>> > > > >> > > >> >>>> >>>
> >> >>> > > > >> > > >> >>>> >>>
> >> >>> > > > >> > > >> >>>> >>> On Wed, Mar 5, 2014 at 10:20 PM, Andrew
> >> Grieve <
> >> >>> > > > >> > > >> agrieve@chromium.org
> >> >>> > > > >> > > >> >>>> >wrote:
> >> >>> > > > >> > > >> >>>> >>>
> >> >>> > > > >> > > >> >>>> >>>> First - very excited that you're working
> on
> >> this!
> >> >>> > > > >> > > >> >>>> >>>>
> >> >>> > > > >> > > >> >>>> >>>> Had a quick look. Not sure there's much to
> >> >>> > > > >> > > >> >>>> >>>> be
> >> >>> > gleaned
> >> >>> > > yet.
> >> >>> > > > >> > > >> >>>> >>>> Once
> >> >>> > > > >> > > >> you
> >> >>> > > > >> > > >> >>>> start
> >> >>> > > > >> > > >> >>>> >>>> in on hooking up x-walk's webview I think
> it
> >> will
> >> >>> > > > >> > > >> >>>> >>>> become more
> >> >>> > > > >> > > >> obvious
> >> >>> > > > >> > > >> >>>> what
> >> >>> > > > >> > > >> >>>> >>>> the interface should look like. E.g., does
> >> x-walk
> >> >>> > > > >> > > >> >>>> >>>> even have the
> >> >>> > > > >> > > >> >>>> concept of
> >> >>> > > > >> > > >> >>>> >>>> ChromeClient vs WebViewClient vs WebView?
> >> Also
> >> >>> > > > >> > > >> >>>> >>>> unsure whether the
> >> >>> > > > >> > > >> >>>> class
> >> >>> > > > >> > > >> >>>> >>>> should extend android.View as well as
> >> implement
> >> >>> > > > >> > > >> >>>> >>>> our
> >> >>> > > > >> > interface.
> >> >>> > > > >> > > >> E.g.
> >> >>> > > > >> > > >> >>>> >>>> alternative is to have a "getView()"
> method
> >> on
> >> >>> the
> >> >>> > > > >> > interface.
> >> >>> > > > >> > > >> Might
> >> >>> > > > >> > > >> >>>> help
> >> >>> > > > >> > > >> >>>> >>>> to
> >> >>> > > > >> > > >> >>>> >>>> cut down on file sizes, and API surface,
> but
> >> >>> > > > >> > > >> >>>> >>>> again, I'm not too
> >> >>> > > > >> > > >> sure.
> >> >>> > > > >> > > >> >>>> >>>>
> >> >>> > > > >> > > >> >>>> >>>> I've been pretty hesitant to touch
> existing
> >> >>> > > > >> > > >> >>>> >>>> exposed members
> >> >>> > > > >> > > >> (e.g. the
> >> >>> > > > >> > > >> >>>> >>>> public fields you were referring to) since
> >> >>> > > > >> > > >> >>>> >>>> touching anything
> >> >>> > > > >> > > >> public
> >> >>> > > > >> > > >> >>>> could
> >> >>> > > > >> > > >> >>>> >>>> break plugins. That said, maybe now is a
> >> >>> > > > >> > > >> >>>> >>>> good
> >> >>> time
> >> >>> > > > >> > > >> >>>> >>>> to @deprecate
> >> >>> > > > >> > > >> a
> >> >>> > > > >> > > >> >>>> bunch
> >> >>> > > > >> > > >> >>>> >>>> of
> >> >>> > > > >> > > >> >>>> >>>> them and either replace them with getters,
> >> >>> > > > >> > > >> >>>> >>>> or
> >> >>> just
> >> >>> > > > >> > > >> >>>> >>>> declare them
> >> >>> > > > >> > > >> to be
> >> >>> > > > >> > > >> >>>> not
> >> >>> > > > >> > > >> >>>> >>>> exposed to plugins.
> >> >>> > > > >> > > >> >>>> >>>>
> >> >>> > > > >> > > >> >>>> >>>>
> >> >>> > > > >> > > >> >>>> >>>> On Wed, Mar 5, 2014 at 6:57 PM, Joe Bowser
> >> >>> > > > >> > > >> >>>> >>>> <bo...@gmail.com>
> >> >>> > > > >> > > >> wrote:
> >> >>> > > > >> > > >> >>>> >>>>
> >> >>> > > > >> > > >> >>>> >>>> > So, after looking at the Crosswalk code
> >> again,
> >> >>> > > > >> > > >> >>>> >>>> > I've decided to
> >> >>> > > > >> > > >> take
> >> >>> > > > >> > > >> >>>> a
> >> >>> > > > >> > > >> >>>> >>>> > quick stab at making things pluggable.
>  I
> >> don't
> >> >>> > > > >> > > >> >>>> >>>> > have a lot to
> >> >>> > > > >> > > >> show
> >> >>> > > > >> > > >> >>>> for
> >> >>> > > > >> > > >> >>>> >>>> > it, but with the help of Eclipse (which
> is
> >> why
> >> >>> > > > >> > > >> >>>> >>>> > the generated interfaces look so screwed
> >> up), I
> >> >>> > > > >> > > >> >>>> >>>> > managed to create some
> >> >>> > > > >> > > >> interfaces
> >> >>> > > > >> > > >> >>>> so
> >> >>> > > > >> > > >> >>>> >>>> > we can start shoehorning in other
> browser
> >> >>> > renderers.
> >> >>> > > > >> > > >> >>>> >>>> >
> >> >>> > > > >> > > >> >>>> >>>> >
> >> >>> > > > >> > > >>
> >> >>> https://github.com/infil00p/cordova-android/tree/pluggable_w
> >> >>> > > > >> > > >> eb
> >> >>> > > > >> > > >> vie
> >> >>> > > > >> > > >> w
> >> >>> > > > >> > > >> >>>> >>>> >
> >> >>> > > > >> > > >> >>>> >>>> > I'm going to probably start with
> >> >>> > > > >> > > >> >>>> >>>> > Crosswalk,
> >> >>> > > > >> > > >> >>>> >>>> > because it's
> >> >>> > > > >> > > >> probably
> >> >>> > > > >> > > >> >>>> the
> >> >>> > > > >> > > >> >>>> >>>> > most mature primary candidate in the
> >> Android
> >> >>> > > > >> > > >> >>>> >>>> > Third-Party
> >> >>> > > > >> > > >> WebView
> >> >>> > > > >> > > >> >>>> >>>> > thing, and I'm pretty sure the GeckoView
> >> will
> >> >>> be
> >> >>> > > > >> > > >> >>>> >>>> > happening
> >> >>> > > > >> > > >> shortly
> >> >>> > > > >> > > >> >>>> >>>> > after.
> >> >>> > > > >> > > >> >>>> >>>> >
> >> >>> > > > >> > > >> >>>> >>>> > I don't know how this would work w.r.t.
> >> the CLI
> >> >>> > > > >> > > >> >>>> >>>> > or our
> >> >>> > > > >> > > >> workflow at
> >> >>> > > > >> > > >> >>>> >>>> > all, but at the moment, I really just
> want
> >> to
> >> >>> at
> >> >>> > > > >> > > >> >>>> >>>> > least start
> >> >>> > > > >> > > >> to have
> >> >>> > > > >> > > >> >>>> >>>> > some headway towards 4.x and PhoneGap
> day.
> >> >>> > > > >> > > >> >>>> >>>> >
> >> >>> > > > >> > > >> >>>> >>>> > What do people think of this so far? I'm
> >> going
> >> >>> > > > >> > > >> >>>> >>>> > to try to clean
> >> >>> > > > >> > > >> >>>> things
> >> >>> > > > >> > > >> >>>> >>>> > up a bit, since we've definitely done a
> >> lot of
> >> >>> > > > >> > > >> >>>> >>>> > things that
> >> >>> > > > >> > > >> would
> >> >>> > > > >> > > >> >>>> make
> >> >>> > > > >> > > >> >>>> >>>> > first year CS profs freak the hell out
> >> (i.e.
> >> >>> > > > >> > > >> >>>> >>>> > public members in
> >> >>> > > > >> > > >> >>>> public
> >> >>> > > > >> > > >> >>>> >>>> > objects w.r.t. PluginManager).
> >> >>> > > > >> > > >> >>>> >>>> >
> >> >>> > > > >> > > >> >>>> >>>> > Thoughts?
> >> >>> > > > >> > > >> >>>> >>>> >
> >> >>> > > > >> > > >> >>>> >>>> > Joe
> >> >>> > > > >> > > >> >>>> >>>> >
> >> >>> > > > >> > > >> >>>> >>>>
> >> >>> > > > >> > > >> >>>> >>>
> >> >>> > > > >> > > >> >>>> >>>
> >> >>> > > > >> > > >> >>>>
> >> >>> > > > >> > > >>
> >> >>> > > > >> >
> >> >>> >
> >> >>>
> >>
> >
> >
> >
> >
>

Re: [Android] Refactoring for different engines

[Joe Bowser <bo...@gmail.com>]

Hangout link for this morning?

On Fri, Apr 25, 2014 at 8:57 AM, Hu, Ningxin <ni...@intel.com> wrote:
>> Are people also going to use older (1-4) versions of Crosswalk? Or is the
>> plan to encourage people to only use either stable or beta versions?
>
>
>
> Crosswalk follows release cycles similar to Chromium. Current canary is
> Crosswalk-6, beta is 5 and stable is 4. The developers work on canary for
> new features. The public embedding API is a new feature for Crosswalk-6. If
> we want to release cordova-corsswalk-engine, the Crosswalk-6 would be the
> initial version.
>
>
>
>> That would be good to have -- I'd like to have some kind of warning that
>> new changes in the upstream project break the plugin :)
>
>
>
> +1. So the bot need to build and run mobilespec test suite. Do you know
> whether the bot can drive mobilespec via adb?
>
>
>
> Thanks,
>
> -ningxin
>
>
>
> From: iclelland@google.com [mailto:iclelland@google.com] On Behalf Of Ian
> Clelland
>
>
> Sent: Thursday, April 24, 2014 11:58 PM
> To: Hu, Ningxin
> Cc: Joe Bowser; dev@cordova.apache.org
> Subject: Re: [Android] Refactoring for different engines
>
>
>
>
>
>
>
> On Thu, Apr 24, 2014 at 5:27 AM, Hu, Ningxin <ni...@intel.com> wrote:
>
>> Mobilespec runs on my N4, with 10 failing tests: 3 in contacts; 7 in
>> file-transfer. Otherwise, things seem to be working pretty well.
>
>
>
> I checked out the latest code (@691fbce540) and build mbilespec with
> Crosswalk 6.35.127.0. However, it runs on the default Android WebView due to
> the InvocationTargetException when calling constructors of
> XWalkWebChromeClient and XWalkClient. I fixed it at:
> https://github.com/infil00p/cordova-crosswalk-engine/pull/6.
>
>
>
> This looks good, I've pulled that in locally.
>
>
>
>
>
> To make the plugins work on cordova-crosswalk-engine, it still needs to set
> correct webview client, chrome client and enable the setNetworkAvailable.
> I've sent another two PRs.
>
> https://github.com/infil00p/cordova-crosswalk-engine/pull/7
>
> https://github.com/infil00p/cordova-android/pull/3
>
>
>
> I think that we could do this differently. I would rather see the
> functionality of CordovaActivity.makeWebViewClient and
> CordovaActivity.makeChromeClient moved into the AndroidWebView class, and
> declared as methods in the CordovaWebView interface. Then we would override
> them in XWalkCordovaWebView to do the right thing.
>
>
>
> The extra string manipulation magic, and reflection, that this patch
> introduces, seems wrong to me. Considering that we already have methods in
> XWalkCordovaWebView to construct those objects, then we should let the
> XWalkCordovaWebView construct them.
>
>
>
> (I do like your method of iterating over the constructors, though -- I'm
> going to try to use that code in makeWebView as well)
>
>
>
>
>
> After these fixes (and with three fixes in plugins to use getPluginManager()
> interface), I can run the mobilespec "Run All Tests" on Crosswalk with all
> passed except Media test. The Media.js seems not be loaded. I didn't have
> chance to debug it yet.
>
>
>
> Ian and Joe, could you please review the PRs? I would appreciate that.
>
>
>
>> I've issued a pull request at
>> https://github.com/infil00p/cordova-crosswalk-engine/pull/5 for it -- I'm
>> not sure if there's a way to keep compatibility with last week's Crosswalk,
>> or if we'd even want to. (Ningxin, if you could take a look at that PR and
>> see if it makes sense, I'd appreciate it)
>
>
>
> The PR LGTM! Thanks for the update.
>
>
>
> For crosswalk embedding API compatibility, currently we track the master
> branch of Crosswalk (a.k.a Canary release channel), the embedding API in
> master is still under development. As planned, the Crosswalk-6 will be
> branched for beta in 4th May. In that branch, the embedding API will be
> stable and only accept bug fixing. So for cordova-crosswalk-engine, we can
> also have crosswalk-6 branch to track beta branch (later stable branch) and
> using master to track the latest crosswalk.
>
>
>
> Are people also going to use older (1-4) versions of Crosswalk? Or is the
> plan to encourage people to only use either stable or beta versions?
>
>
>
> I am even thinking about we can setup some bots (as buildbots in crosswalk)
> to track if any patches to crosswalk break the cordova-crosswalk-engine.
>
>
>
> Your thoughts?
>
>
>
> That would be good to have -- I'd like to have some kind of warning that new
> changes in the upstream project break the plugin :)
>
>
>
>
>
> Thanks,
>
> -ningxin
>
>
>
> From: iclelland@google.com [mailto:iclelland@google.com] On Behalf Of Ian
> Clelland
> Sent: Thursday, April 24, 2014 1:32 AM
> To: dev@cordova.apache.org
> Cc: Joe Bowser; Hu, Ningxin
>
>
> Subject: Re: [Android] Refactoring for different engines
>
>
>
> I've managed to get this up and running now -- great work on this, Joe!
>
>
>
> Mobilespec runs on my N4, with 10 failing tests: 3 in contacts; 7 in
> file-transfer. Otherwise, things seem to be working pretty well.
>
>
>
> I used a new build of Crosswalk, and found that the embedding API has
> changed since the weekend (when Ningxin's patches applied). I've issued a
> pull request at https://github.com/infil00p/cordova-crosswalk-engine/pull/5
> for it -- I'm not sure if there's a way to keep compatibility with last
> week's Crosswalk, or if we'd even want to. (Ningxin, if you could take a
> look at that PR and see if it makes sense, I'd appreciate it)
>
>
>
> Joe, I also had to patch the default constructor for XWalkCordovaWebView; it
> wasn't creating its own client objects, so it got the default ones, and most
> of the tests were failing because some component of the bridge wan't
> working. https://github.com/infil00p/cordova-crosswalk-engine/pull/4 is out
> for that.
>
>
>
> Count me in for the hangout -- this is exciting stuff
>
>
>
> Ian
>
>
>
> On Wed, Apr 23, 2014 at 10:26 AM, Brian LeRoux <b...@brian.io> wrote:
>
> Yup I'll track em down
>
> On Apr 23, 2014 7:17 AM, "Andrew Grieve" <ag...@chromium.org> wrote:
>
>> Does anyone have a contact at moz that we could invite?
>>
>> On Wed, Apr 23, 2014 at 10:09 AM, Andrew Grieve <ag...@chromium.org>
>> wrote:
>> > Depends on their interest level I think. Faster we can get this out
>> > the door the better. If we need to delay for geckoview, then I don't
>> > think we should gate on it, just release it after.
>> >
>> > On Wed, Apr 23, 2014 at 3:01 AM, Tommy Williams <to...@devgeeks.org>
>> wrote:
>> >> More engines, more better...
>> >> On 23 Apr 2014 16:32, "Joe Bowser" <bo...@gmail.com> wrote:
>> >>
>> >>> Hey
>> >>>
>> >>> A Hangout would have to happen on Friday at the earliest.  It'd be
>> good if
>> >>> we could get someone from Mozilla on the hangout as well.  I haven't
>> gotten
>> >>> MozillaView (GeckoView with Cordova methods) fully working yet.  For
>> some
>> >>> reason it's not rendering on the screen.
>> >>>
>> >>> Ideally it'd be cool to have at least two options when this feature
>> finally
>> >>> lands.
>> >>>
>> >>> What do other people think?
>> >>>
>> >>> Joe
>> >>> On 22 Apr 2014 20:06, "Hu, Ningxin" <ni...@intel.com> wrote:
>> >>>
>> >>> > Joe,
>> >>> >
>> >>> > Thanks for your review and merge the PRs.
>> >>> >
>> >>> > To pluggable webview interest group:
>> >>> > Are we OK to setup a hangout this week for initial introduction and
>> >>> > discussion of next steps?
>> >>> >
>> >>> > Thanks,
>> >>> > -ningxin
>> >>> >
>> >>> > > -----Original Message-----
>> >>> > > From: Hu, Ningxin [mailto:ningxin.hu@intel.com]
>> >>> > > Sent: Tuesday, April 22, 2014 4:04 PM
>> >>> > > To: dev@cordova.apache.org
>> >>> > > Subject: RE: [Android] Refactoring for different engines
>> >>> > >
>> >>> > > The PoC is great! Quite excited about the direction!
>> >>> > >
>> >>> > > I've sent a PR to update the cordova-crosswalk-engine to latest
>> >>> crosswalk
>> >>> > > embedding API. It works with xwalk_core_library at 6.35.124.0.
>> >>> > >
>> >>> > > I've also changed the CordovaWebView interface slightly (adding
>> >>> > getView() API)
>> >>> > > to allow XWalkCordovaWebView to composite a XWalkView instead of
>> >>> > extending
>> >>> > > it. It resolves some API naming issues for XWalkView case.
>> >>> > >
>> >>> > > Please review them at:
>> >>> > > https://github.com/infil00p/cordova-crosswalk-engine/pull/3
>> >>> > > https://github.com/infil00p/cordova-android/pull/2
>> >>> > >
>> >>> > > Thanks,
>> >>> > > -ningxin
>> >>> > >
>> >>> > > > -----Original Message-----
>> >>> > > > From: Joe Bowser [mailto:bowserj@gmail.com]
>> >>> > > > Sent: Friday, April 11, 2014 12:45 AM
>> >>> > > > To: dev
>> >>> > > > Subject: Re: [Android] Refactoring for different engines
>> >>> > > >
>> >>> > > > Yeah, I'd be cool with setting up a hangout.  Everyone should
>> take a
>> >>> > > > look at the PoC, I've basically distilled it down to four or
>> >>> > > > five
>> >>> > > > classes so far, but with some work, we may be able to get it
>> down to
>> >>> > > > three.  Due to legacy, we're pretty stuck with the Android
>> WebView
>> >>> API
>> >>> > calls,
>> >>> > > but these can probably be modified.
>> >>> > > >
>> >>> > > > It'd be good to get Mozilla people on the call as well, since
>> they
>> >>> > > > have their WebView as well.
>> >>> > > >
>> >>> > > > On Thu, Apr 10, 2014 at 9:38 AM, Hu, Ningxin <
>> ningxin.hu@intel.com>
>> >>> > wrote:
>> >>> > > > > Hangout would be a good idea.
>> >>> > > > >
>> >>> > > > > FYI, I will be off next week. How about the week after next?
>> If it
>> >>> > > > > works, please
>> >>> > > > feel free to schedule one and count me in.
>> >>> > > > >
>> >>> > > > > Thanks,
>> >>> > > > > -ningxin
>> >>> > > > >
>> >>> > > > >> -----Original Message-----
>> >>> > > > >> From: mmocny@google.com [mailto:mmocny@google.com] On Behalf
>> Of
>> >>> > > > >> Michal Mocny
>> >>> > > > >> Sent: Tuesday, April 08, 2014 11:39 PM
>> >>> > > > >> To: dev
>> >>> > > > >> Subject: Re: [Android] Refactoring for different engines
>> >>> > > > >>
>> >>> > > > >> Would it be alright to set up a Hangout some time to
>> >>> > > > >> introduce
>> >>> > everyone?
>> >>> > > > >>
>> >>> > > > >> Joe has been leading the effort here, but there are other
>> cordova
>> >>> > > > >> contributors for whom this is top priority.  It would be nice
>> if
>> >>> we
>> >>> > > > >> could all meet to say hello and make sure we are all going in
>> the
>> >>> > > > >> right
>> >>> > > > direction.
>> >>> > > > >>
>> >>> > > > >> Quite exciting!
>> >>> > > > >>
>> >>> > > > >> -Michal
>> >>> > > > >>
>> >>> > > > >>
>> >>> > > > >> On Tue, Apr 8, 2014 at 10:56 AM, Hu, Ningxin <
>> >>> ningxin.hu@intel.com>
>> >>> > > wrote:
>> >>> > > > >>
>> >>> > > > >> > Joe, thanks for this. I am very excited.
>> >>> > > > >> >
>> >>> > > > >> > FYI. Crosswalk team is working on refactoring the WebView
>> API to
>> >>> > > > >> > support embedding usage better [1]. (Previously the layer
>> API
>> >>> was
>> >>> > > > >> > not exposed as public usage).
>> >>> > > > >> >
>> >>> > > > >> > I would like to review the PoC and work with you to get
>> >>> Crosswalk
>> >>> > > > >> > fits into the pluggable WebView architecture.
>> >>> > > > >> >
>> >>> > > > >> > Thanks,
>> >>> > > > >> > -ningxin
>> >>> > > > >> >
>> >>> > > > >> > > -----Original Message-----
>> >>> > > > >> > > From: Joe Bowser [mailto:bowserj@gmail.com]
>> >>> > > > >> > > Sent: Wednesday, March 19, 2014 7:08 AM
>> >>> > > > >> > > To: dev
>> >>> > > > >> > > Subject: Re: [Android] Refactoring for different engines
>> >>> > > > >> > >
>> >>> > > > >> > > Hey
>> >>> > > > >> > >
>> >>> > > > >> > > After debugging, I did some minor updates to the plugin
>> >>> README.
>> >>> > > > >> > > It
>> >>> > > > >> > should be
>> >>> > > > >> > > easier to get this up and running, although there's still
>> the
>> >>> > > > >> > > issue of
>> >>> > > > >> > after-install
>> >>> > > > >> > > hooks and the relative path weirdness with the Crosswalk
>> >>> > Library itself.
>> >>> > > > >> > >
>> >>> > > > >> > > It still doesn't support the CLI at all, but it should be
>> >>> there
>> >>> > > > >> > > with the
>> >>> > > > >> > old flow.
>> >>> > > > >> > >
>> >>> > > > >> > > On Mon, Mar 17, 2014 at 1:14 PM, Michal Mocny
>> >>> > > > >> > > <mm...@chromium.org>
>> >>> > > > >> > > wrote:
>> >>> > > > >> > > > (Sorry Joe, Googlers are down in California and way
>> busy.
>> >>> > > > >> > > > Will be back in a week.  Super excited about this,
>> though.)
>> >>> > > > >> > > >
>> >>> > > > >> > > > -Michal
>> >>> > > > >> > > >
>> >>> > > > >> > > >
>> >>> > > > >> > > > On Mon, Mar 17, 2014 at 2:53 PM, Joe Bowser
>> >>> > > > >> > > > <bo...@gmail.com>
>> >>> > > > >> wrote:
>> >>> > > > >> > > >
>> >>> > > > >> > > >> Reviving this thread!
>> >>> > > > >> > > >>
>> >>> > > > >> > > >> Can other people look at this, and see if/when we
>> should
>> >>> > land this?
>> >>> > > > >> > > >> I know that I have to re-write the tests still, but I
>> would
>> >>> > > > >> > > >> like some feedback before merging it in.  Also, it'd
>> >>> > > > >> > > >> be
>> >>> > > > >> > > >> super awesome if other people could try and make a
>> WebView
>> >>> > > > >> > > >> based on the interfaces and recommend which methods
>> should
>> >>> > > > >> > > >> die.  I want to get this released in the next month or
>> so,
>> >>> > > > >> > > >> so any time and feedback would be greatly appreciated.
>> >>> > > > >> > > >>
>> >>> > > > >> > > >> Thanks
>> >>> > > > >> > > >>
>> >>> > > > >> > > >> On Thu, Mar 13, 2014 at 3:50 PM, Joe Bowser
>> >>> > > > >> > > >> <bo...@gmail.com>
>> >>> > > > >> > wrote:
>> >>> > > > >> > > >> > Hey, I created the following today to track various
>> >>> > > > >> > > >> > WebView
>> >>> > > > >> > progresses:
>> >>> > > > >> > > >> > https://issues.apache.org/jira/browse/CB-6246
>> >>> > > > >> > > >> >
>> >>> > > > >> > > >> > I also have this repo created.  The licensing is
>> ugly as
>> >>> > > > >> > > >> > all crap, but it's a Proof-Of-Concept:
>> >>> > > > >> > > >> > https://github.com/infil00p/cordova-crosswalk-engine
>> >>> > > > >> > > >> >
>> >>> > > > >> > > >> > If I can get some help getting plugman to just load
>> >>> > > > >> > > >> > Crosswalk, it'll
>> >>> > > > >> > > >> look hawt.
>> >>> > > > >> > > >> >
>> >>> > > > >> > > >> > BTW: We should probably get this ready to go into
>> Android
>> >>> > > > >> > > >> > in the next two months and deprecate the setProperty
>> >>> > > > >> > > >> > methods, since all properties should be preferences
>> in
>> >>> > config.xml
>> >>> > > now.
>> >>> > > > >> > > >> >
>> >>> > > > >> > > >> > On Mon, Mar 10, 2014 at 2:42 PM, Joe Bowser
>> >>> > > > >> > > >> > <bo...@gmail.com>
>> >>> > > > >> > > wrote:
>> >>> > > > >> > > >> >> Perhaps. There would be additional benefits to this
>> >>> > > > >> > > >> >> approach, namely fixes being added to that platform
>> more
>> >>> > > > >> > > >> >> quickly.  I'll probably take a look at that once I
>> have
>> >>> > > > >> > > >> >> Crosswalk
>> >>> > > > finalized.
>> >>> > > > >> > > >> >>
>> >>> > > > >> > > >> >> On Mon, Mar 10, 2014 at 9:49 AM, Brian LeRoux
>> >>> > > > >> > > >> >> <b...@brian.io>
>> >>> > > > wrote:
>> >>> > > > >> > > >> >>> this is great stuff
>> >>> > > > >> > > >> >>>
>> >>> > > > >> > > >> >>> do we think it may be possible to bring in amazon
>> >>> fireos
>> >>> > > > >> > > >> >>> stuff
>> >>> > > > >> > > >> eventually
>> >>> > > > >> > > >> >>> too?
>> >>> > > > >> > > >> >>>
>> >>> > > > >> > > >> >>>
>> >>> > > > >> > > >> >>> On Fri, Mar 7, 2014 at 3:22 PM, Joe Bowser
>> >>> > > > >> > > >> >>> <bo...@gmail.com>
>> >>> > > > >> > wrote:
>> >>> > > > >> > > >> >>>
>> >>> > > > >> > > >> >>>> BTW: I committed it in my repo, not the main
>> Apache
>> >>> one.
>> >>> > > > >> > > >> >>>>
>> >>> > > > >> > > >> >>>> On Fri, Mar 7, 2014 at 3:21 PM, Joe Bowser
>> >>> > > > >> > > >> >>>> <bo...@gmail.com>
>> >>> > > > >> > > wrote:
>> >>> > > > >> > > >> >>>> > Hey
>> >>> > > > >> > > >> >>>> >
>> >>> > > > >> > > >> >>>> > I just committed some code based on their
>> WebView
>> >>> > > > >> > > >> >>>> > modifications that allows you to choose your
>> >>> renderer
>> >>> > > > >> > > >> >>>> > in the
>> >>> > > > >> > config file
>> >>> > > > >> > > with this:
>> >>> > > > >> > > >> >>>> >
>> >>> > > > >> > > >> >>>> >     <preference name="webView"
>> >>> > > > >> > > >> >>>> >
>> >>> value="org.apache.cordova.engine.crosswalk.XWalkCordo
>> >>> > > > >> > > >> >>>> > va
>> >>> > > > >> > > >> >>>> > Web
>> >>> > > > >> > > >> >>>> > View
>> >>> > > > >> > > >> >>>> > " />
>> >>> > > > >> > > >> >>>> >
>> >>> > > > >> > > >> >>>> > You currently have to copy over the *.pak file
>> and
>> >>> > > > >> > > >> >>>> > the jsapi from a Crosswalk Example project to
>> get
>> >>> > > > >> > > >> >>>> > this to work.  The next thing that I'm going to
>> do
>> >>> is
>> >>> > > > >> > > >> >>>> > figure out how to write this as a plugin and
>> have it
>> >>> > > > >> > > >> >>>> > install on a default
>> >>> > > > project.
>> >>> > > > >> > > >> >>>> > Also, right now the bridge doesn't seem to
>> work, and
>> >>> > > > >> > > >> >>>> > I don't know why exactly.  That being said, the
>> >>> > > > >> > > >> fact
>> >>> > > > >> > > >> >>>> > that I can choose which version of
>> Chrome/Chromium
>> >>> > > > >> > > >> >>>> > I'm running with
>> >>> > > > >> > > >> a
>> >>> > > > >> > > >> >>>> > single XML preference is HUGE.
>> >>> > > > >> > > >> >>>> >
>> >>> > > > >> > > >> >>>> > There's definitely a lot more work that needs
>> to be
>> >>> > > > >> > > >> >>>> > done, but as
>> >>> > > > >> > > >> long
>> >>> > > > >> > > >> >>>> > as we have something that we can fit into the
>> >>> > > > >> > > >> >>>> > interface, we should
>> >>> > > > >> > > >> be
>> >>> > > > >> > > >> >>>> > able to put in things like GeckoView or other
>> third
>> >>> > > > >> > > >> >>>> > party
>> >>> > > > >> > renderers.
>> >>> > > > >> > > >> >>>> > The nightmare of being stuck with bullshit
>> WebView
>> >>> > > > >> > > >> >>>> > bugs may soon be over.
>> >>> > > > >> > > >> >>>> >
>> >>> > > > >> > > >> >>>> > On Wed, Mar 5, 2014 at 8:59 PM, Michal Mocny
>> >>> > > > >> > > >> >>>> > <mm...@chromium.org>
>> >>> > > > >> > > >> >>>> wrote:
>> >>> > > > >> > > >> >>>> >>
>> >>> https://github.com/crosswalk-project/crosswalk-cordo
>> >>> > > > >> > > >> >>>> >> va
>> >>> > > > >> > > >> >>>> >> -an
>> >>> > > > >> > > >> >>>> >> droi
>> >>> > > > >> > > >> >>>> >> d
>> >>> > > > >> > > >> >>>> >>
>> >>> > > > >> > > >> >>>> >> First patch they landed, which claims to have
>> min
>> >>> > > > >> > > >> >>>> >> viable xwalk
>> >>> > > > >> > > >> webview:
>> >>> > > > >> > > >> >>>> >>
>> >>> > > > >> > > >> >>>>
>> >>> > > > >> > > >>
>> >>> https://github.com/crosswalk-project/crosswalk-cordova-andro
>> >>> > > > >> > > >> id
>> >>> > > > >> > > >> /co
>> >>> > > > >> > > >> mmit
>> >>> > > > >> > > >> /a04dedeb0204e7542d190312c6ae70c795a26e04
>> >>> > > > >> > > >> >>>> >>
>> >>> > > > >> > > >> >>>> >>
>> >>> > > > >> > > >> >>>> >> On Wed, Mar 5, 2014 at 11:37 PM, Michal Mocny
>> >>> > > > >> > > >> >>>> >> <mmocny@chromium.org
>> >>> > > > >> > > >> >
>> >>> > > > >> > > >> >>>> wrote:
>> >>> > > > >> > > >> >>>> >>
>> >>> > > > >> > > >> >>>> >>> I haven't looked yet, but did you see:
>> >>> > > > >> > > >> >>>> >>>
>> >>> https://crosswalk-project.org/#wiki/crosswalk-cordo
>> >>> > > > >> > > >> >>>> >>> va
>> >>> > > > >> > > >> >>>> >>> -an
>> >>> > > > >> > > >> >>>> >>> droi
>> >>> > > > >> > > >> >>>> >>> d
>> >>> > > > >> > > >> >>>> >>>
>> >>> > > > >> > > >> >>>> >>> ?
>> >>> > > > >> > > >> >>>> >>>
>> >>> > > > >> > > >> >>>> >>>
>> >>> > > > >> > > >> >>>> >>> On Wed, Mar 5, 2014 at 10:20 PM, Andrew
>> Grieve <
>> >>> > > > >> > > >> agrieve@chromium.org
>> >>> > > > >> > > >> >>>> >wrote:
>> >>> > > > >> > > >> >>>> >>>
>> >>> > > > >> > > >> >>>> >>>> First - very excited that you're working on
>> this!
>> >>> > > > >> > > >> >>>> >>>>
>> >>> > > > >> > > >> >>>> >>>> Had a quick look. Not sure there's much to
>> >>> > > > >> > > >> >>>> >>>> be
>> >>> > gleaned
>> >>> > > yet.
>> >>> > > > >> > > >> >>>> >>>> Once
>> >>> > > > >> > > >> you
>> >>> > > > >> > > >> >>>> start
>> >>> > > > >> > > >> >>>> >>>> in on hooking up x-walk's webview I think it
>> will
>> >>> > > > >> > > >> >>>> >>>> become more
>> >>> > > > >> > > >> obvious
>> >>> > > > >> > > >> >>>> what
>> >>> > > > >> > > >> >>>> >>>> the interface should look like. E.g., does
>> x-walk
>> >>> > > > >> > > >> >>>> >>>> even have the
>> >>> > > > >> > > >> >>>> concept of
>> >>> > > > >> > > >> >>>> >>>> ChromeClient vs WebViewClient vs WebView?
>> Also
>> >>> > > > >> > > >> >>>> >>>> unsure whether the
>> >>> > > > >> > > >> >>>> class
>> >>> > > > >> > > >> >>>> >>>> should extend android.View as well as
>> implement
>> >>> > > > >> > > >> >>>> >>>> our
>> >>> > > > >> > interface.
>> >>> > > > >> > > >> E.g.
>> >>> > > > >> > > >> >>>> >>>> alternative is to have a "getView()" method
>> on
>> >>> the
>> >>> > > > >> > interface.
>> >>> > > > >> > > >> Might
>> >>> > > > >> > > >> >>>> help
>> >>> > > > >> > > >> >>>> >>>> to
>> >>> > > > >> > > >> >>>> >>>> cut down on file sizes, and API surface, but
>> >>> > > > >> > > >> >>>> >>>> again, I'm not too
>> >>> > > > >> > > >> sure.
>> >>> > > > >> > > >> >>>> >>>>
>> >>> > > > >> > > >> >>>> >>>> I've been pretty hesitant to touch existing
>> >>> > > > >> > > >> >>>> >>>> exposed members
>> >>> > > > >> > > >> (e.g. the
>> >>> > > > >> > > >> >>>> >>>> public fields you were referring to) since
>> >>> > > > >> > > >> >>>> >>>> touching anything
>> >>> > > > >> > > >> public
>> >>> > > > >> > > >> >>>> could
>> >>> > > > >> > > >> >>>> >>>> break plugins. That said, maybe now is a
>> >>> > > > >> > > >> >>>> >>>> good
>> >>> time
>> >>> > > > >> > > >> >>>> >>>> to @deprecate
>> >>> > > > >> > > >> a
>> >>> > > > >> > > >> >>>> bunch
>> >>> > > > >> > > >> >>>> >>>> of
>> >>> > > > >> > > >> >>>> >>>> them and either replace them with getters,
>> >>> > > > >> > > >> >>>> >>>> or
>> >>> just
>> >>> > > > >> > > >> >>>> >>>> declare them
>> >>> > > > >> > > >> to be
>> >>> > > > >> > > >> >>>> not
>> >>> > > > >> > > >> >>>> >>>> exposed to plugins.
>> >>> > > > >> > > >> >>>> >>>>
>> >>> > > > >> > > >> >>>> >>>>
>> >>> > > > >> > > >> >>>> >>>> On Wed, Mar 5, 2014 at 6:57 PM, Joe Bowser
>> >>> > > > >> > > >> >>>> >>>> <bo...@gmail.com>
>> >>> > > > >> > > >> wrote:
>> >>> > > > >> > > >> >>>> >>>>
>> >>> > > > >> > > >> >>>> >>>> > So, after looking at the Crosswalk code
>> again,
>> >>> > > > >> > > >> >>>> >>>> > I've decided to
>> >>> > > > >> > > >> take
>> >>> > > > >> > > >> >>>> a
>> >>> > > > >> > > >> >>>> >>>> > quick stab at making things pluggable.  I
>> don't
>> >>> > > > >> > > >> >>>> >>>> > have a lot to
>> >>> > > > >> > > >> show
>> >>> > > > >> > > >> >>>> for
>> >>> > > > >> > > >> >>>> >>>> > it, but with the help of Eclipse (which is
>> why
>> >>> > > > >> > > >> >>>> >>>> > the generated interfaces look so screwed
>> up), I
>> >>> > > > >> > > >> >>>> >>>> > managed to create some
>> >>> > > > >> > > >> interfaces
>> >>> > > > >> > > >> >>>> so
>> >>> > > > >> > > >> >>>> >>>> > we can start shoehorning in other browser
>> >>> > renderers.
>> >>> > > > >> > > >> >>>> >>>> >
>> >>> > > > >> > > >> >>>> >>>> >
>> >>> > > > >> > > >>
>> >>> https://github.com/infil00p/cordova-android/tree/pluggable_w
>> >>> > > > >> > > >> eb
>> >>> > > > >> > > >> vie
>> >>> > > > >> > > >> w
>> >>> > > > >> > > >> >>>> >>>> >
>> >>> > > > >> > > >> >>>> >>>> > I'm going to probably start with
>> >>> > > > >> > > >> >>>> >>>> > Crosswalk,
>> >>> > > > >> > > >> >>>> >>>> > because it's
>> >>> > > > >> > > >> probably
>> >>> > > > >> > > >> >>>> the
>> >>> > > > >> > > >> >>>> >>>> > most mature primary candidate in the
>> Android
>> >>> > > > >> > > >> >>>> >>>> > Third-Party
>> >>> > > > >> > > >> WebView
>> >>> > > > >> > > >> >>>> >>>> > thing, and I'm pretty sure the GeckoView
>> will
>> >>> be
>> >>> > > > >> > > >> >>>> >>>> > happening
>> >>> > > > >> > > >> shortly
>> >>> > > > >> > > >> >>>> >>>> > after.
>> >>> > > > >> > > >> >>>> >>>> >
>> >>> > > > >> > > >> >>>> >>>> > I don't know how this would work w.r.t.
>> the CLI
>> >>> > > > >> > > >> >>>> >>>> > or our
>> >>> > > > >> > > >> workflow at
>> >>> > > > >> > > >> >>>> >>>> > all, but at the moment, I really just want
>> to
>> >>> at
>> >>> > > > >> > > >> >>>> >>>> > least start
>> >>> > > > >> > > >> to have
>> >>> > > > >> > > >> >>>> >>>> > some headway towards 4.x and PhoneGap day.
>> >>> > > > >> > > >> >>>> >>>> >
>> >>> > > > >> > > >> >>>> >>>> > What do people think of this so far? I'm
>> going
>> >>> > > > >> > > >> >>>> >>>> > to try to clean
>> >>> > > > >> > > >> >>>> things
>> >>> > > > >> > > >> >>>> >>>> > up a bit, since we've definitely done a
>> lot of
>> >>> > > > >> > > >> >>>> >>>> > things that
>> >>> > > > >> > > >> would
>> >>> > > > >> > > >> >>>> make
>> >>> > > > >> > > >> >>>> >>>> > first year CS profs freak the hell out
>> (i.e.
>> >>> > > > >> > > >> >>>> >>>> > public members in
>> >>> > > > >> > > >> >>>> public
>> >>> > > > >> > > >> >>>> >>>> > objects w.r.t. PluginManager).
>> >>> > > > >> > > >> >>>> >>>> >
>> >>> > > > >> > > >> >>>> >>>> > Thoughts?
>> >>> > > > >> > > >> >>>> >>>> >
>> >>> > > > >> > > >> >>>> >>>> > Joe
>> >>> > > > >> > > >> >>>> >>>> >
>> >>> > > > >> > > >> >>>> >>>>
>> >>> > > > >> > > >> >>>> >>>
>> >>> > > > >> > > >> >>>> >>>
>> >>> > > > >> > > >> >>>>
>> >>> > > > >> > > >>
>> >>> > > > >> >
>> >>> >
>> >>>
>>
>
>
>
>

RE: [Android] Refactoring for different engines

["Hu, Ningxin" <ni...@intel.com>]

> Are people also going to use older (1-4) versions of Crosswalk? Or is the plan to encourage people to only use either stable or beta versions?

Crosswalk follows release cycles similar to Chromium. Current canary is Crosswalk-6, beta is 5 and stable is 4. The developers work on canary for new features. The public embedding API is a new feature for Crosswalk-6. If we want to release cordova-corsswalk-engine, the Crosswalk-6 would be the initial version.

> That would be good to have -- I'd like to have some kind of warning that new changes in the upstream project break the plugin :)

+1. So the bot need to build and run mobilespec test suite. Do you know whether the bot can drive mobilespec via adb?

Thanks,
-ningxin

From: iclelland@google.com [mailto:iclelland@google.com] On Behalf Of Ian Clelland
Sent: Thursday, April 24, 2014 11:58 PM
To: Hu, Ningxin
Cc: Joe Bowser; dev@cordova.apache.org
Subject: Re: [Android] Refactoring for different engines



On Thu, Apr 24, 2014 at 5:27 AM, Hu, Ningxin <ni...@intel.com>> wrote:
> Mobilespec runs on my N4, with 10 failing tests: 3 in contacts; 7 in file-transfer. Otherwise, things seem to be working pretty well.

I checked out the latest code (@691fbce540) and build mbilespec with Crosswalk 6.35.127.0. However, it runs on the default Android WebView due to the InvocationTargetException when calling constructors of XWalkWebChromeClient and XWalkClient. I fixed it at: https://github.com/infil00p/cordova-crosswalk-engine/pull/6.

This looks good, I've pulled that in locally.


To make the plugins work on cordova-crosswalk-engine, it still needs to set correct webview client, chrome client and enable the setNetworkAvailable. I've sent another two PRs.
https://github.com/infil00p/cordova-crosswalk-engine/pull/7
https://github.com/infil00p/cordova-android/pull/3

I think that we could do this differently. I would rather see the functionality of CordovaActivity.makeWebViewClient and CordovaActivity.makeChromeClient moved into the AndroidWebView class, and declared as methods in the CordovaWebView interface. Then we would override them in XWalkCordovaWebView to do the right thing.

The extra string manipulation magic, and reflection, that this patch introduces, seems wrong to me. Considering that we already have methods in XWalkCordovaWebView to construct those objects, then we should let the XWalkCordovaWebView construct them.

(I do like your method of iterating over the constructors, though -- I'm going to try to use that code in makeWebView as well)


After these fixes (and with three fixes in plugins to use getPluginManager() interface), I can run the mobilespec "Run All Tests" on Crosswalk with all passed except Media test. The Media.js seems not be loaded. I didn't have chance to debug it yet.

Ian and Joe, could you please review the PRs? I would appreciate that.

> I've issued a pull request at https://github.com/infil00p/cordova-crosswalk-engine/pull/5 for it -- I'm not sure if there's a way to keep compatibility with last week's Crosswalk, or if we'd even want to. (Ningxin, if you could take a look at that PR and see if it makes sense, I'd appreciate it)

The PR LGTM! Thanks for the update.

For crosswalk embedding API compatibility, currently we track the master branch of Crosswalk (a.k.a Canary release channel), the embedding API in master is still under development. As planned, the Crosswalk-6 will be branched for beta in 4th May. In that branch, the embedding API will be stable and only accept bug fixing. So for cordova-crosswalk-engine, we can also have crosswalk-6 branch to track beta branch (later stable branch) and using master to track the latest crosswalk.

Are people also going to use older (1-4) versions of Crosswalk? Or is the plan to encourage people to only use either stable or beta versions?

I am even thinking about we can setup some bots (as buildbots in crosswalk) to track if any patches to crosswalk break the cordova-crosswalk-engine.

Your thoughts?

That would be good to have -- I'd like to have some kind of warning that new changes in the upstream project break the plugin :)


Thanks,
-ningxin

From: iclelland@google.com<ma...@google.com> [mailto:iclelland@google.com<ma...@google.com>] On Behalf Of Ian Clelland
Sent: Thursday, April 24, 2014 1:32 AM
To: dev@cordova.apache.org<ma...@cordova.apache.org>
Cc: Joe Bowser; Hu, Ningxin

Subject: Re: [Android] Refactoring for different engines

I've managed to get this up and running now -- great work on this, Joe!

Mobilespec runs on my N4, with 10 failing tests: 3 in contacts; 7 in file-transfer. Otherwise, things seem to be working pretty well.

I used a new build of Crosswalk, and found that the embedding API has changed since the weekend (when Ningxin's patches applied). I've issued a pull request at https://github.com/infil00p/cordova-crosswalk-engine/pull/5 for it -- I'm not sure if there's a way to keep compatibility with last week's Crosswalk, or if we'd even want to. (Ningxin, if you could take a look at that PR and see if it makes sense, I'd appreciate it)

Joe, I also had to patch the default constructor for XWalkCordovaWebView; it wasn't creating its own client objects, so it got the default ones, and most of the tests were failing because some component of the bridge wan't working. https://github.com/infil00p/cordova-crosswalk-engine/pull/4 is out for that.

Count me in for the hangout -- this is exciting stuff

Ian

On Wed, Apr 23, 2014 at 10:26 AM, Brian LeRoux <b@...@brian.io>> wrote:
Yup I'll track em down
On Apr 23, 2014 7:17 AM, "Andrew Grieve" <ag...@chromium.org>> wrote:

> Does anyone have a contact at moz that we could invite?
>
> On Wed, Apr 23, 2014 at 10:09 AM, Andrew Grieve <ag...@chromium.org>>
> wrote:
> > Depends on their interest level I think. Faster we can get this out
> > the door the better. If we need to delay for geckoview, then I don't
> > think we should gate on it, just release it after.
> >
> > On Wed, Apr 23, 2014 at 3:01 AM, Tommy Williams <to...@devgeeks.org>>
> wrote:
> >> More engines, more better...
> >> On 23 Apr 2014 16:32, "Joe Bowser" <bo...@gmail.com>> wrote:
> >>
> >>> Hey
> >>>
> >>> A Hangout would have to happen on Friday at the earliest.  It'd be
> good if
> >>> we could get someone from Mozilla on the hangout as well.  I haven't
> gotten
> >>> MozillaView (GeckoView with Cordova methods) fully working yet.  For
> some
> >>> reason it's not rendering on the screen.
> >>>
> >>> Ideally it'd be cool to have at least two options when this feature
> finally
> >>> lands.
> >>>
> >>> What do other people think?
> >>>
> >>> Joe
> >>> On 22 Apr 2014 20:06, "Hu, Ningxin" <ni...@intel.com>> wrote:
> >>>
> >>> > Joe,
> >>> >
> >>> > Thanks for your review and merge the PRs.
> >>> >
> >>> > To pluggable webview interest group:
> >>> > Are we OK to setup a hangout this week for initial introduction and
> >>> > discussion of next steps?
> >>> >
> >>> > Thanks,
> >>> > -ningxin
> >>> >
> >>> > > -----Original Message-----
> >>> > > From: Hu, Ningxin [mailto:ningxin.hu@intel.com<ma...@intel.com>]
> >>> > > Sent: Tuesday, April 22, 2014 4:04 PM
> >>> > > To: dev@cordova.apache.org<ma...@cordova.apache.org>
> >>> > > Subject: RE: [Android] Refactoring for different engines
> >>> > >
> >>> > > The PoC is great! Quite excited about the direction!
> >>> > >
> >>> > > I've sent a PR to update the cordova-crosswalk-engine to latest
> >>> crosswalk
> >>> > > embedding API. It works with xwalk_core_library at 6.35.124.0.
> >>> > >
> >>> > > I've also changed the CordovaWebView interface slightly (adding
> >>> > getView() API)
> >>> > > to allow XWalkCordovaWebView to composite a XWalkView instead of
> >>> > extending
> >>> > > it. It resolves some API naming issues for XWalkView case.
> >>> > >
> >>> > > Please review them at:
> >>> > > https://github.com/infil00p/cordova-crosswalk-engine/pull/3
> >>> > > https://github.com/infil00p/cordova-android/pull/2
> >>> > >
> >>> > > Thanks,
> >>> > > -ningxin
> >>> > >
> >>> > > > -----Original Message-----
> >>> > > > From: Joe Bowser [mailto:bowserj@gmail.com<ma...@gmail.com>]
> >>> > > > Sent: Friday, April 11, 2014 12:45 AM
> >>> > > > To: dev
> >>> > > > Subject: Re: [Android] Refactoring for different engines
> >>> > > >
> >>> > > > Yeah, I'd be cool with setting up a hangout.  Everyone should
> take a
> >>> > > > look at the PoC, I've basically distilled it down to four or five
> >>> > > > classes so far, but with some work, we may be able to get it
> down to
> >>> > > > three.  Due to legacy, we're pretty stuck with the Android
> WebView
> >>> API
> >>> > calls,
> >>> > > but these can probably be modified.
> >>> > > >
> >>> > > > It'd be good to get Mozilla people on the call as well, since
> they
> >>> > > > have their WebView as well.
> >>> > > >
> >>> > > > On Thu, Apr 10, 2014 at 9:38 AM, Hu, Ningxin <
> ningxin.hu@intel.com<ma...@intel.com>>
> >>> > wrote:
> >>> > > > > Hangout would be a good idea.
> >>> > > > >
> >>> > > > > FYI, I will be off next week. How about the week after next?
> If it
> >>> > > > > works, please
> >>> > > > feel free to schedule one and count me in.
> >>> > > > >
> >>> > > > > Thanks,
> >>> > > > > -ningxin
> >>> > > > >
> >>> > > > >> -----Original Message-----
> >>> > > > >> From: mmocny@google.com<ma...@google.com> [mailto:mmocny@google.com<ma...@google.com>] On Behalf
> Of
> >>> > > > >> Michal Mocny
> >>> > > > >> Sent: Tuesday, April 08, 2014 11:39 PM
> >>> > > > >> To: dev
> >>> > > > >> Subject: Re: [Android] Refactoring for different engines
> >>> > > > >>
> >>> > > > >> Would it be alright to set up a Hangout some time to introduce
> >>> > everyone?
> >>> > > > >>
> >>> > > > >> Joe has been leading the effort here, but there are other
> cordova
> >>> > > > >> contributors for whom this is top priority.  It would be nice
> if
> >>> we
> >>> > > > >> could all meet to say hello and make sure we are all going in
> the
> >>> > > > >> right
> >>> > > > direction.
> >>> > > > >>
> >>> > > > >> Quite exciting!
> >>> > > > >>
> >>> > > > >> -Michal
> >>> > > > >>
> >>> > > > >>
> >>> > > > >> On Tue, Apr 8, 2014 at 10:56 AM, Hu, Ningxin <
> >>> ningxin.hu@intel.com<ma...@intel.com>>
> >>> > > wrote:
> >>> > > > >>
> >>> > > > >> > Joe, thanks for this. I am very excited.
> >>> > > > >> >
> >>> > > > >> > FYI. Crosswalk team is working on refactoring the WebView
> API to
> >>> > > > >> > support embedding usage better [1]. (Previously the layer
> API
> >>> was
> >>> > > > >> > not exposed as public usage).
> >>> > > > >> >
> >>> > > > >> > I would like to review the PoC and work with you to get
> >>> Crosswalk
> >>> > > > >> > fits into the pluggable WebView architecture.
> >>> > > > >> >
> >>> > > > >> > Thanks,
> >>> > > > >> > -ningxin
> >>> > > > >> >
> >>> > > > >> > > -----Original Message-----
> >>> > > > >> > > From: Joe Bowser [mailto:bowserj@gmail.com<ma...@gmail.com>]
> >>> > > > >> > > Sent: Wednesday, March 19, 2014 7:08 AM
> >>> > > > >> > > To: dev
> >>> > > > >> > > Subject: Re: [Android] Refactoring for different engines
> >>> > > > >> > >
> >>> > > > >> > > Hey
> >>> > > > >> > >
> >>> > > > >> > > After debugging, I did some minor updates to the plugin
> >>> README.
> >>> > > > >> > > It
> >>> > > > >> > should be
> >>> > > > >> > > easier to get this up and running, although there's still
> the
> >>> > > > >> > > issue of
> >>> > > > >> > after-install
> >>> > > > >> > > hooks and the relative path weirdness with the Crosswalk
> >>> > Library itself.
> >>> > > > >> > >
> >>> > > > >> > > It still doesn't support the CLI at all, but it should be
> >>> there
> >>> > > > >> > > with the
> >>> > > > >> > old flow.
> >>> > > > >> > >
> >>> > > > >> > > On Mon, Mar 17, 2014 at 1:14 PM, Michal Mocny
> >>> > > > >> > > <mm...@chromium.org>>
> >>> > > > >> > > wrote:
> >>> > > > >> > > > (Sorry Joe, Googlers are down in California and way
> busy.
> >>> > > > >> > > > Will be back in a week.  Super excited about this,
> though.)
> >>> > > > >> > > >
> >>> > > > >> > > > -Michal
> >>> > > > >> > > >
> >>> > > > >> > > >
> >>> > > > >> > > > On Mon, Mar 17, 2014 at 2:53 PM, Joe Bowser
> >>> > > > >> > > > <bo...@gmail.com>>
> >>> > > > >> wrote:
> >>> > > > >> > > >
> >>> > > > >> > > >> Reviving this thread!
> >>> > > > >> > > >>
> >>> > > > >> > > >> Can other people look at this, and see if/when we
> should
> >>> > land this?
> >>> > > > >> > > >> I know that I have to re-write the tests still, but I
> would
> >>> > > > >> > > >> like some feedback before merging it in.  Also, it'd be
> >>> > > > >> > > >> super awesome if other people could try and make a
> WebView
> >>> > > > >> > > >> based on the interfaces and recommend which methods
> should
> >>> > > > >> > > >> die.  I want to get this released in the next month or
> so,
> >>> > > > >> > > >> so any time and feedback would be greatly appreciated.
> >>> > > > >> > > >>
> >>> > > > >> > > >> Thanks
> >>> > > > >> > > >>
> >>> > > > >> > > >> On Thu, Mar 13, 2014 at 3:50 PM, Joe Bowser
> >>> > > > >> > > >> <bo...@gmail.com>>
> >>> > > > >> > wrote:
> >>> > > > >> > > >> > Hey, I created the following today to track various
> >>> > > > >> > > >> > WebView
> >>> > > > >> > progresses:
> >>> > > > >> > > >> > https://issues.apache.org/jira/browse/CB-6246
> >>> > > > >> > > >> >
> >>> > > > >> > > >> > I also have this repo created.  The licensing is
> ugly as
> >>> > > > >> > > >> > all crap, but it's a Proof-Of-Concept:
> >>> > > > >> > > >> > https://github.com/infil00p/cordova-crosswalk-engine
> >>> > > > >> > > >> >
> >>> > > > >> > > >> > If I can get some help getting plugman to just load
> >>> > > > >> > > >> > Crosswalk, it'll
> >>> > > > >> > > >> look hawt.
> >>> > > > >> > > >> >
> >>> > > > >> > > >> > BTW: We should probably get this ready to go into
> Android
> >>> > > > >> > > >> > in the next two months and deprecate the setProperty
> >>> > > > >> > > >> > methods, since all properties should be preferences
> in
> >>> > config.xml
> >>> > > now.
> >>> > > > >> > > >> >
> >>> > > > >> > > >> > On Mon, Mar 10, 2014 at 2:42 PM, Joe Bowser
> >>> > > > >> > > >> > <bo...@gmail.com>>
> >>> > > > >> > > wrote:
> >>> > > > >> > > >> >> Perhaps. There would be additional benefits to this
> >>> > > > >> > > >> >> approach, namely fixes being added to that platform
> more
> >>> > > > >> > > >> >> quickly.  I'll probably take a look at that once I
> have
> >>> > > > >> > > >> >> Crosswalk
> >>> > > > finalized.
> >>> > > > >> > > >> >>
> >>> > > > >> > > >> >> On Mon, Mar 10, 2014 at 9:49 AM, Brian LeRoux
> >>> > > > >> > > >> >> <b@...@brian.io>>
> >>> > > > wrote:
> >>> > > > >> > > >> >>> this is great stuff
> >>> > > > >> > > >> >>>
> >>> > > > >> > > >> >>> do we think it may be possible to bring in amazon
> >>> fireos
> >>> > > > >> > > >> >>> stuff
> >>> > > > >> > > >> eventually
> >>> > > > >> > > >> >>> too?
> >>> > > > >> > > >> >>>
> >>> > > > >> > > >> >>>
> >>> > > > >> > > >> >>> On Fri, Mar 7, 2014 at 3:22 PM, Joe Bowser
> >>> > > > >> > > >> >>> <bo...@gmail.com>>
> >>> > > > >> > wrote:
> >>> > > > >> > > >> >>>
> >>> > > > >> > > >> >>>> BTW: I committed it in my repo, not the main
> Apache
> >>> one.
> >>> > > > >> > > >> >>>>
> >>> > > > >> > > >> >>>> On Fri, Mar 7, 2014 at 3:21 PM, Joe Bowser
> >>> > > > >> > > >> >>>> <bo...@gmail.com>>
> >>> > > > >> > > wrote:
> >>> > > > >> > > >> >>>> > Hey
> >>> > > > >> > > >> >>>> >
> >>> > > > >> > > >> >>>> > I just committed some code based on their
> WebView
> >>> > > > >> > > >> >>>> > modifications that allows you to choose your
> >>> renderer
> >>> > > > >> > > >> >>>> > in the
> >>> > > > >> > config file
> >>> > > > >> > > with this:
> >>> > > > >> > > >> >>>> >
> >>> > > > >> > > >> >>>> >     <preference name="webView"
> >>> > > > >> > > >> >>>> >
> >>> value="org.apache.cordova.engine.crosswalk.XWalkCordo
> >>> > > > >> > > >> >>>> > va
> >>> > > > >> > > >> >>>> > Web
> >>> > > > >> > > >> >>>> > View
> >>> > > > >> > > >> >>>> > " />
> >>> > > > >> > > >> >>>> >
> >>> > > > >> > > >> >>>> > You currently have to copy over the *.pak file
> and
> >>> > > > >> > > >> >>>> > the jsapi from a Crosswalk Example project to
> get
> >>> > > > >> > > >> >>>> > this to work.  The next thing that I'm going to
> do
> >>> is
> >>> > > > >> > > >> >>>> > figure out how to write this as a plugin and
> have it
> >>> > > > >> > > >> >>>> > install on a default
> >>> > > > project.
> >>> > > > >> > > >> >>>> > Also, right now the bridge doesn't seem to
> work, and
> >>> > > > >> > > >> >>>> > I don't know why exactly.  That being said, the
> >>> > > > >> > > >> fact
> >>> > > > >> > > >> >>>> > that I can choose which version of
> Chrome/Chromium
> >>> > > > >> > > >> >>>> > I'm running with
> >>> > > > >> > > >> a
> >>> > > > >> > > >> >>>> > single XML preference is HUGE.
> >>> > > > >> > > >> >>>> >
> >>> > > > >> > > >> >>>> > There's definitely a lot more work that needs
> to be
> >>> > > > >> > > >> >>>> > done, but as
> >>> > > > >> > > >> long
> >>> > > > >> > > >> >>>> > as we have something that we can fit into the
> >>> > > > >> > > >> >>>> > interface, we should
> >>> > > > >> > > >> be
> >>> > > > >> > > >> >>>> > able to put in things like GeckoView or other
> third
> >>> > > > >> > > >> >>>> > party
> >>> > > > >> > renderers.
> >>> > > > >> > > >> >>>> > The nightmare of being stuck with bullshit
> WebView
> >>> > > > >> > > >> >>>> > bugs may soon be over.
> >>> > > > >> > > >> >>>> >
> >>> > > > >> > > >> >>>> > On Wed, Mar 5, 2014 at 8:59 PM, Michal Mocny
> >>> > > > >> > > >> >>>> > <mm...@chromium.org>>
> >>> > > > >> > > >> >>>> wrote:
> >>> > > > >> > > >> >>>> >>
> >>> https://github.com/crosswalk-project/crosswalk-cordo
> >>> > > > >> > > >> >>>> >> va
> >>> > > > >> > > >> >>>> >> -an
> >>> > > > >> > > >> >>>> >> droi
> >>> > > > >> > > >> >>>> >> d
> >>> > > > >> > > >> >>>> >>
> >>> > > > >> > > >> >>>> >> First patch they landed, which claims to have
> min
> >>> > > > >> > > >> >>>> >> viable xwalk
> >>> > > > >> > > >> webview:
> >>> > > > >> > > >> >>>> >>
> >>> > > > >> > > >> >>>>
> >>> > > > >> > > >>
> >>> https://github.com/crosswalk-project/crosswalk-cordova-andro
> >>> > > > >> > > >> id
> >>> > > > >> > > >> /co
> >>> > > > >> > > >> mmit
> >>> > > > >> > > >> /a04dedeb0204e7542d190312c6ae70c795a26e04
> >>> > > > >> > > >> >>>> >>
> >>> > > > >> > > >> >>>> >>
> >>> > > > >> > > >> >>>> >> On Wed, Mar 5, 2014 at 11:37 PM, Michal Mocny
> >>> > > > >> > > >> >>>> >> <mm...@chromium.org>
> >>> > > > >> > > >> >
> >>> > > > >> > > >> >>>> wrote:
> >>> > > > >> > > >> >>>> >>
> >>> > > > >> > > >> >>>> >>> I haven't looked yet, but did you see:
> >>> > > > >> > > >> >>>> >>>
> >>> https://crosswalk-project.org/#wiki/crosswalk-cordo
> >>> > > > >> > > >> >>>> >>> va
> >>> > > > >> > > >> >>>> >>> -an
> >>> > > > >> > > >> >>>> >>> droi
> >>> > > > >> > > >> >>>> >>> d
> >>> > > > >> > > >> >>>> >>>
> >>> > > > >> > > >> >>>> >>> ?
> >>> > > > >> > > >> >>>> >>>
> >>> > > > >> > > >> >>>> >>>
> >>> > > > >> > > >> >>>> >>> On Wed, Mar 5, 2014 at 10:20 PM, Andrew
> Grieve <
> >>> > > > >> > > >> agrieve@chromium.org<ma...@chromium.org>
> >>> > > > >> > > >> >>>> >wrote:
> >>> > > > >> > > >> >>>> >>>
> >>> > > > >> > > >> >>>> >>>> First - very excited that you're working on
> this!
> >>> > > > >> > > >> >>>> >>>>
> >>> > > > >> > > >> >>>> >>>> Had a quick look. Not sure there's much to be
> >>> > gleaned
> >>> > > yet.
> >>> > > > >> > > >> >>>> >>>> Once
> >>> > > > >> > > >> you
> >>> > > > >> > > >> >>>> start
> >>> > > > >> > > >> >>>> >>>> in on hooking up x-walk's webview I think it
> will
> >>> > > > >> > > >> >>>> >>>> become more
> >>> > > > >> > > >> obvious
> >>> > > > >> > > >> >>>> what
> >>> > > > >> > > >> >>>> >>>> the interface should look like. E.g., does
> x-walk
> >>> > > > >> > > >> >>>> >>>> even have the
> >>> > > > >> > > >> >>>> concept of
> >>> > > > >> > > >> >>>> >>>> ChromeClient vs WebViewClient vs WebView?
> Also
> >>> > > > >> > > >> >>>> >>>> unsure whether the
> >>> > > > >> > > >> >>>> class
> >>> > > > >> > > >> >>>> >>>> should extend android.View as well as
> implement
> >>> > > > >> > > >> >>>> >>>> our
> >>> > > > >> > interface.
> >>> > > > >> > > >> E.g.
> >>> > > > >> > > >> >>>> >>>> alternative is to have a "getView()" method
> on
> >>> the
> >>> > > > >> > interface.
> >>> > > > >> > > >> Might
> >>> > > > >> > > >> >>>> help
> >>> > > > >> > > >> >>>> >>>> to
> >>> > > > >> > > >> >>>> >>>> cut down on file sizes, and API surface, but
> >>> > > > >> > > >> >>>> >>>> again, I'm not too
> >>> > > > >> > > >> sure.
> >>> > > > >> > > >> >>>> >>>>
> >>> > > > >> > > >> >>>> >>>> I've been pretty hesitant to touch existing
> >>> > > > >> > > >> >>>> >>>> exposed members
> >>> > > > >> > > >> (e.g. the
> >>> > > > >> > > >> >>>> >>>> public fields you were referring to) since
> >>> > > > >> > > >> >>>> >>>> touching anything
> >>> > > > >> > > >> public
> >>> > > > >> > > >> >>>> could
> >>> > > > >> > > >> >>>> >>>> break plugins. That said, maybe now is a good
> >>> time
> >>> > > > >> > > >> >>>> >>>> to @deprecate
> >>> > > > >> > > >> a
> >>> > > > >> > > >> >>>> bunch
> >>> > > > >> > > >> >>>> >>>> of
> >>> > > > >> > > >> >>>> >>>> them and either replace them with getters, or
> >>> just
> >>> > > > >> > > >> >>>> >>>> declare them
> >>> > > > >> > > >> to be
> >>> > > > >> > > >> >>>> not
> >>> > > > >> > > >> >>>> >>>> exposed to plugins.
> >>> > > > >> > > >> >>>> >>>>
> >>> > > > >> > > >> >>>> >>>>
> >>> > > > >> > > >> >>>> >>>> On Wed, Mar 5, 2014 at 6:57 PM, Joe Bowser
> >>> > > > >> > > >> >>>> >>>> <bo...@gmail.com>>
> >>> > > > >> > > >> wrote:
> >>> > > > >> > > >> >>>> >>>>
> >>> > > > >> > > >> >>>> >>>> > So, after looking at the Crosswalk code
> again,
> >>> > > > >> > > >> >>>> >>>> > I've decided to
> >>> > > > >> > > >> take
> >>> > > > >> > > >> >>>> a
> >>> > > > >> > > >> >>>> >>>> > quick stab at making things pluggable.  I
> don't
> >>> > > > >> > > >> >>>> >>>> > have a lot to
> >>> > > > >> > > >> show
> >>> > > > >> > > >> >>>> for
> >>> > > > >> > > >> >>>> >>>> > it, but with the help of Eclipse (which is
> why
> >>> > > > >> > > >> >>>> >>>> > the generated interfaces look so screwed
> up), I
> >>> > > > >> > > >> >>>> >>>> > managed to create some
> >>> > > > >> > > >> interfaces
> >>> > > > >> > > >> >>>> so
> >>> > > > >> > > >> >>>> >>>> > we can start shoehorning in other browser
> >>> > renderers.
> >>> > > > >> > > >> >>>> >>>> >
> >>> > > > >> > > >> >>>> >>>> >
> >>> > > > >> > > >>
> >>> https://github.com/infil00p/cordova-android/tree/pluggable_w
> >>> > > > >> > > >> eb
> >>> > > > >> > > >> vie
> >>> > > > >> > > >> w
> >>> > > > >> > > >> >>>> >>>> >
> >>> > > > >> > > >> >>>> >>>> > I'm going to probably start with Crosswalk,
> >>> > > > >> > > >> >>>> >>>> > because it's
> >>> > > > >> > > >> probably
> >>> > > > >> > > >> >>>> the
> >>> > > > >> > > >> >>>> >>>> > most mature primary candidate in the
> Android
> >>> > > > >> > > >> >>>> >>>> > Third-Party
> >>> > > > >> > > >> WebView
> >>> > > > >> > > >> >>>> >>>> > thing, and I'm pretty sure the GeckoView
> will
> >>> be
> >>> > > > >> > > >> >>>> >>>> > happening
> >>> > > > >> > > >> shortly
> >>> > > > >> > > >> >>>> >>>> > after.
> >>> > > > >> > > >> >>>> >>>> >
> >>> > > > >> > > >> >>>> >>>> > I don't know how this would work w.r.t.
> the CLI
> >>> > > > >> > > >> >>>> >>>> > or our
> >>> > > > >> > > >> workflow at
> >>> > > > >> > > >> >>>> >>>> > all, but at the moment, I really just want
> to
> >>> at
> >>> > > > >> > > >> >>>> >>>> > least start
> >>> > > > >> > > >> to have
> >>> > > > >> > > >> >>>> >>>> > some headway towards 4.x and PhoneGap day.
> >>> > > > >> > > >> >>>> >>>> >
> >>> > > > >> > > >> >>>> >>>> > What do people think of this so far? I'm
> going
> >>> > > > >> > > >> >>>> >>>> > to try to clean
> >>> > > > >> > > >> >>>> things
> >>> > > > >> > > >> >>>> >>>> > up a bit, since we've definitely done a
> lot of
> >>> > > > >> > > >> >>>> >>>> > things that
> >>> > > > >> > > >> would
> >>> > > > >> > > >> >>>> make
> >>> > > > >> > > >> >>>> >>>> > first year CS profs freak the hell out
> (i.e.
> >>> > > > >> > > >> >>>> >>>> > public members in
> >>> > > > >> > > >> >>>> public
> >>> > > > >> > > >> >>>> >>>> > objects w.r.t. PluginManager).
> >>> > > > >> > > >> >>>> >>>> >
> >>> > > > >> > > >> >>>> >>>> > Thoughts?
> >>> > > > >> > > >> >>>> >>>> >
> >>> > > > >> > > >> >>>> >>>> > Joe
> >>> > > > >> > > >> >>>> >>>> >
> >>> > > > >> > > >> >>>> >>>>
> >>> > > > >> > > >> >>>> >>>
> >>> > > > >> > > >> >>>> >>>
> >>> > > > >> > > >> >>>>
> >>> > > > >> > > >>
> >>> > > > >> >
> >>> >
> >>>
>

RE: [Android] Refactoring for different engines

["Hu, Ningxin" <ni...@intel.com>]

I am happy to work with you guys on this really exciting thing.

> The other branch is https://github.com/clelland/cordova-android/tree/pluggable_webview, and moves the client-creation logic entirely into the webview classes.
> I'm not entirely happy with it, since Cordova has had the feature that users can override the creation of the WebViewClient and ChromeClient themselves, in their Activity subclass, and we've lost that with my branch. I want to re-work it to allow those methods to be used, if they exist, but let the WebView handle creation entirely on its own if they don't.

Agree. We should keep this feature. In my implementation, I keep the makeWebViewClient and makeChromeClient in CordovaAcitity and just delegate to WebView engine. So if needed, application Activity subclass can still provide its own version.

Talk to you soon.

Thanks,
-ningxin

From: iclelland@google.com [mailto:iclelland@google.com] On Behalf Of Ian Clelland
Sent: Friday, April 25, 2014 10:20 AM
To: Hu, Ningxin
Cc: Joe Bowser; dev@cordova.apache.org
Subject: Re: [Android] Refactoring for different engines

That's some close timing -- I just pushed my branches to github :)

I've pushed a branch at https://github.com/clelland/cordova-crosswalk-engine/tree/fix-plugin1 that basically covers your commit up to 158fea7, with the small tweak that I mentioned about not re-casting to XWalkCordovaWebView when not necessary.

The other branch is https://github.com/clelland/cordova-android/tree/pluggable_webview, and moves the client-creation logic entirely into the webview classes.

I'm not entirely happy with it, since Cordova has had the feature that users can override the creation of the WebViewClient and ChromeClient themselves, in their Activity subclass, and we've lost that with my branch. I want to re-work it to allow those methods to be used, if they exist, but let the WebView handle creation entirely on its own if they don't.

I'll take a look at your branches in the morning; it's getting late here... I appreciate you working with us to get this working!

Talk to you tomorrow on the hangout (some time)

Ian


On Thu, Apr 24, 2014 at 10:02 PM, Hu, Ningxin <ni...@intel.com>> wrote:
> I think that we could do this differently. I would rather see the functionality of CordovaActivity.makeWebViewClient and CordovaActivity.makeChromeClient moved into the AndroidWebView class, and declared as methods in the CordovaWebView interface. Then we would override them in XWalkCordovaWebView to do the right thing.
> The extra string manipulation magic, and reflection, that this patch introduces, seems wrong to me. Considering that we already have methods in XWalkCordovaWebView to construct those objects, then we should let the XWalkCordovaWebView construct them.

Agree with your solution. It sounds better to me. I've updated the PR to implement it. Please take another look.

> (I do like your method of iterating over the constructors, though -- I'm going to try to use that code in makeWebView as well)

Thanks. I've implemented it in the PR update. Please review.

-ningxin

From: iclelland@google.com<ma...@google.com> [mailto:iclelland@google.com<ma...@google.com>] On Behalf Of Ian Clelland
Sent: Thursday, April 24, 2014 11:58 PM
To: Hu, Ningxin
Cc: Joe Bowser; dev@cordova.apache.org<ma...@cordova.apache.org>

Subject: Re: [Android] Refactoring for different engines



On Thu, Apr 24, 2014 at 5:27 AM, Hu, Ningxin <ni...@intel.com>> wrote:
> Mobilespec runs on my N4, with 10 failing tests: 3 in contacts; 7 in file-transfer. Otherwise, things seem to be working pretty well.

I checked out the latest code (@691fbce540) and build mbilespec with Crosswalk 6.35.127.0. However, it runs on the default Android WebView due to the InvocationTargetException when calling constructors of XWalkWebChromeClient and XWalkClient. I fixed it at: https://github.com/infil00p/cordova-crosswalk-engine/pull/6.

This looks good, I've pulled that in locally.


To make the plugins work on cordova-crosswalk-engine, it still needs to set correct webview client, chrome client and enable the setNetworkAvailable. I've sent another two PRs.
https://github.com/infil00p/cordova-crosswalk-engine/pull/7
https://github.com/infil00p/cordova-android/pull/3

I think that we could do this differently. I would rather see the functionality of CordovaActivity.makeWebViewClient and CordovaActivity.makeChromeClient moved into the AndroidWebView class, and declared as methods in the CordovaWebView interface. Then we would override them in XWalkCordovaWebView to do the right thing.

The extra string manipulation magic, and reflection, that this patch introduces, seems wrong to me. Considering that we already have methods in XWalkCordovaWebView to construct those objects, then we should let the XWalkCordovaWebView construct them.

(I do like your method of iterating over the constructors, though -- I'm going to try to use that code in makeWebView as well)


After these fixes (and with three fixes in plugins to use getPluginManager() interface), I can run the mobilespec "Run All Tests" on Crosswalk with all passed except Media test. The Media.js seems not be loaded. I didn't have chance to debug it yet.

Ian and Joe, could you please review the PRs? I would appreciate that.

> I've issued a pull request at https://github.com/infil00p/cordova-crosswalk-engine/pull/5 for it -- I'm not sure if there's a way to keep compatibility with last week's Crosswalk, or if we'd even want to. (Ningxin, if you could take a look at that PR and see if it makes sense, I'd appreciate it)

The PR LGTM! Thanks for the update.

For crosswalk embedding API compatibility, currently we track the master branch of Crosswalk (a.k.a Canary release channel), the embedding API in master is still under development. As planned, the Crosswalk-6 will be branched for beta in 4th May. In that branch, the embedding API will be stable and only accept bug fixing. So for cordova-crosswalk-engine, we can also have crosswalk-6 branch to track beta branch (later stable branch) and using master to track the latest crosswalk.

Are people also going to use older (1-4) versions of Crosswalk? Or is the plan to encourage people to only use either stable or beta versions?

I am even thinking about we can setup some bots (as buildbots in crosswalk) to track if any patches to crosswalk break the cordova-crosswalk-engine.

Your thoughts?

That would be good to have -- I'd like to have some kind of warning that new changes in the upstream project break the plugin :)


Thanks,
-ningxin

From: iclelland@google.com<ma...@google.com> [mailto:iclelland@google.com<ma...@google.com>] On Behalf Of Ian Clelland
Sent: Thursday, April 24, 2014 1:32 AM
To: dev@cordova.apache.org<ma...@cordova.apache.org>
Cc: Joe Bowser; Hu, Ningxin

Subject: Re: [Android] Refactoring for different engines

I've managed to get this up and running now -- great work on this, Joe!

Mobilespec runs on my N4, with 10 failing tests: 3 in contacts; 7 in file-transfer. Otherwise, things seem to be working pretty well.

I used a new build of Crosswalk, and found that the embedding API has changed since the weekend (when Ningxin's patches applied). I've issued a pull request at https://github.com/infil00p/cordova-crosswalk-engine/pull/5 for it -- I'm not sure if there's a way to keep compatibility with last week's Crosswalk, or if we'd even want to. (Ningxin, if you could take a look at that PR and see if it makes sense, I'd appreciate it)

Joe, I also had to patch the default constructor for XWalkCordovaWebView; it wasn't creating its own client objects, so it got the default ones, and most of the tests were failing because some component of the bridge wan't working. https://github.com/infil00p/cordova-crosswalk-engine/pull/4 is out for that.

Count me in for the hangout -- this is exciting stuff

Ian

On Wed, Apr 23, 2014 at 10:26 AM, Brian LeRoux <b@...@brian.io>> wrote:
Yup I'll track em down
On Apr 23, 2014 7:17 AM, "Andrew Grieve" <ag...@chromium.org>> wrote:

> Does anyone have a contact at moz that we could invite?
>
> On Wed, Apr 23, 2014 at 10:09 AM, Andrew Grieve <ag...@chromium.org>>
> wrote:
> > Depends on their interest level I think. Faster we can get this out
> > the door the better. If we need to delay for geckoview, then I don't
> > think we should gate on it, just release it after.
> >
> > On Wed, Apr 23, 2014 at 3:01 AM, Tommy Williams <to...@devgeeks.org>>
> wrote:
> >> More engines, more better...
> >> On 23 Apr 2014 16:32, "Joe Bowser" <bo...@gmail.com>> wrote:
> >>
> >>> Hey
> >>>
> >>> A Hangout would have to happen on Friday at the earliest.  It'd be
> good if
> >>> we could get someone from Mozilla on the hangout as well.  I haven't
> gotten
> >>> MozillaView (GeckoView with Cordova methods) fully working yet.  For
> some
> >>> reason it's not rendering on the screen.
> >>>
> >>> Ideally it'd be cool to have at least two options when this feature
> finally
> >>> lands.
> >>>
> >>> What do other people think?
> >>>
> >>> Joe
> >>> On 22 Apr 2014 20:06, "Hu, Ningxin" <ni...@intel.com>> wrote:
> >>>
> >>> > Joe,
> >>> >
> >>> > Thanks for your review and merge the PRs.
> >>> >
> >>> > To pluggable webview interest group:
> >>> > Are we OK to setup a hangout this week for initial introduction and
> >>> > discussion of next steps?
> >>> >
> >>> > Thanks,
> >>> > -ningxin
> >>> >
> >>> > > -----Original Message-----
> >>> > > From: Hu, Ningxin [mailto:ningxin.hu@intel.com<ma...@intel.com>]
> >>> > > Sent: Tuesday, April 22, 2014 4:04 PM
> >>> > > To: dev@cordova.apache.org<ma...@cordova.apache.org>
> >>> > > Subject: RE: [Android] Refactoring for different engines
> >>> > >
> >>> > > The PoC is great! Quite excited about the direction!
> >>> > >
> >>> > > I've sent a PR to update the cordova-crosswalk-engine to latest
> >>> crosswalk
> >>> > > embedding API. It works with xwalk_core_library at 6.35.124.0.
> >>> > >
> >>> > > I've also changed the CordovaWebView interface slightly (adding
> >>> > getView() API)
> >>> > > to allow XWalkCordovaWebView to composite a XWalkView instead of
> >>> > extending
> >>> > > it. It resolves some API naming issues for XWalkView case.
> >>> > >
> >>> > > Please review them at:
> >>> > > https://github.com/infil00p/cordova-crosswalk-engine/pull/3
> >>> > > https://github.com/infil00p/cordova-android/pull/2
> >>> > >
> >>> > > Thanks,
> >>> > > -ningxin
> >>> > >
> >>> > > > -----Original Message-----
> >>> > > > From: Joe Bowser [mailto:bowserj@gmail.com<ma...@gmail.com>]
> >>> > > > Sent: Friday, April 11, 2014 12:45 AM
> >>> > > > To: dev
> >>> > > > Subject: Re: [Android] Refactoring for different engines
> >>> > > >
> >>> > > > Yeah, I'd be cool with setting up a hangout.  Everyone should
> take a
> >>> > > > look at the PoC, I've basically distilled it down to four or five
> >>> > > > classes so far, but with some work, we may be able to get it
> down to
> >>> > > > three.  Due to legacy, we're pretty stuck with the Android
> WebView
> >>> API
> >>> > calls,
> >>> > > but these can probably be modified.
> >>> > > >
> >>> > > > It'd be good to get Mozilla people on the call as well, since
> they
> >>> > > > have their WebView as well.
> >>> > > >
> >>> > > > On Thu, Apr 10, 2014 at 9:38 AM, Hu, Ningxin <
> ningxin.hu@intel.com<ma...@intel.com>>
> >>> > wrote:
> >>> > > > > Hangout would be a good idea.
> >>> > > > >
> >>> > > > > FYI, I will be off next week. How about the week after next?
> If it
> >>> > > > > works, please
> >>> > > > feel free to schedule one and count me in.
> >>> > > > >
> >>> > > > > Thanks,
> >>> > > > > -ningxin
> >>> > > > >
> >>> > > > >> -----Original Message-----
> >>> > > > >> From: mmocny@google.com<ma...@google.com> [mailto:mmocny@google.com<ma...@google.com>] On Behalf
> Of
> >>> > > > >> Michal Mocny
> >>> > > > >> Sent: Tuesday, April 08, 2014 11:39 PM
> >>> > > > >> To: dev
> >>> > > > >> Subject: Re: [Android] Refactoring for different engines
> >>> > > > >>
> >>> > > > >> Would it be alright to set up a Hangout some time to introduce
> >>> > everyone?
> >>> > > > >>
> >>> > > > >> Joe has been leading the effort here, but there are other
> cordova
> >>> > > > >> contributors for whom this is top priority.  It would be nice
> if
> >>> we
> >>> > > > >> could all meet to say hello and make sure we are all going in
> the
> >>> > > > >> right
> >>> > > > direction.
> >>> > > > >>
> >>> > > > >> Quite exciting!
> >>> > > > >>
> >>> > > > >> -Michal
> >>> > > > >>
> >>> > > > >>
> >>> > > > >> On Tue, Apr 8, 2014 at 10:56 AM, Hu, Ningxin <
> >>> ningxin.hu@intel.com<ma...@intel.com>>
> >>> > > wrote:
> >>> > > > >>
> >>> > > > >> > Joe, thanks for this. I am very excited.
> >>> > > > >> >
> >>> > > > >> > FYI. Crosswalk team is working on refactoring the WebView
> API to
> >>> > > > >> > support embedding usage better [1]. (Previously the layer
> API
> >>> was
> >>> > > > >> > not exposed as public usage).
> >>> > > > >> >
> >>> > > > >> > I would like to review the PoC and work with you to get
> >>> Crosswalk
> >>> > > > >> > fits into the pluggable WebView architecture.
> >>> > > > >> >
> >>> > > > >> > Thanks,
> >>> > > > >> > -ningxin
> >>> > > > >> >
> >>> > > > >> > > -----Original Message-----
> >>> > > > >> > > From: Joe Bowser [mailto:bowserj@gmail.com<ma...@gmail.com>]
> >>> > > > >> > > Sent: Wednesday, March 19, 2014 7:08 AM
> >>> > > > >> > > To: dev
> >>> > > > >> > > Subject: Re: [Android] Refactoring for different engines
> >>> > > > >> > >
> >>> > > > >> > > Hey
> >>> > > > >> > >
> >>> > > > >> > > After debugging, I did some minor updates to the plugin
> >>> README.
> >>> > > > >> > > It
> >>> > > > >> > should be
> >>> > > > >> > > easier to get this up and running, although there's still
> the
> >>> > > > >> > > issue of
> >>> > > > >> > after-install
> >>> > > > >> > > hooks and the relative path weirdness with the Crosswalk
> >>> > Library itself.
> >>> > > > >> > >
> >>> > > > >> > > It still doesn't support the CLI at all, but it should be
> >>> there
> >>> > > > >> > > with the
> >>> > > > >> > old flow.
> >>> > > > >> > >
> >>> > > > >> > > On Mon, Mar 17, 2014 at 1:14 PM, Michal Mocny
> >>> > > > >> > > <mm...@chromium.org>>
> >>> > > > >> > > wrote:
> >>> > > > >> > > > (Sorry Joe, Googlers are down in California and way
> busy.
> >>> > > > >> > > > Will be back in a week.  Super excited about this,
> though.)
> >>> > > > >> > > >
> >>> > > > >> > > > -Michal
> >>> > > > >> > > >
> >>> > > > >> > > >
> >>> > > > >> > > > On Mon, Mar 17, 2014 at 2:53 PM, Joe Bowser
> >>> > > > >> > > > <bo...@gmail.com>>
> >>> > > > >> wrote:
> >>> > > > >> > > >
> >>> > > > >> > > >> Reviving this thread!
> >>> > > > >> > > >>
> >>> > > > >> > > >> Can other people look at this, and see if/when we
> should
> >>> > land this?
> >>> > > > >> > > >> I know that I have to re-write the tests still, but I
> would
> >>> > > > >> > > >> like some feedback before merging it in.  Also, it'd be
> >>> > > > >> > > >> super awesome if other people could try and make a
> WebView
> >>> > > > >> > > >> based on the interfaces and recommend which methods
> should
> >>> > > > >> > > >> die.  I want to get this released in the next month or
> so,
> >>> > > > >> > > >> so any time and feedback would be greatly appreciated.
> >>> > > > >> > > >>
> >>> > > > >> > > >> Thanks
> >>> > > > >> > > >>
> >>> > > > >> > > >> On Thu, Mar 13, 2014 at 3:50 PM, Joe Bowser
> >>> > > > >> > > >> <bo...@gmail.com>>
> >>> > > > >> > wrote:
> >>> > > > >> > > >> > Hey, I created the following today to track various
> >>> > > > >> > > >> > WebView
> >>> > > > >> > progresses:
> >>> > > > >> > > >> > https://issues.apache.org/jira/browse/CB-6246
> >>> > > > >> > > >> >
> >>> > > > >> > > >> > I also have this repo created.  The licensing is
> ugly as
> >>> > > > >> > > >> > all crap, but it's a Proof-Of-Concept:
> >>> > > > >> > > >> > https://github.com/infil00p/cordova-crosswalk-engine
> >>> > > > >> > > >> >
> >>> > > > >> > > >> > If I can get some help getting plugman to just load
> >>> > > > >> > > >> > Crosswalk, it'll
> >>> > > > >> > > >> look hawt.
> >>> > > > >> > > >> >
> >>> > > > >> > > >> > BTW: We should probably get this ready to go into
> Android
> >>> > > > >> > > >> > in the next two months and deprecate the setProperty
> >>> > > > >> > > >> > methods, since all properties should be preferences
> in
> >>> > config.xml
> >>> > > now.
> >>> > > > >> > > >> >
> >>> > > > >> > > >> > On Mon, Mar 10, 2014 at 2:42 PM, Joe Bowser
> >>> > > > >> > > >> > <bo...@gmail.com>>
> >>> > > > >> > > wrote:
> >>> > > > >> > > >> >> Perhaps. There would be additional benefits to this
> >>> > > > >> > > >> >> approach, namely fixes being added to that platform
> more
> >>> > > > >> > > >> >> quickly.  I'll probably take a look at that once I
> have
> >>> > > > >> > > >> >> Crosswalk
> >>> > > > finalized.
> >>> > > > >> > > >> >>
> >>> > > > >> > > >> >> On Mon, Mar 10, 2014 at 9:49 AM, Brian LeRoux
> >>> > > > >> > > >> >> <b@...@brian.io>>
> >>> > > > wrote:
> >>> > > > >> > > >> >>> this is great stuff
> >>> > > > >> > > >> >>>
> >>> > > > >> > > >> >>> do we think it may be possible to bring in amazon
> >>> fireos
> >>> > > > >> > > >> >>> stuff
> >>> > > > >> > > >> eventually
> >>> > > > >> > > >> >>> too?
> >>> > > > >> > > >> >>>
> >>> > > > >> > > >> >>>
> >>> > > > >> > > >> >>> On Fri, Mar 7, 2014 at 3:22 PM, Joe Bowser
> >>> > > > >> > > >> >>> <bo...@gmail.com>>
> >>> > > > >> > wrote:
> >>> > > > >> > > >> >>>
> >>> > > > >> > > >> >>>> BTW: I committed it in my repo, not the main
> Apache
> >>> one.
> >>> > > > >> > > >> >>>>
> >>> > > > >> > > >> >>>> On Fri, Mar 7, 2014 at 3:21 PM, Joe Bowser
> >>> > > > >> > > >> >>>> <bo...@gmail.com>>
> >>> > > > >> > > wrote:
> >>> > > > >> > > >> >>>> > Hey
> >>> > > > >> > > >> >>>> >
> >>> > > > >> > > >> >>>> > I just committed some code based on their
> WebView
> >>> > > > >> > > >> >>>> > modifications that allows you to choose your
> >>> renderer
> >>> > > > >> > > >> >>>> > in the
> >>> > > > >> > config file
> >>> > > > >> > > with this:
> >>> > > > >> > > >> >>>> >
> >>> > > > >> > > >> >>>> >     <preference name="webView"
> >>> > > > >> > > >> >>>> >
> >>> value="org.apache.cordova.engine.crosswalk.XWalkCordo
> >>> > > > >> > > >> >>>> > va
> >>> > > > >> > > >> >>>> > Web
> >>> > > > >> > > >> >>>> > View
> >>> > > > >> > > >> >>>> > " />
> >>> > > > >> > > >> >>>> >
> >>> > > > >> > > >> >>>> > You currently have to copy over the *.pak file
> and
> >>> > > > >> > > >> >>>> > the jsapi from a Crosswalk Example project to
> get
> >>> > > > >> > > >> >>>> > this to work.  The next thing that I'm going to
> do
> >>> is
> >>> > > > >> > > >> >>>> > figure out how to write this as a plugin and
> have it
> >>> > > > >> > > >> >>>> > install on a default
> >>> > > > project.
> >>> > > > >> > > >> >>>> > Also, right now the bridge doesn't seem to
> work, and
> >>> > > > >> > > >> >>>> > I don't know why exactly.  That being said, the
> >>> > > > >> > > >> fact
> >>> > > > >> > > >> >>>> > that I can choose which version of
> Chrome/Chromium
> >>> > > > >> > > >> >>>> > I'm running with
> >>> > > > >> > > >> a
> >>> > > > >> > > >> >>>> > single XML preference is HUGE.
> >>> > > > >> > > >> >>>> >
> >>> > > > >> > > >> >>>> > There's definitely a lot more work that needs
> to be
> >>> > > > >> > > >> >>>> > done, but as
> >>> > > > >> > > >> long
> >>> > > > >> > > >> >>>> > as we have something that we can fit into the
> >>> > > > >> > > >> >>>> > interface, we should
> >>> > > > >> > > >> be
> >>> > > > >> > > >> >>>> > able to put in things like GeckoView or other
> third
> >>> > > > >> > > >> >>>> > party
> >>> > > > >> > renderers.
> >>> > > > >> > > >> >>>> > The nightmare of being stuck with bullshit
> WebView
> >>> > > > >> > > >> >>>> > bugs may soon be over.
> >>> > > > >> > > >> >>>> >
> >>> > > > >> > > >> >>>> > On Wed, Mar 5, 2014 at 8:59 PM, Michal Mocny
> >>> > > > >> > > >> >>>> > <mm...@chromium.org>>
> >>> > > > >> > > >> >>>> wrote:
> >>> > > > >> > > >> >>>> >>
> >>> https://github.com/crosswalk-project/crosswalk-cordo
> >>> > > > >> > > >> >>>> >> va
> >>> > > > >> > > >> >>>> >> -an
> >>> > > > >> > > >> >>>> >> droi
> >>> > > > >> > > >> >>>> >> d
> >>> > > > >> > > >> >>>> >>
> >>> > > > >> > > >> >>>> >> First patch they landed, which claims to have
> min
> >>> > > > >> > > >> >>>> >> viable xwalk
> >>> > > > >> > > >> webview:
> >>> > > > >> > > >> >>>> >>
> >>> > > > >> > > >> >>>>
> >>> > > > >> > > >>
> >>> https://github.com/crosswalk-project/crosswalk-cordova-andro
> >>> > > > >> > > >> id
> >>> > > > >> > > >> /co
> >>> > > > >> > > >> mmit
> >>> > > > >> > > >> /a04dedeb0204e7542d190312c6ae70c795a26e04
> >>> > > > >> > > >> >>>> >>
> >>> > > > >> > > >> >>>> >>
> >>> > > > >> > > >> >>>> >> On Wed, Mar 5, 2014 at 11:37 PM, Michal Mocny
> >>> > > > >> > > >> >>>> >> <mm...@chromium.org>
> >>> > > > >> > > >> >
> >>> > > > >> > > >> >>>> wrote:
> >>> > > > >> > > >> >>>> >>
> >>> > > > >> > > >> >>>> >>> I haven't looked yet, but did you see:
> >>> > > > >> > > >> >>>> >>>
> >>> https://crosswalk-project.org/#wiki/crosswalk-cordo
> >>> > > > >> > > >> >>>> >>> va
> >>> > > > >> > > >> >>>> >>> -an
> >>> > > > >> > > >> >>>> >>> droi
> >>> > > > >> > > >> >>>> >>> d
> >>> > > > >> > > >> >>>> >>>
> >>> > > > >> > > >> >>>> >>> ?
> >>> > > > >> > > >> >>>> >>>
> >>> > > > >> > > >> >>>> >>>
> >>> > > > >> > > >> >>>> >>> On Wed, Mar 5, 2014 at 10:20 PM, Andrew
> Grieve <
> >>> > > > >> > > >> agrieve@chromium.org<ma...@chromium.org>
> >>> > > > >> > > >> >>>> >wrote:
> >>> > > > >> > > >> >>>> >>>
> >>> > > > >> > > >> >>>> >>>> First - very excited that you're working on
> this!
> >>> > > > >> > > >> >>>> >>>>
> >>> > > > >> > > >> >>>> >>>> Had a quick look. Not sure there's much to be
> >>> > gleaned
> >>> > > yet.
> >>> > > > >> > > >> >>>> >>>> Once
> >>> > > > >> > > >> you
> >>> > > > >> > > >> >>>> start
> >>> > > > >> > > >> >>>> >>>> in on hooking up x-walk's webview I think it
> will
> >>> > > > >> > > >> >>>> >>>> become more
> >>> > > > >> > > >> obvious
> >>> > > > >> > > >> >>>> what
> >>> > > > >> > > >> >>>> >>>> the interface should look like. E.g., does
> x-walk
> >>> > > > >> > > >> >>>> >>>> even have the
> >>> > > > >> > > >> >>>> concept of
> >>> > > > >> > > >> >>>> >>>> ChromeClient vs WebViewClient vs WebView?
> Also
> >>> > > > >> > > >> >>>> >>>> unsure whether the
> >>> > > > >> > > >> >>>> class
> >>> > > > >> > > >> >>>> >>>> should extend android.View as well as
> implement
> >>> > > > >> > > >> >>>> >>>> our
> >>> > > > >> > interface.
> >>> > > > >> > > >> E.g.
> >>> > > > >> > > >> >>>> >>>> alternative is to have a "getView()" method
> on
> >>> the
> >>> > > > >> > interface.
> >>> > > > >> > > >> Might
> >>> > > > >> > > >> >>>> help
> >>> > > > >> > > >> >>>> >>>> to
> >>> > > > >> > > >> >>>> >>>> cut down on file sizes, and API surface, but
> >>> > > > >> > > >> >>>> >>>> again, I'm not too
> >>> > > > >> > > >> sure.
> >>> > > > >> > > >> >>>> >>>>
> >>> > > > >> > > >> >>>> >>>> I've been pretty hesitant to touch existing
> >>> > > > >> > > >> >>>> >>>> exposed members
> >>> > > > >> > > >> (e.g. the
> >>> > > > >> > > >> >>>> >>>> public fields you were referring to) since
> >>> > > > >> > > >> >>>> >>>> touching anything
> >>> > > > >> > > >> public
> >>> > > > >> > > >> >>>> could
> >>> > > > >> > > >> >>>> >>>> break plugins. That said, maybe now is a good
> >>> time
> >>> > > > >> > > >> >>>> >>>> to @deprecate
> >>> > > > >> > > >> a
> >>> > > > >> > > >> >>>> bunch
> >>> > > > >> > > >> >>>> >>>> of
> >>> > > > >> > > >> >>>> >>>> them and either replace them with getters, or
> >>> just
> >>> > > > >> > > >> >>>> >>>> declare them
> >>> > > > >> > > >> to be
> >>> > > > >> > > >> >>>> not
> >>> > > > >> > > >> >>>> >>>> exposed to plugins.
> >>> > > > >> > > >> >>>> >>>>
> >>> > > > >> > > >> >>>> >>>>
> >>> > > > >> > > >> >>>> >>>> On Wed, Mar 5, 2014 at 6:57 PM, Joe Bowser
> >>> > > > >> > > >> >>>> >>>> <bo...@gmail.com>>
> >>> > > > >> > > >> wrote:
> >>> > > > >> > > >> >>>> >>>>
> >>> > > > >> > > >> >>>> >>>> > So, after looking at the Crosswalk code
> again,
> >>> > > > >> > > >> >>>> >>>> > I've decided to
> >>> > > > >> > > >> take
> >>> > > > >> > > >> >>>> a
> >>> > > > >> > > >> >>>> >>>> > quick stab at making things pluggable.  I
> don't
> >>> > > > >> > > >> >>>> >>>> > have a lot to
> >>> > > > >> > > >> show
> >>> > > > >> > > >> >>>> for
> >>> > > > >> > > >> >>>> >>>> > it, but with the help of Eclipse (which is
> why
> >>> > > > >> > > >> >>>> >>>> > the generated interfaces look so screwed
> up), I
> >>> > > > >> > > >> >>>> >>>> > managed to create some
> >>> > > > >> > > >> interfaces
> >>> > > > >> > > >> >>>> so
> >>> > > > >> > > >> >>>> >>>> > we can start shoehorning in other browser
> >>> > renderers.
> >>> > > > >> > > >> >>>> >>>> >
> >>> > > > >> > > >> >>>> >>>> >
> >>> > > > >> > > >>
> >>> https://github.com/infil00p/cordova-android/tree/pluggable_w
> >>> > > > >> > > >> eb
> >>> > > > >> > > >> vie
> >>> > > > >> > > >> w
> >>> > > > >> > > >> >>>> >>>> >
> >>> > > > >> > > >> >>>> >>>> > I'm going to probably start with Crosswalk,
> >>> > > > >> > > >> >>>> >>>> > because it's
> >>> > > > >> > > >> probably
> >>> > > > >> > > >> >>>> the
> >>> > > > >> > > >> >>>> >>>> > most mature primary candidate in the
> Android
> >>> > > > >> > > >> >>>> >>>> > Third-Party
> >>> > > > >> > > >> WebView
> >>> > > > >> > > >> >>>> >>>> > thing, and I'm pretty sure the GeckoView
> will
> >>> be
> >>> > > > >> > > >> >>>> >>>> > happening
> >>> > > > >> > > >> shortly
> >>> > > > >> > > >> >>>> >>>> > after.
> >>> > > > >> > > >> >>>> >>>> >
> >>> > > > >> > > >> >>>> >>>> > I don't know how this would work w.r.t.
> the CLI
> >>> > > > >> > > >> >>>> >>>> > or our
> >>> > > > >> > > >> workflow at
> >>> > > > >> > > >> >>>> >>>> > all, but at the moment, I really just want
> to
> >>> at
> >>> > > > >> > > >> >>>> >>>> > least start
> >>> > > > >> > > >> to have
> >>> > > > >> > > >> >>>> >>>> > some headway towards 4.x and PhoneGap day.
> >>> > > > >> > > >> >>>> >>>> >
> >>> > > > >> > > >> >>>> >>>> > What do people think of this so far? I'm
> going
> >>> > > > >> > > >> >>>> >>>> > to try to clean
> >>> > > > >> > > >> >>>> things
> >>> > > > >> > > >> >>>> >>>> > up a bit, since we've definitely done a
> lot of
> >>> > > > >> > > >> >>>> >>>> > things that
> >>> > > > >> > > >> would
> >>> > > > >> > > >> >>>> make
> >>> > > > >> > > >> >>>> >>>> > first year CS profs freak the hell out
> (i.e.
> >>> > > > >> > > >> >>>> >>>> > public members in
> >>> > > > >> > > >> >>>> public
> >>> > > > >> > > >> >>>> >>>> > objects w.r.t. PluginManager).
> >>> > > > >> > > >> >>>> >>>> >
> >>> > > > >> > > >> >>>> >>>> > Thoughts?
> >>> > > > >> > > >> >>>> >>>> >
> >>> > > > >> > > >> >>>> >>>> > Joe
> >>> > > > >> > > >> >>>> >>>> >
> >>> > > > >> > > >> >>>> >>>>
> >>> > > > >> > > >> >>>> >>>
> >>> > > > >> > > >> >>>> >>>
> >>> > > > >> > > >> >>>>
> >>> > > > >> > > >>
> >>> > > > >> >
> >>> >
> >>>
>

Re: [Android] Refactoring for different engines

[Ian Clelland <ic...@chromium.org>]

That's some close timing -- I just pushed my branches to github :)

I've pushed a branch at
https://github.com/clelland/cordova-crosswalk-engine/tree/fix-plugin1 that
basically covers your commit up to 158fea7, with the small tweak that I
mentioned about not re-casting to XWalkCordovaWebView when not necessary.

The other branch is
https://github.com/clelland/cordova-android/tree/pluggable_webview, and
moves the client-creation logic entirely into the webview classes.

I'm not entirely happy with it, since Cordova has had the feature that
users can override the creation of the WebViewClient and ChromeClient
themselves, in their Activity subclass, and we've lost that with my branch.
I want to re-work it to allow those methods to be used, if they exist, but
let the WebView handle creation entirely on its own if they don't.

I'll take a look at your branches in the morning; it's getting late here...
I appreciate you working with us to get this working!

Talk to you tomorrow on the hangout (some time)

Ian



On Thu, Apr 24, 2014 at 10:02 PM, Hu, Ningxin <ni...@intel.com> wrote:

>  > I think that we could do this differently. I would rather see the
> functionality of CordovaActivity.makeWebViewClient and
> CordovaActivity.makeChromeClient moved into the AndroidWebView class, and
> declared as methods in the CordovaWebView interface. Then we would override
> them in XWalkCordovaWebView to do the right thing.
>
> > The extra string manipulation magic, and reflection, that this patch
> introduces, seems wrong to me. Considering that we already have methods in
> XWalkCordovaWebView to construct those objects, then we should let the
> XWalkCordovaWebView construct them.
>
>
>
> Agree with your solution. It sounds better to me. I've updated the PR to
> implement it. Please take another look.
>
>
>
> > (I do like your method of iterating over the constructors, though -- I'm
> going to try to use that code in makeWebView as well)
>
>
>
> Thanks. I've implemented it in the PR update. Please review.
>
>
>
> -ningxin
>
>
>
> *From:* iclelland@google.com [mailto:iclelland@google.com] *On Behalf Of *Ian
> Clelland
> *Sent:* Thursday, April 24, 2014 11:58 PM
> *To:* Hu, Ningxin
> *Cc:* Joe Bowser; dev@cordova.apache.org
>
> *Subject:* Re: [Android] Refactoring for different engines
>
>
>
>
>
>
>
> On Thu, Apr 24, 2014 at 5:27 AM, Hu, Ningxin <ni...@intel.com> wrote:
>
> > Mobilespec runs on my N4, with 10 failing tests: 3 in contacts; 7 in
> file-transfer. Otherwise, things seem to be working pretty well.
>
>
>
> I checked out the latest code (@691fbce540) and build mbilespec with
> Crosswalk 6.35.127.0. However, it runs on the default Android WebView due
> to the InvocationTargetException when calling constructors of
> XWalkWebChromeClient and XWalkClient. I fixed it at:
> https://github.com/infil00p/cordova-crosswalk-engine/pull/6.
>
>
>
> This looks good, I've pulled that in locally.
>
>
>
>
>
> To make the plugins work on cordova-crosswalk-engine, it still needs to
> set correct webview client, chrome client and enable the
> setNetworkAvailable. I've sent another two PRs.
>
> https://github.com/infil00p/cordova-crosswalk-engine/pull/7
>
> https://github.com/infil00p/cordova-android/pull/3
>
>
>
> I think that we could do this differently. I would rather see the
> functionality of CordovaActivity.makeWebViewClient and
> CordovaActivity.makeChromeClient moved into the AndroidWebView class, and
> declared as methods in the CordovaWebView interface. Then we would override
> them in XWalkCordovaWebView to do the right thing.
>
>
>
> The extra string manipulation magic, and reflection, that this patch
> introduces, seems wrong to me. Considering that we already have methods in
> XWalkCordovaWebView to construct those objects, then we should let the
> XWalkCordovaWebView construct them.
>
>
>
> (I do like your method of iterating over the constructors, though -- I'm
> going to try to use that code in makeWebView as well)
>
>
>
>
>
> After these fixes (and with three fixes in plugins to use
> getPluginManager() interface), I can run the mobilespec "Run All Tests" on
> Crosswalk with all passed except Media test. The Media.js seems not be
> loaded. I didn't have chance to debug it yet.
>
>
>
> Ian and Joe, could you please review the PRs? I would appreciate that.
>
>
>
> > I've issued a pull request at
> https://github.com/infil00p/cordova-crosswalk-engine/pull/5 for it -- I'm
> not sure if there's a way to keep compatibility with last week's Crosswalk,
> or if we'd even want to. (Ningxin, if you could take a look at that PR and
> see if it makes sense, I'd appreciate it)
>
>
>
> The PR LGTM! Thanks for the update.
>
>
>
> For crosswalk embedding API compatibility, currently we track the master
> branch of Crosswalk (a.k.a Canary release channel), the embedding API in
> master is still under development. As planned, the Crosswalk-6 will be
> branched for beta in 4th May. In that branch, the embedding API will be
> stable and only accept bug fixing. So for cordova-crosswalk-engine, we can
> also have crosswalk-6 branch to track beta branch (later stable branch) and
> using master to track the latest crosswalk.
>
>
>
> Are people also going to use older (1-4) versions of Crosswalk? Or is the
> plan to encourage people to only use either stable or beta versions?
>
>
>
> I am even thinking about we can setup some bots (as buildbots in
> crosswalk) to track if any patches to crosswalk break the
> cordova-crosswalk-engine.
>
>
>
> Your thoughts?
>
>
>
> That would be good to have -- I'd like to have some kind of warning that
> new changes in the upstream project break the plugin :)
>
>
>
>
>
> Thanks,
>
> -ningxin
>
>
>
> *From:* iclelland@google.com [mailto:iclelland@google.com] *On Behalf Of *Ian
> Clelland
> *Sent:* Thursday, April 24, 2014 1:32 AM
> *To:* dev@cordova.apache.org
> *Cc:* Joe Bowser; Hu, Ningxin
>
>
> *Subject:* Re: [Android] Refactoring for different engines
>
>
>
> I've managed to get this up and running now -- great work on this, Joe!
>
>
>
> Mobilespec runs on my N4, with 10 failing tests: 3 in contacts; 7 in
> file-transfer. Otherwise, things seem to be working pretty well.
>
>
>
> I used a new build of Crosswalk, and found that the embedding API has
> changed since the weekend (when Ningxin's patches applied). I've issued a
> pull request at
> https://github.com/infil00p/cordova-crosswalk-engine/pull/5 for it -- I'm
> not sure if there's a way to keep compatibility with last week's Crosswalk,
> or if we'd even want to. (Ningxin, if you could take a look at that PR and
> see if it makes sense, I'd appreciate it)
>
>
>
> Joe, I also had to patch the default constructor for XWalkCordovaWebView;
> it wasn't creating its own client objects, so it got the default ones, and
> most of the tests were failing because some component of the bridge wan't
> working. https://github.com/infil00p/cordova-crosswalk-engine/pull/4 is
> out for that.
>
>
>
> Count me in for the hangout -- this is exciting stuff
>
>
>
> Ian
>
>
>
> On Wed, Apr 23, 2014 at 10:26 AM, Brian LeRoux <b...@brian.io> wrote:
>
> Yup I'll track em down
>
> On Apr 23, 2014 7:17 AM, "Andrew Grieve" <ag...@chromium.org> wrote:
>
> > Does anyone have a contact at moz that we could invite?
> >
> > On Wed, Apr 23, 2014 at 10:09 AM, Andrew Grieve <ag...@chromium.org>
> > wrote:
> > > Depends on their interest level I think. Faster we can get this out
> > > the door the better. If we need to delay for geckoview, then I don't
> > > think we should gate on it, just release it after.
> > >
> > > On Wed, Apr 23, 2014 at 3:01 AM, Tommy Williams <to...@devgeeks.org>
> > wrote:
> > >> More engines, more better...
> > >> On 23 Apr 2014 16:32, "Joe Bowser" <bo...@gmail.com> wrote:
> > >>
> > >>> Hey
> > >>>
> > >>> A Hangout would have to happen on Friday at the earliest.  It'd be
> > good if
> > >>> we could get someone from Mozilla on the hangout as well.  I haven't
> > gotten
> > >>> MozillaView (GeckoView with Cordova methods) fully working yet.  For
> > some
> > >>> reason it's not rendering on the screen.
> > >>>
> > >>> Ideally it'd be cool to have at least two options when this feature
> > finally
> > >>> lands.
> > >>>
> > >>> What do other people think?
> > >>>
> > >>> Joe
> > >>> On 22 Apr 2014 20:06, "Hu, Ningxin" <ni...@intel.com> wrote:
> > >>>
> > >>> > Joe,
> > >>> >
> > >>> > Thanks for your review and merge the PRs.
> > >>> >
> > >>> > To pluggable webview interest group:
> > >>> > Are we OK to setup a hangout this week for initial introduction and
> > >>> > discussion of next steps?
> > >>> >
> > >>> > Thanks,
> > >>> > -ningxin
> > >>> >
> > >>> > > -----Original Message-----
> > >>> > > From: Hu, Ningxin [mailto:ningxin.hu@intel.com]
> > >>> > > Sent: Tuesday, April 22, 2014 4:04 PM
> > >>> > > To: dev@cordova.apache.org
> > >>> > > Subject: RE: [Android] Refactoring for different engines
> > >>> > >
> > >>> > > The PoC is great! Quite excited about the direction!
> > >>> > >
> > >>> > > I've sent a PR to update the cordova-crosswalk-engine to latest
> > >>> crosswalk
> > >>> > > embedding API. It works with xwalk_core_library at 6.35.124.0.
> > >>> > >
> > >>> > > I've also changed the CordovaWebView interface slightly (adding
> > >>> > getView() API)
> > >>> > > to allow XWalkCordovaWebView to composite a XWalkView instead of
> > >>> > extending
> > >>> > > it. It resolves some API naming issues for XWalkView case.
> > >>> > >
> > >>> > > Please review them at:
> > >>> > > https://github.com/infil00p/cordova-crosswalk-engine/pull/3
> > >>> > > https://github.com/infil00p/cordova-android/pull/2
> > >>> > >
> > >>> > > Thanks,
> > >>> > > -ningxin
> > >>> > >
> > >>> > > > -----Original Message-----
> > >>> > > > From: Joe Bowser [mailto:bowserj@gmail.com]
> > >>> > > > Sent: Friday, April 11, 2014 12:45 AM
> > >>> > > > To: dev
> > >>> > > > Subject: Re: [Android] Refactoring for different engines
> > >>> > > >
> > >>> > > > Yeah, I'd be cool with setting up a hangout.  Everyone should
> > take a
> > >>> > > > look at the PoC, I've basically distilled it down to four or
> five
> > >>> > > > classes so far, but with some work, we may be able to get it
> > down to
> > >>> > > > three.  Due to legacy, we're pretty stuck with the Android
> > WebView
> > >>> API
> > >>> > calls,
> > >>> > > but these can probably be modified.
> > >>> > > >
> > >>> > > > It'd be good to get Mozilla people on the call as well, since
> > they
> > >>> > > > have their WebView as well.
> > >>> > > >
> > >>> > > > On Thu, Apr 10, 2014 at 9:38 AM, Hu, Ningxin <
> > ningxin.hu@intel.com>
> > >>> > wrote:
> > >>> > > > > Hangout would be a good idea.
> > >>> > > > >
> > >>> > > > > FYI, I will be off next week. How about the week after next?
> > If it
> > >>> > > > > works, please
> > >>> > > > feel free to schedule one and count me in.
> > >>> > > > >
> > >>> > > > > Thanks,
> > >>> > > > > -ningxin
> > >>> > > > >
> > >>> > > > >> -----Original Message-----
> > >>> > > > >> From: mmocny@google.com [mailto:mmocny@google.com] On
> Behalf
> > Of
> > >>> > > > >> Michal Mocny
> > >>> > > > >> Sent: Tuesday, April 08, 2014 11:39 PM
> > >>> > > > >> To: dev
> > >>> > > > >> Subject: Re: [Android] Refactoring for different engines
> > >>> > > > >>
> > >>> > > > >> Would it be alright to set up a Hangout some time to
> introduce
> > >>> > everyone?
> > >>> > > > >>
> > >>> > > > >> Joe has been leading the effort here, but there are other
> > cordova
> > >>> > > > >> contributors for whom this is top priority.  It would be
> nice
> > if
> > >>> we
> > >>> > > > >> could all meet to say hello and make sure we are all going
> in
> > the
> > >>> > > > >> right
> > >>> > > > direction.
> > >>> > > > >>
> > >>> > > > >> Quite exciting!
> > >>> > > > >>
> > >>> > > > >> -Michal
> > >>> > > > >>
> > >>> > > > >>
> > >>> > > > >> On Tue, Apr 8, 2014 at 10:56 AM, Hu, Ningxin <
> > >>> ningxin.hu@intel.com>
> > >>> > > wrote:
> > >>> > > > >>
> > >>> > > > >> > Joe, thanks for this. I am very excited.
> > >>> > > > >> >
> > >>> > > > >> > FYI. Crosswalk team is working on refactoring the WebView
> > API to
> > >>> > > > >> > support embedding usage better [1]. (Previously the layer
> > API
> > >>> was
> > >>> > > > >> > not exposed as public usage).
> > >>> > > > >> >
> > >>> > > > >> > I would like to review the PoC and work with you to get
> > >>> Crosswalk
> > >>> > > > >> > fits into the pluggable WebView architecture.
> > >>> > > > >> >
> > >>> > > > >> > Thanks,
> > >>> > > > >> > -ningxin
> > >>> > > > >> >
> > >>> > > > >> > > -----Original Message-----
> > >>> > > > >> > > From: Joe Bowser [mailto:bowserj@gmail.com]
> > >>> > > > >> > > Sent: Wednesday, March 19, 2014 7:08 AM
> > >>> > > > >> > > To: dev
> > >>> > > > >> > > Subject: Re: [Android] Refactoring for different engines
> > >>> > > > >> > >
> > >>> > > > >> > > Hey
> > >>> > > > >> > >
> > >>> > > > >> > > After debugging, I did some minor updates to the plugin
> > >>> README.
> > >>> > > > >> > > It
> > >>> > > > >> > should be
> > >>> > > > >> > > easier to get this up and running, although there's
> still
> > the
> > >>> > > > >> > > issue of
> > >>> > > > >> > after-install
> > >>> > > > >> > > hooks and the relative path weirdness with the Crosswalk
> > >>> > Library itself.
> > >>> > > > >> > >
> > >>> > > > >> > > It still doesn't support the CLI at all, but it should
> be
> > >>> there
> > >>> > > > >> > > with the
> > >>> > > > >> > old flow.
> > >>> > > > >> > >
> > >>> > > > >> > > On Mon, Mar 17, 2014 at 1:14 PM, Michal Mocny
> > >>> > > > >> > > <mm...@chromium.org>
> > >>> > > > >> > > wrote:
> > >>> > > > >> > > > (Sorry Joe, Googlers are down in California and way
> > busy.
> > >>> > > > >> > > > Will be back in a week.  Super excited about this,
> > though.)
> > >>> > > > >> > > >
> > >>> > > > >> > > > -Michal
> > >>> > > > >> > > >
> > >>> > > > >> > > >
> > >>> > > > >> > > > On Mon, Mar 17, 2014 at 2:53 PM, Joe Bowser
> > >>> > > > >> > > > <bo...@gmail.com>
> > >>> > > > >> wrote:
> > >>> > > > >> > > >
> > >>> > > > >> > > >> Reviving this thread!
> > >>> > > > >> > > >>
> > >>> > > > >> > > >> Can other people look at this, and see if/when we
> > should
> > >>> > land this?
> > >>> > > > >> > > >> I know that I have to re-write the tests still, but I
> > would
> > >>> > > > >> > > >> like some feedback before merging it in.  Also, it'd
> be
> > >>> > > > >> > > >> super awesome if other people could try and make a
> > WebView
> > >>> > > > >> > > >> based on the interfaces and recommend which methods
> > should
> > >>> > > > >> > > >> die.  I want to get this released in the next month
> or
> > so,
> > >>> > > > >> > > >> so any time and feedback would be greatly
> appreciated.
> > >>> > > > >> > > >>
> > >>> > > > >> > > >> Thanks
> > >>> > > > >> > > >>
> > >>> > > > >> > > >> On Thu, Mar 13, 2014 at 3:50 PM, Joe Bowser
> > >>> > > > >> > > >> <bo...@gmail.com>
> > >>> > > > >> > wrote:
> > >>> > > > >> > > >> > Hey, I created the following today to track various
> > >>> > > > >> > > >> > WebView
> > >>> > > > >> > progresses:
> > >>> > > > >> > > >> > https://issues.apache.org/jira/browse/CB-6246
> > >>> > > > >> > > >> >
> > >>> > > > >> > > >> > I also have this repo created.  The licensing is
> > ugly as
> > >>> > > > >> > > >> > all crap, but it's a Proof-Of-Concept:
> > >>> > > > >> > > >> >
> https://github.com/infil00p/cordova-crosswalk-engine
> > >>> > > > >> > > >> >
> > >>> > > > >> > > >> > If I can get some help getting plugman to just load
> > >>> > > > >> > > >> > Crosswalk, it'll
> > >>> > > > >> > > >> look hawt.
> > >>> > > > >> > > >> >
> > >>> > > > >> > > >> > BTW: We should probably get this ready to go into
> > Android
> > >>> > > > >> > > >> > in the next two months and deprecate the
> setProperty
> > >>> > > > >> > > >> > methods, since all properties should be preferences
> > in
> > >>> > config.xml
> > >>> > > now.
> > >>> > > > >> > > >> >
> > >>> > > > >> > > >> > On Mon, Mar 10, 2014 at 2:42 PM, Joe Bowser
> > >>> > > > >> > > >> > <bo...@gmail.com>
> > >>> > > > >> > > wrote:
> > >>> > > > >> > > >> >> Perhaps. There would be additional benefits to
> this
> > >>> > > > >> > > >> >> approach, namely fixes being added to that
> platform
> > more
> > >>> > > > >> > > >> >> quickly.  I'll probably take a look at that once I
> > have
> > >>> > > > >> > > >> >> Crosswalk
> > >>> > > > finalized.
> > >>> > > > >> > > >> >>
> > >>> > > > >> > > >> >> On Mon, Mar 10, 2014 at 9:49 AM, Brian LeRoux
> > >>> > > > >> > > >> >> <b...@brian.io>
> > >>> > > > wrote:
> > >>> > > > >> > > >> >>> this is great stuff
> > >>> > > > >> > > >> >>>
> > >>> > > > >> > > >> >>> do we think it may be possible to bring in amazon
> > >>> fireos
> > >>> > > > >> > > >> >>> stuff
> > >>> > > > >> > > >> eventually
> > >>> > > > >> > > >> >>> too?
> > >>> > > > >> > > >> >>>
> > >>> > > > >> > > >> >>>
> > >>> > > > >> > > >> >>> On Fri, Mar 7, 2014 at 3:22 PM, Joe Bowser
> > >>> > > > >> > > >> >>> <bo...@gmail.com>
> > >>> > > > >> > wrote:
> > >>> > > > >> > > >> >>>
> > >>> > > > >> > > >> >>>> BTW: I committed it in my repo, not the main
> > Apache
> > >>> one.
> > >>> > > > >> > > >> >>>>
> > >>> > > > >> > > >> >>>> On Fri, Mar 7, 2014 at 3:21 PM, Joe Bowser
> > >>> > > > >> > > >> >>>> <bo...@gmail.com>
> > >>> > > > >> > > wrote:
> > >>> > > > >> > > >> >>>> > Hey
> > >>> > > > >> > > >> >>>> >
> > >>> > > > >> > > >> >>>> > I just committed some code based on their
> > WebView
> > >>> > > > >> > > >> >>>> > modifications that allows you to choose your
> > >>> renderer
> > >>> > > > >> > > >> >>>> > in the
> > >>> > > > >> > config file
> > >>> > > > >> > > with this:
> > >>> > > > >> > > >> >>>> >
> > >>> > > > >> > > >> >>>> >     <preference name="webView"
> > >>> > > > >> > > >> >>>> >
> > >>> value="org.apache.cordova.engine.crosswalk.XWalkCordo
> > >>> > > > >> > > >> >>>> > va
> > >>> > > > >> > > >> >>>> > Web
> > >>> > > > >> > > >> >>>> > View
> > >>> > > > >> > > >> >>>> > " />
> > >>> > > > >> > > >> >>>> >
> > >>> > > > >> > > >> >>>> > You currently have to copy over the *.pak file
> > and
> > >>> > > > >> > > >> >>>> > the jsapi from a Crosswalk Example project to
> > get
> > >>> > > > >> > > >> >>>> > this to work.  The next thing that I'm going
> to
> > do
> > >>> is
> > >>> > > > >> > > >> >>>> > figure out how to write this as a plugin and
> > have it
> > >>> > > > >> > > >> >>>> > install on a default
> > >>> > > > project.
> > >>> > > > >> > > >> >>>> > Also, right now the bridge doesn't seem to
> > work, and
> > >>> > > > >> > > >> >>>> > I don't know why exactly.  That being said,
> the
> > >>> > > > >> > > >> fact
> > >>> > > > >> > > >> >>>> > that I can choose which version of
> > Chrome/Chromium
> > >>> > > > >> > > >> >>>> > I'm running with
> > >>> > > > >> > > >> a
> > >>> > > > >> > > >> >>>> > single XML preference is HUGE.
> > >>> > > > >> > > >> >>>> >
> > >>> > > > >> > > >> >>>> > There's definitely a lot more work that needs
> > to be
> > >>> > > > >> > > >> >>>> > done, but as
> > >>> > > > >> > > >> long
> > >>> > > > >> > > >> >>>> > as we have something that we can fit into the
> > >>> > > > >> > > >> >>>> > interface, we should
> > >>> > > > >> > > >> be
> > >>> > > > >> > > >> >>>> > able to put in things like GeckoView or other
> > third
> > >>> > > > >> > > >> >>>> > party
> > >>> > > > >> > renderers.
> > >>> > > > >> > > >> >>>> > The nightmare of being stuck with bullshit
> > WebView
> > >>> > > > >> > > >> >>>> > bugs may soon be over.
> > >>> > > > >> > > >> >>>> >
> > >>> > > > >> > > >> >>>> > On Wed, Mar 5, 2014 at 8:59 PM, Michal Mocny
> > >>> > > > >> > > >> >>>> > <mm...@chromium.org>
> > >>> > > > >> > > >> >>>> wrote:
> > >>> > > > >> > > >> >>>> >>
> > >>> https://github.com/crosswalk-project/crosswalk-cordo
> > >>> > > > >> > > >> >>>> >> va
> > >>> > > > >> > > >> >>>> >> -an
> > >>> > > > >> > > >> >>>> >> droi
> > >>> > > > >> > > >> >>>> >> d
> > >>> > > > >> > > >> >>>> >>
> > >>> > > > >> > > >> >>>> >> First patch they landed, which claims to have
> > min
> > >>> > > > >> > > >> >>>> >> viable xwalk
> > >>> > > > >> > > >> webview:
> > >>> > > > >> > > >> >>>> >>
> > >>> > > > >> > > >> >>>>
> > >>> > > > >> > > >>
> > >>> https://github.com/crosswalk-project/crosswalk-cordova-andro
> > >>> > > > >> > > >> id
> > >>> > > > >> > > >> /co
> > >>> > > > >> > > >> mmit
> > >>> > > > >> > > >> /a04dedeb0204e7542d190312c6ae70c795a26e04
> > >>> > > > >> > > >> >>>> >>
> > >>> > > > >> > > >> >>>> >>
> > >>> > > > >> > > >> >>>> >> On Wed, Mar 5, 2014 at 11:37 PM, Michal Mocny
> > >>> > > > >> > > >> >>>> >> <mmocny@chromium.org
> > >>> > > > >> > > >> >
> > >>> > > > >> > > >> >>>> wrote:
> > >>> > > > >> > > >> >>>> >>
> > >>> > > > >> > > >> >>>> >>> I haven't looked yet, but did you see:
> > >>> > > > >> > > >> >>>> >>>
> > >>> https://crosswalk-project.org/#wiki/crosswalk-cordo
> > >>> > > > >> > > >> >>>> >>> va
> > >>> > > > >> > > >> >>>> >>> -an
> > >>> > > > >> > > >> >>>> >>> droi
> > >>> > > > >> > > >> >>>> >>> d
> > >>> > > > >> > > >> >>>> >>>
> > >>> > > > >> > > >> >>>> >>> ?
> > >>> > > > >> > > >> >>>> >>>
> > >>> > > > >> > > >> >>>> >>>
> > >>> > > > >> > > >> >>>> >>> On Wed, Mar 5, 2014 at 10:20 PM, Andrew
> > Grieve <
> > >>> > > > >> > > >> agrieve@chromium.org
> > >>> > > > >> > > >> >>>> >wrote:
> > >>> > > > >> > > >> >>>> >>>
> > >>> > > > >> > > >> >>>> >>>> First - very excited that you're working on
> > this!
> > >>> > > > >> > > >> >>>> >>>>
> > >>> > > > >> > > >> >>>> >>>> Had a quick look. Not sure there's much to
> be
> > >>> > gleaned
> > >>> > > yet.
> > >>> > > > >> > > >> >>>> >>>> Once
> > >>> > > > >> > > >> you
> > >>> > > > >> > > >> >>>> start
> > >>> > > > >> > > >> >>>> >>>> in on hooking up x-walk's webview I think
> it
> > will
> > >>> > > > >> > > >> >>>> >>>> become more
> > >>> > > > >> > > >> obvious
> > >>> > > > >> > > >> >>>> what
> > >>> > > > >> > > >> >>>> >>>> the interface should look like. E.g., does
> > x-walk
> > >>> > > > >> > > >> >>>> >>>> even have the
> > >>> > > > >> > > >> >>>> concept of
> > >>> > > > >> > > >> >>>> >>>> ChromeClient vs WebViewClient vs WebView?
> > Also
> > >>> > > > >> > > >> >>>> >>>> unsure whether the
> > >>> > > > >> > > >> >>>> class
> > >>> > > > >> > > >> >>>> >>>> should extend android.View as well as
> > implement
> > >>> > > > >> > > >> >>>> >>>> our
> > >>> > > > >> > interface.
> > >>> > > > >> > > >> E.g.
> > >>> > > > >> > > >> >>>> >>>> alternative is to have a "getView()" method
> > on
> > >>> the
> > >>> > > > >> > interface.
> > >>> > > > >> > > >> Might
> > >>> > > > >> > > >> >>>> help
> > >>> > > > >> > > >> >>>> >>>> to
> > >>> > > > >> > > >> >>>> >>>> cut down on file sizes, and API surface,
> but
> > >>> > > > >> > > >> >>>> >>>> again, I'm not too
> > >>> > > > >> > > >> sure.
> > >>> > > > >> > > >> >>>> >>>>
> > >>> > > > >> > > >> >>>> >>>> I've been pretty hesitant to touch existing
> > >>> > > > >> > > >> >>>> >>>> exposed members
> > >>> > > > >> > > >> (e.g. the
> > >>> > > > >> > > >> >>>> >>>> public fields you were referring to) since
> > >>> > > > >> > > >> >>>> >>>> touching anything
> > >>> > > > >> > > >> public
> > >>> > > > >> > > >> >>>> could
> > >>> > > > >> > > >> >>>> >>>> break plugins. That said, maybe now is a
> good
> > >>> time
> > >>> > > > >> > > >> >>>> >>>> to @deprecate
> > >>> > > > >> > > >> a
> > >>> > > > >> > > >> >>>> bunch
> > >>> > > > >> > > >> >>>> >>>> of
> > >>> > > > >> > > >> >>>> >>>> them and either replace them with getters,
> or
> > >>> just
> > >>> > > > >> > > >> >>>> >>>> declare them
> > >>> > > > >> > > >> to be
> > >>> > > > >> > > >> >>>> not
> > >>> > > > >> > > >> >>>> >>>> exposed to plugins.
> > >>> > > > >> > > >> >>>> >>>>
> > >>> > > > >> > > >> >>>> >>>>
> > >>> > > > >> > > >> >>>> >>>> On Wed, Mar 5, 2014 at 6:57 PM, Joe Bowser
> > >>> > > > >> > > >> >>>> >>>> <bo...@gmail.com>
> > >>> > > > >> > > >> wrote:
> > >>> > > > >> > > >> >>>> >>>>
> > >>> > > > >> > > >> >>>> >>>> > So, after looking at the Crosswalk code
> > again,
> > >>> > > > >> > > >> >>>> >>>> > I've decided to
> > >>> > > > >> > > >> take
> > >>> > > > >> > > >> >>>> a
> > >>> > > > >> > > >> >>>> >>>> > quick stab at making things pluggable.  I
> > don't
> > >>> > > > >> > > >> >>>> >>>> > have a lot to
> > >>> > > > >> > > >> show
> > >>> > > > >> > > >> >>>> for
> > >>> > > > >> > > >> >>>> >>>> > it, but with the help of Eclipse (which
> is
> > why
> > >>> > > > >> > > >> >>>> >>>> > the generated interfaces look so screwed
> > up), I
> > >>> > > > >> > > >> >>>> >>>> > managed to create some
> > >>> > > > >> > > >> interfaces
> > >>> > > > >> > > >> >>>> so
> > >>> > > > >> > > >> >>>> >>>> > we can start shoehorning in other browser
> > >>> > renderers.
> > >>> > > > >> > > >> >>>> >>>> >
> > >>> > > > >> > > >> >>>> >>>> >
> > >>> > > > >> > > >>
> > >>> https://github.com/infil00p/cordova-android/tree/pluggable_w
> > >>> > > > >> > > >> eb
> > >>> > > > >> > > >> vie
> > >>> > > > >> > > >> w
> > >>> > > > >> > > >> >>>> >>>> >
> > >>> > > > >> > > >> >>>> >>>> > I'm going to probably start with
> Crosswalk,
> > >>> > > > >> > > >> >>>> >>>> > because it's
> > >>> > > > >> > > >> probably
> > >>> > > > >> > > >> >>>> the
> > >>> > > > >> > > >> >>>> >>>> > most mature primary candidate in the
> > Android
> > >>> > > > >> > > >> >>>> >>>> > Third-Party
> > >>> > > > >> > > >> WebView
> > >>> > > > >> > > >> >>>> >>>> > thing, and I'm pretty sure the GeckoView
> > will
> > >>> be
> > >>> > > > >> > > >> >>>> >>>> > happening
> > >>> > > > >> > > >> shortly
> > >>> > > > >> > > >> >>>> >>>> > after.
> > >>> > > > >> > > >> >>>> >>>> >
> > >>> > > > >> > > >> >>>> >>>> > I don't know how this would work w.r.t.
> > the CLI
> > >>> > > > >> > > >> >>>> >>>> > or our
> > >>> > > > >> > > >> workflow at
> > >>> > > > >> > > >> >>>> >>>> > all, but at the moment, I really just
> want
> > to
> > >>> at
> > >>> > > > >> > > >> >>>> >>>> > least start
> > >>> > > > >> > > >> to have
> > >>> > > > >> > > >> >>>> >>>> > some headway towards 4.x and PhoneGap
> day.
> > >>> > > > >> > > >> >>>> >>>> >
> > >>> > > > >> > > >> >>>> >>>> > What do people think of this so far? I'm
> > going
> > >>> > > > >> > > >> >>>> >>>> > to try to clean
> > >>> > > > >> > > >> >>>> things
> > >>> > > > >> > > >> >>>> >>>> > up a bit, since we've definitely done a
> > lot of
> > >>> > > > >> > > >> >>>> >>>> > things that
> > >>> > > > >> > > >> would
> > >>> > > > >> > > >> >>>> make
> > >>> > > > >> > > >> >>>> >>>> > first year CS profs freak the hell out
> > (i.e.
> > >>> > > > >> > > >> >>>> >>>> > public members in
> > >>> > > > >> > > >> >>>> public
> > >>> > > > >> > > >> >>>> >>>> > objects w.r.t. PluginManager).
> > >>> > > > >> > > >> >>>> >>>> >
> > >>> > > > >> > > >> >>>> >>>> > Thoughts?
> > >>> > > > >> > > >> >>>> >>>> >
> > >>> > > > >> > > >> >>>> >>>> > Joe
> > >>> > > > >> > > >> >>>> >>>> >
> > >>> > > > >> > > >> >>>> >>>>
> > >>> > > > >> > > >> >>>> >>>
> > >>> > > > >> > > >> >>>> >>>
> > >>> > > > >> > > >> >>>>
> > >>> > > > >> > > >>
> > >>> > > > >> >
> > >>> >
> > >>>
> >
>
>
>
>
>

RE: [Android] Refactoring for different engines

["Hu, Ningxin" <ni...@intel.com>]

> I think that we could do this differently. I would rather see the functionality of CordovaActivity.makeWebViewClient and CordovaActivity.makeChromeClient moved into the AndroidWebView class, and declared as methods in the CordovaWebView interface. Then we would override them in XWalkCordovaWebView to do the right thing.
> The extra string manipulation magic, and reflection, that this patch introduces, seems wrong to me. Considering that we already have methods in XWalkCordovaWebView to construct those objects, then we should let the XWalkCordovaWebView construct them.

Agree with your solution. It sounds better to me. I've updated the PR to implement it. Please take another look.

> (I do like your method of iterating over the constructors, though -- I'm going to try to use that code in makeWebView as well)

Thanks. I've implemented it in the PR update. Please review.

-ningxin

From: iclelland@google.com [mailto:iclelland@google.com] On Behalf Of Ian Clelland
Sent: Thursday, April 24, 2014 11:58 PM
To: Hu, Ningxin
Cc: Joe Bowser; dev@cordova.apache.org
Subject: Re: [Android] Refactoring for different engines



On Thu, Apr 24, 2014 at 5:27 AM, Hu, Ningxin <ni...@intel.com>> wrote:
> Mobilespec runs on my N4, with 10 failing tests: 3 in contacts; 7 in file-transfer. Otherwise, things seem to be working pretty well.

I checked out the latest code (@691fbce540) and build mbilespec with Crosswalk 6.35.127.0. However, it runs on the default Android WebView due to the InvocationTargetException when calling constructors of XWalkWebChromeClient and XWalkClient. I fixed it at: https://github.com/infil00p/cordova-crosswalk-engine/pull/6.

This looks good, I've pulled that in locally.


To make the plugins work on cordova-crosswalk-engine, it still needs to set correct webview client, chrome client and enable the setNetworkAvailable. I've sent another two PRs.
https://github.com/infil00p/cordova-crosswalk-engine/pull/7
https://github.com/infil00p/cordova-android/pull/3

I think that we could do this differently. I would rather see the functionality of CordovaActivity.makeWebViewClient and CordovaActivity.makeChromeClient moved into the AndroidWebView class, and declared as methods in the CordovaWebView interface. Then we would override them in XWalkCordovaWebView to do the right thing.

The extra string manipulation magic, and reflection, that this patch introduces, seems wrong to me. Considering that we already have methods in XWalkCordovaWebView to construct those objects, then we should let the XWalkCordovaWebView construct them.

(I do like your method of iterating over the constructors, though -- I'm going to try to use that code in makeWebView as well)


After these fixes (and with three fixes in plugins to use getPluginManager() interface), I can run the mobilespec "Run All Tests" on Crosswalk with all passed except Media test. The Media.js seems not be loaded. I didn't have chance to debug it yet.

Ian and Joe, could you please review the PRs? I would appreciate that.

> I've issued a pull request at https://github.com/infil00p/cordova-crosswalk-engine/pull/5 for it -- I'm not sure if there's a way to keep compatibility with last week's Crosswalk, or if we'd even want to. (Ningxin, if you could take a look at that PR and see if it makes sense, I'd appreciate it)

The PR LGTM! Thanks for the update.

For crosswalk embedding API compatibility, currently we track the master branch of Crosswalk (a.k.a Canary release channel), the embedding API in master is still under development. As planned, the Crosswalk-6 will be branched for beta in 4th May. In that branch, the embedding API will be stable and only accept bug fixing. So for cordova-crosswalk-engine, we can also have crosswalk-6 branch to track beta branch (later stable branch) and using master to track the latest crosswalk.

Are people also going to use older (1-4) versions of Crosswalk? Or is the plan to encourage people to only use either stable or beta versions?

I am even thinking about we can setup some bots (as buildbots in crosswalk) to track if any patches to crosswalk break the cordova-crosswalk-engine.

Your thoughts?

That would be good to have -- I'd like to have some kind of warning that new changes in the upstream project break the plugin :)


Thanks,
-ningxin

From: iclelland@google.com<ma...@google.com> [mailto:iclelland@google.com<ma...@google.com>] On Behalf Of Ian Clelland
Sent: Thursday, April 24, 2014 1:32 AM
To: dev@cordova.apache.org<ma...@cordova.apache.org>
Cc: Joe Bowser; Hu, Ningxin

Subject: Re: [Android] Refactoring for different engines

I've managed to get this up and running now -- great work on this, Joe!

Mobilespec runs on my N4, with 10 failing tests: 3 in contacts; 7 in file-transfer. Otherwise, things seem to be working pretty well.

I used a new build of Crosswalk, and found that the embedding API has changed since the weekend (when Ningxin's patches applied). I've issued a pull request at https://github.com/infil00p/cordova-crosswalk-engine/pull/5 for it -- I'm not sure if there's a way to keep compatibility with last week's Crosswalk, or if we'd even want to. (Ningxin, if you could take a look at that PR and see if it makes sense, I'd appreciate it)

Joe, I also had to patch the default constructor for XWalkCordovaWebView; it wasn't creating its own client objects, so it got the default ones, and most of the tests were failing because some component of the bridge wan't working. https://github.com/infil00p/cordova-crosswalk-engine/pull/4 is out for that.

Count me in for the hangout -- this is exciting stuff

Ian

On Wed, Apr 23, 2014 at 10:26 AM, Brian LeRoux <b@...@brian.io>> wrote:
Yup I'll track em down
On Apr 23, 2014 7:17 AM, "Andrew Grieve" <ag...@chromium.org>> wrote:

> Does anyone have a contact at moz that we could invite?
>
> On Wed, Apr 23, 2014 at 10:09 AM, Andrew Grieve <ag...@chromium.org>>
> wrote:
> > Depends on their interest level I think. Faster we can get this out
> > the door the better. If we need to delay for geckoview, then I don't
> > think we should gate on it, just release it after.
> >
> > On Wed, Apr 23, 2014 at 3:01 AM, Tommy Williams <to...@devgeeks.org>>
> wrote:
> >> More engines, more better...
> >> On 23 Apr 2014 16:32, "Joe Bowser" <bo...@gmail.com>> wrote:
> >>
> >>> Hey
> >>>
> >>> A Hangout would have to happen on Friday at the earliest.  It'd be
> good if
> >>> we could get someone from Mozilla on the hangout as well.  I haven't
> gotten
> >>> MozillaView (GeckoView with Cordova methods) fully working yet.  For
> some
> >>> reason it's not rendering on the screen.
> >>>
> >>> Ideally it'd be cool to have at least two options when this feature
> finally
> >>> lands.
> >>>
> >>> What do other people think?
> >>>
> >>> Joe
> >>> On 22 Apr 2014 20:06, "Hu, Ningxin" <ni...@intel.com>> wrote:
> >>>
> >>> > Joe,
> >>> >
> >>> > Thanks for your review and merge the PRs.
> >>> >
> >>> > To pluggable webview interest group:
> >>> > Are we OK to setup a hangout this week for initial introduction and
> >>> > discussion of next steps?
> >>> >
> >>> > Thanks,
> >>> > -ningxin
> >>> >
> >>> > > -----Original Message-----
> >>> > > From: Hu, Ningxin [mailto:ningxin.hu@intel.com<ma...@intel.com>]
> >>> > > Sent: Tuesday, April 22, 2014 4:04 PM
> >>> > > To: dev@cordova.apache.org<ma...@cordova.apache.org>
> >>> > > Subject: RE: [Android] Refactoring for different engines
> >>> > >
> >>> > > The PoC is great! Quite excited about the direction!
> >>> > >
> >>> > > I've sent a PR to update the cordova-crosswalk-engine to latest
> >>> crosswalk
> >>> > > embedding API. It works with xwalk_core_library at 6.35.124.0.
> >>> > >
> >>> > > I've also changed the CordovaWebView interface slightly (adding
> >>> > getView() API)
> >>> > > to allow XWalkCordovaWebView to composite a XWalkView instead of
> >>> > extending
> >>> > > it. It resolves some API naming issues for XWalkView case.
> >>> > >
> >>> > > Please review them at:
> >>> > > https://github.com/infil00p/cordova-crosswalk-engine/pull/3
> >>> > > https://github.com/infil00p/cordova-android/pull/2
> >>> > >
> >>> > > Thanks,
> >>> > > -ningxin
> >>> > >
> >>> > > > -----Original Message-----
> >>> > > > From: Joe Bowser [mailto:bowserj@gmail.com<ma...@gmail.com>]
> >>> > > > Sent: Friday, April 11, 2014 12:45 AM
> >>> > > > To: dev
> >>> > > > Subject: Re: [Android] Refactoring for different engines
> >>> > > >
> >>> > > > Yeah, I'd be cool with setting up a hangout.  Everyone should
> take a
> >>> > > > look at the PoC, I've basically distilled it down to four or five
> >>> > > > classes so far, but with some work, we may be able to get it
> down to
> >>> > > > three.  Due to legacy, we're pretty stuck with the Android
> WebView
> >>> API
> >>> > calls,
> >>> > > but these can probably be modified.
> >>> > > >
> >>> > > > It'd be good to get Mozilla people on the call as well, since
> they
> >>> > > > have their WebView as well.
> >>> > > >
> >>> > > > On Thu, Apr 10, 2014 at 9:38 AM, Hu, Ningxin <
> ningxin.hu@intel.com<ma...@intel.com>>
> >>> > wrote:
> >>> > > > > Hangout would be a good idea.
> >>> > > > >
> >>> > > > > FYI, I will be off next week. How about the week after next?
> If it
> >>> > > > > works, please
> >>> > > > feel free to schedule one and count me in.
> >>> > > > >
> >>> > > > > Thanks,
> >>> > > > > -ningxin
> >>> > > > >
> >>> > > > >> -----Original Message-----
> >>> > > > >> From: mmocny@google.com<ma...@google.com> [mailto:mmocny@google.com<ma...@google.com>] On Behalf
> Of
> >>> > > > >> Michal Mocny
> >>> > > > >> Sent: Tuesday, April 08, 2014 11:39 PM
> >>> > > > >> To: dev
> >>> > > > >> Subject: Re: [Android] Refactoring for different engines
> >>> > > > >>
> >>> > > > >> Would it be alright to set up a Hangout some time to introduce
> >>> > everyone?
> >>> > > > >>
> >>> > > > >> Joe has been leading the effort here, but there are other
> cordova
> >>> > > > >> contributors for whom this is top priority.  It would be nice
> if
> >>> we
> >>> > > > >> could all meet to say hello and make sure we are all going in
> the
> >>> > > > >> right
> >>> > > > direction.
> >>> > > > >>
> >>> > > > >> Quite exciting!
> >>> > > > >>
> >>> > > > >> -Michal
> >>> > > > >>
> >>> > > > >>
> >>> > > > >> On Tue, Apr 8, 2014 at 10:56 AM, Hu, Ningxin <
> >>> ningxin.hu@intel.com<ma...@intel.com>>
> >>> > > wrote:
> >>> > > > >>
> >>> > > > >> > Joe, thanks for this. I am very excited.
> >>> > > > >> >
> >>> > > > >> > FYI. Crosswalk team is working on refactoring the WebView
> API to
> >>> > > > >> > support embedding usage better [1]. (Previously the layer
> API
> >>> was
> >>> > > > >> > not exposed as public usage).
> >>> > > > >> >
> >>> > > > >> > I would like to review the PoC and work with you to get
> >>> Crosswalk
> >>> > > > >> > fits into the pluggable WebView architecture.
> >>> > > > >> >
> >>> > > > >> > Thanks,
> >>> > > > >> > -ningxin
> >>> > > > >> >
> >>> > > > >> > > -----Original Message-----
> >>> > > > >> > > From: Joe Bowser [mailto:bowserj@gmail.com<ma...@gmail.com>]
> >>> > > > >> > > Sent: Wednesday, March 19, 2014 7:08 AM
> >>> > > > >> > > To: dev
> >>> > > > >> > > Subject: Re: [Android] Refactoring for different engines
> >>> > > > >> > >
> >>> > > > >> > > Hey
> >>> > > > >> > >
> >>> > > > >> > > After debugging, I did some minor updates to the plugin
> >>> README.
> >>> > > > >> > > It
> >>> > > > >> > should be
> >>> > > > >> > > easier to get this up and running, although there's still
> the
> >>> > > > >> > > issue of
> >>> > > > >> > after-install
> >>> > > > >> > > hooks and the relative path weirdness with the Crosswalk
> >>> > Library itself.
> >>> > > > >> > >
> >>> > > > >> > > It still doesn't support the CLI at all, but it should be
> >>> there
> >>> > > > >> > > with the
> >>> > > > >> > old flow.
> >>> > > > >> > >
> >>> > > > >> > > On Mon, Mar 17, 2014 at 1:14 PM, Michal Mocny
> >>> > > > >> > > <mm...@chromium.org>>
> >>> > > > >> > > wrote:
> >>> > > > >> > > > (Sorry Joe, Googlers are down in California and way
> busy.
> >>> > > > >> > > > Will be back in a week.  Super excited about this,
> though.)
> >>> > > > >> > > >
> >>> > > > >> > > > -Michal
> >>> > > > >> > > >
> >>> > > > >> > > >
> >>> > > > >> > > > On Mon, Mar 17, 2014 at 2:53 PM, Joe Bowser
> >>> > > > >> > > > <bo...@gmail.com>>
> >>> > > > >> wrote:
> >>> > > > >> > > >
> >>> > > > >> > > >> Reviving this thread!
> >>> > > > >> > > >>
> >>> > > > >> > > >> Can other people look at this, and see if/when we
> should
> >>> > land this?
> >>> > > > >> > > >> I know that I have to re-write the tests still, but I
> would
> >>> > > > >> > > >> like some feedback before merging it in.  Also, it'd be
> >>> > > > >> > > >> super awesome if other people could try and make a
> WebView
> >>> > > > >> > > >> based on the interfaces and recommend which methods
> should
> >>> > > > >> > > >> die.  I want to get this released in the next month or
> so,
> >>> > > > >> > > >> so any time and feedback would be greatly appreciated.
> >>> > > > >> > > >>
> >>> > > > >> > > >> Thanks
> >>> > > > >> > > >>
> >>> > > > >> > > >> On Thu, Mar 13, 2014 at 3:50 PM, Joe Bowser
> >>> > > > >> > > >> <bo...@gmail.com>>
> >>> > > > >> > wrote:
> >>> > > > >> > > >> > Hey, I created the following today to track various
> >>> > > > >> > > >> > WebView
> >>> > > > >> > progresses:
> >>> > > > >> > > >> > https://issues.apache.org/jira/browse/CB-6246
> >>> > > > >> > > >> >
> >>> > > > >> > > >> > I also have this repo created.  The licensing is
> ugly as
> >>> > > > >> > > >> > all crap, but it's a Proof-Of-Concept:
> >>> > > > >> > > >> > https://github.com/infil00p/cordova-crosswalk-engine
> >>> > > > >> > > >> >
> >>> > > > >> > > >> > If I can get some help getting plugman to just load
> >>> > > > >> > > >> > Crosswalk, it'll
> >>> > > > >> > > >> look hawt.
> >>> > > > >> > > >> >
> >>> > > > >> > > >> > BTW: We should probably get this ready to go into
> Android
> >>> > > > >> > > >> > in the next two months and deprecate the setProperty
> >>> > > > >> > > >> > methods, since all properties should be preferences
> in
> >>> > config.xml
> >>> > > now.
> >>> > > > >> > > >> >
> >>> > > > >> > > >> > On Mon, Mar 10, 2014 at 2:42 PM, Joe Bowser
> >>> > > > >> > > >> > <bo...@gmail.com>>
> >>> > > > >> > > wrote:
> >>> > > > >> > > >> >> Perhaps. There would be additional benefits to this
> >>> > > > >> > > >> >> approach, namely fixes being added to that platform
> more
> >>> > > > >> > > >> >> quickly.  I'll probably take a look at that once I
> have
> >>> > > > >> > > >> >> Crosswalk
> >>> > > > finalized.
> >>> > > > >> > > >> >>
> >>> > > > >> > > >> >> On Mon, Mar 10, 2014 at 9:49 AM, Brian LeRoux
> >>> > > > >> > > >> >> <b@...@brian.io>>
> >>> > > > wrote:
> >>> > > > >> > > >> >>> this is great stuff
> >>> > > > >> > > >> >>>
> >>> > > > >> > > >> >>> do we think it may be possible to bring in amazon
> >>> fireos
> >>> > > > >> > > >> >>> stuff
> >>> > > > >> > > >> eventually
> >>> > > > >> > > >> >>> too?
> >>> > > > >> > > >> >>>
> >>> > > > >> > > >> >>>
> >>> > > > >> > > >> >>> On Fri, Mar 7, 2014 at 3:22 PM, Joe Bowser
> >>> > > > >> > > >> >>> <bo...@gmail.com>>
> >>> > > > >> > wrote:
> >>> > > > >> > > >> >>>
> >>> > > > >> > > >> >>>> BTW: I committed it in my repo, not the main
> Apache
> >>> one.
> >>> > > > >> > > >> >>>>
> >>> > > > >> > > >> >>>> On Fri, Mar 7, 2014 at 3:21 PM, Joe Bowser
> >>> > > > >> > > >> >>>> <bo...@gmail.com>>
> >>> > > > >> > > wrote:
> >>> > > > >> > > >> >>>> > Hey
> >>> > > > >> > > >> >>>> >
> >>> > > > >> > > >> >>>> > I just committed some code based on their
> WebView
> >>> > > > >> > > >> >>>> > modifications that allows you to choose your
> >>> renderer
> >>> > > > >> > > >> >>>> > in the
> >>> > > > >> > config file
> >>> > > > >> > > with this:
> >>> > > > >> > > >> >>>> >
> >>> > > > >> > > >> >>>> >     <preference name="webView"
> >>> > > > >> > > >> >>>> >
> >>> value="org.apache.cordova.engine.crosswalk.XWalkCordo
> >>> > > > >> > > >> >>>> > va
> >>> > > > >> > > >> >>>> > Web
> >>> > > > >> > > >> >>>> > View
> >>> > > > >> > > >> >>>> > " />
> >>> > > > >> > > >> >>>> >
> >>> > > > >> > > >> >>>> > You currently have to copy over the *.pak file
> and
> >>> > > > >> > > >> >>>> > the jsapi from a Crosswalk Example project to
> get
> >>> > > > >> > > >> >>>> > this to work.  The next thing that I'm going to
> do
> >>> is
> >>> > > > >> > > >> >>>> > figure out how to write this as a plugin and
> have it
> >>> > > > >> > > >> >>>> > install on a default
> >>> > > > project.
> >>> > > > >> > > >> >>>> > Also, right now the bridge doesn't seem to
> work, and
> >>> > > > >> > > >> >>>> > I don't know why exactly.  That being said, the
> >>> > > > >> > > >> fact
> >>> > > > >> > > >> >>>> > that I can choose which version of
> Chrome/Chromium
> >>> > > > >> > > >> >>>> > I'm running with
> >>> > > > >> > > >> a
> >>> > > > >> > > >> >>>> > single XML preference is HUGE.
> >>> > > > >> > > >> >>>> >
> >>> > > > >> > > >> >>>> > There's definitely a lot more work that needs
> to be
> >>> > > > >> > > >> >>>> > done, but as
> >>> > > > >> > > >> long
> >>> > > > >> > > >> >>>> > as we have something that we can fit into the
> >>> > > > >> > > >> >>>> > interface, we should
> >>> > > > >> > > >> be
> >>> > > > >> > > >> >>>> > able to put in things like GeckoView or other
> third
> >>> > > > >> > > >> >>>> > party
> >>> > > > >> > renderers.
> >>> > > > >> > > >> >>>> > The nightmare of being stuck with bullshit
> WebView
> >>> > > > >> > > >> >>>> > bugs may soon be over.
> >>> > > > >> > > >> >>>> >
> >>> > > > >> > > >> >>>> > On Wed, Mar 5, 2014 at 8:59 PM, Michal Mocny
> >>> > > > >> > > >> >>>> > <mm...@chromium.org>>
> >>> > > > >> > > >> >>>> wrote:
> >>> > > > >> > > >> >>>> >>
> >>> https://github.com/crosswalk-project/crosswalk-cordo
> >>> > > > >> > > >> >>>> >> va
> >>> > > > >> > > >> >>>> >> -an
> >>> > > > >> > > >> >>>> >> droi
> >>> > > > >> > > >> >>>> >> d
> >>> > > > >> > > >> >>>> >>
> >>> > > > >> > > >> >>>> >> First patch they landed, which claims to have
> min
> >>> > > > >> > > >> >>>> >> viable xwalk
> >>> > > > >> > > >> webview:
> >>> > > > >> > > >> >>>> >>
> >>> > > > >> > > >> >>>>
> >>> > > > >> > > >>
> >>> https://github.com/crosswalk-project/crosswalk-cordova-andro
> >>> > > > >> > > >> id
> >>> > > > >> > > >> /co
> >>> > > > >> > > >> mmit
> >>> > > > >> > > >> /a04dedeb0204e7542d190312c6ae70c795a26e04
> >>> > > > >> > > >> >>>> >>
> >>> > > > >> > > >> >>>> >>
> >>> > > > >> > > >> >>>> >> On Wed, Mar 5, 2014 at 11:37 PM, Michal Mocny
> >>> > > > >> > > >> >>>> >> <mm...@chromium.org>
> >>> > > > >> > > >> >
> >>> > > > >> > > >> >>>> wrote:
> >>> > > > >> > > >> >>>> >>
> >>> > > > >> > > >> >>>> >>> I haven't looked yet, but did you see:
> >>> > > > >> > > >> >>>> >>>
> >>> https://crosswalk-project.org/#wiki/crosswalk-cordo
> >>> > > > >> > > >> >>>> >>> va
> >>> > > > >> > > >> >>>> >>> -an
> >>> > > > >> > > >> >>>> >>> droi
> >>> > > > >> > > >> >>>> >>> d
> >>> > > > >> > > >> >>>> >>>
> >>> > > > >> > > >> >>>> >>> ?
> >>> > > > >> > > >> >>>> >>>
> >>> > > > >> > > >> >>>> >>>
> >>> > > > >> > > >> >>>> >>> On Wed, Mar 5, 2014 at 10:20 PM, Andrew
> Grieve <
> >>> > > > >> > > >> agrieve@chromium.org<ma...@chromium.org>
> >>> > > > >> > > >> >>>> >wrote:
> >>> > > > >> > > >> >>>> >>>
> >>> > > > >> > > >> >>>> >>>> First - very excited that you're working on
> this!
> >>> > > > >> > > >> >>>> >>>>
> >>> > > > >> > > >> >>>> >>>> Had a quick look. Not sure there's much to be
> >>> > gleaned
> >>> > > yet.
> >>> > > > >> > > >> >>>> >>>> Once
> >>> > > > >> > > >> you
> >>> > > > >> > > >> >>>> start
> >>> > > > >> > > >> >>>> >>>> in on hooking up x-walk's webview I think it
> will
> >>> > > > >> > > >> >>>> >>>> become more
> >>> > > > >> > > >> obvious
> >>> > > > >> > > >> >>>> what
> >>> > > > >> > > >> >>>> >>>> the interface should look like. E.g., does
> x-walk
> >>> > > > >> > > >> >>>> >>>> even have the
> >>> > > > >> > > >> >>>> concept of
> >>> > > > >> > > >> >>>> >>>> ChromeClient vs WebViewClient vs WebView?
> Also
> >>> > > > >> > > >> >>>> >>>> unsure whether the
> >>> > > > >> > > >> >>>> class
> >>> > > > >> > > >> >>>> >>>> should extend android.View as well as
> implement
> >>> > > > >> > > >> >>>> >>>> our
> >>> > > > >> > interface.
> >>> > > > >> > > >> E.g.
> >>> > > > >> > > >> >>>> >>>> alternative is to have a "getView()" method
> on
> >>> the
> >>> > > > >> > interface.
> >>> > > > >> > > >> Might
> >>> > > > >> > > >> >>>> help
> >>> > > > >> > > >> >>>> >>>> to
> >>> > > > >> > > >> >>>> >>>> cut down on file sizes, and API surface, but
> >>> > > > >> > > >> >>>> >>>> again, I'm not too
> >>> > > > >> > > >> sure.
> >>> > > > >> > > >> >>>> >>>>
> >>> > > > >> > > >> >>>> >>>> I've been pretty hesitant to touch existing
> >>> > > > >> > > >> >>>> >>>> exposed members
> >>> > > > >> > > >> (e.g. the
> >>> > > > >> > > >> >>>> >>>> public fields you were referring to) since
> >>> > > > >> > > >> >>>> >>>> touching anything
> >>> > > > >> > > >> public
> >>> > > > >> > > >> >>>> could
> >>> > > > >> > > >> >>>> >>>> break plugins. That said, maybe now is a good
> >>> time
> >>> > > > >> > > >> >>>> >>>> to @deprecate
> >>> > > > >> > > >> a
> >>> > > > >> > > >> >>>> bunch
> >>> > > > >> > > >> >>>> >>>> of
> >>> > > > >> > > >> >>>> >>>> them and either replace them with getters, or
> >>> just
> >>> > > > >> > > >> >>>> >>>> declare them
> >>> > > > >> > > >> to be
> >>> > > > >> > > >> >>>> not
> >>> > > > >> > > >> >>>> >>>> exposed to plugins.
> >>> > > > >> > > >> >>>> >>>>
> >>> > > > >> > > >> >>>> >>>>
> >>> > > > >> > > >> >>>> >>>> On Wed, Mar 5, 2014 at 6:57 PM, Joe Bowser
> >>> > > > >> > > >> >>>> >>>> <bo...@gmail.com>>
> >>> > > > >> > > >> wrote:
> >>> > > > >> > > >> >>>> >>>>
> >>> > > > >> > > >> >>>> >>>> > So, after looking at the Crosswalk code
> again,
> >>> > > > >> > > >> >>>> >>>> > I've decided to
> >>> > > > >> > > >> take
> >>> > > > >> > > >> >>>> a
> >>> > > > >> > > >> >>>> >>>> > quick stab at making things pluggable.  I
> don't
> >>> > > > >> > > >> >>>> >>>> > have a lot to
> >>> > > > >> > > >> show
> >>> > > > >> > > >> >>>> for
> >>> > > > >> > > >> >>>> >>>> > it, but with the help of Eclipse (which is
> why
> >>> > > > >> > > >> >>>> >>>> > the generated interfaces look so screwed
> up), I
> >>> > > > >> > > >> >>>> >>>> > managed to create some
> >>> > > > >> > > >> interfaces
> >>> > > > >> > > >> >>>> so
> >>> > > > >> > > >> >>>> >>>> > we can start shoehorning in other browser
> >>> > renderers.
> >>> > > > >> > > >> >>>> >>>> >
> >>> > > > >> > > >> >>>> >>>> >
> >>> > > > >> > > >>
> >>> https://github.com/infil00p/cordova-android/tree/pluggable_w
> >>> > > > >> > > >> eb
> >>> > > > >> > > >> vie
> >>> > > > >> > > >> w
> >>> > > > >> > > >> >>>> >>>> >
> >>> > > > >> > > >> >>>> >>>> > I'm going to probably start with Crosswalk,
> >>> > > > >> > > >> >>>> >>>> > because it's
> >>> > > > >> > > >> probably
> >>> > > > >> > > >> >>>> the
> >>> > > > >> > > >> >>>> >>>> > most mature primary candidate in the
> Android
> >>> > > > >> > > >> >>>> >>>> > Third-Party
> >>> > > > >> > > >> WebView
> >>> > > > >> > > >> >>>> >>>> > thing, and I'm pretty sure the GeckoView
> will
> >>> be
> >>> > > > >> > > >> >>>> >>>> > happening
> >>> > > > >> > > >> shortly
> >>> > > > >> > > >> >>>> >>>> > after.
> >>> > > > >> > > >> >>>> >>>> >
> >>> > > > >> > > >> >>>> >>>> > I don't know how this would work w.r.t.
> the CLI
> >>> > > > >> > > >> >>>> >>>> > or our
> >>> > > > >> > > >> workflow at
> >>> > > > >> > > >> >>>> >>>> > all, but at the moment, I really just want
> to
> >>> at
> >>> > > > >> > > >> >>>> >>>> > least start
> >>> > > > >> > > >> to have
> >>> > > > >> > > >> >>>> >>>> > some headway towards 4.x and PhoneGap day.
> >>> > > > >> > > >> >>>> >>>> >
> >>> > > > >> > > >> >>>> >>>> > What do people think of this so far? I'm
> going
> >>> > > > >> > > >> >>>> >>>> > to try to clean
> >>> > > > >> > > >> >>>> things
> >>> > > > >> > > >> >>>> >>>> > up a bit, since we've definitely done a
> lot of
> >>> > > > >> > > >> >>>> >>>> > things that
> >>> > > > >> > > >> would
> >>> > > > >> > > >> >>>> make
> >>> > > > >> > > >> >>>> >>>> > first year CS profs freak the hell out
> (i.e.
> >>> > > > >> > > >> >>>> >>>> > public members in
> >>> > > > >> > > >> >>>> public
> >>> > > > >> > > >> >>>> >>>> > objects w.r.t. PluginManager).
> >>> > > > >> > > >> >>>> >>>> >
> >>> > > > >> > > >> >>>> >>>> > Thoughts?
> >>> > > > >> > > >> >>>> >>>> >
> >>> > > > >> > > >> >>>> >>>> > Joe
> >>> > > > >> > > >> >>>> >>>> >
> >>> > > > >> > > >> >>>> >>>>
> >>> > > > >> > > >> >>>> >>>
> >>> > > > >> > > >> >>>> >>>
> >>> > > > >> > > >> >>>>
> >>> > > > >> > > >>
> >>> > > > >> >
> >>> >
> >>>
>

Re: [Android] Refactoring for different engines

[Ian Clelland <ic...@chromium.org>]

On Thu, Apr 24, 2014 at 5:27 AM, Hu, Ningxin <ni...@intel.com> wrote:

>  > Mobilespec runs on my N4, with 10 failing tests: 3 in contacts; 7 in
> file-transfer. Otherwise, things seem to be working pretty well.
>
>
>
> I checked out the latest code (@691fbce540) and build mbilespec with
> Crosswalk 6.35.127.0. However, it runs on the default Android WebView due
> to the InvocationTargetException when calling constructors of
> XWalkWebChromeClient and XWalkClient. I fixed it at:
> https://github.com/infil00p/cordova-crosswalk-engine/pull/6.
>

This looks good, I've pulled that in locally.


>
>
> To make the plugins work on cordova-crosswalk-engine, it still needs to
> set correct webview client, chrome client and enable the
> setNetworkAvailable. I've sent another two PRs.
>
> https://github.com/infil00p/cordova-crosswalk-engine/pull/7
>
> https://github.com/infil00p/cordova-android/pull/3
>

I think that we could do this differently. I would rather see the
functionality of CordovaActivity.makeWebViewClient and
CordovaActivity.makeChromeClient moved into the AndroidWebView class, and
declared as methods in the CordovaWebView interface. Then we would override
them in XWalkCordovaWebView to do the right thing.

The extra string manipulation magic, and reflection, that this patch
introduces, seems wrong to me. Considering that we already have methods in
XWalkCordovaWebView to construct those objects, then we should let the
XWalkCordovaWebView construct them.

(I do like your method of iterating over the constructors, though -- I'm
going to try to use that code in makeWebView as well)


>
>
> After these fixes (and with three fixes in plugins to use
> getPluginManager() interface), I can run the mobilespec "Run All Tests" on
> Crosswalk with all passed except Media test. The Media.js seems not be
> loaded. I didn't have chance to debug it yet.
>
>
>
> Ian and Joe, could you please review the PRs? I would appreciate that.
>
>
>
> > I've issued a pull request at
> https://github.com/infil00p/cordova-crosswalk-engine/pull/5 for it -- I'm
> not sure if there's a way to keep compatibility with last week's Crosswalk,
> or if we'd even want to. (Ningxin, if you could take a look at that PR and
> see if it makes sense, I'd appreciate it)
>
>
>
> The PR LGTM! Thanks for the update.
>
>
>
> For crosswalk embedding API compatibility, currently we track the master
> branch of Crosswalk (a.k.a Canary release channel), the embedding API in
> master is still under development. As planned, the Crosswalk-6 will be
> branched for beta in 4th May. In that branch, the embedding API will be
> stable and only accept bug fixing. So for cordova-crosswalk-engine, we can
> also have crosswalk-6 branch to track beta branch (later stable branch) and
> using master to track the latest crosswalk.
>

Are people also going to use older (1-4) versions of Crosswalk? Or is the
plan to encourage people to only use either stable or beta versions?

>
>
> I am even thinking about we can setup some bots (as buildbots in
> crosswalk) to track if any patches to crosswalk break the
> cordova-crosswalk-engine.
>
>
>
> Your thoughts?
>

That would be good to have -- I'd like to have some kind of warning that
new changes in the upstream project break the plugin :)


>
>
> Thanks,
>
> -ningxin
>
>
>
> *From:* iclelland@google.com [mailto:iclelland@google.com] *On Behalf Of *Ian
> Clelland
> *Sent:* Thursday, April 24, 2014 1:32 AM
> *To:* dev@cordova.apache.org
> *Cc:* Joe Bowser; Hu, Ningxin
>
> *Subject:* Re: [Android] Refactoring for different engines
>
>
>
> I've managed to get this up and running now -- great work on this, Joe!
>
>
>
> Mobilespec runs on my N4, with 10 failing tests: 3 in contacts; 7 in
> file-transfer. Otherwise, things seem to be working pretty well.
>
>
>
> I used a new build of Crosswalk, and found that the embedding API has
> changed since the weekend (when Ningxin's patches applied). I've issued a
> pull request at
> https://github.com/infil00p/cordova-crosswalk-engine/pull/5 for it -- I'm
> not sure if there's a way to keep compatibility with last week's Crosswalk,
> or if we'd even want to. (Ningxin, if you could take a look at that PR and
> see if it makes sense, I'd appreciate it)
>
>
>
> Joe, I also had to patch the default constructor for XWalkCordovaWebView;
> it wasn't creating its own client objects, so it got the default ones, and
> most of the tests were failing because some component of the bridge wan't
> working. https://github.com/infil00p/cordova-crosswalk-engine/pull/4 is
> out for that.
>
>
>
> Count me in for the hangout -- this is exciting stuff
>
>
>
> Ian
>
>
>
> On Wed, Apr 23, 2014 at 10:26 AM, Brian LeRoux <b...@brian.io> wrote:
>
> Yup I'll track em down
>
> On Apr 23, 2014 7:17 AM, "Andrew Grieve" <ag...@chromium.org> wrote:
>
> > Does anyone have a contact at moz that we could invite?
> >
> > On Wed, Apr 23, 2014 at 10:09 AM, Andrew Grieve <ag...@chromium.org>
> > wrote:
> > > Depends on their interest level I think. Faster we can get this out
> > > the door the better. If we need to delay for geckoview, then I don't
> > > think we should gate on it, just release it after.
> > >
> > > On Wed, Apr 23, 2014 at 3:01 AM, Tommy Williams <to...@devgeeks.org>
> > wrote:
> > >> More engines, more better...
> > >> On 23 Apr 2014 16:32, "Joe Bowser" <bo...@gmail.com> wrote:
> > >>
> > >>> Hey
> > >>>
> > >>> A Hangout would have to happen on Friday at the earliest.  It'd be
> > good if
> > >>> we could get someone from Mozilla on the hangout as well.  I haven't
> > gotten
> > >>> MozillaView (GeckoView with Cordova methods) fully working yet.  For
> > some
> > >>> reason it's not rendering on the screen.
> > >>>
> > >>> Ideally it'd be cool to have at least two options when this feature
> > finally
> > >>> lands.
> > >>>
> > >>> What do other people think?
> > >>>
> > >>> Joe
> > >>> On 22 Apr 2014 20:06, "Hu, Ningxin" <ni...@intel.com> wrote:
> > >>>
> > >>> > Joe,
> > >>> >
> > >>> > Thanks for your review and merge the PRs.
> > >>> >
> > >>> > To pluggable webview interest group:
> > >>> > Are we OK to setup a hangout this week for initial introduction and
> > >>> > discussion of next steps?
> > >>> >
> > >>> > Thanks,
> > >>> > -ningxin
> > >>> >
> > >>> > > -----Original Message-----
> > >>> > > From: Hu, Ningxin [mailto:ningxin.hu@intel.com]
> > >>> > > Sent: Tuesday, April 22, 2014 4:04 PM
> > >>> > > To: dev@cordova.apache.org
> > >>> > > Subject: RE: [Android] Refactoring for different engines
> > >>> > >
> > >>> > > The PoC is great! Quite excited about the direction!
> > >>> > >
> > >>> > > I've sent a PR to update the cordova-crosswalk-engine to latest
> > >>> crosswalk
> > >>> > > embedding API. It works with xwalk_core_library at 6.35.124.0.
> > >>> > >
> > >>> > > I've also changed the CordovaWebView interface slightly (adding
> > >>> > getView() API)
> > >>> > > to allow XWalkCordovaWebView to composite a XWalkView instead of
> > >>> > extending
> > >>> > > it. It resolves some API naming issues for XWalkView case.
> > >>> > >
> > >>> > > Please review them at:
> > >>> > > https://github.com/infil00p/cordova-crosswalk-engine/pull/3
> > >>> > > https://github.com/infil00p/cordova-android/pull/2
> > >>> > >
> > >>> > > Thanks,
> > >>> > > -ningxin
> > >>> > >
> > >>> > > > -----Original Message-----
> > >>> > > > From: Joe Bowser [mailto:bowserj@gmail.com]
> > >>> > > > Sent: Friday, April 11, 2014 12:45 AM
> > >>> > > > To: dev
> > >>> > > > Subject: Re: [Android] Refactoring for different engines
> > >>> > > >
> > >>> > > > Yeah, I'd be cool with setting up a hangout.  Everyone should
> > take a
> > >>> > > > look at the PoC, I've basically distilled it down to four or
> five
> > >>> > > > classes so far, but with some work, we may be able to get it
> > down to
> > >>> > > > three.  Due to legacy, we're pretty stuck with the Android
> > WebView
> > >>> API
> > >>> > calls,
> > >>> > > but these can probably be modified.
> > >>> > > >
> > >>> > > > It'd be good to get Mozilla people on the call as well, since
> > they
> > >>> > > > have their WebView as well.
> > >>> > > >
> > >>> > > > On Thu, Apr 10, 2014 at 9:38 AM, Hu, Ningxin <
> > ningxin.hu@intel.com>
> > >>> > wrote:
> > >>> > > > > Hangout would be a good idea.
> > >>> > > > >
> > >>> > > > > FYI, I will be off next week. How about the week after next?
> > If it
> > >>> > > > > works, please
> > >>> > > > feel free to schedule one and count me in.
> > >>> > > > >
> > >>> > > > > Thanks,
> > >>> > > > > -ningxin
> > >>> > > > >
> > >>> > > > >> -----Original Message-----
> > >>> > > > >> From: mmocny@google.com [mailto:mmocny@google.com] On
> Behalf
> > Of
> > >>> > > > >> Michal Mocny
> > >>> > > > >> Sent: Tuesday, April 08, 2014 11:39 PM
> > >>> > > > >> To: dev
> > >>> > > > >> Subject: Re: [Android] Refactoring for different engines
> > >>> > > > >>
> > >>> > > > >> Would it be alright to set up a Hangout some time to
> introduce
> > >>> > everyone?
> > >>> > > > >>
> > >>> > > > >> Joe has been leading the effort here, but there are other
> > cordova
> > >>> > > > >> contributors for whom this is top priority.  It would be
> nice
> > if
> > >>> we
> > >>> > > > >> could all meet to say hello and make sure we are all going
> in
> > the
> > >>> > > > >> right
> > >>> > > > direction.
> > >>> > > > >>
> > >>> > > > >> Quite exciting!
> > >>> > > > >>
> > >>> > > > >> -Michal
> > >>> > > > >>
> > >>> > > > >>
> > >>> > > > >> On Tue, Apr 8, 2014 at 10:56 AM, Hu, Ningxin <
> > >>> ningxin.hu@intel.com>
> > >>> > > wrote:
> > >>> > > > >>
> > >>> > > > >> > Joe, thanks for this. I am very excited.
> > >>> > > > >> >
> > >>> > > > >> > FYI. Crosswalk team is working on refactoring the WebView
> > API to
> > >>> > > > >> > support embedding usage better [1]. (Previously the layer
> > API
> > >>> was
> > >>> > > > >> > not exposed as public usage).
> > >>> > > > >> >
> > >>> > > > >> > I would like to review the PoC and work with you to get
> > >>> Crosswalk
> > >>> > > > >> > fits into the pluggable WebView architecture.
> > >>> > > > >> >
> > >>> > > > >> > Thanks,
> > >>> > > > >> > -ningxin
> > >>> > > > >> >
> > >>> > > > >> > > -----Original Message-----
> > >>> > > > >> > > From: Joe Bowser [mailto:bowserj@gmail.com]
> > >>> > > > >> > > Sent: Wednesday, March 19, 2014 7:08 AM
> > >>> > > > >> > > To: dev
> > >>> > > > >> > > Subject: Re: [Android] Refactoring for different engines
> > >>> > > > >> > >
> > >>> > > > >> > > Hey
> > >>> > > > >> > >
> > >>> > > > >> > > After debugging, I did some minor updates to the plugin
> > >>> README.
> > >>> > > > >> > > It
> > >>> > > > >> > should be
> > >>> > > > >> > > easier to get this up and running, although there's
> still
> > the
> > >>> > > > >> > > issue of
> > >>> > > > >> > after-install
> > >>> > > > >> > > hooks and the relative path weirdness with the Crosswalk
> > >>> > Library itself.
> > >>> > > > >> > >
> > >>> > > > >> > > It still doesn't support the CLI at all, but it should
> be
> > >>> there
> > >>> > > > >> > > with the
> > >>> > > > >> > old flow.
> > >>> > > > >> > >
> > >>> > > > >> > > On Mon, Mar 17, 2014 at 1:14 PM, Michal Mocny
> > >>> > > > >> > > <mm...@chromium.org>
> > >>> > > > >> > > wrote:
> > >>> > > > >> > > > (Sorry Joe, Googlers are down in California and way
> > busy.
> > >>> > > > >> > > > Will be back in a week.  Super excited about this,
> > though.)
> > >>> > > > >> > > >
> > >>> > > > >> > > > -Michal
> > >>> > > > >> > > >
> > >>> > > > >> > > >
> > >>> > > > >> > > > On Mon, Mar 17, 2014 at 2:53 PM, Joe Bowser
> > >>> > > > >> > > > <bo...@gmail.com>
> > >>> > > > >> wrote:
> > >>> > > > >> > > >
> > >>> > > > >> > > >> Reviving this thread!
> > >>> > > > >> > > >>
> > >>> > > > >> > > >> Can other people look at this, and see if/when we
> > should
> > >>> > land this?
> > >>> > > > >> > > >> I know that I have to re-write the tests still, but I
> > would
> > >>> > > > >> > > >> like some feedback before merging it in.  Also, it'd
> be
> > >>> > > > >> > > >> super awesome if other people could try and make a
> > WebView
> > >>> > > > >> > > >> based on the interfaces and recommend which methods
> > should
> > >>> > > > >> > > >> die.  I want to get this released in the next month
> or
> > so,
> > >>> > > > >> > > >> so any time and feedback would be greatly
> appreciated.
> > >>> > > > >> > > >>
> > >>> > > > >> > > >> Thanks
> > >>> > > > >> > > >>
> > >>> > > > >> > > >> On Thu, Mar 13, 2014 at 3:50 PM, Joe Bowser
> > >>> > > > >> > > >> <bo...@gmail.com>
> > >>> > > > >> > wrote:
> > >>> > > > >> > > >> > Hey, I created the following today to track various
> > >>> > > > >> > > >> > WebView
> > >>> > > > >> > progresses:
> > >>> > > > >> > > >> > https://issues.apache.org/jira/browse/CB-6246
> > >>> > > > >> > > >> >
> > >>> > > > >> > > >> > I also have this repo created.  The licensing is
> > ugly as
> > >>> > > > >> > > >> > all crap, but it's a Proof-Of-Concept:
> > >>> > > > >> > > >> >
> https://github.com/infil00p/cordova-crosswalk-engine
> > >>> > > > >> > > >> >
> > >>> > > > >> > > >> > If I can get some help getting plugman to just load
> > >>> > > > >> > > >> > Crosswalk, it'll
> > >>> > > > >> > > >> look hawt.
> > >>> > > > >> > > >> >
> > >>> > > > >> > > >> > BTW: We should probably get this ready to go into
> > Android
> > >>> > > > >> > > >> > in the next two months and deprecate the
> setProperty
> > >>> > > > >> > > >> > methods, since all properties should be preferences
> > in
> > >>> > config.xml
> > >>> > > now.
> > >>> > > > >> > > >> >
> > >>> > > > >> > > >> > On Mon, Mar 10, 2014 at 2:42 PM, Joe Bowser
> > >>> > > > >> > > >> > <bo...@gmail.com>
> > >>> > > > >> > > wrote:
> > >>> > > > >> > > >> >> Perhaps. There would be additional benefits to
> this
> > >>> > > > >> > > >> >> approach, namely fixes being added to that
> platform
> > more
> > >>> > > > >> > > >> >> quickly.  I'll probably take a look at that once I
> > have
> > >>> > > > >> > > >> >> Crosswalk
> > >>> > > > finalized.
> > >>> > > > >> > > >> >>
> > >>> > > > >> > > >> >> On Mon, Mar 10, 2014 at 9:49 AM, Brian LeRoux
> > >>> > > > >> > > >> >> <b...@brian.io>
> > >>> > > > wrote:
> > >>> > > > >> > > >> >>> this is great stuff
> > >>> > > > >> > > >> >>>
> > >>> > > > >> > > >> >>> do we think it may be possible to bring in amazon
> > >>> fireos
> > >>> > > > >> > > >> >>> stuff
> > >>> > > > >> > > >> eventually
> > >>> > > > >> > > >> >>> too?
> > >>> > > > >> > > >> >>>
> > >>> > > > >> > > >> >>>
> > >>> > > > >> > > >> >>> On Fri, Mar 7, 2014 at 3:22 PM, Joe Bowser
> > >>> > > > >> > > >> >>> <bo...@gmail.com>
> > >>> > > > >> > wrote:
> > >>> > > > >> > > >> >>>
> > >>> > > > >> > > >> >>>> BTW: I committed it in my repo, not the main
> > Apache
> > >>> one.
> > >>> > > > >> > > >> >>>>
> > >>> > > > >> > > >> >>>> On Fri, Mar 7, 2014 at 3:21 PM, Joe Bowser
> > >>> > > > >> > > >> >>>> <bo...@gmail.com>
> > >>> > > > >> > > wrote:
> > >>> > > > >> > > >> >>>> > Hey
> > >>> > > > >> > > >> >>>> >
> > >>> > > > >> > > >> >>>> > I just committed some code based on their
> > WebView
> > >>> > > > >> > > >> >>>> > modifications that allows you to choose your
> > >>> renderer
> > >>> > > > >> > > >> >>>> > in the
> > >>> > > > >> > config file
> > >>> > > > >> > > with this:
> > >>> > > > >> > > >> >>>> >
> > >>> > > > >> > > >> >>>> >     <preference name="webView"
> > >>> > > > >> > > >> >>>> >
> > >>> value="org.apache.cordova.engine.crosswalk.XWalkCordo
> > >>> > > > >> > > >> >>>> > va
> > >>> > > > >> > > >> >>>> > Web
> > >>> > > > >> > > >> >>>> > View
> > >>> > > > >> > > >> >>>> > " />
> > >>> > > > >> > > >> >>>> >
> > >>> > > > >> > > >> >>>> > You currently have to copy over the *.pak file
> > and
> > >>> > > > >> > > >> >>>> > the jsapi from a Crosswalk Example project to
> > get
> > >>> > > > >> > > >> >>>> > this to work.  The next thing that I'm going
> to
> > do
> > >>> is
> > >>> > > > >> > > >> >>>> > figure out how to write this as a plugin and
> > have it
> > >>> > > > >> > > >> >>>> > install on a default
> > >>> > > > project.
> > >>> > > > >> > > >> >>>> > Also, right now the bridge doesn't seem to
> > work, and
> > >>> > > > >> > > >> >>>> > I don't know why exactly.  That being said,
> the
> > >>> > > > >> > > >> fact
> > >>> > > > >> > > >> >>>> > that I can choose which version of
> > Chrome/Chromium
> > >>> > > > >> > > >> >>>> > I'm running with
> > >>> > > > >> > > >> a
> > >>> > > > >> > > >> >>>> > single XML preference is HUGE.
> > >>> > > > >> > > >> >>>> >
> > >>> > > > >> > > >> >>>> > There's definitely a lot more work that needs
> > to be
> > >>> > > > >> > > >> >>>> > done, but as
> > >>> > > > >> > > >> long
> > >>> > > > >> > > >> >>>> > as we have something that we can fit into the
> > >>> > > > >> > > >> >>>> > interface, we should
> > >>> > > > >> > > >> be
> > >>> > > > >> > > >> >>>> > able to put in things like GeckoView or other
> > third
> > >>> > > > >> > > >> >>>> > party
> > >>> > > > >> > renderers.
> > >>> > > > >> > > >> >>>> > The nightmare of being stuck with bullshit
> > WebView
> > >>> > > > >> > > >> >>>> > bugs may soon be over.
> > >>> > > > >> > > >> >>>> >
> > >>> > > > >> > > >> >>>> > On Wed, Mar 5, 2014 at 8:59 PM, Michal Mocny
> > >>> > > > >> > > >> >>>> > <mm...@chromium.org>
> > >>> > > > >> > > >> >>>> wrote:
> > >>> > > > >> > > >> >>>> >>
> > >>> https://github.com/crosswalk-project/crosswalk-cordo
> > >>> > > > >> > > >> >>>> >> va
> > >>> > > > >> > > >> >>>> >> -an
> > >>> > > > >> > > >> >>>> >> droi
> > >>> > > > >> > > >> >>>> >> d
> > >>> > > > >> > > >> >>>> >>
> > >>> > > > >> > > >> >>>> >> First patch they landed, which claims to have
> > min
> > >>> > > > >> > > >> >>>> >> viable xwalk
> > >>> > > > >> > > >> webview:
> > >>> > > > >> > > >> >>>> >>
> > >>> > > > >> > > >> >>>>
> > >>> > > > >> > > >>
> > >>> https://github.com/crosswalk-project/crosswalk-cordova-andro
> > >>> > > > >> > > >> id
> > >>> > > > >> > > >> /co
> > >>> > > > >> > > >> mmit
> > >>> > > > >> > > >> /a04dedeb0204e7542d190312c6ae70c795a26e04
> > >>> > > > >> > > >> >>>> >>
> > >>> > > > >> > > >> >>>> >>
> > >>> > > > >> > > >> >>>> >> On Wed, Mar 5, 2014 at 11:37 PM, Michal Mocny
> > >>> > > > >> > > >> >>>> >> <mmocny@chromium.org
> > >>> > > > >> > > >> >
> > >>> > > > >> > > >> >>>> wrote:
> > >>> > > > >> > > >> >>>> >>
> > >>> > > > >> > > >> >>>> >>> I haven't looked yet, but did you see:
> > >>> > > > >> > > >> >>>> >>>
> > >>> https://crosswalk-project.org/#wiki/crosswalk-cordo
> > >>> > > > >> > > >> >>>> >>> va
> > >>> > > > >> > > >> >>>> >>> -an
> > >>> > > > >> > > >> >>>> >>> droi
> > >>> > > > >> > > >> >>>> >>> d
> > >>> > > > >> > > >> >>>> >>>
> > >>> > > > >> > > >> >>>> >>> ?
> > >>> > > > >> > > >> >>>> >>>
> > >>> > > > >> > > >> >>>> >>>
> > >>> > > > >> > > >> >>>> >>> On Wed, Mar 5, 2014 at 10:20 PM, Andrew
> > Grieve <
> > >>> > > > >> > > >> agrieve@chromium.org
> > >>> > > > >> > > >> >>>> >wrote:
> > >>> > > > >> > > >> >>>> >>>
> > >>> > > > >> > > >> >>>> >>>> First - very excited that you're working on
> > this!
> > >>> > > > >> > > >> >>>> >>>>
> > >>> > > > >> > > >> >>>> >>>> Had a quick look. Not sure there's much to
> be
> > >>> > gleaned
> > >>> > > yet.
> > >>> > > > >> > > >> >>>> >>>> Once
> > >>> > > > >> > > >> you
> > >>> > > > >> > > >> >>>> start
> > >>> > > > >> > > >> >>>> >>>> in on hooking up x-walk's webview I think
> it
> > will
> > >>> > > > >> > > >> >>>> >>>> become more
> > >>> > > > >> > > >> obvious
> > >>> > > > >> > > >> >>>> what
> > >>> > > > >> > > >> >>>> >>>> the interface should look like. E.g., does
> > x-walk
> > >>> > > > >> > > >> >>>> >>>> even have the
> > >>> > > > >> > > >> >>>> concept of
> > >>> > > > >> > > >> >>>> >>>> ChromeClient vs WebViewClient vs WebView?
> > Also
> > >>> > > > >> > > >> >>>> >>>> unsure whether the
> > >>> > > > >> > > >> >>>> class
> > >>> > > > >> > > >> >>>> >>>> should extend android.View as well as
> > implement
> > >>> > > > >> > > >> >>>> >>>> our
> > >>> > > > >> > interface.
> > >>> > > > >> > > >> E.g.
> > >>> > > > >> > > >> >>>> >>>> alternative is to have a "getView()" method
> > on
> > >>> the
> > >>> > > > >> > interface.
> > >>> > > > >> > > >> Might
> > >>> > > > >> > > >> >>>> help
> > >>> > > > >> > > >> >>>> >>>> to
> > >>> > > > >> > > >> >>>> >>>> cut down on file sizes, and API surface,
> but
> > >>> > > > >> > > >> >>>> >>>> again, I'm not too
> > >>> > > > >> > > >> sure.
> > >>> > > > >> > > >> >>>> >>>>
> > >>> > > > >> > > >> >>>> >>>> I've been pretty hesitant to touch existing
> > >>> > > > >> > > >> >>>> >>>> exposed members
> > >>> > > > >> > > >> (e.g. the
> > >>> > > > >> > > >> >>>> >>>> public fields you were referring to) since
> > >>> > > > >> > > >> >>>> >>>> touching anything
> > >>> > > > >> > > >> public
> > >>> > > > >> > > >> >>>> could
> > >>> > > > >> > > >> >>>> >>>> break plugins. That said, maybe now is a
> good
> > >>> time
> > >>> > > > >> > > >> >>>> >>>> to @deprecate
> > >>> > > > >> > > >> a
> > >>> > > > >> > > >> >>>> bunch
> > >>> > > > >> > > >> >>>> >>>> of
> > >>> > > > >> > > >> >>>> >>>> them and either replace them with getters,
> or
> > >>> just
> > >>> > > > >> > > >> >>>> >>>> declare them
> > >>> > > > >> > > >> to be
> > >>> > > > >> > > >> >>>> not
> > >>> > > > >> > > >> >>>> >>>> exposed to plugins.
> > >>> > > > >> > > >> >>>> >>>>
> > >>> > > > >> > > >> >>>> >>>>
> > >>> > > > >> > > >> >>>> >>>> On Wed, Mar 5, 2014 at 6:57 PM, Joe Bowser
> > >>> > > > >> > > >> >>>> >>>> <bo...@gmail.com>
> > >>> > > > >> > > >> wrote:
> > >>> > > > >> > > >> >>>> >>>>
> > >>> > > > >> > > >> >>>> >>>> > So, after looking at the Crosswalk code
> > again,
> > >>> > > > >> > > >> >>>> >>>> > I've decided to
> > >>> > > > >> > > >> take
> > >>> > > > >> > > >> >>>> a
> > >>> > > > >> > > >> >>>> >>>> > quick stab at making things pluggable.  I
> > don't
> > >>> > > > >> > > >> >>>> >>>> > have a lot to
> > >>> > > > >> > > >> show
> > >>> > > > >> > > >> >>>> for
> > >>> > > > >> > > >> >>>> >>>> > it, but with the help of Eclipse (which
> is
> > why
> > >>> > > > >> > > >> >>>> >>>> > the generated interfaces look so screwed
> > up), I
> > >>> > > > >> > > >> >>>> >>>> > managed to create some
> > >>> > > > >> > > >> interfaces
> > >>> > > > >> > > >> >>>> so
> > >>> > > > >> > > >> >>>> >>>> > we can start shoehorning in other browser
> > >>> > renderers.
> > >>> > > > >> > > >> >>>> >>>> >
> > >>> > > > >> > > >> >>>> >>>> >
> > >>> > > > >> > > >>
> > >>> https://github.com/infil00p/cordova-android/tree/pluggable_w
> > >>> > > > >> > > >> eb
> > >>> > > > >> > > >> vie
> > >>> > > > >> > > >> w
> > >>> > > > >> > > >> >>>> >>>> >
> > >>> > > > >> > > >> >>>> >>>> > I'm going to probably start with
> Crosswalk,
> > >>> > > > >> > > >> >>>> >>>> > because it's
> > >>> > > > >> > > >> probably
> > >>> > > > >> > > >> >>>> the
> > >>> > > > >> > > >> >>>> >>>> > most mature primary candidate in the
> > Android
> > >>> > > > >> > > >> >>>> >>>> > Third-Party
> > >>> > > > >> > > >> WebView
> > >>> > > > >> > > >> >>>> >>>> > thing, and I'm pretty sure the GeckoView
> > will
> > >>> be
> > >>> > > > >> > > >> >>>> >>>> > happening
> > >>> > > > >> > > >> shortly
> > >>> > > > >> > > >> >>>> >>>> > after.
> > >>> > > > >> > > >> >>>> >>>> >
> > >>> > > > >> > > >> >>>> >>>> > I don't know how this would work w.r.t.
> > the CLI
> > >>> > > > >> > > >> >>>> >>>> > or our
> > >>> > > > >> > > >> workflow at
> > >>> > > > >> > > >> >>>> >>>> > all, but at the moment, I really just
> want
> > to
> > >>> at
> > >>> > > > >> > > >> >>>> >>>> > least start
> > >>> > > > >> > > >> to have
> > >>> > > > >> > > >> >>>> >>>> > some headway towards 4.x and PhoneGap
> day.
> > >>> > > > >> > > >> >>>> >>>> >
> > >>> > > > >> > > >> >>>> >>>> > What do people think of this so far? I'm
> > going
> > >>> > > > >> > > >> >>>> >>>> > to try to clean
> > >>> > > > >> > > >> >>>> things
> > >>> > > > >> > > >> >>>> >>>> > up a bit, since we've definitely done a
> > lot of
> > >>> > > > >> > > >> >>>> >>>> > things that
> > >>> > > > >> > > >> would
> > >>> > > > >> > > >> >>>> make
> > >>> > > > >> > > >> >>>> >>>> > first year CS profs freak the hell out
> > (i.e.
> > >>> > > > >> > > >> >>>> >>>> > public members in
> > >>> > > > >> > > >> >>>> public
> > >>> > > > >> > > >> >>>> >>>> > objects w.r.t. PluginManager).
> > >>> > > > >> > > >> >>>> >>>> >
> > >>> > > > >> > > >> >>>> >>>> > Thoughts?
> > >>> > > > >> > > >> >>>> >>>> >
> > >>> > > > >> > > >> >>>> >>>> > Joe
> > >>> > > > >> > > >> >>>> >>>> >
> > >>> > > > >> > > >> >>>> >>>>
> > >>> > > > >> > > >> >>>> >>>
> > >>> > > > >> > > >> >>>> >>>
> > >>> > > > >> > > >> >>>>
> > >>> > > > >> > > >>
> > >>> > > > >> >
> > >>> >
> > >>>
> >
>
>
>

RE: [Android] Refactoring for different engines

["Hu, Ningxin" <ni...@intel.com>]

> Mobilespec runs on my N4, with 10 failing tests: 3 in contacts; 7 in file-transfer. Otherwise, things seem to be working pretty well.

I checked out the latest code (@691fbce540) and build mbilespec with Crosswalk 6.35.127.0. However, it runs on the default Android WebView due to the InvocationTargetException when calling constructors of XWalkWebChromeClient and XWalkClient. I fixed it at: https://github.com/infil00p/cordova-crosswalk-engine/pull/6.

To make the plugins work on cordova-crosswalk-engine, it still needs to set correct webview client, chrome client and enable the setNetworkAvailable. I've sent another two PRs.
https://github.com/infil00p/cordova-crosswalk-engine/pull/7
https://github.com/infil00p/cordova-android/pull/3

After these fixes (and with three fixes in plugins to use getPluginManager() interface), I can run the mobilespec "Run All Tests" on Crosswalk with all passed except Media test. The Media.js seems not be loaded. I didn't have chance to debug it yet.

Ian and Joe, could you please review the PRs? I would appreciate that.

> I've issued a pull request at https://github.com/infil00p/cordova-crosswalk-engine/pull/5 for it -- I'm not sure if there's a way to keep compatibility with last week's Crosswalk, or if we'd even want to. (Ningxin, if you could take a look at that PR and see if it makes sense, I'd appreciate it)

The PR LGTM! Thanks for the update.

For crosswalk embedding API compatibility, currently we track the master branch of Crosswalk (a.k.a Canary release channel), the embedding API in master is still under development. As planned, the Crosswalk-6 will be branched for beta in 4th May. In that branch, the embedding API will be stable and only accept bug fixing. So for cordova-crosswalk-engine, we can also have crosswalk-6 branch to track beta branch (later stable branch) and using master to track the latest crosswalk.

I am even thinking about we can setup some bots (as buildbots in crosswalk) to track if any patches to crosswalk break the cordova-crosswalk-engine.

Your thoughts?

Thanks,
-ningxin

From: iclelland@google.com [mailto:iclelland@google.com] On Behalf Of Ian Clelland
Sent: Thursday, April 24, 2014 1:32 AM
To: dev@cordova.apache.org
Cc: Joe Bowser; Hu, Ningxin
Subject: Re: [Android] Refactoring for different engines

I've managed to get this up and running now -- great work on this, Joe!

Mobilespec runs on my N4, with 10 failing tests: 3 in contacts; 7 in file-transfer. Otherwise, things seem to be working pretty well.

I used a new build of Crosswalk, and found that the embedding API has changed since the weekend (when Ningxin's patches applied). I've issued a pull request at https://github.com/infil00p/cordova-crosswalk-engine/pull/5 for it -- I'm not sure if there's a way to keep compatibility with last week's Crosswalk, or if we'd even want to. (Ningxin, if you could take a look at that PR and see if it makes sense, I'd appreciate it)

Joe, I also had to patch the default constructor for XWalkCordovaWebView; it wasn't creating its own client objects, so it got the default ones, and most of the tests were failing because some component of the bridge wan't working. https://github.com/infil00p/cordova-crosswalk-engine/pull/4 is out for that.

Count me in for the hangout -- this is exciting stuff

Ian

On Wed, Apr 23, 2014 at 10:26 AM, Brian LeRoux <b@...@brian.io>> wrote:
Yup I'll track em down
On Apr 23, 2014 7:17 AM, "Andrew Grieve" <ag...@chromium.org>> wrote:

> Does anyone have a contact at moz that we could invite?
>
> On Wed, Apr 23, 2014 at 10:09 AM, Andrew Grieve <ag...@chromium.org>>
> wrote:
> > Depends on their interest level I think. Faster we can get this out
> > the door the better. If we need to delay for geckoview, then I don't
> > think we should gate on it, just release it after.
> >
> > On Wed, Apr 23, 2014 at 3:01 AM, Tommy Williams <to...@devgeeks.org>>
> wrote:
> >> More engines, more better...
> >> On 23 Apr 2014 16:32, "Joe Bowser" <bo...@gmail.com>> wrote:
> >>
> >>> Hey
> >>>
> >>> A Hangout would have to happen on Friday at the earliest.  It'd be
> good if
> >>> we could get someone from Mozilla on the hangout as well.  I haven't
> gotten
> >>> MozillaView (GeckoView with Cordova methods) fully working yet.  For
> some
> >>> reason it's not rendering on the screen.
> >>>
> >>> Ideally it'd be cool to have at least two options when this feature
> finally
> >>> lands.
> >>>
> >>> What do other people think?
> >>>
> >>> Joe
> >>> On 22 Apr 2014 20:06, "Hu, Ningxin" <ni...@intel.com>> wrote:
> >>>
> >>> > Joe,
> >>> >
> >>> > Thanks for your review and merge the PRs.
> >>> >
> >>> > To pluggable webview interest group:
> >>> > Are we OK to setup a hangout this week for initial introduction and
> >>> > discussion of next steps?
> >>> >
> >>> > Thanks,
> >>> > -ningxin
> >>> >
> >>> > > -----Original Message-----
> >>> > > From: Hu, Ningxin [mailto:ningxin.hu@intel.com<ma...@intel.com>]
> >>> > > Sent: Tuesday, April 22, 2014 4:04 PM
> >>> > > To: dev@cordova.apache.org<ma...@cordova.apache.org>
> >>> > > Subject: RE: [Android] Refactoring for different engines
> >>> > >
> >>> > > The PoC is great! Quite excited about the direction!
> >>> > >
> >>> > > I've sent a PR to update the cordova-crosswalk-engine to latest
> >>> crosswalk
> >>> > > embedding API. It works with xwalk_core_library at 6.35.124.0.
> >>> > >
> >>> > > I've also changed the CordovaWebView interface slightly (adding
> >>> > getView() API)
> >>> > > to allow XWalkCordovaWebView to composite a XWalkView instead of
> >>> > extending
> >>> > > it. It resolves some API naming issues for XWalkView case.
> >>> > >
> >>> > > Please review them at:
> >>> > > https://github.com/infil00p/cordova-crosswalk-engine/pull/3
> >>> > > https://github.com/infil00p/cordova-android/pull/2
> >>> > >
> >>> > > Thanks,
> >>> > > -ningxin
> >>> > >
> >>> > > > -----Original Message-----
> >>> > > > From: Joe Bowser [mailto:bowserj@gmail.com<ma...@gmail.com>]
> >>> > > > Sent: Friday, April 11, 2014 12:45 AM
> >>> > > > To: dev
> >>> > > > Subject: Re: [Android] Refactoring for different engines
> >>> > > >
> >>> > > > Yeah, I'd be cool with setting up a hangout.  Everyone should
> take a
> >>> > > > look at the PoC, I've basically distilled it down to four or five
> >>> > > > classes so far, but with some work, we may be able to get it
> down to
> >>> > > > three.  Due to legacy, we're pretty stuck with the Android
> WebView
> >>> API
> >>> > calls,
> >>> > > but these can probably be modified.
> >>> > > >
> >>> > > > It'd be good to get Mozilla people on the call as well, since
> they
> >>> > > > have their WebView as well.
> >>> > > >
> >>> > > > On Thu, Apr 10, 2014 at 9:38 AM, Hu, Ningxin <
> ningxin.hu@intel.com<ma...@intel.com>>
> >>> > wrote:
> >>> > > > > Hangout would be a good idea.
> >>> > > > >
> >>> > > > > FYI, I will be off next week. How about the week after next?
> If it
> >>> > > > > works, please
> >>> > > > feel free to schedule one and count me in.
> >>> > > > >
> >>> > > > > Thanks,
> >>> > > > > -ningxin
> >>> > > > >
> >>> > > > >> -----Original Message-----
> >>> > > > >> From: mmocny@google.com<ma...@google.com> [mailto:mmocny@google.com<ma...@google.com>] On Behalf
> Of
> >>> > > > >> Michal Mocny
> >>> > > > >> Sent: Tuesday, April 08, 2014 11:39 PM
> >>> > > > >> To: dev
> >>> > > > >> Subject: Re: [Android] Refactoring for different engines
> >>> > > > >>
> >>> > > > >> Would it be alright to set up a Hangout some time to introduce
> >>> > everyone?
> >>> > > > >>
> >>> > > > >> Joe has been leading the effort here, but there are other
> cordova
> >>> > > > >> contributors for whom this is top priority.  It would be nice
> if
> >>> we
> >>> > > > >> could all meet to say hello and make sure we are all going in
> the
> >>> > > > >> right
> >>> > > > direction.
> >>> > > > >>
> >>> > > > >> Quite exciting!
> >>> > > > >>
> >>> > > > >> -Michal
> >>> > > > >>
> >>> > > > >>
> >>> > > > >> On Tue, Apr 8, 2014 at 10:56 AM, Hu, Ningxin <
> >>> ningxin.hu@intel.com<ma...@intel.com>>
> >>> > > wrote:
> >>> > > > >>
> >>> > > > >> > Joe, thanks for this. I am very excited.
> >>> > > > >> >
> >>> > > > >> > FYI. Crosswalk team is working on refactoring the WebView
> API to
> >>> > > > >> > support embedding usage better [1]. (Previously the layer
> API
> >>> was
> >>> > > > >> > not exposed as public usage).
> >>> > > > >> >
> >>> > > > >> > I would like to review the PoC and work with you to get
> >>> Crosswalk
> >>> > > > >> > fits into the pluggable WebView architecture.
> >>> > > > >> >
> >>> > > > >> > Thanks,
> >>> > > > >> > -ningxin
> >>> > > > >> >
> >>> > > > >> > > -----Original Message-----
> >>> > > > >> > > From: Joe Bowser [mailto:bowserj@gmail.com<ma...@gmail.com>]
> >>> > > > >> > > Sent: Wednesday, March 19, 2014 7:08 AM
> >>> > > > >> > > To: dev
> >>> > > > >> > > Subject: Re: [Android] Refactoring for different engines
> >>> > > > >> > >
> >>> > > > >> > > Hey
> >>> > > > >> > >
> >>> > > > >> > > After debugging, I did some minor updates to the plugin
> >>> README.
> >>> > > > >> > > It
> >>> > > > >> > should be
> >>> > > > >> > > easier to get this up and running, although there's still
> the
> >>> > > > >> > > issue of
> >>> > > > >> > after-install
> >>> > > > >> > > hooks and the relative path weirdness with the Crosswalk
> >>> > Library itself.
> >>> > > > >> > >
> >>> > > > >> > > It still doesn't support the CLI at all, but it should be
> >>> there
> >>> > > > >> > > with the
> >>> > > > >> > old flow.
> >>> > > > >> > >
> >>> > > > >> > > On Mon, Mar 17, 2014 at 1:14 PM, Michal Mocny
> >>> > > > >> > > <mm...@chromium.org>>
> >>> > > > >> > > wrote:
> >>> > > > >> > > > (Sorry Joe, Googlers are down in California and way
> busy.
> >>> > > > >> > > > Will be back in a week.  Super excited about this,
> though.)
> >>> > > > >> > > >
> >>> > > > >> > > > -Michal
> >>> > > > >> > > >
> >>> > > > >> > > >
> >>> > > > >> > > > On Mon, Mar 17, 2014 at 2:53 PM, Joe Bowser
> >>> > > > >> > > > <bo...@gmail.com>>
> >>> > > > >> wrote:
> >>> > > > >> > > >
> >>> > > > >> > > >> Reviving this thread!
> >>> > > > >> > > >>
> >>> > > > >> > > >> Can other people look at this, and see if/when we
> should
> >>> > land this?
> >>> > > > >> > > >> I know that I have to re-write the tests still, but I
> would
> >>> > > > >> > > >> like some feedback before merging it in.  Also, it'd be
> >>> > > > >> > > >> super awesome if other people could try and make a
> WebView
> >>> > > > >> > > >> based on the interfaces and recommend which methods
> should
> >>> > > > >> > > >> die.  I want to get this released in the next month or
> so,
> >>> > > > >> > > >> so any time and feedback would be greatly appreciated.
> >>> > > > >> > > >>
> >>> > > > >> > > >> Thanks
> >>> > > > >> > > >>
> >>> > > > >> > > >> On Thu, Mar 13, 2014 at 3:50 PM, Joe Bowser
> >>> > > > >> > > >> <bo...@gmail.com>>
> >>> > > > >> > wrote:
> >>> > > > >> > > >> > Hey, I created the following today to track various
> >>> > > > >> > > >> > WebView
> >>> > > > >> > progresses:
> >>> > > > >> > > >> > https://issues.apache.org/jira/browse/CB-6246
> >>> > > > >> > > >> >
> >>> > > > >> > > >> > I also have this repo created.  The licensing is
> ugly as
> >>> > > > >> > > >> > all crap, but it's a Proof-Of-Concept:
> >>> > > > >> > > >> > https://github.com/infil00p/cordova-crosswalk-engine
> >>> > > > >> > > >> >
> >>> > > > >> > > >> > If I can get some help getting plugman to just load
> >>> > > > >> > > >> > Crosswalk, it'll
> >>> > > > >> > > >> look hawt.
> >>> > > > >> > > >> >
> >>> > > > >> > > >> > BTW: We should probably get this ready to go into
> Android
> >>> > > > >> > > >> > in the next two months and deprecate the setProperty
> >>> > > > >> > > >> > methods, since all properties should be preferences
> in
> >>> > config.xml
> >>> > > now.
> >>> > > > >> > > >> >
> >>> > > > >> > > >> > On Mon, Mar 10, 2014 at 2:42 PM, Joe Bowser
> >>> > > > >> > > >> > <bo...@gmail.com>>
> >>> > > > >> > > wrote:
> >>> > > > >> > > >> >> Perhaps. There would be additional benefits to this
> >>> > > > >> > > >> >> approach, namely fixes being added to that platform
> more
> >>> > > > >> > > >> >> quickly.  I'll probably take a look at that once I
> have
> >>> > > > >> > > >> >> Crosswalk
> >>> > > > finalized.
> >>> > > > >> > > >> >>
> >>> > > > >> > > >> >> On Mon, Mar 10, 2014 at 9:49 AM, Brian LeRoux
> >>> > > > >> > > >> >> <b@...@brian.io>>
> >>> > > > wrote:
> >>> > > > >> > > >> >>> this is great stuff
> >>> > > > >> > > >> >>>
> >>> > > > >> > > >> >>> do we think it may be possible to bring in amazon
> >>> fireos
> >>> > > > >> > > >> >>> stuff
> >>> > > > >> > > >> eventually
> >>> > > > >> > > >> >>> too?
> >>> > > > >> > > >> >>>
> >>> > > > >> > > >> >>>
> >>> > > > >> > > >> >>> On Fri, Mar 7, 2014 at 3:22 PM, Joe Bowser
> >>> > > > >> > > >> >>> <bo...@gmail.com>>
> >>> > > > >> > wrote:
> >>> > > > >> > > >> >>>
> >>> > > > >> > > >> >>>> BTW: I committed it in my repo, not the main
> Apache
> >>> one.
> >>> > > > >> > > >> >>>>
> >>> > > > >> > > >> >>>> On Fri, Mar 7, 2014 at 3:21 PM, Joe Bowser
> >>> > > > >> > > >> >>>> <bo...@gmail.com>>
> >>> > > > >> > > wrote:
> >>> > > > >> > > >> >>>> > Hey
> >>> > > > >> > > >> >>>> >
> >>> > > > >> > > >> >>>> > I just committed some code based on their
> WebView
> >>> > > > >> > > >> >>>> > modifications that allows you to choose your
> >>> renderer
> >>> > > > >> > > >> >>>> > in the
> >>> > > > >> > config file
> >>> > > > >> > > with this:
> >>> > > > >> > > >> >>>> >
> >>> > > > >> > > >> >>>> >     <preference name="webView"
> >>> > > > >> > > >> >>>> >
> >>> value="org.apache.cordova.engine.crosswalk.XWalkCordo
> >>> > > > >> > > >> >>>> > va
> >>> > > > >> > > >> >>>> > Web
> >>> > > > >> > > >> >>>> > View
> >>> > > > >> > > >> >>>> > " />
> >>> > > > >> > > >> >>>> >
> >>> > > > >> > > >> >>>> > You currently have to copy over the *.pak file
> and
> >>> > > > >> > > >> >>>> > the jsapi from a Crosswalk Example project to
> get
> >>> > > > >> > > >> >>>> > this to work.  The next thing that I'm going to
> do
> >>> is
> >>> > > > >> > > >> >>>> > figure out how to write this as a plugin and
> have it
> >>> > > > >> > > >> >>>> > install on a default
> >>> > > > project.
> >>> > > > >> > > >> >>>> > Also, right now the bridge doesn't seem to
> work, and
> >>> > > > >> > > >> >>>> > I don't know why exactly.  That being said, the
> >>> > > > >> > > >> fact
> >>> > > > >> > > >> >>>> > that I can choose which version of
> Chrome/Chromium
> >>> > > > >> > > >> >>>> > I'm running with
> >>> > > > >> > > >> a
> >>> > > > >> > > >> >>>> > single XML preference is HUGE.
> >>> > > > >> > > >> >>>> >
> >>> > > > >> > > >> >>>> > There's definitely a lot more work that needs
> to be
> >>> > > > >> > > >> >>>> > done, but as
> >>> > > > >> > > >> long
> >>> > > > >> > > >> >>>> > as we have something that we can fit into the
> >>> > > > >> > > >> >>>> > interface, we should
> >>> > > > >> > > >> be
> >>> > > > >> > > >> >>>> > able to put in things like GeckoView or other
> third
> >>> > > > >> > > >> >>>> > party
> >>> > > > >> > renderers.
> >>> > > > >> > > >> >>>> > The nightmare of being stuck with bullshit
> WebView
> >>> > > > >> > > >> >>>> > bugs may soon be over.
> >>> > > > >> > > >> >>>> >
> >>> > > > >> > > >> >>>> > On Wed, Mar 5, 2014 at 8:59 PM, Michal Mocny
> >>> > > > >> > > >> >>>> > <mm...@chromium.org>>
> >>> > > > >> > > >> >>>> wrote:
> >>> > > > >> > > >> >>>> >>
> >>> https://github.com/crosswalk-project/crosswalk-cordo
> >>> > > > >> > > >> >>>> >> va
> >>> > > > >> > > >> >>>> >> -an
> >>> > > > >> > > >> >>>> >> droi
> >>> > > > >> > > >> >>>> >> d
> >>> > > > >> > > >> >>>> >>
> >>> > > > >> > > >> >>>> >> First patch they landed, which claims to have
> min
> >>> > > > >> > > >> >>>> >> viable xwalk
> >>> > > > >> > > >> webview:
> >>> > > > >> > > >> >>>> >>
> >>> > > > >> > > >> >>>>
> >>> > > > >> > > >>
> >>> https://github.com/crosswalk-project/crosswalk-cordova-andro
> >>> > > > >> > > >> id
> >>> > > > >> > > >> /co
> >>> > > > >> > > >> mmit
> >>> > > > >> > > >> /a04dedeb0204e7542d190312c6ae70c795a26e04
> >>> > > > >> > > >> >>>> >>
> >>> > > > >> > > >> >>>> >>
> >>> > > > >> > > >> >>>> >> On Wed, Mar 5, 2014 at 11:37 PM, Michal Mocny
> >>> > > > >> > > >> >>>> >> <mm...@chromium.org>
> >>> > > > >> > > >> >
> >>> > > > >> > > >> >>>> wrote:
> >>> > > > >> > > >> >>>> >>
> >>> > > > >> > > >> >>>> >>> I haven't looked yet, but did you see:
> >>> > > > >> > > >> >>>> >>>
> >>> https://crosswalk-project.org/#wiki/crosswalk-cordo
> >>> > > > >> > > >> >>>> >>> va
> >>> > > > >> > > >> >>>> >>> -an
> >>> > > > >> > > >> >>>> >>> droi
> >>> > > > >> > > >> >>>> >>> d
> >>> > > > >> > > >> >>>> >>>
> >>> > > > >> > > >> >>>> >>> ?
> >>> > > > >> > > >> >>>> >>>
> >>> > > > >> > > >> >>>> >>>
> >>> > > > >> > > >> >>>> >>> On Wed, Mar 5, 2014 at 10:20 PM, Andrew
> Grieve <
> >>> > > > >> > > >> agrieve@chromium.org<ma...@chromium.org>
> >>> > > > >> > > >> >>>> >wrote:
> >>> > > > >> > > >> >>>> >>>
> >>> > > > >> > > >> >>>> >>>> First - very excited that you're working on
> this!
> >>> > > > >> > > >> >>>> >>>>
> >>> > > > >> > > >> >>>> >>>> Had a quick look. Not sure there's much to be
> >>> > gleaned
> >>> > > yet.
> >>> > > > >> > > >> >>>> >>>> Once
> >>> > > > >> > > >> you
> >>> > > > >> > > >> >>>> start
> >>> > > > >> > > >> >>>> >>>> in on hooking up x-walk's webview I think it
> will
> >>> > > > >> > > >> >>>> >>>> become more
> >>> > > > >> > > >> obvious
> >>> > > > >> > > >> >>>> what
> >>> > > > >> > > >> >>>> >>>> the interface should look like. E.g., does
> x-walk
> >>> > > > >> > > >> >>>> >>>> even have the
> >>> > > > >> > > >> >>>> concept of
> >>> > > > >> > > >> >>>> >>>> ChromeClient vs WebViewClient vs WebView?
> Also
> >>> > > > >> > > >> >>>> >>>> unsure whether the
> >>> > > > >> > > >> >>>> class
> >>> > > > >> > > >> >>>> >>>> should extend android.View as well as
> implement
> >>> > > > >> > > >> >>>> >>>> our
> >>> > > > >> > interface.
> >>> > > > >> > > >> E.g.
> >>> > > > >> > > >> >>>> >>>> alternative is to have a "getView()" method
> on
> >>> the
> >>> > > > >> > interface.
> >>> > > > >> > > >> Might
> >>> > > > >> > > >> >>>> help
> >>> > > > >> > > >> >>>> >>>> to
> >>> > > > >> > > >> >>>> >>>> cut down on file sizes, and API surface, but
> >>> > > > >> > > >> >>>> >>>> again, I'm not too
> >>> > > > >> > > >> sure.
> >>> > > > >> > > >> >>>> >>>>
> >>> > > > >> > > >> >>>> >>>> I've been pretty hesitant to touch existing
> >>> > > > >> > > >> >>>> >>>> exposed members
> >>> > > > >> > > >> (e.g. the
> >>> > > > >> > > >> >>>> >>>> public fields you were referring to) since
> >>> > > > >> > > >> >>>> >>>> touching anything
> >>> > > > >> > > >> public
> >>> > > > >> > > >> >>>> could
> >>> > > > >> > > >> >>>> >>>> break plugins. That said, maybe now is a good
> >>> time
> >>> > > > >> > > >> >>>> >>>> to @deprecate
> >>> > > > >> > > >> a
> >>> > > > >> > > >> >>>> bunch
> >>> > > > >> > > >> >>>> >>>> of
> >>> > > > >> > > >> >>>> >>>> them and either replace them with getters, or
> >>> just
> >>> > > > >> > > >> >>>> >>>> declare them
> >>> > > > >> > > >> to be
> >>> > > > >> > > >> >>>> not
> >>> > > > >> > > >> >>>> >>>> exposed to plugins.
> >>> > > > >> > > >> >>>> >>>>
> >>> > > > >> > > >> >>>> >>>>
> >>> > > > >> > > >> >>>> >>>> On Wed, Mar 5, 2014 at 6:57 PM, Joe Bowser
> >>> > > > >> > > >> >>>> >>>> <bo...@gmail.com>>
> >>> > > > >> > > >> wrote:
> >>> > > > >> > > >> >>>> >>>>
> >>> > > > >> > > >> >>>> >>>> > So, after looking at the Crosswalk code
> again,
> >>> > > > >> > > >> >>>> >>>> > I've decided to
> >>> > > > >> > > >> take
> >>> > > > >> > > >> >>>> a
> >>> > > > >> > > >> >>>> >>>> > quick stab at making things pluggable.  I
> don't
> >>> > > > >> > > >> >>>> >>>> > have a lot to
> >>> > > > >> > > >> show
> >>> > > > >> > > >> >>>> for
> >>> > > > >> > > >> >>>> >>>> > it, but with the help of Eclipse (which is
> why
> >>> > > > >> > > >> >>>> >>>> > the generated interfaces look so screwed
> up), I
> >>> > > > >> > > >> >>>> >>>> > managed to create some
> >>> > > > >> > > >> interfaces
> >>> > > > >> > > >> >>>> so
> >>> > > > >> > > >> >>>> >>>> > we can start shoehorning in other browser
> >>> > renderers.
> >>> > > > >> > > >> >>>> >>>> >
> >>> > > > >> > > >> >>>> >>>> >
> >>> > > > >> > > >>
> >>> https://github.com/infil00p/cordova-android/tree/pluggable_w
> >>> > > > >> > > >> eb
> >>> > > > >> > > >> vie
> >>> > > > >> > > >> w
> >>> > > > >> > > >> >>>> >>>> >
> >>> > > > >> > > >> >>>> >>>> > I'm going to probably start with Crosswalk,
> >>> > > > >> > > >> >>>> >>>> > because it's
> >>> > > > >> > > >> probably
> >>> > > > >> > > >> >>>> the
> >>> > > > >> > > >> >>>> >>>> > most mature primary candidate in the
> Android
> >>> > > > >> > > >> >>>> >>>> > Third-Party
> >>> > > > >> > > >> WebView
> >>> > > > >> > > >> >>>> >>>> > thing, and I'm pretty sure the GeckoView
> will
> >>> be
> >>> > > > >> > > >> >>>> >>>> > happening
> >>> > > > >> > > >> shortly
> >>> > > > >> > > >> >>>> >>>> > after.
> >>> > > > >> > > >> >>>> >>>> >
> >>> > > > >> > > >> >>>> >>>> > I don't know how this would work w.r.t.
> the CLI
> >>> > > > >> > > >> >>>> >>>> > or our
> >>> > > > >> > > >> workflow at
> >>> > > > >> > > >> >>>> >>>> > all, but at the moment, I really just want
> to
> >>> at
> >>> > > > >> > > >> >>>> >>>> > least start
> >>> > > > >> > > >> to have
> >>> > > > >> > > >> >>>> >>>> > some headway towards 4.x and PhoneGap day.
> >>> > > > >> > > >> >>>> >>>> >
> >>> > > > >> > > >> >>>> >>>> > What do people think of this so far? I'm
> going
> >>> > > > >> > > >> >>>> >>>> > to try to clean
> >>> > > > >> > > >> >>>> things
> >>> > > > >> > > >> >>>> >>>> > up a bit, since we've definitely done a
> lot of
> >>> > > > >> > > >> >>>> >>>> > things that
> >>> > > > >> > > >> would
> >>> > > > >> > > >> >>>> make
> >>> > > > >> > > >> >>>> >>>> > first year CS profs freak the hell out
> (i.e.
> >>> > > > >> > > >> >>>> >>>> > public members in
> >>> > > > >> > > >> >>>> public
> >>> > > > >> > > >> >>>> >>>> > objects w.r.t. PluginManager).
> >>> > > > >> > > >> >>>> >>>> >
> >>> > > > >> > > >> >>>> >>>> > Thoughts?
> >>> > > > >> > > >> >>>> >>>> >
> >>> > > > >> > > >> >>>> >>>> > Joe
> >>> > > > >> > > >> >>>> >>>> >
> >>> > > > >> > > >> >>>> >>>>
> >>> > > > >> > > >> >>>> >>>
> >>> > > > >> > > >> >>>> >>>
> >>> > > > >> > > >> >>>>
> >>> > > > >> > > >>
> >>> > > > >> >
> >>> >
> >>>
>

Re: [Android] Refactoring for different engines

[Ian Clelland <ic...@chromium.org>]

I've managed to get this up and running now -- great work on this, Joe!

Mobilespec runs on my N4, with 10 failing tests: 3 in contacts; 7 in
file-transfer. Otherwise, things seem to be working pretty well.

I used a new build of Crosswalk, and found that the embedding API has
changed since the weekend (when Ningxin's patches applied). I've issued a
pull request at
https://github.com/infil00p/cordova-crosswalk-engine/pull/5for it --
I'm not sure if there's a way to keep compatibility with last
week's Crosswalk, or if we'd even want to. (Ningxin, if you could take a
look at that PR and see if it makes sense, I'd appreciate it)

Joe, I also had to patch the default constructor for XWalkCordovaWebView;
it wasn't creating its own client objects, so it got the default ones, and
most of the tests were failing because some component of the bridge wan't
working. https://github.com/infil00p/cordova-crosswalk-engine/pull/4 is out
for that.

Count me in for the hangout -- this is exciting stuff

Ian


On Wed, Apr 23, 2014 at 10:26 AM, Brian LeRoux <b...@brian.io> wrote:

> Yup I'll track em down
> On Apr 23, 2014 7:17 AM, "Andrew Grieve" <ag...@chromium.org> wrote:
>
> > Does anyone have a contact at moz that we could invite?
> >
> > On Wed, Apr 23, 2014 at 10:09 AM, Andrew Grieve <ag...@chromium.org>
> > wrote:
> > > Depends on their interest level I think. Faster we can get this out
> > > the door the better. If we need to delay for geckoview, then I don't
> > > think we should gate on it, just release it after.
> > >
> > > On Wed, Apr 23, 2014 at 3:01 AM, Tommy Williams <to...@devgeeks.org>
> > wrote:
> > >> More engines, more better...
> > >> On 23 Apr 2014 16:32, "Joe Bowser" <bo...@gmail.com> wrote:
> > >>
> > >>> Hey
> > >>>
> > >>> A Hangout would have to happen on Friday at the earliest.  It'd be
> > good if
> > >>> we could get someone from Mozilla on the hangout as well.  I haven't
> > gotten
> > >>> MozillaView (GeckoView with Cordova methods) fully working yet.  For
> > some
> > >>> reason it's not rendering on the screen.
> > >>>
> > >>> Ideally it'd be cool to have at least two options when this feature
> > finally
> > >>> lands.
> > >>>
> > >>> What do other people think?
> > >>>
> > >>> Joe
> > >>> On 22 Apr 2014 20:06, "Hu, Ningxin" <ni...@intel.com> wrote:
> > >>>
> > >>> > Joe,
> > >>> >
> > >>> > Thanks for your review and merge the PRs.
> > >>> >
> > >>> > To pluggable webview interest group:
> > >>> > Are we OK to setup a hangout this week for initial introduction and
> > >>> > discussion of next steps?
> > >>> >
> > >>> > Thanks,
> > >>> > -ningxin
> > >>> >
> > >>> > > -----Original Message-----
> > >>> > > From: Hu, Ningxin [mailto:ningxin.hu@intel.com]
> > >>> > > Sent: Tuesday, April 22, 2014 4:04 PM
> > >>> > > To: dev@cordova.apache.org
> > >>> > > Subject: RE: [Android] Refactoring for different engines
> > >>> > >
> > >>> > > The PoC is great! Quite excited about the direction!
> > >>> > >
> > >>> > > I've sent a PR to update the cordova-crosswalk-engine to latest
> > >>> crosswalk
> > >>> > > embedding API. It works with xwalk_core_library at 6.35.124.0.
> > >>> > >
> > >>> > > I've also changed the CordovaWebView interface slightly (adding
> > >>> > getView() API)
> > >>> > > to allow XWalkCordovaWebView to composite a XWalkView instead of
> > >>> > extending
> > >>> > > it. It resolves some API naming issues for XWalkView case.
> > >>> > >
> > >>> > > Please review them at:
> > >>> > > https://github.com/infil00p/cordova-crosswalk-engine/pull/3
> > >>> > > https://github.com/infil00p/cordova-android/pull/2
> > >>> > >
> > >>> > > Thanks,
> > >>> > > -ningxin
> > >>> > >
> > >>> > > > -----Original Message-----
> > >>> > > > From: Joe Bowser [mailto:bowserj@gmail.com]
> > >>> > > > Sent: Friday, April 11, 2014 12:45 AM
> > >>> > > > To: dev
> > >>> > > > Subject: Re: [Android] Refactoring for different engines
> > >>> > > >
> > >>> > > > Yeah, I'd be cool with setting up a hangout.  Everyone should
> > take a
> > >>> > > > look at the PoC, I've basically distilled it down to four or
> five
> > >>> > > > classes so far, but with some work, we may be able to get it
> > down to
> > >>> > > > three.  Due to legacy, we're pretty stuck with the Android
> > WebView
> > >>> API
> > >>> > calls,
> > >>> > > but these can probably be modified.
> > >>> > > >
> > >>> > > > It'd be good to get Mozilla people on the call as well, since
> > they
> > >>> > > > have their WebView as well.
> > >>> > > >
> > >>> > > > On Thu, Apr 10, 2014 at 9:38 AM, Hu, Ningxin <
> > ningxin.hu@intel.com>
> > >>> > wrote:
> > >>> > > > > Hangout would be a good idea.
> > >>> > > > >
> > >>> > > > > FYI, I will be off next week. How about the week after next?
> > If it
> > >>> > > > > works, please
> > >>> > > > feel free to schedule one and count me in.
> > >>> > > > >
> > >>> > > > > Thanks,
> > >>> > > > > -ningxin
> > >>> > > > >
> > >>> > > > >> -----Original Message-----
> > >>> > > > >> From: mmocny@google.com [mailto:mmocny@google.com] On
> Behalf
> > Of
> > >>> > > > >> Michal Mocny
> > >>> > > > >> Sent: Tuesday, April 08, 2014 11:39 PM
> > >>> > > > >> To: dev
> > >>> > > > >> Subject: Re: [Android] Refactoring for different engines
> > >>> > > > >>
> > >>> > > > >> Would it be alright to set up a Hangout some time to
> introduce
> > >>> > everyone?
> > >>> > > > >>
> > >>> > > > >> Joe has been leading the effort here, but there are other
> > cordova
> > >>> > > > >> contributors for whom this is top priority.  It would be
> nice
> > if
> > >>> we
> > >>> > > > >> could all meet to say hello and make sure we are all going
> in
> > the
> > >>> > > > >> right
> > >>> > > > direction.
> > >>> > > > >>
> > >>> > > > >> Quite exciting!
> > >>> > > > >>
> > >>> > > > >> -Michal
> > >>> > > > >>
> > >>> > > > >>
> > >>> > > > >> On Tue, Apr 8, 2014 at 10:56 AM, Hu, Ningxin <
> > >>> ningxin.hu@intel.com>
> > >>> > > wrote:
> > >>> > > > >>
> > >>> > > > >> > Joe, thanks for this. I am very excited.
> > >>> > > > >> >
> > >>> > > > >> > FYI. Crosswalk team is working on refactoring the WebView
> > API to
> > >>> > > > >> > support embedding usage better [1]. (Previously the layer
> > API
> > >>> was
> > >>> > > > >> > not exposed as public usage).
> > >>> > > > >> >
> > >>> > > > >> > I would like to review the PoC and work with you to get
> > >>> Crosswalk
> > >>> > > > >> > fits into the pluggable WebView architecture.
> > >>> > > > >> >
> > >>> > > > >> > Thanks,
> > >>> > > > >> > -ningxin
> > >>> > > > >> >
> > >>> > > > >> > > -----Original Message-----
> > >>> > > > >> > > From: Joe Bowser [mailto:bowserj@gmail.com]
> > >>> > > > >> > > Sent: Wednesday, March 19, 2014 7:08 AM
> > >>> > > > >> > > To: dev
> > >>> > > > >> > > Subject: Re: [Android] Refactoring for different engines
> > >>> > > > >> > >
> > >>> > > > >> > > Hey
> > >>> > > > >> > >
> > >>> > > > >> > > After debugging, I did some minor updates to the plugin
> > >>> README.
> > >>> > > > >> > > It
> > >>> > > > >> > should be
> > >>> > > > >> > > easier to get this up and running, although there's
> still
> > the
> > >>> > > > >> > > issue of
> > >>> > > > >> > after-install
> > >>> > > > >> > > hooks and the relative path weirdness with the Crosswalk
> > >>> > Library itself.
> > >>> > > > >> > >
> > >>> > > > >> > > It still doesn't support the CLI at all, but it should
> be
> > >>> there
> > >>> > > > >> > > with the
> > >>> > > > >> > old flow.
> > >>> > > > >> > >
> > >>> > > > >> > > On Mon, Mar 17, 2014 at 1:14 PM, Michal Mocny
> > >>> > > > >> > > <mm...@chromium.org>
> > >>> > > > >> > > wrote:
> > >>> > > > >> > > > (Sorry Joe, Googlers are down in California and way
> > busy.
> > >>> > > > >> > > > Will be back in a week.  Super excited about this,
> > though.)
> > >>> > > > >> > > >
> > >>> > > > >> > > > -Michal
> > >>> > > > >> > > >
> > >>> > > > >> > > >
> > >>> > > > >> > > > On Mon, Mar 17, 2014 at 2:53 PM, Joe Bowser
> > >>> > > > >> > > > <bo...@gmail.com>
> > >>> > > > >> wrote:
> > >>> > > > >> > > >
> > >>> > > > >> > > >> Reviving this thread!
> > >>> > > > >> > > >>
> > >>> > > > >> > > >> Can other people look at this, and see if/when we
> > should
> > >>> > land this?
> > >>> > > > >> > > >> I know that I have to re-write the tests still, but I
> > would
> > >>> > > > >> > > >> like some feedback before merging it in.  Also, it'd
> be
> > >>> > > > >> > > >> super awesome if other people could try and make a
> > WebView
> > >>> > > > >> > > >> based on the interfaces and recommend which methods
> > should
> > >>> > > > >> > > >> die.  I want to get this released in the next month
> or
> > so,
> > >>> > > > >> > > >> so any time and feedback would be greatly
> appreciated.
> > >>> > > > >> > > >>
> > >>> > > > >> > > >> Thanks
> > >>> > > > >> > > >>
> > >>> > > > >> > > >> On Thu, Mar 13, 2014 at 3:50 PM, Joe Bowser
> > >>> > > > >> > > >> <bo...@gmail.com>
> > >>> > > > >> > wrote:
> > >>> > > > >> > > >> > Hey, I created the following today to track various
> > >>> > > > >> > > >> > WebView
> > >>> > > > >> > progresses:
> > >>> > > > >> > > >> > https://issues.apache.org/jira/browse/CB-6246
> > >>> > > > >> > > >> >
> > >>> > > > >> > > >> > I also have this repo created.  The licensing is
> > ugly as
> > >>> > > > >> > > >> > all crap, but it's a Proof-Of-Concept:
> > >>> > > > >> > > >> >
> https://github.com/infil00p/cordova-crosswalk-engine
> > >>> > > > >> > > >> >
> > >>> > > > >> > > >> > If I can get some help getting plugman to just load
> > >>> > > > >> > > >> > Crosswalk, it'll
> > >>> > > > >> > > >> look hawt.
> > >>> > > > >> > > >> >
> > >>> > > > >> > > >> > BTW: We should probably get this ready to go into
> > Android
> > >>> > > > >> > > >> > in the next two months and deprecate the
> setProperty
> > >>> > > > >> > > >> > methods, since all properties should be preferences
> > in
> > >>> > config.xml
> > >>> > > now.
> > >>> > > > >> > > >> >
> > >>> > > > >> > > >> > On Mon, Mar 10, 2014 at 2:42 PM, Joe Bowser
> > >>> > > > >> > > >> > <bo...@gmail.com>
> > >>> > > > >> > > wrote:
> > >>> > > > >> > > >> >> Perhaps. There would be additional benefits to
> this
> > >>> > > > >> > > >> >> approach, namely fixes being added to that
> platform
> > more
> > >>> > > > >> > > >> >> quickly.  I'll probably take a look at that once I
> > have
> > >>> > > > >> > > >> >> Crosswalk
> > >>> > > > finalized.
> > >>> > > > >> > > >> >>
> > >>> > > > >> > > >> >> On Mon, Mar 10, 2014 at 9:49 AM, Brian LeRoux
> > >>> > > > >> > > >> >> <b...@brian.io>
> > >>> > > > wrote:
> > >>> > > > >> > > >> >>> this is great stuff
> > >>> > > > >> > > >> >>>
> > >>> > > > >> > > >> >>> do we think it may be possible to bring in amazon
> > >>> fireos
> > >>> > > > >> > > >> >>> stuff
> > >>> > > > >> > > >> eventually
> > >>> > > > >> > > >> >>> too?
> > >>> > > > >> > > >> >>>
> > >>> > > > >> > > >> >>>
> > >>> > > > >> > > >> >>> On Fri, Mar 7, 2014 at 3:22 PM, Joe Bowser
> > >>> > > > >> > > >> >>> <bo...@gmail.com>
> > >>> > > > >> > wrote:
> > >>> > > > >> > > >> >>>
> > >>> > > > >> > > >> >>>> BTW: I committed it in my repo, not the main
> > Apache
> > >>> one.
> > >>> > > > >> > > >> >>>>
> > >>> > > > >> > > >> >>>> On Fri, Mar 7, 2014 at 3:21 PM, Joe Bowser
> > >>> > > > >> > > >> >>>> <bo...@gmail.com>
> > >>> > > > >> > > wrote:
> > >>> > > > >> > > >> >>>> > Hey
> > >>> > > > >> > > >> >>>> >
> > >>> > > > >> > > >> >>>> > I just committed some code based on their
> > WebView
> > >>> > > > >> > > >> >>>> > modifications that allows you to choose your
> > >>> renderer
> > >>> > > > >> > > >> >>>> > in the
> > >>> > > > >> > config file
> > >>> > > > >> > > with this:
> > >>> > > > >> > > >> >>>> >
> > >>> > > > >> > > >> >>>> >     <preference name="webView"
> > >>> > > > >> > > >> >>>> >
> > >>> value="org.apache.cordova.engine.crosswalk.XWalkCordo
> > >>> > > > >> > > >> >>>> > va
> > >>> > > > >> > > >> >>>> > Web
> > >>> > > > >> > > >> >>>> > View
> > >>> > > > >> > > >> >>>> > " />
> > >>> > > > >> > > >> >>>> >
> > >>> > > > >> > > >> >>>> > You currently have to copy over the *.pak file
> > and
> > >>> > > > >> > > >> >>>> > the jsapi from a Crosswalk Example project to
> > get
> > >>> > > > >> > > >> >>>> > this to work.  The next thing that I'm going
> to
> > do
> > >>> is
> > >>> > > > >> > > >> >>>> > figure out how to write this as a plugin and
> > have it
> > >>> > > > >> > > >> >>>> > install on a default
> > >>> > > > project.
> > >>> > > > >> > > >> >>>> > Also, right now the bridge doesn't seem to
> > work, and
> > >>> > > > >> > > >> >>>> > I don't know why exactly.  That being said,
> the
> > >>> > > > >> > > >> fact
> > >>> > > > >> > > >> >>>> > that I can choose which version of
> > Chrome/Chromium
> > >>> > > > >> > > >> >>>> > I'm running with
> > >>> > > > >> > > >> a
> > >>> > > > >> > > >> >>>> > single XML preference is HUGE.
> > >>> > > > >> > > >> >>>> >
> > >>> > > > >> > > >> >>>> > There's definitely a lot more work that needs
> > to be
> > >>> > > > >> > > >> >>>> > done, but as
> > >>> > > > >> > > >> long
> > >>> > > > >> > > >> >>>> > as we have something that we can fit into the
> > >>> > > > >> > > >> >>>> > interface, we should
> > >>> > > > >> > > >> be
> > >>> > > > >> > > >> >>>> > able to put in things like GeckoView or other
> > third
> > >>> > > > >> > > >> >>>> > party
> > >>> > > > >> > renderers.
> > >>> > > > >> > > >> >>>> > The nightmare of being stuck with bullshit
> > WebView
> > >>> > > > >> > > >> >>>> > bugs may soon be over.
> > >>> > > > >> > > >> >>>> >
> > >>> > > > >> > > >> >>>> > On Wed, Mar 5, 2014 at 8:59 PM, Michal Mocny
> > >>> > > > >> > > >> >>>> > <mm...@chromium.org>
> > >>> > > > >> > > >> >>>> wrote:
> > >>> > > > >> > > >> >>>> >>
> > >>> https://github.com/crosswalk-project/crosswalk-cordo
> > >>> > > > >> > > >> >>>> >> va
> > >>> > > > >> > > >> >>>> >> -an
> > >>> > > > >> > > >> >>>> >> droi
> > >>> > > > >> > > >> >>>> >> d
> > >>> > > > >> > > >> >>>> >>
> > >>> > > > >> > > >> >>>> >> First patch they landed, which claims to have
> > min
> > >>> > > > >> > > >> >>>> >> viable xwalk
> > >>> > > > >> > > >> webview:
> > >>> > > > >> > > >> >>>> >>
> > >>> > > > >> > > >> >>>>
> > >>> > > > >> > > >>
> > >>> https://github.com/crosswalk-project/crosswalk-cordova-andro
> > >>> > > > >> > > >> id
> > >>> > > > >> > > >> /co
> > >>> > > > >> > > >> mmit
> > >>> > > > >> > > >> /a04dedeb0204e7542d190312c6ae70c795a26e04
> > >>> > > > >> > > >> >>>> >>
> > >>> > > > >> > > >> >>>> >>
> > >>> > > > >> > > >> >>>> >> On Wed, Mar 5, 2014 at 11:37 PM, Michal Mocny
> > >>> > > > >> > > >> >>>> >> <mmocny@chromium.org
> > >>> > > > >> > > >> >
> > >>> > > > >> > > >> >>>> wrote:
> > >>> > > > >> > > >> >>>> >>
> > >>> > > > >> > > >> >>>> >>> I haven't looked yet, but did you see:
> > >>> > > > >> > > >> >>>> >>>
> > >>> https://crosswalk-project.org/#wiki/crosswalk-cordo
> > >>> > > > >> > > >> >>>> >>> va
> > >>> > > > >> > > >> >>>> >>> -an
> > >>> > > > >> > > >> >>>> >>> droi
> > >>> > > > >> > > >> >>>> >>> d
> > >>> > > > >> > > >> >>>> >>>
> > >>> > > > >> > > >> >>>> >>> ?
> > >>> > > > >> > > >> >>>> >>>
> > >>> > > > >> > > >> >>>> >>>
> > >>> > > > >> > > >> >>>> >>> On Wed, Mar 5, 2014 at 10:20 PM, Andrew
> > Grieve <
> > >>> > > > >> > > >> agrieve@chromium.org
> > >>> > > > >> > > >> >>>> >wrote:
> > >>> > > > >> > > >> >>>> >>>
> > >>> > > > >> > > >> >>>> >>>> First - very excited that you're working on
> > this!
> > >>> > > > >> > > >> >>>> >>>>
> > >>> > > > >> > > >> >>>> >>>> Had a quick look. Not sure there's much to
> be
> > >>> > gleaned
> > >>> > > yet.
> > >>> > > > >> > > >> >>>> >>>> Once
> > >>> > > > >> > > >> you
> > >>> > > > >> > > >> >>>> start
> > >>> > > > >> > > >> >>>> >>>> in on hooking up x-walk's webview I think
> it
> > will
> > >>> > > > >> > > >> >>>> >>>> become more
> > >>> > > > >> > > >> obvious
> > >>> > > > >> > > >> >>>> what
> > >>> > > > >> > > >> >>>> >>>> the interface should look like. E.g., does
> > x-walk
> > >>> > > > >> > > >> >>>> >>>> even have the
> > >>> > > > >> > > >> >>>> concept of
> > >>> > > > >> > > >> >>>> >>>> ChromeClient vs WebViewClient vs WebView?
> > Also
> > >>> > > > >> > > >> >>>> >>>> unsure whether the
> > >>> > > > >> > > >> >>>> class
> > >>> > > > >> > > >> >>>> >>>> should extend android.View as well as
> > implement
> > >>> > > > >> > > >> >>>> >>>> our
> > >>> > > > >> > interface.
> > >>> > > > >> > > >> E.g.
> > >>> > > > >> > > >> >>>> >>>> alternative is to have a "getView()" method
> > on
> > >>> the
> > >>> > > > >> > interface.
> > >>> > > > >> > > >> Might
> > >>> > > > >> > > >> >>>> help
> > >>> > > > >> > > >> >>>> >>>> to
> > >>> > > > >> > > >> >>>> >>>> cut down on file sizes, and API surface,
> but
> > >>> > > > >> > > >> >>>> >>>> again, I'm not too
> > >>> > > > >> > > >> sure.
> > >>> > > > >> > > >> >>>> >>>>
> > >>> > > > >> > > >> >>>> >>>> I've been pretty hesitant to touch existing
> > >>> > > > >> > > >> >>>> >>>> exposed members
> > >>> > > > >> > > >> (e.g. the
> > >>> > > > >> > > >> >>>> >>>> public fields you were referring to) since
> > >>> > > > >> > > >> >>>> >>>> touching anything
> > >>> > > > >> > > >> public
> > >>> > > > >> > > >> >>>> could
> > >>> > > > >> > > >> >>>> >>>> break plugins. That said, maybe now is a
> good
> > >>> time
> > >>> > > > >> > > >> >>>> >>>> to @deprecate
> > >>> > > > >> > > >> a
> > >>> > > > >> > > >> >>>> bunch
> > >>> > > > >> > > >> >>>> >>>> of
> > >>> > > > >> > > >> >>>> >>>> them and either replace them with getters,
> or
> > >>> just
> > >>> > > > >> > > >> >>>> >>>> declare them
> > >>> > > > >> > > >> to be
> > >>> > > > >> > > >> >>>> not
> > >>> > > > >> > > >> >>>> >>>> exposed to plugins.
> > >>> > > > >> > > >> >>>> >>>>
> > >>> > > > >> > > >> >>>> >>>>
> > >>> > > > >> > > >> >>>> >>>> On Wed, Mar 5, 2014 at 6:57 PM, Joe Bowser
> > >>> > > > >> > > >> >>>> >>>> <bo...@gmail.com>
> > >>> > > > >> > > >> wrote:
> > >>> > > > >> > > >> >>>> >>>>
> > >>> > > > >> > > >> >>>> >>>> > So, after looking at the Crosswalk code
> > again,
> > >>> > > > >> > > >> >>>> >>>> > I've decided to
> > >>> > > > >> > > >> take
> > >>> > > > >> > > >> >>>> a
> > >>> > > > >> > > >> >>>> >>>> > quick stab at making things pluggable.  I
> > don't
> > >>> > > > >> > > >> >>>> >>>> > have a lot to
> > >>> > > > >> > > >> show
> > >>> > > > >> > > >> >>>> for
> > >>> > > > >> > > >> >>>> >>>> > it, but with the help of Eclipse (which
> is
> > why
> > >>> > > > >> > > >> >>>> >>>> > the generated interfaces look so screwed
> > up), I
> > >>> > > > >> > > >> >>>> >>>> > managed to create some
> > >>> > > > >> > > >> interfaces
> > >>> > > > >> > > >> >>>> so
> > >>> > > > >> > > >> >>>> >>>> > we can start shoehorning in other browser
> > >>> > renderers.
> > >>> > > > >> > > >> >>>> >>>> >
> > >>> > > > >> > > >> >>>> >>>> >
> > >>> > > > >> > > >>
> > >>> https://github.com/infil00p/cordova-android/tree/pluggable_w
> > >>> > > > >> > > >> eb
> > >>> > > > >> > > >> vie
> > >>> > > > >> > > >> w
> > >>> > > > >> > > >> >>>> >>>> >
> > >>> > > > >> > > >> >>>> >>>> > I'm going to probably start with
> Crosswalk,
> > >>> > > > >> > > >> >>>> >>>> > because it's
> > >>> > > > >> > > >> probably
> > >>> > > > >> > > >> >>>> the
> > >>> > > > >> > > >> >>>> >>>> > most mature primary candidate in the
> > Android
> > >>> > > > >> > > >> >>>> >>>> > Third-Party
> > >>> > > > >> > > >> WebView
> > >>> > > > >> > > >> >>>> >>>> > thing, and I'm pretty sure the GeckoView
> > will
> > >>> be
> > >>> > > > >> > > >> >>>> >>>> > happening
> > >>> > > > >> > > >> shortly
> > >>> > > > >> > > >> >>>> >>>> > after.
> > >>> > > > >> > > >> >>>> >>>> >
> > >>> > > > >> > > >> >>>> >>>> > I don't know how this would work w.r.t.
> > the CLI
> > >>> > > > >> > > >> >>>> >>>> > or our
> > >>> > > > >> > > >> workflow at
> > >>> > > > >> > > >> >>>> >>>> > all, but at the moment, I really just
> want
> > to
> > >>> at
> > >>> > > > >> > > >> >>>> >>>> > least start
> > >>> > > > >> > > >> to have
> > >>> > > > >> > > >> >>>> >>>> > some headway towards 4.x and PhoneGap
> day.
> > >>> > > > >> > > >> >>>> >>>> >
> > >>> > > > >> > > >> >>>> >>>> > What do people think of this so far? I'm
> > going
> > >>> > > > >> > > >> >>>> >>>> > to try to clean
> > >>> > > > >> > > >> >>>> things
> > >>> > > > >> > > >> >>>> >>>> > up a bit, since we've definitely done a
> > lot of
> > >>> > > > >> > > >> >>>> >>>> > things that
> > >>> > > > >> > > >> would
> > >>> > > > >> > > >> >>>> make
> > >>> > > > >> > > >> >>>> >>>> > first year CS profs freak the hell out
> > (i.e.
> > >>> > > > >> > > >> >>>> >>>> > public members in
> > >>> > > > >> > > >> >>>> public
> > >>> > > > >> > > >> >>>> >>>> > objects w.r.t. PluginManager).
> > >>> > > > >> > > >> >>>> >>>> >
> > >>> > > > >> > > >> >>>> >>>> > Thoughts?
> > >>> > > > >> > > >> >>>> >>>> >
> > >>> > > > >> > > >> >>>> >>>> > Joe
> > >>> > > > >> > > >> >>>> >>>> >
> > >>> > > > >> > > >> >>>> >>>>
> > >>> > > > >> > > >> >>>> >>>
> > >>> > > > >> > > >> >>>> >>>
> > >>> > > > >> > > >> >>>>
> > >>> > > > >> > > >>
> > >>> > > > >> >
> > >>> >
> > >>>
> >
>

Re: [Android] Refactoring for different engines

[Brian LeRoux <b...@brian.io>]

Yup I'll track em down
On Apr 23, 2014 7:17 AM, "Andrew Grieve" <ag...@chromium.org> wrote:

> Does anyone have a contact at moz that we could invite?
>
> On Wed, Apr 23, 2014 at 10:09 AM, Andrew Grieve <ag...@chromium.org>
> wrote:
> > Depends on their interest level I think. Faster we can get this out
> > the door the better. If we need to delay for geckoview, then I don't
> > think we should gate on it, just release it after.
> >
> > On Wed, Apr 23, 2014 at 3:01 AM, Tommy Williams <to...@devgeeks.org>
> wrote:
> >> More engines, more better...
> >> On 23 Apr 2014 16:32, "Joe Bowser" <bo...@gmail.com> wrote:
> >>
> >>> Hey
> >>>
> >>> A Hangout would have to happen on Friday at the earliest.  It'd be
> good if
> >>> we could get someone from Mozilla on the hangout as well.  I haven't
> gotten
> >>> MozillaView (GeckoView with Cordova methods) fully working yet.  For
> some
> >>> reason it's not rendering on the screen.
> >>>
> >>> Ideally it'd be cool to have at least two options when this feature
> finally
> >>> lands.
> >>>
> >>> What do other people think?
> >>>
> >>> Joe
> >>> On 22 Apr 2014 20:06, "Hu, Ningxin" <ni...@intel.com> wrote:
> >>>
> >>> > Joe,
> >>> >
> >>> > Thanks for your review and merge the PRs.
> >>> >
> >>> > To pluggable webview interest group:
> >>> > Are we OK to setup a hangout this week for initial introduction and
> >>> > discussion of next steps?
> >>> >
> >>> > Thanks,
> >>> > -ningxin
> >>> >
> >>> > > -----Original Message-----
> >>> > > From: Hu, Ningxin [mailto:ningxin.hu@intel.com]
> >>> > > Sent: Tuesday, April 22, 2014 4:04 PM
> >>> > > To: dev@cordova.apache.org
> >>> > > Subject: RE: [Android] Refactoring for different engines
> >>> > >
> >>> > > The PoC is great! Quite excited about the direction!
> >>> > >
> >>> > > I've sent a PR to update the cordova-crosswalk-engine to latest
> >>> crosswalk
> >>> > > embedding API. It works with xwalk_core_library at 6.35.124.0.
> >>> > >
> >>> > > I've also changed the CordovaWebView interface slightly (adding
> >>> > getView() API)
> >>> > > to allow XWalkCordovaWebView to composite a XWalkView instead of
> >>> > extending
> >>> > > it. It resolves some API naming issues for XWalkView case.
> >>> > >
> >>> > > Please review them at:
> >>> > > https://github.com/infil00p/cordova-crosswalk-engine/pull/3
> >>> > > https://github.com/infil00p/cordova-android/pull/2
> >>> > >
> >>> > > Thanks,
> >>> > > -ningxin
> >>> > >
> >>> > > > -----Original Message-----
> >>> > > > From: Joe Bowser [mailto:bowserj@gmail.com]
> >>> > > > Sent: Friday, April 11, 2014 12:45 AM
> >>> > > > To: dev
> >>> > > > Subject: Re: [Android] Refactoring for different engines
> >>> > > >
> >>> > > > Yeah, I'd be cool with setting up a hangout.  Everyone should
> take a
> >>> > > > look at the PoC, I've basically distilled it down to four or five
> >>> > > > classes so far, but with some work, we may be able to get it
> down to
> >>> > > > three.  Due to legacy, we're pretty stuck with the Android
> WebView
> >>> API
> >>> > calls,
> >>> > > but these can probably be modified.
> >>> > > >
> >>> > > > It'd be good to get Mozilla people on the call as well, since
> they
> >>> > > > have their WebView as well.
> >>> > > >
> >>> > > > On Thu, Apr 10, 2014 at 9:38 AM, Hu, Ningxin <
> ningxin.hu@intel.com>
> >>> > wrote:
> >>> > > > > Hangout would be a good idea.
> >>> > > > >
> >>> > > > > FYI, I will be off next week. How about the week after next?
> If it
> >>> > > > > works, please
> >>> > > > feel free to schedule one and count me in.
> >>> > > > >
> >>> > > > > Thanks,
> >>> > > > > -ningxin
> >>> > > > >
> >>> > > > >> -----Original Message-----
> >>> > > > >> From: mmocny@google.com [mailto:mmocny@google.com] On Behalf
> Of
> >>> > > > >> Michal Mocny
> >>> > > > >> Sent: Tuesday, April 08, 2014 11:39 PM
> >>> > > > >> To: dev
> >>> > > > >> Subject: Re: [Android] Refactoring for different engines
> >>> > > > >>
> >>> > > > >> Would it be alright to set up a Hangout some time to introduce
> >>> > everyone?
> >>> > > > >>
> >>> > > > >> Joe has been leading the effort here, but there are other
> cordova
> >>> > > > >> contributors for whom this is top priority.  It would be nice
> if
> >>> we
> >>> > > > >> could all meet to say hello and make sure we are all going in
> the
> >>> > > > >> right
> >>> > > > direction.
> >>> > > > >>
> >>> > > > >> Quite exciting!
> >>> > > > >>
> >>> > > > >> -Michal
> >>> > > > >>
> >>> > > > >>
> >>> > > > >> On Tue, Apr 8, 2014 at 10:56 AM, Hu, Ningxin <
> >>> ningxin.hu@intel.com>
> >>> > > wrote:
> >>> > > > >>
> >>> > > > >> > Joe, thanks for this. I am very excited.
> >>> > > > >> >
> >>> > > > >> > FYI. Crosswalk team is working on refactoring the WebView
> API to
> >>> > > > >> > support embedding usage better [1]. (Previously the layer
> API
> >>> was
> >>> > > > >> > not exposed as public usage).
> >>> > > > >> >
> >>> > > > >> > I would like to review the PoC and work with you to get
> >>> Crosswalk
> >>> > > > >> > fits into the pluggable WebView architecture.
> >>> > > > >> >
> >>> > > > >> > Thanks,
> >>> > > > >> > -ningxin
> >>> > > > >> >
> >>> > > > >> > > -----Original Message-----
> >>> > > > >> > > From: Joe Bowser [mailto:bowserj@gmail.com]
> >>> > > > >> > > Sent: Wednesday, March 19, 2014 7:08 AM
> >>> > > > >> > > To: dev
> >>> > > > >> > > Subject: Re: [Android] Refactoring for different engines
> >>> > > > >> > >
> >>> > > > >> > > Hey
> >>> > > > >> > >
> >>> > > > >> > > After debugging, I did some minor updates to the plugin
> >>> README.
> >>> > > > >> > > It
> >>> > > > >> > should be
> >>> > > > >> > > easier to get this up and running, although there's still
> the
> >>> > > > >> > > issue of
> >>> > > > >> > after-install
> >>> > > > >> > > hooks and the relative path weirdness with the Crosswalk
> >>> > Library itself.
> >>> > > > >> > >
> >>> > > > >> > > It still doesn't support the CLI at all, but it should be
> >>> there
> >>> > > > >> > > with the
> >>> > > > >> > old flow.
> >>> > > > >> > >
> >>> > > > >> > > On Mon, Mar 17, 2014 at 1:14 PM, Michal Mocny
> >>> > > > >> > > <mm...@chromium.org>
> >>> > > > >> > > wrote:
> >>> > > > >> > > > (Sorry Joe, Googlers are down in California and way
> busy.
> >>> > > > >> > > > Will be back in a week.  Super excited about this,
> though.)
> >>> > > > >> > > >
> >>> > > > >> > > > -Michal
> >>> > > > >> > > >
> >>> > > > >> > > >
> >>> > > > >> > > > On Mon, Mar 17, 2014 at 2:53 PM, Joe Bowser
> >>> > > > >> > > > <bo...@gmail.com>
> >>> > > > >> wrote:
> >>> > > > >> > > >
> >>> > > > >> > > >> Reviving this thread!
> >>> > > > >> > > >>
> >>> > > > >> > > >> Can other people look at this, and see if/when we
> should
> >>> > land this?
> >>> > > > >> > > >> I know that I have to re-write the tests still, but I
> would
> >>> > > > >> > > >> like some feedback before merging it in.  Also, it'd be
> >>> > > > >> > > >> super awesome if other people could try and make a
> WebView
> >>> > > > >> > > >> based on the interfaces and recommend which methods
> should
> >>> > > > >> > > >> die.  I want to get this released in the next month or
> so,
> >>> > > > >> > > >> so any time and feedback would be greatly appreciated.
> >>> > > > >> > > >>
> >>> > > > >> > > >> Thanks
> >>> > > > >> > > >>
> >>> > > > >> > > >> On Thu, Mar 13, 2014 at 3:50 PM, Joe Bowser
> >>> > > > >> > > >> <bo...@gmail.com>
> >>> > > > >> > wrote:
> >>> > > > >> > > >> > Hey, I created the following today to track various
> >>> > > > >> > > >> > WebView
> >>> > > > >> > progresses:
> >>> > > > >> > > >> > https://issues.apache.org/jira/browse/CB-6246
> >>> > > > >> > > >> >
> >>> > > > >> > > >> > I also have this repo created.  The licensing is
> ugly as
> >>> > > > >> > > >> > all crap, but it's a Proof-Of-Concept:
> >>> > > > >> > > >> > https://github.com/infil00p/cordova-crosswalk-engine
> >>> > > > >> > > >> >
> >>> > > > >> > > >> > If I can get some help getting plugman to just load
> >>> > > > >> > > >> > Crosswalk, it'll
> >>> > > > >> > > >> look hawt.
> >>> > > > >> > > >> >
> >>> > > > >> > > >> > BTW: We should probably get this ready to go into
> Android
> >>> > > > >> > > >> > in the next two months and deprecate the setProperty
> >>> > > > >> > > >> > methods, since all properties should be preferences
> in
> >>> > config.xml
> >>> > > now.
> >>> > > > >> > > >> >
> >>> > > > >> > > >> > On Mon, Mar 10, 2014 at 2:42 PM, Joe Bowser
> >>> > > > >> > > >> > <bo...@gmail.com>
> >>> > > > >> > > wrote:
> >>> > > > >> > > >> >> Perhaps. There would be additional benefits to this
> >>> > > > >> > > >> >> approach, namely fixes being added to that platform
> more
> >>> > > > >> > > >> >> quickly.  I'll probably take a look at that once I
> have
> >>> > > > >> > > >> >> Crosswalk
> >>> > > > finalized.
> >>> > > > >> > > >> >>
> >>> > > > >> > > >> >> On Mon, Mar 10, 2014 at 9:49 AM, Brian LeRoux
> >>> > > > >> > > >> >> <b...@brian.io>
> >>> > > > wrote:
> >>> > > > >> > > >> >>> this is great stuff
> >>> > > > >> > > >> >>>
> >>> > > > >> > > >> >>> do we think it may be possible to bring in amazon
> >>> fireos
> >>> > > > >> > > >> >>> stuff
> >>> > > > >> > > >> eventually
> >>> > > > >> > > >> >>> too?
> >>> > > > >> > > >> >>>
> >>> > > > >> > > >> >>>
> >>> > > > >> > > >> >>> On Fri, Mar 7, 2014 at 3:22 PM, Joe Bowser
> >>> > > > >> > > >> >>> <bo...@gmail.com>
> >>> > > > >> > wrote:
> >>> > > > >> > > >> >>>
> >>> > > > >> > > >> >>>> BTW: I committed it in my repo, not the main
> Apache
> >>> one.
> >>> > > > >> > > >> >>>>
> >>> > > > >> > > >> >>>> On Fri, Mar 7, 2014 at 3:21 PM, Joe Bowser
> >>> > > > >> > > >> >>>> <bo...@gmail.com>
> >>> > > > >> > > wrote:
> >>> > > > >> > > >> >>>> > Hey
> >>> > > > >> > > >> >>>> >
> >>> > > > >> > > >> >>>> > I just committed some code based on their
> WebView
> >>> > > > >> > > >> >>>> > modifications that allows you to choose your
> >>> renderer
> >>> > > > >> > > >> >>>> > in the
> >>> > > > >> > config file
> >>> > > > >> > > with this:
> >>> > > > >> > > >> >>>> >
> >>> > > > >> > > >> >>>> >     <preference name="webView"
> >>> > > > >> > > >> >>>> >
> >>> value="org.apache.cordova.engine.crosswalk.XWalkCordo
> >>> > > > >> > > >> >>>> > va
> >>> > > > >> > > >> >>>> > Web
> >>> > > > >> > > >> >>>> > View
> >>> > > > >> > > >> >>>> > " />
> >>> > > > >> > > >> >>>> >
> >>> > > > >> > > >> >>>> > You currently have to copy over the *.pak file
> and
> >>> > > > >> > > >> >>>> > the jsapi from a Crosswalk Example project to
> get
> >>> > > > >> > > >> >>>> > this to work.  The next thing that I'm going to
> do
> >>> is
> >>> > > > >> > > >> >>>> > figure out how to write this as a plugin and
> have it
> >>> > > > >> > > >> >>>> > install on a default
> >>> > > > project.
> >>> > > > >> > > >> >>>> > Also, right now the bridge doesn't seem to
> work, and
> >>> > > > >> > > >> >>>> > I don't know why exactly.  That being said, the
> >>> > > > >> > > >> fact
> >>> > > > >> > > >> >>>> > that I can choose which version of
> Chrome/Chromium
> >>> > > > >> > > >> >>>> > I'm running with
> >>> > > > >> > > >> a
> >>> > > > >> > > >> >>>> > single XML preference is HUGE.
> >>> > > > >> > > >> >>>> >
> >>> > > > >> > > >> >>>> > There's definitely a lot more work that needs
> to be
> >>> > > > >> > > >> >>>> > done, but as
> >>> > > > >> > > >> long
> >>> > > > >> > > >> >>>> > as we have something that we can fit into the
> >>> > > > >> > > >> >>>> > interface, we should
> >>> > > > >> > > >> be
> >>> > > > >> > > >> >>>> > able to put in things like GeckoView or other
> third
> >>> > > > >> > > >> >>>> > party
> >>> > > > >> > renderers.
> >>> > > > >> > > >> >>>> > The nightmare of being stuck with bullshit
> WebView
> >>> > > > >> > > >> >>>> > bugs may soon be over.
> >>> > > > >> > > >> >>>> >
> >>> > > > >> > > >> >>>> > On Wed, Mar 5, 2014 at 8:59 PM, Michal Mocny
> >>> > > > >> > > >> >>>> > <mm...@chromium.org>
> >>> > > > >> > > >> >>>> wrote:
> >>> > > > >> > > >> >>>> >>
> >>> https://github.com/crosswalk-project/crosswalk-cordo
> >>> > > > >> > > >> >>>> >> va
> >>> > > > >> > > >> >>>> >> -an
> >>> > > > >> > > >> >>>> >> droi
> >>> > > > >> > > >> >>>> >> d
> >>> > > > >> > > >> >>>> >>
> >>> > > > >> > > >> >>>> >> First patch they landed, which claims to have
> min
> >>> > > > >> > > >> >>>> >> viable xwalk
> >>> > > > >> > > >> webview:
> >>> > > > >> > > >> >>>> >>
> >>> > > > >> > > >> >>>>
> >>> > > > >> > > >>
> >>> https://github.com/crosswalk-project/crosswalk-cordova-andro
> >>> > > > >> > > >> id
> >>> > > > >> > > >> /co
> >>> > > > >> > > >> mmit
> >>> > > > >> > > >> /a04dedeb0204e7542d190312c6ae70c795a26e04
> >>> > > > >> > > >> >>>> >>
> >>> > > > >> > > >> >>>> >>
> >>> > > > >> > > >> >>>> >> On Wed, Mar 5, 2014 at 11:37 PM, Michal Mocny
> >>> > > > >> > > >> >>>> >> <mmocny@chromium.org
> >>> > > > >> > > >> >
> >>> > > > >> > > >> >>>> wrote:
> >>> > > > >> > > >> >>>> >>
> >>> > > > >> > > >> >>>> >>> I haven't looked yet, but did you see:
> >>> > > > >> > > >> >>>> >>>
> >>> https://crosswalk-project.org/#wiki/crosswalk-cordo
> >>> > > > >> > > >> >>>> >>> va
> >>> > > > >> > > >> >>>> >>> -an
> >>> > > > >> > > >> >>>> >>> droi
> >>> > > > >> > > >> >>>> >>> d
> >>> > > > >> > > >> >>>> >>>
> >>> > > > >> > > >> >>>> >>> ?
> >>> > > > >> > > >> >>>> >>>
> >>> > > > >> > > >> >>>> >>>
> >>> > > > >> > > >> >>>> >>> On Wed, Mar 5, 2014 at 10:20 PM, Andrew
> Grieve <
> >>> > > > >> > > >> agrieve@chromium.org
> >>> > > > >> > > >> >>>> >wrote:
> >>> > > > >> > > >> >>>> >>>
> >>> > > > >> > > >> >>>> >>>> First - very excited that you're working on
> this!
> >>> > > > >> > > >> >>>> >>>>
> >>> > > > >> > > >> >>>> >>>> Had a quick look. Not sure there's much to be
> >>> > gleaned
> >>> > > yet.
> >>> > > > >> > > >> >>>> >>>> Once
> >>> > > > >> > > >> you
> >>> > > > >> > > >> >>>> start
> >>> > > > >> > > >> >>>> >>>> in on hooking up x-walk's webview I think it
> will
> >>> > > > >> > > >> >>>> >>>> become more
> >>> > > > >> > > >> obvious
> >>> > > > >> > > >> >>>> what
> >>> > > > >> > > >> >>>> >>>> the interface should look like. E.g., does
> x-walk
> >>> > > > >> > > >> >>>> >>>> even have the
> >>> > > > >> > > >> >>>> concept of
> >>> > > > >> > > >> >>>> >>>> ChromeClient vs WebViewClient vs WebView?
> Also
> >>> > > > >> > > >> >>>> >>>> unsure whether the
> >>> > > > >> > > >> >>>> class
> >>> > > > >> > > >> >>>> >>>> should extend android.View as well as
> implement
> >>> > > > >> > > >> >>>> >>>> our
> >>> > > > >> > interface.
> >>> > > > >> > > >> E.g.
> >>> > > > >> > > >> >>>> >>>> alternative is to have a "getView()" method
> on
> >>> the
> >>> > > > >> > interface.
> >>> > > > >> > > >> Might
> >>> > > > >> > > >> >>>> help
> >>> > > > >> > > >> >>>> >>>> to
> >>> > > > >> > > >> >>>> >>>> cut down on file sizes, and API surface, but
> >>> > > > >> > > >> >>>> >>>> again, I'm not too
> >>> > > > >> > > >> sure.
> >>> > > > >> > > >> >>>> >>>>
> >>> > > > >> > > >> >>>> >>>> I've been pretty hesitant to touch existing
> >>> > > > >> > > >> >>>> >>>> exposed members
> >>> > > > >> > > >> (e.g. the
> >>> > > > >> > > >> >>>> >>>> public fields you were referring to) since
> >>> > > > >> > > >> >>>> >>>> touching anything
> >>> > > > >> > > >> public
> >>> > > > >> > > >> >>>> could
> >>> > > > >> > > >> >>>> >>>> break plugins. That said, maybe now is a good
> >>> time
> >>> > > > >> > > >> >>>> >>>> to @deprecate
> >>> > > > >> > > >> a
> >>> > > > >> > > >> >>>> bunch
> >>> > > > >> > > >> >>>> >>>> of
> >>> > > > >> > > >> >>>> >>>> them and either replace them with getters, or
> >>> just
> >>> > > > >> > > >> >>>> >>>> declare them
> >>> > > > >> > > >> to be
> >>> > > > >> > > >> >>>> not
> >>> > > > >> > > >> >>>> >>>> exposed to plugins.
> >>> > > > >> > > >> >>>> >>>>
> >>> > > > >> > > >> >>>> >>>>
> >>> > > > >> > > >> >>>> >>>> On Wed, Mar 5, 2014 at 6:57 PM, Joe Bowser
> >>> > > > >> > > >> >>>> >>>> <bo...@gmail.com>
> >>> > > > >> > > >> wrote:
> >>> > > > >> > > >> >>>> >>>>
> >>> > > > >> > > >> >>>> >>>> > So, after looking at the Crosswalk code
> again,
> >>> > > > >> > > >> >>>> >>>> > I've decided to
> >>> > > > >> > > >> take
> >>> > > > >> > > >> >>>> a
> >>> > > > >> > > >> >>>> >>>> > quick stab at making things pluggable.  I
> don't
> >>> > > > >> > > >> >>>> >>>> > have a lot to
> >>> > > > >> > > >> show
> >>> > > > >> > > >> >>>> for
> >>> > > > >> > > >> >>>> >>>> > it, but with the help of Eclipse (which is
> why
> >>> > > > >> > > >> >>>> >>>> > the generated interfaces look so screwed
> up), I
> >>> > > > >> > > >> >>>> >>>> > managed to create some
> >>> > > > >> > > >> interfaces
> >>> > > > >> > > >> >>>> so
> >>> > > > >> > > >> >>>> >>>> > we can start shoehorning in other browser
> >>> > renderers.
> >>> > > > >> > > >> >>>> >>>> >
> >>> > > > >> > > >> >>>> >>>> >
> >>> > > > >> > > >>
> >>> https://github.com/infil00p/cordova-android/tree/pluggable_w
> >>> > > > >> > > >> eb
> >>> > > > >> > > >> vie
> >>> > > > >> > > >> w
> >>> > > > >> > > >> >>>> >>>> >
> >>> > > > >> > > >> >>>> >>>> > I'm going to probably start with Crosswalk,
> >>> > > > >> > > >> >>>> >>>> > because it's
> >>> > > > >> > > >> probably
> >>> > > > >> > > >> >>>> the
> >>> > > > >> > > >> >>>> >>>> > most mature primary candidate in the
> Android
> >>> > > > >> > > >> >>>> >>>> > Third-Party
> >>> > > > >> > > >> WebView
> >>> > > > >> > > >> >>>> >>>> > thing, and I'm pretty sure the GeckoView
> will
> >>> be
> >>> > > > >> > > >> >>>> >>>> > happening
> >>> > > > >> > > >> shortly
> >>> > > > >> > > >> >>>> >>>> > after.
> >>> > > > >> > > >> >>>> >>>> >
> >>> > > > >> > > >> >>>> >>>> > I don't know how this would work w.r.t.
> the CLI
> >>> > > > >> > > >> >>>> >>>> > or our
> >>> > > > >> > > >> workflow at
> >>> > > > >> > > >> >>>> >>>> > all, but at the moment, I really just want
> to
> >>> at
> >>> > > > >> > > >> >>>> >>>> > least start
> >>> > > > >> > > >> to have
> >>> > > > >> > > >> >>>> >>>> > some headway towards 4.x and PhoneGap day.
> >>> > > > >> > > >> >>>> >>>> >
> >>> > > > >> > > >> >>>> >>>> > What do people think of this so far? I'm
> going
> >>> > > > >> > > >> >>>> >>>> > to try to clean
> >>> > > > >> > > >> >>>> things
> >>> > > > >> > > >> >>>> >>>> > up a bit, since we've definitely done a
> lot of
> >>> > > > >> > > >> >>>> >>>> > things that
> >>> > > > >> > > >> would
> >>> > > > >> > > >> >>>> make
> >>> > > > >> > > >> >>>> >>>> > first year CS profs freak the hell out
> (i.e.
> >>> > > > >> > > >> >>>> >>>> > public members in
> >>> > > > >> > > >> >>>> public
> >>> > > > >> > > >> >>>> >>>> > objects w.r.t. PluginManager).
> >>> > > > >> > > >> >>>> >>>> >
> >>> > > > >> > > >> >>>> >>>> > Thoughts?
> >>> > > > >> > > >> >>>> >>>> >
> >>> > > > >> > > >> >>>> >>>> > Joe
> >>> > > > >> > > >> >>>> >>>> >
> >>> > > > >> > > >> >>>> >>>>
> >>> > > > >> > > >> >>>> >>>
> >>> > > > >> > > >> >>>> >>>
> >>> > > > >> > > >> >>>>
> >>> > > > >> > > >>
> >>> > > > >> >
> >>> >
> >>>
>

Re: [Android] Refactoring for different engines

[Andrew Grieve <ag...@chromium.org>]

Does anyone have a contact at moz that we could invite?

On Wed, Apr 23, 2014 at 10:09 AM, Andrew Grieve <ag...@chromium.org> wrote:
> Depends on their interest level I think. Faster we can get this out
> the door the better. If we need to delay for geckoview, then I don't
> think we should gate on it, just release it after.
>
> On Wed, Apr 23, 2014 at 3:01 AM, Tommy Williams <to...@devgeeks.org> wrote:
>> More engines, more better...
>> On 23 Apr 2014 16:32, "Joe Bowser" <bo...@gmail.com> wrote:
>>
>>> Hey
>>>
>>> A Hangout would have to happen on Friday at the earliest.  It'd be good if
>>> we could get someone from Mozilla on the hangout as well.  I haven't gotten
>>> MozillaView (GeckoView with Cordova methods) fully working yet.  For some
>>> reason it's not rendering on the screen.
>>>
>>> Ideally it'd be cool to have at least two options when this feature finally
>>> lands.
>>>
>>> What do other people think?
>>>
>>> Joe
>>> On 22 Apr 2014 20:06, "Hu, Ningxin" <ni...@intel.com> wrote:
>>>
>>> > Joe,
>>> >
>>> > Thanks for your review and merge the PRs.
>>> >
>>> > To pluggable webview interest group:
>>> > Are we OK to setup a hangout this week for initial introduction and
>>> > discussion of next steps?
>>> >
>>> > Thanks,
>>> > -ningxin
>>> >
>>> > > -----Original Message-----
>>> > > From: Hu, Ningxin [mailto:ningxin.hu@intel.com]
>>> > > Sent: Tuesday, April 22, 2014 4:04 PM
>>> > > To: dev@cordova.apache.org
>>> > > Subject: RE: [Android] Refactoring for different engines
>>> > >
>>> > > The PoC is great! Quite excited about the direction!
>>> > >
>>> > > I've sent a PR to update the cordova-crosswalk-engine to latest
>>> crosswalk
>>> > > embedding API. It works with xwalk_core_library at 6.35.124.0.
>>> > >
>>> > > I've also changed the CordovaWebView interface slightly (adding
>>> > getView() API)
>>> > > to allow XWalkCordovaWebView to composite a XWalkView instead of
>>> > extending
>>> > > it. It resolves some API naming issues for XWalkView case.
>>> > >
>>> > > Please review them at:
>>> > > https://github.com/infil00p/cordova-crosswalk-engine/pull/3
>>> > > https://github.com/infil00p/cordova-android/pull/2
>>> > >
>>> > > Thanks,
>>> > > -ningxin
>>> > >
>>> > > > -----Original Message-----
>>> > > > From: Joe Bowser [mailto:bowserj@gmail.com]
>>> > > > Sent: Friday, April 11, 2014 12:45 AM
>>> > > > To: dev
>>> > > > Subject: Re: [Android] Refactoring for different engines
>>> > > >
>>> > > > Yeah, I'd be cool with setting up a hangout.  Everyone should take a
>>> > > > look at the PoC, I've basically distilled it down to four or five
>>> > > > classes so far, but with some work, we may be able to get it down to
>>> > > > three.  Due to legacy, we're pretty stuck with the Android WebView
>>> API
>>> > calls,
>>> > > but these can probably be modified.
>>> > > >
>>> > > > It'd be good to get Mozilla people on the call as well, since they
>>> > > > have their WebView as well.
>>> > > >
>>> > > > On Thu, Apr 10, 2014 at 9:38 AM, Hu, Ningxin <ni...@intel.com>
>>> > wrote:
>>> > > > > Hangout would be a good idea.
>>> > > > >
>>> > > > > FYI, I will be off next week. How about the week after next? If it
>>> > > > > works, please
>>> > > > feel free to schedule one and count me in.
>>> > > > >
>>> > > > > Thanks,
>>> > > > > -ningxin
>>> > > > >
>>> > > > >> -----Original Message-----
>>> > > > >> From: mmocny@google.com [mailto:mmocny@google.com] On Behalf Of
>>> > > > >> Michal Mocny
>>> > > > >> Sent: Tuesday, April 08, 2014 11:39 PM
>>> > > > >> To: dev
>>> > > > >> Subject: Re: [Android] Refactoring for different engines
>>> > > > >>
>>> > > > >> Would it be alright to set up a Hangout some time to introduce
>>> > everyone?
>>> > > > >>
>>> > > > >> Joe has been leading the effort here, but there are other cordova
>>> > > > >> contributors for whom this is top priority.  It would be nice if
>>> we
>>> > > > >> could all meet to say hello and make sure we are all going in the
>>> > > > >> right
>>> > > > direction.
>>> > > > >>
>>> > > > >> Quite exciting!
>>> > > > >>
>>> > > > >> -Michal
>>> > > > >>
>>> > > > >>
>>> > > > >> On Tue, Apr 8, 2014 at 10:56 AM, Hu, Ningxin <
>>> ningxin.hu@intel.com>
>>> > > wrote:
>>> > > > >>
>>> > > > >> > Joe, thanks for this. I am very excited.
>>> > > > >> >
>>> > > > >> > FYI. Crosswalk team is working on refactoring the WebView API to
>>> > > > >> > support embedding usage better [1]. (Previously the layer API
>>> was
>>> > > > >> > not exposed as public usage).
>>> > > > >> >
>>> > > > >> > I would like to review the PoC and work with you to get
>>> Crosswalk
>>> > > > >> > fits into the pluggable WebView architecture.
>>> > > > >> >
>>> > > > >> > Thanks,
>>> > > > >> > -ningxin
>>> > > > >> >
>>> > > > >> > > -----Original Message-----
>>> > > > >> > > From: Joe Bowser [mailto:bowserj@gmail.com]
>>> > > > >> > > Sent: Wednesday, March 19, 2014 7:08 AM
>>> > > > >> > > To: dev
>>> > > > >> > > Subject: Re: [Android] Refactoring for different engines
>>> > > > >> > >
>>> > > > >> > > Hey
>>> > > > >> > >
>>> > > > >> > > After debugging, I did some minor updates to the plugin
>>> README.
>>> > > > >> > > It
>>> > > > >> > should be
>>> > > > >> > > easier to get this up and running, although there's still the
>>> > > > >> > > issue of
>>> > > > >> > after-install
>>> > > > >> > > hooks and the relative path weirdness with the Crosswalk
>>> > Library itself.
>>> > > > >> > >
>>> > > > >> > > It still doesn't support the CLI at all, but it should be
>>> there
>>> > > > >> > > with the
>>> > > > >> > old flow.
>>> > > > >> > >
>>> > > > >> > > On Mon, Mar 17, 2014 at 1:14 PM, Michal Mocny
>>> > > > >> > > <mm...@chromium.org>
>>> > > > >> > > wrote:
>>> > > > >> > > > (Sorry Joe, Googlers are down in California and way busy.
>>> > > > >> > > > Will be back in a week.  Super excited about this, though.)
>>> > > > >> > > >
>>> > > > >> > > > -Michal
>>> > > > >> > > >
>>> > > > >> > > >
>>> > > > >> > > > On Mon, Mar 17, 2014 at 2:53 PM, Joe Bowser
>>> > > > >> > > > <bo...@gmail.com>
>>> > > > >> wrote:
>>> > > > >> > > >
>>> > > > >> > > >> Reviving this thread!
>>> > > > >> > > >>
>>> > > > >> > > >> Can other people look at this, and see if/when we should
>>> > land this?
>>> > > > >> > > >> I know that I have to re-write the tests still, but I would
>>> > > > >> > > >> like some feedback before merging it in.  Also, it'd be
>>> > > > >> > > >> super awesome if other people could try and make a WebView
>>> > > > >> > > >> based on the interfaces and recommend which methods should
>>> > > > >> > > >> die.  I want to get this released in the next month or so,
>>> > > > >> > > >> so any time and feedback would be greatly appreciated.
>>> > > > >> > > >>
>>> > > > >> > > >> Thanks
>>> > > > >> > > >>
>>> > > > >> > > >> On Thu, Mar 13, 2014 at 3:50 PM, Joe Bowser
>>> > > > >> > > >> <bo...@gmail.com>
>>> > > > >> > wrote:
>>> > > > >> > > >> > Hey, I created the following today to track various
>>> > > > >> > > >> > WebView
>>> > > > >> > progresses:
>>> > > > >> > > >> > https://issues.apache.org/jira/browse/CB-6246
>>> > > > >> > > >> >
>>> > > > >> > > >> > I also have this repo created.  The licensing is ugly as
>>> > > > >> > > >> > all crap, but it's a Proof-Of-Concept:
>>> > > > >> > > >> > https://github.com/infil00p/cordova-crosswalk-engine
>>> > > > >> > > >> >
>>> > > > >> > > >> > If I can get some help getting plugman to just load
>>> > > > >> > > >> > Crosswalk, it'll
>>> > > > >> > > >> look hawt.
>>> > > > >> > > >> >
>>> > > > >> > > >> > BTW: We should probably get this ready to go into Android
>>> > > > >> > > >> > in the next two months and deprecate the setProperty
>>> > > > >> > > >> > methods, since all properties should be preferences in
>>> > config.xml
>>> > > now.
>>> > > > >> > > >> >
>>> > > > >> > > >> > On Mon, Mar 10, 2014 at 2:42 PM, Joe Bowser
>>> > > > >> > > >> > <bo...@gmail.com>
>>> > > > >> > > wrote:
>>> > > > >> > > >> >> Perhaps. There would be additional benefits to this
>>> > > > >> > > >> >> approach, namely fixes being added to that platform more
>>> > > > >> > > >> >> quickly.  I'll probably take a look at that once I have
>>> > > > >> > > >> >> Crosswalk
>>> > > > finalized.
>>> > > > >> > > >> >>
>>> > > > >> > > >> >> On Mon, Mar 10, 2014 at 9:49 AM, Brian LeRoux
>>> > > > >> > > >> >> <b...@brian.io>
>>> > > > wrote:
>>> > > > >> > > >> >>> this is great stuff
>>> > > > >> > > >> >>>
>>> > > > >> > > >> >>> do we think it may be possible to bring in amazon
>>> fireos
>>> > > > >> > > >> >>> stuff
>>> > > > >> > > >> eventually
>>> > > > >> > > >> >>> too?
>>> > > > >> > > >> >>>
>>> > > > >> > > >> >>>
>>> > > > >> > > >> >>> On Fri, Mar 7, 2014 at 3:22 PM, Joe Bowser
>>> > > > >> > > >> >>> <bo...@gmail.com>
>>> > > > >> > wrote:
>>> > > > >> > > >> >>>
>>> > > > >> > > >> >>>> BTW: I committed it in my repo, not the main Apache
>>> one.
>>> > > > >> > > >> >>>>
>>> > > > >> > > >> >>>> On Fri, Mar 7, 2014 at 3:21 PM, Joe Bowser
>>> > > > >> > > >> >>>> <bo...@gmail.com>
>>> > > > >> > > wrote:
>>> > > > >> > > >> >>>> > Hey
>>> > > > >> > > >> >>>> >
>>> > > > >> > > >> >>>> > I just committed some code based on their WebView
>>> > > > >> > > >> >>>> > modifications that allows you to choose your
>>> renderer
>>> > > > >> > > >> >>>> > in the
>>> > > > >> > config file
>>> > > > >> > > with this:
>>> > > > >> > > >> >>>> >
>>> > > > >> > > >> >>>> >     <preference name="webView"
>>> > > > >> > > >> >>>> >
>>> value="org.apache.cordova.engine.crosswalk.XWalkCordo
>>> > > > >> > > >> >>>> > va
>>> > > > >> > > >> >>>> > Web
>>> > > > >> > > >> >>>> > View
>>> > > > >> > > >> >>>> > " />
>>> > > > >> > > >> >>>> >
>>> > > > >> > > >> >>>> > You currently have to copy over the *.pak file and
>>> > > > >> > > >> >>>> > the jsapi from a Crosswalk Example project to get
>>> > > > >> > > >> >>>> > this to work.  The next thing that I'm going to do
>>> is
>>> > > > >> > > >> >>>> > figure out how to write this as a plugin and have it
>>> > > > >> > > >> >>>> > install on a default
>>> > > > project.
>>> > > > >> > > >> >>>> > Also, right now the bridge doesn't seem to work, and
>>> > > > >> > > >> >>>> > I don't know why exactly.  That being said, the
>>> > > > >> > > >> fact
>>> > > > >> > > >> >>>> > that I can choose which version of Chrome/Chromium
>>> > > > >> > > >> >>>> > I'm running with
>>> > > > >> > > >> a
>>> > > > >> > > >> >>>> > single XML preference is HUGE.
>>> > > > >> > > >> >>>> >
>>> > > > >> > > >> >>>> > There's definitely a lot more work that needs to be
>>> > > > >> > > >> >>>> > done, but as
>>> > > > >> > > >> long
>>> > > > >> > > >> >>>> > as we have something that we can fit into the
>>> > > > >> > > >> >>>> > interface, we should
>>> > > > >> > > >> be
>>> > > > >> > > >> >>>> > able to put in things like GeckoView or other third
>>> > > > >> > > >> >>>> > party
>>> > > > >> > renderers.
>>> > > > >> > > >> >>>> > The nightmare of being stuck with bullshit WebView
>>> > > > >> > > >> >>>> > bugs may soon be over.
>>> > > > >> > > >> >>>> >
>>> > > > >> > > >> >>>> > On Wed, Mar 5, 2014 at 8:59 PM, Michal Mocny
>>> > > > >> > > >> >>>> > <mm...@chromium.org>
>>> > > > >> > > >> >>>> wrote:
>>> > > > >> > > >> >>>> >>
>>> https://github.com/crosswalk-project/crosswalk-cordo
>>> > > > >> > > >> >>>> >> va
>>> > > > >> > > >> >>>> >> -an
>>> > > > >> > > >> >>>> >> droi
>>> > > > >> > > >> >>>> >> d
>>> > > > >> > > >> >>>> >>
>>> > > > >> > > >> >>>> >> First patch they landed, which claims to have min
>>> > > > >> > > >> >>>> >> viable xwalk
>>> > > > >> > > >> webview:
>>> > > > >> > > >> >>>> >>
>>> > > > >> > > >> >>>>
>>> > > > >> > > >>
>>> https://github.com/crosswalk-project/crosswalk-cordova-andro
>>> > > > >> > > >> id
>>> > > > >> > > >> /co
>>> > > > >> > > >> mmit
>>> > > > >> > > >> /a04dedeb0204e7542d190312c6ae70c795a26e04
>>> > > > >> > > >> >>>> >>
>>> > > > >> > > >> >>>> >>
>>> > > > >> > > >> >>>> >> On Wed, Mar 5, 2014 at 11:37 PM, Michal Mocny
>>> > > > >> > > >> >>>> >> <mmocny@chromium.org
>>> > > > >> > > >> >
>>> > > > >> > > >> >>>> wrote:
>>> > > > >> > > >> >>>> >>
>>> > > > >> > > >> >>>> >>> I haven't looked yet, but did you see:
>>> > > > >> > > >> >>>> >>>
>>> https://crosswalk-project.org/#wiki/crosswalk-cordo
>>> > > > >> > > >> >>>> >>> va
>>> > > > >> > > >> >>>> >>> -an
>>> > > > >> > > >> >>>> >>> droi
>>> > > > >> > > >> >>>> >>> d
>>> > > > >> > > >> >>>> >>>
>>> > > > >> > > >> >>>> >>> ?
>>> > > > >> > > >> >>>> >>>
>>> > > > >> > > >> >>>> >>>
>>> > > > >> > > >> >>>> >>> On Wed, Mar 5, 2014 at 10:20 PM, Andrew Grieve <
>>> > > > >> > > >> agrieve@chromium.org
>>> > > > >> > > >> >>>> >wrote:
>>> > > > >> > > >> >>>> >>>
>>> > > > >> > > >> >>>> >>>> First - very excited that you're working on this!
>>> > > > >> > > >> >>>> >>>>
>>> > > > >> > > >> >>>> >>>> Had a quick look. Not sure there's much to be
>>> > gleaned
>>> > > yet.
>>> > > > >> > > >> >>>> >>>> Once
>>> > > > >> > > >> you
>>> > > > >> > > >> >>>> start
>>> > > > >> > > >> >>>> >>>> in on hooking up x-walk's webview I think it will
>>> > > > >> > > >> >>>> >>>> become more
>>> > > > >> > > >> obvious
>>> > > > >> > > >> >>>> what
>>> > > > >> > > >> >>>> >>>> the interface should look like. E.g., does x-walk
>>> > > > >> > > >> >>>> >>>> even have the
>>> > > > >> > > >> >>>> concept of
>>> > > > >> > > >> >>>> >>>> ChromeClient vs WebViewClient vs WebView? Also
>>> > > > >> > > >> >>>> >>>> unsure whether the
>>> > > > >> > > >> >>>> class
>>> > > > >> > > >> >>>> >>>> should extend android.View as well as implement
>>> > > > >> > > >> >>>> >>>> our
>>> > > > >> > interface.
>>> > > > >> > > >> E.g.
>>> > > > >> > > >> >>>> >>>> alternative is to have a "getView()" method on
>>> the
>>> > > > >> > interface.
>>> > > > >> > > >> Might
>>> > > > >> > > >> >>>> help
>>> > > > >> > > >> >>>> >>>> to
>>> > > > >> > > >> >>>> >>>> cut down on file sizes, and API surface, but
>>> > > > >> > > >> >>>> >>>> again, I'm not too
>>> > > > >> > > >> sure.
>>> > > > >> > > >> >>>> >>>>
>>> > > > >> > > >> >>>> >>>> I've been pretty hesitant to touch existing
>>> > > > >> > > >> >>>> >>>> exposed members
>>> > > > >> > > >> (e.g. the
>>> > > > >> > > >> >>>> >>>> public fields you were referring to) since
>>> > > > >> > > >> >>>> >>>> touching anything
>>> > > > >> > > >> public
>>> > > > >> > > >> >>>> could
>>> > > > >> > > >> >>>> >>>> break plugins. That said, maybe now is a good
>>> time
>>> > > > >> > > >> >>>> >>>> to @deprecate
>>> > > > >> > > >> a
>>> > > > >> > > >> >>>> bunch
>>> > > > >> > > >> >>>> >>>> of
>>> > > > >> > > >> >>>> >>>> them and either replace them with getters, or
>>> just
>>> > > > >> > > >> >>>> >>>> declare them
>>> > > > >> > > >> to be
>>> > > > >> > > >> >>>> not
>>> > > > >> > > >> >>>> >>>> exposed to plugins.
>>> > > > >> > > >> >>>> >>>>
>>> > > > >> > > >> >>>> >>>>
>>> > > > >> > > >> >>>> >>>> On Wed, Mar 5, 2014 at 6:57 PM, Joe Bowser
>>> > > > >> > > >> >>>> >>>> <bo...@gmail.com>
>>> > > > >> > > >> wrote:
>>> > > > >> > > >> >>>> >>>>
>>> > > > >> > > >> >>>> >>>> > So, after looking at the Crosswalk code again,
>>> > > > >> > > >> >>>> >>>> > I've decided to
>>> > > > >> > > >> take
>>> > > > >> > > >> >>>> a
>>> > > > >> > > >> >>>> >>>> > quick stab at making things pluggable.  I don't
>>> > > > >> > > >> >>>> >>>> > have a lot to
>>> > > > >> > > >> show
>>> > > > >> > > >> >>>> for
>>> > > > >> > > >> >>>> >>>> > it, but with the help of Eclipse (which is why
>>> > > > >> > > >> >>>> >>>> > the generated interfaces look so screwed up), I
>>> > > > >> > > >> >>>> >>>> > managed to create some
>>> > > > >> > > >> interfaces
>>> > > > >> > > >> >>>> so
>>> > > > >> > > >> >>>> >>>> > we can start shoehorning in other browser
>>> > renderers.
>>> > > > >> > > >> >>>> >>>> >
>>> > > > >> > > >> >>>> >>>> >
>>> > > > >> > > >>
>>> https://github.com/infil00p/cordova-android/tree/pluggable_w
>>> > > > >> > > >> eb
>>> > > > >> > > >> vie
>>> > > > >> > > >> w
>>> > > > >> > > >> >>>> >>>> >
>>> > > > >> > > >> >>>> >>>> > I'm going to probably start with Crosswalk,
>>> > > > >> > > >> >>>> >>>> > because it's
>>> > > > >> > > >> probably
>>> > > > >> > > >> >>>> the
>>> > > > >> > > >> >>>> >>>> > most mature primary candidate in the Android
>>> > > > >> > > >> >>>> >>>> > Third-Party
>>> > > > >> > > >> WebView
>>> > > > >> > > >> >>>> >>>> > thing, and I'm pretty sure the GeckoView will
>>> be
>>> > > > >> > > >> >>>> >>>> > happening
>>> > > > >> > > >> shortly
>>> > > > >> > > >> >>>> >>>> > after.
>>> > > > >> > > >> >>>> >>>> >
>>> > > > >> > > >> >>>> >>>> > I don't know how this would work w.r.t. the CLI
>>> > > > >> > > >> >>>> >>>> > or our
>>> > > > >> > > >> workflow at
>>> > > > >> > > >> >>>> >>>> > all, but at the moment, I really just want to
>>> at
>>> > > > >> > > >> >>>> >>>> > least start
>>> > > > >> > > >> to have
>>> > > > >> > > >> >>>> >>>> > some headway towards 4.x and PhoneGap day.
>>> > > > >> > > >> >>>> >>>> >
>>> > > > >> > > >> >>>> >>>> > What do people think of this so far? I'm going
>>> > > > >> > > >> >>>> >>>> > to try to clean
>>> > > > >> > > >> >>>> things
>>> > > > >> > > >> >>>> >>>> > up a bit, since we've definitely done a lot of
>>> > > > >> > > >> >>>> >>>> > things that
>>> > > > >> > > >> would
>>> > > > >> > > >> >>>> make
>>> > > > >> > > >> >>>> >>>> > first year CS profs freak the hell out (i.e.
>>> > > > >> > > >> >>>> >>>> > public members in
>>> > > > >> > > >> >>>> public
>>> > > > >> > > >> >>>> >>>> > objects w.r.t. PluginManager).
>>> > > > >> > > >> >>>> >>>> >
>>> > > > >> > > >> >>>> >>>> > Thoughts?
>>> > > > >> > > >> >>>> >>>> >
>>> > > > >> > > >> >>>> >>>> > Joe
>>> > > > >> > > >> >>>> >>>> >
>>> > > > >> > > >> >>>> >>>>
>>> > > > >> > > >> >>>> >>>
>>> > > > >> > > >> >>>> >>>
>>> > > > >> > > >> >>>>
>>> > > > >> > > >>
>>> > > > >> >
>>> >
>>>

Re: [Android] Refactoring for different engines

[Andrew Grieve <ag...@chromium.org>]

Depends on their interest level I think. Faster we can get this out
the door the better. If we need to delay for geckoview, then I don't
think we should gate on it, just release it after.

On Wed, Apr 23, 2014 at 3:01 AM, Tommy Williams <to...@devgeeks.org> wrote:
> More engines, more better...
> On 23 Apr 2014 16:32, "Joe Bowser" <bo...@gmail.com> wrote:
>
>> Hey
>>
>> A Hangout would have to happen on Friday at the earliest.  It'd be good if
>> we could get someone from Mozilla on the hangout as well.  I haven't gotten
>> MozillaView (GeckoView with Cordova methods) fully working yet.  For some
>> reason it's not rendering on the screen.
>>
>> Ideally it'd be cool to have at least two options when this feature finally
>> lands.
>>
>> What do other people think?
>>
>> Joe
>> On 22 Apr 2014 20:06, "Hu, Ningxin" <ni...@intel.com> wrote:
>>
>> > Joe,
>> >
>> > Thanks for your review and merge the PRs.
>> >
>> > To pluggable webview interest group:
>> > Are we OK to setup a hangout this week for initial introduction and
>> > discussion of next steps?
>> >
>> > Thanks,
>> > -ningxin
>> >
>> > > -----Original Message-----
>> > > From: Hu, Ningxin [mailto:ningxin.hu@intel.com]
>> > > Sent: Tuesday, April 22, 2014 4:04 PM
>> > > To: dev@cordova.apache.org
>> > > Subject: RE: [Android] Refactoring for different engines
>> > >
>> > > The PoC is great! Quite excited about the direction!
>> > >
>> > > I've sent a PR to update the cordova-crosswalk-engine to latest
>> crosswalk
>> > > embedding API. It works with xwalk_core_library at 6.35.124.0.
>> > >
>> > > I've also changed the CordovaWebView interface slightly (adding
>> > getView() API)
>> > > to allow XWalkCordovaWebView to composite a XWalkView instead of
>> > extending
>> > > it. It resolves some API naming issues for XWalkView case.
>> > >
>> > > Please review them at:
>> > > https://github.com/infil00p/cordova-crosswalk-engine/pull/3
>> > > https://github.com/infil00p/cordova-android/pull/2
>> > >
>> > > Thanks,
>> > > -ningxin
>> > >
>> > > > -----Original Message-----
>> > > > From: Joe Bowser [mailto:bowserj@gmail.com]
>> > > > Sent: Friday, April 11, 2014 12:45 AM
>> > > > To: dev
>> > > > Subject: Re: [Android] Refactoring for different engines
>> > > >
>> > > > Yeah, I'd be cool with setting up a hangout.  Everyone should take a
>> > > > look at the PoC, I've basically distilled it down to four or five
>> > > > classes so far, but with some work, we may be able to get it down to
>> > > > three.  Due to legacy, we're pretty stuck with the Android WebView
>> API
>> > calls,
>> > > but these can probably be modified.
>> > > >
>> > > > It'd be good to get Mozilla people on the call as well, since they
>> > > > have their WebView as well.
>> > > >
>> > > > On Thu, Apr 10, 2014 at 9:38 AM, Hu, Ningxin <ni...@intel.com>
>> > wrote:
>> > > > > Hangout would be a good idea.
>> > > > >
>> > > > > FYI, I will be off next week. How about the week after next? If it
>> > > > > works, please
>> > > > feel free to schedule one and count me in.
>> > > > >
>> > > > > Thanks,
>> > > > > -ningxin
>> > > > >
>> > > > >> -----Original Message-----
>> > > > >> From: mmocny@google.com [mailto:mmocny@google.com] On Behalf Of
>> > > > >> Michal Mocny
>> > > > >> Sent: Tuesday, April 08, 2014 11:39 PM
>> > > > >> To: dev
>> > > > >> Subject: Re: [Android] Refactoring for different engines
>> > > > >>
>> > > > >> Would it be alright to set up a Hangout some time to introduce
>> > everyone?
>> > > > >>
>> > > > >> Joe has been leading the effort here, but there are other cordova
>> > > > >> contributors for whom this is top priority.  It would be nice if
>> we
>> > > > >> could all meet to say hello and make sure we are all going in the
>> > > > >> right
>> > > > direction.
>> > > > >>
>> > > > >> Quite exciting!
>> > > > >>
>> > > > >> -Michal
>> > > > >>
>> > > > >>
>> > > > >> On Tue, Apr 8, 2014 at 10:56 AM, Hu, Ningxin <
>> ningxin.hu@intel.com>
>> > > wrote:
>> > > > >>
>> > > > >> > Joe, thanks for this. I am very excited.
>> > > > >> >
>> > > > >> > FYI. Crosswalk team is working on refactoring the WebView API to
>> > > > >> > support embedding usage better [1]. (Previously the layer API
>> was
>> > > > >> > not exposed as public usage).
>> > > > >> >
>> > > > >> > I would like to review the PoC and work with you to get
>> Crosswalk
>> > > > >> > fits into the pluggable WebView architecture.
>> > > > >> >
>> > > > >> > Thanks,
>> > > > >> > -ningxin
>> > > > >> >
>> > > > >> > > -----Original Message-----
>> > > > >> > > From: Joe Bowser [mailto:bowserj@gmail.com]
>> > > > >> > > Sent: Wednesday, March 19, 2014 7:08 AM
>> > > > >> > > To: dev
>> > > > >> > > Subject: Re: [Android] Refactoring for different engines
>> > > > >> > >
>> > > > >> > > Hey
>> > > > >> > >
>> > > > >> > > After debugging, I did some minor updates to the plugin
>> README.
>> > > > >> > > It
>> > > > >> > should be
>> > > > >> > > easier to get this up and running, although there's still the
>> > > > >> > > issue of
>> > > > >> > after-install
>> > > > >> > > hooks and the relative path weirdness with the Crosswalk
>> > Library itself.
>> > > > >> > >
>> > > > >> > > It still doesn't support the CLI at all, but it should be
>> there
>> > > > >> > > with the
>> > > > >> > old flow.
>> > > > >> > >
>> > > > >> > > On Mon, Mar 17, 2014 at 1:14 PM, Michal Mocny
>> > > > >> > > <mm...@chromium.org>
>> > > > >> > > wrote:
>> > > > >> > > > (Sorry Joe, Googlers are down in California and way busy.
>> > > > >> > > > Will be back in a week.  Super excited about this, though.)
>> > > > >> > > >
>> > > > >> > > > -Michal
>> > > > >> > > >
>> > > > >> > > >
>> > > > >> > > > On Mon, Mar 17, 2014 at 2:53 PM, Joe Bowser
>> > > > >> > > > <bo...@gmail.com>
>> > > > >> wrote:
>> > > > >> > > >
>> > > > >> > > >> Reviving this thread!
>> > > > >> > > >>
>> > > > >> > > >> Can other people look at this, and see if/when we should
>> > land this?
>> > > > >> > > >> I know that I have to re-write the tests still, but I would
>> > > > >> > > >> like some feedback before merging it in.  Also, it'd be
>> > > > >> > > >> super awesome if other people could try and make a WebView
>> > > > >> > > >> based on the interfaces and recommend which methods should
>> > > > >> > > >> die.  I want to get this released in the next month or so,
>> > > > >> > > >> so any time and feedback would be greatly appreciated.
>> > > > >> > > >>
>> > > > >> > > >> Thanks
>> > > > >> > > >>
>> > > > >> > > >> On Thu, Mar 13, 2014 at 3:50 PM, Joe Bowser
>> > > > >> > > >> <bo...@gmail.com>
>> > > > >> > wrote:
>> > > > >> > > >> > Hey, I created the following today to track various
>> > > > >> > > >> > WebView
>> > > > >> > progresses:
>> > > > >> > > >> > https://issues.apache.org/jira/browse/CB-6246
>> > > > >> > > >> >
>> > > > >> > > >> > I also have this repo created.  The licensing is ugly as
>> > > > >> > > >> > all crap, but it's a Proof-Of-Concept:
>> > > > >> > > >> > https://github.com/infil00p/cordova-crosswalk-engine
>> > > > >> > > >> >
>> > > > >> > > >> > If I can get some help getting plugman to just load
>> > > > >> > > >> > Crosswalk, it'll
>> > > > >> > > >> look hawt.
>> > > > >> > > >> >
>> > > > >> > > >> > BTW: We should probably get this ready to go into Android
>> > > > >> > > >> > in the next two months and deprecate the setProperty
>> > > > >> > > >> > methods, since all properties should be preferences in
>> > config.xml
>> > > now.
>> > > > >> > > >> >
>> > > > >> > > >> > On Mon, Mar 10, 2014 at 2:42 PM, Joe Bowser
>> > > > >> > > >> > <bo...@gmail.com>
>> > > > >> > > wrote:
>> > > > >> > > >> >> Perhaps. There would be additional benefits to this
>> > > > >> > > >> >> approach, namely fixes being added to that platform more
>> > > > >> > > >> >> quickly.  I'll probably take a look at that once I have
>> > > > >> > > >> >> Crosswalk
>> > > > finalized.
>> > > > >> > > >> >>
>> > > > >> > > >> >> On Mon, Mar 10, 2014 at 9:49 AM, Brian LeRoux
>> > > > >> > > >> >> <b...@brian.io>
>> > > > wrote:
>> > > > >> > > >> >>> this is great stuff
>> > > > >> > > >> >>>
>> > > > >> > > >> >>> do we think it may be possible to bring in amazon
>> fireos
>> > > > >> > > >> >>> stuff
>> > > > >> > > >> eventually
>> > > > >> > > >> >>> too?
>> > > > >> > > >> >>>
>> > > > >> > > >> >>>
>> > > > >> > > >> >>> On Fri, Mar 7, 2014 at 3:22 PM, Joe Bowser
>> > > > >> > > >> >>> <bo...@gmail.com>
>> > > > >> > wrote:
>> > > > >> > > >> >>>
>> > > > >> > > >> >>>> BTW: I committed it in my repo, not the main Apache
>> one.
>> > > > >> > > >> >>>>
>> > > > >> > > >> >>>> On Fri, Mar 7, 2014 at 3:21 PM, Joe Bowser
>> > > > >> > > >> >>>> <bo...@gmail.com>
>> > > > >> > > wrote:
>> > > > >> > > >> >>>> > Hey
>> > > > >> > > >> >>>> >
>> > > > >> > > >> >>>> > I just committed some code based on their WebView
>> > > > >> > > >> >>>> > modifications that allows you to choose your
>> renderer
>> > > > >> > > >> >>>> > in the
>> > > > >> > config file
>> > > > >> > > with this:
>> > > > >> > > >> >>>> >
>> > > > >> > > >> >>>> >     <preference name="webView"
>> > > > >> > > >> >>>> >
>> value="org.apache.cordova.engine.crosswalk.XWalkCordo
>> > > > >> > > >> >>>> > va
>> > > > >> > > >> >>>> > Web
>> > > > >> > > >> >>>> > View
>> > > > >> > > >> >>>> > " />
>> > > > >> > > >> >>>> >
>> > > > >> > > >> >>>> > You currently have to copy over the *.pak file and
>> > > > >> > > >> >>>> > the jsapi from a Crosswalk Example project to get
>> > > > >> > > >> >>>> > this to work.  The next thing that I'm going to do
>> is
>> > > > >> > > >> >>>> > figure out how to write this as a plugin and have it
>> > > > >> > > >> >>>> > install on a default
>> > > > project.
>> > > > >> > > >> >>>> > Also, right now the bridge doesn't seem to work, and
>> > > > >> > > >> >>>> > I don't know why exactly.  That being said, the
>> > > > >> > > >> fact
>> > > > >> > > >> >>>> > that I can choose which version of Chrome/Chromium
>> > > > >> > > >> >>>> > I'm running with
>> > > > >> > > >> a
>> > > > >> > > >> >>>> > single XML preference is HUGE.
>> > > > >> > > >> >>>> >
>> > > > >> > > >> >>>> > There's definitely a lot more work that needs to be
>> > > > >> > > >> >>>> > done, but as
>> > > > >> > > >> long
>> > > > >> > > >> >>>> > as we have something that we can fit into the
>> > > > >> > > >> >>>> > interface, we should
>> > > > >> > > >> be
>> > > > >> > > >> >>>> > able to put in things like GeckoView or other third
>> > > > >> > > >> >>>> > party
>> > > > >> > renderers.
>> > > > >> > > >> >>>> > The nightmare of being stuck with bullshit WebView
>> > > > >> > > >> >>>> > bugs may soon be over.
>> > > > >> > > >> >>>> >
>> > > > >> > > >> >>>> > On Wed, Mar 5, 2014 at 8:59 PM, Michal Mocny
>> > > > >> > > >> >>>> > <mm...@chromium.org>
>> > > > >> > > >> >>>> wrote:
>> > > > >> > > >> >>>> >>
>> https://github.com/crosswalk-project/crosswalk-cordo
>> > > > >> > > >> >>>> >> va
>> > > > >> > > >> >>>> >> -an
>> > > > >> > > >> >>>> >> droi
>> > > > >> > > >> >>>> >> d
>> > > > >> > > >> >>>> >>
>> > > > >> > > >> >>>> >> First patch they landed, which claims to have min
>> > > > >> > > >> >>>> >> viable xwalk
>> > > > >> > > >> webview:
>> > > > >> > > >> >>>> >>
>> > > > >> > > >> >>>>
>> > > > >> > > >>
>> https://github.com/crosswalk-project/crosswalk-cordova-andro
>> > > > >> > > >> id
>> > > > >> > > >> /co
>> > > > >> > > >> mmit
>> > > > >> > > >> /a04dedeb0204e7542d190312c6ae70c795a26e04
>> > > > >> > > >> >>>> >>
>> > > > >> > > >> >>>> >>
>> > > > >> > > >> >>>> >> On Wed, Mar 5, 2014 at 11:37 PM, Michal Mocny
>> > > > >> > > >> >>>> >> <mmocny@chromium.org
>> > > > >> > > >> >
>> > > > >> > > >> >>>> wrote:
>> > > > >> > > >> >>>> >>
>> > > > >> > > >> >>>> >>> I haven't looked yet, but did you see:
>> > > > >> > > >> >>>> >>>
>> https://crosswalk-project.org/#wiki/crosswalk-cordo
>> > > > >> > > >> >>>> >>> va
>> > > > >> > > >> >>>> >>> -an
>> > > > >> > > >> >>>> >>> droi
>> > > > >> > > >> >>>> >>> d
>> > > > >> > > >> >>>> >>>
>> > > > >> > > >> >>>> >>> ?
>> > > > >> > > >> >>>> >>>
>> > > > >> > > >> >>>> >>>
>> > > > >> > > >> >>>> >>> On Wed, Mar 5, 2014 at 10:20 PM, Andrew Grieve <
>> > > > >> > > >> agrieve@chromium.org
>> > > > >> > > >> >>>> >wrote:
>> > > > >> > > >> >>>> >>>
>> > > > >> > > >> >>>> >>>> First - very excited that you're working on this!
>> > > > >> > > >> >>>> >>>>
>> > > > >> > > >> >>>> >>>> Had a quick look. Not sure there's much to be
>> > gleaned
>> > > yet.
>> > > > >> > > >> >>>> >>>> Once
>> > > > >> > > >> you
>> > > > >> > > >> >>>> start
>> > > > >> > > >> >>>> >>>> in on hooking up x-walk's webview I think it will
>> > > > >> > > >> >>>> >>>> become more
>> > > > >> > > >> obvious
>> > > > >> > > >> >>>> what
>> > > > >> > > >> >>>> >>>> the interface should look like. E.g., does x-walk
>> > > > >> > > >> >>>> >>>> even have the
>> > > > >> > > >> >>>> concept of
>> > > > >> > > >> >>>> >>>> ChromeClient vs WebViewClient vs WebView? Also
>> > > > >> > > >> >>>> >>>> unsure whether the
>> > > > >> > > >> >>>> class
>> > > > >> > > >> >>>> >>>> should extend android.View as well as implement
>> > > > >> > > >> >>>> >>>> our
>> > > > >> > interface.
>> > > > >> > > >> E.g.
>> > > > >> > > >> >>>> >>>> alternative is to have a "getView()" method on
>> the
>> > > > >> > interface.
>> > > > >> > > >> Might
>> > > > >> > > >> >>>> help
>> > > > >> > > >> >>>> >>>> to
>> > > > >> > > >> >>>> >>>> cut down on file sizes, and API surface, but
>> > > > >> > > >> >>>> >>>> again, I'm not too
>> > > > >> > > >> sure.
>> > > > >> > > >> >>>> >>>>
>> > > > >> > > >> >>>> >>>> I've been pretty hesitant to touch existing
>> > > > >> > > >> >>>> >>>> exposed members
>> > > > >> > > >> (e.g. the
>> > > > >> > > >> >>>> >>>> public fields you were referring to) since
>> > > > >> > > >> >>>> >>>> touching anything
>> > > > >> > > >> public
>> > > > >> > > >> >>>> could
>> > > > >> > > >> >>>> >>>> break plugins. That said, maybe now is a good
>> time
>> > > > >> > > >> >>>> >>>> to @deprecate
>> > > > >> > > >> a
>> > > > >> > > >> >>>> bunch
>> > > > >> > > >> >>>> >>>> of
>> > > > >> > > >> >>>> >>>> them and either replace them with getters, or
>> just
>> > > > >> > > >> >>>> >>>> declare them
>> > > > >> > > >> to be
>> > > > >> > > >> >>>> not
>> > > > >> > > >> >>>> >>>> exposed to plugins.
>> > > > >> > > >> >>>> >>>>
>> > > > >> > > >> >>>> >>>>
>> > > > >> > > >> >>>> >>>> On Wed, Mar 5, 2014 at 6:57 PM, Joe Bowser
>> > > > >> > > >> >>>> >>>> <bo...@gmail.com>
>> > > > >> > > >> wrote:
>> > > > >> > > >> >>>> >>>>
>> > > > >> > > >> >>>> >>>> > So, after looking at the Crosswalk code again,
>> > > > >> > > >> >>>> >>>> > I've decided to
>> > > > >> > > >> take
>> > > > >> > > >> >>>> a
>> > > > >> > > >> >>>> >>>> > quick stab at making things pluggable.  I don't
>> > > > >> > > >> >>>> >>>> > have a lot to
>> > > > >> > > >> show
>> > > > >> > > >> >>>> for
>> > > > >> > > >> >>>> >>>> > it, but with the help of Eclipse (which is why
>> > > > >> > > >> >>>> >>>> > the generated interfaces look so screwed up), I
>> > > > >> > > >> >>>> >>>> > managed to create some
>> > > > >> > > >> interfaces
>> > > > >> > > >> >>>> so
>> > > > >> > > >> >>>> >>>> > we can start shoehorning in other browser
>> > renderers.
>> > > > >> > > >> >>>> >>>> >
>> > > > >> > > >> >>>> >>>> >
>> > > > >> > > >>
>> https://github.com/infil00p/cordova-android/tree/pluggable_w
>> > > > >> > > >> eb
>> > > > >> > > >> vie
>> > > > >> > > >> w
>> > > > >> > > >> >>>> >>>> >
>> > > > >> > > >> >>>> >>>> > I'm going to probably start with Crosswalk,
>> > > > >> > > >> >>>> >>>> > because it's
>> > > > >> > > >> probably
>> > > > >> > > >> >>>> the
>> > > > >> > > >> >>>> >>>> > most mature primary candidate in the Android
>> > > > >> > > >> >>>> >>>> > Third-Party
>> > > > >> > > >> WebView
>> > > > >> > > >> >>>> >>>> > thing, and I'm pretty sure the GeckoView will
>> be
>> > > > >> > > >> >>>> >>>> > happening
>> > > > >> > > >> shortly
>> > > > >> > > >> >>>> >>>> > after.
>> > > > >> > > >> >>>> >>>> >
>> > > > >> > > >> >>>> >>>> > I don't know how this would work w.r.t. the CLI
>> > > > >> > > >> >>>> >>>> > or our
>> > > > >> > > >> workflow at
>> > > > >> > > >> >>>> >>>> > all, but at the moment, I really just want to
>> at
>> > > > >> > > >> >>>> >>>> > least start
>> > > > >> > > >> to have
>> > > > >> > > >> >>>> >>>> > some headway towards 4.x and PhoneGap day.
>> > > > >> > > >> >>>> >>>> >
>> > > > >> > > >> >>>> >>>> > What do people think of this so far? I'm going
>> > > > >> > > >> >>>> >>>> > to try to clean
>> > > > >> > > >> >>>> things
>> > > > >> > > >> >>>> >>>> > up a bit, since we've definitely done a lot of
>> > > > >> > > >> >>>> >>>> > things that
>> > > > >> > > >> would
>> > > > >> > > >> >>>> make
>> > > > >> > > >> >>>> >>>> > first year CS profs freak the hell out (i.e.
>> > > > >> > > >> >>>> >>>> > public members in
>> > > > >> > > >> >>>> public
>> > > > >> > > >> >>>> >>>> > objects w.r.t. PluginManager).
>> > > > >> > > >> >>>> >>>> >
>> > > > >> > > >> >>>> >>>> > Thoughts?
>> > > > >> > > >> >>>> >>>> >
>> > > > >> > > >> >>>> >>>> > Joe
>> > > > >> > > >> >>>> >>>> >
>> > > > >> > > >> >>>> >>>>
>> > > > >> > > >> >>>> >>>
>> > > > >> > > >> >>>> >>>
>> > > > >> > > >> >>>>
>> > > > >> > > >>
>> > > > >> >
>> >
>>

RE: [Android] Refactoring for different engines

[Tommy Williams <to...@devgeeks.org>]

More engines, more better...
On 23 Apr 2014 16:32, "Joe Bowser" <bo...@gmail.com> wrote:

> Hey
>
> A Hangout would have to happen on Friday at the earliest.  It'd be good if
> we could get someone from Mozilla on the hangout as well.  I haven't gotten
> MozillaView (GeckoView with Cordova methods) fully working yet.  For some
> reason it's not rendering on the screen.
>
> Ideally it'd be cool to have at least two options when this feature finally
> lands.
>
> What do other people think?
>
> Joe
> On 22 Apr 2014 20:06, "Hu, Ningxin" <ni...@intel.com> wrote:
>
> > Joe,
> >
> > Thanks for your review and merge the PRs.
> >
> > To pluggable webview interest group:
> > Are we OK to setup a hangout this week for initial introduction and
> > discussion of next steps?
> >
> > Thanks,
> > -ningxin
> >
> > > -----Original Message-----
> > > From: Hu, Ningxin [mailto:ningxin.hu@intel.com]
> > > Sent: Tuesday, April 22, 2014 4:04 PM
> > > To: dev@cordova.apache.org
> > > Subject: RE: [Android] Refactoring for different engines
> > >
> > > The PoC is great! Quite excited about the direction!
> > >
> > > I've sent a PR to update the cordova-crosswalk-engine to latest
> crosswalk
> > > embedding API. It works with xwalk_core_library at 6.35.124.0.
> > >
> > > I've also changed the CordovaWebView interface slightly (adding
> > getView() API)
> > > to allow XWalkCordovaWebView to composite a XWalkView instead of
> > extending
> > > it. It resolves some API naming issues for XWalkView case.
> > >
> > > Please review them at:
> > > https://github.com/infil00p/cordova-crosswalk-engine/pull/3
> > > https://github.com/infil00p/cordova-android/pull/2
> > >
> > > Thanks,
> > > -ningxin
> > >
> > > > -----Original Message-----
> > > > From: Joe Bowser [mailto:bowserj@gmail.com]
> > > > Sent: Friday, April 11, 2014 12:45 AM
> > > > To: dev
> > > > Subject: Re: [Android] Refactoring for different engines
> > > >
> > > > Yeah, I'd be cool with setting up a hangout.  Everyone should take a
> > > > look at the PoC, I've basically distilled it down to four or five
> > > > classes so far, but with some work, we may be able to get it down to
> > > > three.  Due to legacy, we're pretty stuck with the Android WebView
> API
> > calls,
> > > but these can probably be modified.
> > > >
> > > > It'd be good to get Mozilla people on the call as well, since they
> > > > have their WebView as well.
> > > >
> > > > On Thu, Apr 10, 2014 at 9:38 AM, Hu, Ningxin <ni...@intel.com>
> > wrote:
> > > > > Hangout would be a good idea.
> > > > >
> > > > > FYI, I will be off next week. How about the week after next? If it
> > > > > works, please
> > > > feel free to schedule one and count me in.
> > > > >
> > > > > Thanks,
> > > > > -ningxin
> > > > >
> > > > >> -----Original Message-----
> > > > >> From: mmocny@google.com [mailto:mmocny@google.com] On Behalf Of
> > > > >> Michal Mocny
> > > > >> Sent: Tuesday, April 08, 2014 11:39 PM
> > > > >> To: dev
> > > > >> Subject: Re: [Android] Refactoring for different engines
> > > > >>
> > > > >> Would it be alright to set up a Hangout some time to introduce
> > everyone?
> > > > >>
> > > > >> Joe has been leading the effort here, but there are other cordova
> > > > >> contributors for whom this is top priority.  It would be nice if
> we
> > > > >> could all meet to say hello and make sure we are all going in the
> > > > >> right
> > > > direction.
> > > > >>
> > > > >> Quite exciting!
> > > > >>
> > > > >> -Michal
> > > > >>
> > > > >>
> > > > >> On Tue, Apr 8, 2014 at 10:56 AM, Hu, Ningxin <
> ningxin.hu@intel.com>
> > > wrote:
> > > > >>
> > > > >> > Joe, thanks for this. I am very excited.
> > > > >> >
> > > > >> > FYI. Crosswalk team is working on refactoring the WebView API to
> > > > >> > support embedding usage better [1]. (Previously the layer API
> was
> > > > >> > not exposed as public usage).
> > > > >> >
> > > > >> > I would like to review the PoC and work with you to get
> Crosswalk
> > > > >> > fits into the pluggable WebView architecture.
> > > > >> >
> > > > >> > Thanks,
> > > > >> > -ningxin
> > > > >> >
> > > > >> > > -----Original Message-----
> > > > >> > > From: Joe Bowser [mailto:bowserj@gmail.com]
> > > > >> > > Sent: Wednesday, March 19, 2014 7:08 AM
> > > > >> > > To: dev
> > > > >> > > Subject: Re: [Android] Refactoring for different engines
> > > > >> > >
> > > > >> > > Hey
> > > > >> > >
> > > > >> > > After debugging, I did some minor updates to the plugin
> README.
> > > > >> > > It
> > > > >> > should be
> > > > >> > > easier to get this up and running, although there's still the
> > > > >> > > issue of
> > > > >> > after-install
> > > > >> > > hooks and the relative path weirdness with the Crosswalk
> > Library itself.
> > > > >> > >
> > > > >> > > It still doesn't support the CLI at all, but it should be
> there
> > > > >> > > with the
> > > > >> > old flow.
> > > > >> > >
> > > > >> > > On Mon, Mar 17, 2014 at 1:14 PM, Michal Mocny
> > > > >> > > <mm...@chromium.org>
> > > > >> > > wrote:
> > > > >> > > > (Sorry Joe, Googlers are down in California and way busy.
> > > > >> > > > Will be back in a week.  Super excited about this, though.)
> > > > >> > > >
> > > > >> > > > -Michal
> > > > >> > > >
> > > > >> > > >
> > > > >> > > > On Mon, Mar 17, 2014 at 2:53 PM, Joe Bowser
> > > > >> > > > <bo...@gmail.com>
> > > > >> wrote:
> > > > >> > > >
> > > > >> > > >> Reviving this thread!
> > > > >> > > >>
> > > > >> > > >> Can other people look at this, and see if/when we should
> > land this?
> > > > >> > > >> I know that I have to re-write the tests still, but I would
> > > > >> > > >> like some feedback before merging it in.  Also, it'd be
> > > > >> > > >> super awesome if other people could try and make a WebView
> > > > >> > > >> based on the interfaces and recommend which methods should
> > > > >> > > >> die.  I want to get this released in the next month or so,
> > > > >> > > >> so any time and feedback would be greatly appreciated.
> > > > >> > > >>
> > > > >> > > >> Thanks
> > > > >> > > >>
> > > > >> > > >> On Thu, Mar 13, 2014 at 3:50 PM, Joe Bowser
> > > > >> > > >> <bo...@gmail.com>
> > > > >> > wrote:
> > > > >> > > >> > Hey, I created the following today to track various
> > > > >> > > >> > WebView
> > > > >> > progresses:
> > > > >> > > >> > https://issues.apache.org/jira/browse/CB-6246
> > > > >> > > >> >
> > > > >> > > >> > I also have this repo created.  The licensing is ugly as
> > > > >> > > >> > all crap, but it's a Proof-Of-Concept:
> > > > >> > > >> > https://github.com/infil00p/cordova-crosswalk-engine
> > > > >> > > >> >
> > > > >> > > >> > If I can get some help getting plugman to just load
> > > > >> > > >> > Crosswalk, it'll
> > > > >> > > >> look hawt.
> > > > >> > > >> >
> > > > >> > > >> > BTW: We should probably get this ready to go into Android
> > > > >> > > >> > in the next two months and deprecate the setProperty
> > > > >> > > >> > methods, since all properties should be preferences in
> > config.xml
> > > now.
> > > > >> > > >> >
> > > > >> > > >> > On Mon, Mar 10, 2014 at 2:42 PM, Joe Bowser
> > > > >> > > >> > <bo...@gmail.com>
> > > > >> > > wrote:
> > > > >> > > >> >> Perhaps. There would be additional benefits to this
> > > > >> > > >> >> approach, namely fixes being added to that platform more
> > > > >> > > >> >> quickly.  I'll probably take a look at that once I have
> > > > >> > > >> >> Crosswalk
> > > > finalized.
> > > > >> > > >> >>
> > > > >> > > >> >> On Mon, Mar 10, 2014 at 9:49 AM, Brian LeRoux
> > > > >> > > >> >> <b...@brian.io>
> > > > wrote:
> > > > >> > > >> >>> this is great stuff
> > > > >> > > >> >>>
> > > > >> > > >> >>> do we think it may be possible to bring in amazon
> fireos
> > > > >> > > >> >>> stuff
> > > > >> > > >> eventually
> > > > >> > > >> >>> too?
> > > > >> > > >> >>>
> > > > >> > > >> >>>
> > > > >> > > >> >>> On Fri, Mar 7, 2014 at 3:22 PM, Joe Bowser
> > > > >> > > >> >>> <bo...@gmail.com>
> > > > >> > wrote:
> > > > >> > > >> >>>
> > > > >> > > >> >>>> BTW: I committed it in my repo, not the main Apache
> one.
> > > > >> > > >> >>>>
> > > > >> > > >> >>>> On Fri, Mar 7, 2014 at 3:21 PM, Joe Bowser
> > > > >> > > >> >>>> <bo...@gmail.com>
> > > > >> > > wrote:
> > > > >> > > >> >>>> > Hey
> > > > >> > > >> >>>> >
> > > > >> > > >> >>>> > I just committed some code based on their WebView
> > > > >> > > >> >>>> > modifications that allows you to choose your
> renderer
> > > > >> > > >> >>>> > in the
> > > > >> > config file
> > > > >> > > with this:
> > > > >> > > >> >>>> >
> > > > >> > > >> >>>> >     <preference name="webView"
> > > > >> > > >> >>>> >
> value="org.apache.cordova.engine.crosswalk.XWalkCordo
> > > > >> > > >> >>>> > va
> > > > >> > > >> >>>> > Web
> > > > >> > > >> >>>> > View
> > > > >> > > >> >>>> > " />
> > > > >> > > >> >>>> >
> > > > >> > > >> >>>> > You currently have to copy over the *.pak file and
> > > > >> > > >> >>>> > the jsapi from a Crosswalk Example project to get
> > > > >> > > >> >>>> > this to work.  The next thing that I'm going to do
> is
> > > > >> > > >> >>>> > figure out how to write this as a plugin and have it
> > > > >> > > >> >>>> > install on a default
> > > > project.
> > > > >> > > >> >>>> > Also, right now the bridge doesn't seem to work, and
> > > > >> > > >> >>>> > I don't know why exactly.  That being said, the
> > > > >> > > >> fact
> > > > >> > > >> >>>> > that I can choose which version of Chrome/Chromium
> > > > >> > > >> >>>> > I'm running with
> > > > >> > > >> a
> > > > >> > > >> >>>> > single XML preference is HUGE.
> > > > >> > > >> >>>> >
> > > > >> > > >> >>>> > There's definitely a lot more work that needs to be
> > > > >> > > >> >>>> > done, but as
> > > > >> > > >> long
> > > > >> > > >> >>>> > as we have something that we can fit into the
> > > > >> > > >> >>>> > interface, we should
> > > > >> > > >> be
> > > > >> > > >> >>>> > able to put in things like GeckoView or other third
> > > > >> > > >> >>>> > party
> > > > >> > renderers.
> > > > >> > > >> >>>> > The nightmare of being stuck with bullshit WebView
> > > > >> > > >> >>>> > bugs may soon be over.
> > > > >> > > >> >>>> >
> > > > >> > > >> >>>> > On Wed, Mar 5, 2014 at 8:59 PM, Michal Mocny
> > > > >> > > >> >>>> > <mm...@chromium.org>
> > > > >> > > >> >>>> wrote:
> > > > >> > > >> >>>> >>
> https://github.com/crosswalk-project/crosswalk-cordo
> > > > >> > > >> >>>> >> va
> > > > >> > > >> >>>> >> -an
> > > > >> > > >> >>>> >> droi
> > > > >> > > >> >>>> >> d
> > > > >> > > >> >>>> >>
> > > > >> > > >> >>>> >> First patch they landed, which claims to have min
> > > > >> > > >> >>>> >> viable xwalk
> > > > >> > > >> webview:
> > > > >> > > >> >>>> >>
> > > > >> > > >> >>>>
> > > > >> > > >>
> https://github.com/crosswalk-project/crosswalk-cordova-andro
> > > > >> > > >> id
> > > > >> > > >> /co
> > > > >> > > >> mmit
> > > > >> > > >> /a04dedeb0204e7542d190312c6ae70c795a26e04
> > > > >> > > >> >>>> >>
> > > > >> > > >> >>>> >>
> > > > >> > > >> >>>> >> On Wed, Mar 5, 2014 at 11:37 PM, Michal Mocny
> > > > >> > > >> >>>> >> <mmocny@chromium.org
> > > > >> > > >> >
> > > > >> > > >> >>>> wrote:
> > > > >> > > >> >>>> >>
> > > > >> > > >> >>>> >>> I haven't looked yet, but did you see:
> > > > >> > > >> >>>> >>>
> https://crosswalk-project.org/#wiki/crosswalk-cordo
> > > > >> > > >> >>>> >>> va
> > > > >> > > >> >>>> >>> -an
> > > > >> > > >> >>>> >>> droi
> > > > >> > > >> >>>> >>> d
> > > > >> > > >> >>>> >>>
> > > > >> > > >> >>>> >>> ?
> > > > >> > > >> >>>> >>>
> > > > >> > > >> >>>> >>>
> > > > >> > > >> >>>> >>> On Wed, Mar 5, 2014 at 10:20 PM, Andrew Grieve <
> > > > >> > > >> agrieve@chromium.org
> > > > >> > > >> >>>> >wrote:
> > > > >> > > >> >>>> >>>
> > > > >> > > >> >>>> >>>> First - very excited that you're working on this!
> > > > >> > > >> >>>> >>>>
> > > > >> > > >> >>>> >>>> Had a quick look. Not sure there's much to be
> > gleaned
> > > yet.
> > > > >> > > >> >>>> >>>> Once
> > > > >> > > >> you
> > > > >> > > >> >>>> start
> > > > >> > > >> >>>> >>>> in on hooking up x-walk's webview I think it will
> > > > >> > > >> >>>> >>>> become more
> > > > >> > > >> obvious
> > > > >> > > >> >>>> what
> > > > >> > > >> >>>> >>>> the interface should look like. E.g., does x-walk
> > > > >> > > >> >>>> >>>> even have the
> > > > >> > > >> >>>> concept of
> > > > >> > > >> >>>> >>>> ChromeClient vs WebViewClient vs WebView? Also
> > > > >> > > >> >>>> >>>> unsure whether the
> > > > >> > > >> >>>> class
> > > > >> > > >> >>>> >>>> should extend android.View as well as implement
> > > > >> > > >> >>>> >>>> our
> > > > >> > interface.
> > > > >> > > >> E.g.
> > > > >> > > >> >>>> >>>> alternative is to have a "getView()" method on
> the
> > > > >> > interface.
> > > > >> > > >> Might
> > > > >> > > >> >>>> help
> > > > >> > > >> >>>> >>>> to
> > > > >> > > >> >>>> >>>> cut down on file sizes, and API surface, but
> > > > >> > > >> >>>> >>>> again, I'm not too
> > > > >> > > >> sure.
> > > > >> > > >> >>>> >>>>
> > > > >> > > >> >>>> >>>> I've been pretty hesitant to touch existing
> > > > >> > > >> >>>> >>>> exposed members
> > > > >> > > >> (e.g. the
> > > > >> > > >> >>>> >>>> public fields you were referring to) since
> > > > >> > > >> >>>> >>>> touching anything
> > > > >> > > >> public
> > > > >> > > >> >>>> could
> > > > >> > > >> >>>> >>>> break plugins. That said, maybe now is a good
> time
> > > > >> > > >> >>>> >>>> to @deprecate
> > > > >> > > >> a
> > > > >> > > >> >>>> bunch
> > > > >> > > >> >>>> >>>> of
> > > > >> > > >> >>>> >>>> them and either replace them with getters, or
> just
> > > > >> > > >> >>>> >>>> declare them
> > > > >> > > >> to be
> > > > >> > > >> >>>> not
> > > > >> > > >> >>>> >>>> exposed to plugins.
> > > > >> > > >> >>>> >>>>
> > > > >> > > >> >>>> >>>>
> > > > >> > > >> >>>> >>>> On Wed, Mar 5, 2014 at 6:57 PM, Joe Bowser
> > > > >> > > >> >>>> >>>> <bo...@gmail.com>
> > > > >> > > >> wrote:
> > > > >> > > >> >>>> >>>>
> > > > >> > > >> >>>> >>>> > So, after looking at the Crosswalk code again,
> > > > >> > > >> >>>> >>>> > I've decided to
> > > > >> > > >> take
> > > > >> > > >> >>>> a
> > > > >> > > >> >>>> >>>> > quick stab at making things pluggable.  I don't
> > > > >> > > >> >>>> >>>> > have a lot to
> > > > >> > > >> show
> > > > >> > > >> >>>> for
> > > > >> > > >> >>>> >>>> > it, but with the help of Eclipse (which is why
> > > > >> > > >> >>>> >>>> > the generated interfaces look so screwed up), I
> > > > >> > > >> >>>> >>>> > managed to create some
> > > > >> > > >> interfaces
> > > > >> > > >> >>>> so
> > > > >> > > >> >>>> >>>> > we can start shoehorning in other browser
> > renderers.
> > > > >> > > >> >>>> >>>> >
> > > > >> > > >> >>>> >>>> >
> > > > >> > > >>
> https://github.com/infil00p/cordova-android/tree/pluggable_w
> > > > >> > > >> eb
> > > > >> > > >> vie
> > > > >> > > >> w
> > > > >> > > >> >>>> >>>> >
> > > > >> > > >> >>>> >>>> > I'm going to probably start with Crosswalk,
> > > > >> > > >> >>>> >>>> > because it's
> > > > >> > > >> probably
> > > > >> > > >> >>>> the
> > > > >> > > >> >>>> >>>> > most mature primary candidate in the Android
> > > > >> > > >> >>>> >>>> > Third-Party
> > > > >> > > >> WebView
> > > > >> > > >> >>>> >>>> > thing, and I'm pretty sure the GeckoView will
> be
> > > > >> > > >> >>>> >>>> > happening
> > > > >> > > >> shortly
> > > > >> > > >> >>>> >>>> > after.
> > > > >> > > >> >>>> >>>> >
> > > > >> > > >> >>>> >>>> > I don't know how this would work w.r.t. the CLI
> > > > >> > > >> >>>> >>>> > or our
> > > > >> > > >> workflow at
> > > > >> > > >> >>>> >>>> > all, but at the moment, I really just want to
> at
> > > > >> > > >> >>>> >>>> > least start
> > > > >> > > >> to have
> > > > >> > > >> >>>> >>>> > some headway towards 4.x and PhoneGap day.
> > > > >> > > >> >>>> >>>> >
> > > > >> > > >> >>>> >>>> > What do people think of this so far? I'm going
> > > > >> > > >> >>>> >>>> > to try to clean
> > > > >> > > >> >>>> things
> > > > >> > > >> >>>> >>>> > up a bit, since we've definitely done a lot of
> > > > >> > > >> >>>> >>>> > things that
> > > > >> > > >> would
> > > > >> > > >> >>>> make
> > > > >> > > >> >>>> >>>> > first year CS profs freak the hell out (i.e.
> > > > >> > > >> >>>> >>>> > public members in
> > > > >> > > >> >>>> public
> > > > >> > > >> >>>> >>>> > objects w.r.t. PluginManager).
> > > > >> > > >> >>>> >>>> >
> > > > >> > > >> >>>> >>>> > Thoughts?
> > > > >> > > >> >>>> >>>> >
> > > > >> > > >> >>>> >>>> > Joe
> > > > >> > > >> >>>> >>>> >
> > > > >> > > >> >>>> >>>>
> > > > >> > > >> >>>> >>>
> > > > >> > > >> >>>> >>>
> > > > >> > > >> >>>>
> > > > >> > > >>
> > > > >> >
> >
>

RE: [Android] Refactoring for different engines

[Joe Bowser <bo...@gmail.com>]

Hey

A Hangout would have to happen on Friday at the earliest.  It'd be good if
we could get someone from Mozilla on the hangout as well.  I haven't gotten
MozillaView (GeckoView with Cordova methods) fully working yet.  For some
reason it's not rendering on the screen.

Ideally it'd be cool to have at least two options when this feature finally
lands.

What do other people think?

Joe
On 22 Apr 2014 20:06, "Hu, Ningxin" <ni...@intel.com> wrote:

> Joe,
>
> Thanks for your review and merge the PRs.
>
> To pluggable webview interest group:
> Are we OK to setup a hangout this week for initial introduction and
> discussion of next steps?
>
> Thanks,
> -ningxin
>
> > -----Original Message-----
> > From: Hu, Ningxin [mailto:ningxin.hu@intel.com]
> > Sent: Tuesday, April 22, 2014 4:04 PM
> > To: dev@cordova.apache.org
> > Subject: RE: [Android] Refactoring for different engines
> >
> > The PoC is great! Quite excited about the direction!
> >
> > I've sent a PR to update the cordova-crosswalk-engine to latest crosswalk
> > embedding API. It works with xwalk_core_library at 6.35.124.0.
> >
> > I've also changed the CordovaWebView interface slightly (adding
> getView() API)
> > to allow XWalkCordovaWebView to composite a XWalkView instead of
> extending
> > it. It resolves some API naming issues for XWalkView case.
> >
> > Please review them at:
> > https://github.com/infil00p/cordova-crosswalk-engine/pull/3
> > https://github.com/infil00p/cordova-android/pull/2
> >
> > Thanks,
> > -ningxin
> >
> > > -----Original Message-----
> > > From: Joe Bowser [mailto:bowserj@gmail.com]
> > > Sent: Friday, April 11, 2014 12:45 AM
> > > To: dev
> > > Subject: Re: [Android] Refactoring for different engines
> > >
> > > Yeah, I'd be cool with setting up a hangout.  Everyone should take a
> > > look at the PoC, I've basically distilled it down to four or five
> > > classes so far, but with some work, we may be able to get it down to
> > > three.  Due to legacy, we're pretty stuck with the Android WebView API
> calls,
> > but these can probably be modified.
> > >
> > > It'd be good to get Mozilla people on the call as well, since they
> > > have their WebView as well.
> > >
> > > On Thu, Apr 10, 2014 at 9:38 AM, Hu, Ningxin <ni...@intel.com>
> wrote:
> > > > Hangout would be a good idea.
> > > >
> > > > FYI, I will be off next week. How about the week after next? If it
> > > > works, please
> > > feel free to schedule one and count me in.
> > > >
> > > > Thanks,
> > > > -ningxin
> > > >
> > > >> -----Original Message-----
> > > >> From: mmocny@google.com [mailto:mmocny@google.com] On Behalf Of
> > > >> Michal Mocny
> > > >> Sent: Tuesday, April 08, 2014 11:39 PM
> > > >> To: dev
> > > >> Subject: Re: [Android] Refactoring for different engines
> > > >>
> > > >> Would it be alright to set up a Hangout some time to introduce
> everyone?
> > > >>
> > > >> Joe has been leading the effort here, but there are other cordova
> > > >> contributors for whom this is top priority.  It would be nice if we
> > > >> could all meet to say hello and make sure we are all going in the
> > > >> right
> > > direction.
> > > >>
> > > >> Quite exciting!
> > > >>
> > > >> -Michal
> > > >>
> > > >>
> > > >> On Tue, Apr 8, 2014 at 10:56 AM, Hu, Ningxin <ni...@intel.com>
> > wrote:
> > > >>
> > > >> > Joe, thanks for this. I am very excited.
> > > >> >
> > > >> > FYI. Crosswalk team is working on refactoring the WebView API to
> > > >> > support embedding usage better [1]. (Previously the layer API was
> > > >> > not exposed as public usage).
> > > >> >
> > > >> > I would like to review the PoC and work with you to get Crosswalk
> > > >> > fits into the pluggable WebView architecture.
> > > >> >
> > > >> > Thanks,
> > > >> > -ningxin
> > > >> >
> > > >> > > -----Original Message-----
> > > >> > > From: Joe Bowser [mailto:bowserj@gmail.com]
> > > >> > > Sent: Wednesday, March 19, 2014 7:08 AM
> > > >> > > To: dev
> > > >> > > Subject: Re: [Android] Refactoring for different engines
> > > >> > >
> > > >> > > Hey
> > > >> > >
> > > >> > > After debugging, I did some minor updates to the plugin README.
> > > >> > > It
> > > >> > should be
> > > >> > > easier to get this up and running, although there's still the
> > > >> > > issue of
> > > >> > after-install
> > > >> > > hooks and the relative path weirdness with the Crosswalk
> Library itself.
> > > >> > >
> > > >> > > It still doesn't support the CLI at all, but it should be there
> > > >> > > with the
> > > >> > old flow.
> > > >> > >
> > > >> > > On Mon, Mar 17, 2014 at 1:14 PM, Michal Mocny
> > > >> > > <mm...@chromium.org>
> > > >> > > wrote:
> > > >> > > > (Sorry Joe, Googlers are down in California and way busy.
> > > >> > > > Will be back in a week.  Super excited about this, though.)
> > > >> > > >
> > > >> > > > -Michal
> > > >> > > >
> > > >> > > >
> > > >> > > > On Mon, Mar 17, 2014 at 2:53 PM, Joe Bowser
> > > >> > > > <bo...@gmail.com>
> > > >> wrote:
> > > >> > > >
> > > >> > > >> Reviving this thread!
> > > >> > > >>
> > > >> > > >> Can other people look at this, and see if/when we should
> land this?
> > > >> > > >> I know that I have to re-write the tests still, but I would
> > > >> > > >> like some feedback before merging it in.  Also, it'd be
> > > >> > > >> super awesome if other people could try and make a WebView
> > > >> > > >> based on the interfaces and recommend which methods should
> > > >> > > >> die.  I want to get this released in the next month or so,
> > > >> > > >> so any time and feedback would be greatly appreciated.
> > > >> > > >>
> > > >> > > >> Thanks
> > > >> > > >>
> > > >> > > >> On Thu, Mar 13, 2014 at 3:50 PM, Joe Bowser
> > > >> > > >> <bo...@gmail.com>
> > > >> > wrote:
> > > >> > > >> > Hey, I created the following today to track various
> > > >> > > >> > WebView
> > > >> > progresses:
> > > >> > > >> > https://issues.apache.org/jira/browse/CB-6246
> > > >> > > >> >
> > > >> > > >> > I also have this repo created.  The licensing is ugly as
> > > >> > > >> > all crap, but it's a Proof-Of-Concept:
> > > >> > > >> > https://github.com/infil00p/cordova-crosswalk-engine
> > > >> > > >> >
> > > >> > > >> > If I can get some help getting plugman to just load
> > > >> > > >> > Crosswalk, it'll
> > > >> > > >> look hawt.
> > > >> > > >> >
> > > >> > > >> > BTW: We should probably get this ready to go into Android
> > > >> > > >> > in the next two months and deprecate the setProperty
> > > >> > > >> > methods, since all properties should be preferences in
> config.xml
> > now.
> > > >> > > >> >
> > > >> > > >> > On Mon, Mar 10, 2014 at 2:42 PM, Joe Bowser
> > > >> > > >> > <bo...@gmail.com>
> > > >> > > wrote:
> > > >> > > >> >> Perhaps. There would be additional benefits to this
> > > >> > > >> >> approach, namely fixes being added to that platform more
> > > >> > > >> >> quickly.  I'll probably take a look at that once I have
> > > >> > > >> >> Crosswalk
> > > finalized.
> > > >> > > >> >>
> > > >> > > >> >> On Mon, Mar 10, 2014 at 9:49 AM, Brian LeRoux
> > > >> > > >> >> <b...@brian.io>
> > > wrote:
> > > >> > > >> >>> this is great stuff
> > > >> > > >> >>>
> > > >> > > >> >>> do we think it may be possible to bring in amazon fireos
> > > >> > > >> >>> stuff
> > > >> > > >> eventually
> > > >> > > >> >>> too?
> > > >> > > >> >>>
> > > >> > > >> >>>
> > > >> > > >> >>> On Fri, Mar 7, 2014 at 3:22 PM, Joe Bowser
> > > >> > > >> >>> <bo...@gmail.com>
> > > >> > wrote:
> > > >> > > >> >>>
> > > >> > > >> >>>> BTW: I committed it in my repo, not the main Apache one.
> > > >> > > >> >>>>
> > > >> > > >> >>>> On Fri, Mar 7, 2014 at 3:21 PM, Joe Bowser
> > > >> > > >> >>>> <bo...@gmail.com>
> > > >> > > wrote:
> > > >> > > >> >>>> > Hey
> > > >> > > >> >>>> >
> > > >> > > >> >>>> > I just committed some code based on their WebView
> > > >> > > >> >>>> > modifications that allows you to choose your renderer
> > > >> > > >> >>>> > in the
> > > >> > config file
> > > >> > > with this:
> > > >> > > >> >>>> >
> > > >> > > >> >>>> >     <preference name="webView"
> > > >> > > >> >>>> > value="org.apache.cordova.engine.crosswalk.XWalkCordo
> > > >> > > >> >>>> > va
> > > >> > > >> >>>> > Web
> > > >> > > >> >>>> > View
> > > >> > > >> >>>> > " />
> > > >> > > >> >>>> >
> > > >> > > >> >>>> > You currently have to copy over the *.pak file and
> > > >> > > >> >>>> > the jsapi from a Crosswalk Example project to get
> > > >> > > >> >>>> > this to work.  The next thing that I'm going to do is
> > > >> > > >> >>>> > figure out how to write this as a plugin and have it
> > > >> > > >> >>>> > install on a default
> > > project.
> > > >> > > >> >>>> > Also, right now the bridge doesn't seem to work, and
> > > >> > > >> >>>> > I don't know why exactly.  That being said, the
> > > >> > > >> fact
> > > >> > > >> >>>> > that I can choose which version of Chrome/Chromium
> > > >> > > >> >>>> > I'm running with
> > > >> > > >> a
> > > >> > > >> >>>> > single XML preference is HUGE.
> > > >> > > >> >>>> >
> > > >> > > >> >>>> > There's definitely a lot more work that needs to be
> > > >> > > >> >>>> > done, but as
> > > >> > > >> long
> > > >> > > >> >>>> > as we have something that we can fit into the
> > > >> > > >> >>>> > interface, we should
> > > >> > > >> be
> > > >> > > >> >>>> > able to put in things like GeckoView or other third
> > > >> > > >> >>>> > party
> > > >> > renderers.
> > > >> > > >> >>>> > The nightmare of being stuck with bullshit WebView
> > > >> > > >> >>>> > bugs may soon be over.
> > > >> > > >> >>>> >
> > > >> > > >> >>>> > On Wed, Mar 5, 2014 at 8:59 PM, Michal Mocny
> > > >> > > >> >>>> > <mm...@chromium.org>
> > > >> > > >> >>>> wrote:
> > > >> > > >> >>>> >> https://github.com/crosswalk-project/crosswalk-cordo
> > > >> > > >> >>>> >> va
> > > >> > > >> >>>> >> -an
> > > >> > > >> >>>> >> droi
> > > >> > > >> >>>> >> d
> > > >> > > >> >>>> >>
> > > >> > > >> >>>> >> First patch they landed, which claims to have min
> > > >> > > >> >>>> >> viable xwalk
> > > >> > > >> webview:
> > > >> > > >> >>>> >>
> > > >> > > >> >>>>
> > > >> > > >> https://github.com/crosswalk-project/crosswalk-cordova-andro
> > > >> > > >> id
> > > >> > > >> /co
> > > >> > > >> mmit
> > > >> > > >> /a04dedeb0204e7542d190312c6ae70c795a26e04
> > > >> > > >> >>>> >>
> > > >> > > >> >>>> >>
> > > >> > > >> >>>> >> On Wed, Mar 5, 2014 at 11:37 PM, Michal Mocny
> > > >> > > >> >>>> >> <mmocny@chromium.org
> > > >> > > >> >
> > > >> > > >> >>>> wrote:
> > > >> > > >> >>>> >>
> > > >> > > >> >>>> >>> I haven't looked yet, but did you see:
> > > >> > > >> >>>> >>> https://crosswalk-project.org/#wiki/crosswalk-cordo
> > > >> > > >> >>>> >>> va
> > > >> > > >> >>>> >>> -an
> > > >> > > >> >>>> >>> droi
> > > >> > > >> >>>> >>> d
> > > >> > > >> >>>> >>>
> > > >> > > >> >>>> >>> ?
> > > >> > > >> >>>> >>>
> > > >> > > >> >>>> >>>
> > > >> > > >> >>>> >>> On Wed, Mar 5, 2014 at 10:20 PM, Andrew Grieve <
> > > >> > > >> agrieve@chromium.org
> > > >> > > >> >>>> >wrote:
> > > >> > > >> >>>> >>>
> > > >> > > >> >>>> >>>> First - very excited that you're working on this!
> > > >> > > >> >>>> >>>>
> > > >> > > >> >>>> >>>> Had a quick look. Not sure there's much to be
> gleaned
> > yet.
> > > >> > > >> >>>> >>>> Once
> > > >> > > >> you
> > > >> > > >> >>>> start
> > > >> > > >> >>>> >>>> in on hooking up x-walk's webview I think it will
> > > >> > > >> >>>> >>>> become more
> > > >> > > >> obvious
> > > >> > > >> >>>> what
> > > >> > > >> >>>> >>>> the interface should look like. E.g., does x-walk
> > > >> > > >> >>>> >>>> even have the
> > > >> > > >> >>>> concept of
> > > >> > > >> >>>> >>>> ChromeClient vs WebViewClient vs WebView? Also
> > > >> > > >> >>>> >>>> unsure whether the
> > > >> > > >> >>>> class
> > > >> > > >> >>>> >>>> should extend android.View as well as implement
> > > >> > > >> >>>> >>>> our
> > > >> > interface.
> > > >> > > >> E.g.
> > > >> > > >> >>>> >>>> alternative is to have a "getView()" method on the
> > > >> > interface.
> > > >> > > >> Might
> > > >> > > >> >>>> help
> > > >> > > >> >>>> >>>> to
> > > >> > > >> >>>> >>>> cut down on file sizes, and API surface, but
> > > >> > > >> >>>> >>>> again, I'm not too
> > > >> > > >> sure.
> > > >> > > >> >>>> >>>>
> > > >> > > >> >>>> >>>> I've been pretty hesitant to touch existing
> > > >> > > >> >>>> >>>> exposed members
> > > >> > > >> (e.g. the
> > > >> > > >> >>>> >>>> public fields you were referring to) since
> > > >> > > >> >>>> >>>> touching anything
> > > >> > > >> public
> > > >> > > >> >>>> could
> > > >> > > >> >>>> >>>> break plugins. That said, maybe now is a good time
> > > >> > > >> >>>> >>>> to @deprecate
> > > >> > > >> a
> > > >> > > >> >>>> bunch
> > > >> > > >> >>>> >>>> of
> > > >> > > >> >>>> >>>> them and either replace them with getters, or just
> > > >> > > >> >>>> >>>> declare them
> > > >> > > >> to be
> > > >> > > >> >>>> not
> > > >> > > >> >>>> >>>> exposed to plugins.
> > > >> > > >> >>>> >>>>
> > > >> > > >> >>>> >>>>
> > > >> > > >> >>>> >>>> On Wed, Mar 5, 2014 at 6:57 PM, Joe Bowser
> > > >> > > >> >>>> >>>> <bo...@gmail.com>
> > > >> > > >> wrote:
> > > >> > > >> >>>> >>>>
> > > >> > > >> >>>> >>>> > So, after looking at the Crosswalk code again,
> > > >> > > >> >>>> >>>> > I've decided to
> > > >> > > >> take
> > > >> > > >> >>>> a
> > > >> > > >> >>>> >>>> > quick stab at making things pluggable.  I don't
> > > >> > > >> >>>> >>>> > have a lot to
> > > >> > > >> show
> > > >> > > >> >>>> for
> > > >> > > >> >>>> >>>> > it, but with the help of Eclipse (which is why
> > > >> > > >> >>>> >>>> > the generated interfaces look so screwed up), I
> > > >> > > >> >>>> >>>> > managed to create some
> > > >> > > >> interfaces
> > > >> > > >> >>>> so
> > > >> > > >> >>>> >>>> > we can start shoehorning in other browser
> renderers.
> > > >> > > >> >>>> >>>> >
> > > >> > > >> >>>> >>>> >
> > > >> > > >> https://github.com/infil00p/cordova-android/tree/pluggable_w
> > > >> > > >> eb
> > > >> > > >> vie
> > > >> > > >> w
> > > >> > > >> >>>> >>>> >
> > > >> > > >> >>>> >>>> > I'm going to probably start with Crosswalk,
> > > >> > > >> >>>> >>>> > because it's
> > > >> > > >> probably
> > > >> > > >> >>>> the
> > > >> > > >> >>>> >>>> > most mature primary candidate in the Android
> > > >> > > >> >>>> >>>> > Third-Party
> > > >> > > >> WebView
> > > >> > > >> >>>> >>>> > thing, and I'm pretty sure the GeckoView will be
> > > >> > > >> >>>> >>>> > happening
> > > >> > > >> shortly
> > > >> > > >> >>>> >>>> > after.
> > > >> > > >> >>>> >>>> >
> > > >> > > >> >>>> >>>> > I don't know how this would work w.r.t. the CLI
> > > >> > > >> >>>> >>>> > or our
> > > >> > > >> workflow at
> > > >> > > >> >>>> >>>> > all, but at the moment, I really just want to at
> > > >> > > >> >>>> >>>> > least start
> > > >> > > >> to have
> > > >> > > >> >>>> >>>> > some headway towards 4.x and PhoneGap day.
> > > >> > > >> >>>> >>>> >
> > > >> > > >> >>>> >>>> > What do people think of this so far? I'm going
> > > >> > > >> >>>> >>>> > to try to clean
> > > >> > > >> >>>> things
> > > >> > > >> >>>> >>>> > up a bit, since we've definitely done a lot of
> > > >> > > >> >>>> >>>> > things that
> > > >> > > >> would
> > > >> > > >> >>>> make
> > > >> > > >> >>>> >>>> > first year CS profs freak the hell out (i.e.
> > > >> > > >> >>>> >>>> > public members in
> > > >> > > >> >>>> public
> > > >> > > >> >>>> >>>> > objects w.r.t. PluginManager).
> > > >> > > >> >>>> >>>> >
> > > >> > > >> >>>> >>>> > Thoughts?
> > > >> > > >> >>>> >>>> >
> > > >> > > >> >>>> >>>> > Joe
> > > >> > > >> >>>> >>>> >
> > > >> > > >> >>>> >>>>
> > > >> > > >> >>>> >>>
> > > >> > > >> >>>> >>>
> > > >> > > >> >>>>
> > > >> > > >>
> > > >> >
>

RE: [Android] Refactoring for different engines

["Hu, Ningxin" <ni...@intel.com>]

Joe,

Thanks for your review and merge the PRs.

To pluggable webview interest group:
Are we OK to setup a hangout this week for initial introduction and discussion of next steps?

Thanks,
-ningxin

> -----Original Message-----
> From: Hu, Ningxin [mailto:ningxin.hu@intel.com]
> Sent: Tuesday, April 22, 2014 4:04 PM
> To: dev@cordova.apache.org
> Subject: RE: [Android] Refactoring for different engines
> 
> The PoC is great! Quite excited about the direction!
> 
> I've sent a PR to update the cordova-crosswalk-engine to latest crosswalk
> embedding API. It works with xwalk_core_library at 6.35.124.0.
> 
> I've also changed the CordovaWebView interface slightly (adding getView() API)
> to allow XWalkCordovaWebView to composite a XWalkView instead of extending
> it. It resolves some API naming issues for XWalkView case.
> 
> Please review them at:
> https://github.com/infil00p/cordova-crosswalk-engine/pull/3
> https://github.com/infil00p/cordova-android/pull/2
> 
> Thanks,
> -ningxin
> 
> > -----Original Message-----
> > From: Joe Bowser [mailto:bowserj@gmail.com]
> > Sent: Friday, April 11, 2014 12:45 AM
> > To: dev
> > Subject: Re: [Android] Refactoring for different engines
> >
> > Yeah, I'd be cool with setting up a hangout.  Everyone should take a
> > look at the PoC, I've basically distilled it down to four or five
> > classes so far, but with some work, we may be able to get it down to
> > three.  Due to legacy, we're pretty stuck with the Android WebView API calls,
> but these can probably be modified.
> >
> > It'd be good to get Mozilla people on the call as well, since they
> > have their WebView as well.
> >
> > On Thu, Apr 10, 2014 at 9:38 AM, Hu, Ningxin <ni...@intel.com> wrote:
> > > Hangout would be a good idea.
> > >
> > > FYI, I will be off next week. How about the week after next? If it
> > > works, please
> > feel free to schedule one and count me in.
> > >
> > > Thanks,
> > > -ningxin
> > >
> > >> -----Original Message-----
> > >> From: mmocny@google.com [mailto:mmocny@google.com] On Behalf Of
> > >> Michal Mocny
> > >> Sent: Tuesday, April 08, 2014 11:39 PM
> > >> To: dev
> > >> Subject: Re: [Android] Refactoring for different engines
> > >>
> > >> Would it be alright to set up a Hangout some time to introduce everyone?
> > >>
> > >> Joe has been leading the effort here, but there are other cordova
> > >> contributors for whom this is top priority.  It would be nice if we
> > >> could all meet to say hello and make sure we are all going in the
> > >> right
> > direction.
> > >>
> > >> Quite exciting!
> > >>
> > >> -Michal
> > >>
> > >>
> > >> On Tue, Apr 8, 2014 at 10:56 AM, Hu, Ningxin <ni...@intel.com>
> wrote:
> > >>
> > >> > Joe, thanks for this. I am very excited.
> > >> >
> > >> > FYI. Crosswalk team is working on refactoring the WebView API to
> > >> > support embedding usage better [1]. (Previously the layer API was
> > >> > not exposed as public usage).
> > >> >
> > >> > I would like to review the PoC and work with you to get Crosswalk
> > >> > fits into the pluggable WebView architecture.
> > >> >
> > >> > Thanks,
> > >> > -ningxin
> > >> >
> > >> > > -----Original Message-----
> > >> > > From: Joe Bowser [mailto:bowserj@gmail.com]
> > >> > > Sent: Wednesday, March 19, 2014 7:08 AM
> > >> > > To: dev
> > >> > > Subject: Re: [Android] Refactoring for different engines
> > >> > >
> > >> > > Hey
> > >> > >
> > >> > > After debugging, I did some minor updates to the plugin README.
> > >> > > It
> > >> > should be
> > >> > > easier to get this up and running, although there's still the
> > >> > > issue of
> > >> > after-install
> > >> > > hooks and the relative path weirdness with the Crosswalk Library itself.
> > >> > >
> > >> > > It still doesn't support the CLI at all, but it should be there
> > >> > > with the
> > >> > old flow.
> > >> > >
> > >> > > On Mon, Mar 17, 2014 at 1:14 PM, Michal Mocny
> > >> > > <mm...@chromium.org>
> > >> > > wrote:
> > >> > > > (Sorry Joe, Googlers are down in California and way busy.
> > >> > > > Will be back in a week.  Super excited about this, though.)
> > >> > > >
> > >> > > > -Michal
> > >> > > >
> > >> > > >
> > >> > > > On Mon, Mar 17, 2014 at 2:53 PM, Joe Bowser
> > >> > > > <bo...@gmail.com>
> > >> wrote:
> > >> > > >
> > >> > > >> Reviving this thread!
> > >> > > >>
> > >> > > >> Can other people look at this, and see if/when we should land this?
> > >> > > >> I know that I have to re-write the tests still, but I would
> > >> > > >> like some feedback before merging it in.  Also, it'd be
> > >> > > >> super awesome if other people could try and make a WebView
> > >> > > >> based on the interfaces and recommend which methods should
> > >> > > >> die.  I want to get this released in the next month or so,
> > >> > > >> so any time and feedback would be greatly appreciated.
> > >> > > >>
> > >> > > >> Thanks
> > >> > > >>
> > >> > > >> On Thu, Mar 13, 2014 at 3:50 PM, Joe Bowser
> > >> > > >> <bo...@gmail.com>
> > >> > wrote:
> > >> > > >> > Hey, I created the following today to track various
> > >> > > >> > WebView
> > >> > progresses:
> > >> > > >> > https://issues.apache.org/jira/browse/CB-6246
> > >> > > >> >
> > >> > > >> > I also have this repo created.  The licensing is ugly as
> > >> > > >> > all crap, but it's a Proof-Of-Concept:
> > >> > > >> > https://github.com/infil00p/cordova-crosswalk-engine
> > >> > > >> >
> > >> > > >> > If I can get some help getting plugman to just load
> > >> > > >> > Crosswalk, it'll
> > >> > > >> look hawt.
> > >> > > >> >
> > >> > > >> > BTW: We should probably get this ready to go into Android
> > >> > > >> > in the next two months and deprecate the setProperty
> > >> > > >> > methods, since all properties should be preferences in config.xml
> now.
> > >> > > >> >
> > >> > > >> > On Mon, Mar 10, 2014 at 2:42 PM, Joe Bowser
> > >> > > >> > <bo...@gmail.com>
> > >> > > wrote:
> > >> > > >> >> Perhaps. There would be additional benefits to this
> > >> > > >> >> approach, namely fixes being added to that platform more
> > >> > > >> >> quickly.  I'll probably take a look at that once I have
> > >> > > >> >> Crosswalk
> > finalized.
> > >> > > >> >>
> > >> > > >> >> On Mon, Mar 10, 2014 at 9:49 AM, Brian LeRoux
> > >> > > >> >> <b...@brian.io>
> > wrote:
> > >> > > >> >>> this is great stuff
> > >> > > >> >>>
> > >> > > >> >>> do we think it may be possible to bring in amazon fireos
> > >> > > >> >>> stuff
> > >> > > >> eventually
> > >> > > >> >>> too?
> > >> > > >> >>>
> > >> > > >> >>>
> > >> > > >> >>> On Fri, Mar 7, 2014 at 3:22 PM, Joe Bowser
> > >> > > >> >>> <bo...@gmail.com>
> > >> > wrote:
> > >> > > >> >>>
> > >> > > >> >>>> BTW: I committed it in my repo, not the main Apache one.
> > >> > > >> >>>>
> > >> > > >> >>>> On Fri, Mar 7, 2014 at 3:21 PM, Joe Bowser
> > >> > > >> >>>> <bo...@gmail.com>
> > >> > > wrote:
> > >> > > >> >>>> > Hey
> > >> > > >> >>>> >
> > >> > > >> >>>> > I just committed some code based on their WebView
> > >> > > >> >>>> > modifications that allows you to choose your renderer
> > >> > > >> >>>> > in the
> > >> > config file
> > >> > > with this:
> > >> > > >> >>>> >
> > >> > > >> >>>> >     <preference name="webView"
> > >> > > >> >>>> > value="org.apache.cordova.engine.crosswalk.XWalkCordo
> > >> > > >> >>>> > va
> > >> > > >> >>>> > Web
> > >> > > >> >>>> > View
> > >> > > >> >>>> > " />
> > >> > > >> >>>> >
> > >> > > >> >>>> > You currently have to copy over the *.pak file and
> > >> > > >> >>>> > the jsapi from a Crosswalk Example project to get
> > >> > > >> >>>> > this to work.  The next thing that I'm going to do is
> > >> > > >> >>>> > figure out how to write this as a plugin and have it
> > >> > > >> >>>> > install on a default
> > project.
> > >> > > >> >>>> > Also, right now the bridge doesn't seem to work, and
> > >> > > >> >>>> > I don't know why exactly.  That being said, the
> > >> > > >> fact
> > >> > > >> >>>> > that I can choose which version of Chrome/Chromium
> > >> > > >> >>>> > I'm running with
> > >> > > >> a
> > >> > > >> >>>> > single XML preference is HUGE.
> > >> > > >> >>>> >
> > >> > > >> >>>> > There's definitely a lot more work that needs to be
> > >> > > >> >>>> > done, but as
> > >> > > >> long
> > >> > > >> >>>> > as we have something that we can fit into the
> > >> > > >> >>>> > interface, we should
> > >> > > >> be
> > >> > > >> >>>> > able to put in things like GeckoView or other third
> > >> > > >> >>>> > party
> > >> > renderers.
> > >> > > >> >>>> > The nightmare of being stuck with bullshit WebView
> > >> > > >> >>>> > bugs may soon be over.
> > >> > > >> >>>> >
> > >> > > >> >>>> > On Wed, Mar 5, 2014 at 8:59 PM, Michal Mocny
> > >> > > >> >>>> > <mm...@chromium.org>
> > >> > > >> >>>> wrote:
> > >> > > >> >>>> >> https://github.com/crosswalk-project/crosswalk-cordo
> > >> > > >> >>>> >> va
> > >> > > >> >>>> >> -an
> > >> > > >> >>>> >> droi
> > >> > > >> >>>> >> d
> > >> > > >> >>>> >>
> > >> > > >> >>>> >> First patch they landed, which claims to have min
> > >> > > >> >>>> >> viable xwalk
> > >> > > >> webview:
> > >> > > >> >>>> >>
> > >> > > >> >>>>
> > >> > > >> https://github.com/crosswalk-project/crosswalk-cordova-andro
> > >> > > >> id
> > >> > > >> /co
> > >> > > >> mmit
> > >> > > >> /a04dedeb0204e7542d190312c6ae70c795a26e04
> > >> > > >> >>>> >>
> > >> > > >> >>>> >>
> > >> > > >> >>>> >> On Wed, Mar 5, 2014 at 11:37 PM, Michal Mocny
> > >> > > >> >>>> >> <mmocny@chromium.org
> > >> > > >> >
> > >> > > >> >>>> wrote:
> > >> > > >> >>>> >>
> > >> > > >> >>>> >>> I haven't looked yet, but did you see:
> > >> > > >> >>>> >>> https://crosswalk-project.org/#wiki/crosswalk-cordo
> > >> > > >> >>>> >>> va
> > >> > > >> >>>> >>> -an
> > >> > > >> >>>> >>> droi
> > >> > > >> >>>> >>> d
> > >> > > >> >>>> >>>
> > >> > > >> >>>> >>> ?
> > >> > > >> >>>> >>>
> > >> > > >> >>>> >>>
> > >> > > >> >>>> >>> On Wed, Mar 5, 2014 at 10:20 PM, Andrew Grieve <
> > >> > > >> agrieve@chromium.org
> > >> > > >> >>>> >wrote:
> > >> > > >> >>>> >>>
> > >> > > >> >>>> >>>> First - very excited that you're working on this!
> > >> > > >> >>>> >>>>
> > >> > > >> >>>> >>>> Had a quick look. Not sure there's much to be gleaned
> yet.
> > >> > > >> >>>> >>>> Once
> > >> > > >> you
> > >> > > >> >>>> start
> > >> > > >> >>>> >>>> in on hooking up x-walk's webview I think it will
> > >> > > >> >>>> >>>> become more
> > >> > > >> obvious
> > >> > > >> >>>> what
> > >> > > >> >>>> >>>> the interface should look like. E.g., does x-walk
> > >> > > >> >>>> >>>> even have the
> > >> > > >> >>>> concept of
> > >> > > >> >>>> >>>> ChromeClient vs WebViewClient vs WebView? Also
> > >> > > >> >>>> >>>> unsure whether the
> > >> > > >> >>>> class
> > >> > > >> >>>> >>>> should extend android.View as well as implement
> > >> > > >> >>>> >>>> our
> > >> > interface.
> > >> > > >> E.g.
> > >> > > >> >>>> >>>> alternative is to have a "getView()" method on the
> > >> > interface.
> > >> > > >> Might
> > >> > > >> >>>> help
> > >> > > >> >>>> >>>> to
> > >> > > >> >>>> >>>> cut down on file sizes, and API surface, but
> > >> > > >> >>>> >>>> again, I'm not too
> > >> > > >> sure.
> > >> > > >> >>>> >>>>
> > >> > > >> >>>> >>>> I've been pretty hesitant to touch existing
> > >> > > >> >>>> >>>> exposed members
> > >> > > >> (e.g. the
> > >> > > >> >>>> >>>> public fields you were referring to) since
> > >> > > >> >>>> >>>> touching anything
> > >> > > >> public
> > >> > > >> >>>> could
> > >> > > >> >>>> >>>> break plugins. That said, maybe now is a good time
> > >> > > >> >>>> >>>> to @deprecate
> > >> > > >> a
> > >> > > >> >>>> bunch
> > >> > > >> >>>> >>>> of
> > >> > > >> >>>> >>>> them and either replace them with getters, or just
> > >> > > >> >>>> >>>> declare them
> > >> > > >> to be
> > >> > > >> >>>> not
> > >> > > >> >>>> >>>> exposed to plugins.
> > >> > > >> >>>> >>>>
> > >> > > >> >>>> >>>>
> > >> > > >> >>>> >>>> On Wed, Mar 5, 2014 at 6:57 PM, Joe Bowser
> > >> > > >> >>>> >>>> <bo...@gmail.com>
> > >> > > >> wrote:
> > >> > > >> >>>> >>>>
> > >> > > >> >>>> >>>> > So, after looking at the Crosswalk code again,
> > >> > > >> >>>> >>>> > I've decided to
> > >> > > >> take
> > >> > > >> >>>> a
> > >> > > >> >>>> >>>> > quick stab at making things pluggable.  I don't
> > >> > > >> >>>> >>>> > have a lot to
> > >> > > >> show
> > >> > > >> >>>> for
> > >> > > >> >>>> >>>> > it, but with the help of Eclipse (which is why
> > >> > > >> >>>> >>>> > the generated interfaces look so screwed up), I
> > >> > > >> >>>> >>>> > managed to create some
> > >> > > >> interfaces
> > >> > > >> >>>> so
> > >> > > >> >>>> >>>> > we can start shoehorning in other browser renderers.
> > >> > > >> >>>> >>>> >
> > >> > > >> >>>> >>>> >
> > >> > > >> https://github.com/infil00p/cordova-android/tree/pluggable_w
> > >> > > >> eb
> > >> > > >> vie
> > >> > > >> w
> > >> > > >> >>>> >>>> >
> > >> > > >> >>>> >>>> > I'm going to probably start with Crosswalk,
> > >> > > >> >>>> >>>> > because it's
> > >> > > >> probably
> > >> > > >> >>>> the
> > >> > > >> >>>> >>>> > most mature primary candidate in the Android
> > >> > > >> >>>> >>>> > Third-Party
> > >> > > >> WebView
> > >> > > >> >>>> >>>> > thing, and I'm pretty sure the GeckoView will be
> > >> > > >> >>>> >>>> > happening
> > >> > > >> shortly
> > >> > > >> >>>> >>>> > after.
> > >> > > >> >>>> >>>> >
> > >> > > >> >>>> >>>> > I don't know how this would work w.r.t. the CLI
> > >> > > >> >>>> >>>> > or our
> > >> > > >> workflow at
> > >> > > >> >>>> >>>> > all, but at the moment, I really just want to at
> > >> > > >> >>>> >>>> > least start
> > >> > > >> to have
> > >> > > >> >>>> >>>> > some headway towards 4.x and PhoneGap day.
> > >> > > >> >>>> >>>> >
> > >> > > >> >>>> >>>> > What do people think of this so far? I'm going
> > >> > > >> >>>> >>>> > to try to clean
> > >> > > >> >>>> things
> > >> > > >> >>>> >>>> > up a bit, since we've definitely done a lot of
> > >> > > >> >>>> >>>> > things that
> > >> > > >> would
> > >> > > >> >>>> make
> > >> > > >> >>>> >>>> > first year CS profs freak the hell out (i.e.
> > >> > > >> >>>> >>>> > public members in
> > >> > > >> >>>> public
> > >> > > >> >>>> >>>> > objects w.r.t. PluginManager).
> > >> > > >> >>>> >>>> >
> > >> > > >> >>>> >>>> > Thoughts?
> > >> > > >> >>>> >>>> >
> > >> > > >> >>>> >>>> > Joe
> > >> > > >> >>>> >>>> >
> > >> > > >> >>>> >>>>
> > >> > > >> >>>> >>>
> > >> > > >> >>>> >>>
> > >> > > >> >>>>
> > >> > > >>
> > >> >

RE: [Android] Refactoring for different engines

["Hu, Ningxin" <ni...@intel.com>]

The PoC is great! Quite excited about the direction!

I've sent a PR to update the cordova-crosswalk-engine to latest crosswalk embedding API. It works with xwalk_core_library at 6.35.124.0.

I've also changed the CordovaWebView interface slightly (adding getView() API) to allow XWalkCordovaWebView to composite a XWalkView instead of extending it. It resolves some API naming issues for XWalkView case.

Please review them at:
https://github.com/infil00p/cordova-crosswalk-engine/pull/3
https://github.com/infil00p/cordova-android/pull/2

Thanks,
-ningxin

> -----Original Message-----
> From: Joe Bowser [mailto:bowserj@gmail.com]
> Sent: Friday, April 11, 2014 12:45 AM
> To: dev
> Subject: Re: [Android] Refactoring for different engines
> 
> Yeah, I'd be cool with setting up a hangout.  Everyone should take a look at the
> PoC, I've basically distilled it down to four or five classes so far, but with some
> work, we may be able to get it down to three.  Due to legacy, we're pretty stuck
> with the Android WebView API calls, but these can probably be modified.
> 
> It'd be good to get Mozilla people on the call as well, since they have their
> WebView as well.
> 
> On Thu, Apr 10, 2014 at 9:38 AM, Hu, Ningxin <ni...@intel.com> wrote:
> > Hangout would be a good idea.
> >
> > FYI, I will be off next week. How about the week after next? If it works, please
> feel free to schedule one and count me in.
> >
> > Thanks,
> > -ningxin
> >
> >> -----Original Message-----
> >> From: mmocny@google.com [mailto:mmocny@google.com] On Behalf Of
> >> Michal Mocny
> >> Sent: Tuesday, April 08, 2014 11:39 PM
> >> To: dev
> >> Subject: Re: [Android] Refactoring for different engines
> >>
> >> Would it be alright to set up a Hangout some time to introduce everyone?
> >>
> >> Joe has been leading the effort here, but there are other cordova
> >> contributors for whom this is top priority.  It would be nice if we
> >> could all meet to say hello and make sure we are all going in the right
> direction.
> >>
> >> Quite exciting!
> >>
> >> -Michal
> >>
> >>
> >> On Tue, Apr 8, 2014 at 10:56 AM, Hu, Ningxin <ni...@intel.com> wrote:
> >>
> >> > Joe, thanks for this. I am very excited.
> >> >
> >> > FYI. Crosswalk team is working on refactoring the WebView API to
> >> > support embedding usage better [1]. (Previously the layer API was
> >> > not exposed as public usage).
> >> >
> >> > I would like to review the PoC and work with you to get Crosswalk
> >> > fits into the pluggable WebView architecture.
> >> >
> >> > Thanks,
> >> > -ningxin
> >> >
> >> > > -----Original Message-----
> >> > > From: Joe Bowser [mailto:bowserj@gmail.com]
> >> > > Sent: Wednesday, March 19, 2014 7:08 AM
> >> > > To: dev
> >> > > Subject: Re: [Android] Refactoring for different engines
> >> > >
> >> > > Hey
> >> > >
> >> > > After debugging, I did some minor updates to the plugin README.
> >> > > It
> >> > should be
> >> > > easier to get this up and running, although there's still the
> >> > > issue of
> >> > after-install
> >> > > hooks and the relative path weirdness with the Crosswalk Library itself.
> >> > >
> >> > > It still doesn't support the CLI at all, but it should be there
> >> > > with the
> >> > old flow.
> >> > >
> >> > > On Mon, Mar 17, 2014 at 1:14 PM, Michal Mocny
> >> > > <mm...@chromium.org>
> >> > > wrote:
> >> > > > (Sorry Joe, Googlers are down in California and way busy.  Will
> >> > > > be back in a week.  Super excited about this, though.)
> >> > > >
> >> > > > -Michal
> >> > > >
> >> > > >
> >> > > > On Mon, Mar 17, 2014 at 2:53 PM, Joe Bowser <bo...@gmail.com>
> >> wrote:
> >> > > >
> >> > > >> Reviving this thread!
> >> > > >>
> >> > > >> Can other people look at this, and see if/when we should land this?
> >> > > >> I know that I have to re-write the tests still, but I would
> >> > > >> like some feedback before merging it in.  Also, it'd be super
> >> > > >> awesome if other people could try and make a WebView based on
> >> > > >> the interfaces and recommend which methods should die.  I want
> >> > > >> to get this released in the next month or so, so any time and
> >> > > >> feedback would be greatly appreciated.
> >> > > >>
> >> > > >> Thanks
> >> > > >>
> >> > > >> On Thu, Mar 13, 2014 at 3:50 PM, Joe Bowser
> >> > > >> <bo...@gmail.com>
> >> > wrote:
> >> > > >> > Hey, I created the following today to track various WebView
> >> > progresses:
> >> > > >> > https://issues.apache.org/jira/browse/CB-6246
> >> > > >> >
> >> > > >> > I also have this repo created.  The licensing is ugly as all
> >> > > >> > crap, but it's a Proof-Of-Concept:
> >> > > >> > https://github.com/infil00p/cordova-crosswalk-engine
> >> > > >> >
> >> > > >> > If I can get some help getting plugman to just load
> >> > > >> > Crosswalk, it'll
> >> > > >> look hawt.
> >> > > >> >
> >> > > >> > BTW: We should probably get this ready to go into Android in
> >> > > >> > the next two months and deprecate the setProperty methods,
> >> > > >> > since all properties should be preferences in config.xml now.
> >> > > >> >
> >> > > >> > On Mon, Mar 10, 2014 at 2:42 PM, Joe Bowser
> >> > > >> > <bo...@gmail.com>
> >> > > wrote:
> >> > > >> >> Perhaps. There would be additional benefits to this
> >> > > >> >> approach, namely fixes being added to that platform more
> >> > > >> >> quickly.  I'll probably take a look at that once I have Crosswalk
> finalized.
> >> > > >> >>
> >> > > >> >> On Mon, Mar 10, 2014 at 9:49 AM, Brian LeRoux <b...@brian.io>
> wrote:
> >> > > >> >>> this is great stuff
> >> > > >> >>>
> >> > > >> >>> do we think it may be possible to bring in amazon fireos
> >> > > >> >>> stuff
> >> > > >> eventually
> >> > > >> >>> too?
> >> > > >> >>>
> >> > > >> >>>
> >> > > >> >>> On Fri, Mar 7, 2014 at 3:22 PM, Joe Bowser
> >> > > >> >>> <bo...@gmail.com>
> >> > wrote:
> >> > > >> >>>
> >> > > >> >>>> BTW: I committed it in my repo, not the main Apache one.
> >> > > >> >>>>
> >> > > >> >>>> On Fri, Mar 7, 2014 at 3:21 PM, Joe Bowser
> >> > > >> >>>> <bo...@gmail.com>
> >> > > wrote:
> >> > > >> >>>> > Hey
> >> > > >> >>>> >
> >> > > >> >>>> > I just committed some code based on their WebView
> >> > > >> >>>> > modifications that allows you to choose your renderer
> >> > > >> >>>> > in the
> >> > config file
> >> > > with this:
> >> > > >> >>>> >
> >> > > >> >>>> >     <preference name="webView"
> >> > > >> >>>> > value="org.apache.cordova.engine.crosswalk.XWalkCordova
> >> > > >> >>>> > Web
> >> > > >> >>>> > View
> >> > > >> >>>> > " />
> >> > > >> >>>> >
> >> > > >> >>>> > You currently have to copy over the *.pak file and the
> >> > > >> >>>> > jsapi from a Crosswalk Example project to get this to
> >> > > >> >>>> > work.  The next thing that I'm going to do is figure
> >> > > >> >>>> > out how to write this as a plugin and have it install on a default
> project.
> >> > > >> >>>> > Also, right now the bridge doesn't seem to work, and I
> >> > > >> >>>> > don't know why exactly.  That being said, the
> >> > > >> fact
> >> > > >> >>>> > that I can choose which version of Chrome/Chromium I'm
> >> > > >> >>>> > running with
> >> > > >> a
> >> > > >> >>>> > single XML preference is HUGE.
> >> > > >> >>>> >
> >> > > >> >>>> > There's definitely a lot more work that needs to be
> >> > > >> >>>> > done, but as
> >> > > >> long
> >> > > >> >>>> > as we have something that we can fit into the
> >> > > >> >>>> > interface, we should
> >> > > >> be
> >> > > >> >>>> > able to put in things like GeckoView or other third
> >> > > >> >>>> > party
> >> > renderers.
> >> > > >> >>>> > The nightmare of being stuck with bullshit WebView bugs
> >> > > >> >>>> > may soon be over.
> >> > > >> >>>> >
> >> > > >> >>>> > On Wed, Mar 5, 2014 at 8:59 PM, Michal Mocny
> >> > > >> >>>> > <mm...@chromium.org>
> >> > > >> >>>> wrote:
> >> > > >> >>>> >> https://github.com/crosswalk-project/crosswalk-cordova
> >> > > >> >>>> >> -an
> >> > > >> >>>> >> droi
> >> > > >> >>>> >> d
> >> > > >> >>>> >>
> >> > > >> >>>> >> First patch they landed, which claims to have min
> >> > > >> >>>> >> viable xwalk
> >> > > >> webview:
> >> > > >> >>>> >>
> >> > > >> >>>>
> >> > > >> https://github.com/crosswalk-project/crosswalk-cordova-android
> >> > > >> /co
> >> > > >> mmit
> >> > > >> /a04dedeb0204e7542d190312c6ae70c795a26e04
> >> > > >> >>>> >>
> >> > > >> >>>> >>
> >> > > >> >>>> >> On Wed, Mar 5, 2014 at 11:37 PM, Michal Mocny
> >> > > >> >>>> >> <mmocny@chromium.org
> >> > > >> >
> >> > > >> >>>> wrote:
> >> > > >> >>>> >>
> >> > > >> >>>> >>> I haven't looked yet, but did you see:
> >> > > >> >>>> >>> https://crosswalk-project.org/#wiki/crosswalk-cordova
> >> > > >> >>>> >>> -an
> >> > > >> >>>> >>> droi
> >> > > >> >>>> >>> d
> >> > > >> >>>> >>>
> >> > > >> >>>> >>> ?
> >> > > >> >>>> >>>
> >> > > >> >>>> >>>
> >> > > >> >>>> >>> On Wed, Mar 5, 2014 at 10:20 PM, Andrew Grieve <
> >> > > >> agrieve@chromium.org
> >> > > >> >>>> >wrote:
> >> > > >> >>>> >>>
> >> > > >> >>>> >>>> First - very excited that you're working on this!
> >> > > >> >>>> >>>>
> >> > > >> >>>> >>>> Had a quick look. Not sure there's much to be gleaned yet.
> >> > > >> >>>> >>>> Once
> >> > > >> you
> >> > > >> >>>> start
> >> > > >> >>>> >>>> in on hooking up x-walk's webview I think it will
> >> > > >> >>>> >>>> become more
> >> > > >> obvious
> >> > > >> >>>> what
> >> > > >> >>>> >>>> the interface should look like. E.g., does x-walk
> >> > > >> >>>> >>>> even have the
> >> > > >> >>>> concept of
> >> > > >> >>>> >>>> ChromeClient vs WebViewClient vs WebView? Also
> >> > > >> >>>> >>>> unsure whether the
> >> > > >> >>>> class
> >> > > >> >>>> >>>> should extend android.View as well as implement our
> >> > interface.
> >> > > >> E.g.
> >> > > >> >>>> >>>> alternative is to have a "getView()" method on the
> >> > interface.
> >> > > >> Might
> >> > > >> >>>> help
> >> > > >> >>>> >>>> to
> >> > > >> >>>> >>>> cut down on file sizes, and API surface, but again,
> >> > > >> >>>> >>>> I'm not too
> >> > > >> sure.
> >> > > >> >>>> >>>>
> >> > > >> >>>> >>>> I've been pretty hesitant to touch existing exposed
> >> > > >> >>>> >>>> members
> >> > > >> (e.g. the
> >> > > >> >>>> >>>> public fields you were referring to) since touching
> >> > > >> >>>> >>>> anything
> >> > > >> public
> >> > > >> >>>> could
> >> > > >> >>>> >>>> break plugins. That said, maybe now is a good time
> >> > > >> >>>> >>>> to @deprecate
> >> > > >> a
> >> > > >> >>>> bunch
> >> > > >> >>>> >>>> of
> >> > > >> >>>> >>>> them and either replace them with getters, or just
> >> > > >> >>>> >>>> declare them
> >> > > >> to be
> >> > > >> >>>> not
> >> > > >> >>>> >>>> exposed to plugins.
> >> > > >> >>>> >>>>
> >> > > >> >>>> >>>>
> >> > > >> >>>> >>>> On Wed, Mar 5, 2014 at 6:57 PM, Joe Bowser
> >> > > >> >>>> >>>> <bo...@gmail.com>
> >> > > >> wrote:
> >> > > >> >>>> >>>>
> >> > > >> >>>> >>>> > So, after looking at the Crosswalk code again,
> >> > > >> >>>> >>>> > I've decided to
> >> > > >> take
> >> > > >> >>>> a
> >> > > >> >>>> >>>> > quick stab at making things pluggable.  I don't
> >> > > >> >>>> >>>> > have a lot to
> >> > > >> show
> >> > > >> >>>> for
> >> > > >> >>>> >>>> > it, but with the help of Eclipse (which is why the
> >> > > >> >>>> >>>> > generated interfaces look so screwed up), I
> >> > > >> >>>> >>>> > managed to create some
> >> > > >> interfaces
> >> > > >> >>>> so
> >> > > >> >>>> >>>> > we can start shoehorning in other browser renderers.
> >> > > >> >>>> >>>> >
> >> > > >> >>>> >>>> >
> >> > > >> https://github.com/infil00p/cordova-android/tree/pluggable_web
> >> > > >> vie
> >> > > >> w
> >> > > >> >>>> >>>> >
> >> > > >> >>>> >>>> > I'm going to probably start with Crosswalk,
> >> > > >> >>>> >>>> > because it's
> >> > > >> probably
> >> > > >> >>>> the
> >> > > >> >>>> >>>> > most mature primary candidate in the Android
> >> > > >> >>>> >>>> > Third-Party
> >> > > >> WebView
> >> > > >> >>>> >>>> > thing, and I'm pretty sure the GeckoView will be
> >> > > >> >>>> >>>> > happening
> >> > > >> shortly
> >> > > >> >>>> >>>> > after.
> >> > > >> >>>> >>>> >
> >> > > >> >>>> >>>> > I don't know how this would work w.r.t. the CLI or
> >> > > >> >>>> >>>> > our
> >> > > >> workflow at
> >> > > >> >>>> >>>> > all, but at the moment, I really just want to at
> >> > > >> >>>> >>>> > least start
> >> > > >> to have
> >> > > >> >>>> >>>> > some headway towards 4.x and PhoneGap day.
> >> > > >> >>>> >>>> >
> >> > > >> >>>> >>>> > What do people think of this so far? I'm going to
> >> > > >> >>>> >>>> > try to clean
> >> > > >> >>>> things
> >> > > >> >>>> >>>> > up a bit, since we've definitely done a lot of
> >> > > >> >>>> >>>> > things that
> >> > > >> would
> >> > > >> >>>> make
> >> > > >> >>>> >>>> > first year CS profs freak the hell out (i.e.
> >> > > >> >>>> >>>> > public members in
> >> > > >> >>>> public
> >> > > >> >>>> >>>> > objects w.r.t. PluginManager).
> >> > > >> >>>> >>>> >
> >> > > >> >>>> >>>> > Thoughts?
> >> > > >> >>>> >>>> >
> >> > > >> >>>> >>>> > Joe
> >> > > >> >>>> >>>> >
> >> > > >> >>>> >>>>
> >> > > >> >>>> >>>
> >> > > >> >>>> >>>
> >> > > >> >>>>
> >> > > >>
> >> >

Re: [Android] Refactoring for different engines

[Joe Bowser <bo...@gmail.com>]

Yeah, I'd be cool with setting up a hangout.  Everyone should take a
look at the PoC, I've basically distilled it down to four or five
classes so far, but with some work, we may be able to get it down to
three.  Due to legacy, we're pretty stuck with the Android WebView API
calls, but these can probably be modified.

It'd be good to get Mozilla people on the call as well, since they
have their WebView as well.

On Thu, Apr 10, 2014 at 9:38 AM, Hu, Ningxin <ni...@intel.com> wrote:
> Hangout would be a good idea.
>
> FYI, I will be off next week. How about the week after next? If it works, please feel free to schedule one and count me in.
>
> Thanks,
> -ningxin
>
>> -----Original Message-----
>> From: mmocny@google.com [mailto:mmocny@google.com] On Behalf Of Michal
>> Mocny
>> Sent: Tuesday, April 08, 2014 11:39 PM
>> To: dev
>> Subject: Re: [Android] Refactoring for different engines
>>
>> Would it be alright to set up a Hangout some time to introduce everyone?
>>
>> Joe has been leading the effort here, but there are other cordova contributors
>> for whom this is top priority.  It would be nice if we could all meet to say hello
>> and make sure we are all going in the right direction.
>>
>> Quite exciting!
>>
>> -Michal
>>
>>
>> On Tue, Apr 8, 2014 at 10:56 AM, Hu, Ningxin <ni...@intel.com> wrote:
>>
>> > Joe, thanks for this. I am very excited.
>> >
>> > FYI. Crosswalk team is working on refactoring the WebView API to
>> > support embedding usage better [1]. (Previously the layer API was not
>> > exposed as public usage).
>> >
>> > I would like to review the PoC and work with you to get Crosswalk fits
>> > into the pluggable WebView architecture.
>> >
>> > Thanks,
>> > -ningxin
>> >
>> > > -----Original Message-----
>> > > From: Joe Bowser [mailto:bowserj@gmail.com]
>> > > Sent: Wednesday, March 19, 2014 7:08 AM
>> > > To: dev
>> > > Subject: Re: [Android] Refactoring for different engines
>> > >
>> > > Hey
>> > >
>> > > After debugging, I did some minor updates to the plugin README.  It
>> > should be
>> > > easier to get this up and running, although there's still the issue
>> > > of
>> > after-install
>> > > hooks and the relative path weirdness with the Crosswalk Library itself.
>> > >
>> > > It still doesn't support the CLI at all, but it should be there with
>> > > the
>> > old flow.
>> > >
>> > > On Mon, Mar 17, 2014 at 1:14 PM, Michal Mocny <mm...@chromium.org>
>> > > wrote:
>> > > > (Sorry Joe, Googlers are down in California and way busy.  Will be
>> > > > back in a week.  Super excited about this, though.)
>> > > >
>> > > > -Michal
>> > > >
>> > > >
>> > > > On Mon, Mar 17, 2014 at 2:53 PM, Joe Bowser <bo...@gmail.com>
>> wrote:
>> > > >
>> > > >> Reviving this thread!
>> > > >>
>> > > >> Can other people look at this, and see if/when we should land this?
>> > > >> I know that I have to re-write the tests still, but I would like
>> > > >> some feedback before merging it in.  Also, it'd be super awesome
>> > > >> if other people could try and make a WebView based on the
>> > > >> interfaces and recommend which methods should die.  I want to get
>> > > >> this released in the next month or so, so any time and feedback
>> > > >> would be greatly appreciated.
>> > > >>
>> > > >> Thanks
>> > > >>
>> > > >> On Thu, Mar 13, 2014 at 3:50 PM, Joe Bowser <bo...@gmail.com>
>> > wrote:
>> > > >> > Hey, I created the following today to track various WebView
>> > progresses:
>> > > >> > https://issues.apache.org/jira/browse/CB-6246
>> > > >> >
>> > > >> > I also have this repo created.  The licensing is ugly as all
>> > > >> > crap, but it's a Proof-Of-Concept:
>> > > >> > https://github.com/infil00p/cordova-crosswalk-engine
>> > > >> >
>> > > >> > If I can get some help getting plugman to just load Crosswalk,
>> > > >> > it'll
>> > > >> look hawt.
>> > > >> >
>> > > >> > BTW: We should probably get this ready to go into Android in
>> > > >> > the next two months and deprecate the setProperty methods,
>> > > >> > since all properties should be preferences in config.xml now.
>> > > >> >
>> > > >> > On Mon, Mar 10, 2014 at 2:42 PM, Joe Bowser <bo...@gmail.com>
>> > > wrote:
>> > > >> >> Perhaps. There would be additional benefits to this approach,
>> > > >> >> namely fixes being added to that platform more quickly.  I'll
>> > > >> >> probably take a look at that once I have Crosswalk finalized.
>> > > >> >>
>> > > >> >> On Mon, Mar 10, 2014 at 9:49 AM, Brian LeRoux <b...@brian.io> wrote:
>> > > >> >>> this is great stuff
>> > > >> >>>
>> > > >> >>> do we think it may be possible to bring in amazon fireos
>> > > >> >>> stuff
>> > > >> eventually
>> > > >> >>> too?
>> > > >> >>>
>> > > >> >>>
>> > > >> >>> On Fri, Mar 7, 2014 at 3:22 PM, Joe Bowser
>> > > >> >>> <bo...@gmail.com>
>> > wrote:
>> > > >> >>>
>> > > >> >>>> BTW: I committed it in my repo, not the main Apache one.
>> > > >> >>>>
>> > > >> >>>> On Fri, Mar 7, 2014 at 3:21 PM, Joe Bowser
>> > > >> >>>> <bo...@gmail.com>
>> > > wrote:
>> > > >> >>>> > Hey
>> > > >> >>>> >
>> > > >> >>>> > I just committed some code based on their WebView
>> > > >> >>>> > modifications that allows you to choose your renderer in
>> > > >> >>>> > the
>> > config file
>> > > with this:
>> > > >> >>>> >
>> > > >> >>>> >     <preference name="webView"
>> > > >> >>>> > value="org.apache.cordova.engine.crosswalk.XWalkCordovaWeb
>> > > >> >>>> > View
>> > > >> >>>> > " />
>> > > >> >>>> >
>> > > >> >>>> > You currently have to copy over the *.pak file and the
>> > > >> >>>> > jsapi from a Crosswalk Example project to get this to
>> > > >> >>>> > work.  The next thing that I'm going to do is figure out
>> > > >> >>>> > how to write this as a plugin and have it install on a default project.
>> > > >> >>>> > Also, right now the bridge doesn't seem to work, and I
>> > > >> >>>> > don't know why exactly.  That being said, the
>> > > >> fact
>> > > >> >>>> > that I can choose which version of Chrome/Chromium I'm
>> > > >> >>>> > running with
>> > > >> a
>> > > >> >>>> > single XML preference is HUGE.
>> > > >> >>>> >
>> > > >> >>>> > There's definitely a lot more work that needs to be done,
>> > > >> >>>> > but as
>> > > >> long
>> > > >> >>>> > as we have something that we can fit into the interface,
>> > > >> >>>> > we should
>> > > >> be
>> > > >> >>>> > able to put in things like GeckoView or other third party
>> > renderers.
>> > > >> >>>> > The nightmare of being stuck with bullshit WebView bugs
>> > > >> >>>> > may soon be over.
>> > > >> >>>> >
>> > > >> >>>> > On Wed, Mar 5, 2014 at 8:59 PM, Michal Mocny
>> > > >> >>>> > <mm...@chromium.org>
>> > > >> >>>> wrote:
>> > > >> >>>> >> https://github.com/crosswalk-project/crosswalk-cordova-an
>> > > >> >>>> >> droi
>> > > >> >>>> >> d
>> > > >> >>>> >>
>> > > >> >>>> >> First patch they landed, which claims to have min viable
>> > > >> >>>> >> xwalk
>> > > >> webview:
>> > > >> >>>> >>
>> > > >> >>>>
>> > > >> https://github.com/crosswalk-project/crosswalk-cordova-android/co
>> > > >> mmit
>> > > >> /a04dedeb0204e7542d190312c6ae70c795a26e04
>> > > >> >>>> >>
>> > > >> >>>> >>
>> > > >> >>>> >> On Wed, Mar 5, 2014 at 11:37 PM, Michal Mocny
>> > > >> >>>> >> <mmocny@chromium.org
>> > > >> >
>> > > >> >>>> wrote:
>> > > >> >>>> >>
>> > > >> >>>> >>> I haven't looked yet, but did you see:
>> > > >> >>>> >>> https://crosswalk-project.org/#wiki/crosswalk-cordova-an
>> > > >> >>>> >>> droi
>> > > >> >>>> >>> d
>> > > >> >>>> >>>
>> > > >> >>>> >>> ?
>> > > >> >>>> >>>
>> > > >> >>>> >>>
>> > > >> >>>> >>> On Wed, Mar 5, 2014 at 10:20 PM, Andrew Grieve <
>> > > >> agrieve@chromium.org
>> > > >> >>>> >wrote:
>> > > >> >>>> >>>
>> > > >> >>>> >>>> First - very excited that you're working on this!
>> > > >> >>>> >>>>
>> > > >> >>>> >>>> Had a quick look. Not sure there's much to be gleaned yet.
>> > > >> >>>> >>>> Once
>> > > >> you
>> > > >> >>>> start
>> > > >> >>>> >>>> in on hooking up x-walk's webview I think it will
>> > > >> >>>> >>>> become more
>> > > >> obvious
>> > > >> >>>> what
>> > > >> >>>> >>>> the interface should look like. E.g., does x-walk even
>> > > >> >>>> >>>> have the
>> > > >> >>>> concept of
>> > > >> >>>> >>>> ChromeClient vs WebViewClient vs WebView? Also unsure
>> > > >> >>>> >>>> whether the
>> > > >> >>>> class
>> > > >> >>>> >>>> should extend android.View as well as implement our
>> > interface.
>> > > >> E.g.
>> > > >> >>>> >>>> alternative is to have a "getView()" method on the
>> > interface.
>> > > >> Might
>> > > >> >>>> help
>> > > >> >>>> >>>> to
>> > > >> >>>> >>>> cut down on file sizes, and API surface, but again, I'm
>> > > >> >>>> >>>> not too
>> > > >> sure.
>> > > >> >>>> >>>>
>> > > >> >>>> >>>> I've been pretty hesitant to touch existing exposed
>> > > >> >>>> >>>> members
>> > > >> (e.g. the
>> > > >> >>>> >>>> public fields you were referring to) since touching
>> > > >> >>>> >>>> anything
>> > > >> public
>> > > >> >>>> could
>> > > >> >>>> >>>> break plugins. That said, maybe now is a good time to
>> > > >> >>>> >>>> @deprecate
>> > > >> a
>> > > >> >>>> bunch
>> > > >> >>>> >>>> of
>> > > >> >>>> >>>> them and either replace them with getters, or just
>> > > >> >>>> >>>> declare them
>> > > >> to be
>> > > >> >>>> not
>> > > >> >>>> >>>> exposed to plugins.
>> > > >> >>>> >>>>
>> > > >> >>>> >>>>
>> > > >> >>>> >>>> On Wed, Mar 5, 2014 at 6:57 PM, Joe Bowser
>> > > >> >>>> >>>> <bo...@gmail.com>
>> > > >> wrote:
>> > > >> >>>> >>>>
>> > > >> >>>> >>>> > So, after looking at the Crosswalk code again, I've
>> > > >> >>>> >>>> > decided to
>> > > >> take
>> > > >> >>>> a
>> > > >> >>>> >>>> > quick stab at making things pluggable.  I don't have
>> > > >> >>>> >>>> > a lot to
>> > > >> show
>> > > >> >>>> for
>> > > >> >>>> >>>> > it, but with the help of Eclipse (which is why the
>> > > >> >>>> >>>> > generated interfaces look so screwed up), I managed
>> > > >> >>>> >>>> > to create some
>> > > >> interfaces
>> > > >> >>>> so
>> > > >> >>>> >>>> > we can start shoehorning in other browser renderers.
>> > > >> >>>> >>>> >
>> > > >> >>>> >>>> >
>> > > >> https://github.com/infil00p/cordova-android/tree/pluggable_webvie
>> > > >> w
>> > > >> >>>> >>>> >
>> > > >> >>>> >>>> > I'm going to probably start with Crosswalk, because
>> > > >> >>>> >>>> > it's
>> > > >> probably
>> > > >> >>>> the
>> > > >> >>>> >>>> > most mature primary candidate in the Android
>> > > >> >>>> >>>> > Third-Party
>> > > >> WebView
>> > > >> >>>> >>>> > thing, and I'm pretty sure the GeckoView will be
>> > > >> >>>> >>>> > happening
>> > > >> shortly
>> > > >> >>>> >>>> > after.
>> > > >> >>>> >>>> >
>> > > >> >>>> >>>> > I don't know how this would work w.r.t. the CLI or
>> > > >> >>>> >>>> > our
>> > > >> workflow at
>> > > >> >>>> >>>> > all, but at the moment, I really just want to at
>> > > >> >>>> >>>> > least start
>> > > >> to have
>> > > >> >>>> >>>> > some headway towards 4.x and PhoneGap day.
>> > > >> >>>> >>>> >
>> > > >> >>>> >>>> > What do people think of this so far? I'm going to try
>> > > >> >>>> >>>> > to clean
>> > > >> >>>> things
>> > > >> >>>> >>>> > up a bit, since we've definitely done a lot of things
>> > > >> >>>> >>>> > that
>> > > >> would
>> > > >> >>>> make
>> > > >> >>>> >>>> > first year CS profs freak the hell out (i.e. public
>> > > >> >>>> >>>> > members in
>> > > >> >>>> public
>> > > >> >>>> >>>> > objects w.r.t. PluginManager).
>> > > >> >>>> >>>> >
>> > > >> >>>> >>>> > Thoughts?
>> > > >> >>>> >>>> >
>> > > >> >>>> >>>> > Joe
>> > > >> >>>> >>>> >
>> > > >> >>>> >>>>
>> > > >> >>>> >>>
>> > > >> >>>> >>>
>> > > >> >>>>
>> > > >>
>> >

RE: [Android] Refactoring for different engines

["Hu, Ningxin" <ni...@intel.com>]

Hangout would be a good idea. 

FYI, I will be off next week. How about the week after next? If it works, please feel free to schedule one and count me in.

Thanks,
-ningxin

> -----Original Message-----
> From: mmocny@google.com [mailto:mmocny@google.com] On Behalf Of Michal
> Mocny
> Sent: Tuesday, April 08, 2014 11:39 PM
> To: dev
> Subject: Re: [Android] Refactoring for different engines
> 
> Would it be alright to set up a Hangout some time to introduce everyone?
> 
> Joe has been leading the effort here, but there are other cordova contributors
> for whom this is top priority.  It would be nice if we could all meet to say hello
> and make sure we are all going in the right direction.
> 
> Quite exciting!
> 
> -Michal
> 
> 
> On Tue, Apr 8, 2014 at 10:56 AM, Hu, Ningxin <ni...@intel.com> wrote:
> 
> > Joe, thanks for this. I am very excited.
> >
> > FYI. Crosswalk team is working on refactoring the WebView API to
> > support embedding usage better [1]. (Previously the layer API was not
> > exposed as public usage).
> >
> > I would like to review the PoC and work with you to get Crosswalk fits
> > into the pluggable WebView architecture.
> >
> > Thanks,
> > -ningxin
> >
> > > -----Original Message-----
> > > From: Joe Bowser [mailto:bowserj@gmail.com]
> > > Sent: Wednesday, March 19, 2014 7:08 AM
> > > To: dev
> > > Subject: Re: [Android] Refactoring for different engines
> > >
> > > Hey
> > >
> > > After debugging, I did some minor updates to the plugin README.  It
> > should be
> > > easier to get this up and running, although there's still the issue
> > > of
> > after-install
> > > hooks and the relative path weirdness with the Crosswalk Library itself.
> > >
> > > It still doesn't support the CLI at all, but it should be there with
> > > the
> > old flow.
> > >
> > > On Mon, Mar 17, 2014 at 1:14 PM, Michal Mocny <mm...@chromium.org>
> > > wrote:
> > > > (Sorry Joe, Googlers are down in California and way busy.  Will be
> > > > back in a week.  Super excited about this, though.)
> > > >
> > > > -Michal
> > > >
> > > >
> > > > On Mon, Mar 17, 2014 at 2:53 PM, Joe Bowser <bo...@gmail.com>
> wrote:
> > > >
> > > >> Reviving this thread!
> > > >>
> > > >> Can other people look at this, and see if/when we should land this?
> > > >> I know that I have to re-write the tests still, but I would like
> > > >> some feedback before merging it in.  Also, it'd be super awesome
> > > >> if other people could try and make a WebView based on the
> > > >> interfaces and recommend which methods should die.  I want to get
> > > >> this released in the next month or so, so any time and feedback
> > > >> would be greatly appreciated.
> > > >>
> > > >> Thanks
> > > >>
> > > >> On Thu, Mar 13, 2014 at 3:50 PM, Joe Bowser <bo...@gmail.com>
> > wrote:
> > > >> > Hey, I created the following today to track various WebView
> > progresses:
> > > >> > https://issues.apache.org/jira/browse/CB-6246
> > > >> >
> > > >> > I also have this repo created.  The licensing is ugly as all
> > > >> > crap, but it's a Proof-Of-Concept:
> > > >> > https://github.com/infil00p/cordova-crosswalk-engine
> > > >> >
> > > >> > If I can get some help getting plugman to just load Crosswalk,
> > > >> > it'll
> > > >> look hawt.
> > > >> >
> > > >> > BTW: We should probably get this ready to go into Android in
> > > >> > the next two months and deprecate the setProperty methods,
> > > >> > since all properties should be preferences in config.xml now.
> > > >> >
> > > >> > On Mon, Mar 10, 2014 at 2:42 PM, Joe Bowser <bo...@gmail.com>
> > > wrote:
> > > >> >> Perhaps. There would be additional benefits to this approach,
> > > >> >> namely fixes being added to that platform more quickly.  I'll
> > > >> >> probably take a look at that once I have Crosswalk finalized.
> > > >> >>
> > > >> >> On Mon, Mar 10, 2014 at 9:49 AM, Brian LeRoux <b...@brian.io> wrote:
> > > >> >>> this is great stuff
> > > >> >>>
> > > >> >>> do we think it may be possible to bring in amazon fireos
> > > >> >>> stuff
> > > >> eventually
> > > >> >>> too?
> > > >> >>>
> > > >> >>>
> > > >> >>> On Fri, Mar 7, 2014 at 3:22 PM, Joe Bowser
> > > >> >>> <bo...@gmail.com>
> > wrote:
> > > >> >>>
> > > >> >>>> BTW: I committed it in my repo, not the main Apache one.
> > > >> >>>>
> > > >> >>>> On Fri, Mar 7, 2014 at 3:21 PM, Joe Bowser
> > > >> >>>> <bo...@gmail.com>
> > > wrote:
> > > >> >>>> > Hey
> > > >> >>>> >
> > > >> >>>> > I just committed some code based on their WebView
> > > >> >>>> > modifications that allows you to choose your renderer in
> > > >> >>>> > the
> > config file
> > > with this:
> > > >> >>>> >
> > > >> >>>> >     <preference name="webView"
> > > >> >>>> > value="org.apache.cordova.engine.crosswalk.XWalkCordovaWeb
> > > >> >>>> > View
> > > >> >>>> > " />
> > > >> >>>> >
> > > >> >>>> > You currently have to copy over the *.pak file and the
> > > >> >>>> > jsapi from a Crosswalk Example project to get this to
> > > >> >>>> > work.  The next thing that I'm going to do is figure out
> > > >> >>>> > how to write this as a plugin and have it install on a default project.
> > > >> >>>> > Also, right now the bridge doesn't seem to work, and I
> > > >> >>>> > don't know why exactly.  That being said, the
> > > >> fact
> > > >> >>>> > that I can choose which version of Chrome/Chromium I'm
> > > >> >>>> > running with
> > > >> a
> > > >> >>>> > single XML preference is HUGE.
> > > >> >>>> >
> > > >> >>>> > There's definitely a lot more work that needs to be done,
> > > >> >>>> > but as
> > > >> long
> > > >> >>>> > as we have something that we can fit into the interface,
> > > >> >>>> > we should
> > > >> be
> > > >> >>>> > able to put in things like GeckoView or other third party
> > renderers.
> > > >> >>>> > The nightmare of being stuck with bullshit WebView bugs
> > > >> >>>> > may soon be over.
> > > >> >>>> >
> > > >> >>>> > On Wed, Mar 5, 2014 at 8:59 PM, Michal Mocny
> > > >> >>>> > <mm...@chromium.org>
> > > >> >>>> wrote:
> > > >> >>>> >> https://github.com/crosswalk-project/crosswalk-cordova-an
> > > >> >>>> >> droi
> > > >> >>>> >> d
> > > >> >>>> >>
> > > >> >>>> >> First patch they landed, which claims to have min viable
> > > >> >>>> >> xwalk
> > > >> webview:
> > > >> >>>> >>
> > > >> >>>>
> > > >> https://github.com/crosswalk-project/crosswalk-cordova-android/co
> > > >> mmit
> > > >> /a04dedeb0204e7542d190312c6ae70c795a26e04
> > > >> >>>> >>
> > > >> >>>> >>
> > > >> >>>> >> On Wed, Mar 5, 2014 at 11:37 PM, Michal Mocny
> > > >> >>>> >> <mmocny@chromium.org
> > > >> >
> > > >> >>>> wrote:
> > > >> >>>> >>
> > > >> >>>> >>> I haven't looked yet, but did you see:
> > > >> >>>> >>> https://crosswalk-project.org/#wiki/crosswalk-cordova-an
> > > >> >>>> >>> droi
> > > >> >>>> >>> d
> > > >> >>>> >>>
> > > >> >>>> >>> ?
> > > >> >>>> >>>
> > > >> >>>> >>>
> > > >> >>>> >>> On Wed, Mar 5, 2014 at 10:20 PM, Andrew Grieve <
> > > >> agrieve@chromium.org
> > > >> >>>> >wrote:
> > > >> >>>> >>>
> > > >> >>>> >>>> First - very excited that you're working on this!
> > > >> >>>> >>>>
> > > >> >>>> >>>> Had a quick look. Not sure there's much to be gleaned yet.
> > > >> >>>> >>>> Once
> > > >> you
> > > >> >>>> start
> > > >> >>>> >>>> in on hooking up x-walk's webview I think it will
> > > >> >>>> >>>> become more
> > > >> obvious
> > > >> >>>> what
> > > >> >>>> >>>> the interface should look like. E.g., does x-walk even
> > > >> >>>> >>>> have the
> > > >> >>>> concept of
> > > >> >>>> >>>> ChromeClient vs WebViewClient vs WebView? Also unsure
> > > >> >>>> >>>> whether the
> > > >> >>>> class
> > > >> >>>> >>>> should extend android.View as well as implement our
> > interface.
> > > >> E.g.
> > > >> >>>> >>>> alternative is to have a "getView()" method on the
> > interface.
> > > >> Might
> > > >> >>>> help
> > > >> >>>> >>>> to
> > > >> >>>> >>>> cut down on file sizes, and API surface, but again, I'm
> > > >> >>>> >>>> not too
> > > >> sure.
> > > >> >>>> >>>>
> > > >> >>>> >>>> I've been pretty hesitant to touch existing exposed
> > > >> >>>> >>>> members
> > > >> (e.g. the
> > > >> >>>> >>>> public fields you were referring to) since touching
> > > >> >>>> >>>> anything
> > > >> public
> > > >> >>>> could
> > > >> >>>> >>>> break plugins. That said, maybe now is a good time to
> > > >> >>>> >>>> @deprecate
> > > >> a
> > > >> >>>> bunch
> > > >> >>>> >>>> of
> > > >> >>>> >>>> them and either replace them with getters, or just
> > > >> >>>> >>>> declare them
> > > >> to be
> > > >> >>>> not
> > > >> >>>> >>>> exposed to plugins.
> > > >> >>>> >>>>
> > > >> >>>> >>>>
> > > >> >>>> >>>> On Wed, Mar 5, 2014 at 6:57 PM, Joe Bowser
> > > >> >>>> >>>> <bo...@gmail.com>
> > > >> wrote:
> > > >> >>>> >>>>
> > > >> >>>> >>>> > So, after looking at the Crosswalk code again, I've
> > > >> >>>> >>>> > decided to
> > > >> take
> > > >> >>>> a
> > > >> >>>> >>>> > quick stab at making things pluggable.  I don't have
> > > >> >>>> >>>> > a lot to
> > > >> show
> > > >> >>>> for
> > > >> >>>> >>>> > it, but with the help of Eclipse (which is why the
> > > >> >>>> >>>> > generated interfaces look so screwed up), I managed
> > > >> >>>> >>>> > to create some
> > > >> interfaces
> > > >> >>>> so
> > > >> >>>> >>>> > we can start shoehorning in other browser renderers.
> > > >> >>>> >>>> >
> > > >> >>>> >>>> >
> > > >> https://github.com/infil00p/cordova-android/tree/pluggable_webvie
> > > >> w
> > > >> >>>> >>>> >
> > > >> >>>> >>>> > I'm going to probably start with Crosswalk, because
> > > >> >>>> >>>> > it's
> > > >> probably
> > > >> >>>> the
> > > >> >>>> >>>> > most mature primary candidate in the Android
> > > >> >>>> >>>> > Third-Party
> > > >> WebView
> > > >> >>>> >>>> > thing, and I'm pretty sure the GeckoView will be
> > > >> >>>> >>>> > happening
> > > >> shortly
> > > >> >>>> >>>> > after.
> > > >> >>>> >>>> >
> > > >> >>>> >>>> > I don't know how this would work w.r.t. the CLI or
> > > >> >>>> >>>> > our
> > > >> workflow at
> > > >> >>>> >>>> > all, but at the moment, I really just want to at
> > > >> >>>> >>>> > least start
> > > >> to have
> > > >> >>>> >>>> > some headway towards 4.x and PhoneGap day.
> > > >> >>>> >>>> >
> > > >> >>>> >>>> > What do people think of this so far? I'm going to try
> > > >> >>>> >>>> > to clean
> > > >> >>>> things
> > > >> >>>> >>>> > up a bit, since we've definitely done a lot of things
> > > >> >>>> >>>> > that
> > > >> would
> > > >> >>>> make
> > > >> >>>> >>>> > first year CS profs freak the hell out (i.e. public
> > > >> >>>> >>>> > members in
> > > >> >>>> public
> > > >> >>>> >>>> > objects w.r.t. PluginManager).
> > > >> >>>> >>>> >
> > > >> >>>> >>>> > Thoughts?
> > > >> >>>> >>>> >
> > > >> >>>> >>>> > Joe
> > > >> >>>> >>>> >
> > > >> >>>> >>>>
> > > >> >>>> >>>
> > > >> >>>> >>>
> > > >> >>>>
> > > >>
> >

Re: [Android] Refactoring for different engines

[Michal Mocny <mm...@chromium.org>]

Would it be alright to set up a Hangout some time to introduce everyone?

Joe has been leading the effort here, but there are other cordova
contributors for whom this is top priority.  It would be nice if we could
all meet to say hello and make sure we are all going in the right direction.

Quite exciting!

-Michal


On Tue, Apr 8, 2014 at 10:56 AM, Hu, Ningxin <ni...@intel.com> wrote:

> Joe, thanks for this. I am very excited.
>
> FYI. Crosswalk team is working on refactoring the WebView API to support
> embedding usage better [1]. (Previously the layer API was not exposed as
> public usage).
>
> I would like to review the PoC and work with you to get Crosswalk fits
> into the pluggable WebView architecture.
>
> Thanks,
> -ningxin
>
> > -----Original Message-----
> > From: Joe Bowser [mailto:bowserj@gmail.com]
> > Sent: Wednesday, March 19, 2014 7:08 AM
> > To: dev
> > Subject: Re: [Android] Refactoring for different engines
> >
> > Hey
> >
> > After debugging, I did some minor updates to the plugin README.  It
> should be
> > easier to get this up and running, although there's still the issue of
> after-install
> > hooks and the relative path weirdness with the Crosswalk Library itself.
> >
> > It still doesn't support the CLI at all, but it should be there with the
> old flow.
> >
> > On Mon, Mar 17, 2014 at 1:14 PM, Michal Mocny <mm...@chromium.org>
> > wrote:
> > > (Sorry Joe, Googlers are down in California and way busy.  Will be
> > > back in a week.  Super excited about this, though.)
> > >
> > > -Michal
> > >
> > >
> > > On Mon, Mar 17, 2014 at 2:53 PM, Joe Bowser <bo...@gmail.com> wrote:
> > >
> > >> Reviving this thread!
> > >>
> > >> Can other people look at this, and see if/when we should land this?
> > >> I know that I have to re-write the tests still, but I would like some
> > >> feedback before merging it in.  Also, it'd be super awesome if other
> > >> people could try and make a WebView based on the interfaces and
> > >> recommend which methods should die.  I want to get this released in
> > >> the next month or so, so any time and feedback would be greatly
> > >> appreciated.
> > >>
> > >> Thanks
> > >>
> > >> On Thu, Mar 13, 2014 at 3:50 PM, Joe Bowser <bo...@gmail.com>
> wrote:
> > >> > Hey, I created the following today to track various WebView
> progresses:
> > >> > https://issues.apache.org/jira/browse/CB-6246
> > >> >
> > >> > I also have this repo created.  The licensing is ugly as all crap,
> > >> > but it's a Proof-Of-Concept:
> > >> > https://github.com/infil00p/cordova-crosswalk-engine
> > >> >
> > >> > If I can get some help getting plugman to just load Crosswalk,
> > >> > it'll
> > >> look hawt.
> > >> >
> > >> > BTW: We should probably get this ready to go into Android in the
> > >> > next two months and deprecate the setProperty methods, since all
> > >> > properties should be preferences in config.xml now.
> > >> >
> > >> > On Mon, Mar 10, 2014 at 2:42 PM, Joe Bowser <bo...@gmail.com>
> > wrote:
> > >> >> Perhaps. There would be additional benefits to this approach,
> > >> >> namely fixes being added to that platform more quickly.  I'll
> > >> >> probably take a look at that once I have Crosswalk finalized.
> > >> >>
> > >> >> On Mon, Mar 10, 2014 at 9:49 AM, Brian LeRoux <b...@brian.io> wrote:
> > >> >>> this is great stuff
> > >> >>>
> > >> >>> do we think it may be possible to bring in amazon fireos stuff
> > >> eventually
> > >> >>> too?
> > >> >>>
> > >> >>>
> > >> >>> On Fri, Mar 7, 2014 at 3:22 PM, Joe Bowser <bo...@gmail.com>
> wrote:
> > >> >>>
> > >> >>>> BTW: I committed it in my repo, not the main Apache one.
> > >> >>>>
> > >> >>>> On Fri, Mar 7, 2014 at 3:21 PM, Joe Bowser <bo...@gmail.com>
> > wrote:
> > >> >>>> > Hey
> > >> >>>> >
> > >> >>>> > I just committed some code based on their WebView
> > >> >>>> > modifications that allows you to choose your renderer in the
> config file
> > with this:
> > >> >>>> >
> > >> >>>> >     <preference name="webView"
> > >> >>>> > value="org.apache.cordova.engine.crosswalk.XWalkCordovaWebView
> > >> >>>> > " />
> > >> >>>> >
> > >> >>>> > You currently have to copy over the *.pak file and the jsapi
> > >> >>>> > from a Crosswalk Example project to get this to work.  The
> > >> >>>> > next thing that I'm going to do is figure out how to write
> > >> >>>> > this as a plugin and have it install on a default project.
> > >> >>>> > Also, right now the bridge doesn't seem to work, and I don't
> > >> >>>> > know why exactly.  That being said, the
> > >> fact
> > >> >>>> > that I can choose which version of Chrome/Chromium I'm running
> > >> >>>> > with
> > >> a
> > >> >>>> > single XML preference is HUGE.
> > >> >>>> >
> > >> >>>> > There's definitely a lot more work that needs to be done, but
> > >> >>>> > as
> > >> long
> > >> >>>> > as we have something that we can fit into the interface, we
> > >> >>>> > should
> > >> be
> > >> >>>> > able to put in things like GeckoView or other third party
> renderers.
> > >> >>>> > The nightmare of being stuck with bullshit WebView bugs may
> > >> >>>> > soon be over.
> > >> >>>> >
> > >> >>>> > On Wed, Mar 5, 2014 at 8:59 PM, Michal Mocny
> > >> >>>> > <mm...@chromium.org>
> > >> >>>> wrote:
> > >> >>>> >> https://github.com/crosswalk-project/crosswalk-cordova-androi
> > >> >>>> >> d
> > >> >>>> >>
> > >> >>>> >> First patch they landed, which claims to have min viable
> > >> >>>> >> xwalk
> > >> webview:
> > >> >>>> >>
> > >> >>>>
> > >> https://github.com/crosswalk-project/crosswalk-cordova-android/commit
> > >> /a04dedeb0204e7542d190312c6ae70c795a26e04
> > >> >>>> >>
> > >> >>>> >>
> > >> >>>> >> On Wed, Mar 5, 2014 at 11:37 PM, Michal Mocny
> > >> >>>> >> <mmocny@chromium.org
> > >> >
> > >> >>>> wrote:
> > >> >>>> >>
> > >> >>>> >>> I haven't looked yet, but did you see:
> > >> >>>> >>> https://crosswalk-project.org/#wiki/crosswalk-cordova-androi
> > >> >>>> >>> d
> > >> >>>> >>>
> > >> >>>> >>> ?
> > >> >>>> >>>
> > >> >>>> >>>
> > >> >>>> >>> On Wed, Mar 5, 2014 at 10:20 PM, Andrew Grieve <
> > >> agrieve@chromium.org
> > >> >>>> >wrote:
> > >> >>>> >>>
> > >> >>>> >>>> First - very excited that you're working on this!
> > >> >>>> >>>>
> > >> >>>> >>>> Had a quick look. Not sure there's much to be gleaned yet.
> > >> >>>> >>>> Once
> > >> you
> > >> >>>> start
> > >> >>>> >>>> in on hooking up x-walk's webview I think it will become
> > >> >>>> >>>> more
> > >> obvious
> > >> >>>> what
> > >> >>>> >>>> the interface should look like. E.g., does x-walk even have
> > >> >>>> >>>> the
> > >> >>>> concept of
> > >> >>>> >>>> ChromeClient vs WebViewClient vs WebView? Also unsure
> > >> >>>> >>>> whether the
> > >> >>>> class
> > >> >>>> >>>> should extend android.View as well as implement our
> interface.
> > >> E.g.
> > >> >>>> >>>> alternative is to have a "getView()" method on the
> interface.
> > >> Might
> > >> >>>> help
> > >> >>>> >>>> to
> > >> >>>> >>>> cut down on file sizes, and API surface, but again, I'm not
> > >> >>>> >>>> too
> > >> sure.
> > >> >>>> >>>>
> > >> >>>> >>>> I've been pretty hesitant to touch existing exposed members
> > >> (e.g. the
> > >> >>>> >>>> public fields you were referring to) since touching
> > >> >>>> >>>> anything
> > >> public
> > >> >>>> could
> > >> >>>> >>>> break plugins. That said, maybe now is a good time to
> > >> >>>> >>>> @deprecate
> > >> a
> > >> >>>> bunch
> > >> >>>> >>>> of
> > >> >>>> >>>> them and either replace them with getters, or just declare
> > >> >>>> >>>> them
> > >> to be
> > >> >>>> not
> > >> >>>> >>>> exposed to plugins.
> > >> >>>> >>>>
> > >> >>>> >>>>
> > >> >>>> >>>> On Wed, Mar 5, 2014 at 6:57 PM, Joe Bowser
> > >> >>>> >>>> <bo...@gmail.com>
> > >> wrote:
> > >> >>>> >>>>
> > >> >>>> >>>> > So, after looking at the Crosswalk code again, I've
> > >> >>>> >>>> > decided to
> > >> take
> > >> >>>> a
> > >> >>>> >>>> > quick stab at making things pluggable.  I don't have a
> > >> >>>> >>>> > lot to
> > >> show
> > >> >>>> for
> > >> >>>> >>>> > it, but with the help of Eclipse (which is why the
> > >> >>>> >>>> > generated interfaces look so screwed up), I managed to
> > >> >>>> >>>> > create some
> > >> interfaces
> > >> >>>> so
> > >> >>>> >>>> > we can start shoehorning in other browser renderers.
> > >> >>>> >>>> >
> > >> >>>> >>>> >
> > >> https://github.com/infil00p/cordova-android/tree/pluggable_webview
> > >> >>>> >>>> >
> > >> >>>> >>>> > I'm going to probably start with Crosswalk, because it's
> > >> probably
> > >> >>>> the
> > >> >>>> >>>> > most mature primary candidate in the Android Third-Party
> > >> WebView
> > >> >>>> >>>> > thing, and I'm pretty sure the GeckoView will be
> > >> >>>> >>>> > happening
> > >> shortly
> > >> >>>> >>>> > after.
> > >> >>>> >>>> >
> > >> >>>> >>>> > I don't know how this would work w.r.t. the CLI or our
> > >> workflow at
> > >> >>>> >>>> > all, but at the moment, I really just want to at least
> > >> >>>> >>>> > start
> > >> to have
> > >> >>>> >>>> > some headway towards 4.x and PhoneGap day.
> > >> >>>> >>>> >
> > >> >>>> >>>> > What do people think of this so far? I'm going to try to
> > >> >>>> >>>> > clean
> > >> >>>> things
> > >> >>>> >>>> > up a bit, since we've definitely done a lot of things
> > >> >>>> >>>> > that
> > >> would
> > >> >>>> make
> > >> >>>> >>>> > first year CS profs freak the hell out (i.e. public
> > >> >>>> >>>> > members in
> > >> >>>> public
> > >> >>>> >>>> > objects w.r.t. PluginManager).
> > >> >>>> >>>> >
> > >> >>>> >>>> > Thoughts?
> > >> >>>> >>>> >
> > >> >>>> >>>> > Joe
> > >> >>>> >>>> >
> > >> >>>> >>>>
> > >> >>>> >>>
> > >> >>>> >>>
> > >> >>>>
> > >>
>

RE: [Android] Refactoring for different engines

["Hu, Ningxin" <ni...@intel.com>]

Joe, thanks for this. I am very excited.

FYI. Crosswalk team is working on refactoring the WebView API to support embedding usage better [1]. (Previously the layer API was not exposed as public usage).

I would like to review the PoC and work with you to get Crosswalk fits into the pluggable WebView architecture.

Thanks,
-ningxin

> -----Original Message-----
> From: Joe Bowser [mailto:bowserj@gmail.com]
> Sent: Wednesday, March 19, 2014 7:08 AM
> To: dev
> Subject: Re: [Android] Refactoring for different engines
> 
> Hey
> 
> After debugging, I did some minor updates to the plugin README.  It should be
> easier to get this up and running, although there's still the issue of after-install
> hooks and the relative path weirdness with the Crosswalk Library itself.
> 
> It still doesn't support the CLI at all, but it should be there with the old flow.
> 
> On Mon, Mar 17, 2014 at 1:14 PM, Michal Mocny <mm...@chromium.org>
> wrote:
> > (Sorry Joe, Googlers are down in California and way busy.  Will be
> > back in a week.  Super excited about this, though.)
> >
> > -Michal
> >
> >
> > On Mon, Mar 17, 2014 at 2:53 PM, Joe Bowser <bo...@gmail.com> wrote:
> >
> >> Reviving this thread!
> >>
> >> Can other people look at this, and see if/when we should land this?
> >> I know that I have to re-write the tests still, but I would like some
> >> feedback before merging it in.  Also, it'd be super awesome if other
> >> people could try and make a WebView based on the interfaces and
> >> recommend which methods should die.  I want to get this released in
> >> the next month or so, so any time and feedback would be greatly
> >> appreciated.
> >>
> >> Thanks
> >>
> >> On Thu, Mar 13, 2014 at 3:50 PM, Joe Bowser <bo...@gmail.com> wrote:
> >> > Hey, I created the following today to track various WebView progresses:
> >> > https://issues.apache.org/jira/browse/CB-6246
> >> >
> >> > I also have this repo created.  The licensing is ugly as all crap,
> >> > but it's a Proof-Of-Concept:
> >> > https://github.com/infil00p/cordova-crosswalk-engine
> >> >
> >> > If I can get some help getting plugman to just load Crosswalk,
> >> > it'll
> >> look hawt.
> >> >
> >> > BTW: We should probably get this ready to go into Android in the
> >> > next two months and deprecate the setProperty methods, since all
> >> > properties should be preferences in config.xml now.
> >> >
> >> > On Mon, Mar 10, 2014 at 2:42 PM, Joe Bowser <bo...@gmail.com>
> wrote:
> >> >> Perhaps. There would be additional benefits to this approach,
> >> >> namely fixes being added to that platform more quickly.  I'll
> >> >> probably take a look at that once I have Crosswalk finalized.
> >> >>
> >> >> On Mon, Mar 10, 2014 at 9:49 AM, Brian LeRoux <b...@brian.io> wrote:
> >> >>> this is great stuff
> >> >>>
> >> >>> do we think it may be possible to bring in amazon fireos stuff
> >> eventually
> >> >>> too?
> >> >>>
> >> >>>
> >> >>> On Fri, Mar 7, 2014 at 3:22 PM, Joe Bowser <bo...@gmail.com> wrote:
> >> >>>
> >> >>>> BTW: I committed it in my repo, not the main Apache one.
> >> >>>>
> >> >>>> On Fri, Mar 7, 2014 at 3:21 PM, Joe Bowser <bo...@gmail.com>
> wrote:
> >> >>>> > Hey
> >> >>>> >
> >> >>>> > I just committed some code based on their WebView
> >> >>>> > modifications that allows you to choose your renderer in the config file
> with this:
> >> >>>> >
> >> >>>> >     <preference name="webView"
> >> >>>> > value="org.apache.cordova.engine.crosswalk.XWalkCordovaWebView
> >> >>>> > " />
> >> >>>> >
> >> >>>> > You currently have to copy over the *.pak file and the jsapi
> >> >>>> > from a Crosswalk Example project to get this to work.  The
> >> >>>> > next thing that I'm going to do is figure out how to write
> >> >>>> > this as a plugin and have it install on a default project.
> >> >>>> > Also, right now the bridge doesn't seem to work, and I don't
> >> >>>> > know why exactly.  That being said, the
> >> fact
> >> >>>> > that I can choose which version of Chrome/Chromium I'm running
> >> >>>> > with
> >> a
> >> >>>> > single XML preference is HUGE.
> >> >>>> >
> >> >>>> > There's definitely a lot more work that needs to be done, but
> >> >>>> > as
> >> long
> >> >>>> > as we have something that we can fit into the interface, we
> >> >>>> > should
> >> be
> >> >>>> > able to put in things like GeckoView or other third party renderers.
> >> >>>> > The nightmare of being stuck with bullshit WebView bugs may
> >> >>>> > soon be over.
> >> >>>> >
> >> >>>> > On Wed, Mar 5, 2014 at 8:59 PM, Michal Mocny
> >> >>>> > <mm...@chromium.org>
> >> >>>> wrote:
> >> >>>> >> https://github.com/crosswalk-project/crosswalk-cordova-androi
> >> >>>> >> d
> >> >>>> >>
> >> >>>> >> First patch they landed, which claims to have min viable
> >> >>>> >> xwalk
> >> webview:
> >> >>>> >>
> >> >>>>
> >> https://github.com/crosswalk-project/crosswalk-cordova-android/commit
> >> /a04dedeb0204e7542d190312c6ae70c795a26e04
> >> >>>> >>
> >> >>>> >>
> >> >>>> >> On Wed, Mar 5, 2014 at 11:37 PM, Michal Mocny
> >> >>>> >> <mmocny@chromium.org
> >> >
> >> >>>> wrote:
> >> >>>> >>
> >> >>>> >>> I haven't looked yet, but did you see:
> >> >>>> >>> https://crosswalk-project.org/#wiki/crosswalk-cordova-androi
> >> >>>> >>> d
> >> >>>> >>>
> >> >>>> >>> ?
> >> >>>> >>>
> >> >>>> >>>
> >> >>>> >>> On Wed, Mar 5, 2014 at 10:20 PM, Andrew Grieve <
> >> agrieve@chromium.org
> >> >>>> >wrote:
> >> >>>> >>>
> >> >>>> >>>> First - very excited that you're working on this!
> >> >>>> >>>>
> >> >>>> >>>> Had a quick look. Not sure there's much to be gleaned yet.
> >> >>>> >>>> Once
> >> you
> >> >>>> start
> >> >>>> >>>> in on hooking up x-walk's webview I think it will become
> >> >>>> >>>> more
> >> obvious
> >> >>>> what
> >> >>>> >>>> the interface should look like. E.g., does x-walk even have
> >> >>>> >>>> the
> >> >>>> concept of
> >> >>>> >>>> ChromeClient vs WebViewClient vs WebView? Also unsure
> >> >>>> >>>> whether the
> >> >>>> class
> >> >>>> >>>> should extend android.View as well as implement our interface.
> >> E.g.
> >> >>>> >>>> alternative is to have a "getView()" method on the interface.
> >> Might
> >> >>>> help
> >> >>>> >>>> to
> >> >>>> >>>> cut down on file sizes, and API surface, but again, I'm not
> >> >>>> >>>> too
> >> sure.
> >> >>>> >>>>
> >> >>>> >>>> I've been pretty hesitant to touch existing exposed members
> >> (e.g. the
> >> >>>> >>>> public fields you were referring to) since touching
> >> >>>> >>>> anything
> >> public
> >> >>>> could
> >> >>>> >>>> break plugins. That said, maybe now is a good time to
> >> >>>> >>>> @deprecate
> >> a
> >> >>>> bunch
> >> >>>> >>>> of
> >> >>>> >>>> them and either replace them with getters, or just declare
> >> >>>> >>>> them
> >> to be
> >> >>>> not
> >> >>>> >>>> exposed to plugins.
> >> >>>> >>>>
> >> >>>> >>>>
> >> >>>> >>>> On Wed, Mar 5, 2014 at 6:57 PM, Joe Bowser
> >> >>>> >>>> <bo...@gmail.com>
> >> wrote:
> >> >>>> >>>>
> >> >>>> >>>> > So, after looking at the Crosswalk code again, I've
> >> >>>> >>>> > decided to
> >> take
> >> >>>> a
> >> >>>> >>>> > quick stab at making things pluggable.  I don't have a
> >> >>>> >>>> > lot to
> >> show
> >> >>>> for
> >> >>>> >>>> > it, but with the help of Eclipse (which is why the
> >> >>>> >>>> > generated interfaces look so screwed up), I managed to
> >> >>>> >>>> > create some
> >> interfaces
> >> >>>> so
> >> >>>> >>>> > we can start shoehorning in other browser renderers.
> >> >>>> >>>> >
> >> >>>> >>>> >
> >> https://github.com/infil00p/cordova-android/tree/pluggable_webview
> >> >>>> >>>> >
> >> >>>> >>>> > I'm going to probably start with Crosswalk, because it's
> >> probably
> >> >>>> the
> >> >>>> >>>> > most mature primary candidate in the Android Third-Party
> >> WebView
> >> >>>> >>>> > thing, and I'm pretty sure the GeckoView will be
> >> >>>> >>>> > happening
> >> shortly
> >> >>>> >>>> > after.
> >> >>>> >>>> >
> >> >>>> >>>> > I don't know how this would work w.r.t. the CLI or our
> >> workflow at
> >> >>>> >>>> > all, but at the moment, I really just want to at least
> >> >>>> >>>> > start
> >> to have
> >> >>>> >>>> > some headway towards 4.x and PhoneGap day.
> >> >>>> >>>> >
> >> >>>> >>>> > What do people think of this so far? I'm going to try to
> >> >>>> >>>> > clean
> >> >>>> things
> >> >>>> >>>> > up a bit, since we've definitely done a lot of things
> >> >>>> >>>> > that
> >> would
> >> >>>> make
> >> >>>> >>>> > first year CS profs freak the hell out (i.e. public
> >> >>>> >>>> > members in
> >> >>>> public
> >> >>>> >>>> > objects w.r.t. PluginManager).
> >> >>>> >>>> >
> >> >>>> >>>> > Thoughts?
> >> >>>> >>>> >
> >> >>>> >>>> > Joe
> >> >>>> >>>> >
> >> >>>> >>>>
> >> >>>> >>>
> >> >>>> >>>
> >> >>>>
> >>

Re: [Android] Refactoring for different engines

[Joe Bowser <bo...@gmail.com>]

Hey

After debugging, I did some minor updates to the plugin README.  It
should be easier to get this up and running, although there's still
the issue of after-install hooks and the relative path weirdness with
the Crosswalk Library itself.

It still doesn't support the CLI at all, but it should be there with
the old flow.

On Mon, Mar 17, 2014 at 1:14 PM, Michal Mocny <mm...@chromium.org> wrote:
> (Sorry Joe, Googlers are down in California and way busy.  Will be back in
> a week.  Super excited about this, though.)
>
> -Michal
>
>
> On Mon, Mar 17, 2014 at 2:53 PM, Joe Bowser <bo...@gmail.com> wrote:
>
>> Reviving this thread!
>>
>> Can other people look at this, and see if/when we should land this?  I
>> know that I have to re-write the tests still, but I would like some
>> feedback before merging it in.  Also, it'd be super awesome if other
>> people could try and make a WebView based on the interfaces and
>> recommend which methods should die.  I want to get this released in
>> the next month or so, so any time and feedback would be greatly
>> appreciated.
>>
>> Thanks
>>
>> On Thu, Mar 13, 2014 at 3:50 PM, Joe Bowser <bo...@gmail.com> wrote:
>> > Hey, I created the following today to track various WebView progresses:
>> > https://issues.apache.org/jira/browse/CB-6246
>> >
>> > I also have this repo created.  The licensing is ugly as all crap, but
>> > it's a Proof-Of-Concept:
>> > https://github.com/infil00p/cordova-crosswalk-engine
>> >
>> > If I can get some help getting plugman to just load Crosswalk, it'll
>> look hawt.
>> >
>> > BTW: We should probably get this ready to go into Android in the next
>> > two months and deprecate the setProperty methods, since all properties
>> > should be preferences in config.xml now.
>> >
>> > On Mon, Mar 10, 2014 at 2:42 PM, Joe Bowser <bo...@gmail.com> wrote:
>> >> Perhaps. There would be additional benefits to this approach, namely
>> >> fixes being added to that platform more quickly.  I'll probably take a
>> >> look at that once I have Crosswalk finalized.
>> >>
>> >> On Mon, Mar 10, 2014 at 9:49 AM, Brian LeRoux <b...@brian.io> wrote:
>> >>> this is great stuff
>> >>>
>> >>> do we think it may be possible to bring in amazon fireos stuff
>> eventually
>> >>> too?
>> >>>
>> >>>
>> >>> On Fri, Mar 7, 2014 at 3:22 PM, Joe Bowser <bo...@gmail.com> wrote:
>> >>>
>> >>>> BTW: I committed it in my repo, not the main Apache one.
>> >>>>
>> >>>> On Fri, Mar 7, 2014 at 3:21 PM, Joe Bowser <bo...@gmail.com> wrote:
>> >>>> > Hey
>> >>>> >
>> >>>> > I just committed some code based on their WebView modifications that
>> >>>> > allows you to choose your renderer in the config file with this:
>> >>>> >
>> >>>> >     <preference name="webView"
>> >>>> > value="org.apache.cordova.engine.crosswalk.XWalkCordovaWebView" />
>> >>>> >
>> >>>> > You currently have to copy over the *.pak file and the jsapi from a
>> >>>> > Crosswalk Example project to get this to work.  The next thing that
>> >>>> > I'm going to do is figure out how to write this as a plugin and have
>> >>>> > it install on a default project.  Also, right now the bridge doesn't
>> >>>> > seem to work, and I don't know why exactly.  That being said, the
>> fact
>> >>>> > that I can choose which version of Chrome/Chromium I'm running with
>> a
>> >>>> > single XML preference is HUGE.
>> >>>> >
>> >>>> > There's definitely a lot more work that needs to be done, but as
>> long
>> >>>> > as we have something that we can fit into the interface, we should
>> be
>> >>>> > able to put in things like GeckoView or other third party renderers.
>> >>>> > The nightmare of being stuck with bullshit WebView bugs may soon be
>> >>>> > over.
>> >>>> >
>> >>>> > On Wed, Mar 5, 2014 at 8:59 PM, Michal Mocny <mm...@chromium.org>
>> >>>> wrote:
>> >>>> >> https://github.com/crosswalk-project/crosswalk-cordova-android
>> >>>> >>
>> >>>> >> First patch they landed, which claims to have min viable xwalk
>> webview:
>> >>>> >>
>> >>>>
>> https://github.com/crosswalk-project/crosswalk-cordova-android/commit/a04dedeb0204e7542d190312c6ae70c795a26e04
>> >>>> >>
>> >>>> >>
>> >>>> >> On Wed, Mar 5, 2014 at 11:37 PM, Michal Mocny <mmocny@chromium.org
>> >
>> >>>> wrote:
>> >>>> >>
>> >>>> >>> I haven't looked yet, but did you see:
>> >>>> >>> https://crosswalk-project.org/#wiki/crosswalk-cordova-android
>> >>>> >>>
>> >>>> >>> ?
>> >>>> >>>
>> >>>> >>>
>> >>>> >>> On Wed, Mar 5, 2014 at 10:20 PM, Andrew Grieve <
>> agrieve@chromium.org
>> >>>> >wrote:
>> >>>> >>>
>> >>>> >>>> First - very excited that you're working on this!
>> >>>> >>>>
>> >>>> >>>> Had a quick look. Not sure there's much to be gleaned yet. Once
>> you
>> >>>> start
>> >>>> >>>> in on hooking up x-walk's webview I think it will become more
>> obvious
>> >>>> what
>> >>>> >>>> the interface should look like. E.g., does x-walk even have the
>> >>>> concept of
>> >>>> >>>> ChromeClient vs WebViewClient vs WebView? Also unsure whether the
>> >>>> class
>> >>>> >>>> should extend android.View as well as implement our interface.
>> E.g.
>> >>>> >>>> alternative is to have a "getView()" method on the interface.
>> Might
>> >>>> help
>> >>>> >>>> to
>> >>>> >>>> cut down on file sizes, and API surface, but again, I'm not too
>> sure.
>> >>>> >>>>
>> >>>> >>>> I've been pretty hesitant to touch existing exposed members
>> (e.g. the
>> >>>> >>>> public fields you were referring to) since touching anything
>> public
>> >>>> could
>> >>>> >>>> break plugins. That said, maybe now is a good time to @deprecate
>> a
>> >>>> bunch
>> >>>> >>>> of
>> >>>> >>>> them and either replace them with getters, or just declare them
>> to be
>> >>>> not
>> >>>> >>>> exposed to plugins.
>> >>>> >>>>
>> >>>> >>>>
>> >>>> >>>> On Wed, Mar 5, 2014 at 6:57 PM, Joe Bowser <bo...@gmail.com>
>> wrote:
>> >>>> >>>>
>> >>>> >>>> > So, after looking at the Crosswalk code again, I've decided to
>> take
>> >>>> a
>> >>>> >>>> > quick stab at making things pluggable.  I don't have a lot to
>> show
>> >>>> for
>> >>>> >>>> > it, but with the help of Eclipse (which is why the generated
>> >>>> >>>> > interfaces look so screwed up), I managed to create some
>> interfaces
>> >>>> so
>> >>>> >>>> > we can start shoehorning in other browser renderers.
>> >>>> >>>> >
>> >>>> >>>> >
>> https://github.com/infil00p/cordova-android/tree/pluggable_webview
>> >>>> >>>> >
>> >>>> >>>> > I'm going to probably start with Crosswalk, because it's
>> probably
>> >>>> the
>> >>>> >>>> > most mature primary candidate in the Android Third-Party
>> WebView
>> >>>> >>>> > thing, and I'm pretty sure the GeckoView will be happening
>> shortly
>> >>>> >>>> > after.
>> >>>> >>>> >
>> >>>> >>>> > I don't know how this would work w.r.t. the CLI or our
>> workflow at
>> >>>> >>>> > all, but at the moment, I really just want to at least start
>> to have
>> >>>> >>>> > some headway towards 4.x and PhoneGap day.
>> >>>> >>>> >
>> >>>> >>>> > What do people think of this so far? I'm going to try to clean
>> >>>> things
>> >>>> >>>> > up a bit, since we've definitely done a lot of things that
>> would
>> >>>> make
>> >>>> >>>> > first year CS profs freak the hell out (i.e. public members in
>> >>>> public
>> >>>> >>>> > objects w.r.t. PluginManager).
>> >>>> >>>> >
>> >>>> >>>> > Thoughts?
>> >>>> >>>> >
>> >>>> >>>> > Joe
>> >>>> >>>> >
>> >>>> >>>>
>> >>>> >>>
>> >>>> >>>
>> >>>>
>>

Re: [Android] Refactoring for different engines

[Michal Mocny <mm...@chromium.org>]

(Sorry Joe, Googlers are down in California and way busy.  Will be back in
a week.  Super excited about this, though.)

-Michal


On Mon, Mar 17, 2014 at 2:53 PM, Joe Bowser <bo...@gmail.com> wrote:

> Reviving this thread!
>
> Can other people look at this, and see if/when we should land this?  I
> know that I have to re-write the tests still, but I would like some
> feedback before merging it in.  Also, it'd be super awesome if other
> people could try and make a WebView based on the interfaces and
> recommend which methods should die.  I want to get this released in
> the next month or so, so any time and feedback would be greatly
> appreciated.
>
> Thanks
>
> On Thu, Mar 13, 2014 at 3:50 PM, Joe Bowser <bo...@gmail.com> wrote:
> > Hey, I created the following today to track various WebView progresses:
> > https://issues.apache.org/jira/browse/CB-6246
> >
> > I also have this repo created.  The licensing is ugly as all crap, but
> > it's a Proof-Of-Concept:
> > https://github.com/infil00p/cordova-crosswalk-engine
> >
> > If I can get some help getting plugman to just load Crosswalk, it'll
> look hawt.
> >
> > BTW: We should probably get this ready to go into Android in the next
> > two months and deprecate the setProperty methods, since all properties
> > should be preferences in config.xml now.
> >
> > On Mon, Mar 10, 2014 at 2:42 PM, Joe Bowser <bo...@gmail.com> wrote:
> >> Perhaps. There would be additional benefits to this approach, namely
> >> fixes being added to that platform more quickly.  I'll probably take a
> >> look at that once I have Crosswalk finalized.
> >>
> >> On Mon, Mar 10, 2014 at 9:49 AM, Brian LeRoux <b...@brian.io> wrote:
> >>> this is great stuff
> >>>
> >>> do we think it may be possible to bring in amazon fireos stuff
> eventually
> >>> too?
> >>>
> >>>
> >>> On Fri, Mar 7, 2014 at 3:22 PM, Joe Bowser <bo...@gmail.com> wrote:
> >>>
> >>>> BTW: I committed it in my repo, not the main Apache one.
> >>>>
> >>>> On Fri, Mar 7, 2014 at 3:21 PM, Joe Bowser <bo...@gmail.com> wrote:
> >>>> > Hey
> >>>> >
> >>>> > I just committed some code based on their WebView modifications that
> >>>> > allows you to choose your renderer in the config file with this:
> >>>> >
> >>>> >     <preference name="webView"
> >>>> > value="org.apache.cordova.engine.crosswalk.XWalkCordovaWebView" />
> >>>> >
> >>>> > You currently have to copy over the *.pak file and the jsapi from a
> >>>> > Crosswalk Example project to get this to work.  The next thing that
> >>>> > I'm going to do is figure out how to write this as a plugin and have
> >>>> > it install on a default project.  Also, right now the bridge doesn't
> >>>> > seem to work, and I don't know why exactly.  That being said, the
> fact
> >>>> > that I can choose which version of Chrome/Chromium I'm running with
> a
> >>>> > single XML preference is HUGE.
> >>>> >
> >>>> > There's definitely a lot more work that needs to be done, but as
> long
> >>>> > as we have something that we can fit into the interface, we should
> be
> >>>> > able to put in things like GeckoView or other third party renderers.
> >>>> > The nightmare of being stuck with bullshit WebView bugs may soon be
> >>>> > over.
> >>>> >
> >>>> > On Wed, Mar 5, 2014 at 8:59 PM, Michal Mocny <mm...@chromium.org>
> >>>> wrote:
> >>>> >> https://github.com/crosswalk-project/crosswalk-cordova-android
> >>>> >>
> >>>> >> First patch they landed, which claims to have min viable xwalk
> webview:
> >>>> >>
> >>>>
> https://github.com/crosswalk-project/crosswalk-cordova-android/commit/a04dedeb0204e7542d190312c6ae70c795a26e04
> >>>> >>
> >>>> >>
> >>>> >> On Wed, Mar 5, 2014 at 11:37 PM, Michal Mocny <mmocny@chromium.org
> >
> >>>> wrote:
> >>>> >>
> >>>> >>> I haven't looked yet, but did you see:
> >>>> >>> https://crosswalk-project.org/#wiki/crosswalk-cordova-android
> >>>> >>>
> >>>> >>> ?
> >>>> >>>
> >>>> >>>
> >>>> >>> On Wed, Mar 5, 2014 at 10:20 PM, Andrew Grieve <
> agrieve@chromium.org
> >>>> >wrote:
> >>>> >>>
> >>>> >>>> First - very excited that you're working on this!
> >>>> >>>>
> >>>> >>>> Had a quick look. Not sure there's much to be gleaned yet. Once
> you
> >>>> start
> >>>> >>>> in on hooking up x-walk's webview I think it will become more
> obvious
> >>>> what
> >>>> >>>> the interface should look like. E.g., does x-walk even have the
> >>>> concept of
> >>>> >>>> ChromeClient vs WebViewClient vs WebView? Also unsure whether the
> >>>> class
> >>>> >>>> should extend android.View as well as implement our interface.
> E.g.
> >>>> >>>> alternative is to have a "getView()" method on the interface.
> Might
> >>>> help
> >>>> >>>> to
> >>>> >>>> cut down on file sizes, and API surface, but again, I'm not too
> sure.
> >>>> >>>>
> >>>> >>>> I've been pretty hesitant to touch existing exposed members
> (e.g. the
> >>>> >>>> public fields you were referring to) since touching anything
> public
> >>>> could
> >>>> >>>> break plugins. That said, maybe now is a good time to @deprecate
> a
> >>>> bunch
> >>>> >>>> of
> >>>> >>>> them and either replace them with getters, or just declare them
> to be
> >>>> not
> >>>> >>>> exposed to plugins.
> >>>> >>>>
> >>>> >>>>
> >>>> >>>> On Wed, Mar 5, 2014 at 6:57 PM, Joe Bowser <bo...@gmail.com>
> wrote:
> >>>> >>>>
> >>>> >>>> > So, after looking at the Crosswalk code again, I've decided to
> take
> >>>> a
> >>>> >>>> > quick stab at making things pluggable.  I don't have a lot to
> show
> >>>> for
> >>>> >>>> > it, but with the help of Eclipse (which is why the generated
> >>>> >>>> > interfaces look so screwed up), I managed to create some
> interfaces
> >>>> so
> >>>> >>>> > we can start shoehorning in other browser renderers.
> >>>> >>>> >
> >>>> >>>> >
> https://github.com/infil00p/cordova-android/tree/pluggable_webview
> >>>> >>>> >
> >>>> >>>> > I'm going to probably start with Crosswalk, because it's
> probably
> >>>> the
> >>>> >>>> > most mature primary candidate in the Android Third-Party
> WebView
> >>>> >>>> > thing, and I'm pretty sure the GeckoView will be happening
> shortly
> >>>> >>>> > after.
> >>>> >>>> >
> >>>> >>>> > I don't know how this would work w.r.t. the CLI or our
> workflow at
> >>>> >>>> > all, but at the moment, I really just want to at least start
> to have
> >>>> >>>> > some headway towards 4.x and PhoneGap day.
> >>>> >>>> >
> >>>> >>>> > What do people think of this so far? I'm going to try to clean
> >>>> things
> >>>> >>>> > up a bit, since we've definitely done a lot of things that
> would
> >>>> make
> >>>> >>>> > first year CS profs freak the hell out (i.e. public members in
> >>>> public
> >>>> >>>> > objects w.r.t. PluginManager).
> >>>> >>>> >
> >>>> >>>> > Thoughts?
> >>>> >>>> >
> >>>> >>>> > Joe
> >>>> >>>> >
> >>>> >>>>
> >>>> >>>
> >>>> >>>
> >>>>
>

Re: [Android] Refactoring for different engines

[Joe Bowser <bo...@gmail.com>]

Reviving this thread!

Can other people look at this, and see if/when we should land this?  I
know that I have to re-write the tests still, but I would like some
feedback before merging it in.  Also, it'd be super awesome if other
people could try and make a WebView based on the interfaces and
recommend which methods should die.  I want to get this released in
the next month or so, so any time and feedback would be greatly
appreciated.

Thanks

On Thu, Mar 13, 2014 at 3:50 PM, Joe Bowser <bo...@gmail.com> wrote:
> Hey, I created the following today to track various WebView progresses:
> https://issues.apache.org/jira/browse/CB-6246
>
> I also have this repo created.  The licensing is ugly as all crap, but
> it's a Proof-Of-Concept:
> https://github.com/infil00p/cordova-crosswalk-engine
>
> If I can get some help getting plugman to just load Crosswalk, it'll look hawt.
>
> BTW: We should probably get this ready to go into Android in the next
> two months and deprecate the setProperty methods, since all properties
> should be preferences in config.xml now.
>
> On Mon, Mar 10, 2014 at 2:42 PM, Joe Bowser <bo...@gmail.com> wrote:
>> Perhaps. There would be additional benefits to this approach, namely
>> fixes being added to that platform more quickly.  I'll probably take a
>> look at that once I have Crosswalk finalized.
>>
>> On Mon, Mar 10, 2014 at 9:49 AM, Brian LeRoux <b...@brian.io> wrote:
>>> this is great stuff
>>>
>>> do we think it may be possible to bring in amazon fireos stuff eventually
>>> too?
>>>
>>>
>>> On Fri, Mar 7, 2014 at 3:22 PM, Joe Bowser <bo...@gmail.com> wrote:
>>>
>>>> BTW: I committed it in my repo, not the main Apache one.
>>>>
>>>> On Fri, Mar 7, 2014 at 3:21 PM, Joe Bowser <bo...@gmail.com> wrote:
>>>> > Hey
>>>> >
>>>> > I just committed some code based on their WebView modifications that
>>>> > allows you to choose your renderer in the config file with this:
>>>> >
>>>> >     <preference name="webView"
>>>> > value="org.apache.cordova.engine.crosswalk.XWalkCordovaWebView" />
>>>> >
>>>> > You currently have to copy over the *.pak file and the jsapi from a
>>>> > Crosswalk Example project to get this to work.  The next thing that
>>>> > I'm going to do is figure out how to write this as a plugin and have
>>>> > it install on a default project.  Also, right now the bridge doesn't
>>>> > seem to work, and I don't know why exactly.  That being said, the fact
>>>> > that I can choose which version of Chrome/Chromium I'm running with a
>>>> > single XML preference is HUGE.
>>>> >
>>>> > There's definitely a lot more work that needs to be done, but as long
>>>> > as we have something that we can fit into the interface, we should be
>>>> > able to put in things like GeckoView or other third party renderers.
>>>> > The nightmare of being stuck with bullshit WebView bugs may soon be
>>>> > over.
>>>> >
>>>> > On Wed, Mar 5, 2014 at 8:59 PM, Michal Mocny <mm...@chromium.org>
>>>> wrote:
>>>> >> https://github.com/crosswalk-project/crosswalk-cordova-android
>>>> >>
>>>> >> First patch they landed, which claims to have min viable xwalk webview:
>>>> >>
>>>> https://github.com/crosswalk-project/crosswalk-cordova-android/commit/a04dedeb0204e7542d190312c6ae70c795a26e04
>>>> >>
>>>> >>
>>>> >> On Wed, Mar 5, 2014 at 11:37 PM, Michal Mocny <mm...@chromium.org>
>>>> wrote:
>>>> >>
>>>> >>> I haven't looked yet, but did you see:
>>>> >>> https://crosswalk-project.org/#wiki/crosswalk-cordova-android
>>>> >>>
>>>> >>> ?
>>>> >>>
>>>> >>>
>>>> >>> On Wed, Mar 5, 2014 at 10:20 PM, Andrew Grieve <agrieve@chromium.org
>>>> >wrote:
>>>> >>>
>>>> >>>> First - very excited that you're working on this!
>>>> >>>>
>>>> >>>> Had a quick look. Not sure there's much to be gleaned yet. Once you
>>>> start
>>>> >>>> in on hooking up x-walk's webview I think it will become more obvious
>>>> what
>>>> >>>> the interface should look like. E.g., does x-walk even have the
>>>> concept of
>>>> >>>> ChromeClient vs WebViewClient vs WebView? Also unsure whether the
>>>> class
>>>> >>>> should extend android.View as well as implement our interface. E.g.
>>>> >>>> alternative is to have a "getView()" method on the interface. Might
>>>> help
>>>> >>>> to
>>>> >>>> cut down on file sizes, and API surface, but again, I'm not too sure.
>>>> >>>>
>>>> >>>> I've been pretty hesitant to touch existing exposed members (e.g. the
>>>> >>>> public fields you were referring to) since touching anything public
>>>> could
>>>> >>>> break plugins. That said, maybe now is a good time to @deprecate a
>>>> bunch
>>>> >>>> of
>>>> >>>> them and either replace them with getters, or just declare them to be
>>>> not
>>>> >>>> exposed to plugins.
>>>> >>>>
>>>> >>>>
>>>> >>>> On Wed, Mar 5, 2014 at 6:57 PM, Joe Bowser <bo...@gmail.com> wrote:
>>>> >>>>
>>>> >>>> > So, after looking at the Crosswalk code again, I've decided to take
>>>> a
>>>> >>>> > quick stab at making things pluggable.  I don't have a lot to show
>>>> for
>>>> >>>> > it, but with the help of Eclipse (which is why the generated
>>>> >>>> > interfaces look so screwed up), I managed to create some interfaces
>>>> so
>>>> >>>> > we can start shoehorning in other browser renderers.
>>>> >>>> >
>>>> >>>> > https://github.com/infil00p/cordova-android/tree/pluggable_webview
>>>> >>>> >
>>>> >>>> > I'm going to probably start with Crosswalk, because it's probably
>>>> the
>>>> >>>> > most mature primary candidate in the Android Third-Party WebView
>>>> >>>> > thing, and I'm pretty sure the GeckoView will be happening shortly
>>>> >>>> > after.
>>>> >>>> >
>>>> >>>> > I don't know how this would work w.r.t. the CLI or our workflow at
>>>> >>>> > all, but at the moment, I really just want to at least start to have
>>>> >>>> > some headway towards 4.x and PhoneGap day.
>>>> >>>> >
>>>> >>>> > What do people think of this so far? I'm going to try to clean
>>>> things
>>>> >>>> > up a bit, since we've definitely done a lot of things that would
>>>> make
>>>> >>>> > first year CS profs freak the hell out (i.e. public members in
>>>> public
>>>> >>>> > objects w.r.t. PluginManager).
>>>> >>>> >
>>>> >>>> > Thoughts?
>>>> >>>> >
>>>> >>>> > Joe
>>>> >>>> >
>>>> >>>>
>>>> >>>
>>>> >>>
>>>>

Re: [Android] Refactoring for different engines

[Joe Bowser <bo...@gmail.com>]

Hey, I created the following today to track various WebView progresses:
https://issues.apache.org/jira/browse/CB-6246

I also have this repo created.  The licensing is ugly as all crap, but
it's a Proof-Of-Concept:
https://github.com/infil00p/cordova-crosswalk-engine

If I can get some help getting plugman to just load Crosswalk, it'll look hawt.

BTW: We should probably get this ready to go into Android in the next
two months and deprecate the setProperty methods, since all properties
should be preferences in config.xml now.

On Mon, Mar 10, 2014 at 2:42 PM, Joe Bowser <bo...@gmail.com> wrote:
> Perhaps. There would be additional benefits to this approach, namely
> fixes being added to that platform more quickly.  I'll probably take a
> look at that once I have Crosswalk finalized.
>
> On Mon, Mar 10, 2014 at 9:49 AM, Brian LeRoux <b...@brian.io> wrote:
>> this is great stuff
>>
>> do we think it may be possible to bring in amazon fireos stuff eventually
>> too?
>>
>>
>> On Fri, Mar 7, 2014 at 3:22 PM, Joe Bowser <bo...@gmail.com> wrote:
>>
>>> BTW: I committed it in my repo, not the main Apache one.
>>>
>>> On Fri, Mar 7, 2014 at 3:21 PM, Joe Bowser <bo...@gmail.com> wrote:
>>> > Hey
>>> >
>>> > I just committed some code based on their WebView modifications that
>>> > allows you to choose your renderer in the config file with this:
>>> >
>>> >     <preference name="webView"
>>> > value="org.apache.cordova.engine.crosswalk.XWalkCordovaWebView" />
>>> >
>>> > You currently have to copy over the *.pak file and the jsapi from a
>>> > Crosswalk Example project to get this to work.  The next thing that
>>> > I'm going to do is figure out how to write this as a plugin and have
>>> > it install on a default project.  Also, right now the bridge doesn't
>>> > seem to work, and I don't know why exactly.  That being said, the fact
>>> > that I can choose which version of Chrome/Chromium I'm running with a
>>> > single XML preference is HUGE.
>>> >
>>> > There's definitely a lot more work that needs to be done, but as long
>>> > as we have something that we can fit into the interface, we should be
>>> > able to put in things like GeckoView or other third party renderers.
>>> > The nightmare of being stuck with bullshit WebView bugs may soon be
>>> > over.
>>> >
>>> > On Wed, Mar 5, 2014 at 8:59 PM, Michal Mocny <mm...@chromium.org>
>>> wrote:
>>> >> https://github.com/crosswalk-project/crosswalk-cordova-android
>>> >>
>>> >> First patch they landed, which claims to have min viable xwalk webview:
>>> >>
>>> https://github.com/crosswalk-project/crosswalk-cordova-android/commit/a04dedeb0204e7542d190312c6ae70c795a26e04
>>> >>
>>> >>
>>> >> On Wed, Mar 5, 2014 at 11:37 PM, Michal Mocny <mm...@chromium.org>
>>> wrote:
>>> >>
>>> >>> I haven't looked yet, but did you see:
>>> >>> https://crosswalk-project.org/#wiki/crosswalk-cordova-android
>>> >>>
>>> >>> ?
>>> >>>
>>> >>>
>>> >>> On Wed, Mar 5, 2014 at 10:20 PM, Andrew Grieve <agrieve@chromium.org
>>> >wrote:
>>> >>>
>>> >>>> First - very excited that you're working on this!
>>> >>>>
>>> >>>> Had a quick look. Not sure there's much to be gleaned yet. Once you
>>> start
>>> >>>> in on hooking up x-walk's webview I think it will become more obvious
>>> what
>>> >>>> the interface should look like. E.g., does x-walk even have the
>>> concept of
>>> >>>> ChromeClient vs WebViewClient vs WebView? Also unsure whether the
>>> class
>>> >>>> should extend android.View as well as implement our interface. E.g.
>>> >>>> alternative is to have a "getView()" method on the interface. Might
>>> help
>>> >>>> to
>>> >>>> cut down on file sizes, and API surface, but again, I'm not too sure.
>>> >>>>
>>> >>>> I've been pretty hesitant to touch existing exposed members (e.g. the
>>> >>>> public fields you were referring to) since touching anything public
>>> could
>>> >>>> break plugins. That said, maybe now is a good time to @deprecate a
>>> bunch
>>> >>>> of
>>> >>>> them and either replace them with getters, or just declare them to be
>>> not
>>> >>>> exposed to plugins.
>>> >>>>
>>> >>>>
>>> >>>> On Wed, Mar 5, 2014 at 6:57 PM, Joe Bowser <bo...@gmail.com> wrote:
>>> >>>>
>>> >>>> > So, after looking at the Crosswalk code again, I've decided to take
>>> a
>>> >>>> > quick stab at making things pluggable.  I don't have a lot to show
>>> for
>>> >>>> > it, but with the help of Eclipse (which is why the generated
>>> >>>> > interfaces look so screwed up), I managed to create some interfaces
>>> so
>>> >>>> > we can start shoehorning in other browser renderers.
>>> >>>> >
>>> >>>> > https://github.com/infil00p/cordova-android/tree/pluggable_webview
>>> >>>> >
>>> >>>> > I'm going to probably start with Crosswalk, because it's probably
>>> the
>>> >>>> > most mature primary candidate in the Android Third-Party WebView
>>> >>>> > thing, and I'm pretty sure the GeckoView will be happening shortly
>>> >>>> > after.
>>> >>>> >
>>> >>>> > I don't know how this would work w.r.t. the CLI or our workflow at
>>> >>>> > all, but at the moment, I really just want to at least start to have
>>> >>>> > some headway towards 4.x and PhoneGap day.
>>> >>>> >
>>> >>>> > What do people think of this so far? I'm going to try to clean
>>> things
>>> >>>> > up a bit, since we've definitely done a lot of things that would
>>> make
>>> >>>> > first year CS profs freak the hell out (i.e. public members in
>>> public
>>> >>>> > objects w.r.t. PluginManager).
>>> >>>> >
>>> >>>> > Thoughts?
>>> >>>> >
>>> >>>> > Joe
>>> >>>> >
>>> >>>>
>>> >>>
>>> >>>
>>>

Re: [Android] Refactoring for different engines

[Joe Bowser <bo...@gmail.com>]

Perhaps. There would be additional benefits to this approach, namely
fixes being added to that platform more quickly.  I'll probably take a
look at that once I have Crosswalk finalized.

On Mon, Mar 10, 2014 at 9:49 AM, Brian LeRoux <b...@brian.io> wrote:
> this is great stuff
>
> do we think it may be possible to bring in amazon fireos stuff eventually
> too?
>
>
> On Fri, Mar 7, 2014 at 3:22 PM, Joe Bowser <bo...@gmail.com> wrote:
>
>> BTW: I committed it in my repo, not the main Apache one.
>>
>> On Fri, Mar 7, 2014 at 3:21 PM, Joe Bowser <bo...@gmail.com> wrote:
>> > Hey
>> >
>> > I just committed some code based on their WebView modifications that
>> > allows you to choose your renderer in the config file with this:
>> >
>> >     <preference name="webView"
>> > value="org.apache.cordova.engine.crosswalk.XWalkCordovaWebView" />
>> >
>> > You currently have to copy over the *.pak file and the jsapi from a
>> > Crosswalk Example project to get this to work.  The next thing that
>> > I'm going to do is figure out how to write this as a plugin and have
>> > it install on a default project.  Also, right now the bridge doesn't
>> > seem to work, and I don't know why exactly.  That being said, the fact
>> > that I can choose which version of Chrome/Chromium I'm running with a
>> > single XML preference is HUGE.
>> >
>> > There's definitely a lot more work that needs to be done, but as long
>> > as we have something that we can fit into the interface, we should be
>> > able to put in things like GeckoView or other third party renderers.
>> > The nightmare of being stuck with bullshit WebView bugs may soon be
>> > over.
>> >
>> > On Wed, Mar 5, 2014 at 8:59 PM, Michal Mocny <mm...@chromium.org>
>> wrote:
>> >> https://github.com/crosswalk-project/crosswalk-cordova-android
>> >>
>> >> First patch they landed, which claims to have min viable xwalk webview:
>> >>
>> https://github.com/crosswalk-project/crosswalk-cordova-android/commit/a04dedeb0204e7542d190312c6ae70c795a26e04
>> >>
>> >>
>> >> On Wed, Mar 5, 2014 at 11:37 PM, Michal Mocny <mm...@chromium.org>
>> wrote:
>> >>
>> >>> I haven't looked yet, but did you see:
>> >>> https://crosswalk-project.org/#wiki/crosswalk-cordova-android
>> >>>
>> >>> ?
>> >>>
>> >>>
>> >>> On Wed, Mar 5, 2014 at 10:20 PM, Andrew Grieve <agrieve@chromium.org
>> >wrote:
>> >>>
>> >>>> First - very excited that you're working on this!
>> >>>>
>> >>>> Had a quick look. Not sure there's much to be gleaned yet. Once you
>> start
>> >>>> in on hooking up x-walk's webview I think it will become more obvious
>> what
>> >>>> the interface should look like. E.g., does x-walk even have the
>> concept of
>> >>>> ChromeClient vs WebViewClient vs WebView? Also unsure whether the
>> class
>> >>>> should extend android.View as well as implement our interface. E.g.
>> >>>> alternative is to have a "getView()" method on the interface. Might
>> help
>> >>>> to
>> >>>> cut down on file sizes, and API surface, but again, I'm not too sure.
>> >>>>
>> >>>> I've been pretty hesitant to touch existing exposed members (e.g. the
>> >>>> public fields you were referring to) since touching anything public
>> could
>> >>>> break plugins. That said, maybe now is a good time to @deprecate a
>> bunch
>> >>>> of
>> >>>> them and either replace them with getters, or just declare them to be
>> not
>> >>>> exposed to plugins.
>> >>>>
>> >>>>
>> >>>> On Wed, Mar 5, 2014 at 6:57 PM, Joe Bowser <bo...@gmail.com> wrote:
>> >>>>
>> >>>> > So, after looking at the Crosswalk code again, I've decided to take
>> a
>> >>>> > quick stab at making things pluggable.  I don't have a lot to show
>> for
>> >>>> > it, but with the help of Eclipse (which is why the generated
>> >>>> > interfaces look so screwed up), I managed to create some interfaces
>> so
>> >>>> > we can start shoehorning in other browser renderers.
>> >>>> >
>> >>>> > https://github.com/infil00p/cordova-android/tree/pluggable_webview
>> >>>> >
>> >>>> > I'm going to probably start with Crosswalk, because it's probably
>> the
>> >>>> > most mature primary candidate in the Android Third-Party WebView
>> >>>> > thing, and I'm pretty sure the GeckoView will be happening shortly
>> >>>> > after.
>> >>>> >
>> >>>> > I don't know how this would work w.r.t. the CLI or our workflow at
>> >>>> > all, but at the moment, I really just want to at least start to have
>> >>>> > some headway towards 4.x and PhoneGap day.
>> >>>> >
>> >>>> > What do people think of this so far? I'm going to try to clean
>> things
>> >>>> > up a bit, since we've definitely done a lot of things that would
>> make
>> >>>> > first year CS profs freak the hell out (i.e. public members in
>> public
>> >>>> > objects w.r.t. PluginManager).
>> >>>> >
>> >>>> > Thoughts?
>> >>>> >
>> >>>> > Joe
>> >>>> >
>> >>>>
>> >>>
>> >>>
>>

Re: [Android] Refactoring for different engines

[Brian LeRoux <b...@brian.io>]

this is great stuff

do we think it may be possible to bring in amazon fireos stuff eventually
too?


On Fri, Mar 7, 2014 at 3:22 PM, Joe Bowser <bo...@gmail.com> wrote:

> BTW: I committed it in my repo, not the main Apache one.
>
> On Fri, Mar 7, 2014 at 3:21 PM, Joe Bowser <bo...@gmail.com> wrote:
> > Hey
> >
> > I just committed some code based on their WebView modifications that
> > allows you to choose your renderer in the config file with this:
> >
> >     <preference name="webView"
> > value="org.apache.cordova.engine.crosswalk.XWalkCordovaWebView" />
> >
> > You currently have to copy over the *.pak file and the jsapi from a
> > Crosswalk Example project to get this to work.  The next thing that
> > I'm going to do is figure out how to write this as a plugin and have
> > it install on a default project.  Also, right now the bridge doesn't
> > seem to work, and I don't know why exactly.  That being said, the fact
> > that I can choose which version of Chrome/Chromium I'm running with a
> > single XML preference is HUGE.
> >
> > There's definitely a lot more work that needs to be done, but as long
> > as we have something that we can fit into the interface, we should be
> > able to put in things like GeckoView or other third party renderers.
> > The nightmare of being stuck with bullshit WebView bugs may soon be
> > over.
> >
> > On Wed, Mar 5, 2014 at 8:59 PM, Michal Mocny <mm...@chromium.org>
> wrote:
> >> https://github.com/crosswalk-project/crosswalk-cordova-android
> >>
> >> First patch they landed, which claims to have min viable xwalk webview:
> >>
> https://github.com/crosswalk-project/crosswalk-cordova-android/commit/a04dedeb0204e7542d190312c6ae70c795a26e04
> >>
> >>
> >> On Wed, Mar 5, 2014 at 11:37 PM, Michal Mocny <mm...@chromium.org>
> wrote:
> >>
> >>> I haven't looked yet, but did you see:
> >>> https://crosswalk-project.org/#wiki/crosswalk-cordova-android
> >>>
> >>> ?
> >>>
> >>>
> >>> On Wed, Mar 5, 2014 at 10:20 PM, Andrew Grieve <agrieve@chromium.org
> >wrote:
> >>>
> >>>> First - very excited that you're working on this!
> >>>>
> >>>> Had a quick look. Not sure there's much to be gleaned yet. Once you
> start
> >>>> in on hooking up x-walk's webview I think it will become more obvious
> what
> >>>> the interface should look like. E.g., does x-walk even have the
> concept of
> >>>> ChromeClient vs WebViewClient vs WebView? Also unsure whether the
> class
> >>>> should extend android.View as well as implement our interface. E.g.
> >>>> alternative is to have a "getView()" method on the interface. Might
> help
> >>>> to
> >>>> cut down on file sizes, and API surface, but again, I'm not too sure.
> >>>>
> >>>> I've been pretty hesitant to touch existing exposed members (e.g. the
> >>>> public fields you were referring to) since touching anything public
> could
> >>>> break plugins. That said, maybe now is a good time to @deprecate a
> bunch
> >>>> of
> >>>> them and either replace them with getters, or just declare them to be
> not
> >>>> exposed to plugins.
> >>>>
> >>>>
> >>>> On Wed, Mar 5, 2014 at 6:57 PM, Joe Bowser <bo...@gmail.com> wrote:
> >>>>
> >>>> > So, after looking at the Crosswalk code again, I've decided to take
> a
> >>>> > quick stab at making things pluggable.  I don't have a lot to show
> for
> >>>> > it, but with the help of Eclipse (which is why the generated
> >>>> > interfaces look so screwed up), I managed to create some interfaces
> so
> >>>> > we can start shoehorning in other browser renderers.
> >>>> >
> >>>> > https://github.com/infil00p/cordova-android/tree/pluggable_webview
> >>>> >
> >>>> > I'm going to probably start with Crosswalk, because it's probably
> the
> >>>> > most mature primary candidate in the Android Third-Party WebView
> >>>> > thing, and I'm pretty sure the GeckoView will be happening shortly
> >>>> > after.
> >>>> >
> >>>> > I don't know how this would work w.r.t. the CLI or our workflow at
> >>>> > all, but at the moment, I really just want to at least start to have
> >>>> > some headway towards 4.x and PhoneGap day.
> >>>> >
> >>>> > What do people think of this so far? I'm going to try to clean
> things
> >>>> > up a bit, since we've definitely done a lot of things that would
> make
> >>>> > first year CS profs freak the hell out (i.e. public members in
> public
> >>>> > objects w.r.t. PluginManager).
> >>>> >
> >>>> > Thoughts?
> >>>> >
> >>>> > Joe
> >>>> >
> >>>>
> >>>
> >>>
>

Re: [Android] Refactoring for different engines

[Joe Bowser <bo...@gmail.com>]

Just added more code.  I have the Cordova bridges working with
Crosswalk.  The thing is that for us to do this, we have to expose a
lot of things that were previously not exposed, because I'm choosing
to not put the Crosswalk code in the same namespace for organizational
purposes.

On Fri, Mar 7, 2014 at 3:22 PM, Joe Bowser <bo...@gmail.com> wrote:
> BTW: I committed it in my repo, not the main Apache one.
>
> On Fri, Mar 7, 2014 at 3:21 PM, Joe Bowser <bo...@gmail.com> wrote:
>> Hey
>>
>> I just committed some code based on their WebView modifications that
>> allows you to choose your renderer in the config file with this:
>>
>>     <preference name="webView"
>> value="org.apache.cordova.engine.crosswalk.XWalkCordovaWebView" />
>>
>> You currently have to copy over the *.pak file and the jsapi from a
>> Crosswalk Example project to get this to work.  The next thing that
>> I'm going to do is figure out how to write this as a plugin and have
>> it install on a default project.  Also, right now the bridge doesn't
>> seem to work, and I don't know why exactly.  That being said, the fact
>> that I can choose which version of Chrome/Chromium I'm running with a
>> single XML preference is HUGE.
>>
>> There's definitely a lot more work that needs to be done, but as long
>> as we have something that we can fit into the interface, we should be
>> able to put in things like GeckoView or other third party renderers.
>> The nightmare of being stuck with bullshit WebView bugs may soon be
>> over.
>>
>> On Wed, Mar 5, 2014 at 8:59 PM, Michal Mocny <mm...@chromium.org> wrote:
>>> https://github.com/crosswalk-project/crosswalk-cordova-android
>>>
>>> First patch they landed, which claims to have min viable xwalk webview:
>>> https://github.com/crosswalk-project/crosswalk-cordova-android/commit/a04dedeb0204e7542d190312c6ae70c795a26e04
>>>
>>>
>>> On Wed, Mar 5, 2014 at 11:37 PM, Michal Mocny <mm...@chromium.org> wrote:
>>>
>>>> I haven't looked yet, but did you see:
>>>> https://crosswalk-project.org/#wiki/crosswalk-cordova-android
>>>>
>>>> ?
>>>>
>>>>
>>>> On Wed, Mar 5, 2014 at 10:20 PM, Andrew Grieve <ag...@chromium.org>wrote:
>>>>
>>>>> First - very excited that you're working on this!
>>>>>
>>>>> Had a quick look. Not sure there's much to be gleaned yet. Once you start
>>>>> in on hooking up x-walk's webview I think it will become more obvious what
>>>>> the interface should look like. E.g., does x-walk even have the concept of
>>>>> ChromeClient vs WebViewClient vs WebView? Also unsure whether the class
>>>>> should extend android.View as well as implement our interface. E.g.
>>>>> alternative is to have a "getView()" method on the interface. Might help
>>>>> to
>>>>> cut down on file sizes, and API surface, but again, I'm not too sure.
>>>>>
>>>>> I've been pretty hesitant to touch existing exposed members (e.g. the
>>>>> public fields you were referring to) since touching anything public could
>>>>> break plugins. That said, maybe now is a good time to @deprecate a bunch
>>>>> of
>>>>> them and either replace them with getters, or just declare them to be not
>>>>> exposed to plugins.
>>>>>
>>>>>
>>>>> On Wed, Mar 5, 2014 at 6:57 PM, Joe Bowser <bo...@gmail.com> wrote:
>>>>>
>>>>> > So, after looking at the Crosswalk code again, I've decided to take a
>>>>> > quick stab at making things pluggable.  I don't have a lot to show for
>>>>> > it, but with the help of Eclipse (which is why the generated
>>>>> > interfaces look so screwed up), I managed to create some interfaces so
>>>>> > we can start shoehorning in other browser renderers.
>>>>> >
>>>>> > https://github.com/infil00p/cordova-android/tree/pluggable_webview
>>>>> >
>>>>> > I'm going to probably start with Crosswalk, because it's probably the
>>>>> > most mature primary candidate in the Android Third-Party WebView
>>>>> > thing, and I'm pretty sure the GeckoView will be happening shortly
>>>>> > after.
>>>>> >
>>>>> > I don't know how this would work w.r.t. the CLI or our workflow at
>>>>> > all, but at the moment, I really just want to at least start to have
>>>>> > some headway towards 4.x and PhoneGap day.
>>>>> >
>>>>> > What do people think of this so far? I'm going to try to clean things
>>>>> > up a bit, since we've definitely done a lot of things that would make
>>>>> > first year CS profs freak the hell out (i.e. public members in public
>>>>> > objects w.r.t. PluginManager).
>>>>> >
>>>>> > Thoughts?
>>>>> >
>>>>> > Joe
>>>>> >
>>>>>
>>>>
>>>>

Re: [Android] Refactoring for different engines

[Joe Bowser <bo...@gmail.com>]

BTW: I committed it in my repo, not the main Apache one.

On Fri, Mar 7, 2014 at 3:21 PM, Joe Bowser <bo...@gmail.com> wrote:
> Hey
>
> I just committed some code based on their WebView modifications that
> allows you to choose your renderer in the config file with this:
>
>     <preference name="webView"
> value="org.apache.cordova.engine.crosswalk.XWalkCordovaWebView" />
>
> You currently have to copy over the *.pak file and the jsapi from a
> Crosswalk Example project to get this to work.  The next thing that
> I'm going to do is figure out how to write this as a plugin and have
> it install on a default project.  Also, right now the bridge doesn't
> seem to work, and I don't know why exactly.  That being said, the fact
> that I can choose which version of Chrome/Chromium I'm running with a
> single XML preference is HUGE.
>
> There's definitely a lot more work that needs to be done, but as long
> as we have something that we can fit into the interface, we should be
> able to put in things like GeckoView or other third party renderers.
> The nightmare of being stuck with bullshit WebView bugs may soon be
> over.
>
> On Wed, Mar 5, 2014 at 8:59 PM, Michal Mocny <mm...@chromium.org> wrote:
>> https://github.com/crosswalk-project/crosswalk-cordova-android
>>
>> First patch they landed, which claims to have min viable xwalk webview:
>> https://github.com/crosswalk-project/crosswalk-cordova-android/commit/a04dedeb0204e7542d190312c6ae70c795a26e04
>>
>>
>> On Wed, Mar 5, 2014 at 11:37 PM, Michal Mocny <mm...@chromium.org> wrote:
>>
>>> I haven't looked yet, but did you see:
>>> https://crosswalk-project.org/#wiki/crosswalk-cordova-android
>>>
>>> ?
>>>
>>>
>>> On Wed, Mar 5, 2014 at 10:20 PM, Andrew Grieve <ag...@chromium.org>wrote:
>>>
>>>> First - very excited that you're working on this!
>>>>
>>>> Had a quick look. Not sure there's much to be gleaned yet. Once you start
>>>> in on hooking up x-walk's webview I think it will become more obvious what
>>>> the interface should look like. E.g., does x-walk even have the concept of
>>>> ChromeClient vs WebViewClient vs WebView? Also unsure whether the class
>>>> should extend android.View as well as implement our interface. E.g.
>>>> alternative is to have a "getView()" method on the interface. Might help
>>>> to
>>>> cut down on file sizes, and API surface, but again, I'm not too sure.
>>>>
>>>> I've been pretty hesitant to touch existing exposed members (e.g. the
>>>> public fields you were referring to) since touching anything public could
>>>> break plugins. That said, maybe now is a good time to @deprecate a bunch
>>>> of
>>>> them and either replace them with getters, or just declare them to be not
>>>> exposed to plugins.
>>>>
>>>>
>>>> On Wed, Mar 5, 2014 at 6:57 PM, Joe Bowser <bo...@gmail.com> wrote:
>>>>
>>>> > So, after looking at the Crosswalk code again, I've decided to take a
>>>> > quick stab at making things pluggable.  I don't have a lot to show for
>>>> > it, but with the help of Eclipse (which is why the generated
>>>> > interfaces look so screwed up), I managed to create some interfaces so
>>>> > we can start shoehorning in other browser renderers.
>>>> >
>>>> > https://github.com/infil00p/cordova-android/tree/pluggable_webview
>>>> >
>>>> > I'm going to probably start with Crosswalk, because it's probably the
>>>> > most mature primary candidate in the Android Third-Party WebView
>>>> > thing, and I'm pretty sure the GeckoView will be happening shortly
>>>> > after.
>>>> >
>>>> > I don't know how this would work w.r.t. the CLI or our workflow at
>>>> > all, but at the moment, I really just want to at least start to have
>>>> > some headway towards 4.x and PhoneGap day.
>>>> >
>>>> > What do people think of this so far? I'm going to try to clean things
>>>> > up a bit, since we've definitely done a lot of things that would make
>>>> > first year CS profs freak the hell out (i.e. public members in public
>>>> > objects w.r.t. PluginManager).
>>>> >
>>>> > Thoughts?
>>>> >
>>>> > Joe
>>>> >
>>>>
>>>
>>>

Re: [Android] Refactoring for different engines

[Joe Bowser <bo...@gmail.com>]

Hey

I just committed some code based on their WebView modifications that
allows you to choose your renderer in the config file with this:

    <preference name="webView"
value="org.apache.cordova.engine.crosswalk.XWalkCordovaWebView" />

You currently have to copy over the *.pak file and the jsapi from a
Crosswalk Example project to get this to work.  The next thing that
I'm going to do is figure out how to write this as a plugin and have
it install on a default project.  Also, right now the bridge doesn't
seem to work, and I don't know why exactly.  That being said, the fact
that I can choose which version of Chrome/Chromium I'm running with a
single XML preference is HUGE.

There's definitely a lot more work that needs to be done, but as long
as we have something that we can fit into the interface, we should be
able to put in things like GeckoView or other third party renderers.
The nightmare of being stuck with bullshit WebView bugs may soon be
over.

On Wed, Mar 5, 2014 at 8:59 PM, Michal Mocny <mm...@chromium.org> wrote:
> https://github.com/crosswalk-project/crosswalk-cordova-android
>
> First patch they landed, which claims to have min viable xwalk webview:
> https://github.com/crosswalk-project/crosswalk-cordova-android/commit/a04dedeb0204e7542d190312c6ae70c795a26e04
>
>
> On Wed, Mar 5, 2014 at 11:37 PM, Michal Mocny <mm...@chromium.org> wrote:
>
>> I haven't looked yet, but did you see:
>> https://crosswalk-project.org/#wiki/crosswalk-cordova-android
>>
>> ?
>>
>>
>> On Wed, Mar 5, 2014 at 10:20 PM, Andrew Grieve <ag...@chromium.org>wrote:
>>
>>> First - very excited that you're working on this!
>>>
>>> Had a quick look. Not sure there's much to be gleaned yet. Once you start
>>> in on hooking up x-walk's webview I think it will become more obvious what
>>> the interface should look like. E.g., does x-walk even have the concept of
>>> ChromeClient vs WebViewClient vs WebView? Also unsure whether the class
>>> should extend android.View as well as implement our interface. E.g.
>>> alternative is to have a "getView()" method on the interface. Might help
>>> to
>>> cut down on file sizes, and API surface, but again, I'm not too sure.
>>>
>>> I've been pretty hesitant to touch existing exposed members (e.g. the
>>> public fields you were referring to) since touching anything public could
>>> break plugins. That said, maybe now is a good time to @deprecate a bunch
>>> of
>>> them and either replace them with getters, or just declare them to be not
>>> exposed to plugins.
>>>
>>>
>>> On Wed, Mar 5, 2014 at 6:57 PM, Joe Bowser <bo...@gmail.com> wrote:
>>>
>>> > So, after looking at the Crosswalk code again, I've decided to take a
>>> > quick stab at making things pluggable.  I don't have a lot to show for
>>> > it, but with the help of Eclipse (which is why the generated
>>> > interfaces look so screwed up), I managed to create some interfaces so
>>> > we can start shoehorning in other browser renderers.
>>> >
>>> > https://github.com/infil00p/cordova-android/tree/pluggable_webview
>>> >
>>> > I'm going to probably start with Crosswalk, because it's probably the
>>> > most mature primary candidate in the Android Third-Party WebView
>>> > thing, and I'm pretty sure the GeckoView will be happening shortly
>>> > after.
>>> >
>>> > I don't know how this would work w.r.t. the CLI or our workflow at
>>> > all, but at the moment, I really just want to at least start to have
>>> > some headway towards 4.x and PhoneGap day.
>>> >
>>> > What do people think of this so far? I'm going to try to clean things
>>> > up a bit, since we've definitely done a lot of things that would make
>>> > first year CS profs freak the hell out (i.e. public members in public
>>> > objects w.r.t. PluginManager).
>>> >
>>> > Thoughts?
>>> >
>>> > Joe
>>> >
>>>
>>
>>

Re: [Android] Refactoring for different engines

[Michal Mocny <mm...@chromium.org>]

https://github.com/crosswalk-project/crosswalk-cordova-android

First patch they landed, which claims to have min viable xwalk webview:
https://github.com/crosswalk-project/crosswalk-cordova-android/commit/a04dedeb0204e7542d190312c6ae70c795a26e04


On Wed, Mar 5, 2014 at 11:37 PM, Michal Mocny <mm...@chromium.org> wrote:

> I haven't looked yet, but did you see:
> https://crosswalk-project.org/#wiki/crosswalk-cordova-android
>
> ?
>
>
> On Wed, Mar 5, 2014 at 10:20 PM, Andrew Grieve <ag...@chromium.org>wrote:
>
>> First - very excited that you're working on this!
>>
>> Had a quick look. Not sure there's much to be gleaned yet. Once you start
>> in on hooking up x-walk's webview I think it will become more obvious what
>> the interface should look like. E.g., does x-walk even have the concept of
>> ChromeClient vs WebViewClient vs WebView? Also unsure whether the class
>> should extend android.View as well as implement our interface. E.g.
>> alternative is to have a "getView()" method on the interface. Might help
>> to
>> cut down on file sizes, and API surface, but again, I'm not too sure.
>>
>> I've been pretty hesitant to touch existing exposed members (e.g. the
>> public fields you were referring to) since touching anything public could
>> break plugins. That said, maybe now is a good time to @deprecate a bunch
>> of
>> them and either replace them with getters, or just declare them to be not
>> exposed to plugins.
>>
>>
>> On Wed, Mar 5, 2014 at 6:57 PM, Joe Bowser <bo...@gmail.com> wrote:
>>
>> > So, after looking at the Crosswalk code again, I've decided to take a
>> > quick stab at making things pluggable.  I don't have a lot to show for
>> > it, but with the help of Eclipse (which is why the generated
>> > interfaces look so screwed up), I managed to create some interfaces so
>> > we can start shoehorning in other browser renderers.
>> >
>> > https://github.com/infil00p/cordova-android/tree/pluggable_webview
>> >
>> > I'm going to probably start with Crosswalk, because it's probably the
>> > most mature primary candidate in the Android Third-Party WebView
>> > thing, and I'm pretty sure the GeckoView will be happening shortly
>> > after.
>> >
>> > I don't know how this would work w.r.t. the CLI or our workflow at
>> > all, but at the moment, I really just want to at least start to have
>> > some headway towards 4.x and PhoneGap day.
>> >
>> > What do people think of this so far? I'm going to try to clean things
>> > up a bit, since we've definitely done a lot of things that would make
>> > first year CS profs freak the hell out (i.e. public members in public
>> > objects w.r.t. PluginManager).
>> >
>> > Thoughts?
>> >
>> > Joe
>> >
>>
>
>

Re: [Android] Refactoring for different engines

[Michal Mocny <mm...@chromium.org>]

I haven't looked yet, but did you see:
https://crosswalk-project.org/#wiki/crosswalk-cordova-android

?


On Wed, Mar 5, 2014 at 10:20 PM, Andrew Grieve <ag...@chromium.org> wrote:

> First - very excited that you're working on this!
>
> Had a quick look. Not sure there's much to be gleaned yet. Once you start
> in on hooking up x-walk's webview I think it will become more obvious what
> the interface should look like. E.g., does x-walk even have the concept of
> ChromeClient vs WebViewClient vs WebView? Also unsure whether the class
> should extend android.View as well as implement our interface. E.g.
> alternative is to have a "getView()" method on the interface. Might help to
> cut down on file sizes, and API surface, but again, I'm not too sure.
>
> I've been pretty hesitant to touch existing exposed members (e.g. the
> public fields you were referring to) since touching anything public could
> break plugins. That said, maybe now is a good time to @deprecate a bunch of
> them and either replace them with getters, or just declare them to be not
> exposed to plugins.
>
>
> On Wed, Mar 5, 2014 at 6:57 PM, Joe Bowser <bo...@gmail.com> wrote:
>
> > So, after looking at the Crosswalk code again, I've decided to take a
> > quick stab at making things pluggable.  I don't have a lot to show for
> > it, but with the help of Eclipse (which is why the generated
> > interfaces look so screwed up), I managed to create some interfaces so
> > we can start shoehorning in other browser renderers.
> >
> > https://github.com/infil00p/cordova-android/tree/pluggable_webview
> >
> > I'm going to probably start with Crosswalk, because it's probably the
> > most mature primary candidate in the Android Third-Party WebView
> > thing, and I'm pretty sure the GeckoView will be happening shortly
> > after.
> >
> > I don't know how this would work w.r.t. the CLI or our workflow at
> > all, but at the moment, I really just want to at least start to have
> > some headway towards 4.x and PhoneGap day.
> >
> > What do people think of this so far? I'm going to try to clean things
> > up a bit, since we've definitely done a lot of things that would make
> > first year CS profs freak the hell out (i.e. public members in public
> > objects w.r.t. PluginManager).
> >
> > Thoughts?
> >
> > Joe
> >
>

Re: [Android] Refactoring for different engines

[Andrew Grieve <ag...@chromium.org>]

First - very excited that you're working on this!

Had a quick look. Not sure there's much to be gleaned yet. Once you start
in on hooking up x-walk's webview I think it will become more obvious what
the interface should look like. E.g., does x-walk even have the concept of
ChromeClient vs WebViewClient vs WebView? Also unsure whether the class
should extend android.View as well as implement our interface. E.g.
alternative is to have a "getView()" method on the interface. Might help to
cut down on file sizes, and API surface, but again, I'm not too sure.

I've been pretty hesitant to touch existing exposed members (e.g. the
public fields you were referring to) since touching anything public could
break plugins. That said, maybe now is a good time to @deprecate a bunch of
them and either replace them with getters, or just declare them to be not
exposed to plugins.


On Wed, Mar 5, 2014 at 6:57 PM, Joe Bowser <bo...@gmail.com> wrote:

> So, after looking at the Crosswalk code again, I've decided to take a
> quick stab at making things pluggable.  I don't have a lot to show for
> it, but with the help of Eclipse (which is why the generated
> interfaces look so screwed up), I managed to create some interfaces so
> we can start shoehorning in other browser renderers.
>
> https://github.com/infil00p/cordova-android/tree/pluggable_webview
>
> I'm going to probably start with Crosswalk, because it's probably the
> most mature primary candidate in the Android Third-Party WebView
> thing, and I'm pretty sure the GeckoView will be happening shortly
> after.
>
> I don't know how this would work w.r.t. the CLI or our workflow at
> all, but at the moment, I really just want to at least start to have
> some headway towards 4.x and PhoneGap day.
>
> What do people think of this so far? I'm going to try to clean things
> up a bit, since we've definitely done a lot of things that would make
> first year CS profs freak the hell out (i.e. public members in public
> objects w.r.t. PluginManager).
>
> Thoughts?
>
> Joe
>