You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2022/03/03 13:28:35 UTC

[GitHub] [beam] echauchot commented on a change in pull request #16894: [adhoc] Prepare aws2 ClientConfiguration for json serialization and cleanup AWS Module

echauchot commented on a change in pull request #16894:
URL: https://github.com/apache/beam/pull/16894#discussion_r814024406



##########
File path: sdks/java/io/amazon-web-services2/src/test/java/org/apache/beam/sdk/io/aws2/common/ClientConfigurationTest.java
##########
@@ -50,4 +52,28 @@ public void testSerialization() {
 
     assertThat(deserializedConfig).isEqualTo(config);
   }
+
+  @Test
+  public void testJsonSerialization() {

Review comment:
       I think you missed to test with `retry(RetryConfiguration retry)` and `regionId` set on config.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org