You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@seatunnel.apache.org by "dybyte (via GitHub)" <gi...@apache.org> on 2025/08/28 23:02:02 UTC

[PR] [Fix][Zeta] Use dynamic port allocation for HTTP in RestApiHttpsForTruststoreTest [seatunnel]

dybyte opened a new pull request, #9792:
URL: https://github.com/apache/seatunnel/pull/9792

   ### Purpose of this pull request
   
   Fix intermittent CI test failures in `RestApiHttpsForTruststoreTest` caused by HTTP port conflicts by dynamically allocating the HTTP port (excluding the fixed HTTPS port).
   
   See [BaseServletTest.java](https://github.com/apache/seatunnel/blob/0d52102241afcc98294b21061c2db02b35c9d2e1/seatunnel-engine/seatunnel-engine-server/src/test/java/org/apache/seatunnel/engine/server/rest/BaseServletTest.java#L59)
    for reference.
   ```
   2025-08-28T13:14:39.2712140Z [ERROR] Failures:
   2025-08-28T13:14:39.2713120Z [ERROR]   RestApiHttpsForTruststoreTest.testRestApiHttp:92 Expected java.net.ConnectException to be thrown, but nothing was thrown.
   ```
   
   ### Does this PR introduce _any_ user-facing change?
   
   No
   
   ### How was this patch tested?
   
   The change is covered by existing tests.
   
   ### Check list
   
   * [ ] If any new Jar binary package adding in your PR, please add License Notice according
     [New License Guide](https://github.com/apache/seatunnel/blob/dev/docs/en/contribution/new-license.md)
   * [ ] If necessary, please update the documentation to describe the new feature. https://github.com/apache/seatunnel/tree/dev/docs
   * [ ] If you are contributing the connector code, please check that the following files are updated:
     1. Update [plugin-mapping.properties](https://github.com/apache/seatunnel/blob/dev/plugin-mapping.properties) and add new connector information in it
     2. Update the pom file of [seatunnel-dist](https://github.com/apache/seatunnel/blob/dev/seatunnel-dist/pom.xml)
     3. Add ci label in [label-scope-conf](https://github.com/apache/seatunnel/blob/dev/.github/workflows/labeler/label-scope-conf.yml)
     4. Add e2e testcase in [seatunnel-e2e](https://github.com/apache/seatunnel/tree/dev/seatunnel-e2e/seatunnel-connector-v2-e2e/)
     5. Update connector [plugin_config](https://github.com/apache/seatunnel/blob/dev/config/plugin_config)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [Fix][Zeta] Use dynamic port allocation for HTTP in `RestApiHttpsForTruststoreTest` [seatunnel]

Posted by "dybyte (via GitHub)" <gi...@apache.org>.
dybyte commented on PR #9792:
URL: https://github.com/apache/seatunnel/pull/9792#issuecomment-3235866967

   @Hisoka-X @corgy-w 
   I found another error in CI test
   ```
   2025-08-29T02:59:06.9008164Z [ERROR] Errors: 
   2025-08-29T02:59:06.9009150Z [ERROR]   PrometheusIT ยป Completion org.testcontainers.containers.ContainerLaunchExcepti...
   ```
   It seems like we may need to change the Docker image from `bitnami/prometheus:2.53.0` to `bitnamilegacy/prometheus:2.53.0`. Bitnami patched their Prometheus image after August 28, so the original image may no longer work. What do you think?
   [More details](https://github.com/bitnami/containers/issues/83267)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [Fix][Zeta] Use dynamic port allocation for HTTP in `RestApiHttpsForTruststoreTest` and update Prometheus image [seatunnel]

Posted by "corgy-w (via GitHub)" <gi...@apache.org>.
corgy-w merged PR #9792:
URL: https://github.com/apache/seatunnel/pull/9792


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [Fix][Zeta] Use dynamic port allocation for HTTP in `RestApiHttpsForTruststoreTest` and update Prometheus image [seatunnel]

Posted by "Hisoka-X (via GitHub)" <gi...@apache.org>.
Hisoka-X commented on PR #9792:
URL: https://github.com/apache/seatunnel/pull/9792#issuecomment-3235968064

   > change the Docker image from bitnami/prometheus:2.53.0 to bitnamilegacy/prometheus:2.53.0
   
   LGTM.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [Fix][Zeta] Use dynamic port allocation for HTTP in `RestApiHttpsForTruststoreTest` [seatunnel]

Posted by "corgy-w (via GitHub)" <gi...@apache.org>.
corgy-w commented on PR #9792:
URL: https://github.com/apache/seatunnel/pull/9792#issuecomment-3235440725

   Thanks @dybyte please retry ci


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [Fix][Zeta] Use dynamic port allocation for HTTP in `RestApiHttpsForTruststoreTest` and update Prometheus image [seatunnel]

Posted by "dybyte (via GitHub)" <gi...@apache.org>.
dybyte commented on PR #9792:
URL: https://github.com/apache/seatunnel/pull/9792#issuecomment-3236936649

   All CI checks have passed.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org