You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Jonathan Hurley <jh...@hortonworks.com> on 2014/09/27 15:36:09 UTC

Review Request 26115: Alerts: Disabling an Alert Should Propagate to Agent

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26115/
-----------------------------------------------------------

Review request for Ambari and Nate Cole.


Bugs: BUG-7534
    https://issues.apache.org/jira/browse/BUG-7534


Repository: ambari


Description
-------

When disabling an alert via the definition, the agents should receive the updated alert definition and unschedule any running.


Diffs
-----

  ambari-agent/src/main/python/ambari_agent/AlertSchedulerHandler.py 8dcce50417dd7206d16660004cd6d1183319eee1 
  ambari-agent/src/main/python/ambari_agent/alerts/base_alert.py 10dcff8e4472de451a4cf7c8220462f7e642f0f0 
  ambari-agent/src/test/python/ambari_agent/TestAlerts.py 662d8eee672bb68c46d4c5f80bad4f6df3992e63 
  ambari-agent/src/test/python/ambari_agent/dummy_files/definitions.json 30973c28f72951f62a43226dce005b508023faf8 

Diff: https://reviews.apache.org/r/26115/diff/


Testing
-------

mvn clean test in ambari-agent

[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 8.586 s
[INFO] Finished at: 2014-09-27T09:35:25-04:00
[INFO] Final Memory: 10M/81M
[INFO] ------------------------------------------------------------------------


Thanks,

Jonathan Hurley


Re: Review Request 26115: Alerts: Disabling an Alert Should Propagate to Agent

Posted by Nate Cole <nc...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26115/#review54775
-----------------------------------------------------------

Ship it!


Ship It!

- Nate Cole


On Sept. 27, 2014, 9:36 a.m., Jonathan Hurley wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26115/
> -----------------------------------------------------------
> 
> (Updated Sept. 27, 2014, 9:36 a.m.)
> 
> 
> Review request for Ambari and Nate Cole.
> 
> 
> Bugs: BUG-7534
>     https://issues.apache.org/jira/browse/BUG-7534
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> When disabling an alert via the definition, the agents should receive the updated alert definition and unschedule any running.
> 
> 
> Diffs
> -----
> 
>   ambari-agent/src/main/python/ambari_agent/AlertSchedulerHandler.py 8dcce50417dd7206d16660004cd6d1183319eee1 
>   ambari-agent/src/main/python/ambari_agent/alerts/base_alert.py 10dcff8e4472de451a4cf7c8220462f7e642f0f0 
>   ambari-agent/src/test/python/ambari_agent/TestAlerts.py 662d8eee672bb68c46d4c5f80bad4f6df3992e63 
>   ambari-agent/src/test/python/ambari_agent/dummy_files/definitions.json 30973c28f72951f62a43226dce005b508023faf8 
> 
> Diff: https://reviews.apache.org/r/26115/diff/
> 
> 
> Testing
> -------
> 
> mvn clean test in ambari-agent
> 
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 8.586 s
> [INFO] Finished at: 2014-09-27T09:35:25-04:00
> [INFO] Final Memory: 10M/81M
> [INFO] ------------------------------------------------------------------------
> 
> 
> Thanks,
> 
> Jonathan Hurley
> 
>


Re: Review Request 26115: Alerts: Disabling an Alert Should Propagate to Agent

Posted by Jonathan Hurley <jh...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26115/
-----------------------------------------------------------

(Updated Sept. 29, 2014, 8:11 a.m.)


Review request for Ambari and Nate Cole.


Bugs: AMBARI-7534
    https://issues.apache.org/jira/browse/AMBARI-7534


Repository: ambari


Description
-------

When disabling an alert via the definition, the agents should receive the updated alert definition and unschedule any running.


Diffs
-----

  ambari-agent/src/main/python/ambari_agent/AlertSchedulerHandler.py 8dcce50417dd7206d16660004cd6d1183319eee1 
  ambari-agent/src/main/python/ambari_agent/alerts/base_alert.py 10dcff8e4472de451a4cf7c8220462f7e642f0f0 
  ambari-agent/src/test/python/ambari_agent/TestAlerts.py 662d8eee672bb68c46d4c5f80bad4f6df3992e63 
  ambari-agent/src/test/python/ambari_agent/dummy_files/definitions.json 30973c28f72951f62a43226dce005b508023faf8 

Diff: https://reviews.apache.org/r/26115/diff/


Testing
-------

mvn clean test in ambari-agent

[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 8.586 s
[INFO] Finished at: 2014-09-27T09:35:25-04:00
[INFO] Final Memory: 10M/81M
[INFO] ------------------------------------------------------------------------


Thanks,

Jonathan Hurley