You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucene.apache.org by "Noble Paul (JIRA)" <ji...@apache.org> on 2018/10/06 02:42:00 UTC
[jira] [Issue Comment Deleted] (SOLR-12798) Structural changes in
SolrJ since version 7.0.0 have effectively disabled multipart post
[ https://issues.apache.org/jira/browse/SOLR-12798?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Noble Paul updated SOLR-12798:
------------------------------
Comment: was deleted
(was: | (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
|| || || || {color:brown} Prechecks {color} ||
| {color:red}-1{color} | {color:red} test4tests {color} | {color:red} 0m 0s{color} | {color:red} The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m 39s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m 36s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 1m 36s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} Release audit (RAT) {color} | {color:green} 1m 25s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} Check forbidden APIs {color} | {color:green} 1m 20s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} Validate source patterns {color} | {color:green} 1m 20s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:red}-1{color} | {color:red} unit {color} | {color:red} 20m 41s{color} | {color:red} core in the patch failed. {color} |
| {color:red}-1{color} | {color:red} unit {color} | {color:red} 4m 57s{color} | {color:red} solrj in the patch failed. {color} |
| {color:black}{color} | {color:black} {color} | {color:black} 30m 59s{color} | {color:black} {color} |
\\
\\
|| Reason || Tests ||
| Failed junit tests | solr.schema.TestManagedSchemaAPI |
| | solr.handler.TestRestoreCore |
| | solr.cloud.LeaderFailureAfterFreshStartTest |
| | solr.TestHighlightDedupGrouping |
| | solr.cloud.TestCloudRecovery |
| | solr.cloud.autoscaling.IndexSizeTriggerTest |
| | solr.cloud.TestPullReplicaErrorHandling |
| | solr.cloud.TriLevelCompositeIdRoutingTest |
| | solr.cloud.api.collections.CustomCollectionTest |
| | solr.handler.component.DistributedFacetPivotSmallTest |
| | solr.schema.TestCloudSchemaless |
| | solr.cloud.autoscaling.MetricTriggerIntegrationTest |
| | solr.core.TestDynamicURP |
| | solr.search.MergeStrategyTest |
| | solr.handler.component.DistributedFacetPivotWhiteBoxTest |
| | solr.cloud.ZkFailoverTest |
| | solr.util.TestSolrCLIRunExample |
| | solr.cloud.TestCloudPseudoReturnFields |
| | solr.cloud.cdcr.CdcrWithNodesRestartsTest |
| | solr.handler.component.DistributedDebugComponentTest |
| | solr.cloud.LIRRollingUpdatesTest |
| | solr.response.transform.TestSubQueryTransformerDistrib |
| | solr.schema.TestBinaryField |
| | solr.handler.component.DistributedFacetPivotLargeTest |
| | solr.cloud.TestDownShardTolerantSearch |
| | solr.cloud.MoveReplicaHDFSFailoverTest |
| | solr.handler.admin.CoreAdminHandlerTest |
| | solr.cloud.api.collections.TestCollectionAPI |
| | solr.TestDistributedMissingSort |
| | solr.cloud.BasicDistributedZk2Test |
| | solr.cloud.TestShortCircuitedRequests |
| | solr.cloud.SolrCloudExampleTest |
| | solr.core.OpenCloseCoreStressTest |
| | solr.core.TestDynamicLoading |
| | solr.cloud.LeaderTragicEventTest |
| | solr.cloud.MigrateRouteKeyTest |
| | solr.handler.component.DistributedExpandComponentTest |
| | solr.TestTolerantSearch |
| | solr.handler.component.TestDistributedStatsComponentCardinality |
| | solr.security.BasicAuthIntegrationTest |
| | solr.handler.TestReplicationHandlerBackup |
| | solr.cloud.TestCloudSearcherWarming |
| | solr.cloud.TestCloudPivotFacet |
| | solr.cloud.RecoveryZkTest |
| | solr.security.hadoop.TestSolrCloudWithHadoopAuthPlugin |
| | solr.handler.component.DistributedFacetPivotLongTailTest |
| | solr.cloud.MissingSegmentRecoveryTest |
| | solr.search.join.TestCloudNestedDocsSort |
| | solr.DistributedIntervalFacetingTest |
| | solr.cloud.TestCryptoKeys |
| | solr.core.BlobRepositoryCloudTest |
| | solr.cloud.DistribDocExpirationUpdateProcessorTest |
| | solr.cloud.TestTolerantUpdateProcessorCloud |
| | solr.search.stats.TestDefaultStatsCache |
| | solr.cloud.cdcr.CdcrVersionReplicationTest |
| | solr.update.SolrIndexSplitterTest |
| | solr.cloud.TestPullReplica |
| | solr.request.TestRemoteStreaming |
| | solr.cloud.TestLeaderElectionWithEmptyReplica |
| | solr.cloud.autoscaling.SystemLogListenerTest |
| | solr.metrics.reporters.solr.SolrCloudReportersTest |
| | solr.cloud.TestTolerantUpdateProcessorRandomCloud |
| | solr.cloud.DeleteReplicaTest |
| | solr.handler.component.DistributedTermsComponentTest |
| | solr.cloud.MoveReplicaTest |
| | solr.handler.component.DistributedFacetExistsSmallTest |
| | solr.client.solrj.request.TestCoreAdmin |
| | solr.client.solrj.embedded.SolrExampleJettyTest |
| | solr.client.solrj.TestSolrJErrorHandling |
| | solr.client.solrj.io.stream.StreamingTest |
| | solr.client.solrj.io.stream.StreamDecoratorTest |
| | solr.client.solrj.SolrSchemalessExampleTest |
| | solr.client.solrj.impl.HttpSolrClientSSLAuthConPoolTest |
| | solr.client.solrj.io.stream.StreamExpressionTest |
| | solr.client.solrj.TestLBHttpSolrClient |
| | solr.client.solrj.response.NoOpResponseParserTest |
| | solr.client.solrj.request.SolrPingTest |
| | solr.client.ref_guide_examples.UsingSolrJRefGuideExamplesTest |
| | solr.client.solrj.io.stream.SelectWithEvaluatorsTest |
| | solr.client.solrj.impl.BasicHttpSolrClientTest |
| | solr.client.solrj.embedded.SolrExampleEmbeddedTest |
| | solr.client.solrj.io.graph.GraphExpressionTest |
| | solr.client.solrj.embedded.TestSolrProperties |
| | solr.client.solrj.io.stream.MathExpressionTest |
| | solr.client.solrj.response.TestSuggesterResponse |
| | solr.client.solrj.impl.HttpSolrClientConPoolTest |
| | solr.client.solrj.embedded.MergeIndexesEmbeddedTest |
| | solr.client.solrj.impl.ConcurrentUpdateSolrClientTest |
| | solr.client.solrj.io.sql.JdbcTest |
| | solr.client.solrj.SolrExampleBinaryTest |
| | solr.client.solrj.embedded.SolrExampleStreamingTest |
| | solr.client.solrj.embedded.LargeVolumeBinaryJettyTest |
| | solr.client.solrj.io.stream.JDBCStreamTest |
| | solr.client.solrj.embedded.LargeVolumeEmbeddedTest |
| | solr.client.solrj.impl.CloudSolrClientRetryTest |
| | solr.client.solrj.impl.CloudSolrClientTest |
| | solr.client.solrj.embedded.LargeVolumeJettyTest |
| | solr.client.solrj.io.graph.GraphTest |
| | solr.client.solrj.GetByIdTest |
| | solr.client.solrj.response.TestSpellCheckResponse |
| | solr.client.solrj.TestBatchUpdate |
| | solr.client.solrj.embedded.SolrExampleStreamingBinaryTest |
| | solr.client.solrj.response.TermsResponseTest |
\\
\\
|| Subsystem || Report/Notes ||
| JIRA Issue | SOLR-12798 |
| JIRA Patch URL | https://issues.apache.org/jira/secure/attachment/12942571/SOLR-12798.patch |
| Optional Tests | compile javac unit ratsources checkforbiddenapis validatesourcepatterns |
| uname | Linux lucene1-us-west 4.4.0-130-generic #156~14.04.1-Ubuntu SMP Thu Jun 14 13:51:47 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | ant |
| Personality | /home/jenkins/jenkins-slave/workspace/PreCommit-SOLR-Build/sourcedir/dev-tools/test-patch/lucene-solr-yetus-personality.sh |
| git revision | master / eb47099 |
| ant | version: Apache Ant(TM) version 1.9.3 compiled on July 24 2018 |
| Default Java | 1.8.0_172 |
| unit | https://builds.apache.org/job/PreCommit-SOLR-Build/197/artifact/out/patch-unit-solr_core.txt |
| unit | https://builds.apache.org/job/PreCommit-SOLR-Build/197/artifact/out/patch-unit-solr_solrj.txt |
| Test Results | https://builds.apache.org/job/PreCommit-SOLR-Build/197/testReport/ |
| modules | C: solr/core solr/solrj U: solr |
| Console output | https://builds.apache.org/job/PreCommit-SOLR-Build/197/console |
| Powered by | Apache Yetus 0.7.0 http://yetus.apache.org |
This message was automatically generated.
)
> Structural changes in SolrJ since version 7.0.0 have effectively disabled multipart post
> ----------------------------------------------------------------------------------------
>
> Key: SOLR-12798
> URL: https://issues.apache.org/jira/browse/SOLR-12798
> Project: Solr
> Issue Type: Improvement
> Security Level: Public(Default Security Level. Issues are Public)
> Components: SolrJ
> Affects Versions: 7.4
> Reporter: Karl Wright
> Assignee: Karl Wright
> Priority: Major
> Attachments: HOT Balloon Trip_Ultra HD.jpg, SOLR-12798-approach.patch, SOLR-12798-reproducer.patch, SOLR-12798-workaround.patch, SOLR-12798.patch, SOLR-12798.patch, no params in url.png, solr-update-request.txt
>
>
> Project ManifoldCF uses SolrJ to post documents to Solr. When upgrading from SolrJ 7.0.x to SolrJ 7.4, we encountered significant structural changes to SolrJ's HttpSolrClient class that seemingly disable any use of multipart post. This is critical because ManifoldCF's documents often contain metadata in excess of 4K that therefore cannot be stuffed into a URL.
> The changes in question seem to have been performed by Paul Noble on 10/31/2017, with the introduction of the RequestWriter mechanism. Basically, if a request has a RequestWriter, it is used exclusively to write the request, and that overrides the stream mechanism completely. I haven't chased it back to a specific ticket.
> ManifoldCF's usage of SolrJ involves the creation of ContentStreamUpdateRequests for all posts meant for Solr Cell, and the creation of UpdateRequests for posts not meant for Solr Cell (as well as for delete and commit requests). For our release cycle that is taking place right now, we're shipping a modified version of HttpSolrClient that ignores the RequestWriter when dealing with ContentStreamUpdateRequests. We apparently cannot use multipart for all requests because on the Solr side we get "pfountz Should not get here!" errors on the Solr side when we do, which generate HTTP error code 500 responses. That should not happen either, in my opinion.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org