[GitHub] [maven-archetype] timtebeek commented on a diff in pull request #146: [MNG-6829] Replace any StringUtils#isEmpty(String) and #isNotEmpty(String)

["timtebeek (via GitHub)" <gi...@apache.org>]

timtebeek commented on code in PR #146:
URL: https://github.com/apache/maven-archetype/pull/146#discussion_r1193122130


##########
archetype-common/src/main/java/org/apache/maven/archetype/common/DefaultArchetypeFilesResolver.java:
##########
@@ -71,7 +71,7 @@ public List<String> getFilteredFiles( List<String> files, String filtered )
     public List<String> filterFiles( String moduleOffset, FileSet fileSet, List<String> archetypeResources )
     {
         ListScanner scanner = new ListScanner();
-        scanner.setBasedir( ( StringUtils.isEmpty( moduleOffset ) ? "" : ( moduleOffset + File.separatorChar ) )
+        scanner.setBasedir( ( (moduleOffset == null || moduleOffset.isEmpty()) ? "" : ( moduleOffset + File.separatorChar ) )

Review Comment:
   ```suggestion
           scanner.setBasedir( ( ( moduleOffset == null || moduleOffset.isEmpty() ) ? "" : ( moduleOffset + File.separatorChar ) )
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org