You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2019/01/29 00:26:17 UTC

[GitHub] codecov-io commented on issue #6773: Make the filterbox sort the values and compare exactly

codecov-io commented on issue #6773: Make the filterbox sort the values and compare exactly
URL: https://github.com/apache/incubator-superset/pull/6773#issuecomment-458357222
 
 
   # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/6773?src=pr&el=h1) Report
   > Merging [#6773](https://codecov.io/gh/apache/incubator-superset/pull/6773?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/83ee9178328c5193808fe356ceb3090a299477f6?src=pr&el=desc) will **decrease** coverage by `17.35%`.
   > The diff coverage is `0%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/6773/graphs/tree.svg?width=650&token=KsB0fHcx6l&height=150&src=pr)](https://codecov.io/gh/apache/incubator-superset/pull/6773?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff             @@
   ##           master    #6773       +/-   ##
   ===========================================
   - Coverage   73.42%   56.07%   -17.36%     
   ===========================================
     Files          75      525      +450     
     Lines       10084    23220    +13136     
     Branches        0     2778     +2778     
   ===========================================
   + Hits         7404    13020     +5616     
   - Misses       2680     9791     +7111     
   - Partials        0      409      +409
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/6773?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [.../assets/src/visualizations/FilterBox/FilterBox.jsx](https://codecov.io/gh/apache/incubator-superset/pull/6773/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy92aXN1YWxpemF0aW9ucy9GaWx0ZXJCb3gvRmlsdGVyQm94LmpzeA==) | `0% <0%> (ø)` | |
   | [superset/assets/src/components/Checkbox.jsx](https://codecov.io/gh/apache/incubator-superset/pull/6773/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9jb21wb25lbnRzL0NoZWNrYm94LmpzeA==) | `100% <0%> (ø)` | |
   | [...ations/deckgl/layers/Polygon/PolygonChartPlugin.js](https://codecov.io/gh/apache/incubator-superset/pull/6773/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy92aXN1YWxpemF0aW9ucy9kZWNrZ2wvbGF5ZXJzL1BvbHlnb24vUG9seWdvbkNoYXJ0UGx1Z2luLmpz) | `0% <0%> (ø)` | |
   | [...ets/src/dashboard/components/dnd/DragDroppable.jsx](https://codecov.io/gh/apache/incubator-superset/pull/6773/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9kYXNoYm9hcmQvY29tcG9uZW50cy9kbmQvRHJhZ0Ryb3BwYWJsZS5qc3g=) | `97.14% <0%> (ø)` | |
   | [...c/visualizations/deckgl/layers/Polygon/Polygon.jsx](https://codecov.io/gh/apache/incubator-superset/pull/6773/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy92aXN1YWxpemF0aW9ucy9kZWNrZ2wvbGF5ZXJzL1BvbHlnb24vUG9seWdvbi5qc3g=) | `0% <0%> (ø)` | |
   | [...ssets/src/visualizations/presets/MapChartPreset.js](https://codecov.io/gh/apache/incubator-superset/pull/6773/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy92aXN1YWxpemF0aW9ucy9wcmVzZXRzL01hcENoYXJ0UHJlc2V0Lmpz) | `0% <0%> (ø)` | |
   | [superset/assets/src/components/EditableTitle.jsx](https://codecov.io/gh/apache/incubator-superset/pull/6773/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9jb21wb25lbnRzL0VkaXRhYmxlVGl0bGUuanN4) | `77.14% <0%> (ø)` | |
   | [...assets/src/visualizations/Iframe/transformProps.js](https://codecov.io/gh/apache/incubator-superset/pull/6773/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy92aXN1YWxpemF0aW9ucy9JZnJhbWUvdHJhbnNmb3JtUHJvcHMuanM=) | `0% <0%> (ø)` | |
   | [superset/assets/src/setup/setupPlugins.js](https://codecov.io/gh/apache/incubator-superset/pull/6773/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9zZXR1cC9zZXR1cFBsdWdpbnMuanM=) | `0% <0%> (ø)` | |
   | [...t/assets/src/components/InfoTooltipWithTrigger.jsx](https://codecov.io/gh/apache/incubator-superset/pull/6773/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9jb21wb25lbnRzL0luZm9Ub29sdGlwV2l0aFRyaWdnZXIuanN4) | `41.66% <0%> (ø)` | |
   | ... and [441 more](https://codecov.io/gh/apache/incubator-superset/pull/6773/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/6773?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/6773?src=pr&el=footer). Last update [83ee917...26fccbc](https://codecov.io/gh/apache/incubator-superset/pull/6773?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org