You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/05/26 15:27:36 UTC
[GitHub] [arrow-datafusion] andygrove opened a new pull request, #2623: Datafusion proto deps
andygrove opened a new pull request, #2623:
URL: https://github.com/apache/arrow-datafusion/pull/2623
# Which issue does this PR close?
<!--
We generally require a GitHub issue to be filed for all bug fixes and enhancements and this helps us generate change logs for our releases. You can link an issue to this PR using the GitHub syntax. For example `Closes #123` indicates that this PR will close issue #123.
-->
N/A
# Rationale for this change
<!--
Why are you proposing this change? If this is already explained clearly in the issue then this section is not needed.
Explaining clearly why changes are proposed helps reviewers understand your changes and offer better suggestions for fixes.
-->
This PR adds specific dependencies on `datafusion-common` and `datafusion-expr` and updates the imports to reference those crates directly rather than use the re-exports from the core `datafusion` crate.
The implementation of `datafusion-proto` now only depends on a single item from the core crate and that is `FunctionRegistry`. We could potentially move this out in the future so that other projects can use `datafusion-proto` without depending on the core crate.
# What changes are included in this PR?
<!--
There is no need to duplicate the description in the issue here but it is sometimes worth providing a summary of the individual changes in this PR.
-->
Add new dependencies in Cargo.toml and refactor the imports
# Are there any user-facing changes?
<!--
If there are user-facing changes then we may require documentation to be updated before approving the PR.
-->
No
<!--
If there are any breaking changes to public APIs, please add the `api change` label.
-->
# Does this PR break compatibility with Ballista?
No
<!--
The CI checks will attempt to build [arrow-ballista](https://github.com/apache/arrow-ballista) against this PR. If
this check fails then it indicates that this PR makes a breaking change to the DataFusion API.
If possible, try to make the change in a way that is not a breaking API change. For example, if code has moved
around, try adding `pub use` from the original location to preserve the current API.
If it is not possible to avoid a breaking change (such as when adding enum variants) then follow this process:
- Make a corresponding PR against `arrow-ballista` with the changes required there
- Update `dev/build-arrow-ballista.sh` to clone the appropriate `arrow-ballista` repo & branch
- Merge this PR when CI passes
- Merge the Ballista PR
- Create a new PR here to reset `dev/build-arrow-ballista.sh` to point to `arrow-ballista` master again
_If you would like to help improve this process, please see https://github.com/apache/arrow-datafusion/issues/2583_
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] alamb merged pull request #2623: MINOR: Refactor `datafusion-proto` dependencies and imports
Posted by GitBox <gi...@apache.org>.
alamb merged PR #2623:
URL: https://github.com/apache/arrow-datafusion/pull/2623
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org