You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cordova.apache.org by dpogue <gi...@git.apache.org> on 2016/06/07 22:49:59 UTC
[GitHub] cordova-ios pull request #228: [CB-10916] Support display name for iOS
GitHub user dpogue opened a pull request:
https://github.com/apache/cordova-ios/pull/228
[CB-10916] Support display name for iOS
This is the iOS Platform API support side of https://github.com/apache/cordova-lib/pull/453.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/dpogue/cordova-ios short-name
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-ios/pull/228.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #228
----
commit 322bd50cf9ae5db857655bdc0da78dae07a12ade
Author: Darryl Pogue <da...@ayogo.com>
Date: 2016-06-07T22:47:38Z
[CB-10916] Support display name for iOS
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-ios issue #228: [CB-10916] Support display name for iOS
Posted by fredgalvao <gi...@git.apache.org>.
Github user fredgalvao commented on the issue:
https://github.com/apache/cordova-ios/pull/228
Should my previous comment go into an issue dedicated to discussion? There was no feedback on it, and it seems like there is a consensus into doing the simple version, which imo doesn't actually solve the root problem (and could solve many other problems if overhauled).
@shazron @dpogue I'm honestly interested in at least knowing your reasoning and opinion regarding my previously stated PoV on the topic. Who knows, maybe I'm even using an overly complex solution on my side.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-ios issue #228: [CB-10916] Support display name for iOS
Posted by dpogue <gi...@git.apache.org>.
Github user dpogue commented on the issue:
https://github.com/apache/cordova-ios/pull/228
Rebased, but still blocked on the cordova-lib PR
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-ios issue #228: [CB-10916] Support display name for iOS
Posted by shazron <gi...@git.apache.org>.
Github user shazron commented on the issue:
https://github.com/apache/cordova-ios/pull/228
This PR needs to be re-based.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-ios issue #228: [CB-10916] Support display name for iOS
Posted by shazron <gi...@git.apache.org>.
Github user shazron commented on the issue:
https://github.com/apache/cordova-ios/pull/228
Pull in when we bundle update to the released cordova-common that includes https://github.com/apache/cordova-lib/pull/453
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-ios issue #228: [CB-10916] Support display name for iOS
Posted by shazron <gi...@git.apache.org>.
Github user shazron commented on the issue:
https://github.com/apache/cordova-ios/pull/228
I would like this in 4.3.0. Hopefully we can resolve https://github.com/apache/cordova-lib/pull/453 for cordova-cli 6.4.0
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-ios pull request #228: [CB-10916] Support display name for iOS
Posted by dpogue <gi...@git.apache.org>.
Github user dpogue closed the pull request at:
https://github.com/apache/cordova-ios/pull/228
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-ios issue #228: [CB-10916] Support display name for iOS
Posted by codecov-io <gi...@git.apache.org>.
Github user codecov-io commented on the issue:
https://github.com/apache/cordova-ios/pull/228
## [Current coverage][cc-pull] is **51.97%**
> Merging [#228][cc-pull] into [master][cc-base-branch] will increase coverage by **0.16%**
```diff
@@ master #228 diff @@
==========================================
Files 11 11
Lines 882 885 +3
Methods 132 132
Messages 0 0
Branches 143 145 +2
==========================================
+ Hits 457 460 +3
Misses 425 425
Partials 0 0
```
> Powered by [Codecov](https://codecov.io?src=pr). Last updated by [2e41e22...322bd50][cc-compare]
[cc-base-branch]: https://codecov.io/gh/apache/cordova-ios/branch/master?src=pr
[cc-compare]: https://codecov.io/gh/apache/cordova-ios/compare/2e41e221d50dd00b832879cd3b4ced372f8be428...322bd50cf9ae5db857655bdc0da78dae07a12ade
[cc-pull]: https://codecov.io/gh/apache/cordova-ios/pull/228?src=pr
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-ios pull request #228: [CB-10916] Support display name for iOS
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-ios/pull/228
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-ios issue #228: [CB-10916] Support display name for iOS
Posted by dpogue <gi...@git.apache.org>.
Github user dpogue commented on the issue:
https://github.com/apache/cordova-ios/pull/228
@fredgalvao Personally, I think your idea is the right way to go in terms of project structure, and should definitely be brought up for discussion on the dev list (because it probably has implications beyond just the display name of the app and because we'd probably want all supported platforms to agree). The scope for this particular PR is just to update the name in the Info.plist.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-ios issue #228: [CB-10916] Support display name for iOS
Posted by shazron <gi...@git.apache.org>.
Github user shazron commented on the issue:
https://github.com/apache/cordova-ios/pull/228
@dpogue looks like a Simulator timeout. Can you close and re-open the PR to trigger the CI again
@fredgalvao ditto what @dpogue said
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-ios issue #228: [CB-10916] Support display name for iOS
Posted by dpogue <gi...@git.apache.org>.
Github user dpogue commented on the issue:
https://github.com/apache/cordova-ios/pull/228
@shazron This can go in to 4.4.1 now that cordova-common changes are merged
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-ios issue #228: [CB-10916] Support display name for iOS
Posted by dpogue <gi...@git.apache.org>.
Github user dpogue commented on the issue:
https://github.com/apache/cordova-ios/pull/228
@shazron All good now :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-ios pull request #228: [CB-10916] Support display name for iOS
Posted by dpogue <gi...@git.apache.org>.
GitHub user dpogue reopened a pull request:
https://github.com/apache/cordova-ios/pull/228
[CB-10916] Support display name for iOS
This is the iOS Platform API support side of https://github.com/apache/cordova-lib/pull/453.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/dpogue/cordova-ios short-name
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-ios/pull/228.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #228
----
commit 92d9cdaacc698f23100df500edf35ff7f3c17fd1
Author: Darryl Pogue <da...@ayogo.com>
Date: 2016-06-07T22:47:38Z
[CB-10916] Support display name for iOS
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-ios pull request #228: [CB-10916] Support display name for iOS
Posted by dpogue <gi...@git.apache.org>.
Github user dpogue closed the pull request at:
https://github.com/apache/cordova-ios/pull/228
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-ios issue #228: [CB-10916] Support display name for iOS
Posted by fredgalvao <gi...@git.apache.org>.
Github user fredgalvao commented on the issue:
https://github.com/apache/cordova-ios/pull/228
Is there any reason why this PR doesn't also export `CFBundleName` as the result of the short name on config.xml? Follow me for a while:
According to [this page on the developer portal](https://developer.apple.com/library/content/qa/qa1892/_index.html) it seems like these two properties go along and, unless they are too big, should most probably have the same value.
Now, with the recent findings and issues related to renaming projects (which causes malformed pbxproj files and unsolvable string search&replace operations), it seems to me like we could simply leave the project structure and project name (not to be confused with app name) a generic static value, and deal with the `<name>` and `<short-name>` outputing them to `CFBundleDisplayName` and `CFBundleName` respectively.
That's what I did when I evolved my cordova project into a whitelabel, so that I could generate different apps with the same code base. However, in my case I needed to use a string replacement on `build.gradle` to set the `applicationId` on android (the app name works fine, it's updated in the string.xml correctly and my main activity class doesn't need to be renamed). There's an [issue](https://issues.apache.org/jira/browse/CB-11374) for the `applicationId` thing too, btw. On iOS, I also had to use [cordova-plugin-app-name](https://github.com/blakgeek/cordova-plugin-app-name/blob/master/plugin.xml) to deal with the "renaming breaks the project" issue (leaving the `<name>` untouched, otherwise I'd be screwed).
## Summary of my _opinion_
To evolve into a more whitelabel-friendly structure with respect to naming apps:
- Evolve `<name>` and `<short-name>` handling to affect **ONLY** {`strings.xml`@`app_name`} on android, and {`CFBundleName` + `CFBundleDisplayName`} on iOS, leaving the following items with a generic static name [activity class name on android, xcode project files (plist, pbxproj)].
Please @shazron and @dpogue tell me what you think of all of this.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-ios pull request #228: [CB-10916] Support display name for iOS
Posted by dpogue <gi...@git.apache.org>.
GitHub user dpogue reopened a pull request:
https://github.com/apache/cordova-ios/pull/228
[CB-10916] Support display name for iOS
This is the iOS Platform API support side of https://github.com/apache/cordova-lib/pull/453.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/dpogue/cordova-ios short-name
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-ios/pull/228.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #228
----
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-ios issue #228: [CB-10916] Support display name for iOS
Posted by shazron <gi...@git.apache.org>.
Github user shazron commented on the issue:
https://github.com/apache/cordova-ios/pull/228
@dpogue bah, same timeout error. Please do the close and re-open PR dance again
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org