You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@ignite.apache.org by GitBox <gi...@apache.org> on 2022/09/13 07:47:14 UTC

[GitHub] [ignite] ivandasch commented on a diff in pull request #10229: IGNITE-17442 Highlight test console output.

ivandasch commented on code in PR #10229:
URL: https://github.com/apache/ignite/pull/10229#discussion_r969266147


##########
docs/_docs/logging.adoc:
##########
@@ -77,6 +77,8 @@ In the above example, the path to `log4j2-config.xml` can be either an absolute
 
 NOTE: Log4j2 supports runtime reconfiguration, i.e. changes in the configuration file is applied without the need to restart the application.
 
+NOTE: `log4j2-config.xml` enables colorization of console output by default. This feature works out of the box on many operating systems, except for Windows. If you would like to enable this feature on Windows, follow the https://logging.apache.org/log4j/2.x/manual/layouts.html#ANSI_Styling_on_Windows[official log4j2 instructions].

Review Comment:
   English mistake -- `If you want to enable this feature on Windows, please follow the...`
   You must not use `would` in a condition clause.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org