You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ranger.apache.org by Madhan Neethiraj <ma...@apache.org> on 2022/03/04 04:32:52 UTC

Review Request 73886: RANGER-3652: updated resource-matcher unit tests to include tests for wildcard=false

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73886/
-----------------------------------------------------------

Review request for ranger, Ankita Sinha, Kishor Gollapalliwar, Abhay Kulkarni, Mehul Parikh, Pradeep Agrawal, Ramesh Mani, Sailaja Polavarapu, and Velmurugan Periasamy.


Bugs: RANGER-3652
    https://issues.apache.org/jira/browse/RANGER-3652


Repository: ranger


Description
-------

- added unit tests to cover wildcard=false case
- fixed unit tests to correctly initialize the matcher with options


Diffs
-----

  agents-common/src/test/java/org/apache/ranger/plugin/resourcematcher/RangerDefaultResourceMatcherTest.java c635e0ded 
  agents-common/src/test/java/org/apache/ranger/plugin/resourcematcher/RangerPathResourceMatcherTest.java 1425027da 
  agents-common/src/test/java/org/apache/ranger/plugin/resourcematcher/RangerURLResourceMatcherTest.java 2762932d3 


Diff: https://reviews.apache.org/r/73886/diff/1/


Testing
-------

- verified that all unit tests pass successfully


Thanks,

Madhan Neethiraj


Re: Review Request 73886: RANGER-3652: updated resource-matcher unit tests to include tests for wildcard=false

Posted by Ramesh Mani <rm...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73886/#review224125
-----------------------------------------------------------


Ship it!




Ship It!

- Ramesh Mani


On March 4, 2022, 4:32 a.m., Madhan Neethiraj wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/73886/
> -----------------------------------------------------------
> 
> (Updated March 4, 2022, 4:32 a.m.)
> 
> 
> Review request for ranger, Ankita Sinha, Kishor Gollapalliwar, Abhay Kulkarni, Mehul Parikh, Pradeep Agrawal, Ramesh Mani, Sailaja Polavarapu, and Velmurugan Periasamy.
> 
> 
> Bugs: RANGER-3652
>     https://issues.apache.org/jira/browse/RANGER-3652
> 
> 
> Repository: ranger
> 
> 
> Description
> -------
> 
> - added unit tests to cover wildcard=false case
> - fixed unit tests to correctly initialize the matcher with options
> 
> 
> Diffs
> -----
> 
>   agents-common/src/test/java/org/apache/ranger/plugin/resourcematcher/RangerDefaultResourceMatcherTest.java c635e0ded 
>   agents-common/src/test/java/org/apache/ranger/plugin/resourcematcher/RangerPathResourceMatcherTest.java 1425027da 
>   agents-common/src/test/java/org/apache/ranger/plugin/resourcematcher/RangerURLResourceMatcherTest.java 2762932d3 
> 
> 
> Diff: https://reviews.apache.org/r/73886/diff/1/
> 
> 
> Testing
> -------
> 
> - verified that all unit tests pass successfully
> 
> 
> Thanks,
> 
> Madhan Neethiraj
> 
>