[GitHub] [hive] deniskuzZ commented on a change in pull request #3102: HIVE-25977: Addendum

[GitBox <gi...@apache.org>]

deniskuzZ commented on a change in pull request #3102:
URL: https://github.com/apache/hive/pull/3102#discussion_r833010456



##########
File path: ql/src/test/org/apache/hadoop/hive/ql/txn/compactor/CompactorTest.java
##########
@@ -401,7 +401,7 @@ private void addFile(Table t, Partition p, long minTxn, long maxTxn, int numReco
     switch (type) {
       case BASE: filename = AcidUtils.BASE_PREFIX + maxTxn + (visibilityId > 0 ? AcidUtils.VISIBILITY_PREFIX + visibilityId : ""); break;
       case LENGTH_FILE: // Fall through to delta
-      case DELTA: filename = makeDeltaDirName(minTxn, maxTxn); break;
+      case DELTA: filename = AcidUtils.addVisibilitySuffix(makeDeltaDirName(minTxn, maxTxn),visibilityId); break;

Review comment:
       I followed the same approach as for the BASE folder: if we won't provide `visibilityId` - 0 value would be passed instead and the final path would be for uncompacted data.
   Renaming of base methods (addBase/DeltaFile => addCompactedStuff) leads to multiple file changes. I think it's better to address this in a separate `refactoring `JIRA.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org