You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "hussein-awala (via GitHub)" <gi...@apache.org> on 2023/03/12 17:42:17 UTC

[GitHub] [airflow] hussein-awala opened a new pull request, #30055: Remove unused key_id variable

hussein-awala opened a new pull request, #30055:
URL: https://github.com/apache/airflow/pull/30055

   The variable `key_id` loaded from connection extra is not used, we pass directly the connection login to the client, and since we already deprecated `role_id` and we asked the users to use connection login, I think we can just remove this code instead of replacing `key_id=self.connection.login` by `key_id=key_id` and add a deprecation warning.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [airflow] potiuk merged pull request #30055: Remove unused key_id variable

Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk merged PR #30055:
URL: https://github.com/apache/airflow/pull/30055


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org