[jira] [Resolved] (IMPALA-5787) Dropped Status in KuduTableSink::Send()

["Thomas Tauber-Marshall (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/IMPALA-5787?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Thomas Tauber-Marshall resolved IMPALA-5787.
--------------------------------------------
       Resolution: Fixed
    Fix Version/s: Impala 2.10.0

commit 8149dbfc9cc0898a7b376d754ac36b9c314ba71e
Author: Thomas Tauber-Marshall <tm...@cloudera.com>
Date:   Fri Aug 11 10:36:45 2017 -0700

    IMPALA-5787: Dropped status in KuduTableSink::Send()
    
    KuduTableSink drops the Status returned from WriteKuduValue(),
    potentially hiding failures.
    
    There are only two possible ways WriteKuduValue() can fail: one of the
    KuduPartialRow::Set<Type> functions fails, which can only happen if
    the specified type is incorrect, which would be a bug in planning and
    is therefore DCHECK-able, or if TimestampValue::UtcToUnixTimeMicros()
    fails, which WriteKuduValue() DCHECKs against but also has a path to
    return the error in release builds.
    
    So similarly, this patch adds a DCHECK that the status is OK, and a
    path to return the error in release builds.
    
    It also adds WARN_UNUSED_RESULT to WriteKuduValue() to prevent similar
    bugs in the future.
    
    Testing:
    - Ran the Kudu tests.
    
    Change-Id: Ia228d98ca90de8638b0afcc242c788e225fb450f
    Reviewed-on: http://gerrit.cloudera.org:8080/7667
    Reviewed-by: Tim Armstrong <ta...@cloudera.com>
    Reviewed-by: Matthew Jacobs <mj...@cloudera.com>
    Tested-by: Impala Public Jenkins

> Dropped Status in KuduTableSink::Send()
> ---------------------------------------
>
>                 Key: IMPALA-5787
>                 URL: https://issues.apache.org/jira/browse/IMPALA-5787
>             Project: IMPALA
>          Issue Type: Bug
>          Components: Backend
>    Affects Versions: Impala 2.9.0, Impala 2.10.0
>            Reporter: Tim Armstrong
>            Assignee: Thomas Tauber-Marshall
>              Labels: kudu
>             Fix For: Impala 2.10.0
>
>
> The Status from WriteKuduValue() is dropped. I'm unsure what symptoms this would cause but it might be bad. Found as part of IMPALA-2615



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)