You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@jmeter.apache.org by ham1 <gi...@git.apache.org> on 2017/11/20 13:46:18 UTC
[GitHub] jmeter pull request #333: Added header check to checkstyle, fixed errors and...
GitHub user ham1 opened a pull request:
https://github.com/apache/jmeter/pull/333
Added header check to checkstyle, fixed errors and minor cleanup
## Description
Added Java Apache licence header check, used a regex so that we don't have to change 100s of files and it still does the job of catching any file with a missing header, however it doesn't match the current format listed http://www.apache.org/dev/apply-license.html but it matches the majority of the ones in the code base at the moment.
## Motivation and Context
Prevent/notify when files are missing a header rather than rely on someone spotting it.
## How Has This Been Tested?
`ant checkstyle`
## Screenshots (if appropriate):
## Types of changes
<!--- What types of changes does your code introduce? Delete as appropriate -->
- Dev enhancement
## Checklist:
<!--- Go over all the following points, and put an `x` in all the boxes that apply. -->
<!--- If you're unsure about any of these, don't hesitate to ask. We're here to help! -->
- [x] My code follows the [code style][style-guide] of this project.
- [ ] I have updated the documentation accordingly.
[style-guide]: https://wiki.apache.org/jmeter/CodeStyleGuidelines
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/ham1/jmeter checkstyle-improvements
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/jmeter/pull/333.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #333
----
commit 4bf9d4082832269ad737832659d4160aab767cd3
Author: Graham Russell <gr...@ham1.co.uk>
Date: 2017-11-20T01:35:03Z
Added header check to checkstyle, fixed errors and minor cleanup
----
---
[GitHub] jmeter pull request #333: Added header check to checkstyle, fixed errors and...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/jmeter/pull/333
---
[GitHub] jmeter issue #333: Added header check to checkstyle, fixed errors and minor ...
Posted by codecov-io <gi...@git.apache.org>.
Github user codecov-io commented on the issue:
https://github.com/apache/jmeter/pull/333
# [Codecov](https://codecov.io/gh/apache/jmeter/pull/333?src=pr&el=h1) Report
> Merging [#333](https://codecov.io/gh/apache/jmeter/pull/333?src=pr&el=desc) into [trunk](https://codecov.io/gh/apache/jmeter/commit/94a658650932bccafb6ea8c73b2b2269fd1c8826?src=pr&el=desc) will **decrease** coverage by `<.01%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/jmeter/pull/333?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## trunk #333 +/- ##
============================================
- Coverage 57.86% 57.86% -0.01%
+ Complexity 9994 9993 -1
============================================
Files 1146 1146
Lines 73614 73614
Branches 7312 7312
============================================
- Hits 42598 42596 -2
Misses 28539 28539
- Partials 2477 2479 +2
```
| [Impacted Files](https://codecov.io/gh/apache/jmeter/pull/333?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...he/jmeter/visualizers/backend/BackendListener.java](https://codecov.io/gh/apache/jmeter/pull/333?src=pr&el=tree#diff-c3JjL2NvbXBvbmVudHMvb3JnL2FwYWNoZS9qbWV0ZXIvdmlzdWFsaXplcnMvYmFja2VuZC9CYWNrZW5kTGlzdGVuZXIuamF2YQ==) | `10.34% <ø> (ø)` | `7 <0> (ø)` | :arrow_down: |
| [...org/apache/jmeter/util/CustomX509TrustManager.java](https://codecov.io/gh/apache/jmeter/pull/333?src=pr&el=tree#diff-c3JjL2NvcmUvb3JnL2FwYWNoZS9qbWV0ZXIvdXRpbC9DdXN0b21YNTA5VHJ1c3RNYW5hZ2VyLmphdmE=) | `20.68% <ø> (ø)` | `4 <0> (ø)` | :arrow_down: |
| [...apache/jmeter/protocol/http/gui/DNSCachePanel.java](https://codecov.io/gh/apache/jmeter/pull/333?src=pr&el=tree#diff-c3JjL3Byb3RvY29sL2h0dHAvb3JnL2FwYWNoZS9qbWV0ZXIvcHJvdG9jb2wvaHR0cC9ndWkvRE5TQ2FjaGVQYW5lbC5qYXZh) | `59.4% <ø> (ø)` | `15 <0> (ø)` | :arrow_down: |
| [...meter/protocol/http/control/gui/AjpSamplerGui.java](https://codecov.io/gh/apache/jmeter/pull/333?src=pr&el=tree#diff-c3JjL3Byb3RvY29sL2h0dHAvb3JnL2FwYWNoZS9qbWV0ZXIvcHJvdG9jb2wvaHR0cC9jb250cm9sL2d1aS9BanBTYW1wbGVyR3VpLmphdmE=) | `100% <ø> (ø)` | `4 <0> (ø)` | :arrow_down: |
| [...er/visualizers/backend/BackendListenerContext.java](https://codecov.io/gh/apache/jmeter/pull/333?src=pr&el=tree#diff-c3JjL2NvbXBvbmVudHMvb3JnL2FwYWNoZS9qbWV0ZXIvdmlzdWFsaXplcnMvYmFja2VuZC9CYWNrZW5kTGlzdGVuZXJDb250ZXh0LmphdmE=) | `0% <ø> (ø)` | `0 <0> (ø)` | :arrow_down: |
| [...pache/jmeter/assertions/gui/SMIMEAssertionGui.java](https://codecov.io/gh/apache/jmeter/pull/333?src=pr&el=tree#diff-c3JjL2NvbXBvbmVudHMvb3JnL2FwYWNoZS9qbWV0ZXIvYXNzZXJ0aW9ucy9ndWkvU01JTUVBc3NlcnRpb25HdWkuamF2YQ==) | `80.45% <ø> (ø)` | `9 <0> (ø)` | :arrow_down: |
| [...c/core/org/apache/jmeter/threads/JMeterThread.java](https://codecov.io/gh/apache/jmeter/pull/333?src=pr&el=tree#diff-c3JjL2NvcmUvb3JnL2FwYWNoZS9qbWV0ZXIvdGhyZWFkcy9KTWV0ZXJUaHJlYWQuamF2YQ==) | `70.52% <ø> (ø)` | `93 <0> (ø)` | :arrow_down: |
| [...apache/jmeter/util/JMeterTreeNodeTransferable.java](https://codecov.io/gh/apache/jmeter/pull/333?src=pr&el=tree#diff-c3JjL2NvcmUvb3JnL2FwYWNoZS9qbWV0ZXIvdXRpbC9KTWV0ZXJUcmVlTm9kZVRyYW5zZmVyYWJsZS5qYXZh) | `0% <ø> (ø)` | `0 <0> (ø)` | :arrow_down: |
| [...pache/jmeter/protocol/http/sampler/AjpSampler.java](https://codecov.io/gh/apache/jmeter/pull/333?src=pr&el=tree#diff-c3JjL3Byb3RvY29sL2h0dHAvb3JnL2FwYWNoZS9qbWV0ZXIvcHJvdG9jb2wvaHR0cC9zYW1wbGVyL0FqcFNhbXBsZXIuamF2YQ==) | `5.61% <ø> (ø)` | `2 <0> (ø)` | :arrow_down: |
| [src/jorphan/org/apache/log/Logger.java](https://codecov.io/gh/apache/jmeter/pull/333?src=pr&el=tree#diff-c3JjL2pvcnBoYW4vb3JnL2FwYWNoZS9sb2cvTG9nZ2VyLmphdmE=) | `0% <ø> (ø)` | `0 <0> (ø)` | :arrow_down: |
| ... and [9 more](https://codecov.io/gh/apache/jmeter/pull/333?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/jmeter/pull/333?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/jmeter/pull/333?src=pr&el=footer). Last update [94a6586...4bf9d40](https://codecov.io/gh/apache/jmeter/pull/333?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
---