You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@fineract.apache.org by GitBox <gi...@apache.org> on 2021/03/15 19:20:14 UTC

[GitHub] [fineract-cn-mobile] EGOR-IND opened a new pull request #135: add browse content functionality for identification card upload

EGOR-IND opened a new pull request #135:
URL: https://github.com/apache/fineract-cn-mobile/pull/135


   Fixes #Issue_number
   
   https://user-images.githubusercontent.com/56648862/111208869-52575600-85f1-11eb-8194-933826038371.mp4
   
   Added the functionality for browsing images from phone storage for uploading identification card scan.
   
   Please make sure these boxes are checked before submitting your pull request - thanks!
   
   - [x] Apply the `AndroidStyle.xml` style template to your code in Android Studio.
   
   - [x] Run the unit tests with `./gradlew check` to make sure you didn't break anything.
   
   - [x] If you have multiple commits please combine them into one commit by squashing them.
   
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [fineract-cn-mobile] EGOR-IND commented on pull request #135: add browse content functionality for identification card upload

Posted by GitBox <gi...@apache.org>.
EGOR-IND commented on pull request #135:
URL: https://github.com/apache/fineract-cn-mobile/pull/135#issuecomment-800345603


   @jawidMuhammadi please review this when you have time:).


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [fineract-cn-mobile] PatelVatsalB21 removed a comment on pull request #135: add browse content functionality for identification card upload

Posted by GitBox <gi...@apache.org>.
PatelVatsalB21 removed a comment on pull request #135:
URL: https://github.com/apache/fineract-cn-mobile/pull/135#issuecomment-800107580


   @EGOR-IND can't we have cancel and upload below upper buttons. It looks slightly shifted to left. Also [jawidMuhammadi](https://github.com/jawidMuhammadi) yesterday told me to add jira ticket of issue so if you also add it it would be icing on the cake :)


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [fineract-cn-mobile] EGOR-IND edited a comment on pull request #135: add browse content functionality for identification card upload

Posted by GitBox <gi...@apache.org>.
EGOR-IND edited a comment on pull request #135:
URL: https://github.com/apache/fineract-cn-mobile/pull/135#issuecomment-800345603


   @jawidMuhammadi please review this when you have time:), one more question there is another issue, same issue that I resolved in #134. So my question is should I resolve this issue in this PR or raise another one because squashing a new commit in this PR will make the merging more convenient.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [fineract-cn-mobile] PatelVatsalB21 commented on pull request #135: add browse content functionality for identification card upload

Posted by GitBox <gi...@apache.org>.
PatelVatsalB21 commented on pull request #135:
URL: https://github.com/apache/fineract-cn-mobile/pull/135#issuecomment-800107580


   @EGOR-IND can't we have cancel and upload below upper buttons. It looks slightly shifted to left. Also [jawidMuhammadi](https://github.com/jawidMuhammadi) yesterday told me to add jira ticket of issue so if you also add it it would be icing on the cake :)


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [fineract-cn-mobile] EGOR-IND commented on pull request #135: add browse content functionality for identification card upload

Posted by GitBox <gi...@apache.org>.
EGOR-IND commented on pull request #135:
URL: https://github.com/apache/fineract-cn-mobile/pull/135#issuecomment-800114070


   > @EGOR-IND can't we have cancel and upload below upper buttons. It looks slightly shifted to left. Also [jawidMuhammadi](https://github.com/jawidMuhammadi) yesterday told me to add jira ticket of issue so if you also add it it would be icing on the cake :)
   
   Yeah we can shift it but I didn't wanted to change the whole layout the position of upload and cancel buttons was already there. I just simply added a linear layout. But if an authorized person permits i will change it. But I personally think it looks good, looks like a form to meet 😊.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org