[jira] [Work logged] (BEAM-4374) Update existing metrics in the FN API to use new Metric Schema

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/BEAM-4374?focusedWorklogId=133819&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-133819 ]

ASF GitHub Bot logged work on BEAM-4374:
----------------------------------------

                Author: ASF GitHub Bot
            Created on: 10/Aug/18 21:33
            Start Date: 10/Aug/18 21:33
    Worklog Time Spent: 10m 
      Work Description: ajamato commented on a change in pull request #6205: [BEAM-4374] Implementing a subset of the new metrics framework in python.
URL: https://github.com/apache/beam/pull/6205#discussion_r209389982
 
 

 ##########
 File path: sdks/python/apache_beam/runners/worker/bundle_processor.py
 ##########
 @@ -313,6 +313,14 @@ def metrics(self):
             self._fix_output_tags(transform_id, op.progress_metrics())
             for transform_id, op in self.ops.items()})
 
+  def monitoring_infos(self):
 
 Review comment:
   Curious about reviewer thoughts on how to test this best. Would it make sense to test BundleProcessor on its own? It might be a bit complex to set this up, not sure if this is the kind of testing approach that we want for beam.
   
   Currently I have tested this indirectly via fn_api_runner_test (this is how the existing user metrics were being tested, the 'system' element count and processing time metrics were not tested at all :( )

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Issue Time Tracking
-------------------

            Worklog Id:     (was: 133819)
            Time Spent: 10m
    Remaining Estimate: 0h

> Update existing metrics in the FN API to use new Metric Schema
> --------------------------------------------------------------
>
>                 Key: BEAM-4374
>                 URL: https://issues.apache.org/jira/browse/BEAM-4374
>             Project: Beam
>          Issue Type: New Feature
>          Components: beam-model
>            Reporter: Alex Amato
>            Priority: Major
>          Time Spent: 10m
>  Remaining Estimate: 0h
>
> Update existing metrics to use the new proto and cataloging schema defined in:
> [_https://s.apache.org/beam-fn-api-metrics_]
>  * Check in new protos
>  * Define catalog file for metrics
>  * Port existing metrics to use this new format, based on catalog names+metadata



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)