You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-issues@hadoop.apache.org by "Hadoop QA (JIRA)" <ji...@apache.org> on 2012/06/04 11:06:23 UTC
[jira] [Commented] (HADOOP-8471) Make ReplicaPlacementPolicyDefault
extensible for reuse code in subclass
[ https://issues.apache.org/jira/browse/HADOOP-8471?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13288435#comment-13288435 ]
Hadoop QA commented on HADOOP-8471:
-----------------------------------
+1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12530739/Hadoop-8471-BlockPlacementDefault-extensible.patch
against trunk revision .
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 1 new or modified test files.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 eclipse:eclipse. The patch built with eclipse:eclipse.
+1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
+1 core tests. The patch passed unit tests in hadoop-hdfs-project/hadoop-hdfs.
+1 contrib tests. The patch passed contrib unit tests.
Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/1077//testReport/
Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/1077//console
This message is automatically generated.
> Make ReplicaPlacementPolicyDefault extensible for reuse code in subclass
> ------------------------------------------------------------------------
>
> Key: HADOOP-8471
> URL: https://issues.apache.org/jira/browse/HADOOP-8471
> Project: Hadoop Common
> Issue Type: Sub-task
> Components: ha, io
> Affects Versions: 1.0.0, 2.0.0-alpha
> Reporter: Junping Du
> Assignee: Junping Du
> Attachments: Hadoop-8471-BlockPlacementDefault-extensible.patch
>
>
> ReplicaPlacementPolicy is already a pluggable component in Hadoop. A user specified ReplicaPlacementPolicy can be specified in the hdfs-site.xml configuration under the key "dfs.block.replicator.classname". However, to make it possible to reuse code in ReplicaPlacementPolicyDefault a few of its methods were changed from private to protected. ReplicaPlacementPolicy and BlockPlacementPolicyDefault are currently annotated with @InterfaceAudience.Private.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira