[GitHub] [spark] rangadi commented on a diff in pull request #38335: [SPARK-40796][CONNECT][FOLLOW-UP] Improve README for proto generated files in Connect Python client

[GitBox <gi...@apache.org>]

rangadi commented on code in PR #38335:
URL: https://github.com/apache/spark/pull/38335#discussion_r1002173180


##########
dev/check-codegen-python.py:
##########
@@ -75,7 +75,9 @@ def check_connect_protos():
         else:
             fail(
                 "Generated files for pyspark-connect are out of sync! "
-                "Please run ./connector/connect/dev/generate_protos.sh"
+                "If you have touched files under connector/connect/src/main/protobuf, "
+                "please run ./connector/connect/dev/generate_protos.sh. "
+                "If you haven't touched any file above, please rebase your PR against main branch."

Review Comment:
   How does rebase help? I think ci/cd merges with master.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org