[GitHub] [incubator-pinot] jackjlli commented on a change in pull request #4236: Add metric on ControllerLeadershipManager

[GitBox <gi...@apache.org>]

jackjlli commented on a change in pull request #4236: Add metric on ControllerLeadershipManager
URL: https://github.com/apache/incubator-pinot/pull/4236#discussion_r287087646
 
 

 ##########
 File path: pinot-controller/src/main/java/org/apache/pinot/controller/ControllerLeadershipManager.java
 ##########
 @@ -35,12 +37,14 @@
   private static final Logger LOGGER = LoggerFactory.getLogger(ControllerLeadershipManager.class);
 
   private HelixManager _helixManager;
+  private ControllerMetrics _controllerMetrics;
   private volatile boolean _amILeader = false;
 
   private Map<String, LeadershipChangeSubscriber> _subscribers = new ConcurrentHashMap<>();
 
-  public ControllerLeadershipManager(HelixManager helixManager) {
+  public ControllerLeadershipManager(HelixManager helixManager, ControllerMetrics controllerMetrics) {
     _helixManager = helixManager;
+    _controllerMetrics = controllerMetrics;
 
 Review comment:
   Done.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org