You are viewing a plain text version of this content. The canonical link for it is here.
Posted to ivy-dev@incubator.apache.org by Maarten Coene <ma...@yahoo.com> on 2007/03/08 10:33:18 UTC

Re: [jira] Commented: (IVY-366) Scope and status leakage during build lifecycle

Xavier,

I've moved the XmlReportOutputter.getReportFileName method to the CacheManager. I think all files that are put in the cache or retrieved from the cache should go through the CacheManager. This will make things easier when we change something about the cache mechanism later.

You're right about the ResolveTest: it should probably use the CacheManager to retrieve the filename instead of construct the name itself.
I'll modify this when I have some time.

regards,
Maarten


----- Original Message ----
From: Xavier Hanin (JIRA) <ji...@apache.org>
To: ivy-commits@incubator.apache.org
Sent: Thursday, March 8, 2007 8:52:24 AM
Subject: [jira] Commented: (IVY-366) Scope and status leakage during build lifecycle


    [ https://issues.apache.org/jira/browse/IVY-366?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12479255 ] 

Xavier Hanin commented on IVY-366:
----------------------------------

Good work Maarten! I've just fixed a little issue in IvyTask (a forgotten replacement of MessageImpl used, and a missing parameter in one ensureResolved method.

One thing I'd like to discuss: why remove XmlReportOutputter.getReportFileName? Changing the signature to take a resolveId would have been better, no? Because now you have some piece of code (like ResolveTest) which constructs the file name themselves.







 
____________________________________________________________________________________
Expecting? Get great news right away with email Auto-Check. 
Try the Yahoo! Mail Beta.
http://advision.webevents.yahoo.com/mailbeta/newmail_tools.html

Re: [jira] Commented: (IVY-366) Scope and status leakage during build lifecycle

Posted by Xavier Hanin <xa...@gmail.com>.
On 3/8/07, Maarten Coene <ma...@yahoo.com> wrote:
>
> Xavier,
>
> I've moved the XmlReportOutputter.getReportFileName method to the
> CacheManager. I think all files that are put in the cache or retrieved from
> the cache should go through the CacheManager. This will make things easier
> when we change something about the cache mechanism later.


It makes sense, I missed this move. So it's ok for me.

You're right about the ResolveTest: it should probably use the CacheManager
> to retrieve the filename instead of construct the name itself.
> I'll modify this when I have some time.


Fine for me.

- Xavier

regards,
> Maarten
>
>
> ----- Original Message ----
> From: Xavier Hanin (JIRA) <ji...@apache.org>
> To: ivy-commits@incubator.apache.org
> Sent: Thursday, March 8, 2007 8:52:24 AM
> Subject: [jira] Commented: (IVY-366) Scope and status leakage during build
> lifecycle
>
>
>     [
> https://issues.apache.org/jira/browse/IVY-366?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12479255]
>
> Xavier Hanin commented on IVY-366:
> ----------------------------------
>
> Good work Maarten! I've just fixed a little issue in IvyTask (a forgotten
> replacement of MessageImpl used, and a missing parameter in one
> ensureResolved method.
>
> One thing I'd like to discuss: why remove
> XmlReportOutputter.getReportFileName? Changing the signature to take a
> resolveId would have been better, no? Because now you have some piece of
> code (like ResolveTest) which constructs the file name themselves.
>
>
>
>
>
>
>
>
>
> ____________________________________________________________________________________
> Expecting? Get great news right away with email Auto-Check.
> Try the Yahoo! Mail Beta.
> http://advision.webevents.yahoo.com/mailbeta/newmail_tools.html
>