You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by alpinegizmo <gi...@git.apache.org> on 2017/07/10 08:13:38 UTC
[GitHub] flink pull request #4291: [FLINK-7136][docs] Improve search by adding facets...
GitHub user alpinegizmo opened a pull request:
https://github.com/apache/flink/pull/4291
[FLINK-7136][docs] Improve search by adding facets and turning off ads
This PR expands the custom search engine used by the documentation to include some additional sources, and expands the UI to include tabs for breaking out the results by source, and turns off ads (which we are entitled to do, since the ASF is a non-profit org).
The specifications for the list of sites to be searched, their weights, and the UI are checked in as XML files. However, editing these files won't have any direct impact. Instead, they must be re-uploaded to the google custom search console. The reason to check them in is to make the search settings visible, and to preserve a copy of all the settings within the project.
Before and after screenshots when searching for "timers":
<img width="930" alt="screen shot 2017-07-10 at 10 11 39 am" src="https://user-images.githubusercontent.com/43608/28008542-3ae67428-6558-11e7-881a-5e79369ef9d3.png">
<img width="868" alt="screen shot 2017-07-10 at 10 12 44 am" src="https://user-images.githubusercontent.com/43608/28008577-60e11fca-6558-11e7-82f5-e28c7c9f364a.png">
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/alpinegizmo/flink 7136-doc-search
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/4291.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #4291
----
commit 9f2ed8cbae957b030774d48ac4206904d7cb8385
Author: David Anderson <da...@alpinegizmo.com>
Date: 2017-07-07T20:54:17Z
[FLINK-7136][docs] Improve search by adding facets and turning off ads
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #4291: [FLINK-7136][docs] Improve search by adding facets and tu...
Posted by StephanEwen <gi...@git.apache.org>.
Github user StephanEwen commented on the issue:
https://github.com/apache/flink/pull/4291
Cool, +1 for this change. Let's merge it into `master`, try it out there, and merge it into `release-1.3` if it works well.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request #4291: [FLINK-7136][docs] Improve search by adding facets...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/4291
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---