[GitHub] [hbase] saintstack commented on a change in pull request #3177: HBASE-25781 Add isCacheBlocks option to RowCounter

[GitBox <gi...@apache.org>]

saintstack commented on a change in pull request #3177:
URL: https://github.com/apache/hbase/pull/3177#discussion_r615110240



##########
File path: hbase-mapreduce/src/main/java/org/apache/hadoop/hbase/mapreduce/RowCounter.java
##########
@@ -64,13 +64,15 @@
 
   private final static String OPT_START_TIME = "starttime";
   private final static String OPT_END_TIME = "endtime";
+  private final static String OPT_IS_CACHE_BLOCKS = "isCacheBlocks";

Review comment:
       Should be named 'cacheBlocks'?

##########
File path: hbase-mapreduce/src/main/java/org/apache/hadoop/hbase/mapreduce/RowCounter.java
##########
@@ -64,13 +64,15 @@
 
   private final static String OPT_START_TIME = "starttime";
   private final static String OPT_END_TIME = "endtime";
+  private final static String OPT_IS_CACHE_BLOCKS = "isCacheBlocks";
   private final static String OPT_RANGE = "range";
   private final static String OPT_EXPECTED_COUNT = "expectedCount";
 
   private String tableName;
   private List<MultiRowRangeFilter.RowRange> rowRangeList;
   private long startTime;
   private long endTime;
+  private boolean isCacheBlocks;

Review comment:
       isCacheBlocks is name of the method that looks at the cacheBlock data member content, not the name of the data member... so suggest s/isCacheBlocks/cacheBlocks/




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org