You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@commons.apache.org by "Ken Tatsushita (JIRA)" <ji...@apache.org> on 2010/10/25 10:49:23 UTC

[jira] Created: (DBCP-346) DBCP cannot set GenericObjectPool.lifo

DBCP cannot set GenericObjectPool.lifo
--------------------------------------

                 Key: DBCP-346
                 URL: https://issues.apache.org/jira/browse/DBCP-346
             Project: Commons Dbcp
          Issue Type: Improvement
    Affects Versions: 2.0
         Environment: All.
            Reporter: Ken Tatsushita


Hi experts! 

I want to change the order of return connection.
change the GenericObjectPool.lifo setting false.(default is true). 

However GenericObjectPool.lifo cannot be changed. 
Because the setter method is not implement in DBCP

IMHO DBCP have to implement setter method of GenericObjectPool.lifo

I made the patch that can change GenericObjectPool.lifo. 

Best regards.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[jira] Resolved: (DBCP-346) DBCP cannot set GenericObjectPool.lifo

Posted by "Phil Steitz (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/DBCP-346?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Phil Steitz resolved DBCP-346.
------------------------------

    Resolution: Fixed

Many thanks for the patch.

Applied to both trunk and 1.4.x branch in r1056867, with slight changes to doc and reduction of visibility of BasicDataSource lifo property to private.

> DBCP cannot set GenericObjectPool.lifo
> --------------------------------------
>
>                 Key: DBCP-346
>                 URL: https://issues.apache.org/jira/browse/DBCP-346
>             Project: Commons Dbcp
>          Issue Type: Improvement
>    Affects Versions: 1.2.2, 1.3, 1.4
>         Environment: All.
>            Reporter: Ken Tatsushita
>             Fix For: 1.3.1, 1.4.1
>
>         Attachments: lifo_patch.txt
>
>
> Hi experts! 
> I want to change the order of return connection.
> change the GenericObjectPool.lifo setting false.(default is true). 
> However GenericObjectPool.lifo cannot be changed. 
> Because the setter method is not implement in DBCP
> IMHO DBCP have to implement setter method of GenericObjectPool.lifo
> I made the patch that can change GenericObjectPool.lifo. 
> Best regards.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[jira] Updated: (DBCP-346) DBCP cannot set GenericObjectPool.lifo

Posted by "Ken Tatsushita (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/DBCP-346?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Ken Tatsushita updated DBCP-346:
--------------------------------

    Attachment: lifo_patch.txt

> DBCP cannot set GenericObjectPool.lifo
> --------------------------------------
>
>                 Key: DBCP-346
>                 URL: https://issues.apache.org/jira/browse/DBCP-346
>             Project: Commons Dbcp
>          Issue Type: Improvement
>    Affects Versions: 2.0
>         Environment: All.
>            Reporter: Ken Tatsushita
>         Attachments: lifo_patch.txt
>
>
> Hi experts! 
> I want to change the order of return connection.
> change the GenericObjectPool.lifo setting false.(default is true). 
> However GenericObjectPool.lifo cannot be changed. 
> Because the setter method is not implement in DBCP
> IMHO DBCP have to implement setter method of GenericObjectPool.lifo
> I made the patch that can change GenericObjectPool.lifo. 
> Best regards.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[jira] Updated: (DBCP-346) DBCP cannot set GenericObjectPool.lifo

Posted by "Phil Steitz (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/DBCP-346?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Phil Steitz updated DBCP-346:
-----------------------------

    Affects Version/s:     (was: 2.0)
                       1.2.2
                       1.3
                       1.4
        Fix Version/s: 1.4.1
                       1.3.1

Thanks for the patch!

I am +1 for including this in 1.3.1, 1.4.1 onward.  Will review further and commit if there are no objections.

As a workaround until fix versions are released, you can either

1. override BasicDataSource.createConnectionPool() and set the desired lifo there
2. Use PoolingDataSource instead, configuring the pool directly.

> DBCP cannot set GenericObjectPool.lifo
> --------------------------------------
>
>                 Key: DBCP-346
>                 URL: https://issues.apache.org/jira/browse/DBCP-346
>             Project: Commons Dbcp
>          Issue Type: Improvement
>    Affects Versions: 1.2.2, 1.3, 1.4
>         Environment: All.
>            Reporter: Ken Tatsushita
>             Fix For: 1.3.1, 1.4.1
>
>         Attachments: lifo_patch.txt
>
>
> Hi experts! 
> I want to change the order of return connection.
> change the GenericObjectPool.lifo setting false.(default is true). 
> However GenericObjectPool.lifo cannot be changed. 
> Because the setter method is not implement in DBCP
> IMHO DBCP have to implement setter method of GenericObjectPool.lifo
> I made the patch that can change GenericObjectPool.lifo. 
> Best regards.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.