[GitHub] [flink] tillrohrmann commented on a change in pull request #16995: [FLINK-22002][tests] Let taskmanager.slot.timeout fall back to akka.ask.timeout

[GitBox <gi...@apache.org>]

tillrohrmann commented on a change in pull request #16995:
URL: https://github.com/apache/flink/pull/16995#discussion_r696730968



##########
File path: flink-core/src/main/java/org/apache/flink/configuration/TaskManagerOptions.java
##########
@@ -239,9 +239,10 @@
     /** Timeout for identifying inactive slots. */
     @Documentation.Section(Documentation.Sections.ALL_TASK_MANAGER)
     public static final ConfigOption<Duration> SLOT_TIMEOUT =
-            ConfigOptions.key("taskmanager.slot.timeout")
+            key("taskmanager.slot.timeout")
                     .durationType()
-                    .defaultValue(TimeUtils.parseDuration("10 s"))
+                    .noDefaultValue()

Review comment:
       I am not sure whether this change made sense in the first place, tbh. Per default you probably want to have the same timeout as you give your RPCs. If you want to have a smaller timeout, then you configure it explicitly.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org