You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@nifi.apache.org by jfrazee <gi...@git.apache.org> on 2016/03/12 19:45:52 UTC
[GitHub] nifi pull request: Added source filename metadata to IdentifyMimeT...
GitHub user jfrazee opened a pull request:
https://github.com/apache/nifi/pull/273
Added source filename metadata to IdentifyMimeType, fixes NIFI-1617
Tika mime type Detector determines mime type on the basis of filename extensions in some cases (e.g., CSV). This adds the FlowFile filename attribute to the Detector Metadata if it's available.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jfrazee/nifi NIFI-1617
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/nifi/pull/273.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #273
----
commit 2ece5d7943f63258bd3dd9abc62aa734392ecce0
Author: Joey Frazee <jo...@icloud.com>
Date: 2016-03-10T22:49:59Z
Added source filename metadata to IdentifyMimeType, fixes NIFI-1617
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi pull request: NIFI-1617 Add source filename metadata to Ident...
Posted by mattyb149 <gi...@git.apache.org>.
Github user mattyb149 commented on the pull request:
https://github.com/apache/nifi/pull/273#issuecomment-198199315
LGTM, successfully built PR, ran unit tests, and tested with running NiFi with both a CSV file and an Atom file (both types recognized by extension: https://github.com/apache/tika/blob/master/tika-core/src/main/resources/org/apache/tika/mime/tika-mimetypes.xml) +1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi pull request: NIFI-1617 Add source filename metadata to Ident...
Posted by mattyb149 <gi...@git.apache.org>.
Github user mattyb149 commented on the pull request:
https://github.com/apache/nifi/pull/273#issuecomment-198185301
reviewing
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi pull request: NIFI-1617 Add source filename metadata to Ident...
Posted by mattyb149 <gi...@git.apache.org>.
Github user mattyb149 commented on the pull request:
https://github.com/apache/nifi/pull/273#issuecomment-198202258
I merged this but forgot to close the PR, @jfrazee can you do the honors?
Thanks for the contrib!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi pull request: NIFI-1617 Add source filename metadata to Ident...
Posted by jfrazee <gi...@git.apache.org>.
Github user jfrazee closed the pull request at:
https://github.com/apache/nifi/pull/273
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---