You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@stormcrawler.apache.org by "rajucomp (via GitHub)" <gi...@apache.org> on 2026/10/01 21:59:36 UTC

Re: [PR] #2057 FetcherBolt: move the fetcher internals to o.a.s.fetcher [stormcrawler]

rajucomp commented on code in PR #2209:
URL: https://github.com/apache/stormcrawler/pull/2209#discussion_r4160925261


##########
core/src/main/java/org/apache/stormcrawler/fetcher/FetchItem.java:
##########
@@ -24,18 +24,23 @@
 import java.util.Locale;
 import org.apache.commons.lang3.StringUtils;
 import org.apache.storm.tuple.Tuple;
+import org.apache.stormcrawler.bolt.FetcherBolt;
 import org.apache.stormcrawler.util.URLUtil;
 import org.slf4j.LoggerFactory;
 
-/** This class described the item to be fetched. */
-class FetchItem {
+/**
+ * This class described the item to be fetched.
+ *
+ * <p>For internal use only. Not part of StormCrawler's public API.
+ */
+public final class FetchItem {
     // the bolt's category: log configurations for FetcherBolt keep covering these lines
     private static final org.slf4j.Logger LOG = LoggerFactory.getLogger(FetcherBolt.class);
 
-    String queueId;
-    String url;
-    Tuple tuple;
-    long creationTime;
+    private final String queueId;

Review Comment:
   Should this be a record ?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@stormcrawler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org