You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@thrift.apache.org by jsirois <gi...@git.apache.org> on 2016/02/13 01:49:14 UTC
[GitHub] thrift pull request: THRIFT-3621 Fix cpp/lib/test/TSSLSocketInterr...
GitHub user jsirois opened a pull request:
https://github.com/apache/thrift/pull/854
THRIFT-3621 Fix cpp/lib/test/TSSLSocketInterruptTest.cpp to use ephem…
…eral ports.
Instead of using a fixed port, use an ephemeral port to improve
robustness and make way for parallelizability.
This change has an undesirable amount of repeated code but this fact is
not different from the prior so being a bit expedient here. Ideally
setup of a `TSSLServerSocket` listening on an ephemeral port would be
DRYed up into a helper of some sort.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jsirois/thrift THRIFT-3623
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/thrift/pull/854.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #854
----
commit fbdbceb9b4c912b87d4ddd93ac397b41ef6b5f25
Author: John Sirois <js...@apache.org>
Date: 2016-02-13T00:44:01Z
THRIFT-3621 Fix cpp/lib/test/TSSLSocketInterruptTest.cpp to use ephemeral ports.
Instead of using a fixed port, use an ephemeral port to improve
robustness and make way for parallelizability.
This change has an undesirable amount of repeated code but this fact is
not different from the prior so being a bit expedient here. Ideally
setup of a `TSSLServerSocket` listening on an ephemeral port would be
DRYed up into a helper of some sort.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] thrift pull request: THRIFT-3623 Fix cpp/lib/test/TSSLSocketInterr...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/thrift/pull/854
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] thrift pull request: THRIFT-3623 Fix cpp/lib/test/TSSLSocketInterr...
Posted by nsuke <gi...@git.apache.org>.
Github user nsuke commented on a diff in the pull request:
https://github.com/apache/thrift/pull/854#discussion_r52828211
--- Diff: lib/cpp/test/TSSLSocketInterruptTest.cpp ---
@@ -91,8 +90,6 @@ BOOST_GLOBAL_FIXTURE(GlobalFixtureSSL);
BOOST_GLOBAL_FIXTURE(GlobalFixtureSSL)
#endif
-BOOST_FIXTURE_TEST_SUITE(TSSLSocketInterruptTest, TestPortFixture)
--- End diff --
Can you keep 3 of these as BOOST_**AUTO**_TEST_SUITE ?
This would remove a namespace and put everything into global namespace.
In this regard, it seems that this one should have been placed before the `keyDir` symbol already...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] thrift pull request: THRIFT-3623 Fix cpp/lib/test/TSSLSocketInterr...
Posted by jsirois <gi...@git.apache.org>.
Github user jsirois commented on a diff in the pull request:
https://github.com/apache/thrift/pull/854#discussion_r52832288
--- Diff: lib/cpp/test/TSSLSocketInterruptTest.cpp ---
@@ -91,8 +90,6 @@ BOOST_GLOBAL_FIXTURE(GlobalFixtureSSL);
BOOST_GLOBAL_FIXTURE(GlobalFixtureSSL)
#endif
-BOOST_FIXTURE_TEST_SUITE(TSSLSocketInterruptTest, TestPortFixture)
--- End diff --
Thanks @nsuke - all fixed up here and in #855 and #857
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---