You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by "4nt01ne (via GitHub)" <gi...@apache.org> on 2024/04/21 23:33:40 UTC
[PR] CAMEL-20206: split overly complex method in RouteBuilderParser [camel]
4nt01ne opened a new pull request, #13871:
URL: https://github.com/apache/camel/pull/13871
# Description
Please review this PR. It's my first contribution.
# Target
- [ x ] I checked that the commit is targeting the correct branch (note that Camel 3 uses `camel-3.x`, whereas Camel 4 uses the `main` branch)
# Tracking
- [ x ] If this is a large change, bug fix, or code improvement, I checked there is a [JIRA issue](https://issues.apache.org/jira/browse/CAMEL) filed for the change (usually before you start working on it).
# Apache Camel coding standards and style
- [ x ] I checked that each commit in the pull request has a meaningful subject line and body.
- [ ] I have run `mvn clean install -DskipTests` locally and I have committed all auto-generated changes
not required for this type of change I believe
- I have run the unit tests of the module locally and faced no extra failing test.
Is it normal that some unit tests are failing?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] CAMEL-20206: split overly complex method in RouteBuilderParser [camel]
Posted by "4nt01ne (via GitHub)" <gi...@apache.org>.
4nt01ne commented on PR #13871:
URL: https://github.com/apache/camel/pull/13871#issuecomment-2069120224
could somebody explain what I have to do to fix the build?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] CAMEL-20206: split overly complex method in RouteBuilderParser [camel]
Posted by "4nt01ne (via GitHub)" <gi...@apache.org>.
4nt01ne commented on PR #13871:
URL: https://github.com/apache/camel/pull/13871#issuecomment-2070992036
done thx!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] CAMEL-20206: split overly complex method in RouteBuilderParser [camel]
Posted by "orpiske (via GitHub)" <gi...@apache.org>.
orpiske merged PR #13871:
URL: https://github.com/apache/camel/pull/13871
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] CAMEL-20206: split overly complex method in RouteBuilderParser [camel]
Posted by "orpiske (via GitHub)" <gi...@apache.org>.
orpiske commented on PR #13871:
URL: https://github.com/apache/camel/pull/13871#issuecomment-2069820484
https://camel.apache.org/camel-core/contributing/#_verifying_the_coding_style
Then commit the files and push force.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org