You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Ben Mahler <be...@gmail.com> on 2012/09/20 23:26:21 UTC
Review Request: Exposing executor work directories.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/7202/
-----------------------------------------------------------
Review request for mesos, Benjamin Hindman and Vinod Kone.
Description
-------
We want these viewable from the webui.
Diffs
-----
src/master/master.hpp 92579c9
src/master/master.cpp addabdb
src/slave/slave.hpp 04df57c
src/slave/slave.cpp 49d8e76
Diff: https://reviews.apache.org/r/7202/diff/
Testing
-------
OSX: make check + ./mesos-local.sh
Thanks,
Ben Mahler
Re: Review Request: Exposing executor work directories.
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/7202/#review11754
-----------------------------------------------------------
Ship it!
Ship It!
- Vinod Kone
On Sept. 20, 2012, 9:26 p.m., Ben Mahler wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/7202/
> -----------------------------------------------------------
>
> (Updated Sept. 20, 2012, 9:26 p.m.)
>
>
> Review request for mesos, Benjamin Hindman and Vinod Kone.
>
>
> Description
> -------
>
> We want these viewable from the webui.
>
>
> Diffs
> -----
>
> src/master/master.hpp 92579c9
> src/master/master.cpp addabdb
> src/slave/slave.hpp 04df57c
> src/slave/slave.cpp 49d8e76
>
> Diff: https://reviews.apache.org/r/7202/diff/
>
>
> Testing
> -------
>
> OSX: make check + ./mesos-local.sh
>
>
> Thanks,
>
> Ben Mahler
>
>
Re: Review Request: Exposing executor work directories.
Posted by Benjamin Hindman <be...@berkeley.edu>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/7202/#review12244
-----------------------------------------------------------
Ship it!
src/slave/slave.cpp
<https://reviews.apache.org/r/7202/#comment25980>
Add a comment regarding this constant "virtual" path that is shared with the webui. Also add a TODO to eventually pass this to the webui explicitly.
- Benjamin Hindman
On Sept. 20, 2012, 9:26 p.m., Ben Mahler wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/7202/
> -----------------------------------------------------------
>
> (Updated Sept. 20, 2012, 9:26 p.m.)
>
>
> Review request for mesos, Benjamin Hindman and Vinod Kone.
>
>
> Description
> -------
>
> We want these viewable from the webui.
>
>
> Diffs
> -----
>
> src/master/master.hpp 92579c9
> src/master/master.cpp addabdb
> src/slave/slave.hpp 04df57c
> src/slave/slave.cpp 49d8e76
>
> Diff: https://reviews.apache.org/r/7202/diff/
>
>
> Testing
> -------
>
> OSX: make check + ./mesos-local.sh
>
>
> Thanks,
>
> Ben Mahler
>
>
Re: Review Request: Exposing executor work directories.
Posted by Ben Mahler <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/7202/
-----------------------------------------------------------
(Updated Oct. 9, 2012, 11:21 p.m.)
Review request for mesos, Benjamin Hindman and Vinod Kone.
Changes
-------
Correct diff.
Description
-------
We want these viewable from the webui.
Diffs (updated)
-----
src/master/master.hpp 92579c9cb01d7d94601c8ce283dbba3e3b2c4cb8
src/master/master.cpp addabdb524c8492e2a5099a6e0d6d88fa7bb9092
src/slave/slave.hpp 02daaa0f4e2002537bed33e9af3371a4422a1bc8
src/slave/slave.cpp 5c49e935a0595beb50db78cd3383877aae5cf5a7
Diff: https://reviews.apache.org/r/7202/diff/
Testing
-------
OSX: make check + ./mesos-local.sh
Thanks,
Ben Mahler
Re: Review Request: Exposing executor work directories.
Posted by Ben Mahler <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/7202/
-----------------------------------------------------------
(Updated Oct. 9, 2012, 12:14 a.m.)
Review request for mesos, Benjamin Hindman and Vinod Kone.
Changes
-------
Forgot the diff of the changes.
Description
-------
We want these viewable from the webui.
Diffs (updated)
-----
src/files/files.hpp 35037a613316846cc8bea259eaa9363705c0f1df
src/files/files.cpp c40b7b74485dc717c4291f17a4533b52f2c51a7e
src/tests/files_tests.cpp 17d284b82de4d9e1dedf1c26f4cedcf8269c4072
third_party/libprocess/include/stout/format.hpp eff0df4006375f62b78b7ca111981180ddf00529
Diff: https://reviews.apache.org/r/7202/diff/
Testing
-------
OSX: make check + ./mesos-local.sh
Thanks,
Ben Mahler
Re: Review Request: Exposing executor work directories.
Posted by Ben Mahler <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/7202/
-----------------------------------------------------------
(Updated Oct. 8, 2012, 11:58 p.m.)
Review request for mesos, Benjamin Hindman and Vinod Kone.
Changes
-------
Update from benh's comment.
Description
-------
We want these viewable from the webui.
Diffs (updated)
-----
src/master/master.hpp 92579c9cb01d7d94601c8ce283dbba3e3b2c4cb8
src/master/master.cpp addabdb524c8492e2a5099a6e0d6d88fa7bb9092
src/slave/slave.hpp 02daaa0f4e2002537bed33e9af3371a4422a1bc8
src/slave/slave.cpp 5c49e935a0595beb50db78cd3383877aae5cf5a7
Diff: https://reviews.apache.org/r/7202/diff/
Testing
-------
OSX: make check + ./mesos-local.sh
Thanks,
Ben Mahler
Re: Review Request: Exposing executor work directories.
Posted by Ben Mahler <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/7202/
-----------------------------------------------------------
(Updated Sept. 20, 2012, 9:26 p.m.)
Review request for mesos, Benjamin Hindman and Vinod Kone.
Description
-------
We want these viewable from the webui.
Diffs
-----
src/master/master.hpp 92579c9
src/master/master.cpp addabdb
src/slave/slave.hpp 04df57c
src/slave/slave.cpp 49d8e76
Diff: https://reviews.apache.org/r/7202/diff/
Testing
-------
OSX: make check + ./mesos-local.sh
Thanks,
Ben Mahler