[GitHub] [flink] jiangxin369 commented on a diff in pull request #23268: [FLINK-32945][runtime] Fix NPE when task reached end-of-data but checkpoint failed

["jiangxin369 (via GitHub)" <gi...@apache.org>]

jiangxin369 commented on code in PR #23268:
URL: https://github.com/apache/flink/pull/23268#discussion_r1305318132


##########
flink-runtime/src/main/java/org/apache/flink/runtime/scheduler/VertexEndOfDataListener.java:
##########
@@ -47,8 +54,15 @@ public VertexEndOfDataListener(ExecutionGraph executionGraph) {
     }
 
     public void recordTaskEndOfData(ExecutionAttemptID executionAttemptID) {
-        BitSet subtaskStatus = tasksReachedEndOfData.get(executionAttemptID.getJobVertexId());
-        subtaskStatus.set(executionAttemptID.getSubtaskIndex());
+        JobVertexID jobVertexId = executionAttemptID.getJobVertexId();
+        if (!tasksReachedEndOfData.containsKey(jobVertexId)) {
+            LOG.warn(

Review Comment:
   Thanks for pointing it out. It should not happen and the changes don't make sense, removed it.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org