[jira] [Commented] (TINKERPOP-1678) until(Predicate) is actually calling emit(Predicate)

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/TINKERPOP-1678?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16026328#comment-16026328 ] 

ASF GitHub Bot commented on TINKERPOP-1678:
-------------------------------------------

GitHub user okram opened a pull request:

    https://github.com/apache/tinkerpop/pull/615

    TINKERPOP-1678: until(Predicate) is actually calling emit(Predicate)

    https://issues.apache.org/jira/browse/TINKERPOP-1678
    
    Fixed a typo-bug in `GraphTraversal` where `until(Predicate)` was actually calling `emit(Predicate)`. A very low probability traversal and thus, it was never uncovered until now. However, fixed and added a test case that verifies that the previous behavior was wrong and the new behavior is write.
    
    VOTE +1.
    
    NOTE: This is the work done here https://github.com/apache/tinkerpop/pull/606, but now there is a test case.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/apache/tinkerpop TINKERPOP-1678

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/tinkerpop/pull/615.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #615
    
----
commit 8695b15c1c91411465b8416fec20b628b7fba045
Author: Marko A. Rodriguez <ok...@gmail.com>
Date:   2017-05-26T14:27:00Z

    fixed a bug in until(predicate) which was actually calling emit(predicate). Added a test case to verify bug and demonstrate that fix fixes bug.

----


> until(Predicate) is actually calling emit(Predicate)
> ----------------------------------------------------
>
>                 Key: TINKERPOP-1678
>                 URL: https://issues.apache.org/jira/browse/TINKERPOP-1678
>             Project: TinkerPop
>          Issue Type: Bug
>          Components: process
>    Affects Versions: 3.2.4
>            Reporter: Marko A. Rodriguez
>            Assignee: Marko A. Rodriguez
>
> This is the bug:
> {code}
>     public default GraphTraversal<S, E> until(final Predicate<Traverser<E>> untilPredicate) {
>         this.asAdmin().getBytecode().addStep(Symbols.until, untilPredicate);
>         return RepeatStep.addEmitToTraversal(this, (Traversal.Admin<E, ?>) __.filter(untilPredicate));
>     }
> {code}
> The {{addEmitToTraversal}} should be {{addUntilToTraversal}}.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)