[GitHub] [incubator-brpc] TheFinalHydra commented on issue #1071: latency 数值不断更新，但是latency_9999 没有变化

[GitBox <gi...@apache.org>]

TheFinalHydra commented on issue #1071:
URL: https://github.com/apache/incubator-brpc/issues/1071#issuecomment-657221387


   我也遇到了这个问题，而且实际上，通过promethus格式暴露出来的lateny_80/90/99/9999/cdf也同样没有值，只有count, ops, latency和max_latency有值。
   
   之前的旧版本是好的，更新到了今年6月份的某一个commit之后，就不可以了，请问是什么地方修改了吗？
   
   另外我看到[`latency_recorder.cpp的137行`](https://github.com/apache/incubator-brpc/blob/master/src/bvar/latency_recorder.cpp#L137)里面有这样一段话
   
   > // NOTE: We don't show 99.99% since it's often significantly larger than
   > // other values and make other curves on the plotted graph small and
   > // hard to read.
   
   这里不太明白，为什么这里要直接把99.99%去掉呢？如果用户觉得指标不需要，完全应该由用户在监控上直接不抓取这一项的值，或者读取`/brpc_metrics`的时候直接跳过这一项就好了，而不是由brpc这个框架级别的东西要这个值写死成一个假的值。这样bvar里面既暴露了9999，但却一直是一个假的值，会容易让人迷惑


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org
For additional commands, e-mail: dev-help@brpc.apache.org