You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@helix.apache.org by GitBox <gi...@apache.org> on 2020/08/09 02:53:33 UTC
[GitHub] [helix] kaisun2000 opened a new issue #1240: Investigate TestCrushAutoRebalance 200+ threads leaking due to @afterClass not invoked.
kaisun2000 opened a new issue #1240:
URL: https://github.com/apache/helix/issues/1240
Running TestCrushAutoRebalance in IntelligJ debugger, TestCrushAutoRebalance would clean up all threads created in `@AfterClass afterClass()`.
But running mvn test under Helix-Core module, it would not invoke this afterClass and subsequent @afterclass in base class ZkTestBase
The following log proves it:
grep -e "has active threads cnt" -e "END " -e "START" out2.log
TestExpandCluster has active threads cnt:137
START TestCrushAutoRebalance at Fri Aug 07 22:35:08 PDT 2020
START testZoneIsolationWithInstanceTag at Fri Aug 07 22:35:09 PDT 2020
END testZoneIsolationWithInstanceTag at Fri Aug 07 22:35:09 PDT 2020, took: 469ms.
START testZoneIsolationWithInstanceTag at Fri Aug 07 22:35:09 PDT 2020
END testZoneIsolationWithInstanceTag at Fri Aug 07 22:35:10 PDT 2020, took: 503ms.
START testZoneIsolationWithInstanceTag at Fri Aug 07 22:35:10 PDT 2020
END testZoneIsolationWithInstanceTag at Fri Aug 07 22:35:10 PDT 2020, took: 505ms.
START testZoneIsolation at Fri Aug 07 22:35:10 PDT 2020
END testZoneIsolation at Fri Aug 07 22:35:11 PDT 2020, took: 458ms.
START testZoneIsolation at Fri Aug 07 22:35:11 PDT 2020
END testZoneIsolation at Fri Aug 07 22:35:11 PDT 2020, took: 497ms.
START testZoneIsolation at Fri Aug 07 22:35:11 PDT 2020
END testZoneIsolation at Fri Aug 07 22:35:12 PDT 2020, took: 470ms.
START testLackEnoughLiveRacks at Fri Aug 07 22:35:12 PDT 2020
END testLackEnoughLiveRacks at Fri Aug 07 22:35:13 PDT 2020, took: 992ms.
START testLackEnoughRacks at Fri Aug 07 22:35:13 PDT 2020
END testLackEnoughRacks at Fri Aug 07 22:35:14 PDT 2020, took: 1177ms.
---> note after class not running, no log of END TestCrushAutoRebalance from afterClass(), thus leaking 200+ threads.
START TestCrushAutoRebalanceNonRack at Fri Aug 07 22:35:14 PDT 2020
START test at Fri Aug 07 22:35:14 PDT 2020
END test at Fri Aug 07 22:35:15 PDT 2020, took: 550ms.
START test at Fri Aug 07 22:35:15 PDT 2020
END test at Fri Aug 07 22:35:15 PDT 2020, took: 549ms.
START testWithInstanceTag at Fri Aug 07 22:35:15 PDT 2020
END testWithInstanceTag at Fri Aug 07 22:35:16 PDT 2020, took: 583ms.
START testWithInstanceTag at Fri Aug 07 22:35:16 PDT 2020
END testWithInstanceTag at Fri Aug 07 22:35:16 PDT 2020, took: 590ms.
START testLackEnoughLiveInstances at Fri Aug 07 22:35:16 PDT 2020
END testLackEnoughLiveInstances at Fri Aug 07 22:35:17 PDT 2020, took: 577ms.
START testLackEnoughLiveInstances at Fri Aug 07 22:35:17 PDT 2020
END testLackEnoughLiveInstances at Fri Aug 07 22:35:17 PDT 2020, took: 566ms.
START testLackEnoughInstances at Fri Aug 07 22:35:17 PDT 2020
END testLackEnoughInstances at Fri Aug 07 22:35:18 PDT 2020, took: 903ms.
START testLackEnoughInstances at Fri Aug 07 22:35:18 PDT 2020
END testLackEnoughInstances at Fri Aug 07 22:35:19 PDT 2020, took: 968ms.
END TestCrushAutoRebalanceNonRack at Fri Aug 07 22:35:20 PDT 2020
TestCrushAutoRebalanceNonRack has active threads cnt:362
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org
[GitHub] [helix] kaisun2000 commented on issue #1240: Investigate TestCrushAutoRebalance 200+ threads leaking due to @afterClass not invoked.
Posted by GitBox <gi...@apache.org>.
kaisun2000 commented on issue #1240:
URL: https://github.com/apache/helix/issues/1240#issuecomment-671000974
Confirmed, the void test caused afterClass() not running. This is a bug of TestNg with mvn.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org
[GitHub] [helix] kaisun2000 edited a comment on issue #1240: Investigate TestCrushAutoRebalance 200+ threads leaking due to @afterClass not invoked.
Posted by GitBox <gi...@apache.org>.
kaisun2000 edited a comment on issue #1240:
URL: https://github.com/apache/helix/issues/1240#issuecomment-671000974
Confirmed, the void test caused afterClass() not running. This is a bug of TestNg with mvn.
comment out the blank tests, we have following log
>TestExpandCluster has active threads cnt:137
START TestCrushAutoRebalance at Sat Aug 08 20:19:08 PDT 2020
START testZoneIsolationWithInstanceTag at Sat Aug 08 20:19:08 PDT 2020
END testZoneIsolationWithInstanceTag at Sat Aug 08 20:19:09 PDT 2020, took: 484ms.
START testZoneIsolationWithInstanceTag at Sat Aug 08 20:19:09 PDT 2020
END testZoneIsolationWithInstanceTag at Sat Aug 08 20:19:09 PDT 2020, took: 512ms.
START testZoneIsolationWithInstanceTag at Sat Aug 08 20:19:09 PDT 2020
END testZoneIsolationWithInstanceTag at Sat Aug 08 20:19:10 PDT 2020, took: 491ms.
START testZoneIsolation at Sat Aug 08 20:19:10 PDT 2020
END testZoneIsolation at Sat Aug 08 20:19:10 PDT 2020, took: 465ms.
START testZoneIsolation at Sat Aug 08 20:19:10 PDT 2020
END testZoneIsolation at Sat Aug 08 20:19:11 PDT 2020, took: 478ms.
START testZoneIsolation at Sat Aug 08 20:19:11 PDT 2020
END testZoneIsolation at Sat Aug 08 20:19:11 PDT 2020, took: 449ms.
START testLackEnoughLiveRacks at Sat Aug 08 20:19:11 PDT 2020
END testLackEnoughLiveRacks at Sat Aug 08 20:19:12 PDT 2020, took: 1011ms.
START testLackEnoughRacks at Sat Aug 08 20:19:12 PDT 2020
END testLackEnoughRacks at Sat Aug 08 20:19:14 PDT 2020, took: 1211ms.
END TestCrushAutoRebalance at Sat Aug 08 20:19:15 PDT 2020
TestCrushAutoRebalance has active threads cnt:134
START TestCrushAutoRebalanceNonRack at Sat Aug 08 20:19:15 PDT 2020
START test at Sat Aug 08 20:19:15 PDT 2020
END test at Sat Aug 08 20:19:16 PDT 2020, took: 558ms.
START test at Sat Aug 08 20:19:16 PDT 2020
END test at Sat Aug 08 20:19:16 PDT 2020, took: 555ms.
START testWithInstanceTag at Sat Aug 08 20:19:16 PDT 2020
END testWithInstanceTag at Sat Aug 08 20:19:17 PDT 2020, took: 600ms.
START testWithInstanceTag at Sat Aug 08 20:19:17 PDT 2020
END testWithInstanceTag at Sat Aug 08 20:19:17 PDT 2020, took: 593ms.
START testLackEnoughLiveInstances at Sat Aug 08 20:19:17 PDT 2020
END testLackEnoughLiveInstances at Sat Aug 08 20:19:18 PDT 2020, took: 581ms.
START testLackEnoughLiveInstances at Sat Aug 08 20:19:18 PDT 2020
END testLackEnoughLiveInstances at Sat Aug 08 20:19:18 PDT 2020, took: 555ms.
START testLackEnoughInstances at Sat Aug 08 20:19:18 PDT 2020
END testLackEnoughInstances at Sat Aug 08 20:19:19 PDT 2020, took: 925ms.
START testLackEnoughInstances at Sat Aug 08 20:19:19 PDT 2020
END testLackEnoughInstances at Sat Aug 08 20:19:20 PDT 2020, took: 893ms.
END TestCrushAutoRebalanceNonRack at Sat Aug 08 20:19:21 PDT 2020
TestCrushAutoRebalanceNonRack has active threads cnt:137
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org
[GitHub] [helix] kaisun2000 commented on issue #1240: Investigate TestCrushAutoRebalance 200+ threads leaking due to @afterClass not invoked.
Posted by GitBox <gi...@apache.org>.
kaisun2000 commented on issue #1240:
URL: https://github.com/apache/helix/issues/1240#issuecomment-671788283
https://github.com/apache/helix/pull/1227 addresses this one.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org
[GitHub] [helix] kaisun2000 commented on issue #1240: Investigate TestCrushAutoRebalance 200+ threads leaking due to @afterClass not invoked.
Posted by GitBox <gi...@apache.org>.
kaisun2000 commented on issue #1240:
URL: https://github.com/apache/helix/issues/1240#issuecomment-671233838
After spending a lot of time testing, I found mvn 3.6.1 with current Testng combination has the following bug.
If some test method in a class use @Test(dependsOnMethod="blah"). If other methods without dependsOnMethod attribute will not be run. What is more, @afterClass of this class and all the base class won't run either.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org
[GitHub] [helix] kaisun2000 commented on issue #1240: Investigate TestCrushAutoRebalance 200+ threads leaking due to @afterClass not invoked.
Posted by GitBox <gi...@apache.org>.
kaisun2000 commented on issue #1240:
URL: https://github.com/apache/helix/issues/1240#issuecomment-670999643
Note, running `mvn test -Dtest=TestCrushAutoRebalance also invokes afterClass().`
invokes three blank testAddZone, testNodeFailure etc. Maybe this is the reason why afterClass() not invoked.
```
@Test()
public void testAddZone() throws Exception {
// TODO
}
@Test()
public void testAddNodes() throws Exception {
// TODO
}
@Test()
public void testNodeFailure() throws Exception {
// TODO
}
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org