You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by milamberspace <gi...@git.apache.org> on 2015/08/12 21:45:54 UTC
[GitHub] cloudstack pull request: [CS45] Add missing localization for some ...
GitHub user milamberspace opened a pull request:
https://github.com/apache/cloudstack/pull/687
[CS45] Add missing localization for some labels in Web UI
- on the zone configuration wizard for the "Next" button
- on templates, Shared, extratable and Dynamically Scalable
- Improve some French translations ("Téléverser" for "Upload")
- update French messages properties from transifex (4.5 branch)
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/milamberspace/cloudstack CS45_MissingSomesL10N
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cloudstack/pull/687.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #687
----
commit a8fa39bdf0278d3a791142fef34260c7cb14b03f
Author: Milamber <mi...@apache.org>
Date: 2015-08-12T19:43:38Z
[CS45] Add missing localization for some labels in Web UI
- on the zone configuration wizard for the "Next" button
- on templates, Shared, extratable and Dynamically Scalable
- Improve some French translations ("Téléverser" for "Upload")
- update French messages properties from transifex (4.5 branch)
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: [CS45] Add missing localization for some ...
Posted by milamberspace <gi...@git.apache.org>.
Github user milamberspace commented on the pull request:
https://github.com/apache/cloudstack/pull/687#issuecomment-131043213
@bhaisaab Thanks for LGTM (Daan too)
The PR for fix the master is here: (#686)
https://github.com/apache/cloudstack/pull/686
Need a second LGTM too
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: [CS45] Add missing localization for some ...
Posted by DaanHoogland <gi...@git.apache.org>.
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/687#issuecomment-130647516
travis timeout
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: [CS45] Add missing localization for some ...
Posted by remibergsma <gi...@git.apache.org>.
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/687#issuecomment-131221363
@bhaisaab Wrote a script to handle the merge and made it compatible with your 'git pr' workflow.
See https://github.com/schubergphilis/cloudstack-git-tree-manipulation/blob/master/git-pr
Put 'git-pr' script in $PATH (and disable/rename your 'pr' alias). I'm finalising the script based on feedback I got and will send a PR soon to add it to ACS repo.
Docs are being written here: https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=61311655
Let me know if it makes sense.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: [CS45] Add missing localization for some ...
Posted by bhaisaab <gi...@git.apache.org>.
Github user bhaisaab commented on the pull request:
https://github.com/apache/cloudstack/pull/687#issuecomment-131028291
LGTM.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: [CS45] Add missing localization for some ...
Posted by bhaisaab <gi...@git.apache.org>.
Github user bhaisaab commented on the pull request:
https://github.com/apache/cloudstack/pull/687#issuecomment-131030116
@DaanHoogland cool, will try that in future
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: [CS45] Add missing localization for some ...
Posted by milamberspace <gi...@git.apache.org>.
Github user milamberspace closed the pull request at:
https://github.com/apache/cloudstack/pull/687
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: [CS45] Add missing localization for some ...
Posted by bhaisaab <gi...@git.apache.org>.
Github user bhaisaab commented on the pull request:
https://github.com/apache/cloudstack/pull/687#issuecomment-131028521
@milamberspace thanks, merged on 4.5; since this is a non-master branch you'll have to close the PR manually. Also, do we want to port this to master?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: [CS45] Add missing localization for some ...
Posted by remibergsma <gi...@git.apache.org>.
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/687#issuecomment-131221933
@milamberspace Could you please close this PR as @bhaisaab applied the patch to 4.5. Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: [CS45] Add missing localization for some ...
Posted by DaanHoogland <gi...@git.apache.org>.
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/687#issuecomment-131029374
@bhaisaab if you merge, preserving the commit-ids github will close this PR regardless of the branch it was merged to.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---