[GitHub] maven-surefire pull request #143: maven-surefire-parser: add new method isEr...

[surli <gi...@git.apache.org>]

Github user surli commented on a diff in the pull request:

    https://github.com/apache/maven-surefire/pull/143#discussion_r138012247
  
    --- Diff: surefire-report-parser/src/main/java/org/apache/maven/plugins/surefire/report/TestSuiteXmlParser.java ---
    @@ -196,7 +196,8 @@ else if ( "failure".equals( qName ) )
                     }
                     else if ( "error".equals( qName ) )
                     {
    -                    testCase.setFailure( attributes.getValue( "message" ), attributes.getValue( "type" ) );
    +                    testCase.setFailure( attributes.getValue( "message" ), attributes.getValue( "type" ) )
    --- End diff --
    
    > If having an error, then failure and error are set both. Why?
    
    An error is a specific kind of failure: if I start to introduce error details, then I should also add error type, message, line, and I'll got every field of `ReportTestCase` duplicated. My purpose was to keep the field of `ReportTestCase` to report the information around the failure, but to be able to flag it as an error instead of a failure. 


---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org