You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@yunikorn.apache.org by GitBox <gi...@apache.org> on 2020/10/09 20:56:19 UTC

[GitHub] [incubator-yunikorn-core] yangwwei commented on pull request #211: [YUNIKORN-429] Set default logging level to INFO

yangwwei commented on pull request #211:
URL: https://github.com/apache/incubator-yunikorn-core/pull/211#issuecomment-706398769


   Hi @adamantal  Thanks for validating this, looks good. For the reservation/unreservation, we do a bunch of checks to make sure the reservation is only created on some valid nodes. You can try the following steps:
   - submit a pod and get it running
   - submit another pod that ask for more resources than what is available on the node, but less than the node total
   - wait for a few seconds (we have a reservation-delay)
   - check if reservation happens
   
   for the changes in this PR, I think they look good enough. Pls double check the reservation-related logs, if there is any missing things, we can track in a different JIRA.
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org