You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2020/09/29 22:56:35 UTC
[GitHub] [incubator-mxnet] leezu opened a new pull request #19254: Remove duplicate setup and teardown functions
leezu opened a new pull request #19254:
URL: https://github.com/apache/incubator-mxnet/pull/19254
faccd91071cc34ed0b3a192d3c7932441fe7e35e introduced a automatic pytest hooks for handling MXNET_MODULE_SEED adapted from https://github.com/dmlc/gluon-nlp/blob/917855b/conftest.py but didn't yet remove the existing seed handling via explicit setup and teardown functions.
This commit removes the explicit setup and teardown functions in favor of the
automatic pytest version, and thereby also ensures that the seed handling code
is not executed twice. As a side benefit, seed handling now works correctly even
if contributors forget to add the magic setup_module and teardown_module
imports in new test files.
If pytest is run with --capture=no (or -s shorthand), output of the module level
fixtures is shown to the user.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] szha merged pull request #19254: Remove duplicate setup and teardown functions
Posted by GitBox <gi...@apache.org>.
szha merged pull request #19254:
URL: https://github.com/apache/incubator-mxnet/pull/19254
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] leezu commented on pull request #19254: Remove duplicate setup and teardown functions
Posted by GitBox <gi...@apache.org>.
leezu commented on pull request #19254:
URL: https://github.com/apache/incubator-mxnet/pull/19254#issuecomment-706593561
@mxnet-bot run ci [miscellaneous]
```
[2020-10-10T00:53:29.773Z] [960/977] Building CXX object 3rdparty/mkldnn/src/cpu/CMakeFiles/dnnl_cpu.dir/cpu_reorder.cpp.o
[2020-10-10T00:53:50.333Z] Cannot contact mxnetlinux-cpu_cqe3ns49vo: java.lang.InterruptedException
[2020-10-10T01:10:43.825Z] wrapper script does not seem to be touching the log file in /home/jenkins_slave/workspace/build-cpu-clang10@tmp/durable-11bd7127
[2020-10-10T01:10:43.825Z] (JENKINS-48300: if on an extremely laggy filesystem, consider -Dorg.jenkinsci.plugins.durabletask.BourneShellScript.HEARTBEAT_CHECK_INTERVAL=86400)
script returned exit code -1
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] mxnet-bot commented on pull request #19254: Remove duplicate setup and teardown functions
Posted by GitBox <gi...@apache.org>.
mxnet-bot commented on pull request #19254:
URL: https://github.com/apache/incubator-mxnet/pull/19254#issuecomment-706593578
Jenkins CI successfully triggered : [miscellaneous]
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] mxnet-bot commented on pull request #19254: Remove duplicate setup and teardown functions
Posted by GitBox <gi...@apache.org>.
mxnet-bot commented on pull request #19254:
URL: https://github.com/apache/incubator-mxnet/pull/19254#issuecomment-701034627
Hey @leezu , Thanks for submitting the PR
All tests are already queued to run once. If tests fail, you can trigger one or more tests again with the following commands:
- To trigger all jobs: @mxnet-bot run ci [all]
- To trigger specific jobs: @mxnet-bot run ci [job1, job2]
***
**CI supported jobs**: [sanity, centos-cpu, edge, website, miscellaneous, windows-cpu, centos-gpu, windows-gpu, clang, unix-gpu, unix-cpu]
***
_Note_:
Only following 3 categories can trigger CI :PR Author, MXNet Committer, Jenkins Admin.
All CI tests must pass before the PR can be merged.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] leezu commented on pull request #19254: Remove duplicate setup and teardown functions
Posted by GitBox <gi...@apache.org>.
leezu commented on pull request #19254:
URL: https://github.com/apache/incubator-mxnet/pull/19254#issuecomment-706455564
@mxnet-bot run ci [miscellaneous]
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] mxnet-bot commented on pull request #19254: Remove duplicate setup and teardown functions
Posted by GitBox <gi...@apache.org>.
mxnet-bot commented on pull request #19254:
URL: https://github.com/apache/incubator-mxnet/pull/19254#issuecomment-706455581
Jenkins CI successfully triggered : [miscellaneous]
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org