You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Adar Dembo (Code Review)" <ge...@cloudera.org> on 2019/01/04 00:32:53 UTC
[kudu-CR] generic iterators-test: fix TestMerge when FLAGS num iters > 1
Hello Mike Percy,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/12155
to review the following change.
Change subject: generic_iterators-test: fix TestMerge when FLAGS_num_iters > 1
......................................................................
generic_iterators-test: fix TestMerge when FLAGS_num_iters > 1
And some assorted cleanup.
Change-Id: Ieb6c5a26e0274772c85c0202c78f906aed154915
---
M src/kudu/common/generic_iterators-test.cc
1 file changed, 34 insertions(+), 30 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/55/12155/1
--
To view, visit http://gerrit.cloudera.org:8080/12155
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ieb6c5a26e0274772c85c0202c78f906aed154915
Gerrit-Change-Number: 12155
Gerrit-PatchSet: 1
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
[kudu-CR] generic iterators-test: fix TestMerge when FLAGS num iters > 1
Posted by "Mike Percy (Code Review)" <ge...@cloudera.org>.
Mike Percy has posted comments on this change. ( http://gerrit.cloudera.org:8080/12155 )
Change subject: generic_iterators-test: fix TestMerge when FLAGS_num_iters > 1
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/12155
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ieb6c5a26e0274772c85c0202c78f906aed154915
Gerrit-Change-Number: 12155
Gerrit-PatchSet: 1
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Comment-Date: Fri, 04 Jan 2019 19:46:06 +0000
Gerrit-HasComments: No
[kudu-CR] generic iterators-test: fix TestMerge when FLAGS num iters > 1
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/12155 )
Change subject: generic_iterators-test: fix TestMerge when FLAGS_num_iters > 1
......................................................................
generic_iterators-test: fix TestMerge when FLAGS_num_iters > 1
And some assorted cleanup.
Change-Id: Ieb6c5a26e0274772c85c0202c78f906aed154915
Reviewed-on: http://gerrit.cloudera.org:8080/12155
Tested-by: Kudu Jenkins
Reviewed-by: Mike Percy <mp...@apache.org>
---
M src/kudu/common/generic_iterators-test.cc
1 file changed, 34 insertions(+), 30 deletions(-)
Approvals:
Kudu Jenkins: Verified
Mike Percy: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/12155
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ieb6c5a26e0274772c85c0202c78f906aed154915
Gerrit-Change-Number: 12155
Gerrit-PatchSet: 2
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mike Percy <mp...@apache.org>