[GitHub] [qpid-dispatch] jiridanek commented on a change in pull request #1536: DISPATCH-2336 Fix Dockerfile Ubuntu build

[GitBox <gi...@apache.org>]

jiridanek commented on a change in pull request #1536:
URL: https://github.com/apache/qpid-dispatch/pull/1536#discussion_r825969556



##########
File path: dockerfiles/Dockerfile-ubuntu
##########
@@ -16,14 +16,17 @@
 # specific language governing permissions and limitations
 # under the License.
 #
+
 # Copy this docker file to your local folder. Build the docker file like this - sudo docker build -t <username>/dispatch --file=Dockerfile-ubuntu . (don't miss the dot at the end)
 # To run it - sudo docker run -i -t <username>/dispatch (this will launch the dispatch router)
 
-# Gets the trusty Ubuntu from dockerhub
-FROM ubuntu:latest
+# Gets the Ubuntu from dockerhub
+FROM docker.io/library/ubuntu:focal

Review comment:
       I wanted to add `:focal` because of the `PYTHONPATH` hardcoded almost at the end. In newer ubuntu, there will be newer Python and things would break. So, focal.
   
   About `docker.io/library` I just wanted to be explicit. Podman and Docker have different search paths... (they both include the docker.io/library, though.
   
   > Explicit is better than implicit.
   https://peps.python.org/pep-0020/#the-zen-of-python
   
   I can of course undo this. IMO it is pretty much the same this way, or the way it was...




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org