You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2022/04/11 23:20:26 UTC

[GitHub] [tvm] mbs-octoml commented on a diff in pull request #10961: [CUDNN] Add partitioning support for conv2d and log_softmax

mbs-octoml commented on code in PR #10961:
URL: https://github.com/apache/tvm/pull/10961#discussion_r847810749


##########
python/tvm/relay/op/contrib/cudnn.py:
##########
@@ -50,6 +51,8 @@ def partition_for_cudnn(
     tvm.IRModule
         The partitioned module.
     """
+    if params:

Review Comment:
   Given it's a one liner never figured out why folks want to fold that into every partition function. Cargo culting?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org