[jira] [Commented] (FALCON-15) Secure Hadoop client interface

["Srikanth Sundarrajan (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/FALCON-15?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13678931#comment-13678931 ] 

Srikanth Sundarrajan commented on FALCON-15:
--------------------------------------------

Can we avoid assertion on exception messages, particularly those depending on external libraries. If those functions were to change with upgraded version, tests here might break. (HadoopClientFactoryTest)

@@ -111,10 +112,9 @@ public class LateDataHandler extends Configured implements Tool {
 
     public String detectChanges(Path file, Map<String, Long> map, Configuration conf)
         throws Exception {
-
         StringBuilder buffer = new StringBuilder();
-        BufferedReader in = new BufferedReader(new InputStreamReader(
-                file.getFileSystem(conf).open(file)));
+        FileSystem fileSystem = HadoopClientFactory.get().createFileSystem(file.toUri(), conf);

>> This fileSystem should be created as the the feed owner. Might break, if the feed owner hasn't given world readable privileges

Also applies to calls within in the same class
+    public long usage(Path inPath, Configuration conf) throws Exception {
 


                
> Secure Hadoop client interface
> ------------------------------
>
>                 Key: FALCON-15
>                 URL: https://issues.apache.org/jira/browse/FALCON-15
>             Project: Falcon
>          Issue Type: Sub-task
>            Reporter: Venkatesh Seetharam
>            Assignee: Venkatesh Seetharam
>              Labels: security
>         Attachments: FALCON-15.patch
>
>


--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira