You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@geode.apache.org by Anthony Baker <ab...@apache.org> on 2015/11/23 21:49:51 UTC
Re: Review Request 40571: GEODE-587: Include the lucence dependent
jars on the classpath
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40571/
-----------------------------------------------------------
(Updated Nov. 23, 2015, 8:49 p.m.)
Review request for geode, Mark Bretl and Dan Smith.
Changes
-------
Fixes the classpath to include lucene jars.
Summary (updated)
-----------------
GEODE-587: Include the lucence dependent jars on the classpath
Repository: geode
Description (updated)
-------
The gemfire-assembly build creates the runtime classpath. This is
a slight tweak to ensure the lucene jars are added to the classpath.
Diffs (updated)
-----
gemfire-assembly/build.gradle 75805878d8d5c990af316cbb69ecdf8b1559aea3
Diff: https://reviews.apache.org/r/40571/diff/
Testing
-------
Thanks,
Anthony Baker
Re: Review Request 40571: GEODE-587: Include the lucence dependent
jars on the classpath
Posted by Dan Smith <ds...@pivotal.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40571/#review107643
-----------------------------------------------------------
Ship it!
Ship It!
- Dan Smith
On Nov. 23, 2015, 8:49 p.m., Anthony Baker wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40571/
> -----------------------------------------------------------
>
> (Updated Nov. 23, 2015, 8:49 p.m.)
>
>
> Review request for geode, Mark Bretl and Dan Smith.
>
>
> Repository: geode
>
>
> Description
> -------
>
> The gemfire-assembly build creates the runtime classpath. This is
> a slight tweak to ensure the lucene jars are added to the classpath.
>
>
> Diffs
> -----
>
> gemfire-assembly/build.gradle 75805878d8d5c990af316cbb69ecdf8b1559aea3
>
> Diff: https://reviews.apache.org/r/40571/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Anthony Baker
>
>
Re: Review Request 40571: GEODE-587: Improve classpath generation
Posted by Dick Cavender <dc...@pivotal.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40571/#review107824
-----------------------------------------------------------
Ship it!
Ship It!
- Dick Cavender
On Nov. 24, 2015, 6:25 p.m., Anthony Baker wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40571/
> -----------------------------------------------------------
>
> (Updated Nov. 24, 2015, 6:25 p.m.)
>
>
> Review request for geode, Dick Cavender, Mark Bretl, and Dan Smith.
>
>
> Repository: geode
>
>
> Description
> -------
>
> Improve classpath generation for the *-dependencies jar files. All
> dependent projects are now automatically analyzed for matching jar
> names.
>
>
> Diffs
> -----
>
> gemfire-assembly/build.gradle 75805878d8d5c990af316cbb69ecdf8b1559aea3
>
> Diff: https://reviews.apache.org/r/40571/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Anthony Baker
>
>
Re: Review Request 40571: GEODE-587: Improve classpath generation
Posted by Anthony Baker <ab...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40571/
-----------------------------------------------------------
(Updated Nov. 24, 2015, 6:25 p.m.)
Review request for geode, Dick Cavender, Mark Bretl, and Dan Smith.
Changes
-------
Ok, last fix on this issue. Updated code to automatically scan dependent projects so we only have to add the jar names to the filter closure.
Summary (updated)
-----------------
GEODE-587: Improve classpath generation
Repository: geode
Description (updated)
-------
Improve classpath generation for the *-dependencies jar files. All
dependent projects are now automatically analyzed for matching jar
names.
Diffs (updated)
-----
gemfire-assembly/build.gradle 75805878d8d5c990af316cbb69ecdf8b1559aea3
Diff: https://reviews.apache.org/r/40571/diff/
Testing
-------
Thanks,
Anthony Baker