You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by James Peach <jp...@apache.org> on 2018/05/11 18:32:25 UTC

Review Request 67096: Added a `linux/devices` isolator skeleton.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67096/
-----------------------------------------------------------

Review request for mesos, Gilbert Song, Jason Lai, Jie Yu, and Zhitao Li.


Bugs: MESOS-8792
    https://issues.apache.org/jira/browse/MESOS-8792


Repository: mesos


Description
-------

Added the skeleton of a `linux/devices` isolator and wired it into
the build and the Mesos containerizer.


Diffs
-----

  src/CMakeLists.txt d4881318d6751fe1475521ecc2669f147c15c2c0 
  src/Makefile.am c08ac6e2f5deec4d05f59f71ff6c51382f216708 
  src/slave/containerizer/mesos/containerizer.cpp eac1d16f2388385fec04ff8f013ce0ebf4e97f0f 
  src/slave/containerizer/mesos/isolators/linux/devices.hpp PRE-CREATION 
  src/slave/containerizer/mesos/isolators/linux/devices.cpp PRE-CREATION 


Diff: https://reviews.apache.org/r/67096/diff/1/


Testing
-------

manual


Thanks,

James Peach


Re: Review Request 67096: Added a `linux/devices` isolator skeleton.

Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67096/#review202974
-----------------------------------------------------------


Ship it!




Ship It!

- Jie Yu


On May 11, 2018, 6:32 p.m., James Peach wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67096/
> -----------------------------------------------------------
> 
> (Updated May 11, 2018, 6:32 p.m.)
> 
> 
> Review request for mesos, Gilbert Song, Jason Lai, Jie Yu, and Zhitao Li.
> 
> 
> Bugs: MESOS-8792
>     https://issues.apache.org/jira/browse/MESOS-8792
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added the skeleton of a `linux/devices` isolator and wired it into
> the build and the Mesos containerizer.
> 
> 
> Diffs
> -----
> 
>   src/CMakeLists.txt d4881318d6751fe1475521ecc2669f147c15c2c0 
>   src/Makefile.am c08ac6e2f5deec4d05f59f71ff6c51382f216708 
>   src/slave/containerizer/mesos/containerizer.cpp eac1d16f2388385fec04ff8f013ce0ebf4e97f0f 
>   src/slave/containerizer/mesos/isolators/linux/devices.hpp PRE-CREATION 
>   src/slave/containerizer/mesos/isolators/linux/devices.cpp PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/67096/diff/1/
> 
> 
> Testing
> -------
> 
> manual
> 
> 
> Thanks,
> 
> James Peach
> 
>