[GitHub] [dolphinscheduler] EricGao888 commented on a diff in pull request #13303: [feat] Add type local turn on resource center by default

[GitBox <gi...@apache.org>]

EricGao888 commented on code in PR #13303:
URL: https://github.com/apache/dolphinscheduler/pull/13303#discussion_r1059630814


##########
dolphinscheduler-storage-plugin/dolphinscheduler-storage-hdfs/src/main/java/org/apache/dolphinscheduler/plugin/storage/hdfs/HdfsStorageOperator.java:
##########
@@ -77,17 +77,12 @@
 public class HdfsStorageOperator implements Closeable, StorageOperate {
 
     private static final Logger logger = LoggerFactory.getLogger(HdfsStorageOperator.class);
-    private String hdfsUser;
-    public static final String RM_HA_IDS = PropertyUtils.getString(Constants.YARN_RESOURCEMANAGER_HA_RM_IDS);
-    public static final String APP_ADDRESS = PropertyUtils.getString(Constants.YARN_APPLICATION_STATUS_ADDRESS);
-    public static final String JOB_HISTORY_ADDRESS = PropertyUtils.getString(Constants.YARN_JOB_HISTORY_STATUS_ADDRESS);
-    public static final int HADOOP_RESOURCE_MANAGER_HTTP_ADDRESS_PORT_VALUE =
-            PropertyUtils.getInt(Constants.HADOOP_RESOURCE_MANAGER_HTTPADDRESS_PORT, 8088);
+    private static HdfsStorageProperties hdfsProperties = new HdfsStorageProperties();

Review Comment:
   Could we avoid instantiating `HdfsStorageProperties` here and do it in the `init()` method? `init()` method is called in both constructors. If u want to use `hdfsProperties.getKerberosExpireTime()`, what about make `getKerberosExpireTime` static?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org