[GitHub] [trafficserver] bneradt commented on a diff in pull request #9136: Change the path for keylog_file on http2_flow_control autest

[GitBox <gi...@apache.org>]

bneradt commented on code in PR #9136:
URL: https://github.com/apache/trafficserver/pull/9136#discussion_r992949200


##########
tests/gold_tests/h2/http2_flow_control.test.py:
##########
@@ -107,7 +107,7 @@ def _configure_trafficserver(self):
             'proxy.config.ssl.server.private_key.path': f'{ts.Variables.SSLDir}',
             'proxy.config.ssl.client.verify.server.policy': 'PERMISSIVE',
             'proxy.config.dns.nameservers': '127.0.0.1:{0}'.format(self._dns.Variables.Port),
-            'proxy.config.ssl.keylog_file': os.path.join(Test.RunDirectory, 'tls_session_keys.txt'),
+            'proxy.config.ssl.keylog_file': '/tmp/tls_session_keys.txt',

Review Comment:
   A downside to this is that it won't be in the sandbox then. CI, for instance, won't have this in the artifacts directory on failure.  Can we instead put this in Traffic Server's log directory? (Like where diags.log is.) 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org