You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zookeeper.apache.org by pyx1990 <gi...@git.apache.org> on 2017/07/26 06:58:33 UTC
[GitHub] zookeeper pull request #318: ZOOKEEPER-2856 ZooKeeperSaslClient#respondToSer...
GitHub user pyx1990 opened a pull request:
https://github.com/apache/zookeeper/pull/318
ZOOKEEPER-2856 ZooKeeperSaslClient#respondToServer should log exception
See https://issues.apache.org/jira/browse/ZOOKEEPER-2856 for details.
When upstream like HBase call ZooKeeperSaslClient with security enabled, we sometimes get error in HBase logs like:
`SASL authentication failed using login context 'Client'.`
This error occures when getting SaslException in ZooKeeperSaslClient#respondToServer :
`catch (SaslException e) {`
`LOG.error("SASL authentication failed using login context '" +`
` this.getLoginContext() + "'.");`
`saslState = SaslState.FAILED;`
`gotLastPacket = true;`
` }`
This error makes user confused without explicit exception message. So I think we can add exception message to the log.
The patch uses parameterized logging to add the exception message to the log.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/pyx1990/zookeeper ZOOKEEPER-2856
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zookeeper/pull/318.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #318
----
commit 298a636acb2e1c7c09a0151ba6529aff101ea200
Author: panyuxuan <pa...@cmss.chinamobile.com>
Date: 2017-07-26T06:47:29Z
ZOOKEEPER-2856 ZooKeeperSaslClient#respondToServer should log exception
message of SaslException
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zookeeper pull request #318: ZOOKEEPER-2856 ZooKeeperSaslClient#respondToSer...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/zookeeper/pull/318
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zookeeper issue #318: ZOOKEEPER-2856 ZooKeeperSaslClient#respondToServer sho...
Posted by hanm <gi...@git.apache.org>.
Github user hanm commented on the issue:
https://github.com/apache/zookeeper/pull/318
LGTM. The failed test is a known issue and will be fixed by https://github.com/apache/zookeeper/pull/315.
Merging.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---