You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Meng Zhu <mz...@mesosphere.io> on 2019/07/23 01:46:09 UTC
Review Request 71139: Removed `quota_info` in the `GET_QUOTA`
authorization object.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71139/
-----------------------------------------------------------
Review request for mesos, Andrei Sekretenko and Benjamin Mahler.
Bugs: MESOS-9668
https://issues.apache.org/jira/browse/MESOS-9668
Repository: mesos
Description
-------
Currently, the `GET_QUOTA` authorizable action set both `value`
and `quota_info` fields. The `value` field is set due to
backward compatibility for the `GET_QUOTA_WITH_ROLE` action.
This patch makes the `GET_QUOTA` action only set the `value`
field with the role name. Since the `quota.QuotaInfo` field
is being deprecated, it is no longer set (the local authorizer
only looks at the `value` field, it is also probably the case
for any external authorizer modules).
Also refactored `QuotaHandler::status`.
Diffs
-----
include/mesos/authorizer/authorizer.proto d09c2341154a39dc74e304742920e01183f0cab1
src/authorizer/local/authorizer.cpp 85821c6b4877e319a2879b26492338b2cd903a6f
src/master/master.hpp 5c229c53f96dda6b30731017b8adbf57c9fc9f95
src/master/quota_handler.cpp 2a3ca5640c850ec8a8aca7abed45386b5b5e1125
Diff: https://reviews.apache.org/r/71139/diff/1/
Testing
-------
make check
Thanks,
Meng Zhu
Re: Review Request 71139: Removed `quota_info` in the `GET_QUOTA`
authorization object.
Posted by Benjamin Mahler <bm...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71139/#review216801
-----------------------------------------------------------
Ship it!
src/master/quota_handler.cpp
Lines 420-423 (original), 393-397 (patched)
<https://reviews.apache.org/r/71139/#comment304024>
Using a single index integer might read a bit easier?
- Benjamin Mahler
On July 23, 2019, 1:46 a.m., Meng Zhu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71139/
> -----------------------------------------------------------
>
> (Updated July 23, 2019, 1:46 a.m.)
>
>
> Review request for mesos, Andrei Sekretenko and Benjamin Mahler.
>
>
> Bugs: MESOS-9668
> https://issues.apache.org/jira/browse/MESOS-9668
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Currently, the `GET_QUOTA` authorizable action set both `value`
> and `quota_info` fields. The `value` field is set due to
> backward compatibility for the `GET_QUOTA_WITH_ROLE` action.
>
> This patch makes the `GET_QUOTA` action only set the `value`
> field with the role name. Since the `quota.QuotaInfo` field
> is being deprecated, it is no longer set (the local authorizer
> only looks at the `value` field, it is also probably the case
> for any external authorizer modules).
>
> Also refactored `QuotaHandler::status`.
>
>
> Diffs
> -----
>
> include/mesos/authorizer/authorizer.proto d09c2341154a39dc74e304742920e01183f0cab1
> src/authorizer/local/authorizer.cpp 85821c6b4877e319a2879b26492338b2cd903a6f
> src/master/master.hpp 5c229c53f96dda6b30731017b8adbf57c9fc9f95
> src/master/quota_handler.cpp 2a3ca5640c850ec8a8aca7abed45386b5b5e1125
>
>
> Diff: https://reviews.apache.org/r/71139/diff/1/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Meng Zhu
>
>
Re: Review Request 71139: Removed `quota_info` in the `GET_QUOTA`
authorization object.
Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71139/#review216797
-----------------------------------------------------------
Patch looks great!
Reviews applied: [71139]
Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers --disable-parallel-test-execution' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh
- Mesos Reviewbot
On July 23, 2019, 1:46 a.m., Meng Zhu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71139/
> -----------------------------------------------------------
>
> (Updated July 23, 2019, 1:46 a.m.)
>
>
> Review request for mesos, Andrei Sekretenko and Benjamin Mahler.
>
>
> Bugs: MESOS-9668
> https://issues.apache.org/jira/browse/MESOS-9668
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Currently, the `GET_QUOTA` authorizable action set both `value`
> and `quota_info` fields. The `value` field is set due to
> backward compatibility for the `GET_QUOTA_WITH_ROLE` action.
>
> This patch makes the `GET_QUOTA` action only set the `value`
> field with the role name. Since the `quota.QuotaInfo` field
> is being deprecated, it is no longer set (the local authorizer
> only looks at the `value` field, it is also probably the case
> for any external authorizer modules).
>
> Also refactored `QuotaHandler::status`.
>
>
> Diffs
> -----
>
> include/mesos/authorizer/authorizer.proto d09c2341154a39dc74e304742920e01183f0cab1
> src/authorizer/local/authorizer.cpp 85821c6b4877e319a2879b26492338b2cd903a6f
> src/master/master.hpp 5c229c53f96dda6b30731017b8adbf57c9fc9f95
> src/master/quota_handler.cpp 2a3ca5640c850ec8a8aca7abed45386b5b5e1125
>
>
> Diff: https://reviews.apache.org/r/71139/diff/1/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Meng Zhu
>
>