You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@qpid.apache.org by "Andrew Stitcher (Jira)" <ji...@apache.org> on 2020/06/16 20:58:00 UTC
[jira] [Commented] (PROTON-2229) pn_data_t initialization lead to
low performance
[ https://issues.apache.org/jira/browse/PROTON-2229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17137923#comment-17137923 ]
Andrew Stitcher commented on PROTON-2229:
-----------------------------------------
[~dengwanfa06] Could you give a few more details on the specific case where the performance is "80%" worse? This change was made to significantly improve some performance aspects (memory usage especially) and improving your case will only be possible if we can measure the case you care about.
> pn_data_t initialization lead to low performance
> ------------------------------------------------
>
> Key: PROTON-2229
> URL: https://issues.apache.org/jira/browse/PROTON-2229
> Project: Qpid Proton
> Issue Type: Bug
> Components: proton-c
> Affects Versions: proton-c-0.30.0
> Environment: x86_64 GNU/Linux
> Reporter: wanfa deng
> Assignee: Andrew Stitcher
> Priority: Major
> Labels: initialization, performance
> Original Estimate: 5h
> Remaining Estimate: 5h
>
> Recently I update qpid-proton from 0.28.0 to 0.30.0 version, and find massive produce performance fallen by 80%。
> Finally，I find this is caused by pn_data_t initialization。 In 0.28.0 version, it's like
> data->buf = pn_buffer(64);
> and in In 0.30.0 version, it's like
> data->buf = NULL;
>
> And when data->buf is initialized by NULL, in the following call flow,
> pn_data_put_binary->pni_data_intern_node->pn_buffer_memory->pn_buffer_defrag->pn_buffer_rotate,
> buf->start is more likely not equal to 0, this is leading to buffer rotate, and make the performance lower.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org