You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@felix.apache.org by "Carsten Ziegeler (JIRA)" <ji...@apache.org> on 2017/04/27 08:35:04 UTC
[jira] [Commented] (FELIX-5625) Do not fall back to bundle version
for the Export-Package header
[ https://issues.apache.org/jira/browse/FELIX-5625?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15986195#comment-15986195 ]
Carsten Ziegeler commented on FELIX-5625:
-----------------------------------------
We should not silently change the default behaviour - whether this is good or not.
I agree that using the project version as the default is not a good choice, but I think 0.0.0 is not good either.
If we change something, I suggest we simply fail the build if there is neither a version instruction nor a package export statement
> Do not fall back to bundle version for the Export-Package header
> ----------------------------------------------------------------
>
> Key: FELIX-5625
> URL: https://issues.apache.org/jira/browse/FELIX-5625
> Project: Felix
> Issue Type: Improvement
> Components: Maven Bundle Plugin
> Affects Versions: maven-bundle-plugin-3.3.0
> Reporter: Konrad Windszus
>
> Currently the maven-bundle-plugin will fall back to the bundle version as the exported version, if no package-info.java version annotations are found. That is not useful. Instead the default version (0.0.0) should be used if no explicit version is set on the bundle itself. This is also in line with the recommendation from Peter Kriens in http://www.mail-archive.com/osgi-dev@mail.osgi.org/msg01514.html.
> The according code responsible for falling back to the bundle version is https://github.com/apache/felix/blob/trunk/tools/maven-bundle-plugin/src/main/java/org/apache/felix/bundleplugin/BundlePlugin.java#L1765 together with https://github.com/bndtools/bnd/blob/7606e60e2dc5149f6fd35b0841f2735e9414b064/biz.aQute.bndlib/src/aQute/bnd/osgi/Analyzer.java#L2720.
> Compare also with the discussion in FELIX-5172.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)